Re: svn commit: r731967 - in /tomcat/trunk: ./ java/javax/servlet/ java/javax/servlet/annotation/ java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/a
Remy Maucherat wrote: > On Tue, 2009-01-06 at 22:17 +, Mark Thomas wrote: >> This is the public review. There have been quite a few changes since the >> public >> draft. > > And there might be more changes, esp with the async stuff. I was going to leave any implementation of that until last for that very reason :) Are you expecting another public draft after this one? Mark > > Rémy > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46339] Recursive tag files with JspFragment attributes fails
https://issues.apache.org/bugzilla/show_bug.cgi?id=46339 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Comment #4 from Mark Thomas 2009-01-07 01:16:01 PST --- Re-opening as a result of Kin-Man's comment. I'll add looking a this to my todo list but if you get there first with the patch that is fine too :) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[g...@vmgump]: Project tomcat-trunk (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 4 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk : Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.jsvc.tar.gz. -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build) Work ended in a state of : Failed Elapsed: 31 secs Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dtomcat-native.tar.gz=/srv/gump/public/workspace/tomcat-trunk/BUILDING.txt -Dcommons-daemon.jsvc.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/jsvc.tar.gz -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-07012009.jar -Djasper-jdt.jar=/srv/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar -Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-07012009.jar -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-07012009.jar [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/dist/junit-07012009.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-07012009.jar: /srv/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-07012009.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-07012009.jar - [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/classes [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/bin [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/conf [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/lib [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/webapps compile: [javac] Compiling 1070 source files to /srv/gump/public/workspace/tomcat-trunk/output/classes [javac] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:306: cannot find symbol [javac] symbol : variable VERSION_1_6 [javac] location: class org.eclipse.jdt.internal.compiler.impl.CompilerOptions [javac] CompilerOptions.VERSION_1_6); [javac] ^ [javac] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:309: cannot find symbol [javac] symbol : variable VERSION_1_7 [javac] location: class org.eclipse.jdt.internal.compiler.impl.CompilerOptions [javac] CompilerOptions.VERSION_1_7); [javac] ^ [javac] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:343: cannot find sym
DO NOT REPLY [Bug 46464] Serialisation issues in catalina
https://issues.apache.org/bugzilla/show_bug.cgi?id=46464 Filip Hanik changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Comment #7 from Filip Hanik 2009-01-07 07:19:22 PST --- If there is a real bug and not just code police, please let us know. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46464] Serialisation issues in catalina
https://issues.apache.org/bugzilla/show_bug.cgi?id=46464 --- Comment #8 from Sebb 2009-01-07 07:32:48 PST --- The code appears to be trying to modify the default Java serialization mechanism by providing readObject/writeObject methods. However these methods do not have the correct signature so they will not be used. The code does not document whether this was intentional or not. It seems to me it would be helpful for future maintainers to know what the intention was. So I think it was reasonable to flag the bug as enhancement, but I don't think it's reasonable to close it as invalid. If you don't wish to update the documentation of the class and/or rename the methods, then close as WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46339] Recursive tag files with JspFragment attributes fails
https://issues.apache.org/bugzilla/show_bug.cgi?id=46339 --- Comment #5 from Kin-Man Chung 2009-01-07 18:15:14 PST --- Created an attachment (id=23094) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23094) Patch based on glassfish source The patch is based on glassfish source, so the lines may be off. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46339] Recursive tag files with JspFragment attributes fails
https://issues.apache.org/bugzilla/show_bug.cgi?id=46339 --- Comment #6 from Konstantin Kolinko 2009-01-07 19:20:59 PST --- My reading of the spec (JSP 2.1, Final Release) is the following 1. The spec in many places uses "calling page" where "calling page or tag" is meant, and I think that it is only for brevity. The full sentence with "or tag" or "/tag" is usually written several lines below such a fragment. E.g. JSP.5.12.3 that Mark cited in comment 1, continues with "The container must then generate code to synchronize the page scope values for the variable in the tag file with the page scope equivalent in the calling page or tag file." Thus, the NESTED and AT_BEGIN variables update the page scope of the calling page or tag. It is said in JSP.5.12.3 (page "1-114"), in JSP.8.9 (page "1-186"), and elsewhere. That explains why the first patch that breaks TCK is incorrect. It might require a review by an editor to lessen such omissions, especially in the first sentences of a chapter and in tables. 2. Each JSP Fragment is associated with a JspContext of that page or tag in context of which it is defined. It is first mentioned in JSP.5.12.1 (page "1-113") and explained in detail in Part II in chapter "7. JSP Fragments" in description of package "javax.servlet.jsp.tagext" in Part II (pages "2-77" through "2-79"). I find it understandable, because the page author may reference any other variable of the page, and those are of no concern for the tag authors. This said, here is a solution for the recursive.tag file: redeclare the JSP fragment. That is, patching recursive.tag: - + + + + + -- A small thing that was bugging me was how this redeclaration will work in view of JSP.5.12.1 phrase that says "the results will be sent to the JspWriter of the JspContext associated with the JspFragment." and how it plays along with specifying an explicit Writer (var or varReader attributes of jsp:invoke action). That is: how invoking a fragment from a fragment will work if the writer for the outer fragment was specified explicitly, but not for the inner fragment, and the inner fragment belongs to the parent page? That is, will it bypass it and write to the page? The answer is that it would not. That is good. As implemented in Tomcat, the JspWriter in not stored in JspContext of the tag, but in the one of the page. Thus, specifying an explicit writer (context.pushBody() call) is delegated to the page, thus affecting all the tags. Thus, all fragments in the same response do write to the same writer. I do not know where in the specification it comes from (I think it should be written somewhere when defining a "JSP Context Wrapper"), but it works good. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
