DO NOT REPLY [Bug 39309] tomcat can't compile big jsp, hitting a compiler limit

2009-01-06 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=39309


Kamichetty Sunil Kumar  changed:

   What|Removed |Added

 CC||sunilkumar.kamiche...@wipro.
   ||com




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[g...@vmgump]: Project tomcat-trunk (in module tomcat-trunk) failed

2009-01-06 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation 
(for ...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.jsvc.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 26 secs
Command Line: /usr/lib/jvm/java-1.5.0-sun/bin/java -Djava.awt.headless=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/tomcat-trunk/BUILDING.txt 
-Dcommons-daemon.jsvc.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/jsvc.tar.gz
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-06012009.jar
 
-Djasper-jdt.jar=/srv/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar
 
-Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-06012009.jar
 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-06012009.jar
 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-1.5.0-sun/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/dist/junit-06012009.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-06012009.jar:
 
/srv/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-jdbc-06012009.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-06012009.jar
-
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/classes
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/bin
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/conf
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/lib
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/webapps

compile:
[javac] Compiling 1060 source files to 
/srv/gump/public/workspace/tomcat-trunk/output/classes
[javac] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:306:
 cannot find symbol
[javac] symbol  : variable VERSION_1_6
[javac] location: class 
org.eclipse.jdt.internal.compiler.impl.CompilerOptions
[javac]  CompilerOptions.VERSION_1_6);
[javac] ^
[javac] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:309:
 cannot find symbol
[javac] symbol  : variable VERSION_1_7
[javac] location: class 
org.eclipse.jdt.internal.compiler.impl.CompilerOptions
[javac]  CompilerOptions.VERSION_1_7);
[javac] ^
[javac] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:343:
 cannot find symbol
[javac] symbol  : variable VER

Re: Why are manager session tokens generated with MD5 by default?

2009-01-06 Thread Tim Funk 
Just turning the random number into a session id should sufficient and 
we can forget the MD5 altogether. But if someone figures out the seed 
and can guess future subsequent numbers, then they can guess future 
session ids.


By using a hashing algorithm - it makes it impossible to guess what 
numbers came from the random number generator.


If MD5 is so broken that a person can piece together a long enough 
sequence of numbers to figure out the seed - and guess future session 
ids - then we need to replace it.


But MD5 is not that broken.

-Tim


Minoo Hamilton wrote:
I'd like to re-raise an issue, since I didn't get too much of a 
response, originally.  Who can I talk to to lobby to get the default 
behavior of using MD5 session token hashes to change?  If you weren't 
aware of it, there has been a recent and highly-publicized breaking of 
SSL, by creating a rogue certificate authority, using collisions in 
MD5.  Creating collisions in MD5 are no longer a "highly theoretical" 
attack for potential session hijacking.  I'd very much like to see the 
default behavior of Tomcat  session tokens become more secure by default 
(possibly SHA-256).  I think the default hashing algorithm should not be 
a known broken and insecure one.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r731967 - in /tomcat/trunk: ./ java/javax/servlet/ java/javax/servlet/annotation/ java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apach

2009-01-06 Thread markt 
Author: markt
Date: Tue Jan  6 07:15:32 2009
New Revision: 731967

URL: http://svn.apache.org/viewvc?rev=731967&view=rev
Log:
First attempt at updating the javax.servlet package for the 3.0 spec
It compiles and runs but 99.9% of the implementation is stubbed out and marked 
with TODO SERVLET3

Added:
tomcat/trunk/java/javax/servlet/AsyncContext.java   (with props)
tomcat/trunk/java/javax/servlet/AsyncEvent.java   (with props)
tomcat/trunk/java/javax/servlet/AsyncListener.java   (with props)
tomcat/trunk/java/javax/servlet/DispatcherType.java   (with props)
tomcat/trunk/java/javax/servlet/SessionCookieConfig.java   (with props)
tomcat/trunk/java/javax/servlet/SessionTrackingMode.java   (with props)
tomcat/trunk/java/javax/servlet/annotation/
tomcat/trunk/java/javax/servlet/annotation/InitParam.java   (with props)
tomcat/trunk/java/javax/servlet/annotation/ServletFilter.java   (with props)
tomcat/trunk/java/javax/servlet/annotation/WebServlet.java   (with props)
tomcat/trunk/java/javax/servlet/annotation/WebServletContextListener.java   
(with props)
Modified:
tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt
tomcat/trunk/build.properties.default
tomcat/trunk/java/javax/servlet/ServletContext.java
tomcat/trunk/java/javax/servlet/ServletRequest.java
tomcat/trunk/java/javax/servlet/ServletRequestWrapper.java
tomcat/trunk/java/javax/servlet/http/Cookie.java
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
tomcat/trunk/java/org/apache/catalina/core/Constants.java
tomcat/trunk/java/org/apache/catalina/core/DummyRequest.java
tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java

Modified: tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt?rev=731967&r1=731966&r2=731967&view=diff
==
--- tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt (original)
+++ tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt Tue Jan  6 07:15:32 2009
@@ -22,8 +22,10 @@
 =
 
 1. Update trunk with new API from Servlet Spec 3.0 PR
+   - Done
 
 2. Provide NOOP implementations with TODO SRV3 markers so it will build
+   - Done
 
 3. Implement all the new Servlet 3 features
 

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=731967&r1=731966&r2=731967&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Tue Jan  6 07:15:32 2009
@@ -25,7 +25,7 @@
 # -
 
 # - Vesion Control Flags -
-version.major=6
+version.major=7
 version.minor=0
 version.build=0
 version.patch=0

Added: tomcat/trunk/java/javax/servlet/AsyncContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/AsyncContext.java?rev=731967&view=auto
==
--- tomcat/trunk/java/javax/servlet/AsyncContext.java (added)
+++ tomcat/trunk/java/javax/servlet/AsyncContext.java Tue Jan  6 07:15:32 2009
@@ -0,0 +1,33 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements.  See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License.  You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+package javax.servlet;
+
+/**
+ * @since 3.0
+ * $Id$
+ * TODO SERVLET3
+ */
+public interface AsyncContext {
+ServletRequest getRequest();
+ServletResponse getResponse();
+boolean hasOriginalRequestAndResponse();
+void forward();
+void forward(String path);
+void forward(ServletContext context, String path);
+void complete();
+void start(Runnable run);
+}

Propchange: tomcat/trunk/java/javax/servlet/AsyncContext.java
--
svn:eol-style = native

Propchange: tomcat/trunk/java/javax/servlet/AsyncContext.java
-

svn commit: r731974 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-01-06 Thread remm 
Author: remm
Date: Tue Jan  6 07:33:11 2009
New Revision: 731974

URL: http://svn.apache.org/viewvc?rev=731974&view=rev
Log:
- Votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=731974&r1=731973&r2=731974&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jan  6 07:33:11 2009
@@ -222,7 +222,7 @@
   the JDBCRealm is invalid.
   Based on a patch by Owen Jacobson
   http://svn.apache.org/viewvc?rev=729809&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46261
@@ -247,20 +247,21 @@
 
 * Print user friendly message when attempting to shutdown and shutdown port is 
disabled
   http://svn.apache.org/viewvc?rev=730178&view=rev
-  +1: fhanik
+  +1: fhanik, remm
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36923
   If EL is disabled, treat it as template text
   http://svn.apache.org/viewvc?rev=730590&view=rev
   +1: markt
+   0: remm (needs TCK testing)
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46462
   Limit package test to just the o.a.jsp package to allow use of packages such
   as o.a.jspwiki
   http://svn.apache.org/viewvc?rev=730694&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37458
@@ -274,10 +275,11 @@
   Use jar url and tag file path to uniquely ID a tag file to prevent naming
   clashes
   +1: markt
-  -1: 
+  -1: remm (e.printStackTrace in the patch, and maybe usage of URL constructs 
which could lead to issues
+when not filesystem based; also needs TCK testing)
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37515
   Add options for 1.6 and 1.7 source and target to JDT compiler
   http://svn.apache.org/viewvc?rev=731773&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r731974 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-01-06 Thread Mark Thomas 
r...@apache.org wrote:
>  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36923
>If EL is disabled, treat it as template text
>http://svn.apache.org/viewvc?rev=730590&view=rev
>+1: markt
> +   0: remm (needs TCK testing)
The TCK passes for me.

>  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37458
> @@ -274,10 +275,11 @@
>Use jar url and tag file path to uniquely ID a tag file to prevent naming
>clashes
>+1: markt
> -  -1: 
> +  -1: remm (e.printStackTrace in the patch, and maybe usage of URL 
> constructs which could lead to issues
> +when not filesystem based; also needs TCK testing)
Sorry - I'll fix the exception handling.
The TCK passes for me.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Why are manager session tokens generated with MD5 by default?

2009-01-06 Thread Preston L. Bannister 
First, note that any session-id provides only the flimsiest sort of
"security". Proper authentication was described a long time ago:

Needham, Roger; Schroeder, Michael (December 1978), "Using encryption
for authentication in large networks of computers.", *Communications of the
ACM* *21* (12): 993-999,
doi
:10.1145/359657.359659 

When first reading up on security in the mid-1980's, I came across a series
of papers from Xerox PARC. I *think* this is one, though I do not have a
copy. The principle of using a "nonce" and a "digest" date back about this
far. The story is too long to write here. Might do a write up later.

There *is* a question worth asking here. Is the random number generator used
to generate session id's easily guessable? If so the applying a MD5 (or any
other hash function) may only make an attack a little more expensive. If the
random number generator used is decent and properly seeded, then (strictly
speaking) we do not need the hash function. Hashing the pseudo-random data
adds a little insurance - but only that. If flimsy security is good enough
(and sometimes it is) then session id's are good enough.

Changing the hash function is not going to make a significant difference.


On Tue, Jan 6, 2009 at 5:02 AM, Tim Funk  wrote:

> Just turning the random number into a session id should sufficient and we
> can forget the MD5 altogether. But if someone figures out the seed and can
> guess future subsequent numbers, then they can guess future session ids.
>
> By using a hashing algorithm - it makes it impossible to guess what numbers
> came from the random number generator.
>
> If MD5 is so broken that a person can piece together a long enough sequence
> of numbers to figure out the seed - and guess future session ids - then we
> need to replace it.
>
> But MD5 is not that broken.
>
> -Tim
>
>
> Minoo Hamilton wrote:
>
>> I'd like to re-raise an issue, since I didn't get too much of a response,
>> originally.  Who can I talk to to lobby to get the default behavior of using
>> MD5 session token hashes to change?  If you weren't aware of it, there has
>> been a recent and highly-publicized breaking of SSL, by creating a rogue
>> certificate authority, using collisions in MD5.  Creating collisions in MD5
>> are no longer a "highly theoretical" attack for potential session hijacking.
>>  I'd very much like to see the default behavior of Tomcat  session tokens
>> become more secure by default (possibly SHA-256).  I think the default
>> hashing algorithm should not be a known broken and insecure one.
>>
>

Re: svn commit: r731974 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-01-06 Thread Remy Maucherat 
On Tue, 2009-01-06 at 18:19 +, Mark Thomas wrote:
> Sorry - I'll fix the exception handling.
> The TCK passes for me.

Then I suppose it is ok. The new URL that is constructed is only used as
a String, right, not to do any actual reading ?

Rémy



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r731967 - in /tomcat/trunk: ./ java/javax/servlet/ java/javax/servlet/annotation/ java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/a

2009-01-06 Thread David Jencks 

cf 
https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec

Is there a new draft of 3.0 or is this for the first public draft?

thanks
david jencks


On Jan 6, 2009, at 7:15 AM, ma...@apache.org wrote:


Author: markt
Date: Tue Jan  6 07:15:32 2009
New Revision: 731967

URL: http://svn.apache.org/viewvc?rev=731967&view=rev
Log:
First attempt at updating the javax.servlet package for the 3.0 spec
It compiles and runs but 99.9% of the implementation is stubbed out  
and marked with TODO SERVLET3


Added:
   tomcat/trunk/java/javax/servlet/AsyncContext.java   (with props)
   tomcat/trunk/java/javax/servlet/AsyncEvent.java   (with props)
   tomcat/trunk/java/javax/servlet/AsyncListener.java   (with props)
   tomcat/trunk/java/javax/servlet/DispatcherType.java   (with props)
   tomcat/trunk/java/javax/servlet/SessionCookieConfig.java   (with  
props)
   tomcat/trunk/java/javax/servlet/SessionTrackingMode.java   (with  
props)

   tomcat/trunk/java/javax/servlet/annotation/
   tomcat/trunk/java/javax/servlet/annotation/InitParam.java   (with  
props)
   tomcat/trunk/java/javax/servlet/annotation/ServletFilter.java
(with props)
   tomcat/trunk/java/javax/servlet/annotation/WebServlet.java
(with props)
   tomcat/trunk/java/javax/servlet/annotation/ 
WebServletContextListener.java   (with props)

Modified:
   tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt
   tomcat/trunk/build.properties.default
   tomcat/trunk/java/javax/servlet/ServletContext.java
   tomcat/trunk/java/javax/servlet/ServletRequest.java
   tomcat/trunk/java/javax/servlet/ServletRequestWrapper.java
   tomcat/trunk/java/javax/servlet/http/Cookie.java
   tomcat/trunk/java/org/apache/catalina/connector/Request.java
   tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java
   tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
   tomcat/trunk/java/org/apache/catalina/core/ 
ApplicationContextFacade.java

   tomcat/trunk/java/org/apache/catalina/core/Constants.java
   tomcat/trunk/java/org/apache/catalina/core/DummyRequest.java
   tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java

Modified: tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt?rev=731967&r1=731966&r2=731967&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==

--- tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt (original)
+++ tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt Tue Jan  6 07:15:32 2009
@@ -22,8 +22,10 @@
=

1. Update trunk with new API from Servlet Spec 3.0 PR
+   - Done

2. Provide NOOP implementations with TODO SRV3 markers so it will  
build

+   - Done

3. Implement all the new Servlet 3 features


Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=731967&r1=731966&r2=731967&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==

--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Tue Jan  6 07:15:32 2009
@@ -25,7 +25,7 @@
#  
-


# - Vesion Control Flags -
-version.major=6
+version.major=7
version.minor=0
version.build=0
version.patch=0

Added: tomcat/trunk/java/javax/servlet/AsyncContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/AsyncContext.java?rev=731967&view=auto
= 
= 
= 
= 
= 
= 
= 
= 
==

--- tomcat/trunk/java/javax/servlet/AsyncContext.java (added)
+++ tomcat/trunk/java/javax/servlet/AsyncContext.java Tue Jan  6  
07:15:32 2009

@@ -0,0 +1,33 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements.  See the NOTICE file distributed  
with

+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License,  
Version 2.0
+* (the "License"); you may not use this file except in compliance  
with

+* the License.  You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or  
implied.

+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+package javax.servlet;
+
+/**
+ * @since 3.0
+ * $Id$
+ * TODO SERVLET3
+ */
+public interface AsyncContext {
+ServletRequest getRequest();
+ServletResponse getResponse();
+boolean hasOriginalRequestAndResponse();
+void forward();
+void forward(String path);
+void forward(ServletContext context, String path);
+void complete();
+

Re: svn commit: r731967 - in /tomcat/trunk: ./ java/javax/servlet/ java/javax/servlet/annotation/ java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/a

2009-01-06 Thread Mark Thomas 
David Jencks wrote:
> cf
> https://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-servlet_3.0_spec

Of course. I should have thought of that. Have you done any implementation or
were you waiting for Tomcat 7?

> Is there a new draft of 3.0 or is this for the first public draft?
This is the public review. There have been quite a few changes since the public
draft.

There is only a week or so of the month long review period left.

Mark

> 
> thanks
> david jencks
> 
> 
> On Jan 6, 2009, at 7:15 AM, ma...@apache.org wrote:
> 
>> Author: markt
>> Date: Tue Jan  6 07:15:32 2009
>> New Revision: 731967
>>
>> URL: http://svn.apache.org/viewvc?rev=731967&view=rev
>> Log:
>> First attempt at updating the javax.servlet package for the 3.0 spec
>> It compiles and runs but 99.9% of the implementation is stubbed out
>> and marked with TODO SERVLET3
>>
>> Added:
>>tomcat/trunk/java/javax/servlet/AsyncContext.java   (with props)
>>tomcat/trunk/java/javax/servlet/AsyncEvent.java   (with props)
>>tomcat/trunk/java/javax/servlet/AsyncListener.java   (with props)
>>tomcat/trunk/java/javax/servlet/DispatcherType.java   (with props)
>>tomcat/trunk/java/javax/servlet/SessionCookieConfig.java   (with
>> props)
>>tomcat/trunk/java/javax/servlet/SessionTrackingMode.java   (with
>> props)
>>tomcat/trunk/java/javax/servlet/annotation/
>>tomcat/trunk/java/javax/servlet/annotation/InitParam.java   (with
>> props)
>>tomcat/trunk/java/javax/servlet/annotation/ServletFilter.java  
>> (with props)
>>tomcat/trunk/java/javax/servlet/annotation/WebServlet.java   (with
>> props)
>>   
>> tomcat/trunk/java/javax/servlet/annotation/WebServletContextListener.java  
>> (with props)
>> Modified:
>>tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt
>>tomcat/trunk/build.properties.default
>>tomcat/trunk/java/javax/servlet/ServletContext.java
>>tomcat/trunk/java/javax/servlet/ServletRequest.java
>>tomcat/trunk/java/javax/servlet/ServletRequestWrapper.java
>>tomcat/trunk/java/javax/servlet/http/Cookie.java
>>tomcat/trunk/java/org/apache/catalina/connector/Request.java
>>tomcat/trunk/java/org/apache/catalina/connector/RequestFacade.java
>>tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
>>   
>> tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java
>>tomcat/trunk/java/org/apache/catalina/core/Constants.java
>>tomcat/trunk/java/org/apache/catalina/core/DummyRequest.java
>>tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
>>
>> Modified: tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt?rev=731967&r1=731966&r2=731967&view=diff
>>
>> ==
>>
>> --- tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt (original)
>> +++ tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt Tue Jan  6 07:15:32 2009
>> @@ -22,8 +22,10 @@
>> =
>>
>> 1. Update trunk with new API from Servlet Spec 3.0 PR
>> +   - Done
>>
>> 2. Provide NOOP implementations with TODO SRV3 markers so it will build
>> +   - Done
>>
>> 3. Implement all the new Servlet 3 features
>>
>>
>> Modified: tomcat/trunk/build.properties.default
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=731967&r1=731966&r2=731967&view=diff
>>
>> ==
>>
>> --- tomcat/trunk/build.properties.default (original)
>> +++ tomcat/trunk/build.properties.default Tue Jan  6 07:15:32 2009
>> @@ -25,7 +25,7 @@
>> #
>> -
>>
>>
>> # - Vesion Control Flags -
>> -version.major=6
>> +version.major=7
>> version.minor=0
>> version.build=0
>> version.patch=0
>>
>> Added: tomcat/trunk/java/javax/servlet/AsyncContext.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/AsyncContext.java?rev=731967&view=auto
>>
>> ==
>>
>> --- tomcat/trunk/java/javax/servlet/AsyncContext.java (added)
>> +++ tomcat/trunk/java/javax/servlet/AsyncContext.java Tue Jan  6
>> 07:15:32 2009
>> @@ -0,0 +1,33 @@
>> +/*
>> +* Licensed to the Apache Software Foundation (ASF) under one or more
>> +* contributor license agreements.  See the NOTICE file distributed with
>> +* this work for additional information regarding copyright ownership.
>> +* The ASF licenses this file to You under the Apache License, Version
>> 2.0
>> +* (the "License"); you may not use this file except in compliance with
>> +* the License.  You may obtain a copy of the License at
>> +*
>> +* http://www.apache.org/licenses/LICENSE-2.0
>> +*
>> +* Unless required by applicable law or agreed to in writing, software
>> +* distributed under the License is distributed on an "AS IS" BASIS,
>> +* WITHOUT WARR

Re: svn commit: r731967 - in /tomcat/trunk: ./ java/javax/servlet/ java/javax/servlet/annotation/ java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/a

2009-01-06 Thread Remy Maucherat 
On Tue, 2009-01-06 at 22:17 +, Mark Thomas wrote:
> This is the public review. There have been quite a few changes since the 
> public
> draft.

And there might be more changes, esp with the async stuff.

Rémy



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 46339] Recursive tag files with JspFragment attributes fails

2009-01-06 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=46339


Kin-Man Chung  changed:

   What|Removed |Added

 CC||kin-man.ch...@sun.com




--- Comment #3 from Kin-Man Chung   2009-01-06 17:56:52 
PST ---
The proposed patch to synchronize tag variables to the outermost page context
will work for this program, but will fail in other cases.  Consider the case
where recursive.tag invokes foo.tag, passing another fragment.  It would be
wrong to synchronize the variables in foo.tag with the outermost page context
in this case, because that fragment is defined in foo.tag, and not index.jsp.

To fix this bug, the variable needs to be synchronized with the page context
that the fragment is created, before the fragment is invoked.  I propose to add
a parameter to org.apache.jasper.runtime.JspContextWrapper.syncBeforeInvoke().

/**
 * Synchronize variables before fragment invokation
 * @param jspContext The Jsp context of the fragment
 */
public void syncBeforeInvoke(JspContext jspContext) {
copyTagToPageScope(jspContext, VariableInfo.NESTED);
copyTagToPageScope(jspContext, VariableInfo.AT_BEGIN);
}

I think we can safely leave the rest of JspContextWrapper the way it is.

Of course, Generator needs to be modified to get the JspContext from the
fragment and pass it to syncBeforeInvoke().

I'll submit a patch when I get around to it.  :-)

It would be nice for the spec to clarify this.  JSP.8.9.1 and Table JSP.8-6
will need to be updated.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 46464] Serialisation issues in catalina

2009-01-06 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=46464


Filip Hanik  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Comment #5 from Filip Hanik   2009-01-06 18:50:48 PST ---
Externalizable supersedes Serializable


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 46464] Serialisation issues in catalina

2009-01-06 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=46464


Sebb  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |




--- Comment #6 from Sebb   2009-01-06 19:05:48 PST ---
StandardSession does not implement Externalizable.

Besides, it is still very confusing to have methods which appear to implement
the Serializable mechanism but don't.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org