May Chun Chew/FEA/PEC is out of the office.
I will be out of the office starting 12/22/2008 and will not return until 12/29/2008. I do not have email access during this period. I am Contactable at (65)97876648. For any urgent matters, pls contact my colleagues, Richard Seng(richard.s...@appliedbiosystems.com at 63629293) and YY Wong at email: yoke.yuen.w...@appliedbiosystems.com. at 63629428. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 44705] Tomcat 5.5.26 - cookie with colon in name is parsed incorrectly
https://issues.apache.org/bugzilla/show_bug.cgi?id=44705 --- Comment #9 from David Karnok 2008-12-22 01:27:40 PST --- I have also issues with the new cookie parsing. In my case, a load balanced Tomcat 5.5.26 application configured to use AJP causes the JSESSIONID cookie to have the host and port number attached to it: JSESSIONID=A54351F6255622340BCCB76397C80A84.server01:8080 Unfortunately, this is now an illegal cookie and any application running on it experiences strange session recreation issues. Is there a way to format the session cookie differently? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41260] [Contribution] WebAppLoader and DirContext implementations for handling with expanded webapp during development
https://issues.apache.org/bugzilla/show_bug.cgi?id=41260 --- Comment #6 from quartz 2008-12-22 07:24:04 PST --- This is quite incomplete: a) can one can set a jars folder? This is unclear. One would have to set ALL jars 1 by 1 manually, instead of pointing to a dir other than web-inf/lib where the jars are discovered. Maybe it is supported but not indicated. b) are the path elements are absolute or relative to the docbase? c) the paths given ARE NOT overriding the content of web-inf/lib jars. This makes the added feature useless in the context of debugging/patching a .war or a .jar in the regular classpath. We need a kind of "prepend" to override the .war, (or any of web-inf/classes and web-inf/lib/*.jar). Note: According to the javadoc, the org.apache.naming.resources.VirtualDirContext is only required if you need .tld to be loaded externally too. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41281] provide a property to the wepapp loader classloader to pick classes from more than web-inf/classes location
https://issues.apache.org/bugzilla/show_bug.cgi?id=41281 --- Comment #3 from quartz 2008-12-22 07:26:15 PST --- This is quite incomplete: a) can one can set a jars folder? This is unclear. One would have to set ALL jars 1 by 1 manually, instead of pointing to a dir other than web-inf/lib where the jars are discovered. Maybe it is supported but not indicated. b) are the path elements are absolute or relative to the docbase? c) the paths given ARE NOT overriding the content of web-inf/lib jars. This makes the added feature useless in the context of debugging/patching a .war or a .jar in the regular classpath. We need a kind of "prepend" to override the .war, (or any of web-inf/classes and web-inf/lib/*.jar). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46408] Invalid cast in SecurityUtil
https://issues.apache.org/bugzilla/show_bug.cgi?id=46408 Kazimierz Pogoda changed: What|Removed |Added CC||hsh...@gmail.com --- Comment #2 from Kazimierz Pogoda 2008-12-22 11:41:53 PST --- It seems that tomcats 5.5.x suffer from the same issue. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r728768 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java
Author: markt
Date: Mon Dec 22 12:45:07 2008
New Revision: 728768
URL: http://svn.apache.org/viewvc?rev=728768&view=rev
Log:
Fix non-performance aspects of
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304
Should use Principal when calling doFilterEvent
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java
Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java?rev=728768&r1=728767&r2=728768&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterChain.java Mon
Dec 22 12:45:07 2008
@@ -408,8 +408,8 @@
ev.getHttpServletRequest().getUserPrincipal();
Object[] args = new Object[]{ev, this};
-SecurityUtil.doAsPrivilege
-("doFilterEvent", (Filter) filter, cometClassType,
args);
+SecurityUtil.doAsPrivilege("doFilterEvent", filter,
+cometClassType, args, principal);
args = null;
} else {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r728770 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Mon Dec 22 12:47:16 2008 New Revision: 728770 URL: http://svn.apache.org/viewvc?rev=728770&view=rev Log: Propose fix for 46304 (excluding performance issues) Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=728770&r1=728769&r2=728770&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Dec 22 12:47:16 2008 @@ -263,3 +263,9 @@ +1: markt -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46304 + Excludes performance issues + Use Principal when calling doFilterEvent() + http://svn.apache.org/viewvc?rev=728768&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304 --- Comment #1 from Mark Thomas 2008-12-22 12:49:01 PST --- I have fixed the internalDoFilterEvent() oart if this issue in trunk and proposed it for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r728776 - /tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java
Author: markt
Date: Mon Dec 22 13:12:27 2008
New Revision: 728776
URL: http://svn.apache.org/viewvc?rev=728776&view=rev
Log:
Fix performance aspects of 46304.
Note it is possible (depending on connector config) to have a servlet/filter
responding to comet and non-comet events - hence why the array used in the
methods cache has been extended.
Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java
Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java?rev=728776&r1=728775&r2=728776&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java (original)
+++ tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java Mon Dec 22
13:12:27 2008
@@ -52,11 +52,15 @@
private final static int INIT= 0;
private final static int SERVICE = 1;
private final static int DOFILTER = 1;
-private final static int DESTROY = 2;
+private final static int EVENT = 2;
+private final static int DOFILTEREVENT = 2;
+private final static int DESTROY = 3;
private final static String INIT_METHOD = "init";
private final static String DOFILTER_METHOD = "doFilter";
private final static String SERVICE_METHOD = "service";
+private final static String EVENT_METHOD = "event";
+private final static String DOFILTEREVENT_METHOD = "doFilterEvent";
private final static String DESTROY_METHOD = "destroy";
/**
@@ -346,6 +350,12 @@
} else if (methodName.equalsIgnoreCase(DOFILTER_METHOD)
&& methodsCache[DOFILTER] != null){
return methodsCache[DOFILTER];
+} else if (methodName.equalsIgnoreCase(EVENT_METHOD)
+&& methodsCache[EVENT] != null){
+return methodsCache[EVENT];
+} else if (methodName.equalsIgnoreCase(DOFILTEREVENT_METHOD)
+&& methodsCache[DOFILTEREVENT] != null){
+return methodsCache[DOFILTEREVENT];
}
return null;
}
@@ -368,7 +378,7 @@
throws Exception{
if ( methodsCache == null){
-methodsCache = new Method[3];
+methodsCache = new Method[4];
}
Method method =
@@ -382,6 +392,10 @@
methodsCache[SERVICE] = method;
} else if (methodName.equalsIgnoreCase(DOFILTER_METHOD)){
methodsCache[DOFILTER] = method;
+} else if (methodName.equalsIgnoreCase(EVENT_METHOD)){
+methodsCache[EVENT] = method;
+} else if (methodName.equalsIgnoreCase(DOFILTEREVENT_METHOD)){
+methodsCache[DOFILTEREVENT] = method;
}
objectCache.put(targetObject, methodsCache );
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304 --- Comment #2 from Mark Thomas 2008-12-22 13:13:08 PST --- I've fixed the performance issues in trunk. I do not intend to propose this for back port - it will be included with Tomcat 7. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r728777 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Mon Dec 22 13:14:52 2008 New Revision: 728777 URL: http://svn.apache.org/viewvc?rev=728777&view=rev Log: Propose fix for 46408 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=728777&r1=728776&r2=728777&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Mon Dec 22 13:14:52 2008 @@ -141,3 +141,9 @@ http://svn.apache.org/viewvc?view=rev&revision=708160 +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46408 + Correct potential invalid cast + http://svn.apache.org/viewvc?rev=728032&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46408] Invalid cast in SecurityUtil
https://issues.apache.org/bugzilla/show_bug.cgi?id=46408 --- Comment #3 from Mark Thomas 2008-12-22 13:14:57 PST --- I've proposed the same fix for 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r728806 - in /tomcat/trunk/modules/jdbc-pool: ./ java/org/apache/tomcat/jdbc/pool/ test/org/apache/tomcat/jdbc/test/
Author: fhanik
Date: Mon Dec 22 14:11:41 2008
New Revision: 728806
URL: http://svn.apache.org/viewvc?rev=728806&view=rev
Log:
Implemented a way to get a delegate using standard APIs rather than custom
handling
Added:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestGetConnection.java
Modified:
tomcat/trunk/modules/jdbc-pool/.classpath
tomcat/trunk/modules/jdbc-pool/build.xml
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java
Modified: tomcat/trunk/modules/jdbc-pool/.classpath
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/.classpath?rev=728806&r1=728805&r2=728806&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/.classpath (original)
+++ tomcat/trunk/modules/jdbc-pool/.classpath Mon Dec 22 14:11:41 2008
@@ -2,10 +2,10 @@
-
+
Modified: tomcat/trunk/modules/jdbc-pool/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=728806&r1=728805&r2=728806&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/build.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/build.xml Mon Dec 22 14:11:41 2008
@@ -23,7 +23,7 @@
-
+
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=728806&r1=728805&r2=728806&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Mon Dec 22 14:11:41 2008
@@ -248,7 +248,7 @@
public Constructor getProxyConstructor() throws NoSuchMethodException {
//cache the constructor
if (proxyClassConstructor == null ) {
-Class proxyClass =
Proxy.getProxyClass(ConnectionPool.class.getClassLoader(), new Class[]
{java.sql.Connection.class});
+Class proxyClass =
Proxy.getProxyClass(ConnectionPool.class.getClassLoader(), new Class[]
{java.sql.Connection.class,javax.sql.PooledConnection.class});
proxyClassConstructor = proxyClass.getConstructor(new Class[] {
InvocationHandler.class });
}
return proxyClassConstructor;
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java?rev=728806&r1=728805&r2=728806&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
Mon Dec 22 14:11:41 2008
@@ -29,9 +29,10 @@
* @version 1.0
*/
public abstract class JdbcInterceptor implements InvocationHandler {
-public static final String CLOSE_VAL = "close";
-public static final String TOSTRING_VAL = "toString";
-public static final String ISCLOSED_VAL = "isClosed";
+public static final String CLOSE_VAL = "close";
+public static final String TOSTRING_VAL = "toString";
+public static final String ISCLOSED_VAL = "isClosed";
+public static final String GETCONNECTION_VAL = "getConnection";
protected Map properties = null;
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java?rev=728806&r1=728805&r2=728806&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java
Mon Dec 22 14:11:41 2008
@@ -80,6 +80,8 @@
return null;
} else if (compare(TOSTRING_VAL,method)) {
return this.toString();
+} else if (compare(GETCONNECTION_VAL,method) && connection!=null) {
+return connection.getConnection();
}
if (isClosed()) throw new SQLException("Connection has already been
closed.");
return method.invoke(connection.getConnection(),args);
Added:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestGetConnection.java
URL:
http://svn.ap
svn commit: r728848 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml sign.sh
Author: fhanik Date: Mon Dec 22 18:16:28 2008 New Revision: 728848 URL: http://svn.apache.org/viewvc?rev=728848&view=rev Log: update version Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml tomcat/trunk/modules/jdbc-pool/sign.sh Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=728848&r1=728847&r2=728848&view=diff == --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original) +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Mon Dec 22 18:16:28 2008 @@ -624,7 +624,17 @@ - + +Connection pools create wrappers around the actual connection in order to properly pool them. + We also create interceptors in these wrappers to be able to perform certain functions. + If there is a need to retrieve the actual connection, one can do so using the javax.sql.PooledConnection + interface. + + Connection con = datasource.getConnection(); + Connection actual = ((javax.sql.PooledConnection)con).getConnection(); + + + Modified: tomcat/trunk/modules/jdbc-pool/sign.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/sign.sh?rev=728848&r1=728847&r2=728848&view=diff == --- tomcat/trunk/modules/jdbc-pool/sign.sh (original) +++ tomcat/trunk/modules/jdbc-pool/sign.sh Mon Dec 22 18:16:28 2008 @@ -1,4 +1,4 @@ -VERSION=v1.0.10-beta +VERSION=v1.0.11-beta for i in $(find output/release/$VERSION -name "*.zip" -o -name "*.tar.gz"); do echo Signing $i echo $1|gpg --passphrase-fd 0 -a -b $i - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
