Re: svn commit: r723961 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: CreateTestTable.java TestSlowQueryReport.java

2008-12-07 Thread Filip Hanik - Dev Lists 

David Jencks wrote:


On Dec 6, 2008, at 9:30 AM, Filip Hanik - Dev Lists wrote:

there has to be a way to automate this, since I'm a frequent 
offender, is there some SVN script we could do?


http://www.apache.org/dev/svn-eol-style.txt  ?
yes,definitely didn't have that. I started up two virtual environments. 
Is there anything that can be done server side?


Filip


david jencks



Filip

[EMAIL PROTECTED] wrote:

Author: markt
Date: Sat Dec  6 01:24:29 2008
New Revision: 723961

URL: http://svn.apache.org/viewvc?rev=723961&view=rev
Log:
Set line endings for a couple of new files

Modified:
   
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CreateTestTable.java   
(props changed)
   
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java   
(props changed)


Propchange: 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CreateTestTable.java 

-- 


   svn:eol-style = native

Propchange: 
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java 

-- 


   svn:eol-style = native



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r724239 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2008-12-07 Thread fhanik 
Author: fhanik
Date: Sun Dec  7 19:32:07 2008
New Revision: 724239

URL: http://svn.apache.org/viewvc?rev=724239&view=rev
Log:
Remove the synchronize/notifyAll based thread pool, and use only the built in 
pool

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=724239&r1=724238&r2=724239&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Sun Dec  7 
19:32:07 2008
@@ -116,12 +116,6 @@
 
 
 /**
- * Available workers.
- */
-protected WorkerStack workers = null;
-
-
-/**
  * Running state of the endpoint.
  */
 protected volatile boolean running = false;
@@ -349,7 +343,11 @@
 public Executor getExecutor() { return executor; }
 
 protected boolean useExecutor = true;
-public void setUseExecutor(boolean useexec) { useExecutor = useexec;}
+/**
+ * @deprecated Executor is always used
+ * @param useexec
+ */
+public void setUseExecutor(boolean useexec) { log.info("Setting 
useExecutor is deprecated. Executors are always used.");}
 public boolean getUseExecutor() { return useExecutor || (executor!=null);}
 
 /**
@@ -359,14 +357,10 @@
 public void setMaxThreads(int maxThreads) {
 this.maxThreads = maxThreads;
 if (running) {
-if (getUseExecutor() && executor!=null) {
+if (executor!=null) {
 if (executor instanceof ThreadPoolExecutor) {
 
((ThreadPoolExecutor)executor).setMaximumPoolSize(maxThreads);
 }
-}else if (workers!=null){
-synchronized(workers) {
-workers.resize(maxThreads);
-}
 }
 }
 }
@@ -857,15 +851,11 @@
 paused = false;
 
 // Create worker collection
-if (getUseExecutor()) {
-if ( executor == null ) {
-TaskQueue taskqueue = new TaskQueue();
-TaskThreadFactory tf = new TaskThreadFactory(getName() + 
"-exec-");
-executor = new ThreadPoolExecutor(getMinSpareThreads(), 
getMaxThreads(), 60, TimeUnit.SECONDS,taskqueue, tf);
-taskqueue.setParent( (ThreadPoolExecutor) executor, this);
-}
-} else if ( executor == null ) {//avoid two thread pools being 
created
-workers = new WorkerStack(maxThreads);
+if ( executor == null ) {
+TaskQueue taskqueue = new TaskQueue();
+TaskThreadFactory tf = new TaskThreadFactory(getName() + 
"-exec-");
+executor = new ThreadPoolExecutor(getMinSpareThreads(), 
getMaxThreads(), 60, TimeUnit.SECONDS,taskqueue, tf);
+taskqueue.setParent( (ThreadPoolExecutor) executor, this);
 }
 
 // Start poller threads
@@ -1104,99 +1094,8 @@
 protected boolean isWorkerAvailable() {
 if ( executor != null ) {
 return true;
-} else {
-if (workers.size() > 0) {
-return true;
-}
-if ( (maxThreads > 0) && (curThreads < maxThreads)) {
-return true;
-} else {
-if (maxThreads < 0) {
-return true;
-} else {
-return false;
-}
-}
-}
-}
-/**
- * Create (or allocate) and return an available processor for use in
- * processing a specific HTTP request, if possible.  If the maximum
- * allowed processors have already been created and are in use, return
- * null instead.
- */
-protected Worker createWorkerThread() {
-
-synchronized (workers) {
-if (workers.size() > 0) {
-curThreadsBusy++;
-return (workers.pop());
-}
-if ((maxThreads > 0) && (curThreads < maxThreads)) {
-curThreadsBusy++;
-if (curThreadsBusy == maxThreads) {
-log.info(sm.getString("endpoint.info.maxThreads",
-Integer.toString(maxThreads), address,
-Integer.toString(port)));
-}
-return (newWorkerThread());
-} else {
-if (maxThreads < 0) {
-curThreadsBusy++;
-return (newWorkerThread());
-} else {
-return (null);
-}
-}
-}
-}
-
-
-/**
- * Create and return a new processor suitable for processing HTTP
- * requests and ret

Bug report for Tomcat 3 [2008/12/07]

2008-12-07 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|  412|Ver|Nor|2001-01-08|JspC on Windows fails to handle includes in subdir|
| 2350|Ver|Nor|2001-06-27|ServletConfig.getInitParameter() requires url-patt|
| 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c|
| 9737|Ver|Nor|2002-06-10|ArrayIndexOutOfBoundsException when sending just p|
|44911|Ass|Nor|2008-04-30|Test again from Chirag|
+-+---+---+--+--+
| Total5 bugs   |
+---+

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Bug report for Tomcat 5 [2008/12/07]

2008-12-07 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat|
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|29160|Ver|Enh|2004-05-23|precompile problem: _jspx_meth_* (javax.servlet.js|
|29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi|
|30241|Ver|Enh|2004-07-21|Enhance build script to use branch argument when c|
|33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis|
|33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps|
|33650|Inf|Enh|2005-02-19|Jasper performance for multiple files processing  |
|33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na|
|34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a|
|34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern|
|34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that|
|35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc|
|36133|Inf|Enh|2005-08-10|Support JSS SSL implementation|
|36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi|
|36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's   |
|36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re|
|36911|Opn|Min|2005-10-04|Make fails while building jsvc on mac os x, multip|
|36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing  |
|36923|New|Nor|2005-10-05|Deactivated EL expressions are not parsed for jsp |
|37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token|
|37084|Opn|Reg|2005-10-14|JspC from ant fails on JSPs that use custom taglib|
|37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis|
|37449|Opn|Enh|2005-11-10|Two UserDatabaseRealm break manager user  |
|37458|Opn|Nor|2005-11-10|Datarace on org.apache.catalina.loader.WebappClass|
|37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre|
|37498|Inf|Nor|2005-11-14|[PATCH] NPE in org.apache.catalina.core.ContainerB|
|37515|Inf|Nor|2005-11-15|smap not generated by JspC when used from Ant for |
|37627|Opn|Nor|2005-11-24|Slow and incomplete dynamic content generation aft|
|37785|Inf|Nor|2005-12-05|Changing startup type via Tomcat Monitor does not |
|37794|Opn|Nor|2005-12-05|getParameter() fails on POST with transfer-encodin|
|37797|Inf|Maj|2005-12-05|Configure Tomcat utility truncates classpath to 96|
|37847|Ass|Enh|2005-12-09|Allow User To Optionally Specify Catalina Output F|
|37869|Opn|Nor|2005-12-12|Cannot obtain client certificate with SSL / client|
|37918|Inf|Nor|2005-12-15|EL cannot find valid getter from object when using|
|37984|New|Nor|2005-12-21|JNDIRealm.java not able to handle MD5 password|
|38046|Ass|Reg|2005-12-27|apache-tomcat-5.5.14-deployer doesn't work (Illega|
|38197|Opn|Maj|2006-01-09|taglib pool bug when tag is used with jsp:attribut|
|38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations |
|38217|Ver|Enh|2006-01-10|mention that private key password and keystore pas|
|38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti|
|38352|Inf|Nor|2006-01-22|Additional Entries for Default catalina.policy fil|
|38360|Inf|Enh|2006-01-24|Domain for session cookies|
|38427|Inf|Nor|2006-01-27|ServletContextListener Notified Multiple Times Whe|
|38483|New|Nor|2006-02-01|access log valve uses simpledateformat in tread-un|
|38484|New|Min|2006-02-01|webapps Admin: Invalid path /login was requested  |
|38516|Inf|Nor|2006-02-05|Configuration Manager loses "Log On" settings |
|38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, |
|38553|Inf|Nor|2006-02-07|Wrong HTTP code for failed CLIENT-CERT authenticat|
|38570|Inf|Nor|2006-02-08|if docBase path contains "webapps", a backslash is|
|38577|Inf|Enh|2006-02-08|Enhance logging of security failures  |
|38630|

Bug report for Tomcat 4 [2008/12/07]

2008-12-07 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 3839|Opn|Enh|2001-09-26|Problem bookmarking login page|
| 4227|Opn|Enh|2001-10-17|Invalid CGI path  |
| 5329|New|Enh|2001-12-08|NT Service exits startup before Tomcat is finished|
| 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob|
| 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi|
| 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio|
| 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI|
| 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam|
| 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty|
| 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store   |
| 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output|
| 7676|New|Enh|2002-04-02|Allow name property to use match experssions in  without className in server.xml produces N|
|11129|New|Enh|2002-07-24|New valve for putting the sessionIDs in the reques|
|11248|New|Enh|2002-07-29|DefaultServlet doesn't send expires header|
|11754|Opn|Enh|2002-08-15|Synchronous shutdown script - shutdown.sh should w|
|12069|New|Enh|2002-08-27|Creation of more HttpSession objects for one previ|
|12428|Opn|Enh|2002-09-09|request.getUserPrincipal(): Misinterpretation of s|
|12658|New|Enh|2002-09-15|a proxy host and port at the  element level |
|12766|New|Enh|2002-09-18|Tomcat should use tld files in /WEB-INF/ over vers|
|13309|Opn|Enh|2002-10-04|Catalina calls System.exit()  |
|13634|New|Enh|2002-10-15|Allowing system properties to be substituted in co|
|13689|Opn|Enh|2002-10-16|Classloader paths for 'Common' classes and librari|
|13731|New|Enh|2002-10-17|Final request, response, session and other variabl|
|13941|New|Enh|2002-10-24|reload is VERY slow   |
|13965|New|Enh|2002-10-25|Catalina.sh correction request for Tru64 Unix |
|14097|New|Enh|2002-10-30|hardcoded registry value for vm lets tomcat servic|
|14416|New|Enh|2002-11-10|blank tag name in TLD cause NullPointerException  |
|14635|New|Enh|2002-11-18|Should be possible not to have -MM-DD in log f|
|14766|New|Enh|2002-11-22|Redirect Vavle|
|14993|New|Enh|2002-12-02|Possible obselete synchronized declaration|
|15115|New|Enh|2002-12-05|correct docs... XML parser *cannot* be overridden |
|15417|Opn|Enh|2002-12-16|Add port for forced compilation of JSP pages  |
|15688|New|Enh|2002-12-27|full-qualified names instead of imports   |
|15941|New|Enh|2003-01-10|Expose rootCause exceptions at deeper levels  |
|16294|New|Enh|2003-01-21|Configurable URL Decoding.|
|16357|New|Enh|2003-01-23|"connection timeout reached"  |
|16531|New|Enh|2003-01-29|Updating already deployed ".war" files in a single|
|16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to|
|16596|New|Enh|2003-01-30|option for disabling log rotation |
|17070|New|Enh|2003-02-14|The Catalina Ant tasks do not allow for 'reusable'|
|17146|New|Enh|2003-02-18|Simplify build.xml using

Bug report for Watchdog [2008/12/07]

2008-12-07 Thread bugzilla 
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|  278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug|
|  279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug|
|  469|Unc|Nor|2001-01-17|in example-taglib.tld "urn" should be "uri" BugRat|
|  470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B|
| 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths|
|10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher|
|11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward()|
|11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav|
|11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie|
|11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro|
|11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid.|
|14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec|
|15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv|
|24649|New|Nor|2003-11-12|getRemoteHost fails when agent has uppercase chara|
|29398|New|Nor|2004-06-04|Update site and note current status   |
+-+---+---+--+--+
| Total   15 bugs   |
+---+

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]