svn commit: r720827 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: remm Date: Wed Nov 26 04:23:12 2008 New Revision: 720827 URL: http://svn.apache.org/viewvc?rev=720827&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=720827&r1=720826&r2=720827&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Nov 26 04:23:12 2008 @@ -139,14 +139,14 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46105 Correctly set URI encoding when replaying a request after FORM auth http://svn.apache.org/viewvc?rev=709294&view=rev - +1: markt, fhanik + +1: markt, fhanik, remm -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46125 Change the exception to cause a 400 status code if the request headers are too big http://svn.apache.org/viewvc?rev=709811&view=rev - +1: markt + +1: markt, remm (with a trivial improvement) -1: fhanik - InternalAprInputBuffer/InternalNioInputBuffer should provide the same behavior * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42409 @@ -155,9 +155,8 @@ http://svn.apache.org/viewvc?rev=710063&view=rev http://svn.apache.org/viewvc?rev=710125&view=rev (to address Remy's comment) +1: markt - -1: remm (will cause a major behavior change; I would recommend doing a resetBuffer, - plus setting usingOutputStream, usingWriter and isCharacterEncodingSet to false; - seriously, this sort of "fix" really needs to stop in the 6.0.x branch) + 0: remm (I think it should now be ok) + -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41861 Add major version number to Tomcat service name created by Windows installer @@ -176,16 +175,16 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46047 Include jar in path for dependencies if they are in a JAR - Patch provided by Cdric Mailleux + Patch provided by C�dric Mailleux http://svn.apache.org/viewvc?rev=710205&view=rev - +1: markt + +1: markt, remm -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46011 Make Principal accessible (if set) via Subject.getSubject(AccessController.getContext()) when processing filters. Based on a patch provided by tsveg1 - +1: markt, pero + +1: markt, pero, remm -1: * Fix http://svn.apache.org/viewvc?rev=712274&view=rev @@ -197,7 +196,7 @@ Correctly handle includes with multi-level contexts Patch provided by Peter Jodeleit http://svn.apache.org/viewvc?rev=712461&view=rev - +1: markt, fhanik + +1: markt, fhanik, remm -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747 @@ -205,34 +204,36 @@ context.xml consistent. http://svn.apache.org/viewvc?rev=712464&view=rev +1: markt, fhanik + 0: remm (risky, would it be possible to stop backporting risky changes and behavior modifications to 6.0.x ?) -1: * Add Costin's DBCP check so you can build Tomcat 6 on a 1.6 JDK http://svn.apache.org/viewvc?view=rev&revision=652744 http://svn.apache.org/viewvc?view=rev&revision=653247 - +1: markt, fhanik + +1: markt, fhanik, remm -1: * Remove unnecessary commons-logging reference from manifest http://svn.apache.org/viewvc?view=rev&revision=612607 - +1: markt + +1: markt, remm -1: * Fix broken URL mapping in examples http://svn.apache.org/viewvc?view=rev&revision=630314 - +1: markt + +1: markt, remm -1: * Clean up dist.xml http://svn.apache.org/viewvc?rev=718360&view=rev - +1: markt + +1: markt, remm -1: * Make sure DIR deployment with context.xml works when configBase does no exist. This is required as a result of my previous changes to HostConfig http://svn.apache.org/viewvc?rev=718436&view=rev +1: markt, fhanik + 0: remm (risky, would it be possible to stop backporting risky changes and behavior modifications to 6.0.x ?) -1: * Fix possible NPE in NioEndpoint @@ -249,6 +250,8 @@ http://svn.apache.org/viewvc?rev=719602&view=rev http://svn.apache.org/viewvc?rev=719628&view=rev +1: markt, fhanik + 0: remm (risky, would it be possible to stop backporting risky changes and behavior modifications to 6.0.x ? + on this particular one, if people want fancy behavior, maybe they should use an executor) -1: * Prevent async close NPE on already closed sockets - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 46293] New: Bean property getter not found when using EL expression
[EMAIL PROTECTED] wrote:
https://issues.apache.org/bugzilla/show_bug.cgi?id=46293
Summary: Bean property getter not found when using EL expression
Product: Tomcat 6
Version: 6.0.18
Platform: PC
OS/Version: Windows Vista
Status: NEW
Severity: regression
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: [EMAIL PROTECTED]
The EL expression ${myBean.xKey} does not yield a call to myBean.getXKey().
However, ${myBean.XKey} does.
Dear All,
I was investigating this bug last night (Philippine time) and found out
something interesting which left me bewildered.
I was trying to come up with a proposed fix. :-)
I have the ff files:
a) testpckg.MyBean.java
package testpckg;
public class MyBean {
private String xKey = "xKey in the house";
private String name = "name in the house";
public String getXKey() { return xKey;}
public String getName() { return name; }
public void setXKey(String xKey) { this.xKey = xKey;}
public void setName(String name) { this.name = name;}
}
b) index.jsp
${test.xKey}
In javax.el.BeanELResolver.java, BeanInfo.getPropertyDescriptors() is
giving the ff:
pds[0].getName(): XKey
pds[1].getName(): class
pds[2].getName(): name
That BeanInfo.getPropertyDescriptors() call is in :
protected final static class BeanProperties {
private final Map properties;
private final Class type;
public BeanProperties(Class type) throws ELException {
this.type = type;
this.properties = new HashMap();
try {
BeanInfo info = Introspector.getBeanInfo(this.type);
PropertyDescriptor[] pds = info.getPropertyDescriptors();
for (int i = 0; i < pds.length; i++) {
this.properties.put(pds[i].getName(), new BeanProperty(
type, pds[i]));
}
} catch (IntrospectionException ie) {
throw new ELException(ie);
}
}
It looks like Java is taking XKey from getXKey().
I could make the code convert the first character of the property to
lowercase but I not sure about that.
My settings:
TC6.0.18
Java 1.5
Regards,
Karl
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: DO NOT REPLY [Bug 46293] New: Bean property getter not found when using EL expression
It has been a long time, but I believe the bean property naming convention is
that if the second letter is capitalized, the first letter should be
capitalized too, avoiding property names like "uRL". If you really want
"xKey", you can provide a MyBeanBeanInfo class to go with MyBean to specify
what you want. For more details, see the JavaBeans API.
Cheers,
Larry
-Original Message-
From: Karl R. San Gabriel [mailto:[EMAIL PROTECTED]
Sent: Wednesday, November 26, 2008 10:13 AM
To: Tomcat Developers List
Subject: Re: DO NOT REPLY [Bug 46293] New: Bean property getter not found when
using EL expression
[EMAIL PROTECTED] wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46293
>
>Summary: Bean property getter not found when using EL expression
>Product: Tomcat 6
>Version: 6.0.18
> Platform: PC
> OS/Version: Windows Vista
> Status: NEW
> Severity: regression
> Priority: P2
> Component: Jasper
> AssignedTo: dev@tomcat.apache.org
> ReportedBy: [EMAIL PROTECTED]
>
>
> The EL expression ${myBean.xKey} does not yield a call to myBean.getXKey().
> However, ${myBean.XKey} does.
>
>
>
Dear All,
I was investigating this bug last night (Philippine time) and found out
something interesting which left me bewildered.
I was trying to come up with a proposed fix. :-)
I have the ff files:
a) testpckg.MyBean.java
package testpckg;
public class MyBean {
private String xKey = "xKey in the house";
private String name = "name in the house";
public String getXKey() { return xKey;}
public String getName() { return name; }
public void setXKey(String xKey) { this.xKey = xKey;}
public void setName(String name) { this.name = name;}
}
b) index.jsp
${test.xKey}
In javax.el.BeanELResolver.java, BeanInfo.getPropertyDescriptors() is
giving the ff:
pds[0].getName(): XKey
pds[1].getName(): class
pds[2].getName(): name
That BeanInfo.getPropertyDescriptors() call is in :
protected final static class BeanProperties {
private final Map properties;
private final Class type;
public BeanProperties(Class type) throws ELException {
this.type = type;
this.properties = new HashMap();
try {
BeanInfo info = Introspector.getBeanInfo(this.type);
PropertyDescriptor[] pds = info.getPropertyDescriptors();
for (int i = 0; i < pds.length; i++) {
this.properties.put(pds[i].getName(), new BeanProperty(
type, pds[i]));
}
} catch (IntrospectionException ie) {
throw new ELException(ie);
}
}
It looks like Java is taking XKey from getXKey().
I could make the code convert the first character of the property to
lowercase but I not sure about that.
My settings:
TC6.0.18
Java 1.5
Regards,
Karl
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45154] Support sendfile with NIO and SSL
https://issues.apache.org/bugzilla/show_bug.cgi?id=45154 Filip Hanik <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED --- Comment #4 from Filip Hanik <[EMAIL PROTECTED]> 2008-11-26 12:35:27 PST --- Proposal for inclusion and performance improvement is added here http://svn.apache.org/viewvc?rev=720724&view=rev http://svn.apache.org/viewvc?rev=720728&view=rev The important thing is to never call a blocking method within the poller Proposal for inclusion in 6.0.x branch has been created. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r720971 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik Date: Wed Nov 26 12:35:53 2008 New Revision: 720971 URL: http://svn.apache.org/viewvc?rev=720971&view=rev Log: votes and proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=720971&r1=720970&r2=720971&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Nov 26 12:35:53 2008 @@ -147,14 +147,14 @@ big http://svn.apache.org/viewvc?rev=709811&view=rev +1: markt, remm (with a trivial improvement) - -1: fhanik - InternalAprInputBuffer/InternalNioInputBuffer should provide the same behavior + -1: fhanik - InternalAprInputBuffer/InternalNioInputBuffer should provide the same behavior (+1 for same changes in all three) * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42409 Use resetBuffer() as suggested by the spec. Makes custom and standard error page handling consistent http://svn.apache.org/viewvc?rev=710063&view=rev http://svn.apache.org/viewvc?rev=710125&view=rev (to address Remy's comment) - +1: markt + +1: markt, fhanik 0: remm (I think it should now be ok) -1: @@ -177,7 +177,7 @@ Include jar in path for dependencies if they are in a JAR Patch provided by C�dric Mailleux http://svn.apache.org/viewvc?rev=710205&view=rev - +1: markt, remm + +1: markt, remm, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46011 @@ -216,17 +216,17 @@ * Remove unnecessary commons-logging reference from manifest http://svn.apache.org/viewvc?view=rev&revision=612607 - +1: markt, remm + +1: markt, remm, fhanik -1: * Fix broken URL mapping in examples http://svn.apache.org/viewvc?view=rev&revision=630314 - +1: markt, remm + +1: markt, remm, fhanik -1: * Clean up dist.xml http://svn.apache.org/viewvc?rev=718360&view=rev - +1: markt, remm + +1: markt, remm, fhanik -1: * Make sure DIR deployment with context.xml works when configBase does no exist. @@ -264,4 +264,11 @@ http://svn.apache.org/viewvc?rev=720553&view=rev +1: fhanik -1: - + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45154 (add sendfile support to NIO/SSL) + http://svn.apache.org/viewvc?rev=720724&view=rev + http://svn.apache.org/viewvc?rev=720728&view=rev + +1: fhanik + -1: + + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r720991 - /tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
Author: markt
Date: Wed Nov 26 13:41:03 2008
New Revision: 720991
URL: http://svn.apache.org/viewvc?rev=720991&view=rev
Log:
Tabs -> 8 spaces
Modified:
tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java?rev=720991&r1=720990&r2=720991&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java Wed Nov
26 13:41:03 2008
@@ -56,34 +56,34 @@
public class JspRuntimeLibrary {
private static final String SERVLET_EXCEPTION
- = "javax.servlet.error.exception";
+= "javax.servlet.error.exception";
private static final String JSP_EXCEPTION
- = "javax.servlet.jsp.jspException";
+= "javax.servlet.jsp.jspException";
protected static class PrivilegedIntrospectHelper
- implements PrivilegedExceptionAction {
+implements PrivilegedExceptionAction {
- private Object bean;
- private String prop;
- private String value;
- private ServletRequest request;
- private String param;
- private boolean ignoreMethodNF;
+private Object bean;
+private String prop;
+private String value;
+private ServletRequest request;
+private String param;
+private boolean ignoreMethodNF;
PrivilegedIntrospectHelper(Object bean, String prop,
String value, ServletRequest request,
String param, boolean ignoreMethodNF)
{
- this.bean = bean;
- this.prop = prop;
- this.value = value;
+this.bean = bean;
+this.prop = prop;
+this.value = value;
this.request = request;
- this.param = param;
- this.ignoreMethodNF = ignoreMethodNF;
+this.param = param;
+this.ignoreMethodNF = ignoreMethodNF;
}
public Object run() throws JasperException {
- internalIntrospecthelper(
+internalIntrospecthelper(
bean,prop,value,request,param,ignoreMethodNF);
return null;
}
@@ -99,134 +99,134 @@
* variable is initialized.
*/
public static Throwable getThrowable(ServletRequest request) {
- Throwable error = (Throwable) request.getAttribute(SERVLET_EXCEPTION);
- if (error == null) {
- error = (Throwable) request.getAttribute(JSP_EXCEPTION);
- if (error != null) {
- /*
-* The only place that sets JSP_EXCEPTION is
-* PageContextImpl.handlePageException(). It really should set
-* SERVLET_EXCEPTION, but that would interfere with the
-* ErrorReportValve. Therefore, if JSP_EXCEPTION is set, we
-* need to set SERVLET_EXCEPTION.
-*/
- request.setAttribute(SERVLET_EXCEPTION, error);
- }
- }
+Throwable error = (Throwable) request.getAttribute(SERVLET_EXCEPTION);
+if (error == null) {
+error = (Throwable) request.getAttribute(JSP_EXCEPTION);
+if (error != null) {
+/*
+ * The only place that sets JSP_EXCEPTION is
+ * PageContextImpl.handlePageException(). It really should set
+ * SERVLET_EXCEPTION, but that would interfere with the
+ * ErrorReportValve. Therefore, if JSP_EXCEPTION is set, we
+ * need to set SERVLET_EXCEPTION.
+ */
+request.setAttribute(SERVLET_EXCEPTION, error);
+}
+}
- return error;
+return error;
}
public static boolean coerceToBoolean(String s) {
- if (s == null || s.length() == 0)
- return false;
- else
- return Boolean.valueOf(s).booleanValue();
+if (s == null || s.length() == 0)
+return false;
+else
+return Boolean.valueOf(s).booleanValue();
}
public static byte coerceToByte(String s) {
- if (s == null || s.length() == 0)
- return (byte) 0;
- else
- return Byte.valueOf(s).byteValue();
+if (s == null || s.length() == 0)
+return (byte) 0;
+else
+return Byte.valueOf(s).byteValue();
}
public static char coerceToChar(String s) {
- if (s == null || s.length() == 0) {
- return (char) 0;
- } else {
- // this trick avoids escaping issues
- return (char)(int) s.charAt(0);
- }
+if (s == null || s.length() == 0) {
+return (char) 0;
+
NTLM Authentication (POST now correctly supported)
Hi Tomcat Developers!
The new authenticator class (modified to support POST) is accessible:
http://www.destin.be/tomcat/NtlmAuthenticator.java
The previous patch file is accessible and UNCHANGED:
http://www.destin.be/tomcat/NtlmAuthentication.patch
Please let me know the procedures I may follow to make this modification
perennial.
I wanted to:
* centralize the parameterization of user authentication at the container level;
* have a simple NTLM authentication for intranet users;
* be able to run Tomcat in a Microsoft Active Directory network where the
server is secured (absolutely no login allowed to regular users)
There is a Microsoft "specification" (bug?) by which all LDAP binds are
evaluated on the Domain Server (like if the user was attempting to login on the
Domain Server).
It would be better to have binds evaluated as if they were originating from the
LDAP client machine (the Tomcat Server).
To circumvent this, I have been obliged to remove the binding (the password
checking) but to ensure that it is NTLM (and nothing else) which provides the
username.
The users are therefore automatically logged with the username used to log on
their PC.
The attached patch is for current Apache Tomcat sources (6.0.18).
It adds:
An NTLM Authenticator: nothing to configure except in the web.xml of each
application:
NTLM
ThisIsApassword
The realm-name is the "password" which ensures that authentication is done by
NTLM and no other method.
A very long password is strongly recommended.
A modified JNDI Realm with new parameters:
preAuthenticatedPassword="ThisIsApassword"
This to suppress password checking if preAuthenticatedPassword is provided.
userIdentification="userPrincipalName" provides a standardized username,
whatever the retrieved user name (case of complex userSearch patterns)
userNamePrefix and userNameSuffix
This to suppress a prefix and/or a suffix from username before returning it to
the application: good to suppress domain identification, etc.
When you user complex userSearch pattern, this can be very useful. Example:
userSearch="(|(sAMAccountName={0})([EMAIL PROTECTED])(userPrincipalName={0}))"
userIdentification="userPrincipalName" userNamePrefix="domain\"
userNameSuffix="@domain.com"
Hopes this can be useful to the community!
Wishing you a very nice day,
Christophe Dupriez
Centre Antipoisons - Antigifcentrum
C/o Hôpital Central de la Base Reine Astrid
Rue Bruyn - 1120 Bruxelles - Belgique
tel 32-(0)2.264.96.36 fax 32-(0)2.264.96.46
svn commit: r721040 - /tomcat/trunk/bin/catalina.bat
Author: markt Date: Wed Nov 26 15:55:26 2008 New Revision: 721040 URL: http://svn.apache.org/viewvc?rev=721040&view=rev Log: Use same (more useful) jpda defaults as catalina.sh Modified: tomcat/trunk/bin/catalina.bat Modified: tomcat/trunk/bin/catalina.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=721040&r1=721039&r2=721040&view=diff == --- tomcat/trunk/bin/catalina.bat (original) +++ tomcat/trunk/bin/catalina.bat Wed Nov 26 15:55:26 2008 @@ -140,10 +140,10 @@ if not ""%1"" == ""jpda"" goto noJpda set JPDA=jpda if not "%JPDA_TRANSPORT%" == "" goto gotJpdaTransport -set JPDA_TRANSPORT=dt_shmem +set JPDA_TRANSPORT=dt_socket :gotJpdaTransport if not "%JPDA_ADDRESS%" == "" goto gotJpdaAddress -set JPDA_ADDRESS=jdbconn +set JPDA_ADDRESS=8000 :gotJpdaAddress if not "%JPDA_SUSPEND%" == "" goto gotJpdaSuspend set JPDA_SUSPEND=n - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r721041 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Author: markt
Date: Wed Nov 26 16:08:32 2008
New Revision: 721041
URL: http://svn.apache.org/viewvc?rev=721041&view=rev
Log:
Generics fixes require change in code generated for JSPs
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=721041&r1=721040&r2=721041&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Wed Nov 26
16:08:32 2008
@@ -485,14 +485,14 @@
out.println();
// Static data for getDependants()
-out.printil("private static java.util.List _jspx_dependants;");
+out.printil("private static java.util.List _jspx_dependants;");
out.println();
List dependants = pageInfo.getDependants();
Iterator iter = dependants.iterator();
if (!dependants.isEmpty()) {
out.printil("static {");
out.pushIndent();
-out.printin("_jspx_dependants = new java.util.ArrayList(");
+out.printin("_jspx_dependants = new java.util.ArrayList(");
out.print("" + dependants.size());
out.println(");");
while (iter.hasNext()) {
@@ -537,7 +537,7 @@
*/
private void genPreambleMethods() throws JasperException {
// Method used to get compile time file dependencies
-out.printil("public Object getDependants() {");
+out.printil("public java.util.List getDependants() {");
out.pushIndent();
out.printil("return _jspx_dependants;");
out.popIndent();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 46304] New: SecurityUtil -- no method caching for event() or doFilterEvent() ?
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304 Summary: SecurityUtil -- no method caching for event() or doFilterEvent() ? Product: Tomcat 6 Version: 6.0.18 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P3 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: [EMAIL PROTECTED] [No, this isn't a bug that has bitten me, I just noticed this in the code while I was trying to get my head around what SecurityUtil does / doesn't do. Also, this is probably just a performance bug, not a real failure. I noticed this in the 6.0.18 source and confirmed that it's still on the trunk, even though there have been code changes nearby, e.g revision 711600 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=711600 ) for issue 46011]. ApplicationFilterChain.internalDoFilterEvent() invokes SecurityUtil.doAsPrivileged() for "doFilterEvent" and "event", but as far as I can see, SecurityUtil.createMethodAndCacheIt() will never cache the Method descriptors for those two methods -- bad (for performance)? Also... the fix for issue 46011 modified internalDoFilter(), but should there be a similar modification in internalDoFilterEvent() too? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304 Thomas Maslen <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r721111 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: pero Date: Wed Nov 26 23:46:51 2008 New Revision: 72 URL: http://svn.apache.org/viewvc?rev=72&view=rev Log: Cast my vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=72&r1=721110&r2=72&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Nov 26 23:46:51 2008 @@ -154,7 +154,7 @@ page handling consistent http://svn.apache.org/viewvc?rev=710063&view=rev http://svn.apache.org/viewvc?rev=710125&view=rev (to address Remy's comment) - +1: markt, fhanik + +1: markt, fhanik, pero 0: remm (I think it should now be ok) -1: @@ -177,7 +177,7 @@ Include jar in path for dependencies if they are in a JAR Patch provided by C�dric Mailleux http://svn.apache.org/viewvc?rev=710205&view=rev - +1: markt, remm, fhanik + +1: markt, remm, fhanik, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46011 @@ -196,7 +196,7 @@ Correctly handle includes with multi-level contexts Patch provided by Peter Jodeleit http://svn.apache.org/viewvc?rev=712461&view=rev - +1: markt, fhanik, remm + +1: markt, fhanik, remm, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747 @@ -211,12 +211,12 @@ * Add Costin's DBCP check so you can build Tomcat 6 on a 1.6 JDK http://svn.apache.org/viewvc?view=rev&revision=652744 http://svn.apache.org/viewvc?view=rev&revision=653247 - +1: markt, fhanik, remm + +1: markt, fhanik, remm, pero -1: * Remove unnecessary commons-logging reference from manifest http://svn.apache.org/viewvc?view=rev&revision=612607 - +1: markt, remm, fhanik + +1: markt, remm, fhanik, pero -1: * Fix broken URL mapping in examples @@ -226,7 +226,7 @@ * Clean up dist.xml http://svn.apache.org/viewvc?rev=718360&view=rev - +1: markt, remm, fhanik + +1: markt, remm, fhanik, pero -1: * Make sure DIR deployment with context.xml works when configBase does no exist. @@ -238,12 +238,12 @@ * Fix possible NPE in NioEndpoint http://svn.apache.org/viewvc?rev=719096&view=rev - +1: fhanik, markt + +1: fhanik, markt, pero -1: * Fix send file bug http://svn.apache.org/viewvc?rev=719129&view=rev - +1: fhanik + +1: fhanik, pero -1: * Make thread pool limits dynamically configurable - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
