DO NOT REPLY [Bug 45913] New: removeAbandoned configuration not working.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45913
Summary: removeAbandoned configuration not working.
Product: Tomcat 5
Version: 5.5.12
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: [EMAIL PROTECTED]
Hi,
Iam using tomcat connection pooling to maintain db connections.
The following configurations were made in context.xml.
I used the following code to look up and get the data base connections
Context initCtx = new InitialContext();
Context envCtx = (Context) initCtx.lookup("java:comp/env");
// Look up our data source
DataSource ds = (DataSource) envCtx.lookup("jdbc/testdb");
// Allocate and use a connection from the pool
Connection connection = ds.getConnection();
After this the application is creating 50 connections and it is not closing
the connections after using.Will removeAbandoned step in and return the
connections to the pool and remove the excess connections greater than maxIdle
parameter.But when the application needs the next set of connections it is
creating new connections instead of using the existing ones and as a result the
MySql server is running out of connections.Why is removeAbandoned not handling
the unclosed connections even after 1 minute even though it is configured to do
so.
Thanks
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45913] removeAbandoned configuration not working.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45913 svkirans <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41849] Blank page after login on static html page (form authentication)
https://issues.apache.org/bugzilla/show_bug.cgi?id=41849 --- Comment #6 from Robin <[EMAIL PROTECTED]> 2008-09-30 01:30:22 PST --- Can somebody confirm this bug, or look at this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45914] New: High CPU Utilization
https://issues.apache.org/bugzilla/show_bug.cgi?id=45914 Summary: High CPU Utilization Product: Tomcat 5 Version: 5.5.15 Platform: PC OS/Version: Linux Status: NEW Keywords: JDK1.5 Severity: normal Priority: P2 Component: Servlet & JSP API AssignedTo: dev@tomcat.apache.org ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Created an attachment (id=22646) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22646) Screenshot im having a problem right now my cpu utilization reach up to 94%, im only running a tomcat in my server. My system is currently running RHEL 4 update 3. Thanks [EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45914] High CPU Utilization
https://issues.apache.org/bugzilla/show_bug.cgi?id=45914 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-30 03:43:57 PST --- This looks like an application problem that should be discussed on the users list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44454] busy count reported in mod_jk inflated, causes incorrect balancing
https://issues.apache.org/bugzilla/show_bug.cgi?id=44454 --- Comment #17 from Mark Greene <[EMAIL PROTECTED]> 2008-09-30 08:19:21 PST --- Hi, I wanted to know if there was any intent on fixing this issue as I have experienced EXACTLY the same symptoms on my production environment and unable to reproduce them in a test environment by simply throwing a load tester at it. I'm using: Server Version: Apache/2.0.52 (CentOS) JK Version: mod_jk/1.2.26 JBoss Version: 4.2.2 GA I have also set about every timeout I could find in the workers.properties documentation as well as the timeout on the AJP connector inside tomcat. I was incredibly happy to see this bug filed as every time I see a forum post with the same issue, someone is quick to respond with telling the poster to set all these timeout settings. Thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45921] New: Session ID not read from URL when cookie value is not valid
https://issues.apache.org/bugzilla/show_bug.cgi?id=45921 Summary: Session ID not read from URL when cookie value is not valid Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: [EMAIL PROTECTED] Hello, According to SRV.7.1.3 of the Servlet specs, "URL rewriting is the lowest common denominator of session tracking. When a client will not accept a cookie, URL rewriting may be used by the server as the basis for session tracking". Let's now consider the following case: - A user accesses to an app that creates a session for that user. This means the response will contain a cookie with that session id. - At some point, the cookie stored into the user's browser might not be valid anymore (let's say we invalidated that session from Tomcat). - Now imagine that the user (who still has his browser opened, so the cookie is still there) now clicks a link pointing to the same app, but that includes a different (and valid) jsessionid embedded into the URL. Under this case, the application is receiving a request that contains 2 references to a session: 1 jsessionid coming from a cookie (which is invalid because we manually expired that session from the server) and 1 jsessionid coming from the URL (which is valid because it belongs to a session still active). When we call request.getSession(true) on the app, Tomcat checks that the jsessionid from the cookie is invalid, and returns a new session. Instead, after verifying that the jsessionid from the cookie is invalid, it should check if there's any valid jsessionid coming through the URL. If so, it should return that session and not create a new one. Apparently, a jsessionid coming through a URL is just considered when there's no jsessionid cookie on the request. Thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r700526 - /tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Author: markt
Date: Tue Sep 30 10:10:48 2008
New Revision: 700526
URL: http://svn.apache.org/viewvc?rev=700526&view=rev
Log:
Code clean up. Use generics. Remove used code and a couple of other Find Bugs
issues.
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=700526&r1=700525&r2=700526&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java Tue Sep 30
10:10:48 2008
@@ -340,9 +340,9 @@
// Document the properties from ServletRequest
out.println("ServletRequest Properties");
out.println("");
-Enumeration attrs = req.getAttributeNames();
+Enumeration attrs = req.getAttributeNames();
while (attrs.hasMoreElements()) {
-String attr = (String) attrs.nextElement();
+String attr = attrs.nextElement();
out.println("attribute " + attr + " = " +
req.getAttribute(attr));
}
@@ -352,14 +352,14 @@
req.getContentLength());
out.println("contentType = " +
req.getContentType());
-Enumeration locales = req.getLocales();
+Enumeration locales = req.getLocales();
while (locales.hasMoreElements()) {
-Locale locale = (Locale) locales.nextElement();
+Locale locale = locales.nextElement();
out.println("locale = " + locale);
}
-Enumeration params = req.getParameterNames();
+Enumeration params = req.getParameterNames();
while (params.hasMoreElements()) {
-String param = (String) params.nextElement();
+String param = params.nextElement();
String values[] = req.getParameterValues(param);
for (int i = 0; i < values.length; i++)
out.println("parameter " + param + " = " +
@@ -386,9 +386,9 @@
for (int i = 0; i < cookies.length; i++)
out.println("cookie " + cookies[i].getName() +" = "
+cookies[i].getValue());
}
-Enumeration headers = req.getHeaderNames();
+Enumeration headers = req.getHeaderNames();
while (headers.hasMoreElements()) {
-String header = (String) headers.nextElement();
+String header = headers.nextElement();
out.println("header " + header + " = " +
req.getHeader(header));
}
@@ -423,7 +423,7 @@
out.println("");
attrs = req.getAttributeNames();
while (attrs.hasMoreElements()) {
-String attr = (String) attrs.nextElement();
+String attr = attrs.nextElement();
out.println("" + attr + " = " +
req.getAttribute(attr));
}
@@ -453,7 +453,7 @@
out.println("");
attrs = session.getAttributeNames();
while (attrs.hasMoreElements()) {
-String attr = (String) attrs.nextElement();
+String attr = attrs.nextElement();
out.println("" + attr + " = " +
session.getAttribute(attr));
}
@@ -475,7 +475,7 @@
out.println("");
params = getServletConfig().getInitParameterNames();
while (params.hasMoreElements()) {
-String param = (String) params.nextElement();
+String param = params.nextElement();
String value = getServletConfig().getInitParameter(param);
out.println("" + param + " = " + value);
}
@@ -501,7 +501,7 @@
out.println("");
params = getServletContext().getInitParameterNames();
while (params.hasMoreElements()) {
-String param = (String) params.nextElement();
+String param = params.nextElement();
String value = getServletContext().getInitParameter(param);
out.println("" + param + " = " + value);
}
@@ -513,7 +513,7 @@
out.println("");
attrs = getServletContext().getAttributeNames();
while (attrs.hasMoreElements()) {
-String attr = (String) attrs.nextElement();
+String attr = attrs.nextElement();
out.println("" + attr + " = " +
getServletContext().getAttribute(attr));
}
@@ -665,7 +665,7 @@
private File tmpDir = null;
/** derived cgi environment */
-private Hashtable env = null;
+private Hashtable env = null;
/** cgi command to be invoked */
private String command = null;
@@ -934,7 +934,6 @@
// Add the CGI environment variables
svn commit: r700532 - /tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Author: markt
Date: Tue Sep 30 10:28:12 2008
New Revision: 700532
URL: http://svn.apache.org/viewvc?rev=700532&view=rev
Log:
Fix some more Find Bugs nags in the CGIServlet. Minor functional changes.
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=700532&r1=700531&r2=700532&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java Tue Sep 30
10:28:12 2008
@@ -1143,7 +1143,11 @@
String dirPath = destPath.toString().substring(
0,destPath.toString().lastIndexOf("/"));
File dir = new File(dirPath);
-dir.mkdirs();
+if (!dir.mkdirs() && debug >= 2) {
+log("expandCGIScript: failed to create directories for '" +
+dir.getAbsolutePath() + "'");
+return;
+}
try {
synchronized (expandFileLock) {
@@ -1169,7 +1173,10 @@
} catch (IOException ioe) {
// delete in case file is corrupted
if (f.exists()) {
-f.delete();
+if (!f.delete() && debug >= 2) {
+log("expandCGIScript: failed to delete '" +
+f.getAbsolutePath() + "'");
+}
}
}
}
@@ -1591,6 +1598,7 @@
* with major modifications by Martin Dengler
*/
Runtime rt = null;
+BufferedReader cgiHeaderReader = null;
InputStream cgiOutput = null;
BufferedReader commandsStdErr = null;
BufferedOutputStream commandsStdIn = null;
@@ -1658,7 +1666,7 @@
InputStream cgiHeaderStream =
new HTTPHeaderInputStream(proc.getInputStream());
-BufferedReader cgiHeaderReader =
+cgiHeaderReader =
new BufferedReader(new InputStreamReader(cgiHeaderStream));
while (isRunning) {
@@ -1728,6 +1736,14 @@
throw e;
}
finally{
+// Close the header reader
+if (cgiHeaderReader != null) {
+try {
+cgiHeaderReader.close();
+} catch (IOException ioe) {
+log ("Exception closing header reader " + ioe);
+}
+}
// Close the output stream if used
if (cgiOutput != null) {
try {
@@ -1833,7 +1849,7 @@
* upto and including the two blank lines terminating the headers. It
* allows the content to be read using bytes or characters as appropriate.
*/
-protected class HTTPHeaderInputStream extends InputStream {
+protected static class HTTPHeaderInputStream extends InputStream {
private static final int STATE_CHARACTER = 0;
private static final int STATE_FIRST_CR = 1;
private static final int STATE_FIRST_LF = 2;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Thanks Tomcat core team and community for your work on Tomcat ! Mobicents Sip Servlets version 0.6, Sip Servlets 1.1 (JSR 289) certified, released !!
We are happy to announce the public availability of Mobicents Sip Servlets v0.6 ! Mobicents Sip Servlets extends Tomcat to provide converged SIP capabilities as defined per Sip Servlets 1.1 specification. The Mobicents Team (http://www.mobicents.org) would like to give special thanks to the Tomcat people that build the Tomcat container on which this work has been made possible. This release features the first open source containers certified for Sip Servlets 1.1 (JSR 289) compliance !!! Both containers Tomcat and JBoss passed the TCK tests : See our TCK Jboss results : http://hudson.jboss.org/hudson/job/MobicentsSipServletsReleaseTest/76/testReport See our TCK Tomcat results : http://hudson.jboss.org/hudson/job/MobicentsSipServletsTomcatReleaseTest/13/testReport What is included in this release: - * Mobicents SIP Servlets (JSR 289) certified containers (Sip Servlets working on top of Tomcat and JBoss) * Management Console * Educational converged example : Click To Call * Mobicents Media Server 1.0.0-BETA4 (Only for the JBoss distro) * The Mobicents SIP load Balancer: http://www.mobicents.org/load-balancer.html (Only JBoss distro) * The server/all profile configured for clustering in JBoss with predeployed simple-sip-servlet-distributable application to test clustering and mid call failover (Only JBoss distro) Project site : --- Mobicents Sip Servlets homepage : http://www.mobicents.org/products_sip_servlets.html Where to download from? --- The distribution can be found on sourceforget.net : https://sourceforge.net/project/showfiles.php?group_id=102670&package_id=262024&release_id=629778 SVN tag: * SVN checkout http://mobicents.googlecode.com/svn/tags/sip-servlets/release-0.6 * SVN browsing http://code.google.com/p/mobicents/source/browse/tags/sip-servlets/release-0.6 Source repositories: --- * SVN checkout http://mobicents.googlecode.com/svn/trunk/servers/sip-servlets * SVN browsing http://code.google.com/p/mobicents/source/browse/trunk/servers/sip-servlets How to get started: --- You'll find online instructions at You can also check out the user guide http://hudson.jboss.org/hudson/job/MobicentsDocumentation/lastSuccessfulBuild/artifact/html_single/index.html#chapter-Mobicents_SIP_Servlets_Server or http://www.mobicents.org/installation.html on how to get the server running. Once the server is running, you'll find online instructions at http://www.mobicents.org/examples.html to try out the examples. Alternatively, there is a README file in the top directory of both zip files. -SIP-SERVLETS-README.txt Roadmap - To check our progress and know what lies ahead for the Mobicents Sip Servlets project now that it has been certified, please check out http://www.mobicents.org/roadmap.html Looking forward to your feedback: - please feel free to post a mail on the mailing list of Mobicents public google group [EMAIL PROTECTED] or post an issue on google code http://code.google.com/p/mobicents/issues/list. Mobicents Sip Servlets Team - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r700570 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: remm
Date: Tue Sep 30 13:34:00 2008
New Revision: 700570
URL: http://svn.apache.org/viewvc?rev=700570&view=rev
Log:
- Votes.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=700570&r1=700569&r2=700570&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Sep 30 13:34:00 2008
@@ -228,6 +228,15 @@
+1: markt
-0: remm (actually, the optimization would be to return the original String
if it was not modified, and avoid doing things with a StringBuffer)
+The simplest would be to add a (redundant) check at the beginning of
replaceProperties,
+and although the "bug" finder program would complain, I think the == check
for the string
+is acceptable:
+public static String replaceProperties(String value, Hashtable staticProp,
+PropertySource dynamicProp[]) {
+if (value.indexOf("$") < 0) {
+return value;
+}
+StringBuffer sb = new StringBuffer();
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45906
Improve ETag handling in ResourceAttributes
@@ -241,5 +250,5 @@
Deprecate (rather than delete) any deleted code that isn't already deprecated
http://svn.apache.org/viewvc?rev=699714&view=rev (previous patch)
http://svn.apache.org/viewvc?rev=700167&view=rev (additional changes)
- +1: mark
+ +1: mark, remm
-1:
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r700580 - /tomcat/trunk/java/org/apache/catalina/valves/WebdavFixValve.java
Author: markt Date: Tue Sep 30 14:18:45 2008 New Revision: 700580 URL: http://svn.apache.org/viewvc?rev=700580&view=rev Log: Correct valve name in javadoc Modified: tomcat/trunk/java/org/apache/catalina/valves/WebdavFixValve.java Modified: tomcat/trunk/java/org/apache/catalina/valves/WebdavFixValve.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/WebdavFixValve.java?rev=700580&r1=700579&r2=700580&view=diff == --- tomcat/trunk/java/org/apache/catalina/valves/WebdavFixValve.java (original) +++ tomcat/trunk/java/org/apache/catalina/valves/WebdavFixValve.java Tue Sep 30 14:18:45 2008 @@ -35,7 +35,7 @@ * reconnect. * * To use this valve add the following+ * className="org.apache.catalina.valves.WebdavFixValve" /> * to your Engine, Host or Context as * required. Normally, this valve would be used at the Context * level. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r700582 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Sep 30 14:22:02 2008 New Revision: 700582 URL: http://svn.apache.org/viewvc?rev=700582&view=rev Log: Propose JMX port fixing listener Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=700582&r1=700581&r2=700582&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Sep 30 14:22:02 2008 @@ -252,3 +252,9 @@ http://svn.apache.org/viewvc?rev=700167&view=rev (additional changes) +1: mark, remm -1: + +* Add a new listener that fixes the ports used by JMX so jconsole etc can be used + through a firewall, ssh tunnel, etc + http://svn.apache.org/viewvc?rev=699523&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r700600 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Sep 30 15:10:19 2008 New Revision: 700600 URL: http://svn.apache.org/viewvc?rev=700600&view=rev Log: Revert this proposal - the listener is missing some key functionality. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=700600&r1=700599&r2=700600&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Sep 30 15:10:19 2008 @@ -252,9 +252,3 @@ http://svn.apache.org/viewvc?rev=700167&view=rev (additional changes) +1: mark, remm -1: - -* Add a new listener that fixes the ports used by JMX so jconsole etc can be used - through a firewall, ssh tunnel, etc - http://svn.apache.org/viewvc?rev=699523&view=rev - +1: markt - -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r700600 - /tomcat/tc6.0.x/trunk/STATUS.txt
On Tue, 2008-09-30 at 22:10 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Tue Sep 30 15:10:19 2008 > New Revision: 700600 > > URL: http://svn.apache.org/viewvc?rev=700600&view=rev > Log: > Revert this proposal - the listener is missing some key functionality. It is also missing any general usefulness too. Please put in in extra or sandbox, or in a tools place somewhere, but I don't see how this fits in the distribution. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r700600 - /tomcat/tc6.0.x/trunk/STATUS.txt
Remy Maucherat wrote: > On Tue, 2008-09-30 at 22:10 +, [EMAIL PROTECTED] wrote: >> Author: markt >> Date: Tue Sep 30 15:10:19 2008 >> New Revision: 700600 >> >> URL: http://svn.apache.org/viewvc?rev=700600&view=rev >> Log: >> Revert this proposal - the listener is missing some key functionality. > > It is also missing any general usefulness too. Please put in in extra or > sandbox, or in a tools place somewhere, but I don't see how this fits in > the distribution. Extras works for me. I'll update the build scripts. You might not find it useful but there have been a couple of people struggling with the very problem this is designed to solve on the users list in the last few weeks. It is also something I find useful when working with remote Tomcats sat behind firewalls. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r700645 - in /tomcat/trunk: java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java webapps/docs/config/listeners.xml
Author: markt
Date: Tue Sep 30 17:38:00 2008
New Revision: 700645
URL: http://svn.apache.org/viewvc?rev=700645&view=rev
Log:
Fix some issues discovered when using this with PuTTY.
Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java
tomcat/trunk/webapps/docs/config/listeners.xml
Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java?rev=700645&r1=700644&r2=700645&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java
Tue Sep 30 17:38:00 2008
@@ -18,10 +18,14 @@
package org.apache.catalina.mbeans;
import java.io.IOException;
+import java.io.Serializable;
import java.lang.management.ManagementFactory;
import java.net.MalformedURLException;
+import java.net.Socket;
import java.rmi.RemoteException;
import java.rmi.registry.LocateRegistry;
+import java.rmi.server.RMIClientSocketFactory;
+import java.rmi.server.RMIServerSocketFactory;
import java.util.HashMap;
import javax.management.MBeanServer;
@@ -44,7 +48,8 @@
* simpler if you need to connect jconsole or similar to a remote Tomcat
* instance that is running behind a firewall. Only this port is configured via
* the listener. The remainder of the configuration is via the standard system
- * properties for configuring JMX.
+ * properties for configuring JMX. Because Tomcat uses a separate MBean server
+ * to the platform MBean server, both servers must be configured separately.
*/
public class JmxRemoteLifecycleListener implements LifecycleListener {
@@ -57,8 +62,10 @@
protected static final StringManager sm =
StringManager.getManager(Constants.Package);
-protected int rmiRegistryPort = -1;
-protected int rmiServerPort = -1;
+protected int rmiRegistryPortPlatform = -1;
+protected int rmiServerPortPlatform = -1;
+protected int rmiRegistryPortCatalina = -1;
+protected int rmiServerPortCatalina = -1;
protected boolean rmiSSL = true;
protected String ciphers[] = null;
protected String protocols[] = null;
@@ -66,39 +73,95 @@
protected boolean authenticate = true;
protected String passwordFile = null;
protected String accessFile = null;
+protected boolean useLocalPorts = false;
/**
- * Get the port on which the RMI server is exported. This is the port that
- * is normally chosen by the RMI stack.
+ * Get the port on which the Platform RMI server is exported. This is the
+ * port that is normally chosen by the RMI stack.
* @returns The port number
*/
-public int getRmiServerPort() {
-return rmiServerPort;
+public int getRmiServerPortPlatform() {
+return rmiServerPortPlatform;
}
/**
- * Set the port on which the RMI server is exported. This is the port that
- * is normally chosen by the RMI stack.
- * @param theRmiServerPort The port number
+ * Set the port on which the Platform RMI server is exported. This is the
+ * port that is normally chosen by the RMI stack.
+ * @param theRmiServerPortPlatform The port number
*/
-public void setRmiServerPort(int theRmiServerPort) {
-rmiServerPort = theRmiServerPort;
+public void setRmiServerPortPlatform(int theRmiServerPortPlatform) {
+rmiServerPortPlatform = theRmiServerPortPlatform;
}
/**
- * Get the port on which the RMI registry is exported.
+ * Get the port on which the Platform RMI registry is exported.
* @returns The port number
*/
-public int getRmiRegistryPort() {
-return rmiRegistryPort;
+public int getRmiRegistryPortPlatform() {
+return rmiRegistryPortPlatform;
}
/**
- * Set the port on which the RMI registryis exported.
- * @param theRmiServerPort The port number
+ * Set the port on which the Platform RMI registry is exported.
+ * @param theRmiRegistryPortPlatform The port number
*/
-public void setRmiRegistryPort(int theRmiRegistryPort) {
-rmiRegistryPort = theRmiRegistryPort;
+public void setRmiRegistryPortPlatform(int theRmiRegistryPortPlatform) {
+rmiRegistryPortPlatform = theRmiRegistryPortPlatform;
+}
+
+/**
+ * Get the port on which the Catalina RMI server is exported. This is the
+ * port that is normally chosen by the RMI stack.
+ * @returns The port number
+ */
+public int getRmiServerPortCatalina() {
+return rmiServerPortCatalina;
+}
+
+/**
+ * Set the port on which the Catalina RMI server is exported. This is the
+ * port that is normally chosen by the RMI stack.
+ * @param theRmiServerPortCatalina The po
