svn commit: r696607 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Author: mturk
Date: Thu Sep 18 02:06:41 2008
New Revision: 696607
URL: http://svn.apache.org/viewvc?rev=696607&view=rev
Log:
Favor done() instead flush() if available. This will send EOS instead FLUSH+EOS
Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=696607&r1=696606&r2=696607&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Thu Sep 18
02:06:41 2008
@@ -1746,12 +1746,14 @@
}
ae->reuse = JK_TRUE;
}
-/* Flush after the last write */
-if (r->flush && !r->flush_packets)
-r->flush(r);
-/* Done with response */
-if (r->done)
+if (r->done) {
+/* Done with response */
r->done(r);
+}
+else if (r->flush && !r->flush_packets) {
+/* Flush after the last write */
+r->flush(r);
+}
JK_TRACE_EXIT(l);
return JK_AJP13_END_RESPONSE;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45812] No EOS bucket when using mod_jk with 401 response
https://issues.apache.org/bugzilla/show_bug.cgi?id=45812 Mladen Turk <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #6 from Mladen Turk <[EMAIL PROTECTED]> 2008-09-18 02:09:22 PST --- OK. I have modified the code so that for last packet only the EOS is send instead flush+eos. This should now behave like mod_proxy_ajp -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45832] New: add DIGEST authentication support to Ant tasks
https://issues.apache.org/bugzilla/show_bug.cgi?id=45832
Summary: add DIGEST authentication support to Ant tasks
Product: Tomcat 6
Version: 6.0.18
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P2
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
It would be useful if the Catalina Ant tasks supported HTTP Digest
authentication, in addition to Basic authentication. This is convenient if one
already has a digest-based security realm and doesn't want to maintain an extra
tomcat-users.xml file. (And Basic authentication is terribly insecure.)
Currently the AbstractCatalinaTask [1] just performs Basic authentication:
// Set up an authorization header with our credentials
String input = username + ":" + password;
String output = new String(Base64.encode(input.getBytes()));
hconn.setRequestProperty("Authorization",
"Basic " + output);
[1]
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.java
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Sep 18 05:49:59 2008 New Revision: 696650 URL: http://svn.apache.org/viewvc?rev=696650&view=rev Log: Update with TCK results - no change with/without patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=696650&r1=696649&r2=696650&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 18 05:49:59 2008 @@ -173,6 +173,9 @@ deleted when ported to 6.0.x +1: markt 0: remm (big patch for a minor issue, so how was this tested ? tck ?) + markt: No change in the TCK results with this patch. We have the + same EL related failures we have without the patch. I'll + look into them as separate issues. -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45447 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45832] add DIGEST authentication support to Ant tasks
https://issues.apache.org/bugzilla/show_bug.cgi?id=45832 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Severity|minor |enhancement --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-18 06:06:37 PST --- Patches are always welcome. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
On Thu, 2008-09-18 at 12:49 +, [EMAIL PROTECTED] wrote: > + markt: No change in the TCK results with this patch. We have the > + same EL related failures we have without the patch. I'll > + look into them as separate issues. I fixed these by regenerating with a newer javacc and usage of the lookahead flag (3 looked sensible). Don't know which one actually fixed the problem. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45832] add DIGEST authentication support to Ant tasks
https://issues.apache.org/bugzilla/show_bug.cgi?id=45832 --- Comment #2 from Marcus Better <[EMAIL PROTECTED]> 2008-09-18 06:35:33 PST --- (In reply to comment #1) > Patches are always welcome. Is it ok to use something like commons-httpclient that does Digest auth? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Remy Maucherat wrote: > On Thu, 2008-09-18 at 12:49 +, [EMAIL PROTECTED] wrote: >> + markt: No change in the TCK results with this patch. We have the >> + same EL related failures we have without the patch. I'll >> + look into them as separate issues. > > I fixed these by regenerating with a newer javacc and usage of the > lookahead flag (3 looked sensible). Don't know which one actually fixed > the problem. So how come those changes haven't been checked back in to svn? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45832] add DIGEST authentication support to Ant tasks
https://issues.apache.org/bugzilla/show_bug.cgi?id=45832 --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-18 06:46:57 PST --- Personally, I'd rather not add a dependency just for that. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
On Thu, 2008-09-18 at 14:41 +0100, Mark Thomas wrote: > Remy Maucherat wrote: > > On Thu, 2008-09-18 at 12:49 +, [EMAIL PROTECTED] wrote: > >> + markt: No change in the TCK results with this patch. We have the > >> + same EL related failures we have without the patch. I'll > >> + look into them as separate issues. > > > > I fixed these by regenerating with a newer javacc and usage of the > > lookahead flag (3 looked sensible). Don't know which one actually fixed > > the problem. > > So how come those changes haven't been checked back in to svn? The problem looks minor (unless you're specifically interested in the TCK at a given point in time). I would have to know what actually fixed it, see if it works in Tomcat (it should) and then run the partial TCK with just Tomcat (I don't know how to do that :( ). So that's a lot of work, and I don't have time for it. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Remy Maucherat wrote: > On Thu, 2008-09-18 at 14:41 +0100, Mark Thomas wrote: >> Remy Maucherat wrote: >>> On Thu, 2008-09-18 at 12:49 +, [EMAIL PROTECTED] wrote: + markt: No change in the TCK results with this patch. We have the + same EL related failures we have without the patch. I'll + look into them as separate issues. >>> I fixed these by regenerating with a newer javacc and usage of the >>> lookahead flag (3 looked sensible). Don't know which one actually fixed >>> the problem. >> So how come those changes haven't been checked back in to svn? > > The problem looks minor (unless you're specifically interested in the > TCK at a given point in time). I would have to know what actually fixed > it, see if it works in Tomcat (it should) and then run the partial TCK > with just Tomcat (I don't know how to do that :( ). So that's a lot of > work, and I don't have time for it. If you used a newer javacc and/or changed the lookahead for the 6.0.18 release that would have resulted in updated .java files. So again, my question is why aren't the updated .java files in svn. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
On Thu, 2008-09-18 at 15:44 +0100, Mark Thomas wrote: > If you used a newer javacc and/or changed the lookahead for the 6.0.18 > release that would have resulted in updated .java files. So again, my > question is why aren't the updated .java files in svn. Because as I said, I don't wish to. I have no idea what is the good value for that lookahead thing (I did try it due to a warning during code generation), I'm just trying to help by pointing out a hack I did. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Remy Maucherat wrote: > On Thu, 2008-09-18 at 15:44 +0100, Mark Thomas wrote: >> If you used a newer javacc and/or changed the lookahead for the 6.0.18 >> release that would have resulted in updated .java files. So again, my >> question is why aren't the updated .java files in svn. > > Because as I said, I don't wish to. I have no idea what is the good > value for that lookahead thing (I did try it due to a warning during > code generation), I'm just trying to help by pointing out a hack I did. Did you include that in the 6.0.18 release or was it just something you did locally? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
On Thu, 2008-09-18 at 16:34 +0100, Mark Thomas wrote: > Did you include that in the 6.0.18 release or was it just something you did > locally? I did my hacking only a few days ago. I don't understand you questions. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696680 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: remm Date: Thu Sep 18 08:53:56 2008 New Revision: 696680 URL: http://svn.apache.org/viewvc?rev=696680&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=696680&r1=696679&r2=696680&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 18 08:53:56 2008 @@ -171,8 +171,8 @@ http://svn.apache.org/viewvc?rev=696061&view=rev Note: Methods deleted in the above patch will be deprecated rather than deleted when ported to 6.0.x - +1: markt - 0: remm (big patch for a minor issue, so how was this tested ? tck ?) + +1: markt, remm (ok, I suppose it should work well enough then) + 0: markt: No change in the TCK results with this patch. We have the same EL related failures we have without the patch. I'll look into them as separate issues. @@ -206,10 +206,11 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45419 Set Accept-Ranges for static resources served by DefaultServlet http://svn.apache.org/viewvc?rev=696408&view=rev - +1: markt + +1: markt, remm -1: * Allow asynchronous close() and setTimeout() on CometEvents http://svn.apache.org/viewvc?view=rev&revision=645175 +1: fhanik + 0: remm (maybe, don't know ...) -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696683 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: pero Date: Thu Sep 18 09:04:19 2008 New Revision: 696683 URL: http://svn.apache.org/viewvc?rev=696683&view=rev Log: Cast my vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=696683&r1=696682&r2=696683&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 18 09:04:19 2008 @@ -81,7 +81,7 @@ * http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHost.java?r1=593649&r2=685530&diff_format=h Provide full stacktrace/message when ErrorReportValveClass can't be instantiated. - +1: funkman, remm, fhanik + +1: funkman, remm, fhanik, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 @@ -162,7 +162,7 @@ Ignore directories named xxx.jar in WEB-INF/lib http://svn.apache.org/viewvc?rev=695274&view=rev http://svn.apache.org/viewvc?rev=695284&view=rev - +1: markt, remm + +1: markt, remm, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45451 @@ -181,20 +181,20 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45447 Update Spanish translations. Patch by Jesus Marin http://svn.apache.org/viewvc?rev=696073&view=rev - +1: markt, remm + +1: markt, remm, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45823 Log missing request headers as - not null Based on a patch by Per Landberg http://svn.apache.org/viewvc?rev=696234&view=rev - +1: markt, remm + +1: markt, remm, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45441 Correctly map filters for FORWARD and INCLUDE http://svn.apache.org/viewvc?rev=696240&view=rev - +1: markt, remm + +1: markt, remm, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45427 @@ -206,11 +206,11 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45419 Set Accept-Ranges for static resources served by DefaultServlet http://svn.apache.org/viewvc?rev=696408&view=rev - +1: markt, remm + +1: markt, remm, pero -1: * Allow asynchronous close() and setTimeout() on CometEvents http://svn.apache.org/viewvc?view=rev&revision=645175 +1: fhanik - 0: remm (maybe, don't know ...) + 0: remm (maybe, don't know ...), pero ( Is close and timeout also working with APR?) -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Remy Maucherat wrote: > On Thu, 2008-09-18 at 16:34 +0100, Mark Thomas wrote: >> Did you include that in the 6.0.18 release or was it just something you did >> locally? > > I did my hacking only a few days ago. I don't understand you questions. My questions are trying to understand the timing. Basically whether a) 6.0.18 went out with TCK failures or b) you fixed the failures as part of the 6.0.18 release or c) some change in svn post 6.0.18 caused the failures. It wasn't clear to me which it was. Your most recent message makes things clear that it is c). It looks like the new fix for 42565 still has some issues. It's good to know that a new javacc / lookahead 3 should fix it but I would like to understand why if only to avoid breaking EL again with any future change. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696702 - in /tomcat/trunk/java/org/apache/el: ./ lang/ parser/ util/
Author: rjung
Date: Thu Sep 18 09:48:10 2008
New Revision: 696702
URL: http://svn.apache.org/viewvc?rev=696702&view=rev
Log:
Tab police and trailing whitespace deletion
for package a.o.el (except for generated java files).
Modified:
tomcat/trunk/java/org/apache/el/MethodExpressionLiteral.java
tomcat/trunk/java/org/apache/el/ValueExpressionLiteral.java
tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java
tomcat/trunk/java/org/apache/el/lang/ELSupport.java
tomcat/trunk/java/org/apache/el/lang/EvaluationContext.java
tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
tomcat/trunk/java/org/apache/el/lang/FunctionMapperFactory.java
tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java
tomcat/trunk/java/org/apache/el/lang/VariableMapperFactory.java
tomcat/trunk/java/org/apache/el/lang/VariableMapperImpl.java
tomcat/trunk/java/org/apache/el/parser/ELParser.jjt
tomcat/trunk/java/org/apache/el/util/ConcurrentCache.java
tomcat/trunk/java/org/apache/el/util/MessageFactory.java
Modified: tomcat/trunk/java/org/apache/el/MethodExpressionLiteral.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/MethodExpressionLiteral.java?rev=696702&r1=696701&r2=696702&view=diff
==
--- tomcat/trunk/java/org/apache/el/MethodExpressionLiteral.java (original)
+++ tomcat/trunk/java/org/apache/el/MethodExpressionLiteral.java Thu Sep 18
09:48:10 2008
@@ -36,13 +36,13 @@
private Class expectedType;
private String expr;
-
+
private Class[] paramTypes;
-
+
public MethodExpressionLiteral() {
// do nothing
}
-
+
public MethodExpressionLiteral(String expr, Class expectedType, Class[]
paramTypes) {
this.expr = expr;
this.expectedType = expectedType;
Modified: tomcat/trunk/java/org/apache/el/ValueExpressionLiteral.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/ValueExpressionLiteral.java?rev=696702&r1=696701&r2=696702&view=diff
==
--- tomcat/trunk/java/org/apache/el/ValueExpressionLiteral.java (original)
+++ tomcat/trunk/java/org/apache/el/ValueExpressionLiteral.java Thu Sep 18
09:48:10 2008
@@ -44,7 +44,7 @@
public ValueExpressionLiteral() {
super();
}
-
+
public ValueExpressionLiteral(Object value, Class expectedType) {
this.value = value;
this.expectedType = expectedType;
Modified: tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java?rev=696702&r1=696701&r2=696702&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java Thu Sep 18 09:48:10
2008
@@ -5,9 +5,9 @@
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -110,12 +110,12 @@
public final static class DoubleDelegate extends ELArithmetic {
protected Number add(Number num0, Number num1) {
- // could only be one of these
- if (num0 instanceof BigDecimal) {
- return ((BigDecimal) num0).add(new
BigDecimal(num1.doubleValue()));
- } else if (num1 instanceof BigDecimal) {
- return ((new
BigDecimal(num0.doubleValue()).add((BigDecimal) num1)));
- }
+// could only be one of these
+if (num0 instanceof BigDecimal) {
+return ((BigDecimal) num0).add(new
BigDecimal(num1.doubleValue()));
+} else if (num1 instanceof BigDecimal) {
+return ((new BigDecimal(num0.doubleValue()).add((BigDecimal)
num1)));
+}
return new Double(num0.doubleValue() + num1.doubleValue());
}
@@ -123,7 +123,7 @@
if (num instanceof Double)
return num;
if (num instanceof BigInteger)
- return new BigDecimal((BigInteger) num);
+return new BigDecimal((BigInteger) num);
return new Double(num.doubleValue());
}
@@ -140,22 +140,22 @@
}
protected Number subtract(Number num0, Number num1) {
- // could only be one of these
- if (num0 instanceof BigDecimal) {
- return ((BigDecimal) num0).subtract(
svn commit: r696714 - in /tomcat/trunk/java/org/apache/el/lang: ExpressionBuilder.java FunctionMapperImpl.java VariableMapperImpl.java
Author: rjung
Date: Thu Sep 18 10:03:38 2008
New Revision: 696714
URL: http://svn.apache.org/viewvc?rev=696714&view=rev
Log:
Use generics to improve type safetyness.
Please check readExternal() in FunctionMapperImpl
and VariableMapperImpl. The type of the persisted
Map has changed. Does this pose a consistency
problem with other components or older, already
persisted Maps?
Modified:
tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java
tomcat/trunk/java/org/apache/el/lang/VariableMapperImpl.java
Modified: tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java?rev=696714&r1=696713&r2=696714&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java Thu Sep 18
10:03:38 2008
@@ -50,7 +50,7 @@
*/
public final class ExpressionBuilder implements NodeVisitor {
-private static final ConcurrentCache cache = new ConcurrentCache(5000);
+private static final ConcurrentCache cache = new
ConcurrentCache(5000);
private FunctionMapper fnMapper;
@@ -87,7 +87,7 @@
throw new ELException(MessageFactory.get("error.null"));
}
-Node n = (Node) cache.get(expr);
+Node n = cache.get(expr);
if (n == null) {
try {
n = (new ELParser(new StringReader(expr)))
Modified: tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java?rev=696714&r1=696713&r2=696714&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/FunctionMapperImpl.java Thu Sep 18
10:03:38 2008
@@ -39,7 +39,7 @@
private static final long serialVersionUID = 1L;
-protected Map functions = null;
+protected Map functions = null;
/*
* (non-Javadoc)
@@ -49,7 +49,7 @@
*/
public Method resolveFunction(String prefix, String localName) {
if (this.functions != null) {
-Function f = (Function) this.functions.get(prefix + ":" +
localName);
+Function f = this.functions.get(prefix + ":" + localName);
return f.getMethod();
}
return null;
@@ -57,7 +57,7 @@
public void addFunction(String prefix, String localName, Method m) {
if (this.functions == null) {
-this.functions = new HashMap();
+this.functions = new HashMap();
}
Function f = new Function(prefix, localName, m);
synchronized (this) {
@@ -81,7 +81,7 @@
*/
public void readExternal(ObjectInput in) throws IOException,
ClassNotFoundException {
-this.functions = (Map) in.readObject();
+this.functions = (Map) in.readObject();
}
public static class Function implements Externalizable {
Modified: tomcat/trunk/java/org/apache/el/lang/VariableMapperImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/VariableMapperImpl.java?rev=696714&r1=696713&r2=696714&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/VariableMapperImpl.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/VariableMapperImpl.java Thu Sep 18
10:03:38 2008
@@ -31,23 +31,23 @@
private static final long serialVersionUID = 1L;
-private Map vars = new HashMap();
+private Map vars = new HashMap();
public VariableMapperImpl() {
super();
}
public ValueExpression resolveVariable(String variable) {
-return (ValueExpression) this.vars.get(variable);
+return this.vars.get(variable);
}
public ValueExpression setVariable(String variable,
ValueExpression expression) {
-return (ValueExpression) this.vars.put(variable, expression);
+return this.vars.put(variable, expression);
}
public void readExternal(ObjectInput in) throws IOException,
ClassNotFoundException {
-this.vars = (Map) in.readObject();
+this.vars = (Map) in.readObject();
}
public void writeExternal(ObjectOutput out) throws IOException {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696716 - /tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
Author: rjung
Date: Thu Sep 18 10:08:10 2008
New Revision: 696716
URL: http://svn.apache.org/viewvc?rev=696716&view=rev
Log:
Fix ClassCastException when we try to cast a
NullPointerException to an ELException.
I still need to investigate where the NPE came from,
but simply casting seems unsafe in any case.
Use a cast if possible and recreate exception
otherwise.
Modified:
tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
Modified: tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java?rev=696716&r1=696715&r2=696716&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java Thu Sep 18
10:08:10 2008
@@ -132,7 +132,11 @@
try {
node.accept(this);
} catch (Exception e) {
-throw (ELException) e;
+if (e instanceof ELException) {
+throw (ELException) e;
+} else {
+throw (new ELException(e));
+}
}
if (this.fnMapper instanceof FunctionMapperFactory) {
this.fnMapper = ((FunctionMapperFactory) this.fnMapper).create();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
On Thu, 2008-09-18 at 17:27 +0100, Mark Thomas wrote: > My questions are trying to understand the timing. Basically whether a) > 6.0.18 went out with TCK failures or b) you fixed the failures as part of > the 6.0.18 release or c) some change in svn post 6.0.18 caused the > failures. It wasn't clear to me which it was. Not certain about 6.0.18 (I think it should be ok, though), but it's most definitely after the latest fix that I used my hack, and it worked. > Your most recent message makes things clear that it is c). It looks like > the new fix for 42565 still has some issues. It's good to know that a new > javacc / lookahead 3 should fix it but I would like to understand why if > only to avoid breaking EL again with any future change. I don't really know what I am doing with that EL parser, so no idea about optimal parameters. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696650 - /tomcat/tc6.0.x/trunk/STATUS.txt
Remy Maucherat wrote: > On Thu, 2008-09-18 at 17:27 +0100, Mark Thomas wrote: >> My questions are trying to understand the timing. Basically whether a) >> 6.0.18 went out with TCK failures or b) you fixed the failures as part of >> the 6.0.18 release or c) some change in svn post 6.0.18 caused the >> failures. It wasn't clear to me which it was. > > Not certain about 6.0.18 (I think it should be ok, though), but it's > most definitely after the latest fix that I used my hack, and it worked. 6.0.18 is OK. The EL tests all pass. >> Your most recent message makes things clear that it is c). It looks like >> the new fix for 42565 still has some issues. It's good to know that a new >> javacc / lookahead 3 should fix it but I would like to understand why if >> only to avoid breaking EL again with any future change. > > I don't really know what I am doing with that EL parser, so no idea > about optimal parameters. You know about as much as me then ;) I still get the problems with the latest javacc so it must be your look ahead change that fixed it. I do get a couple of look ahead warnings when I run javacc so I am going to see if I can put in explicit fixes for those warnings rather than setting the look ahead globally. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696780 - /tomcat/trunk/java/org/apache/el/parser/ELParser.jjt
Author: markt
Date: Thu Sep 18 12:42:54 2008
New Revision: 696780
URL: http://svn.apache.org/viewvc?rev=696780&view=rev
Log:
Add explicit lookaheads where they could be ambiguity. This resolves some TCK
failures with the fix for 42565.
Modified:
tomcat/trunk/java/org/apache/el/parser/ELParser.jjt
Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.jjt
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/ELParser.jjt?rev=696780&r1=696779&r2=696780&view=diff
==
--- tomcat/trunk/java/org/apache/el/parser/ELParser.jjt (original)
+++ tomcat/trunk/java/org/apache/el/parser/ELParser.jjt Thu Sep 18 12:42:54 2008
@@ -104,7 +104,7 @@
*/
void Choice() : {}
{
-Or() ( Choice() Choice() #Choice(3))*
+Or() (LOOKAHEAD(3) Choice() Choice() #Choice(3))*
}
/*
@@ -278,7 +278,7 @@
Token t1 = null;
}
{
-(t0= )? t1=
+(LOOKAHEAD(2) t0= )? t1=
{
if (t0 != null) {
jjtThis.setPrefix(t0.image);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696782 [2/2] - in /tomcat/trunk/java/org/apache/el/parser: ELParser.java ELParserConstants.java ELParserTokenManager.java ELParserTreeConstants.java JJTELParserState.java ParseException.j
Modified: tomcat/trunk/java/org/apache/el/parser/ELParserTokenManager.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/ELParserTokenManager.java?rev=696782&r1=696781&r2=696782&view=diff
==
--- tomcat/trunk/java/org/apache/el/parser/ELParserTokenManager.java (original)
+++ tomcat/trunk/java/org/apache/el/parser/ELParserTokenManager.java Thu Sep 18
12:53:24 2008
@@ -1,27 +1,15 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
/* Generated By:JJTree&JavaCC: Do not edit this line.
ELParserTokenManager.java */
package org.apache.el.parser;
import java.io.StringReader;
import javax.el.ELException;
+/** Token Manager. */
public class ELParserTokenManager implements ELParserConstants
{
+
+ /** Debug output. */
public java.io.PrintStream debugStream = System.out;
+ /** Set debug output. */
public void setDebugStream(java.io.PrintStream ds) { debugStream = ds; }
private final int jjStopStringLiteralDfa_0(int pos, long active0)
{
@@ -49,21 +37,13 @@
{
return jjMoveNfa_0(jjStopStringLiteralDfa_0(pos, active0), pos + 1);
}
-private final int jjStopAtPos(int pos, int kind)
+private int jjStopAtPos(int pos, int kind)
{
jjmatchedKind = kind;
jjmatchedPos = pos;
return pos + 1;
}
-private final int jjStartNfaWithStates_0(int pos, int kind, int state)
-{
- jjmatchedKind = kind;
- jjmatchedPos = pos;
- try { curChar = input_stream.readChar(); }
- catch(java.io.IOException e) { return pos + 1; }
- return jjMoveNfa_0(state, pos + 1);
-}
-private final int jjMoveStringLiteralDfa0_0()
+private int jjMoveStringLiteralDfa0_0()
{
switch(curChar)
{
@@ -77,7 +57,7 @@
return jjMoveNfa_0(7, 0);
}
}
-private final int jjMoveStringLiteralDfa1_0(long active0)
+private int jjMoveStringLiteralDfa1_0(long active0)
{
try { curChar = input_stream.readChar(); }
catch(java.io.IOException e) {
@@ -97,35 +77,13 @@
}
return jjStartNfa_0(0, active0);
}
-private final void jjCheckNAdd(int state)
-{
- if (jjrounds[state] != jjround)
- {
- jjstateSet[jjnewStateCnt++] = state;
- jjrounds[state] = jjround;
- }
-}
-private final void jjAddStates(int start, int end)
+private int jjStartNfaWithStates_0(int pos, int kind, int state)
{
- do {
- jjstateSet[jjnewStateCnt++] = jjnextStates[start];
- } while (start++ != end);
-}
-private final void jjCheckNAddTwoStates(int state1, int state2)
-{
- jjCheckNAdd(state1);
- jjCheckNAdd(state2);
-}
-private final void jjCheckNAddStates(int start, int end)
-{
- do {
- jjCheckNAdd(jjnextStates[start]);
- } while (start++ != end);
-}
-private final void jjCheckNAddStates(int start)
-{
- jjCheckNAdd(jjnextStates[start]);
- jjCheckNAdd(jjnextStates[start + 1]);
+ jjmatchedKind = kind;
+ jjmatchedPos = pos;
+ try { curChar = input_stream.readChar(); }
+ catch(java.io.IOException e) { return pos + 1; }
+ return jjMoveNfa_0(state, pos + 1);
}
static final long[] jjbitVec0 = {
0xfffeL, 0xL, 0xL,
0xL
@@ -133,14 +91,13 @@
static final long[] jjbitVec2 = {
0x0L, 0x0L, 0xL, 0xL
};
-private final int jjMoveNfa_0(int startState, int curPos)
+private int jjMoveNfa_0(int startState, int curPos)
{
- int[] nextStates;
int startsAt = 0;
jjnewStateCnt = 8;
int i = 1;
jjstateSet[0] = startState;
- int j, kind = 0x7fff;
+ int kind = 0x7fff;
for (;;)
{
if (++jjround == 0x7fff)
@@ -148,7 +105,7 @@
if (curChar < 64)
{
long l = 1L << curChar;
- MatchLoop: do
+ do
{
switch(jjstateSet[--i])
{
@@ -212,7 +169,7 @@
else if (curChar < 128)
{
long l = 1L << (curChar & 077);
- MatchLoop: do
+ do
{
switch(jjstateSet[--i])
{
@@ -263,7 +220,7 @@
long l1 = 1L << (hiByte & 077);
int i2 = (curChar & 0xff) >> 6;
long l2 = 1L << (curChar & 077);
- MatchLoop: do
+ do
{
switch(jjstateSet[-
EL and TCK
With the recent fixes to the EL code it appears that there is a bug in the
TCK. I won't repeat the exact test since the TCK licence won't let me do
that but a simple version is that the TCK thinks the following expression
should be valid:
${\'string literal\'}
For those of you with access to the TCK, mail me privately if you want the
real expression the TCK is using.
My reading of the EL spec is that string literals *must* be quoted. Single
or double, take you pick but you have to use one or the other. Note that
the quotes in the example above are escaped so they don't count.
Before I embark on trying to convince the EG there is a bug in the TCK can
anyone see a reason why the above?
Cheers,
Mark
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45837] New: page implicit object typed as Object instead of HttpJspPage
https://issues.apache.org/bugzilla/show_bug.cgi?id=45837 Summary: page implicit object typed as Object instead of HttpJspPage Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In a JSP page, the page object (see below) in the generated servlet code is typed as Object instead of HttpJspPage, which makes it difficult to call meaningful methods on it. PageContext pageContext = null; ServletContext application = null; ServletConfig config = null; JspWriter out = null; Object page = this; JspWriter _jspx_out = null; PageContext _jspx_page_context = null; The workaround is to use "this" instead. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r696810 - in /tomcat/trunk/java: javax/el/ javax/servlet/ org/apache/catalina/ha/ org/apache/catalina/ha/session/ org/apache/catalina/ha/tcp/ org/apache/catalina/manager/host/ org/apache/c
Author: markt
Date: Thu Sep 18 14:18:41 2008
New Revision: 696810
URL: http://svn.apache.org/viewvc?rev=696810&view=rev
Log:
More Spanish translations
Added:
tomcat/trunk/java/javax/el/LocalStrings_es.properties (with props)
tomcat/trunk/java/javax/servlet/LocalStrings_es.properties (with props)
tomcat/trunk/java/org/apache/catalina/ha/LocalStrings_es.properties (with
props)
tomcat/trunk/java/org/apache/catalina/ha/session/LocalStrings_es.properties
(with props)
tomcat/trunk/java/org/apache/catalina/ha/tcp/LocalStrings_es.properties
(with props)
tomcat/trunk/java/org/apache/catalina/manager/host/LocalStrings_es.properties
(with props)
tomcat/trunk/java/org/apache/catalina/tribes/LocalStrings_es.properties
(with props)
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings_es.properties
(with props)
tomcat/trunk/java/org/apache/catalina/tribes/transport/LocalStrings_es.properties
(with props)
tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties (with
props)
tomcat/trunk/java/org/apache/el/Messages_es.properties (with props)
Added: tomcat/trunk/java/javax/el/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/LocalStrings_es.properties?rev=696810&view=auto
==
--- tomcat/trunk/java/javax/el/LocalStrings_es.properties (added)
+++ tomcat/trunk/java/javax/el/LocalStrings_es.properties Thu Sep 18 14:18:41
2008
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+propertyNotFound = Propiedad ''{1}'' no hallada en el tipo {0}
+propertyNotReadable = Propiedad ''{1}'' no legible para el tipo {0}
+propertyNotWritable = Propiedad ''{1}'' no grabable para el tipo {0}
+propertyReadError = Error reading ''{1}'' en el tipo {0}
+propertyWriteError = Error writing ''{1}'' en el tipo {0}
+resolverNotWritable = ELResolver no grabable para el tipo {0}
Propchange: tomcat/trunk/java/javax/el/LocalStrings_es.properties
--
svn:eol-style = native
Added: tomcat/trunk/java/javax/servlet/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/LocalStrings_es.properties?rev=696810&view=auto
==
--- tomcat/trunk/java/javax/servlet/LocalStrings_es.properties (added)
+++ tomcat/trunk/java/javax/servlet/LocalStrings_es.properties Thu Sep 18
14:18:41 2008
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+err.not_iso8859_1 = No es un car\u00E1cter ISO 8859-1\: {0}
+value.true = true
+value.false = false
Propchange: tomcat/trunk/java/javax/servlet/LocalStrings_es.properties
--
svn:eol-style = native
Added: tomcat/trunk/java/org/apache/catalina/ha/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/LocalStrings_es.properties?rev=696810&view=auto
==
--- tomcat/trunk/java/org/apache/catalina/ha/LocalStrings_es.properties (added)
+++ tomcat/trunk/java/org/apache/catalina/ha/LocalStrings_es.properties Thu Sep
18 14:18:41 2008
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license a
svn commit: r696812 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Sep 18 14:22:19 2008 New Revision: 696812 URL: http://svn.apache.org/viewvc?rev=696812&view=rev Log: Proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=696812&r1=696811&r2=696812&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 18 14:22:19 2008 @@ -214,3 +214,14 @@ +1: fhanik 0: remm (maybe, don't know ...), pero ( Is close and timeout also working with APR?) -1: + +* More EL fixes. Add lookaheads to prevent parsing ambiguity + http://svn.apache.org/viewvc?rev=696780&view=rev (the change) + http://svn.apache.org/viewvc?rev=696782&view=rev (the auto generated code) + +1: mark + -1: + +* More Spanish translations that I missed in the previous commit + http://svn.apache.org/viewvc?rev=696810&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45840] New: Issue : 44860 : Cookie problem exists in 5.5.26
https://issues.apache.org/bugzilla/show_bug.cgi?id=45840 Summary: Issue : 44860 : Cookie problem exists in 5.5.26 Product: Tomcat 5 Version: 5.5.27 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Please refer to bug# 44860 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AntiResourceLocking Side Effect
Hi Jonathan, I also used antiResourceLocking flag in context.xml. Once the flag is set to true, Tomcat starts exploding web application in temp directory. It works well for me in Linux and Windows environment, but in AIX, I cannot even start tomcat with antiResourceLocking flag set to true. When I saw the my application folder in temp, I saw all files were of zero bytes. And in the catalina logs I see it gives SAX parse exception. Well since all files including web.xml is of 0 bytes, then tomcat cannot start. Have you noticed this problem. I am using tomcat 6.018. Thanks, Vikas Sharma Jonathan Holloway wrote: > > Hi all, > > Just a quick introduction, I'm Jonathan Holloway, I recently became a > contributer with Apache. > I've been using Java and Apache software since 1998 or so... : ) > > I really wanted to get an understanding on an issue that's in the Apache > documentation regarding > antiResourceLocking which is set on the Context element. The bug is here: > > https://issues.apache.org/bugzilla/show_bug.cgi?id=37668 > > The side effect of setting this is that JSP's or in our case Velocity > templates are not reloaded. This > is a bit of pain for development, but is required for production on a > Windows server (I'm told). > > Is this considered a bug still and does it need a fix proposed, or is it > an > accepted side effect? We've > solved this by substituting the value into our context.xml file for > production.. > > I'd also like to know the best way to get started with becoming a Tomcat > contributor, could I possibly > help out by doing some documentation work for now? If you need any help > here then please let me know. > > Many thanks, > Jon. > > -- > Web: http://www.jonathanholloway.co.uk > Mail: [EMAIL PROTECTED] > IM: [EMAIL PROTECTED] > > -- View this message in context: http://www.nabble.com/AntiResourceLocking-Side-Effect-tp18618364p19564995.html Sent from the Tomcat - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r696780 - /tomcat/trunk/java/org/apache/el/parser/ELParser.jjt
On Thu, 2008-09-18 at 19:42 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Thu Sep 18 12:42:54 2008 > New Revision: 696780 > > URL: http://svn.apache.org/viewvc?rev=696780&view=rev > Log: > Add explicit lookaheads where they could be ambiguity. This resolves some TCK > failures with the fix for 42565. I suppose not abusing lookahead is a lot more efficient. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45840] Issue : 44860 : Cookie problem exists in 5.5.26
https://issues.apache.org/bugzilla/show_bug.cgi?id=45840 Filip Hanik <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Filip Hanik <[EMAIL PROTECTED]> 2008-09-18 19:03:32 PST --- Should be resolved in 5.5.27. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AntiResourceLocking Side Effect
I can't say I have seen this issue having not deployed on AIX. This problem was specifically on Windows and Linux (the actual side effect I saw). It doesn't sound like it's permissions based since the files you mention are actually created. If you're starting tomcat via the sh file under AIX try starting it with the -x flag and see if it gives you any clues as to whether it's not starting. Hope that helps, Jon. 2008/9/18 Vikas Sharma <[EMAIL PROTECTED]> > > Hi Jonathan, > > I also used antiResourceLocking flag in context.xml. Once the flag is set > to true, Tomcat starts exploding web application in temp directory. It > works > well for me in Linux and Windows environment, but in AIX, I cannot even > start tomcat with antiResourceLocking flag set to true. > > When I saw the my application folder in temp, I saw all files were of zero > bytes. And in the catalina logs I see it gives SAX parse exception. Well > since all files including web.xml is of 0 bytes, then tomcat cannot start. > > Have you noticed this problem. I am using tomcat 6.018. > > Thanks, > > Vikas Sharma > > Jonathan Holloway wrote: > > > > Hi all, > > > > Just a quick introduction, I'm Jonathan Holloway, I recently became a > > contributer with Apache. > > I've been using Java and Apache software since 1998 or so... : ) > > > > I really wanted to get an understanding on an issue that's in the Apache > > documentation regarding > > antiResourceLocking which is set on the Context element. The bug is > here: > > > > https://issues.apache.org/bugzilla/show_bug.cgi?id=37668 > > > > The side effect of setting this is that JSP's or in our case Velocity > > templates are not reloaded. This > > is a bit of pain for development, but is required for production on a > > Windows server (I'm told). > > > > Is this considered a bug still and does it need a fix proposed, or is it > > an > > accepted side effect? We've > > solved this by substituting the value into our context.xml file for > > production.. > > > > I'd also like to know the best way to get started with becoming a Tomcat > > contributor, could I possibly > > help out by doing some documentation work for now? If you need any help > > here then please let me know. > > > > Many thanks, > > Jon. > > > > -- > > Web: http://www.jonathanholloway.co.uk > > Mail: [EMAIL PROTECTED] > > IM: [EMAIL PROTECTED] > > > > > > -- > View this message in context: > http://www.nabble.com/AntiResourceLocking-Side-Effect-tp18618364p19564995.html > Sent from the Tomcat - Dev mailing list archive at Nabble.com. > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Web: http://www.jonathanholloway.co.uk Mail: [EMAIL PROTECTED] IM: [EMAIL PROTECTED]
