Re: 5.5.27
Filip Hanik - Dev Lists wrote: there is a required patch in STATUS.txt before I can actually move this, right now its failing TCK tests Filip Filip Hanik - Dev Lists wrote: How about cutting a release candidate on Monday, Aug 18th and if all is well, have a release towards end of next week? Don't we have the same erreur in trunk and tc6.0.x? Cheers Jean-Frederic Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r687996 - /tomcat/current/tc5.5.x/STATUS.txt
Author: jfclere Date: Fri Aug 22 00:24:22 2008 New Revision: 687996 URL: http://svn.apache.org/viewvc?rev=687996&view=rev Log: my vote. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=687996&r1=687995&r2=687996&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Fri Aug 22 00:24:22 2008 @@ -90,6 +90,6 @@ * Additional fix for 44494, holding up 5.5.27 http://people.apache.org/~fhanik/patches/55-44494.patch Reproduce error, call getReader, but never use the converter. You'll get a NPE on InputBuffer.recycle() - +1: fhanik + +1: fhanik, jfclere -1: - \ No newline at end of file + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r688013 - /tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestBind.java
Author: jfclere
Date: Fri Aug 22 01:08:53 2008
New Revision: 688013
URL: http://svn.apache.org/viewvc?rev=688013&view=rev
Log:
Improve the test.
Modified:
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestBind.java
Modified:
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestBind.java
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestBind.java?rev=688013&r1=688012&r2=688013&view=diff
==
---
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestBind.java
(original)
+++
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestBind.java
Fri Aug 22 01:08:53 2008
@@ -23,6 +23,7 @@
import junit.framework.TestCase;
import java.io.OutputStream;
+import java.io.InputStream;
import java.net.NetworkInterface;
import java.net.InetAddress;
import java.util.*;
@@ -70,11 +71,17 @@
while (running) {
/* Accept it */
long clientSock = Socket.accept(serverSock);
+Socket.timeoutSet(clientSock, 1);
byte [] buf = new byte[1];
while (Socket.recv(clientSock, buf, 0, 1) == 1) {
+if (buf[0] == 'A') {
+buf[0] = 'Z';
+Socket.send(clientSock, buf, 0, 1);
+}
}
-if (buf[0] != 'A')
-break;
+Socket.close(clientSock);
+if (buf[0] != 'Z')
+running = false;
}
client.join();
Library.terminate();
@@ -95,11 +102,15 @@
InetAddress ia = (InetAddress)addrs.nextElement();
System.out.println("Trying: " + ia.getHostAddress());
java.net.Socket sock = new java.net.Socket(ia, port);
+ sock.setSoTimeout(1);
OutputStream ou = sock.getOutputStream();
+ InputStream in = sock.getInputStream();
ou.write('A');
ou.flush();
- java.lang.Thread.sleep(1);
- ou.close();
+ int rep = in.read();
+ sock.close();
+ if (rep != 'Z')
+throw new Exception("Read wrong data");
}
}
} catch(Exception ex ) {
@@ -112,8 +123,7 @@
OutputStream ou = sock.getOutputStream();
ou.write('E');
ou.flush();
- java.lang.Thread.sleep(1);
- ou.close();
+ sock.close();
} catch(Exception ex ) {
ex.printStackTrace();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43327] Socket bind fails on tomcat startup when using apr
https://issues.apache.org/bugzilla/show_bug.cgi?id=43327 --- Comment #22 from Remy Maucherat <[EMAIL PROTECTED]> 2008-08-22 01:46:43 PST --- With the latest changes, this now works :) Really tricky to get right ... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r688038 - /tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
Author: jfclere
Date: Fri Aug 22 02:29:14 2008
New Revision: 688038
URL: http://svn.apache.org/viewvc?rev=688038&view=rev
Log:
Close sockets in case of errors (and when not needed).
Modified:
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
Modified:
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java?rev=688038&r1=688037&r2=688038&view=diff
==
---
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
(original)
+++
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
Fri Aug 22 02:29:14 2008
@@ -52,6 +52,7 @@
Socket.APR_PROTO_TCP, serverPool);
int rc = Socket.bind(serverSock, inetAddress);
if (rc != 0) {
+Socket.close(serverSock);
throw(new Exception("Can't bind: " + Error.strerror(rc)));
}
Socket.listen(serverSock, 5);
@@ -67,22 +68,30 @@
/* Try 2 milliseconds timeout */
Socket.timeoutSet(clientSock, 2000);
long timeout = Socket.timeoutGet(clientSock);
-if (timeout != 2000)
+if (timeout != 2000) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("Socket.timeoutGet clientSock failed");
+}
long start = System.currentTimeMillis();
byte [] buf = new byte[1];
while (Socket.recv(clientSock, buf, 0, 1) == 1) {
}
long wait = System.currentTimeMillis() - start;
-if (wait < 1 || wait >3)
+if (wait < 1 || wait >3) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("2 milliseconds client Socket.timeoutSet
failed");
+}
/* Try 2 milliseconds timeout on accept socket */
Socket.timeoutSet(serverSock, 2000);
timeout = Socket.timeoutGet(serverSock);
-if (timeout != 2000)
+if (timeout != 2000) {
+Socket.close(serverSock);
throw new Exception("Socket.timeoutGet serverSock failed");
+}
start = System.currentTimeMillis();
boolean ok = false;
@@ -92,14 +101,19 @@
ok = true;
}
wait = System.currentTimeMillis() - start;
-if (wait < 1 || wait >3 && ! ok)
+if (wait < 1 || wait >3 && ! ok) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("2 milliseconds accept Socket.timeoutSet
failed");
+}
/* Try APR_SO_NONBLOCK */
Socket.optSet(serverSock, Socket.APR_SO_NONBLOCK, 1);
int val = Socket.optGet(serverSock, Socket.APR_SO_NONBLOCK);
-if (val != 1)
+if (val != 1) {
+Socket.close(serverSock);
throw new Exception("Socket.optGet serverSock failed");
+}
start = System.currentTimeMillis();
ok = false;
@@ -109,9 +123,13 @@
ok = true;
}
wait = System.currentTimeMillis() - start;
-if (wait > 1 && ! ok)
+if (wait > 1 && ! ok) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("non_blocking accept Socket.APR_SO_NONBLOCK
failed");
+}
client.join();
+Socket.close(clientSock);
/* Try the same on client socket */
client = new Client();
@@ -120,14 +138,20 @@
clientSock = Socket.accept(serverSock);
Socket.optSet(clientSock, Socket.APR_SO_NONBLOCK, 1);
val = Socket.optGet(clientSock, Socket.APR_SO_NONBLOCK);
-if (val != 1)
+if (val != 1) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("Socket.optGet clientSock failed");
+}
start = System.currentTimeMillis();
while (Socket.recv(clientSock, buf, 0, 1) == 1) {
}
wait = System.currentTimeMillis() - start;
-if (wait > 1)
+if (wait > 1) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("non_blocking client Socket.APR_SO_NONBLOCK
failed");
+}
/* Now blocking */
Socket.optSet(clientSock, Socket.APR_SO_NONBLOCK, 0);
@@ -135,10 +159,15 @@
while (Socket.recv(clientSock, buf, 0, 1) == 1) {
}
wait = System.currentTimeMillis() - start;
-if (wait < 1)
+if (wait < 1) {
+Socket.close(clientSock);
+Socket.close(serverSock);
throw new Exception("non_blocking client Socket.APR_SO_NONBLOCK
false failed");
+}
client.join();
+Socket.close(clientS
svn commit: r688043 - /tomcat/current/tc5.5.x/STATUS.txt
Author: rjung Date: Fri Aug 22 02:44:20 2008 New Revision: 688043 URL: http://svn.apache.org/viewvc?rev=688043&view=rev Log: Vote. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=688043&r1=688042&r2=688043&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Fri Aug 22 02:44:20 2008 @@ -28,7 +28,7 @@ * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44282 Do call to getClassLoader() in a privileged block. http://svn.apache.org/viewvc?rev=616953&view=rev (less the generics stuff) - +1: markt, fhanik + +1: markt, fhanik, rjung -1: 0: yoavs (because I think there might be a bug when we're only diong the work if log.isTraceEnabled) markt I believe this is correct. The privileged block is only required for @@ -50,23 +50,25 @@ -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45591 - NPE on start-up failure in some cases. Based on a patch by Matt Passell + NPE on shutdown failure in some cases. Based on a patch by Matt Passell http://svn.apache.org/viewvc?rev=683982&view=rev - +1: markt, fhanik + +1: markt, fhanik, rjung -1: * JAASMemoryLoginModule didn't confirm to JAASRealm contract. This prevented any user from being assigned a role. http://svn.apache.org/viewvc?rev=684081&view=rev - +1: markt, fhanik + +1: markt, fhanik, rjung -1: + rjung: sudjucts -> subjects ;) * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45585 Tomcat failed to start if using $CATALINA_BASE but not JULI. Patch based on a suggestion by Ian Ward Comfort http://svn.apache.org/viewvc?rev=684001&view=rev - +1: markt, fhanik + +1: markt, fhanik, rjung -1: + rjung: Only needed if r651713 above gets applied. * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45576 Add support for DIGEST to the JAASRealm @@ -76,9 +78,9 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41407 Add support for CLIENT-CERT to the JASSRealm. Builds on DIGEST patch above. - https://issues.apache.org/bugzilla/show_bug.cgi?id=41407 +1: markt, fhanik -1: + rjung: Can you please add the original revision here? * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45528 Improved fix that hopefully addresses previous concerns @@ -90,6 +92,6 @@ * Additional fix for 44494, holding up 5.5.27 http://people.apache.org/~fhanik/patches/55-44494.patch Reproduce error, call getReader, but never use the converter. You'll get a NPE on InputBuffer.recycle() - +1: fhanik, jfclere + +1: fhanik, jfclere, rjung -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: 5.5.27
Filip Hanik - Dev Lists wrote: there is a required patch in STATUS.txt before I can actually move this, right now its failing TCK tests I added a third +1 and some other votes. Regards, Rainer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
enable https on tomcat 5.5
*hi I want to enable SSL on my tomcat 5.5, so I'follow this tutorial : http://tomcat.apache.org/tomcat-5.5-doc/ssl-howto.html but when I try to enter https://localhost:8443 it does not work ; I do not see the certificat in browsers ( IE + Mozilla ) help please ??? best regards *
DO NOT REPLY [Bug 45648] Function 'f:length' not found
https://issues.apache.org/bugzilla/show_bug.cgi?id=45648
--- Comment #5 from Konstantin Kolinko <[EMAIL PROTECTED]> 2008-08-22 05:18:11
PST ---
I am confirming that it is reproducible with the examples app bundled with
Tomcat, with the current top of tc6.0.x branch (2008-08-22, rev.688071).
The page that fails is /examples/jsp/jsp2/el/functions.jsp
>From the root application, click JSP Examples. That page is the 4th example
there ("Functions" in the JSP 2.0 Examples group).
The issue disappears if I rollback to rev.685696 of 2008-08-14.
The released version 6.0.18 is not affected. I tested the page there
and it works.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45652] XSS patch for EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=45652
Rafael Serrano <[EMAIL PROTECTED]> changed:
What|Removed |Added
Attachment #22456|0 |1
is obsolete||
--- Comment #3 from Rafael Serrano <[EMAIL PROTECTED]> 2008-08-22 05:50:40 PST
---
Created an attachment (id=22472)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22472)
Reworked patch
Hi Mark,
I think you are right about the way this should be configured, so here is the
new patch. The JspServlet parameter to en/disable XML escaping is named
escapeXml.
BTW, I have changed the current behavior, so ${foo} escapes XML by default.
Regards
Rafa
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
enable https on tomcat 5.5
*hi I want to enable SSL on my tomcat 5.5, so I'follow this tutorial : http://tomcat.apache.org/tomcat-5.5-doc/ssl-howto.html but when I try to enter https://localhost:8443 it does not work ; I do not see the certificat in browsers ( IE + Mozilla ) help please ??? best regards*
DO NOT REPLY [Bug 45652] XSS patch for EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=45652 --- Comment #4 from Mark Thomas <[EMAIL PROTECTED]> 2008-08-22 06:03:18 PST --- Thanks for this. There are some other EL issues I want to get fixed first and then I'll look at integrating this patch. I'll change the default though to the current, spec compliant, behaviour. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45652] XSS patch for EL
https://issues.apache.org/bugzilla/show_bug.cgi?id=45652 --- Comment #5 from Remy Maucherat <[EMAIL PROTECTED]> 2008-08-22 07:43:09 PST --- The default value should probably be (! strict_spec_complaince), and the name of the parameter should be fixed so that it refers to EL. escapeElOutput ? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: enable https on tomcat 5.5
OUJGHA Radouane schrieb: *hi I want to enable SSL on my tomcat 5.5, so I'follow this tutorial : http://tomcat.apache.org/tomcat-5.5-doc/ssl-howto.html but when I try to enter https://localhost:8443 it does not work ; I do not see the certificat in browsers ( IE + Mozilla ) help please ??? best regards* Hello Mr. Radouane, if you are reading German, you might find http://a-weinert.de/weinert/pub/tomcat-tips.pdf and / or http://a-weinert.de/weinert/pub/tomcat-win-ad.pdf helpful. I fear the masters of this Developers List might refer you (us) to the user's list as the right forum for your question. Best regards Albrecht Weinert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41746] Default web application can not be changed
https://issues.apache.org/bugzilla/show_bug.cgi?id=41746 Paul <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #6 from Paul <[EMAIL PROTECTED]> 2008-08-22 15:28:07 PST --- I can't see why this bug has been resolved as invalid. Can anyone explain? Mark? Tomcat 6.0.18 still appears to not set the default/root application as it is described in accompanying documentation: http://tomcat.apache.org/tomcat-6.0-doc/config/context.html#Common%20Attributes (see "path" attribute). Either this is a bug in the Tomcat codebase or accompanying documentation requires changing (I guess this would result in raising another bug report in order to change documentation?). I'm new to the Apache way of working, so apologies if I've overlooked some regular Apache procedure here. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45661] NioBlockingSelector uses all CPU after a socket connection is killed
https://issues.apache.org/bugzilla/show_bug.cgi?id=45661 --- Comment #2 from Alan Yu <[EMAIL PROTECTED]> 2008-08-22 21:01:11 PST --- I am using the latest JDK 1.6.0_07 already and the problem still exists. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
