Re: Shipping Tomcat Native from ASF site

2008-07-09 Thread Filip Hanik - Dev Lists

+1

Mladen Turk wrote:

Hi,

Since all crypto software issues has been resolved
with US government we can ship openssl native binaries
directly instead using Irelands official mirror site.

Now, this also presumes that installer can directly
contain those .dll's instead downloading them at install
time. It's probably feasible for post 6.0.17 version
since 6.0.17 is close to get released.

Any problem I play with that?

Regards



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Shipping Tomcat Native from ASF site

2008-07-09 Thread Henri Gomez
+1

It will be easier for users to grab them next to mod_jk and tomcat

2008/7/9 Filip Hanik - Dev Lists <[EMAIL PROTECTED]>:
> +1
>
> Mladen Turk wrote:
>>
>> Hi,
>>
>> Since all crypto software issues has been resolved
>> with US government we can ship openssl native binaries
>> directly instead using Irelands official mirror site.
>>
>> Now, this also presumes that installer can directly
>> contain those .dll's instead downloading them at install
>> time. It's probably feasible for post 6.0.17 version
>> since 6.0.17 is close to get released.
>>
>> Any problem I play with that?
>>
>> Regards
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r675147 - /tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris

2008-07-09 Thread jfclere
Author: jfclere
Date: Wed Jul  9 05:36:55 2008
New Revision: 675147

URL: http://svn.apache.org/viewvc?rev=675147&view=rev
Log:
The  $(shell \ls $(JK_DIR)/*.c) doesn't seem to work replace it with a list of 
files.

Modified:
tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris

Modified: tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris?rev=675147&r1=675146&r2=675147&view=diff
==
--- tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris (original)
+++ tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris Wed Jul  9 
05:36:55 2008
@@ -16,22 +16,23 @@
 # Defines for example NSAPI programs running under SOLARIS
 
 # Choose between the settings for gcc or Sun Studio compiler
+SUITSPOT_HOME=/opt/SUNWwbsvr/plugins
 
 # gcc
 # If you get relocation errors, try:
 #   1. compiling with Sun's cc
 #   2. statically linking with libgcc
 #   3. Adjusting LD_LIBRARY_PATH to grab libgcc_s
-CC=gcc
+#CC=gcc
 # For 64 Bit builds, add "-m64" to EXTRA_CFLAGS
-EXTRA_CFLAGS=-fPIC -pthread
-LDFLAGS=-shared
+#EXTRA_CFLAGS=-fPIC -pthread
+#LDFLAGS=-shared
 
 # Sun Studio cc compiler
-#CC=cc
+CC=cc
 # For 64 Bit builds, add "-xtarget=generic64" to EXTRA_CFLAGS
-#EXTRA_CFLAGS=-xcode=pic32 -mt
-#LDFLAGS=-G
+EXTRA_CFLAGS=-xcode=pic32 -mt
+LDFLAGS=-G
 
 CC_CMD=$(CC) $(CFLAGS) $(EXTRA_CFLAGS) \
-DNET_SSL -DSOLARIS -D_REENTRANT -DXP_UNIX -DMCC_HTTPD -DSPAPI20 
-DJK_NSAPI
@@ -48,8 +49,19 @@
 JK_DIR=../common
 VPATH=.:$(JK_DIR)
 
-JK_SRCS = $(shell \ls $(JK_DIR)/*.c)
-JK_OBJS = $(patsubst $(JK_DIR)/%.c,%.o,$(JK_SRCS))
+JK_OBJS = ap_snprintf.ojk_md5.o \
+jk_ajp12_worker.ojk_msg_buff.o \
+jk_ajp13.o   jk_nwmain.o \
+jk_ajp13_worker.ojk_pool.o \
+jk_ajp14.o   jk_shm.o \
+jk_ajp14_worker.ojk_sockbuf.o \
+jk_ajp_common.o  jk_status.o \
+jk_connect.o jk_uri_worker_map.o \
+jk_context.o jk_url.o \
+jk_jni_worker.o  jk_util.o \
+jk_lb_worker.o   jk_worker.o \
+jk_map.o
+
 
 PLUGIN_OBJ = jk_nsapi_plugin.o
 
@@ -64,6 +76,7 @@
 
 clean:
rm -f *.o nsapi_redirector.so $(JK_OBJS)
+   rm -f $(JK_DIR)/*.o
 
 %.o : %.c
$(CC_CMD) $(INCLUDE_FLAGS) -c $<



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r675147 - /tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris

2008-07-09 Thread Rainer Jung

Hi JFC,

[EMAIL PROTECTED] wrote:

Author: jfclere
Date: Wed Jul  9 05:36:55 2008
New Revision: 675147

URL: http://svn.apache.org/viewvc?rev=675147&view=rev
Log:
The  $(shell \ls $(JK_DIR)/*.c) doesn't seem to work replace it with a list of 
files.



 # Defines for example NSAPI programs running under SOLARIS
 
 # Choose between the settings for gcc or Sun Studio compiler

+SUITSPOT_HOME=/opt/SUNWwbsvr/plugins


We should move the SUITSPOT_HOME up before the comment on choosing 
values for gcc or cc.



 # gcc
 # If you get relocation errors, try:
 #   1. compiling with Sun's cc
 #   2. statically linking with libgcc
 #   3. Adjusting LD_LIBRARY_PATH to grab libgcc_s
-CC=gcc
+#CC=gcc
 # For 64 Bit builds, add "-m64" to EXTRA_CFLAGS
-EXTRA_CFLAGS=-fPIC -pthread
-LDFLAGS=-shared
+#EXTRA_CFLAGS=-fPIC -pthread
+#LDFLAGS=-shared
 
 # Sun Studio cc compiler

-#CC=cc
+CC=cc
 # For 64 Bit builds, add "-xtarget=generic64" to EXTRA_CFLAGS
-#EXTRA_CFLAGS=-xcode=pic32 -mt
-#LDFLAGS=-G
+EXTRA_CFLAGS=-xcode=pic32 -mt
+LDFLAGS=-G


I think we shouldn't switch the default between minor versions. So let's 
keep gcc active and cc commented. I gues this part was not really what 
you were after when committing.


Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r675193 - /tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris

2008-07-09 Thread jfclere
Author: jfclere
Date: Wed Jul  9 07:44:32 2008
New Revision: 675193

URL: http://svn.apache.org/viewvc?rev=675193&view=rev
Log:
Let gcc as default.
Add some comments with SUITSPOT_HOME=/opt/SUNWwbsvr/plugins

Modified:
tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris

Modified: tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris?rev=675193&r1=675192&r2=675193&view=diff
==
--- tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris (original)
+++ tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris Wed Jul  9 
07:44:32 2008
@@ -16,23 +16,27 @@
 # Defines for example NSAPI programs running under SOLARIS
 
 # Choose between the settings for gcc or Sun Studio compiler
-SUITSPOT_HOME=/opt/SUNWwbsvr/plugins
 
 # gcc
 # If you get relocation errors, try:
 #   1. compiling with Sun's cc
 #   2. statically linking with libgcc
 #   3. Adjusting LD_LIBRARY_PATH to grab libgcc_s
-#CC=gcc
+CC=gcc
 # For 64 Bit builds, add "-m64" to EXTRA_CFLAGS
-#EXTRA_CFLAGS=-fPIC -pthread
-#LDFLAGS=-shared
+EXTRA_CFLAGS=-fPIC -pthread
+LDFLAGS=-shared
 
 # Sun Studio cc compiler
-CC=cc
+#CC=cc
 # For 64 Bit builds, add "-xtarget=generic64" to EXTRA_CFLAGS
-EXTRA_CFLAGS=-xcode=pic32 -mt
-LDFLAGS=-G
+#EXTRA_CFLAGS=-xcode=pic32 -mt
+#LDFLAGS=-G
+
+# Change this according to location where on installed the server.
+# Don't forget to do the ./configure --enable-netscape=/opt/SUNWwbsvr/plugins
+# before doing gmake -f Makefile.solaris
+SUITSPOT_HOME=/opt/SUNWwbsvr/plugins
 
 CC_CMD=$(CC) $(CFLAGS) $(EXTRA_CFLAGS) \
-DNET_SSL -DSOLARIS -D_REENTRANT -DXP_UNIX -DMCC_HTTPD -DSPAPI20 
-DJK_NSAPI



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r675147 - /tomcat/connectors/trunk/jk/native/netscape/Makefile.solaris

2008-07-09 Thread jean-frederic clere

Rainer Jung wrote:

Hi JFC,

[EMAIL PROTECTED] wrote:

Author: jfclere
Date: Wed Jul  9 05:36:55 2008
New Revision: 675147

URL: http://svn.apache.org/viewvc?rev=675147&view=rev
Log:
The  $(shell \ls $(JK_DIR)/*.c) doesn't seem to work replace it with a 
list of files.



 # Defines for example NSAPI programs running under SOLARIS
 
 # Choose between the settings for gcc or Sun Studio compiler

+SUITSPOT_HOME=/opt/SUNWwbsvr/plugins


We should move the SUITSPOT_HOME up before the comment on choosing 
values for gcc or cc.


Ok.




 # gcc
 # If you get relocation errors, try:
 #   1. compiling with Sun's cc
 #   2. statically linking with libgcc
 #   3. Adjusting LD_LIBRARY_PATH to grab libgcc_s
-CC=gcc
+#CC=gcc
 # For 64 Bit builds, add "-m64" to EXTRA_CFLAGS
-EXTRA_CFLAGS=-fPIC -pthread
-LDFLAGS=-shared
+#EXTRA_CFLAGS=-fPIC -pthread
+#LDFLAGS=-shared
 
 # Sun Studio cc compiler

-#CC=cc
+CC=cc
 # For 64 Bit builds, add "-xtarget=generic64" to EXTRA_CFLAGS
-#EXTRA_CFLAGS=-xcode=pic32 -mt
-#LDFLAGS=-G
+EXTRA_CFLAGS=-xcode=pic32 -mt
+LDFLAGS=-G


I think we shouldn't switch the default between minor versions. So let's 
keep gcc active and cc commented. I gues this part was not really what 
you were after when committing.


Well I was think gcc brings problems but the tests are ok. So I have put 
back.


Cheers

Jean-Frederic



Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 41939] NPE in Logging due to classloading

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41939





--- Comment #23 from Dan Armbrust <[EMAIL PROTECTED]>  2008-07-09 13:40:47 PST 
---
Could someone with knowledge of this bug read through this comment on a bug in
Log4j?

https://issues.apache.org/bugzilla/show_bug.cgi?id=43867#c39

I believe that this is an example of tomcat breaking other code due to the way
that it clears references, when
org.apache.catalina.loader.WebappClassLoader.ENABLE_CLEAR_REFERENCES is left to
its default of "on".

In this case, log4j prevents a null pointer, and simply logs an error.  But
other code could very easily take a null pointer for the same reason.

It doesn't seem like the current implementation of clear references is safe to
use.

Comment #17 indicates that clearReferences is a workaround to a different bug,
and won't be removed.  Perhaps that should be re-evaluated.  

I now have to disable clearReferences on my tomcat installs on most of my
webapps which use log4j to prevent users from seeing a scary looking error
being logged by log4j.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r675340 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2008-07-09 Thread markt
Author: markt
Date: Wed Jul  9 13:50:18 2008
New Revision: 675340

URL: http://svn.apache.org/viewvc?rev=675340&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
Should look for annotations all the way up the class hierarchy

Modified:
tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java?rev=675340&r1=675339&r2=675340&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java Wed 
Jul  9 13:50:18 2008
@@ -245,62 +245,67 @@
 return;
 }
 
-// Initialize fields annotations
-Field[] fields = instance.getClass().getDeclaredFields();
-for (Field field : fields) {
-if (injections != null && injections.containsKey(field.getName())) 
{
-lookupFieldResource(context, instance, field, 
injections.get(field.getName()));
-} else if (field.isAnnotationPresent(Resource.class)) {
-Resource annotation = field.getAnnotation(Resource.class);
-lookupFieldResource(context, instance, field, 
annotation.name());
-} else if (field.isAnnotationPresent(EJB.class)) {
-EJB annotation = field.getAnnotation(EJB.class);
-lookupFieldResource(context, instance, field, 
annotation.name());
-} else if (field.isAnnotationPresent(WebServiceRef.class)) {
-WebServiceRef annotation =
-field.getAnnotation(WebServiceRef.class);
-lookupFieldResource(context, instance, field, 
annotation.name());
-} else if (field.isAnnotationPresent(PersistenceContext.class)) {
-PersistenceContext annotation =
-field.getAnnotation(PersistenceContext.class);
-lookupFieldResource(context, instance, field, 
annotation.name());
-} else if (field.isAnnotationPresent(PersistenceUnit.class)) {
-PersistenceUnit annotation =
-field.getAnnotation(PersistenceUnit.class);
-lookupFieldResource(context, instance, field, 
annotation.name());
-}
-}
-
-// Initialize methods annotations
-Method[] methods = instance.getClass().getDeclaredMethods();
-for (Method method : methods) {
-String methodName = method.getName();
-if (injections != null && methodName.startsWith("set") && 
methodName.length() > 3) {
-String fieldName = Character.toLowerCase(methodName.charAt(3)) 
+ methodName.substring(4);
-if (injections.containsKey(fieldName)) {
-lookupMethodResource(context, instance, method, 
injections.get(fieldName));
-break;
+Class clazz = instance.getClass();
+
+while (clazz != null) {
+// Initialize fields annotations
+Field[] fields = clazz.getDeclaredFields();
+for (Field field : fields) {
+if (injections != null && 
injections.containsKey(field.getName())) {
+lookupFieldResource(context, instance, field, 
injections.get(field.getName()));
+} else if (field.isAnnotationPresent(Resource.class)) {
+Resource annotation = field.getAnnotation(Resource.class);
+lookupFieldResource(context, instance, field, 
annotation.name());
+} else if (field.isAnnotationPresent(EJB.class)) {
+EJB annotation = field.getAnnotation(EJB.class);
+lookupFieldResource(context, instance, field, 
annotation.name());
+} else if (field.isAnnotationPresent(WebServiceRef.class)) {
+WebServiceRef annotation =
+field.getAnnotation(WebServiceRef.class);
+lookupFieldResource(context, instance, field, 
annotation.name());
+} else if 
(field.isAnnotationPresent(PersistenceContext.class)) {
+PersistenceContext annotation =
+field.getAnnotation(PersistenceContext.class);
+lookupFieldResource(context, instance, field, 
annotation.name());
+} else if (field.isAnnotationPresent(PersistenceUnit.class)) {
+PersistenceUnit annotation =
+field.getAnnotation(PersistenceUnit.class);
+lookupFieldResource(context, instance, field, 
annotation.name());
 }
 }
-if (method.isAnnotationPresent(Resource.class)) {
-Resource 

DO NOT REPLY [Bug 41939] NPE in Logging due to classloading

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41939





--- Comment #24 from Mark Thomas <[EMAIL PROTECTED]>  2008-07-09 14:01:42 PST 
---
Yes, if you and the libraries you use code their use of loggers correctly you
should be safe with setting ENABLE_CLEAR_REFERENCES to false.

I can't speak for the other developers but I am happy with the current default
for this being true on the basis it fixes more issues than it causes.

That said, I am more than happy to look into any test case (like bug 42172)
that could be a Tomcat memory leak.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r675342 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-07-09 Thread markt
Author: markt
Date: Wed Jul  9 14:06:59 2008
New Revision: 675342

URL: http://svn.apache.org/viewvc?rev=675342&view=rev
Log:
Propose fix for 45285

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=675342&r1=675341&r2=675342&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jul  9 14:06:59 2008
@@ -54,3 +54,9 @@
   http://svn.apache.org/viewvc?rev=674335&view=rev
   +1: markt, fhanik
   -1: 
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
+  Need to look for annotations in class hierarchy
+  http://people.apache.org/~markt/patches/2008-07-09-bug45285.patch
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45285] RESOURCES DECLARED IN PARENT CLASSES ARE NOT INJECTED

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45285





--- Comment #1 from Mark Thomas <[EMAIL PROTECTED]>  2008-07-09 14:07:06 PST ---
A fix has been committed to trunk and proposed for 6.0.x


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45350] ColdFusion MX7 Administration doesn't work

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45350


Mark Thomas <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Comment #1 from Mark Thomas <[EMAIL PROTECTED]>  2008-07-09 14:32:20 PST ---
This works for me with the latest source.

I haven't looked too deeply at this but given that the login process uses POST
and the versions you see issues with this looks very much like a duplicate of
bug 44494

*** This bug has been marked as a duplicate of bug 44494 ***


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494


Mark Thomas <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #55 from Mark Thomas <[EMAIL PROTECTED]>  2008-07-09 14:32:20 PST 
---
*** Bug 45350 has been marked as a duplicate of this bug. ***


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45349] ColdFusion MX7 Administration doesn't work

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45349


Mark Thomas <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Comment #1 from Mark Thomas <[EMAIL PROTECTED]>  2008-07-09 14:32:46 PST ---
All indications are that this is a dup of 44494

*** This bug has been marked as a duplicate of bug 44494 ***


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-07-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494





--- Comment #56 from Mark Thomas <[EMAIL PROTECTED]>  2008-07-09 14:32:46 PST 
---
*** Bug 45349 has been marked as a duplicate of this bug. ***


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]