DO NOT REPLY [Bug 45313] New: mod_jk 1.2.26 & apache 2.2. 9 static compiled on solaris not able to connect

2008-06-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45313

   Summary: mod_jk 1.2.26 & apache 2.2.9 static compiled on solaris
not able to connect
   Product: Tomcat 5
   Version: Unknown
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:AJP
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I tried a static compile of mod_jk 1.2.26 and apache 2.2.9 on solaris 8,9 and
10 (sparc) and solaris 10 (intel).

Compilation worked perfect, mod_jk worked in all cases when tomcat (or other
servlet container) was on the same host. It did not work, when tomcat was on an
other host on the same network on all sparc versions of solaris, but it worked
for the intel version.

Some investigation showed, that nb_connect() in jk_connect.c fails when
statically compiled into apache. Modular compilation works fine.

Compiler was gcc version 3.2.4, tried with sun "ld" and gnu "ld", no
difference.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Client certificate using tomcat native

2008-06-30 Thread jean-frederic clere

Brian Hawkins wrote:

I've finally been able to get the client certificate while using tomcat
native for my SSL connections.  This is using Tomcat 5.5.25.


Could you open a bugzilla on this one...

Cheers

Jean-Frederic



Here is what doesn't work:
Calling request.getAttribute("javax.servlet.request.X509Certificate") is
supposed to return the client certificate chain.  This attribute is
populated by a call, down in the depths of the native code, to
SSL_get_peer_cert_chain().  The openssl documentation for
SSL_get_peer_cert_chain (
http://www.openssl.org/docs/ssl/SSL_get_peer_cert_chain.html) says:

SSL_get_peer_cert_chain() returns a pointer to STACKOF(X509) certificates
forming the certificate chain of the peer. If called on the client side, the
stack also contains the peer's certificate; if called on the server side,
the peer's certificate must be obtained separately using
SSL_get_peer_certificate(3).
If the peer did not present a certificate, NULL is returned.

So according to that it only returns the CA chain and not the actual client
cert.  I'm not sure what the client chain is worth without the client cert.

The fix to this problem can be made in Http11AprProcessor in the action()
method under the ACTION_REQ_SSL_ATTRIBUTE if block by adding the following
code:

// Client certificate
byte[] certdata = SSLSocket.getInfoB(socket, SSL.SSL_INFO_CLIENT_CERT);
if (certdata != null)
{
CertificateFactory cf = CertificateFactory.getInstance("X.509");
ByteArrayInputStream stream = new ByteArrayInputStream(certdata);
request.setAttribute("ClientCert", cf.generateCertificate(stream));
}

Personally I think the attribute name should be
"javax.servlet.request.X509Certificate" but I'll let the list decide that
one.

Brian




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r672871 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-06-30 Thread remm
Author: remm
Date: Mon Jun 30 12:18:59 2008
New Revision: 672871

URL: http://svn.apache.org/viewvc?rev=672871&view=rev
Log:
- Votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=672871&r1=672870&r2=672871&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 30 12:18:59 2008
@@ -41,12 +41,12 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45279
   Properly close multicast socket
   http://svn.apache.org/viewvc?rev=671650&view=rev
-  +1: fhanik, markt
+  +1: fhanik, markt, remm
   -1: 
 
 * Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45272
   Patch attached in bugzilla issue
-  +1: fhanik, markt
+  +1: fhanik, markt, remm (pfff, use ff)
   -1: 
 
 * Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
@@ -56,6 +56,8 @@
   http://svn.apache.org/viewvc?rev=672397&view=rev
   +1: markt
   -1: 
+  -0: remm: This cannot be fixed from what you are saying, so this stream of 
fixes
+  seems pointless to me right now
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45277
   Correct typo
@@ -67,4 +69,8 @@
Port the fix from the JK Connector to the AJP and APR Connectors
http://svn.apache.org/viewvc?rev=672454&view=rev
+1: billbarker
-   -1:
+   -1: remm: No, this gets called all the time, and we're trying to fix a 
small issue. The real
+ solution would be to recycle the fields (when exiting the process 
method of the processors)
+ since as mentioned here it is the cause of the problem (the 
"local" fields will often never
+ change, but there's no real guarantee overall):
+ https://issues.apache.org/bugzilla/show_bug.cgi?id=36155#c17



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45315] New: Wine support for building

2008-06-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45315

   Summary: Wine support for building
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:Packaging
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Created an attachment (id=22199)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22199)
Patch

NSIS is fully usable through Wine. The attached patch should add support for
building the Windows installer on Unix.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45279] McastServiceImpl leaks sockets.

2008-06-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45279


Filip Hanik <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #3 from Filip Hanik <[EMAIL PROTECTED]>  2008-06-30 13:03:21 PST ---
Fixed in 6.0.x branch, will be included in 6.0.17 and forward


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r672888 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/tribes/membership/McastServiceImpl.java webapps/docs/changelog.xml

2008-06-30 Thread fhanik
Author: fhanik
Date: Mon Jun 30 13:04:27 2008
New Revision: 672888

URL: http://svn.apache.org/viewvc?rev=672888&view=rev
Log:
commit fix for 45279

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=672888&r1=672887&r2=672888&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 30 13:04:27 2008
@@ -38,12 +38,6 @@
   +1: markt, fhanik
   -1: 
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45279
-  Properly close multicast socket
-  http://svn.apache.org/viewvc?rev=671650&view=rev
-  +1: fhanik, markt, remm
-  -1: 
-
 * Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45272
   Patch attached in bugzilla issue
   +1: fhanik, markt, remm (pfff, use ff)

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java?rev=672888&r1=672887&r2=672888&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
 (original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
 Mon Jun 30 13:04:27 2008
@@ -299,6 +299,7 @@
 send(false);
 //leave mcast group
 try {socket.leaveGroup(address);}catch ( Exception ignore){}
+try {socket.close();}catch ( Exception ignore){}
 serviceStartTime = Long.MAX_VALUE;
 }
 return (startLevel == 0);

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=672888&r1=672887&r2=672888&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Jun 30 13:04:27 2008
@@ -378,6 +378,7 @@
   
   
 
+  45279Properly close multicast socket.
   
 Fix session replication dead lock during non sticky load balancing.
 (fhanik)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45272] Version 1 cookie not persisted in IE

2008-06-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45272


Filip Hanik <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Comment #8 from Filip Hanik <[EMAIL PROTECTED]>  2008-06-30 13:05:04 PST ---
Fixed in 6.0.x
will be available in 6.0.17 onward


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r672889 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/http/ServerCookie.java webapps/docs/changelog.xml

2008-06-30 Thread fhanik
Author: fhanik
Date: Mon Jun 30 13:07:49 2008
New Revision: 672889

URL: http://svn.apache.org/viewvc?rev=672889&view=rev
Log:
commit fix for 45272

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=672889&r1=672888&r2=672889&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 30 13:07:49 2008
@@ -38,11 +38,6 @@
   +1: markt, fhanik
   -1: 
 
-* Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45272
-  Patch attached in bugzilla issue
-  +1: fhanik, markt, remm (pfff, use ff)
-  -1: 
-
 * Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
   This isn't perfect but it narrows the window for the race condition
   significantly. A perfect fix would require syncing most (all?) of allocate()

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie.java?rev=672889&r1=672888&r2=672889&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie.java Mon 
Jun 30 13:07:49 2008
@@ -135,6 +135,7 @@
 
 private static final String tspecials = ",; ";
 private static final String tspecials2 = "()<>@,;:\\\"/[]?={} \t";
+private static final String tspecials2NoSlash = "()<>@,;:\\\"[]?={} \t";
 
 /*
  * Tests a string and returns true if the string counts as a
@@ -146,6 +147,11 @@
  *  token; false if it is not
  */
 public static boolean isToken(String value) {
+return isToken(value,null);
+}
+
+public static boolean isToken(String value, String literals) {
+String tspecials = (literals==null?ServerCookie.tspecials:literals);
 if( value==null) return true;
 int len = value.length();
 
@@ -172,8 +178,12 @@
 return false;
 }
 
-
 public static boolean isToken2(String value) {
+return isToken2(value,null);
+}
+
+public static boolean isToken2(String value, String literals) {
+String tspecials2 = (literals==null?ServerCookie.tspecials2:literals);
 if( value==null) return true;
 int len = value.length();
 
@@ -299,7 +309,11 @@
 // Path=path
 if (path!=null) {
 buf.append ("; Path=");
-maybeQuote2(version, buf, path);
+if (version==0) {
+maybeQuote2(version, buf, path);
+} else {
+maybeQuote2(version, buf, path, 
ServerCookie.tspecials2NoSlash, false);
+}
 }
 
 // Secure
@@ -341,6 +355,10 @@
 }
 
 public static int maybeQuote2 (int version, StringBuffer buf, String 
value, boolean allowVersionSwitch) {
+return maybeQuote2(version,buf,value,null,allowVersionSwitch);
+}
+
+public static int maybeQuote2 (int version, StringBuffer buf, String 
value, String literals, boolean allowVersionSwitch) {
 if (value==null || value.length()==0) {
 buf.append("\"\"");
 }else if (containsCTL(value,version)) 
@@ -349,16 +367,16 @@
 buf.append('"');
 buf.append(escapeDoubleQuotes(value,1,value.length()-1));
 buf.append('"');
-} else if (allowVersionSwitch && (!STRICT_SERVLET_COMPLIANCE) && 
version==0 && !isToken2(value)) {
+} else if (allowVersionSwitch && (!STRICT_SERVLET_COMPLIANCE) && 
version==0 && !isToken2(value, literals)) {
 buf.append('"');
 buf.append(escapeDoubleQuotes(value,0,value.length()));
 buf.append('"');
 version = 1;
-} else if (version==0 && !isToken(value)) {
+} else if (version==0 && !isToken(value,literals)) {
 buf.append('"');
 buf.append(escapeDoubleQuotes(value,0,value.length()));
 buf.append('"');
-} else if (version==1 && !isToken2(value)) {
+} else if (version==1 && !isToken2(value,literals)) {
 buf.append('"');
 buf.append(escapeDoubleQuotes(value,0,value.length()));
 buf.append('"');

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=672889&r1=672888&r2=672889&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Jun 30 13:07:49 2008
@@ -35,6 +35,7 @@

svn commit: r672942 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-06-30 Thread fhanik
Author: fhanik
Date: Mon Jun 30 14:53:56 2008
New Revision: 672942

URL: http://svn.apache.org/viewvc?rev=672942&view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=672942&r1=672941&r2=672942&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun 30 14:53:56 2008
@@ -43,7 +43,7 @@
   significantly. A perfect fix would require syncing most (all?) of allocate()
   which is on the critical path.
   http://svn.apache.org/viewvc?rev=672397&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
   -0: remm: This cannot be fixed from what you are saying, so this stream of 
fixes
   seems pointless to me right now
@@ -51,7 +51,7 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45277
   Correct typo
   http://svn.apache.org/viewvc?rev=672399&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 *  Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36155



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]