svn commit: r667429 - in /tomcat/connectors/trunk/jk/xdocs: miscellaneous/changelog.xml reference/status.xml
Author: rjung Date: Fri Jun 13 01:58:37 2008 New Revision: 667429 URL: http://svn.apache.org/viewvc?rev=667429&view=rev Log: "val" attribute numbering in status worker documentation needs to start with 0 instead of 1. Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml tomcat/connectors/trunk/jk/xdocs/reference/status.xml Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?rev=667429&r1=667428&r2=667429&view=diff == --- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Fri Jun 13 01:58:37 2008 @@ -43,6 +43,10 @@ + +Documentation: "val" attribute numbering in status worker +needs to start with 0 instead of 1. (rjung) + Documentation: Remove JNI parameters from sample configuration in the workers generic howto. (rjung) Modified: tomcat/connectors/trunk/jk/xdocs/reference/status.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/reference/status.xml?rev=667429&r1=667428&r2=667429&view=diff == --- tomcat/connectors/trunk/jk/xdocs/reference/status.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/reference/status.xml Fri Jun 13 01:58:37 2008 @@ -557,7 +557,7 @@ The values of the common aspect for all the load balancer members will be given -in parameters named "val1", "val2", +in parameters named "val0", "val1", - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45191] Cookie.getValue() returns wrong value
https://issues.apache.org/bugzilla/show_bug.cgi?id=45191 Filip Hanik <[EMAIL PROTECTED]> changed: What|Removed |Added Resolution|DUPLICATE |INVALID --- Comment #3 from Filip Hanik <[EMAIL PROTECTED]> 2008-06-13 08:15:25 PST --- = is not a valid character in v0 cookies, both the HTTP and the servlet spec say so. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Author: markt Date: Fri Jun 13 10:43:51 2008 New Revision: 667604 URL: http://svn.apache.org/viewvc?rev=667604&view=rev Log: Fix bug 45195. NPE when calling getAttribute(null). The spec is unclear but this is a regression from 5.0.x Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/StandardSession.java?rev=667604&r1=667603&r2=667604&view=diff == --- tomcat/trunk/java/org/apache/catalina/session/StandardSession.java (original) +++ tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Fri Jun 13 10:43:51 2008 @@ -1032,6 +1032,8 @@ throw new IllegalStateException (sm.getString("standardSession.getAttribute.ise")); +if (name == null) return null; + return (attributes.get(name)); } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
hi Mark, can you please update the changelog thanks Filip [EMAIL PROTECTED] wrote: Author: markt Date: Fri Jun 13 10:43:51 2008 New Revision: 667604 URL: http://svn.apache.org/viewvc?rev=667604&view=rev Log: Fix bug 45195. NPE when calling getAttribute(null). The spec is unclear but this is a regression from 5.0.x Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/StandardSession.java?rev=667604&r1=667603&r2=667604&view=diff == --- tomcat/trunk/java/org/apache/catalina/session/StandardSession.java (original) +++ tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Fri Jun 13 10:43:51 2008 @@ -1032,6 +1032,8 @@ throw new IllegalStateException (sm.getString("standardSession.getAttribute.ise")); +if (name == null) return null; + return (attributes.get(name)); } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45202] New: context.xml used from conf/ Catalina and not from deployed web-app
https://issues.apache.org/bugzilla/show_bug.cgi?id=45202 Summary: context.xml used from conf/Catalina and not from deployed web-app Product: Tomcat 6 Version: 6.0.16 Platform: PC OS/Version: Windows XP Status: NEW Severity: major Priority: P2 Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I am using context.xml as my form based autentication source. The file lives in mywar.war/META-INF/context.xml. When I put the war in the webapps directory it is exploded and the context.xml is also copied into tc_home/conf/Catalina/localhost/ and renamed to mywar.xml. There are several issues with this. When developing an application I expect that the exploded files are the ones being used so in this case modifications to mywar/META-INF fail to have any effect. The second issue with this for me is that I have two wars. The first is the authentication source that context.xml tells the second to connect to. When the context.xml file exists in conf/Catalina it is loaded before the web app that is the authentication source has been started and the authentication server connection is therefor not established. My workaround it to always delete the conf/Catalina directory before starting the server. Kind of a pain but seems to work. Why is the file moved to the conf directory and then access from there as opposed to the deployed webapp? Thank You -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Filip Hanik - Dev Lists wrote: hi Mark, can you please update the changelog For trunk? The changelog for trunk hasn't been been kept up to date since it was created. I don't see the point of keeping the trunk changelog updated for changes that will be in 6.0.x. There is some merit if the change is intended for the next release branch. That said, I would still want to do a diff between 6.0.x and the new release branch to get the complete picture. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45202] context.xml used from conf/ Catalina and not from deployed web-app
https://issues.apache.org/bugzilla/show_bug.cgi?id=45202 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-06-13 11:59:06 PST --- Copying to conf is an intentional design decision. There are a few things that need cleaning up in this area (see bug 42747) but I don't think changes for that bug are going to help you. If you want to discuss the reasons behind the design decision, please use the dev list. I'm not clear how you are using context.xml for authentication but it looks like you are using context.xml for a purpose other than that for which it was intended. There is probably a better solution to the problem you are trying to solve. The users list is the place to get help with that. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r667622 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Jun 13 12:06:13 2008 New Revision: 667622 URL: http://svn.apache.org/viewvc?rev=667622&view=rev Log: Propose fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45195 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=667622&r1=667621&r2=667622&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Fri Jun 13 12:06:13 2008 @@ -223,3 +223,10 @@ http://svn.apache.org/viewvc?rev=657954&view=rev +1: markt, fhanik -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45195 + NPE when calling getAttribute(null). The spec is unclear but this + is a regression from 5.0.x + http://svn.apache.org/viewvc?rev=667604&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=667622&r1=667621&r2=667622&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jun 13 12:06:13 2008 @@ -62,3 +62,10 @@ +1: markt +1: fhanik - candidate for STRICT_SERVLET_COMPLIANCE? -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45195 + NPE when calling getAttribute(null). The spec is unclear but this + is a regression from 5.0.x + http://svn.apache.org/viewvc?rev=667604&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r667623 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Jun 13 12:07:56 2008 New Revision: 667623 URL: http://svn.apache.org/viewvc?rev=667623&view=rev Log: Comment Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=667623&r1=667622&r2=667623&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jun 13 12:07:56 2008 @@ -61,6 +61,9 @@ http://svn.apache.org/viewvc?rev=665756&view=rev +1: markt +1: fhanik - candidate for STRICT_SERVLET_COMPLIANCE? + markt - Probably not. STRICT_SERVLET_COMPLIANCE is a shortcut to set all + options that are non-compliant by default. This one is already + compliant by defult -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45195 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: hi Mark, can you please update the changelog For trunk? The changelog for trunk hasn't been been kept up to date since it was created. then we should bring it up to date, and keep it up to date. trunk is no different in terms of changelog, or at least it shouldn't be. can't expect trunk to be the CTR for 6.0 forever Filip I don't see the point of keeping the trunk changelog updated for changes that will be in 6.0.x. There is some merit if the change is intended for the next release branch. That said, I would still want to do a diff between 6.0.x and the new release branch to get the complete picture. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45195] Possible regression issue with HttpSession. getAtttribute()
https://issues.apache.org/bugzilla/show_bug.cgi?id=45195 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-06-13 12:26:48 PST --- This has been fixed in trunk and proposed for 6.0.x and 5.5.x Thanks for the report. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
context.xml, hotdeploy
Hi Mark, Yeah I don't think the cleanup for 42747 will help with this issue. The other thing that I forgot to mention is that the behavior is inconsistent between exploded deployment and war deployment. In war deployment the file will be copied to the conf/Catalina location. In exploded deployment the file will remain where it is and be used from where it is. In war deployment I still find it useful to hotdeploy files to the exploded directory and with the current implementation, hotdeploying the context.xml file will not work in war deployment mode. It will work in exploded deployment mode, if I manually have the war exploded instead of allowing tc to explode it for me. Would you not consider the inconsistent behavior to be a bug? Thanks for the response, Fu-Tung In terms of my usage of context.xml I am not doing anything special in fact pretty much to the letter of the example in the sun docs for form based authentication. The only thing that is different is that my authentication source happens to be war based and running in the tc web container. There isn't anything strictly wrong with that. There are other approaches I could use, a different authentication source, have the authentication source run in a separately launched and configured tc container, etc. In any case this is tangential to the bug report. https://issues.apache.org/bugzilla/show_bug.cgi?id=45202 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-06-13 11:59:06 PST --- Copying to conf is an intentional design decision. There are a few things that need cleaning up in this area (see bug 42747) but I don't think changes for that bug are going to help you. If you want to discuss the reasons behind the design decision, please use the dev list. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r667644 - /tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java
Author: markt Date: Fri Jun 13 13:40:27 2008 New Revision: 667644 URL: http://svn.apache.org/viewvc?rev=667644&view=rev Log: Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683 There was a short period where the context didn't appear in the mapper that resulted in some more 404s. Modified: tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java Modified: tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java?rev=667644&r1=667643&r2=667644&view=diff == --- tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/MapperListener.java Fri Jun 13 13:40:27 2008 @@ -26,11 +26,14 @@ import javax.management.ObjectInstance; import javax.management.ObjectName; +import org.apache.catalina.core.StandardContext; import org.apache.juli.logging.Log; import org.apache.juli.logging.LogFactory; +import org.apache.tomcat.util.buf.MessageBytes; import org.apache.tomcat.util.http.mapper.Mapper; +import org.apache.tomcat.util.http.mapper.MappingData; import org.apache.tomcat.util.modeler.Registry; import org.apache.tomcat.util.res.StringManager; @@ -430,6 +433,19 @@ if (contextName.equals("/")) { contextName = ""; } + +// Don't un-map a context that is paused +MessageBytes hostMB = MessageBytes.newInstance(); +hostMB.setString(hostName); +MessageBytes contextMB = MessageBytes.newInstance(); +contextMB.setString(contextName); +MappingData mappingData = new MappingData(); +mapper.map(hostMB, contextMB, mappingData); +if (mappingData.context instanceof StandardContext && +((StandardContext)mappingData.context).getPaused()) { +return; +} + if(log.isDebugEnabled()) log.debug(sm.getString ("mapperListener.unregisterContext", contextName)); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: context.xml, hotdeploy
Fu-Tung Cheng wrote: Would you not consider the inconsistent behavior to be a bug? I do. The clean-up as part of 42747 should take care of that. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r667645 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Jun 13 13:43:26 2008 New Revision: 667645 URL: http://svn.apache.org/viewvc?rev=667645&view=rev Log: Propose another patch for 43683. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=667645&r1=667644&r2=667645&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jun 13 13:43:26 2008 @@ -72,3 +72,10 @@ http://svn.apache.org/viewvc?rev=667604&view=rev +1: markt -1: + +* Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683 + JMX re-registration was causing the context to briefly disappear from the + mapper during reload causing 404s + http://svn.apache.org/viewvc?rev=667644&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43683] Accessing Servlet while Reloading context gives 404 error
https://issues.apache.org/bugzilla/show_bug.cgi?id=43683 --- Comment #14 from Mark Thomas <[EMAIL PROTECTED]> 2008-06-13 13:44:28 PST --- I have committed another patch to trunk and proposed it for 6.0.x that fixes another source of 404s on reload. The patch is: http://svn.apache.org/viewvc?rev=667644&view=rev With this patch I can't get any 404s with test case 2. On to test case 3... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43683] Accessing Servlet while Reloading context gives 404 error
https://issues.apache.org/bugzilla/show_bug.cgi?id=43683 --- Comment #15 from Mark Thomas <[EMAIL PROTECTED]> 2008-06-13 14:03:11 PST --- I can't reproduce the problem you had with case 3. Have you set the unloadDelay on the context? I have set mine to 2 (20 seconds) for this bug to make sure that the servlet is given a chance to destroy() cleanly. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Tomcat Wiki] Update of "PoweredBy" by JohnDale
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by JohnDale: http://wiki.apache.org/tomcat/PoweredBy The comment on the change is: Added RedEndo BMX site to the listing, which uses Tomcat 5.0.28 -- http://www.quickcreative.net/images/topBanner/topBanner_r1_c1.gif [http://quickcreative.net QuickCreative.net] - Advertising Agency offering online ordering of business cards, brochures, logos, postcards and other printed materials. + = RedEndo BMX = + [http://www.redendo.com RedEndo BMX] - Online Opt-in advertising BMX Journal + = ResCarta Foundation = http://www.rescarta.org/rcweblogo.jpg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Tomcat Wiki] Update of "PoweredBy" by JohnDale
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by JohnDale: http://wiki.apache.org/tomcat/PoweredBy The comment on the change is: Uses tomcat 5.0.28 -- = RedEndo BMX = [http://www.redendo.com RedEndo BMX] - Online Opt-in advertising BMX Journal + = FarmDirectory.org = + [http://www.farmdirectory.org FarmDirectory.org] - Connects producers of agricultural goods with consumers. + = ResCarta Foundation = http://www.rescarta.org/rcweblogo.jpg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Tomcat Wiki] Update of "PoweredBy" by JohnDale
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by JohnDale: http://wiki.apache.org/tomcat/PoweredBy -- http://www.etools.ch/images/logo.gif [http://www.etools.ch/ eTools.ch] is a fast and transparent metasearch engine that simultaneously queries major search engines. + = FarmDirectory.org = + [http://www.farmdirectory.org FarmDirectory.org] - Connects producers of agricultural goods with consumers. + = Farmer Guy Hams and Gammons = http://www.farmerguy.co.uk/images/logo.jpg [http://www.farmerguy.co.uk Farmer Guy Hams and Gammons] - is a small web site offering home made hams and gammons for the christmas season, we only have a small jsp order form on tomcat but it works really well. Many thanks to the Tomcat team. @@ -370, +373 @@ = RedEndo BMX = [http://www.redendo.com RedEndo BMX] - Online Opt-in advertising BMX Journal - = FarmDirectory.org = - [http://www.farmdirectory.org FarmDirectory.org] - Connects producers of agricultural goods with consumers. - = ResCarta Foundation = - http://www.rescarta.org/rcweblogo.jpg [http://www.rescarta.org The ResCarta Foundation] - Community Standards through Collaborative Efforts. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Since there was never a release from trunk - there really isn't a change log. When trunk is released as a new branch it should have a RELEASE-NOTES which highlight why its a different branch but maintaining change log for an unreleased version doesn't make much sense to me. -Tim Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: hi Mark, can you please update the changelog For trunk? The changelog for trunk hasn't been been kept up to date since it was created. then we should bring it up to date, and keep it up to date. trunk is no different in terms of changelog, or at least it shouldn't be. can't expect trunk to be the CTR for 6.0 forever - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Tim Funk wrote: Since there was never a release from trunk - there really isn't a change log. When trunk is released as a new branch it should have a RELEASE-NOTES which highlight why its a different branch but maintaining change log for an unreleased version doesn't make much sense to me. Hmmm - perhaps the simple fact that it's a code base is enough to warrant a change log against the last released flavor? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]