svn commit: r664641 - in /tomcat/connectors/trunk/jk/xdocs: generic_howto/workers.xml miscellaneous/changelog.xml

2008-06-09 Thread rjung
Author: rjung
Date: Mon Jun  9 00:10:36 2008
New Revision: 664641

URL: http://svn.apache.org/viewvc?rev=664641&view=rev
Log:
Remove JNI parameters from sample configuration
in the workers generic howto.

Modified:
tomcat/connectors/trunk/jk/xdocs/generic_howto/workers.xml
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/connectors/trunk/jk/xdocs/generic_howto/workers.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/generic_howto/workers.xml?rev=664641&r1=664640&r2=664641&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/generic_howto/workers.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/generic_howto/workers.xml Mon Jun  9 
00:10:36 2008
@@ -168,7 +168,7 @@
 
 
 
-lbfactorproperty is used when working with a load balancer worker, this 
is the load-balancing factor for the worker.
+lbfactor property is used when working with a load balancer worker, 
this is the load-balancing factor for the worker.
 We'll see more on this in the lb 
worker section.
 
 
@@ -418,21 +418,13 @@
 An ajp13 worker that used the host localhost and the port 8008
 
 
-A jni worker
-
-
-A lb worker that load balance the ajp12 and ajp13 workers
+An lb worker that load balance the ajp12 and ajp13 workers
 
 
 
 
-  # Define some properties
-  workers.apache_log=/var/log/httpd/
-  workers.tomcat_home=/var/tomcat3
-  workers.java_home=/opt/IBMJava2-131/
-  ps=/
-  # Define 4 workers, 3 real workers using ajp12, ajp13, jni, the last one 
being a loadbalancing worker 
-  worker.list=worker1, worker2, worker3, worker4
+  # Define 3 workers, 2 real workers using ajp12, ajp13, the last one being a 
loadbalancing worker 
+  worker.list=worker1, worker2, worker3
   # Set properties for worker1 (ajp12)
   worker.worker1.type=ajp12
   worker.worker1.host=locahost
@@ -446,23 +438,8 @@
   worker.worker2.connection_pool_timeout=600
   worker.worker2.socket_keepalive=1
   worker.worker2.socket_timeout=60
-  # Set properties for worker3 (jni)
-  worker.worker3.type=jni
-  # Set worker3 bridge type, here Tomcat 3.3
-  worker.worker3.bridge=tomcat33
-  # Set worker3 classpath
-  worker.worker3.class_path=$(workers.tomcat_home)$(ps)classes
-  worker.worker3.class_path=$(workers.tomcat_home)$(ps)lib$(ps)tomcat.jar
-  # Set worker3 tomcat command line
-  worker.worker3.cmd_line=-home
-  worker.worker3.cmd_line=$(workers.tomcat_home)
-  # Set worker3 Tomcat/JVM settings
-  
worker.worker3.jvm_lib=$(workers.java_home)$(ps)jre$(ps)bin$(ps)classic$(ps)libjvm.so
-  worker.worker3.stdout=$(workers.apache_log)$(ps)inprocess.stdout
-  worker.worker3.stderr=$(workers.apache_log)$(ps)inprocess.stderr
-  worker.worker3.sysprops=tomcat.home=$(workers.tomcat_home)
-  # Set properties for worker4 (lb) which use worker1 and worker2
-  worker.worker4.balance_workers=worker1,worker2
+  # Set properties for worker3 (lb) which use worker1 and worker2
+  worker.worker3.balance_workers=worker1,worker2
 
 
 

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?rev=664641&r1=664640&r2=664641&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Mon Jun  9 
00:10:36 2008
@@ -43,6 +43,10 @@
   
   
 
+  
+Documentation: Remove JNI parameters from sample configuration
+in the workers generic howto. (rjung)
+  
   
 45026: For Apache httpd 2.x add "Unknown Reason"
 as the reason phrase, if we get an empty one from the backend.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Edward J. Yoon
Hi community,

I got "An unexpected error has been detected by HotSpot Virtual
Machine" when i reduce the number of Tomcat server 3 to 1.

#
# An unexpected error has been detected by HotSpot Virtual Machine:
#
#  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
#
# Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
# Problematic frame:
# C  [libc.so.6+0x68de6]  strcpy+0x26
#
# An error report file with more information is saved as hs_err_pid10535.log
#
# If you would like to submit a bug report, please visit:
#   http://java.sun.com/webapps/bugreport/crash.jsp
#

Have Anyone experience this?

-- 
Best regards,
Edward J. Yoon,
http://blog.udanax.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Quintin Beukes
Ouch. Rub it, will let the pain go away quicker.

It's copying a too large byte string into a too small buffer.
> # C  [libc.so.6+0x68de6]  strcpy+0x26

This is definitely a JVM bug. Are you running a beta JVM ->
1.5.0_06-b05? I might be mistaken, but I've never noticed the b at the
b05 at the end of any of them. Try upgrading it and confirm that it's
still there.

Q

On Mon, Jun 9, 2008 at 9:25 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
> Hi community,
>
> I got "An unexpected error has been detected by HotSpot Virtual
> Machine" when i reduce the number of Tomcat server 3 to 1.
>
> #
> # An unexpected error has been detected by HotSpot Virtual Machine:
> #
> #  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
> #
> # Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
> # Problematic frame:
> # C  [libc.so.6+0x68de6]  strcpy+0x26
> #
> # An error report file with more information is saved as hs_err_pid10535.log
> #
> # If you would like to submit a bug report, please visit:
> #   http://java.sun.com/webapps/bugreport/crash.jsp
> #
>
> Have Anyone experience this?
>
> --
> Best regards,
> Edward J. Yoon,
> http://blog.udanax.org
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-- 
Quintin Beukes

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Edward J. Yoon
Thank you very much for your nice advice.
Then, Is there no related with the reduction of tomcat number?

Thanks,
Edward.

On Mon, Jun 9, 2008 at 4:31 PM, Quintin Beukes <[EMAIL PROTECTED]> wrote:
> Ouch. Rub it, will let the pain go away quicker.
>
> It's copying a too large byte string into a too small buffer.
>> # C  [libc.so.6+0x68de6]  strcpy+0x26
>
> This is definitely a JVM bug. Are you running a beta JVM ->
> 1.5.0_06-b05? I might be mistaken, but I've never noticed the b at the
> b05 at the end of any of them. Try upgrading it and confirm that it's
> still there.
>
> Q
>
> On Mon, Jun 9, 2008 at 9:25 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
>> Hi community,
>>
>> I got "An unexpected error has been detected by HotSpot Virtual
>> Machine" when i reduce the number of Tomcat server 3 to 1.
>>
>> #
>> # An unexpected error has been detected by HotSpot Virtual Machine:
>> #
>> #  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
>> #
>> # Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
>> # Problematic frame:
>> # C  [libc.so.6+0x68de6]  strcpy+0x26
>> #
>> # An error report file with more information is saved as hs_err_pid10535.log
>> #
>> # If you would like to submit a bug report, please visit:
>> #   http://java.sun.com/webapps/bugreport/crash.jsp
>> #
>>
>> Have Anyone experience this?
>>
>> --
>> Best regards,
>> Edward J. Yoon,
>> http://blog.udanax.org
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>
>
> --
> Quintin Beukes
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-- 
Best regards,
Edward J. Yoon,
http://blog.udanax.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Edward J. Yoon
> Are you running a beta JVM -> 1.5.0_06-b05?

Oh, Java version is a 1.4.2.

Thanks, Edward

On Mon, Jun 9, 2008 at 4:43 PM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
> Thank you very much for your nice advice.
> Then, Is there no related with the reduction of tomcat number?
>
> Thanks,
> Edward.
>
> On Mon, Jun 9, 2008 at 4:31 PM, Quintin Beukes <[EMAIL PROTECTED]> wrote:
>> Ouch. Rub it, will let the pain go away quicker.
>>
>> It's copying a too large byte string into a too small buffer.
>>> # C  [libc.so.6+0x68de6]  strcpy+0x26
>>
>> This is definitely a JVM bug. Are you running a beta JVM ->
>> 1.5.0_06-b05? I might be mistaken, but I've never noticed the b at the
>> b05 at the end of any of them. Try upgrading it and confirm that it's
>> still there.
>>
>> Q
>>
>> On Mon, Jun 9, 2008 at 9:25 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
>>> Hi community,
>>>
>>> I got "An unexpected error has been detected by HotSpot Virtual
>>> Machine" when i reduce the number of Tomcat server 3 to 1.
>>>
>>> #
>>> # An unexpected error has been detected by HotSpot Virtual Machine:
>>> #
>>> #  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
>>> #
>>> # Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
>>> # Problematic frame:
>>> # C  [libc.so.6+0x68de6]  strcpy+0x26
>>> #
>>> # An error report file with more information is saved as hs_err_pid10535.log
>>> #
>>> # If you would like to submit a bug report, please visit:
>>> #   http://java.sun.com/webapps/bugreport/crash.jsp
>>> #
>>>
>>> Have Anyone experience this?
>>>
>>> --
>>> Best regards,
>>> Edward J. Yoon,
>>> http://blog.udanax.org
>>>
>>> -
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>>
>>
>> --
>> Quintin Beukes
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>
>
> --
> Best regards,
> Edward J. Yoon,
> http://blog.udanax.org
>



-- 
Best regards,
Edward J. Yoon,
http://blog.udanax.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Edward J. Yoon
Ooops, sorry for my mistakes.
I use the jdk1.5.0_06, And it seems really JVM bug. :)

Thanks.

On Mon, Jun 9, 2008 at 4:48 PM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
>> Are you running a beta JVM -> 1.5.0_06-b05?
>
> Oh, Java version is a 1.4.2.
>
> Thanks, Edward
>
> On Mon, Jun 9, 2008 at 4:43 PM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
>> Thank you very much for your nice advice.
>> Then, Is there no related with the reduction of tomcat number?
>>
>> Thanks,
>> Edward.
>>
>> On Mon, Jun 9, 2008 at 4:31 PM, Quintin Beukes <[EMAIL PROTECTED]> wrote:
>>> Ouch. Rub it, will let the pain go away quicker.
>>>
>>> It's copying a too large byte string into a too small buffer.
 # C  [libc.so.6+0x68de6]  strcpy+0x26
>>>
>>> This is definitely a JVM bug. Are you running a beta JVM ->
>>> 1.5.0_06-b05? I might be mistaken, but I've never noticed the b at the
>>> b05 at the end of any of them. Try upgrading it and confirm that it's
>>> still there.
>>>
>>> Q
>>>
>>> On Mon, Jun 9, 2008 at 9:25 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
 Hi community,

 I got "An unexpected error has been detected by HotSpot Virtual
 Machine" when i reduce the number of Tomcat server 3 to 1.

 #
 # An unexpected error has been detected by HotSpot Virtual Machine:
 #
 #  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
 #
 # Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
 # Problematic frame:
 # C  [libc.so.6+0x68de6]  strcpy+0x26
 #
 # An error report file with more information is saved as 
 hs_err_pid10535.log
 #
 # If you would like to submit a bug report, please visit:
 #   http://java.sun.com/webapps/bugreport/crash.jsp
 #

 Have Anyone experience this?

 --
 Best regards,
 Edward J. Yoon,
 http://blog.udanax.org

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


>>>
>>>
>>>
>>> --
>>> Quintin Beukes
>>>
>>> -
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>>
>>
>> --
>> Best regards,
>> Edward J. Yoon,
>> http://blog.udanax.org
>>
>
>
>
> --
> Best regards,
> Edward J. Yoon,
> http://blog.udanax.org
>



-- 
Best regards,
Edward J. Yoon,
http://blog.udanax.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42681] FarmWarDeployer

2008-06-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42681


Vicente TarĂ­n <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Quintin Beukes
Even if there is such a problem, the JVM should never crash. The JVM
crashing means tomcat did something the triggered a bug in the JVM.
Even overwritting/reading on buffers should be safe, since the JVM
should catch it and throw an exception.

On Mon, Jun 9, 2008 at 9:43 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
> Thank you very much for your nice advice.
> Then, Is there no related with the reduction of tomcat number?
>
> Thanks,
> Edward.
>
> On Mon, Jun 9, 2008 at 4:31 PM, Quintin Beukes <[EMAIL PROTECTED]> wrote:
>> Ouch. Rub it, will let the pain go away quicker.
>>
>> It's copying a too large byte string into a too small buffer.
>>> # C  [libc.so.6+0x68de6]  strcpy+0x26
>>
>> This is definitely a JVM bug. Are you running a beta JVM ->
>> 1.5.0_06-b05? I might be mistaken, but I've never noticed the b at the
>> b05 at the end of any of them. Try upgrading it and confirm that it's
>> still there.
>>
>> Q
>>
>> On Mon, Jun 9, 2008 at 9:25 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
>>> Hi community,
>>>
>>> I got "An unexpected error has been detected by HotSpot Virtual
>>> Machine" when i reduce the number of Tomcat server 3 to 1.
>>>
>>> #
>>> # An unexpected error has been detected by HotSpot Virtual Machine:
>>> #
>>> #  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
>>> #
>>> # Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
>>> # Problematic frame:
>>> # C  [libc.so.6+0x68de6]  strcpy+0x26
>>> #
>>> # An error report file with more information is saved as hs_err_pid10535.log
>>> #
>>> # If you would like to submit a bug report, please visit:
>>> #   http://java.sun.com/webapps/bugreport/crash.jsp
>>> #
>>>
>>> Have Anyone experience this?
>>>
>>> --
>>> Best regards,
>>> Edward J. Yoon,
>>> http://blog.udanax.org
>>>
>>> -
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>>
>>
>> --
>> Quintin Beukes
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>
>
> --
> Best regards,
> Edward J. Yoon,
> http://blog.udanax.org
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-- 
Quintin Beukes

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: An unexpected error has been detected by HotSpot Virtual Machine

2008-06-09 Thread Edward J. Yoon
Oh, I see. Thanks for your advice.

On Mon, Jun 9, 2008 at 5:45 PM, Quintin Beukes <[EMAIL PROTECTED]> wrote:
> Even if there is such a problem, the JVM should never crash. The JVM
> crashing means tomcat did something the triggered a bug in the JVM.
> Even overwritting/reading on buffers should be safe, since the JVM
> should catch it and throw an exception.
>
> On Mon, Jun 9, 2008 at 9:43 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
>> Thank you very much for your nice advice.
>> Then, Is there no related with the reduction of tomcat number?
>>
>> Thanks,
>> Edward.
>>
>> On Mon, Jun 9, 2008 at 4:31 PM, Quintin Beukes <[EMAIL PROTECTED]> wrote:
>>> Ouch. Rub it, will let the pain go away quicker.
>>>
>>> It's copying a too large byte string into a too small buffer.
 # C  [libc.so.6+0x68de6]  strcpy+0x26
>>>
>>> This is definitely a JVM bug. Are you running a beta JVM ->
>>> 1.5.0_06-b05? I might be mistaken, but I've never noticed the b at the
>>> b05 at the end of any of them. Try upgrading it and confirm that it's
>>> still there.
>>>
>>> Q
>>>
>>> On Mon, Jun 9, 2008 at 9:25 AM, Edward J. Yoon <[EMAIL PROTECTED]> wrote:
 Hi community,

 I got "An unexpected error has been detected by HotSpot Virtual
 Machine" when i reduce the number of Tomcat server 3 to 1.

 #
 # An unexpected error has been detected by HotSpot Virtual Machine:
 #
 #  SIGSEGV (0xb) at pc=0x00497de6, pid=10535, tid=1726987184
 #
 # Java VM: Java HotSpot(TM) Server VM (1.5.0_06-b05 mixed mode)
 # Problematic frame:
 # C  [libc.so.6+0x68de6]  strcpy+0x26
 #
 # An error report file with more information is saved as 
 hs_err_pid10535.log
 #
 # If you would like to submit a bug report, please visit:
 #   http://java.sun.com/webapps/bugreport/crash.jsp
 #

 Have Anyone experience this?

 --
 Best regards,
 Edward J. Yoon,
 http://blog.udanax.org

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


>>>
>>>
>>>
>>> --
>>> Quintin Beukes
>>>
>>> -
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>>
>>
>> --
>> Best regards,
>> Edward J. Yoon,
>> http://blog.udanax.org
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
>
>
> --
> Quintin Beukes
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-- 
Best regards,
Edward J. Yoon,
http://blog.udanax.org

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45108] JSPX source containing "&" renders "&" in output page

2008-06-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45108





--- Comment #7 from Julian Reschke <[EMAIL PROTECTED]>  2008-06-09 02:38:56 PST 
---
Again: a single, unescaped ampersand character in XML (and thus XHTML) is an
error, either in the implemenation, the specification, or both.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists
oh, maybe I missed the email discussion where we talked about adding 
this to svn


if I did, ignore this email
Filip

Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:


sandbox better place to play around :) ?


I don't see this as playing around. For those of us on this side of 
the Atlantic, relative externals mean we can make use of the EU svn 
mirror with the externals and get a significant performance 
improvement for checkouts and updates.


Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r665756 - in /tomcat/trunk: java/org/apache/el/parser/AstValue.java webapps/docs/config/systemprops.xml

2008-06-09 Thread markt
Author: markt
Date: Mon Jun  9 09:41:58 2008
New Revision: 665756

URL: http://svn.apache.org/viewvc?rev=665756&view=rev
Log:
Make forced coercion of null and "" to zero optional. It is enabled by default, 
as per the spec.
Patch by Nils Eckert.

Modified:
tomcat/trunk/java/org/apache/el/parser/AstValue.java
tomcat/trunk/webapps/docs/config/systemprops.xml

Modified: tomcat/trunk/java/org/apache/el/parser/AstValue.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/AstValue.java?rev=665756&r1=665755&r2=665756&view=diff
==
--- tomcat/trunk/java/org/apache/el/parser/AstValue.java (original)
+++ tomcat/trunk/java/org/apache/el/parser/AstValue.java Mon Jun  9 09:41:58 
2008
@@ -38,6 +38,10 @@
  */
 public final class AstValue extends SimpleNode {
 
+protected static final boolean COERCE_TO_ZERO =
+Boolean.valueOf(System.getProperty(
+"org.apache.el.parser.COERCE_TO_ZERO", "true")).booleanValue();
+
 protected static class Target {
 protected Object base;
 
@@ -129,12 +133,28 @@
 Target t = getTarget(ctx);
 ctx.setPropertyResolved(false);
 ELResolver resolver = ctx.getELResolver();
-resolver.setValue(ctx, t.base, t.property, 
-   // coerce to the expected type
-   ELSupport.coerceToType(value, 
-   resolver.getType(ctx, t.base, 
t.property)));
+
+// coerce to the expected type
+Class targetClass = resolver.getType(ctx, t.base, t.property);
+if (COERCE_TO_ZERO == true
+|| !isAssignable(value, targetClass)) {
+value = ELSupport.coerceToType(value, targetClass);
+}
+resolver.setValue(ctx, t.base, t.property, value);
+}
+
+private boolean isAssignable(Object value, Class targetClass) {
+if (targetClass == null) {
+return false;
+} else if (value != null && targetClass.isPrimitive()) {
+return false;
+} else if (value != null && !targetClass.isInstance(value)) {
+return false;
+}
+return true;
 }
 
+
 public MethodInfo getMethodInfo(EvaluationContext ctx, Class[] paramTypes)
 throws ELException {
 Target t = getTarget(ctx);

Modified: tomcat/trunk/webapps/docs/config/systemprops.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=665756&r1=665755&r2=665756&view=diff
==
--- tomcat/trunk/webapps/docs/config/systemprops.xml (original)
+++ tomcat/trunk/webapps/docs/config/systemprops.xml Mon Jun  9 09:41:58 2008
@@ -48,6 +48,18 @@
 
 
 
+
+  
+
+
+  If true, when coercing expressions to numbers
+  "" and null will be coerced to zero as required
+  by the specification. If not specified, the default value of
+  true will be used.
+
+
+  
+
 
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Mark Thomas


Filip Hanik - Dev Lists wrote:


oh, maybe I missed the email discussion where we talked about adding 
this to svn


There wasn't any discussion but what is there to discuss?

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r665758 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-06-09 Thread markt
Author: markt
Date: Mon Jun  9 09:45:25 2008
New Revision: 665758

URL: http://svn.apache.org/viewvc?rev=665758&view=rev
Log:
Propose making fix 43285 optional

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=665758&r1=665757&r2=665758&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun  9 09:45:25 2008
@@ -99,3 +99,10 @@
   http://svn.apache.org/viewvc?rev=664483&view=rev
   +1: markt
   -1: 
+
+* Make fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43285 
optional
+  Coercion of null and "" to zero can now be disabled if required
+  Patch by Nils Eckert
+  http://svn.apache.org/viewvc?rev=665756&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 43285] Missing EL Coercion causes argument type mismatch

2008-06-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43285





--- Comment #16 from Mark Thomas <[EMAIL PROTECTED]>  2008-06-09 09:45:39 PST 
---
I have applied your patch to make this optional to trunk and proposed it for
6.0.x


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists

Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:


oh, maybe I missed the email discussion where we talked about adding 
this to svn


There wasn't any discussion but what is there to discuss?

I would change the choice of names and the SVN location,
for me looking at svn, I have no idea what current/svn15 means, and when 
I check out

current (to get the 3,4,5 branches)

I know what current/tc4.1.x means
I know what current tc5.5.x means

but svn15? what does that mean, and how does it belong in current?

Filip


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Mark Thomas


Filip Hanik - Dev Lists wrote:


Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:


oh, maybe I missed the email discussion where we talked about adding 
this to svn


There wasn't any discussion but what is there to discuss?

I would change the choice of names and the SVN location,
for me looking at svn, I have no idea what current/svn15 means, and when 
I check out

current (to get the 3,4,5 branches)

I know what current/tc4.1.x means
I know what current tc5.5.x means

but svn15? what does that mean, and how does it belong in current?


Well, they could read the docs:
http://tomcat.apache.org/svn.html

I don't mind what it is called. If you have a better name for it, feel free 
to rename it.


I also don't mind where it ends up in the tree. If you prefer 
/tomcat/current/... and /tomcat/current-svn15/... then again, feel free to 
rename/move it.


All I ask is that you use svn move so svn clients can track what is going 
on without a massive delete and re-checkout.


Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists

Filip Hanik - Dev Lists wrote:

Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:


oh, maybe I missed the email discussion where we talked about adding 
this to svn


There wasn't any discussion but what is there to discuss?

I would change the choice of names and the SVN location,
for me looking at svn, I have no idea what current/svn15 means, and 
when I check out

current (to get the 3,4,5 branches)

I know what current/tc4.1.x means
I know what current tc5.5.x means

but svn15? what does that mean, and how does it belong in current?


the point being made, when subversion 2.0 comes out, are we gonna create 
a svn20 directory,

or should the name reflect what you actually are trying to do

Filip


Filip


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45156] Symbol not found: _open$UNIX2003

2008-06-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45156


Mark Thomas <[EMAIL PROTECTED]> changed:

   What|Removed |Added

  Component|Connectors  |Native:JK
Version|6.0.10  |unspecified




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists

Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:


Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:


oh, maybe I missed the email discussion where we talked about 
adding this to svn


There wasn't any discussion but what is there to discuss?

I would change the choice of names and the SVN location,
for me looking at svn, I have no idea what current/svn15 means, and 
when I check out

current (to get the 3,4,5 branches)

I know what current/tc4.1.x means
I know what current tc5.5.x means

but svn15? what does that mean, and how does it belong in current?


Well, they could read the docs:
http://tomcat.apache.org/svn.html

well, the docs doesn't make sense
|/current/|  	Single 
directory checkouts for Tomcat 4.x and 5.x
|/current/svn15| 
 	Single directory 
checkouts for Tomcat 4.x and 5.x using svn 1.5+ style relative links for 
the externals



if I check out current, I get two directories with 4.x and 5.x, instead 
of what the docs say, I should get 4.x and 5.x since I am now also 
downloading current/svn15

on a side note, you get 3.3.x as well with current.



I don't mind what it is called. If you have a better name for it, feel 
free to rename it.


I also don't mind where it ends up in the tree. If you prefer 
/tomcat/current/... and /tomcat/current-svn15/... then again, feel 
free to rename/move it.
again, I don't want to meddle in what you are already doing, or do the 
corrections for you.
I simply suggest that there is a more logical approach than naming a 
directory after a subversion version, and I also suggest to not create 
more stuff to check out when I check out tomcat/current


what has also happened here, if I use svn version <1.5 I can't check out 
current anymore, I need to check out current/xxx one by one


I all you want is another mirror using svn1.5 features for 4.x and 5.x, 
set up a structure for that, and use a name that is descriptive.


Filip



All I ask is that you use svn move so svn clients can track what is 
going on without a massive delete and re-checkout.


Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r665823 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/ha/session/mbeans-descriptors.xml java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/session

2008-06-09 Thread fhanik
Author: fhanik
Date: Mon Jun  9 11:49:42 2008
New Revision: 665823

URL: http://svn.apache.org/viewvc?rev=665823&view=rev
Log:
add jmx accessors for session creation and last accessed time

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=665823&r1=665822&r2=665823&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun  9 11:49:42 2008
@@ -32,13 +32,6 @@
   [ New proposals should be added at the end of the list ]
 
 
-* Add ManagerBase session getLastAccessedTimestamp and getCreationTimestamp 
for better
-  remote JMX access.
-  http://svn.apache.org/viewvc?rev=612971&view=rev
-  +1: pero, rjung, fhanik, markt
-  -1: remm: I believe it would need specific support for certain managers. 
Interested users
-could use their own extended manager instead.
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
   You can't use an unescaped quote if you quote the value with that character
   http://svn.apache.org/viewvc?rev=657231&view=rev

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=665823&r1=665822&r2=665823&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
Mon Jun  9 11:49:42 2008
@@ -342,6 +342,22 @@
   description="Id of the session"
  type="java.lang.String"/>
 
+
+  
+
+
+  
+
 http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=665823&r1=665822&r2=665823&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java Mon 
Jun  9 11:49:42 2008
@@ -1203,7 +1203,13 @@
 s.expire();
 }
 
-
+public long getLastAccessedTimestamp( String sessionId ) {
+Session s=(Session)sessions.get(sessionId);
+if(s== null)
+return -1 ;
+return s.getLastAccessedTime();
+}
+  
 public String getLastAccessedTime( String sessionId ) {
 Session s=(Session)sessions.get(sessionId);
 if( s==null ) {
@@ -1224,6 +1230,13 @@
 return new Date(s.getCreationTime()).toString();
 }
 
+public long getCreationTimestamp( String sessionId ) {
+Session s=(Session)sessions.get(sessionId);
+if(s== null)
+return -1 ;
+return s.getCreationTime();
+}
+
 //  JMX and Registration  
 protected String domain;
 protected ObjectName oname;

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml?rev=665823&r1=665822&r2=665823&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml 
Mon Jun  9 11:49:42 2008
@@ -160,6 +160,24 @@
  type="java.lang.String"/>
 
 
+   
+  
+
+
+
+  
+
+
   
 
   
 
 
+
+  
+
+
+
+  
+
+
   
 
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=665823&r1=665822&r2=665823&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Jun  9 11:49:42 2008
@@ -35,6 +35,10 @@
 
   
 
+  
+Add ManagerBase session getLastAccessedTimestamp and 
getCreationTimestamp for better
+remote JMX access. (pero)
+  
   44595
 Add possibility to request the QueueSize of an executor via JMX. 
(jfclere)
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r665827 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-06-09 Thread fhanik
Author: fhanik
Date: Mon Jun  9 11:54:34 2008
New Revision: 665827

URL: http://svn.apache.org/viewvc?rev=665827&view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=665827&r1=665826&r2=665827&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun  9 11:54:34 2008
@@ -47,7 +47,7 @@
   Make parsing of request line more tolerant of multiple SP and/or HT
   Note: This is on the critical path
   http://svn.apache.org/viewvc?rev=657954&view=rev
-  +1: markt, jfclere
+  +1: markt, jfclere, fhanik
   -1: 
   +0: remm
 
@@ -71,7 +71,7 @@
  } else {
  // Close the socket since this is
  // the end of not keep-alive request.
-  +1: remm, jfclere
+  +1: remm, jfclere, fhanik
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45101



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r665829 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/http11/ webapps/docs/

2008-06-09 Thread fhanik
Author: fhanik
Date: Mon Jun  9 11:59:43 2008
New Revision: 665829

URL: http://svn.apache.org/viewvc?rev=665829&view=rev
Log:
apply whitespace tolerance fix

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java

tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=665829&r1=665828&r2=665829&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun  9 11:59:43 2008
@@ -43,14 +43,6 @@
   remm Ok with this addition, but I would only vote +0 for inclusion in 
this release
(this still sounds like a very minor fix)
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42750
-  Make parsing of request line more tolerant of multiple SP and/or HT
-  Note: This is on the critical path
-  http://svn.apache.org/viewvc?rev=657954&view=rev
-  +1: markt, jfclere, fhanik
-  -1: 
-  +0: remm
-
 * After being done with an asynchronous sendfile, the socket should go to the 
poller (if assigned
   to a worker, it will block).
 Index: java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java?rev=665829&r1=665828&r2=665829&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java 
Mon Jun  9 11:59:43 2008
@@ -403,7 +403,8 @@
 throw new EOFException(sm.getString("iib.eof.error"));
 }
 
-if (buf[pos] == Constants.SP) {
+// Spec says single SP but it also says be tolerant of HT
+if (buf[pos] == Constants.SP || buf[pos] == Constants.HT) {
 space = true;
 request.method().setBytes(buf, start, pos - start);
 }
@@ -412,6 +413,20 @@
 
 }
 
+// Spec says single SP but also says be tolerant of multiple and/or HT
+while (space) {
+// Read new bytes if needed
+if (pos >= lastValid) {
+if (!fill())
+throw new EOFException(sm.getString("iib.eof.error"));
+}
+if (buf[pos] == Constants.SP || buf[pos] == Constants.HT) {
+pos++;
+} else {
+space = false;
+}
+}
+
 // Mark the current buffer position
 start = pos;
 int end = 0;
@@ -421,7 +436,6 @@
 // Reading the URI
 //
 
-space = false;
 boolean eol = false;
 
 while (!space) {
@@ -432,7 +446,8 @@
 throw new EOFException(sm.getString("iib.eof.error"));
 }
 
-if (buf[pos] == Constants.SP) {
+// Spec says single SP but it also says be tolerant of HT
+if (buf[pos] == Constants.SP || buf[pos] == Constants.HT) {
 space = true;
 end = pos;
 } else if ((buf[pos] == Constants.CR) 
@@ -459,6 +474,21 @@
 request.requestURI().setBytes(buf, start, end - start);
 }
 
+// Spec says single SP but also says be tolerant of multiple and/or HT
+while (space) {
+// Read new bytes if needed
+if (pos >= lastValid) {
+if (!fill())
+throw new EOFException(sm.getString("iib.eof.error"));
+}
+if (buf[pos] == Constants.SP || buf[pos] == Constants.HT) {
+pos++;
+} else {
+space = false;
+}
+}
+
+
 // Mark the current buffer position
 start = pos;
 end = 0;

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java?rev=665829&r1=665828&r2=665829&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalInputBuffer.java 
Mon Jun  9 11:59:43 2008
@@ -391,7 +391,8 @@
 throw new EOFException(sm.getString("iib.eof.error"));
 }
 
-if (buf[pos] == Constants.SP) {
+// Spec says single SP but it also says be toleran

svn commit: r665830 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

2008-06-09 Thread fhanik
Author: fhanik
Date: Mon Jun  9 12:01:32 2008
New Revision: 665830

URL: http://svn.apache.org/viewvc?rev=665830&view=rev
Log:
apply fix for APR sendfile to add connection to poller, not worker

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=665830&r1=665829&r2=665830&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun  9 12:01:32 2008
@@ -43,29 +43,6 @@
   remm Ok with this addition, but I would only vote +0 for inclusion in 
this release
(this still sounds like a very minor fix)
 
-* After being done with an asynchronous sendfile, the socket should go to the 
poller (if assigned
-  to a worker, it will block).
-Index: java/org/apache/tomcat/util/net/AprEndpoint.java
-===
 java/org/apache/tomcat/util/net/AprEndpoint.java   (revision 658292)
-+++ java/org/apache/tomcat/util/net/AprEndpoint.java   (working copy)
-@@ -1787,11 +1787,9 @@
- // Destroy file descriptor pool, which 
should close the file
- Pool.destroy(state.fdpool);
- Socket.timeoutSet(state.socket, soTimeout 
* 1000);
--// If all done hand this socket off to a 
worker for
-+// If all done put the socket back in the 
poller for
- // processing of further requests
--if (!processSocket(state.socket)) {
--Socket.destroy(state.socket);
--}
-+getPoller().add(state.socket);
- } else {
- // Close the socket since this is
- // the end of not keep-alive request.
-  +1: remm, jfclere, fhanik
-  -1: 
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45101
   Format header dates obtained from DirContextURLConnection as per HTTP spec
   Patch provided by Chris Hubick

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=665830&r1=665829&r2=665830&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Mon 
Jun  9 12:01:32 2008
@@ -1787,11 +1787,9 @@
 // Destroy file descriptor pool, which 
should close the file
 Pool.destroy(state.fdpool);
 Socket.timeoutSet(state.socket, soTimeout 
* 1000);
-// If all done hand this socket off to a 
worker for
+// If all done put the socket back in the 
poller for
 // processing of further requests
-if (!processSocket(state.socket)) {
-Socket.destroy(state.socket);
-}
+getPoller().add(state.socket);
 } else {
 // Close the socket since this is
 // the end of not keep-alive request.

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=665830&r1=665829&r2=665830&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Jun  9 12:01:32 2008
@@ -35,6 +35,9 @@
 
   
 
+  
+APR connector now adds connection to poller after using send file 
(remm)
+  
   42750
 request line should be tolerant of multiple whitespaces.
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r665834 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-06-09 Thread fhanik
Author: fhanik
Date: Mon Jun  9 12:12:11 2008
New Revision: 665834

URL: http://svn.apache.org/viewvc?rev=665834&view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=665834&r1=665833&r2=665834&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jun  9 12:12:11 2008
@@ -48,18 +48,19 @@
   Patch provided by Chris Hubick
   http://svn.apache.org/viewvc?rev=661488&view=rev
   +1: markt, remm (but there's downside as naming now depends on the utils)
+  +1: fhanik
   -1: 
 
 * Enhancement https://issues.apache.org/bugzilla/show_bug.cgi?id=45155
   Provide a workaround to a buggy MS WebDAV client.
   http://svn.apache.org/viewvc?rev=664345&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Provide belt and braces XSS protection. Really an app responsbility but worth
   protecting against in case the app forgets.
   http://svn.apache.org/viewvc?rev=664483&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Make fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43285 
optional
@@ -67,4 +68,5 @@
   Patch by Nils Eckert
   http://svn.apache.org/viewvc?rev=665756&view=rev
   +1: markt
+  +1: fhanik - candidate for STRICT_SERVLET_COMPLIANCE?
   -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Mark Thomas


Filip Hanik - Dev Lists wrote:

well, the docs doesn't make sense
|/current/|  Single 
directory checkouts for Tomcat 4.x and 5.x
|/current/svn15| 
 Single 
directory checkouts for Tomcat 4.x and 5.x using svn 1.5+ style relative 
links for the externals



if I check out current, I get two directories with 4.x and 5.x, instead 
of what the docs say, I should get 4.x and 5.x since I am now also 
downloading current/svn15
You can fix that with a 1.5 client but since not everyone has one then that 
does need to move underneath Tomcat to stop the issue. I'll move it to 
tomcat/current-svn15 but if you have a better suggestion for a name then 
feel free to rename it.


As a side note, I expect that eventually we will make svn1.5 the minimum 
client version but we are a way off that point yet.



on a side note, you get 3.3.x as well with current.
Yeah, 3.3.x is on the list to move to the archive area. This should be a 
whole lot easier with the 1.5 client and shouldn't result in the mass of 
commit messages we got when I archived 5.0.x


I simply suggest that there is a more logical approach than naming a 
directory after a subversion version


I all you want is another mirror using svn1.5 features for 4.x and 5.x, 
set up a structure for that, and use a name that is descriptive.
Given that the new dirs are for svn1.5, naming it current-svn15 seems 
suitably descriptive to me. Better suggestions welcome.


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



May Chun Chew/FEA/PEC is out of the office.

2008-06-09 Thread May Chun Chew

I will be out of the office starting  06/10/2008 and will not return until
06/12/2008.

I will not be accessing my email during this period. I am Contactable at
(65)97876648. For any urgent matters, pls contact my colleague, Richard
Seng at 63629293.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r665918 - in /tomcat: current-svn15/ current/svn15/ site/trunk/docs/svn.html site/trunk/xdocs/svn.xml

2008-06-09 Thread markt
Author: markt
Date: Mon Jun  9 15:11:48 2008
New Revision: 665918

URL: http://svn.apache.org/viewvc?rev=665918&view=rev
Log:
Move current (ie with externals) dirs for svn15 that were causing issues with 
pre 1.5 clients in previous location.
If anyone has a better name for the current-svn15 directory, feel free to 
rename it.

Added:
tomcat/current-svn15/   (props changed)
  - copied from r665916, tomcat/current/svn15/
Removed:
tomcat/current/svn15/
Modified:
tomcat/site/trunk/docs/svn.html
tomcat/site/trunk/xdocs/svn.xml

Propchange: tomcat/current-svn15/
--
svn:mergeinfo = 

Modified: tomcat/site/trunk/docs/svn.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/svn.html?rev=665918&r1=665917&r2=665918&view=diff
==
--- tomcat/site/trunk/docs/svn.html (original)
+++ tomcat/site/trunk/docs/svn.html Mon Jun  9 15:11:48 2008
@@ -268,8 +268,8 @@
   
   
 
-http://svn.apache.org/repos/asf/tomcat/current/svn15";>
-/current/svn15
+http://svn.apache.org/repos/asf/tomcat/current-svn15";>
+/current-svn15
 
 
 Single directory checkouts for Tomcat 4.x and 5.x using svn 1.5+

Modified: tomcat/site/trunk/xdocs/svn.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/svn.xml?rev=665918&r1=665917&r2=665918&view=diff
==
--- tomcat/site/trunk/xdocs/svn.xml (original)
+++ tomcat/site/trunk/xdocs/svn.xml Mon Jun  9 15:11:48 2008
@@ -52,8 +52,8 @@
 Single directory checkouts for Tomcat 4.x and 5.x
   
   
-http://svn.apache.org/repos/asf/tomcat/current/svn15";>
-/current/svn15
+http://svn.apache.org/repos/asf/tomcat/current-svn15";>
+/current-svn15
 Single directory checkouts for Tomcat 4.x and 5.x using svn 1.5+
 style relative links for the externals
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45173] New: Apache installation in Windows Vista Home Premium is failing

2008-06-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45173

   Summary: Apache installation in Windows Vista Home Premium is
failing
   Product: Tomcat 5
   Version: Unknown
  Platform: PC
OS/Version: Windows Vista
Status: NEW
  Severity: major
  Priority: P2
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Bug Description :

1.  When I try to click on startup.bat of Tomcat 5.0.26 in Windows Vista Home
Premium I get and exception showing java.net.SocketExcepiton : Permission
denied
although the CATALINA_HOME and JAVA_HOME are set properly.
The stacktarace goes like this :
  java.net.SocketException: Permission denied: listen failed
at java.net.PlainSocketImpl.socketListen(Native Method)
at java.net.PlainSocketImpl.listen(Unknown Source)
at java.net.ServerSocket.bind(Unknown Source)
at java.net.ServerSocket.(Unknown Source)
at java.net.ServerSocket.(Unknown Source)
at SocketTest.main(SocketTest.java:18)
java.net.SocketException: Permission denied: listen failed





2. If I use the Windows Installer, click of start button is not starting up the
Web Server.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]