svn commit: r660845 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-28 Thread jfclere
Author: jfclere
Date: Wed May 28 00:46:06 2008
New Revision: 660845

URL: http://svn.apache.org/viewvc?rev=660845&view=rev
Log:
My votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=660845&r1=660844&r2=660845&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed May 28 00:46:06 2008
@@ -59,7 +59,7 @@
   Make parsing of request line more tolerant of multiple SP and/or HT
   Note: This is on the critical path
   http://svn.apache.org/viewvc?rev=657954&view=rev
-  +1: markt
+  +1: markt, jfclere
   -1: 
   +0: remm
 
@@ -83,5 +83,5 @@
  } else {
  // Close the socket since this is
  // the end of not keep-alive request.
-  +1: remm
+  +1: remm, jfclere
   -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r660851 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/StandardThreadExecutor.java webapps/docs/changelog.xml

2008-05-28 Thread jfclere
Author: jfclere
Date: Wed May 28 00:59:42 2008
New Revision: 660851

URL: http://svn.apache.org/viewvc?rev=660851&view=rev
Log:
Fix #44595.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=660851&r1=660850&r2=660851&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed May 28 00:59:42 2008
@@ -39,11 +39,6 @@
   -1: remm: I believe it would need specific support for certain managers. 
Interested users
 could use their own extended manager instead.
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44595
-  http://svn.apache.org/viewvc?view=rev&revision=645428
-  +1: jfclere, rjung, fhanik, remm, pero
-  -1:
-
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
   You can't use an unescaped quote if you quote the value with that character
   http://svn.apache.org/viewvc?rev=657231&view=rev

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java?rev=660851&r1=660850&r2=660851&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java 
Wed May 28 00:59:42 2008
@@ -193,6 +193,10 @@
 return (executor != null) ? executor.getPoolSize() : 0;
 }
 
+public int getQueueSize() {
+return (executor != null) ? executor.getQueue().size() : -1;
+}
+
 // -- TaskQueue Inner Class
 class TaskQueue extends LinkedBlockingQueue {
 ThreadPoolExecutor parent = null;
@@ -254,4 +258,4 @@
 }
 
 
-}
\ No newline at end of file
+}

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=660851&r1=660850&r2=660851&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed May 28 00:59:42 2008
@@ -35,6 +35,9 @@
 
   
 
+  44595
+Add possibility to request the QueueSize of an executor via JMX. 
(jfclere)
+  
   expose alwaysSend flag for message dispatch interceptor 
 
   44833
 correctly override StandardSession methods from DeltaSession



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r661074 - /tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java

2008-05-28 Thread markt
Author: markt
Date: Wed May 28 13:42:22 2008
New Revision: 661074

URL: http://svn.apache.org/viewvc?rev=661074&view=rev
Log:
Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
If the context is reloaded, the classloader will have changed so need to reset 
it

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java?rev=661074&r1=661073&r2=661074&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java Wed 
May 28 13:42:22 2008
@@ -126,7 +126,9 @@
 }
 
 // Wait if we are reloading
+boolean reloaded = false;
 while (context.getPaused()) {
+reloaded = true;
 try {
 Thread.sleep(1000);
 } catch (InterruptedException e) {
@@ -134,6 +136,15 @@
 }
 }
 
+// Reloading will have stopped the old webappclassloader and
+// created a new one
+if (reloaded &&
+context.getLoader() != null &&
+context.getLoader().getClassLoader() != null) {
+Thread.currentThread().setContextClassLoader(
+context.getLoader().getClassLoader());
+}
+
 // Select the Wrapper to be used for this Request
 Wrapper wrapper = request.getWrapper();
 if (wrapper == null) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r661077 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-28 Thread markt
Author: markt
Date: Wed May 28 13:49:47 2008
New Revision: 661077

URL: http://svn.apache.org/viewvc?rev=661077&view=rev
Log:
Further fix for 43683

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=661077&r1=661076&r2=661077&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed May 28 13:49:47 2008
@@ -80,3 +80,10 @@
  // the end of not keep-alive request.
   +1: remm, jfclere
   -1: 
+
+* Further fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
+  Reloaded context has new classloader so the context classloader needs to
+  be reset
+  http://svn.apache.org/viewvc?rev=661074&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 43683] Accessing Servlet while Reloading context gives 404 error

2008-05-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43683





--- Comment #9 from Mark Thomas <[EMAIL PROTECTED]>  2008-05-28 13:49:54 PST ---
Thanks for your efforts on the test case. It made things so much easier to
investigate. I have committed a fix to trunk that addresses this and proposed
it for 6.0.x
http://svn.apache.org/viewvc?rev=661074&view=rev

If you are able to test my fix that would be very helpful.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45090] New: tomcat jvm crashed.

2008-05-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45090

   Summary: tomcat jvm crashed.
   Product: Tomcat 5
   Version: Unknown
  Platform: PC
OS/Version: Windows Server 2003
Status: NEW
  Severity: blocker
  Priority: P1
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Created an attachment (id=22026)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22026)
Error report file hs_err_pid3016.log

On our production server, our tomcat node stopped operating due to a jvm crash.
We detected this crash from the wrapper log, please find below the log data,

INFO   | jvm 8| 2008/05/27 09:45:16 | #
INFO   | jvm 8| 2008/05/27 09:45:16 | # An unexpected error has been
detected by HotSpot Virtual Machine:
INFO   | jvm 8| 2008/05/27 09:45:16 | #
INFO   | jvm 8| 2008/05/27 09:45:16 | #  EXCEPTION_ACCESS_VIOLATION
(0xc005) at pc=0x7eed78a7, pid=3016, tid=8032
INFO   | jvm 8| 2008/05/27 09:45:16 | #
INFO   | jvm 8| 2008/05/27 09:45:16 | # Java VM: Java HotSpot(TM) Server VM
(1.4.2_10-b03 mixed mode)
INFO   | jvm 8| 2008/05/27 09:45:16 | # Problematic frame:
INFO   | jvm 8| 2008/05/27 09:45:16 | # C  [DOCNRN22.DLL+0x78a7]
INFO   | jvm 8| 2008/05/27 09:45:16 | #
INFO   | jvm 8| 2008/05/27 09:45:16 | # An error report file with more
information is saved as hs_err_pid3016.log
INFO   | jvm 8| 2008/05/27 09:45:16 | #
INFO   | jvm 8| 2008/05/27 09:45:16 | # If you would like to submit a bug
report, please visit:
INFO   | jvm 8| 2008/05/27 09:45:16 | #  
http://java.sun.com/webapps/bugreport/crash.jsp
INFO   | jvm 8| 2008/05/27 09:45:16 | #
ERROR  | wrapper  | 2008/05/27 09:45:16 | JVM exited unexpectedly.
STATUS | wrapper  | 2008/05/27 09:45:21 | Launching a JVM...
INFO   | jvm 9| 2008/05/27 09:45:21 | Wrapper (Version 3.2.2)
http://wrapper.tanukisoftware.org
INFO   | jvm 9| 2008/05/27 09:45:21 |   Copyright 1999-2006 Tanuki
Software, Inc.  All Rights Reserved.
INFO   | jvm 9| 2008/05/27 09:45:21 |
INFO   | jvm 9| 2008/05/27 09:45:23 | May 27, 2008 9:45:23 AM
org.apache.coyote.http11.Http11Protocol init
INFO   | jvm 9| 2008/05/27 09:45:23 | INFO: Initializing Coyote HTTP/1.1 on
http-8080
INFO   | jvm 9| 2008/05/27 09:45:23 | May 27, 2008 9:45:23 AM
org.apache.catalina.startup.Catalina load
INFO   | jvm 9| 2008/05/27 09:45:23 | INFO: Initialization processed in
1235 ms


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]