svn commit: r649783 - in /tomcat/trunk/test/org/apache/el: ./ lang/ lang/TestELSupport.java
Author: markt
Date: Sat Apr 19 02:44:35 2008
New Revision: 649783
URL: http://svn.apache.org/viewvc?rev=649783&view=rev
Log:
Add test case for bug 43656. Based on a patch from Konstantin Kolinko.
Added:
tomcat/trunk/test/org/apache/el/
tomcat/trunk/test/org/apache/el/lang/
tomcat/trunk/test/org/apache/el/lang/TestELSupport.java (with props)
Added: tomcat/trunk/test/org/apache/el/lang/TestELSupport.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/lang/TestELSupport.java?rev=649783&view=auto
==
--- tomcat/trunk/test/org/apache/el/lang/TestELSupport.java (added)
+++ tomcat/trunk/test/org/apache/el/lang/TestELSupport.java Sat Apr 19 02:44:35
2008
@@ -0,0 +1,46 @@
+package org.apache.el.lang;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+
+import junit.framework.TestCase;
+
+public class TestELSupport extends TestCase {
+public void testBigDecimal() {
+testIsSame(new BigDecimal(
+
"0.123456789012345678901234567890123456789012345678901234567890123456789"));
+}
+
+public void testBigInteger() {
+testIsSame(new BigInteger(
+
"1234567890123456789012345678901234567890123456789012345678901234567890"));
+}
+
+public void testLong() {
+testIsSame(Long.valueOf(0x0102030405060708L));
+}
+
+public void testInteger() {
+testIsSame(Integer.valueOf(0x01020304));
+}
+
+public void testShort() {
+testIsSame(Short.valueOf((short) 0x0102));
+}
+
+public void testByte() {
+testIsSame(Byte.valueOf((byte) 0xEF));
+}
+
+public void testDouble() {
+testIsSame(Double.valueOf(0.123456789012345678901234));
+}
+
+public void testFloat() {
+testIsSame(Float.valueOf(0.123456F));
+}
+
+private static void testIsSame(Object value) {
+assertEquals(value, ELSupport.coerceToNumber(value, value.getClass()));
+}
+}
Propchange: tomcat/trunk/test/org/apache/el/lang/TestELSupport.java
--
svn:eol-style = native
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r649784 - /tomcat/trunk/java/org/apache/el/lang/ELSupport.java
Author: markt
Date: Sat Apr 19 02:47:07 2008
New Revision: 649784
URL: http://svn.apache.org/viewvc?rev=649784&view=rev
Log:
More fixes for bug 43656 so new test case passes.
Modified:
tomcat/trunk/java/org/apache/el/lang/ELSupport.java
Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ELSupport.java?rev=649784&r1=649783&r2=649784&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/ELSupport.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/ELSupport.java Sat Apr 19 02:47:07 2008
@@ -223,9 +223,15 @@
if (number instanceof BigDecimal) {
return ((BigDecimal) number).toBigInteger();
}
+if (number instanceof BigInteger) {
+return new BigInteger(number.toString());
+}
return BigInteger.valueOf(number.longValue());
}
if (BigDecimal.class.equals(type)) {
+if (number instanceof BigDecimal) {
+return new BigDecimal(number.toString());
+}
if (number instanceof BigInteger) {
return new BigDecimal((BigInteger) number);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r649785 - /tomcat/trunk/test/org/apache/el/lang/TestELSupport.java
Author: markt Date: Sat Apr 19 02:51:35 2008 New Revision: 649785 URL: http://svn.apache.org/viewvc?rev=649785&view=rev Log: Add license and props. Modified: tomcat/trunk/test/org/apache/el/lang/TestELSupport.java (contents, props changed) Modified: tomcat/trunk/test/org/apache/el/lang/TestELSupport.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/lang/TestELSupport.java?rev=649785&r1=649784&r2=649785&view=diff == --- tomcat/trunk/test/org/apache/el/lang/TestELSupport.java (original) +++ tomcat/trunk/test/org/apache/el/lang/TestELSupport.java Sat Apr 19 02:51:35 2008 @@ -1,3 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.el.lang; import java.math.BigDecimal; Propchange: tomcat/trunk/test/org/apache/el/lang/TestELSupport.java -- svn:keywords = Author Date Id Revision - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r649786 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sat Apr 19 02:54:03 2008 New Revision: 649786 URL: http://svn.apache.org/viewvc?rev=649786&view=rev Log: Propose test case and further fixes for 43656. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=649786&r1=649785&r2=649786&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Apr 19 02:54:03 2008 @@ -87,3 +87,14 @@ http://svn.apache.org/viewvc?rev=649638&view=rev +1: markt -1: + +* Add test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 + http://svn.apache.org/viewvc?rev=649783&view=rev + http://svn.apache.org/viewvc?rev=649785&view=rev + +1: markt + -1: + +* Fixes to make test case above pass + http://svn.apache.org/viewvc?rev=649784&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 --- Comment #4 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-19 02:51:39 PST --- Thanks for the test case. I have added the unit test and the necessary fixes to trunk. They have also been proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44683] connection pool is not being kept alive by dbcp
https://issues.apache.org/bugzilla/show_bug.cgi?id=44683 Marco Boniardi <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Comment #2 from Marco Boniardi <[EMAIL PROTECTED]> 2008-04-19 06:21:24 PST --- We have the very similar problem in our production environment. Apache Tomcat/6.0.16 Jdk 1.6.0_05-b13 Sun Microsystems Inc. Linux 2.6.18-53.1.4.el5 amd64 mysql-connector-java-5.0.8-bin.jar This is one of our 6 pool: problems: 1) totally random the connection pool collapses, no errors, just hunged. You can not retrive it from context with a lookup, we can not have connections. All requests hunged. We think it's closely related to db idle connection management, with idle connection closed server side due to timeout while the connection pool can't see it. 2) We see validation query running, but very often twice than in timeBetweenEvictionRunsMillis. We wrote 40 seconds, it runs every 80 seconds. For some reason, in some machine of the cluster (older tomcat restart?) we see validation query running 4 times (160 seconds) the time we defined, and it's stable, always 160 sec., even if I don't know if tomorrow it goes to 320sec. or it stays to 160. In our idea there is something wrong with the Timer that manage query validation for idle connection. Problably timeBetweenEvictionRunsMillis grows over server timeout period causing connections pool collape. Till 3 weeks ago we had Tom 5.0.x and everything was perfect, lower performance but perfect. In these days we have to restart 1-2 servers /day in a 10 serves cluster due to hunged connection pool. The problem is not related to traffic because it happends night time too. I hope this can help to figure out the problem. Regards Marco Boniardi -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44683] connection pool is not being kept alive by dbcp
https://issues.apache.org/bugzilla/show_bug.cgi?id=44683 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WORKSFORME --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-19 10:00:47 PST --- Please don't hijack bugs if they look 'similar' to yours. If you have the same bug, then please add your comments. If there are differences, open a new one. Comment #2 looks like a DBCP issue so you will probably have more luck reporting the issue to the DBCP folks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43653] NIO connector may corrupt first line of HTTP/1. 1 100 Continue response
https://issues.apache.org/bugzilla/show_bug.cgi?id=43653 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #8 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-19 10:29:10 PST --- This was fixed a little while ago and has been included in 6.0.16 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
