Re: svn commit: r646605 - /tomcat/tc6.0.x/trunk/STATUS.txt
[EMAIL PROTECTED] wrote: * Clean up type checking code. Patch provided by Konstantin Kolinko. http://svn.apache.org/viewvc?rev=646571&view=rev +1: markt + -0: remm (44766: the first patch http://svn.apache.org/viewvc?rev=646106&view=rev is not mentioned ?) Oversight on my part. I'll do that now. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r646667 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Apr 10 00:23:03 2008 New Revision: 646667 URL: http://svn.apache.org/viewvc?rev=646667&view=rev Log: Add missing proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=646667&r1=64&r2=646667&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Apr 10 00:23:03 2008 @@ -130,3 +130,9 @@ http://svn.apache.org/viewvc?rev=646574&view=rev +1: markt, remm -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44766 + Handle custom subtypes of java.lang.Number + http://svn.apache.org/viewvc?view=rev&revision=646106 + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r646719 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: remm Date: Thu Apr 10 02:48:51 2008 New Revision: 646719 URL: http://svn.apache.org/viewvc?rev=646719&view=rev Log: - Votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=646719&r1=646718&r2=646719&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Apr 10 02:48:51 2008 @@ -121,8 +121,7 @@ * Clean up type checking code. Patch provided by Konstantin Kolinko. http://svn.apache.org/viewvc?rev=646571&view=rev - +1: markt - -0: remm (44766: the first patch http://svn.apache.org/viewvc?rev=646106&view=rev is not mentioned ?) + +1: markt, remm -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44428 @@ -134,5 +133,5 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44766 Handle custom subtypes of java.lang.Number http://svn.apache.org/viewvc?view=rev&revision=646106 - +1: markt + +1: markt, remm -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494
--- Comment #34 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 01:59:00 PST
---
I tested recent trunk and also 6.x with the latest STATUS file patches for this
issue applied.
When we change maxHttpHeaderSize from the default to something bigger, we still
have a problem with POST bodies bigger than 8K. Using smaller maxHttpHedaerSize
than the default 8KB seems to be no problem, bigger sizes like 16KB or 48KB
show the problem.
We simply use a text file of some size between 16KB and 64KB, send it via POST
using e.g. "curl --data-binary @FILE" or "ab -p FILE" and try to read via a
simple JSP:
Size: <%= request.getContentLength() %>
<%
out.println("Start reading");
try {
String line = null;
int n = 0;
int m = 0;
java.io.BufferedReader br = request.getReader();
while ((line = br.readLine()) != null) {
n=n+1;
m=m+line.length()+1;
out.println(line);
}
out.println("Nothing more available, lines=" + n + ", bytes=" + m);
} catch(Exception ex) {
out.println(ex);ex.printStackTrace();
}
out.println("Done");
%>
It's primitive and the byte count shown below is wrong if the file has DOS line
endings, but the failure is shown clearly, because when truncation appears,
you'll be shown less than 8KB of data.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java
On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote:
> Author: markt
> Date: Wed Apr 9 15:29:28 2008
> New Revision: 646571
>
> URL: http://svn.apache.org/viewvc?rev=646571&view=rev
> Log:
> Clean up type checking code. Patch provided by Konstantin Kolinko.
>
> Modified:
> tomcat/trunk/java/org/apache/el/parser/AstNegative.java
> Modified: tomcat/trunk/java/org/apache/el/parser/AstNegative.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/AstNegative.java?rev=646571&r1=646570&r2=646571&view=diff
> ==
> --- tomcat/trunk/java/org/apache/el/parser/AstNegative.java (original)
> +++ tomcat/trunk/java/org/apache/el/parser/AstNegative.java Wed Apr 9
> 15:29:28 2008
> @@ -59,23 +59,22 @@
> }
> return new Long(-Long.parseLong((String) obj));
> }
> -Class type = obj.getClass();
> -if (obj instanceof Long || Long.TYPE == type) {
> +if (obj instanceof Long) {
> return new Long(-((Long) obj).longValue());
> }
> -if (obj instanceof Double || Double.TYPE == type) {
> +if (obj instanceof Double) {
> return new Double(-((Double) obj).doubleValue());
> }
> -if (obj instanceof Integer || Integer.TYPE == type) {
> +if (obj instanceof Integer) {
> return new Integer(-((Integer) obj).intValue());
> }
> -if (obj instanceof Float || Float.TYPE == type) {
> +if (obj instanceof Float) {
> return new Float(-((Float) obj).floatValue());
> }
> -if (obj instanceof Short || Short.TYPE == type) {
> +if (obj instanceof Short) {
> return new Short((short) -((Short) obj).shortValue());
> }
> -if (obj instanceof Byte || Byte.TYPE == type) {
> +if (obj instanceof Byte) {
> return new Byte((byte) -((Byte) obj).byteValue());
> }
> Long num = (Long) coerceToNumber(obj, Long.class);
Possible problem: this class is apparently generated code. Not sure if
it should really be modified.
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44797] New: url-pattern not working as expected.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44797
Summary: url-pattern not working as expected.
Product: Tomcat 5
Version: 5.5.26
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
A static URL-Pattern yeilds empty PathInfo.
E.g.,
MyServlet
/user/request
and, in the mapped Servlet:
System.err.println("[PathInfoCS] PathInfo: " + request.getPathInfo());
Yeilds:
[PathInfoCS] PathInfo: null
for, e.g., /myapp/user/request
s of things like: '/user/request*' and '/user/req*' return
pathInfo, but don't map to the underlying servlet properly.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r646816 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik Date: Thu Apr 10 07:24:33 2008 New Revision: 646816 URL: http://svn.apache.org/viewvc?rev=646816&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=646816&r1=646815&r2=646816&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Apr 10 07:24:33 2008 @@ -100,8 +100,9 @@ cases I could think of. http://svn.apache.org/viewvc?rev=645719&view=rev (Remy's resizing fix) http://svn.apache.org/viewvc?rev=645722&view=rev (mark/reset fix) - +1: markt, fhanik, remm + +1: markt, remm -1: + +1: fhanik, still not completely fixed * Better handling of lack of permission for context specific logging http://svn.apache.org/viewvc?rev=646543&view=rev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 Ruediger Pluem <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #35 from Remy Maucherat <[EMAIL PROTECTED]> 2008-04-10 08:05:13 PST --- You've got to be able to reproduce this using the test webapp provided in this report (the line length is configurable, and there's a readLine test). I don't like a test using ab. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #36 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 08:15:03 PST --- I'll try that. For the sake of completeness, here's the exception stack: java.io.IOException at org.apache.catalina.connector.InputBuffer.reset(InputBuffer.java:475) at org.apache.catalina.connector.CoyoteReader.reset(CoyoteReader.java:134) at org.apache.catalina.connector.CoyoteReader.readLine(CoyoteReader.java:191) at org.apache.jsp.maxpost_jsp._jspService(maxpost_jsp.java:65) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:369) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:337) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:568) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447) at java.lang.Thread.run(Thread.java:595) The same test (curl/ab) works for 6.0.14 and for default maxHttpHeaderSize. Will report about the war soon. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #37 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 08:24:21 PST --- Using the war and maxHttpHeaderSize="16384" I did the following test case: Characters size: 17000___ Use MultiByte Character: ( ) yes (*) no _ [test case:] (*) only read [readLine()/read()/read(char[1])] ( ) garbage in buffer * real read size: 4096 ( ) mark/reset * read size before mark(): 0___ * readAheadLimit size: 8192 * read size after mark()/before reset(): 8192 _ submit _ And on the next page I choose the first send (#readLine test): request#getReader()#readLine test abcdefghijklmnopqrst send request#getReader()#read() test abcdefghijklmnopqrst send request#getReader()#read(char[1]) test abcdefghijklmnopqrst send The result is: request#getReader test. readLine.jsp is called. _ Content-Type:multipart/form-data; boundary=xnyLAaB03X Character Encoding:UTF-8 Content-Length:17115 expected:17076 real read:4827 isSame:false -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44797] url-pattern not working as expected.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44797 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-10 10:00:19 PST --- I don't see anything here that does not comply with the servlet spec. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r646889 - /tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
Author: markt
Date: Thu Apr 10 10:29:23 2008
New Revision: 646889
URL: http://svn.apache.org/viewvc?rev=646889&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44408
Avoid bottleneck by calling the synchronized method only once.
Patch provided by Robert Andersson.
Modified:
tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java?rev=646889&r1=646888&r2=646889&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Thu Apr 10
10:29:23 2008
@@ -70,6 +70,8 @@
*/
public class PageContextImpl extends PageContext {
+ private static final JspFactory jspf = JspFactory.getDefaultFactory();
+
private BodyContentImpl[] outs;
private int depth;
@@ -895,7 +897,7 @@
final ProtectedFunctionMapper functionMap, final
boolean escape)
throws ELException {
Object retValue;
-final ExpressionFactory exprFactory =
JspFactory.getDefaultFactory().getJspApplicationContext(pageContext.getServletContext()).getExpressionFactory();
+final ExpressionFactory exprFactory =
jspf.getJspApplicationContext(pageContext.getServletContext()).getExpressionFactory();
if (SecurityUtil.isPackageProtectionEnabled()) {
try {
retValue = AccessController
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r646891 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Apr 10 10:32:23 2008 New Revision: 646891 URL: http://svn.apache.org/viewvc?rev=646891&view=rev Log: Propose patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=646891&r1=646890&r2=646891&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Apr 10 10:32:23 2008 @@ -136,3 +136,9 @@ http://svn.apache.org/viewvc?view=rev&revision=646106 +1: markt, remm -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44408 + Avoid bottleneck by calling synchronized method only once + http://svn.apache.org/viewvc?rev=646889&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44408] EL-expression evaluation slow due to synchronization caused by JspFactory. getDefaultFactory
https://issues.apache.org/bugzilla/show_bug.cgi?id=44408 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-10 10:30:09 PST --- This has been fixed in trunk and proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java
Remy Maucherat wrote: On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: Author: markt Date: Wed Apr 9 15:29:28 2008 New Revision: 646571 URL: http://svn.apache.org/viewvc?rev=646571&view=rev Log: Clean up type checking code. Patch provided by Konstantin Kolinko. Modified: tomcat/trunk/java/org/apache/el/parser/AstNegative.java Possible problem: this class is apparently generated code. Not sure if it should really be modified. My preference is to keep the change. We can merge/overwrite if/when the class is recreated. That said I am not going to die in a ditch over this change. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #38 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 11:25:43 PST --- Since most people are deeper in the code than I, here's what i get if I instrument o.a.c.connector.InputBuffer with a couple of log statements and post the file with increased maxHttpHeaderSize. So markPos get set to -1 in realWriteChars: 10.04.2008 20:25:17 org.apache.catalina.connector.InputBuffer mark INFO: Set markPos in mark from -1 to 0 10.04.2008 20:25:17 org.apache.catalina.connector.InputBuffer realReadChars INFO: Found markPos in realReadChars 0 10.04.2008 20:25:17 org.apache.catalina.connector.InputBuffer realWriteChars INFO: Reset markPos in realWriteChars from 0 to -1 10.04.2008 20:25:17 org.apache.catalina.connector.InputBuffer reset INFO: Found =-1 in reset for CHAR_STATE 10.04.2008 20:25:17 org.apache.catalina.connector.InputBuffer reset INFO: Reset markPos in reset/CHAR_STATE to -1 java.io.IOException: markPos=-1 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #39 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 11:41:32 PST --- And the stack in realWriteChars is: at org.apache.catalina.connector.InputBuffer.realWriteChars(InputBuffer. java:335) at org.apache.tomcat.util.buf.CharChunk.flushBuffer(CharChunk.java:440) at org.apache.tomcat.util.buf.CharChunk.append(CharChunk.java:295) at org.apache.tomcat.util.buf.B2CConverter.convert(B2CConverter.java:100 ) at org.apache.catalina.connector.InputBuffer.realReadChars(InputBuffer.j ava:371) at org.apache.tomcat.util.buf.CharChunk.substract(CharChunk.java:416) at org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:405) at org.apache.catalina.connector.CoyoteReader.read(CoyoteReader.java:105 ) at org.apache.catalina.connector.CoyoteReader.readLine(CoyoteReader.java :154) at org.apache.jsp.maxpost_jsp._jspService(maxpost_jsp.java:64) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper .java:369) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:3 37) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV alve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV alve.java:175) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j ava:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j ava:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal ve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav a:286) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java :844) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.proce ss(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:44 7) at java.lang.Thread.run(Thread.java:595) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44801] New: getPathInfo() and getRequestURI() handle %3B incorrectly
https://issues.apache.org/bugzilla/show_bug.cgi?id=44801 Summary: getPathInfo() and getRequestURI() handle %3B incorrectly Product: Tomcat 6 Version: 6.0.16 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Servlet & JSP API AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] We have some servlets that take rather general path-info's. When these include a properly escaped semicolon, invoking getPathInfo() in Tomcat results in a truncated path info. For example, one might have the request http://myhost/mywebapp/servlet/myservlet/pathcomp1/pathcomp2/foo%3Bbar?spaz=bot The expected result of getPathInfo() is /pathcomp1/pathcomp2/foo%3Bbar The actual result in Tomcat is: /pathcomp1/pathcomp2/foo Note that the %3B is already converted into a ";" character in the results of getRequestURI(), which is also quite incorrect. Some comparative testing shows that Sun Java Web Server behaves in the same incorrect fashion. In the exception that proves the rule, WebSphere does this correctly (one of the few things...) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44801] getPathInfo() and getRequestURI() handle %3B incorrectly
https://issues.apache.org/bugzilla/show_bug.cgi?id=44801 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-10 13:30:54 PST --- Lets give the thread on the users list a chance to conclude before opening a bug. If the thread does conclude there is a bug, then feel free to re-open this. Given the users thread has already shown this doesn't happen in the direct to Tomcat case please include httpd version and mod_jk version (if used) and any other relevant version information if you do re-open it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44801] getPathInfo() and getRequestURI() handle %3B incorrectly
https://issues.apache.org/bugzilla/show_bug.cgi?id=44801 --- Comment #2 from Jess Holle <[EMAIL PROTECTED]> 2008-04-10 13:32:45 PST --- Sorry to have jumped the gun on this. As per the user's group thread, it would seem that this is an issue only with Apache. Is there any reasonable way I can tell whether this is an issue in mod_proxy_ajp or rather in the Tomcat side of things? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r646980 - in /tomcat/trunk/java/org/apache/catalina/ssi: ExpressionParseTree.java SSIExternalResolver.java SSIMediator.java SSIPrintenv.java SSIProcessor.java SSIServletExternalResolver.ja
Author: markt
Date: Thu Apr 10 14:51:57 2008
New Revision: 646980
URL: http://svn.apache.org/viewvc?rev=646980&view=rev
Log:
Java 5 clean up. No functional change.
Modified:
tomcat/trunk/java/org/apache/catalina/ssi/ExpressionParseTree.java
tomcat/trunk/java/org/apache/catalina/ssi/SSIExternalResolver.java
tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java
tomcat/trunk/java/org/apache/catalina/ssi/SSIPrintenv.java
tomcat/trunk/java/org/apache/catalina/ssi/SSIProcessor.java
tomcat/trunk/java/org/apache/catalina/ssi/SSIServletExternalResolver.java
Modified: tomcat/trunk/java/org/apache/catalina/ssi/ExpressionParseTree.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ssi/ExpressionParseTree.java?rev=646980&r1=646979&r2=646980&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ssi/ExpressionParseTree.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ssi/ExpressionParseTree.java Thu Apr
10 14:51:57 2008
@@ -31,12 +31,12 @@
* Contains the current set of completed nodes. This is a workspace for the
* parser.
*/
-private LinkedList nodeStack = new LinkedList();
+private LinkedList nodeStack = new LinkedList();
/**
* Contains operator nodes that don't yet have values. This is a workspace
* for the parser.
*/
-private LinkedList oppStack = new LinkedList();
+private LinkedList oppStack = new LinkedList();
/**
* The root node after the expression has been parsed.
*/
@@ -78,7 +78,7 @@
}
while (true) {
if (oppStack.size() == 0) break;
-OppNode top = (OppNode)oppStack.get(0);
+OppNode top = oppStack.get(0);
// If the top is a spacer then don't pop
// anything
if (top == null) break;
@@ -103,7 +103,7 @@
*/
private void resolveGroup() {
OppNode top = null;
-while ((top = (OppNode)oppStack.remove(0)) != null) {
+while ((top = oppStack.remove(0)) != null) {
// Let it fill its branches
top.popValues(nodeStack);
// Stick it on the resolved node stack
@@ -195,7 +195,7 @@
if (oppStack.size() != 0) {
throw new ParseException("Unused opp nodes exist.", et.getIndex());
}
-root = (Node)nodeStack.get(0);
+root = nodeStack.get(0);
}
/**
@@ -272,9 +272,9 @@
* Lets the node pop its own branch nodes off the front of the
* specified list. The default pulls two.
*/
-public void popValues(List values) {
-right = (Node)values.remove(0);
-left = (Node)values.remove(0);
+public void popValues(List values) {
+right = values.remove(0);
+left = values.remove(0);
}
}
private final class NotNode extends OppNode {
@@ -291,8 +291,8 @@
/**
* Overridden to pop only one value.
*/
-public void popValues(List values) {
-left = (Node)values.remove(0);
+public void popValues(List values) {
+left = values.remove(0);
}
Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIExternalResolver.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ssi/SSIExternalResolver.java?rev=646980&r1=646979&r2=646980&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ssi/SSIExternalResolver.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ssi/SSIExternalResolver.java Thu Apr
10 14:51:57 2008
@@ -34,7 +34,7 @@
* @param variableNames
*the collection to add to
*/
-public void addVariableNames(Collection variableNames);
+public void addVariableNames(Collection variableNames);
public String getVariableValue(String name);
Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java?rev=646980&r1=646979&r2=646980&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java (original)
+++ tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java Thu Apr 10
14:51:57 2008
@@ -125,8 +125,8 @@
}
-public Collection getVariableNames() {
-Set variableNames = new HashSet();
+public Collection getVariableNames() {
+Set variableNames = new HashSet();
//These built-in variables are supplied by the mediator ( if not
// over-written by
// the user ) and always exist
@@ -135,9 +135,9 @@
variableNames.add("LAST_MODIFIED");
ssiExternalResolver.addVariableNames(variableNames);
//Remove any variables that are reserved by th
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494
--- Comment #40 from Filip Hanik <[EMAIL PROTECTED]> 2008-04-10 14:56:29 PST
---
I think I might have found the problem,
I've been unable to reproduce the error using the NIO/APR (APR below) connector
with setting
I reproduce the error everytime using the regular connector
and I am unable to reproduce it using the APR connector
so I started debugging it,
The problem is in org.apache.tomcat.util.CharChunk
in two subsequent reads, where the inputbuffer is 16384, it tries to use the
CharChunk to store all the data. The reason it works with the APR/NIO connector
is cause those connectors never pull out more than 8192 bytes from the socket
buffer.
however, the regular BIO connector will read as much as it can, and then the
B2CConverter tries to append the character array to the CharChunk,
but the CharChunk refuses to grow beyond the limit.
The fix is simple
Index: java/org/apache/tomcat/util/buf/CharChunk.java
===
--- java/org/apache/tomcat/util/buf/CharChunk.java (revision 646950)
+++ java/org/apache/tomcat/util/buf/CharChunk.java (working copy)
@@ -454,7 +454,8 @@
// Can't grow above the limit
if( limit > 0 &&
desiredSize > limit) {
- desiredSize=limit;
+ limit = desiredSize;
+ //desiredSize=limit;
}
if( buff==null ) {
however, we could probably shrink the CharChunk back on a recycle, but it wont
grow beyond maxHttpHeaderSize, so I am not sure we need to
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #23 from Carlos <[EMAIL PROTECTED]> 2008-04-10 14:59:01 PST --- Hi, In my case, I tried: *adding C:\j2sdk1.4.2_17\bin to the PATH environmental variable *copying the mscvr71.dll file to C:\WINDOWS\system32 directory *Adding an environmental variable with name JAVA_HOME whcih pointed to C:\j2sdk1.4.2_17\bin -After all of which I restarted the machine and/or re-installed Tomcat Non of the above worked to get the Tomcat service started and I keep getting the same error reported in the logs... Did I do something wrong? Did I miss something? -BeasC -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #41 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 15:15:06 PST --- Hi Filip, I didn't yet read your comment, because we both worked in parallel (mid-air collission). I'm posting my finding nevertheless, so we can look for the best solution. This gets funny: while looking at the code I realized, that the 5.5.x/6.0.x patch that introduced the problem (r569969 resp. r572498) actually removed 3 lines of code, that I added in r371804 (resp. Bill added my patch). https://issues.apache.org/bugzilla/show_bug.cgi?id=38346 If I add those lines back, then I can not reproduce the problem with or without maxHttpHeaderSize. I tried my POST test and also tried some fo the numerous possibilities with the test war. So I think the following patch for trunk is worth some tests: http://people.apache.org/~rjung/patches/maxhttpheadersize.patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #42 from Filip Hanik <[EMAIL PROTECTED]> 2008-04-10 15:20:00 PST --- If we don't want the simple fix of growing the CharChunk, (since CharChunk will always be <=maxHttpHeaderSize, a character is at least one byte) then the code would have to back out during the conversion, but I think it's not worth the time, this code is fragile, and has proven to break easily during larger fixes and refactoring of APIs. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #43 from Filip Hanik <[EMAIL PROTECTED]> 2008-04-10 15:21:07 PST --- hi Rainer, both patches do the exact same thing, one explicit one implicit, I'd vote +1 for either or Filip -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #44 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-10 15:29:58 PST --- Next mid-air, BZ is obviously not IM :) When I use the test war, the garbage test still seems to fail, even with default maxHttpHeaderSize. The behaviour is the same with my patch, with Filip's, with both of them applied and with unchanged trunk. It might be, that I don't understand how to use this test case. I choose the garbage radio button with default values, submit and the choose send. The resulting page says "correct:true", but then asks me to Retry the request. If I do that, I get a correct:false. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
JNDIRealm connection pooling
While trying to track down an issue with logins taking a very long time, I just discovered in the 5.5.26 source code/Javadoc for JNDIRealm (likewise in the 6.0 documentation) that there's a big bold TODO to support connection pooling in the JNDIRealm. I think this may be part of the login problem I'm seeing. Looking over the current source code, I can see that it's going to require a fairly extensive refactoring of the JNDIRealm code. I'm willing to take a shot at fixing it, but wanted to first check with the list on a couple of things, mostly matters of process. 1. I could not find a corresponding case in the bug database in either the 5.5 or 6.0 builds. Since this is an issue in both, should I open it in both? If not, does anyone care which one the issue is filed against? 2. Likewise, is there a preferred version to contribute patches against? Ideally for me, I would patch 5.5, since that's what we use at work, but I'm willing to do either provided the patch ultimately could be applied to both versions. 3. Library dependencies. The fix, as indicated in the comment, requires that the MessageFormat objects for user search and/or user pattern be pooled in some manner to make them thread-safe. My initial thought was to use the Apache Commons Pool library for this purpose. I see it listed in the Core Optional Libraries and JNDIRealm is a part of the catalina.optional library, but I don't see commons-pool*.jar show up anywhere in the package, so I must be missing something. Any pointers on that would be greatly appreciated. Also, if I'm way off base and should be using some other pooling mechanism please let me know. Thanks in advance for any pointers. Regards, Brandon
DO NOT REPLY [Bug 44804] New: JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6.0_03-b05 mixed mode)
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 Summary: JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6.0_03- b05 mixed mode) Product: Tomcat 5 Version: 5.5.23 Platform: Sun URL: internal OS/Version: Solaris Status: NEW Severity: blocker Priority: P1 Component: Connector:Coyote AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Created an attachment (id=21811) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21811) Core Dump for JVM Crash Configuration: 64 bit JVM Java HotSpot(TM) Server VM (1.6.0_03-b05 mixed mode) The error happened when a SOAP Message with attachments was received by a webservice. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r646571 - in /tomcat/trunk/java/org/apache/el: lang/ELArithmetic.java lang/ELSupport.java parser/AstNegative.java
On Thu, 2008-04-10 at 19:01 +0100, Mark Thomas wrote: > Remy Maucherat wrote: > > On Wed, 2008-04-09 at 22:29 +, [EMAIL PROTECTED] wrote: > >> Author: markt > >> Date: Wed Apr 9 15:29:28 2008 > >> New Revision: 646571 > >> > >> URL: http://svn.apache.org/viewvc?rev=646571&view=rev > >> Log: > >> Clean up type checking code. Patch provided by Konstantin Kolinko. > >> > >> Modified: > >> tomcat/trunk/java/org/apache/el/parser/AstNegative.java > > > > Possible problem: this class is apparently generated code. Not sure if > > it should really be modified. > > My preference is to keep the change. We can merge/overwrite if/when the > class is recreated. That said I am not going to die in a ditch over this > change. Yes, keeping the change is better. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #45 from Suzuki Yuichiro <[EMAIL PROTECTED]> 2008-04-10 21:26:03 PST --- Hi, The behavior of the test case with default values is as follows. 1. It posts 8192 multibytes characters. 2. The posted data is read up to 4096 characters. (And other information like the multipart-boundary characters and the Content-Disposition is read, too) 3. It checks whether the read data is correct or not. 4. They are repeated by retrying. If "correct:false" is output by retrying, perhaps there were garbage bytes of the multibyte character in the buffer of the ReadConvertor object, after the previous request. When the end of the read byte sequence is not complete as the multibyte character, InputStreamReader seems to keep imperfect byte sequence internally until the under-lying stream returns -1. And the imperfect byte sequence will be used as the start bytes of the next request. Please see the recycle method part of the attached patch. Yuichiro -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r647056 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Author: mturk
Date: Thu Apr 10 22:51:52 2008
New Revision: 647056
URL: http://svn.apache.org/viewvc?rev=647056&view=rev
Log:
Don't log ajp_connection_tcp_get_message failure as ERROR. This can be part of
normal operation caused by cping/cpong. We are later logging that either as
INFO in handle_cping_cpong or as ERROR in (ab)normal response
Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=647056&r1=647055&r2=647056&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Thu Apr 10
22:51:52 2008
@@ -1078,14 +1078,14 @@
if (rc < 0) {
ae->last_errno = errno;
if (rc == JK_SOCKET_EOF) {
-jk_log(l, JK_LOG_ERROR,
+jk_log(l, JK_LOG_INFO,
"(%s) can't receive the response message from tomcat, "
"tomcat (%s) has forced a connection close for socket %d",
ae->worker->name,
jk_dump_hinfo(&ae->worker->worker_inet_addr, buf),
ae->sd);
}
else {
-jk_log(l, JK_LOG_ERROR,
+jk_log(l, JK_LOG_INFO,
"(%s) can't receive the response message from tomcat, "
"network problems or tomcat (%s) is down (errno=%d)",
ae->worker->name,
jk_dump_hinfo(&ae->worker->worker_inet_addr, buf),
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44804] JVM Crash: SIGSEGV Java HotSpot(TM) Server VM (1.6 .0_03-b05 mixed mode)
https://issues.apache.org/bugzilla/show_bug.cgi?id=44804 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Severity|blocker |major Status|NEW |NEEDINFO --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-10 23:50:11 PST --- Which version of the native connector are you using? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
