svn commit: r645428 - /tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java
Author: jfclere
Date: Mon Apr 7 02:29:41 2008
New Revision: 645428
URL: http://svn.apache.org/viewvc?rev=645428&view=rev
Log:
Submitted by Ruediger Pluem. PR#44595
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java?rev=645428&r1=645427&r2=645428&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java Mon
Apr 7 02:29:41 2008
@@ -193,6 +193,10 @@
return (executor != null) ? executor.getPoolSize() : 0;
}
+public int getQueueSize() {
+return (executor != null) ? executor.getQueue().size() : -1;
+}
+
// -- TaskQueue Inner Class
class TaskQueue extends LinkedBlockingQueue {
ThreadPoolExecutor parent = null;
@@ -254,4 +258,4 @@
}
-}
\ No newline at end of file
+}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645429 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: jfclere Date: Mon Apr 7 02:36:34 2008 New Revision: 645429 URL: http://svn.apache.org/viewvc?rev=645429&view=rev Log: Add proposal to back the enhancement that allows to check the QueueSize of an executor via JMX. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=645429&r1=645428&r2=645429&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 7 02:36:34 2008 @@ -88,4 +88,9 @@ http://svn.apache.org/viewvc?view=rev&revision=645184 +1: fhanik -1: - \ No newline at end of file + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44595 + http://svn.apache.org/viewvc?view=rev&revision=645428 + +1: jfclere + -1: + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 jfclere <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44764] New: service wont start if JDK 6u5 is the only Java installed
https://issues.apache.org/bugzilla/show_bug.cgi?id=44764 Summary: service wont start if JDK 6u5 is the only Java installed Product: Tomcat 5 Version: 5.5.26 Platform: PC OS/Version: Windows Server 2003 Status: NEW Severity: critical Priority: P2 Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I am currently on a customer site, where they are installing onto a brand new server, they had the JDK 6 update 5 on the server, having never had any previous versions of Java on the server. They had not installed Apache Tomcat, so I installed 5.5.26 but it would not start with an error message [2008-04-07 10:48:39] [986 prunsrv.c] [error] Failed creating java C:\Program Files\Java\jre1.6.0_05\bin\client\jvm.dll I could find no reason why this should have failed, and no mention of any incompatibilities on the internet. HOWEVER, I then uninstalled the JDK 6u5 and installed JRE 1.5 instead. Of course I had to re-install Apache Tomcat 5.5.26 (so that it knew about the new Java installation) and it worked perfectly! I then tried to go back and uninstalled both products, and reinstalled JDK 6u5 and Apache Tomcat 5.5.26 on top of it, and sure enough I got the same errors and it would not start up. FULL LOG FILE: [2008-04-07 10:48:11] [info] Procrun (2.0.3.0) started [2008-04-07 10:48:11] [info] Service Tomcat5 name Apache Tomcat [2008-04-07 10:48:11] [info] Service Tomcat5 installed [2008-04-07 10:48:11] [info] Procrun finished. [2008-04-07 10:48:11] [info] Procrun (2.0.3.0) started [2008-04-07 10:48:11] [info] Updating service... [2008-04-07 10:48:11] [info] Service Tomcat5 updated [2008-04-07 10:48:11] [info] Update service finished. [2008-04-07 10:48:11] [info] Procrun finished. [2008-04-07 10:48:21] [info] Procrun (2.0.3.0) started [2008-04-07 10:48:21] [info] Updating service... [2008-04-07 10:48:21] [info] Service Tomcat5 updated [2008-04-07 10:48:21] [info] Update service finished. [2008-04-07 10:48:21] [info] Procrun finished. [2008-04-07 10:48:21] [info] Procrun (2.0.3.0) started [2008-04-07 10:48:21] [info] Updating service... [2008-04-07 10:48:21] [info] Service Tomcat5 updated [2008-04-07 10:48:21] [info] Update service finished. [2008-04-07 10:48:21] [info] Procrun finished. [2008-04-07 10:48:33] [info] Procrun (2.0.3.0) started [2008-04-07 10:48:33] [info] Running Service... [2008-04-07 10:48:33] [info] Starting service... [2008-04-07 10:48:33] [174 javajni.c] [error] The specified module could not be found. [2008-04-07 10:48:33] [986 prunsrv.c] [error] Failed creating java C:\Program Files\Java\jre1.6.0_05\bin\client\jvm.dll [2008-04-07 10:48:33] [1260 prunsrv.c] [error] ServiceStart returned 1 [2008-04-07 10:48:33] [info] Run service finished. [2008-04-07 10:48:33] [info] Procrun finished. [2008-04-07 10:48:39] [info] Procrun (2.0.3.0) started [2008-04-07 10:48:39] [info] Running Service... [2008-04-07 10:48:39] [info] Starting service... [2008-04-07 10:48:39] [174 javajni.c] [error] The specified module could not be found. [2008-04-07 10:48:39] [986 prunsrv.c] [error] Failed creating java C:\Program Files\Java\jre1.6.0_05\bin\client\jvm.dll [2008-04-07 10:48:39] [1260 prunsrv.c] [error] ServiceStart returned 1 [2008-04-07 10:48:39] [info] Run service finished. [2008-04-07 10:48:39] [info] Procrun finished. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44595] Add possibility to request the QueueSize of an executor via JMX
https://issues.apache.org/bugzilla/show_bug.cgi?id=44595 jfclere <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from jfclere <[EMAIL PROTECTED]> 2008-04-07 02:37:05 PST --- Committed to trunk proposed for backport in 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645466 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Mon Apr 7 04:30:31 2008 New Revision: 645466 URL: http://svn.apache.org/viewvc?rev=645466&view=rev Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=645466&r1=645465&r2=645466&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 7 04:30:31 2008 @@ -91,6 +91,6 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44595 http://svn.apache.org/viewvc?view=rev&revision=645428 - +1: jfclere + +1: jfclere, rjung -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 42366] Memory leak in newer mod_jk version when connection is abortet by the client
https://issues.apache.org/bugzilla/show_bug.cgi?id=42366 Rainer Jung <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|NEEDINFO --- Comment #6 from Rainer Jung <[EMAIL PROTECTED]> 2008-04-07 06:55:39 PST --- I couldn't reproduce the leak, even with FlushPackets. Can you provide a simple webapp to reproduce it? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #31 from Remy Maucherat <[EMAIL PROTECTED]> 2008-04-07 08:10:29 PST --- I found a problem with the buffer resizing in conjunction with mark/reset. Index: java/org/apache/tomcat/util/buf/CharChunk.java === --- java/org/apache/tomcat/util/buf/CharChunk.java (revision 645466) +++ java/org/apache/tomcat/util/buf/CharChunk.java (working copy) @@ -480,7 +480,7 @@ tmp=new char[newSize]; } - System.arraycopy(buff, start, tmp, start, end-start); + System.arraycopy(buff, 0, tmp, 0, end); buff = tmp; tmp = null; } Alternately, a buffered reader could be used (since the decoding code is now fixed, there should be no problem). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44766] New: Tomcat's EL implementation doesn' t coerce custom Number subclasses
https://issues.apache.org/bugzilla/show_bug.cgi?id=44766
Summary: Tomcat's EL implementation doesn't coerce custom Number
subclasses
Product: Tomcat 6
Version: 6.0.14
Platform: All
URL: http://jira.jboss.com/jira/browse/RF-1715
OS/Version: All
Status: NEW
Severity: major
Priority: P2
Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
I have class that extends java.lang.Number, and want to use something like #{x
+ 1} where x is instance of my class.
But get IllegalArgumentException.
java.util.MissingResourceException: Can't find resource for bundle
java.util.PropertyResourceBundle, key el.convert
at java.util.ResourceBundle.getObject(ResourceBundle.java:325)
at java.util.ResourceBundle.getString(ResourceBundle.java:285)
at org.apache.el.util.MessageFactory.getArray(MessageFactory.java:67)
at org.apache.el.util.MessageFactory.get(MessageFactory.java:47)
at org.apache.el.lang.ELArithmetic.coerce(ELArithmetic.java:367)
at org.apache.el.lang.ELArithmetic.add(ELArithmetic.java:237)
at org.apache.el.parser.AstPlus.getValue(AstPlus.java:24)
at
org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:186)
at
com.sun.facelets.el.TagValueExpression.getValue(TagValueExpression.java:71)
That is caused by org.apache.el.lang.ELArithmetic.coerce(Number) method that
uses very strange Number type check
public final static boolean isNumberType(final Class type) {
return type == (java.lang.Long.class) || type == Long.TYPE || type ==
(java.lang.Double.class) || type == Double.TYPE || type ==
(java.lang.Byte.class) || type == Byte.TYPE || type == (java.lang.Short.class)
|| type == Short.TYPE || type == (java.lang.Integer.class) || type ==
Integer.TYPE || type == (java.lang.Float.class) || type == Float.TYPE || type
== (java.math.BigInteger.class) || type == (java.math.BigDecimal.class);
}
I think this method could make use of instanceof operator so that users could
provide their own Number subclasses.
Referenced classes reside within jasper-el.jar, so I choose Jasper component.
The bug is inspired by http://jira.jboss.com/jira/browse/RF-1715
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44767] New: Manager app does not prompt for credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=44767 Summary: Manager app does not prompt for credentials Product: Tomcat 5 Version: 5.5.26 Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Webapps:Manager AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, The manager application does not prompt for credentials; it simply returns 403. Using Firefox 1.5 (RHEL-5). If you add the user:pass@ to the URL, it lets me in. At the very least, the documentation should be updated to indicate that you have to put the creds in there, as you won't be prompted. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44769] New: Add ByteBuffer creation method to org.apache. tomcat.jni.Stdlib
https://issues.apache.org/bugzilla/show_bug.cgi?id=44769 Summary: Add ByteBuffer creation method to org.apache.tomcat.jni.Stdlib Product: Tomcat 6 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Native:Integration AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Currently, org.apache.tomcat.jni.Stdlib provides only memory allocation, deallocation and primitive access methods. It would be much more useful if there's a method that creates a new ByteBuffer from the memory region allocated by Stdlib.malloc(), like the following example code: // Stdlib.asByteBuffer(long mem, int sz) long addr = Stdlib.malloc(1024); ByteBuffer buf = Stdlib.asByteBuffer(addr, 1024); Optionally exposing a method that returns the address of the ByteBuffer will be very useful: // Stdlib.address(ByteBuffer buf) long addr = Stdlib.address(buf); Stdlib.free(addr); -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44769] Add ByteBuffer creation method to org.apache. tomcat.jni.Stdlib
https://issues.apache.org/bugzilla/show_bug.cgi?id=44769 Mladen Turk <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Mladen Turk <[EMAIL PROTECTED]> 2008-04-07 12:05:02 PST --- This looks pretty usable. It's a simple call to NewDirectByteBuffer Think it can be done in one call, I mean allocation and creation of ByteBuffer (much faster) so ByteBuffer bb = Stdlib.newDirectByteBuffer(size) ... Stdlib.freeByteBuffer(bb) Of course other option would be to use single Stdlib.malloc of higher size and then create ByteBuffers on slices. So this long addr = Stdlib.malloc(1024 * 16) ByteBuffer bba = Stdlib.asByteBuffer(addr, 1024); ByteBuffer bbb = Stdlib.asByteBuffer(addr + 1024, 1024); ... Stdlib.free(addr) has meaning only if you need to have addr of longer life then ByteBuffer and you wish to have your memory manager, which can be very useful in case you need to create/destroy many objects (malloc is time expensive). In other case the first one will do. A Stdlib.getByteBufferAddress(bb) will return the memory that you can use with Stdlib.memread, memset, etc. Think I'll implement all options -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44769] Add ByteBuffer creation method to org.apache. tomcat.jni.Stdlib
https://issues.apache.org/bugzilla/show_bug.cgi?id=44769 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645700 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik Date: Mon Apr 7 14:27:56 2008 New Revision: 645700 URL: http://svn.apache.org/viewvc?rev=645700&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=645700&r1=645699&r2=645700&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 7 14:27:56 2008 @@ -81,7 +81,7 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44759 Need source to build java docs http://svn.apache.org/viewvc?rev=645169&view=rev - +1: markt + +1: markt,fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42662 @@ -91,6 +91,6 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44595 http://svn.apache.org/viewvc?view=rev&revision=645428 - +1: jfclere, rjung + +1: jfclere, rjung, fhanik -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #32 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-07 14:27:43 PST --- The mark/reset test case still fails. I'm looking into it but it is taking me time to figure out exactly where the error is. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645719 - /tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java
Author: markt Date: Mon Apr 7 15:43:52 2008 New Revision: 645719 URL: http://svn.apache.org/viewvc?rev=645719&view=rev Log: Remy's resizing fix from bug 44494 Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java?rev=645719&r1=645718&r2=645719&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Mon Apr 7 15:43:52 2008 @@ -480,7 +480,7 @@ tmp=new char[newSize]; } - System.arraycopy(buff, start, tmp, start, end-start); + System.arraycopy(buff, 0, tmp, 0, end); buff = tmp; tmp = null; } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
Author: markt
Date: Mon Apr 7 15:47:54 2008
New Revision: 645722
URL: http://svn.apache.org/viewvc?rev=645722&view=rev
Log:
All of the issues I was seeing with mark/reset were due to states that resulted
in a call to CharChunk.flushBuffer().
I tried many different ways to fix it but by far the simplest was this patch
that just increases the size of the CharChunk internal buffer when creating the
mark sufficiently that flushBuffer() is never called.
With this patch I can't break mark/reset with bug 44494's test case in single
or multibyte mode.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java?rev=645722&r1=645721&r2=645722&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java Mon Apr 7
15:47:54 2008
@@ -457,11 +457,7 @@
cb.setOffset(0);
}
}
-int offset = readAheadLimit;
-if (offset < size) {
-offset = size;
-}
-cb.setLimit(cb.getStart() + offset);
+cb.setLimit(cb.getStart() + readAheadLimit + size);
markPos = cb.getStart();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645723 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Mon Apr 7 15:52:19 2008 New Revision: 645723 URL: http://svn.apache.org/viewvc?rev=645723&view=rev Log: Propose final fixes for 44494. Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=645723&r1=645722&r2=645723&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Mon Apr 7 15:52:19 2008 @@ -108,3 +108,12 @@ http://svn.apache.org/viewvc?rev=643497&view=rev +1: mark -1: + +* Final fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 + With these patches the test case provided in the bug report + passes for multibyte and single bytes tests including the edge + cases I could think of. + http://svn.apache.org/viewvc?rev=645719&view=rev (Remy's resizing fix) + http://svn.apache.org/viewvc?rev=645722&view=rev (mark/reset fix) + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r645724 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Mon Apr 7 15:52:38 2008 New Revision: 645724 URL: http://svn.apache.org/viewvc?rev=645724&view=rev Log: Propose final fixes for 44494. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=645724&r1=645723&r2=645724&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 7 15:52:38 2008 @@ -94,3 +94,11 @@ +1: jfclere, rjung, fhanik -1: +* Final fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 + With these patches the test case provided in the bug report + passes for multibyte and single bytes tests including the edge + cases I could think of. + http://svn.apache.org/viewvc?rev=645719&view=rev (Remy's resizing fix) + http://svn.apache.org/viewvc?rev=645722&view=rev (mark/reset fix) + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #33 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-07 15:50:41 PST --- I have a fix for this now. Thsi fix and Remy's fix above have been proposed for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44767] Manager app does not prompt for credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=44767 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-07 15:55:11 PST --- Looks like you have some cached credentials on your browser. Please use the users list if you need more help fixing this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
On Mon, 2008-04-07 at 22:47 +, [EMAIL PROTECTED] wrote: > Author: markt > Date: Mon Apr 7 15:47:54 2008 > New Revision: 645722 > > URL: http://svn.apache.org/viewvc?rev=645722&view=rev > Log: > All of the issues I was seeing with mark/reset were due to states that > resulted in a call to CharChunk.flushBuffer(). > I tried many different ways to fix it but by far the simplest was this > patch that just increases the size of the CharChunk internal buffer > when creating the mark sufficiently that flushBuffer() is never > called. > With this patch I can't break mark/reset with bug 44494's test case in > single or multibyte mode. Oops, I had forgotten that part, there was indeed another problem with that. Sorry. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #19 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-07 16:24:57 PST --- *** Bug 44764 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44764] service wont start if JDK 6u5 is the only Java installed
https://issues.apache.org/bugzilla/show_bug.cgi?id=44764 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-07 16:24:57 PST --- *** This bug has been marked as a duplicate of bug 41538 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java
Remy Maucherat wrote: On Mon, 2008-04-07 at 22:47 +, [EMAIL PROTECTED] wrote: Author: markt Date: Mon Apr 7 15:47:54 2008 New Revision: 645722 URL: http://svn.apache.org/viewvc?rev=645722&view=rev Log: All of the issues I was seeing with mark/reset were due to states that resulted in a call to CharChunk.flushBuffer(). I tried many different ways to fix it but by far the simplest was this patch that just increases the size of the CharChunk internal buffer when creating the mark sufficiently that flushBuffer() is never called. With this patch I can't break mark/reset with bug 44494's test case in single or multibyte mode. Oops, I had forgotten that part, there was indeed another problem with that. Sorry. No problem. I learned quite a bit digging around in that code ;) If you can see a better way of fixing this then feel free to propose an alternative patch. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41538] Unable to run Tomcat as a Windows service under JDK 1.6
https://issues.apache.org/bugzilla/show_bug.cgi?id=41538 --- Comment #20 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-07 16:31:01 PST --- Just to summarise: Short term fix options: - add %JAVA_HOME%\bin to the PATH - copy %JAVA_HOME%\bin\mscvr71.dll to a folder on the path A quick check shows that it is jvm.dll that requires msvcr71.dll, not Tomcat or the service. Re-reading the comments above, particularly comment #6, suggests that this is probably an issue with procrun, part of commons-daemon. Commons uses JIRA. new issues can be created via: https://issues.apache.org/jira/browse/DAEMON -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
