Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-29 Thread Rainer Jung

Hi Günter, hi Makr,

Guenter Knauf schrieb:

Hi Mark,

I see nothing unusual with that - NetWare behaves here exactly same as
Windows;
OS: NetWare
VM: 1.4.2
SYS:\nwtest
SYS:\nwtest
file:/SYS:/nwtest/
SYS:\nwtest
java: Class org.apache.markt.NetWareTest exited successfully

The above test was called with netware-specific -envCWD which is same as a cd 
into the dir:
java -envCWD=sys:/nwtest org.apache.markt.NetWareTest %1

I did a second test with:
java -cp sys:/nwtest org.apache.markt.NetWareTest

OS: NetWare
VM: 1.4.2
SYS:
SYS:
file:/SYS:/
SYS:
java: Class org.apache.markt.NetWareTest exited successfully

java -cp d:\projects\java\nwtest org.apache.markt.NetWareTest
OS: Windows XP
VM: 1.4.2_12-b03
D:\
D:\
file:/D:/
D:\

and now we see a difference to Windows in that the the Windows drive has a 
trailing backslash while the NetWare volume doesnt have one

Guenter.


The ant code Mark is referring to handles multi letter drive names 
(valume names) well for Netware (they have an explicit Netware rule 
there). But for DOS and Netware it doesn't allow a *leading* path 
separator in front of the volume name (as Mark already said). More 
precisely it only allows some UNC notations on DOS. For Netware it won't 
like any leading path separator (backslash).


In your case the path is \sys:\..., and I think Mark wants to find out, 
where the leading backslash comes form.


The leading backslash might not be new in TC 4.1.37, but the 
implementation of the test for absolute paths changed a lot between ant 
1.5 and 1.7.


Mark: it is interesting in the stderr log, that the classpath for 
compilation contains items with and items without leading backslash. So 
the difference in code generating the first two items (WEB-INF/classes) 
and the other ones might give an idea.


Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r642412 - /tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml

2008-03-29 Thread Rainer Jung

Sehr gut!

Schon mal das neue release target ausprobiert?

Ich muss mir unbedingt mal die JUnit reports ansehen.

Grüße sendet

Rainer


[EMAIL PROTECTED] schrieb:

Author: pero
Date: Fri Mar 28 15:31:20 2008
New Revision: 642412

URL: http://svn.apache.org/viewvc?rev=642412&view=rev
Log:
add my last changes

Modified:
tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml

Modified: tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml?rev=642412&r1=642411&r2=642412&view=diff
==
--- tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml (original)
+++ tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml Fri Mar 28 15:31:20 2008
@@ -24,6 +24,7 @@
 
   

 Rainer Jung
+Peter Rossbach
 Changelog
   
 
@@ -32,6 +33,16 @@

   
  
   
+  	New Membership service (org.apache.catalina.cluster.membership.McastService) 
+  	to better control tomcat cluster node start and stop (pero)

+  
+  
+Porting the junit testcases (pero)
+  
+  
+ReplicationValve NPE as requested context is not available (pero)
+  
+  
 Initial port of org.apache.catalina.cluster from Tomcat 5.5
 to Tomcat 6.0 (rjung)
   
@@ -39,6 +50,15 @@
   
   
 
+  
+build.xml javadoc generation (pero)
+  
+  
+Update cluster etc/cluster-server.xml example (pero)
+  
+  
+Add cluster membership element docs to OACC (pero)
+  
   
 Initial port of Tomcat 5.5 cluster docs to OACC (rjung)
   


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r642533 - /tomcat/sandbox/tomcat-oacc/trunk/test/build.xml

2008-03-29 Thread pero
Author: pero
Date: Sat Mar 29 06:35:10 2008
New Revision: 642533

URL: http://svn.apache.org/viewvc?rev=642533&view=rev
Log:
fix testcase (new jar names and release layout)

Modified:
tomcat/sandbox/tomcat-oacc/trunk/test/build.xml

Modified: tomcat/sandbox/tomcat-oacc/trunk/test/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/test/build.xml?rev=642533&r1=642532&r2=642533&view=diff
==
--- tomcat/sandbox/tomcat-oacc/trunk/test/build.xml (original)
+++ tomcat/sandbox/tomcat-oacc/trunk/test/build.xml Sat Mar 29 06:35:10 2008
@@ -16,7 +16,7 @@
   limitations under the License.
 -->
 
-
+



@@ -24,12 +24,13 @@
 


+   





-   
+   
 

 
@@ -37,9 +38,8 @@



-   
-   
-   
+   
+   
 
 
 
@@ -49,7 +49,7 @@
 


-   This ant script implements some testcases to verify the 
key functions of tomcat OACC module.
+   This ant script implements some testcases to verify the 
key functions of tomcat clustering module.
You find this script at: ${ant.file}





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r642412 - /tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml

2008-03-29 Thread Peter Rossbach

Hi Rainer,

damit die junit test case funktionieren muss DU ein junit.jar in  
Deiner ant installation hinzufügen.
Ich benutzte immer noch ein junit 3.8. Junit 4 nutzt Annotationen und  
damit konnte ich mich bisher überhaupt nicht anfreunden.


Mit freundlichen Grüßen
Peter Roßbach
[EMAIL PROTECTED]



Am 29.03.2008 um 12:19 schrieb Rainer Jung:


Sehr gut!

Schon mal das neue release target ausprobiert?

Ich muss mir unbedingt mal die JUnit reports ansehen.

Grüße sendet

Rainer


[EMAIL PROTECTED] schrieb:

Author: pero
Date: Fri Mar 28 15:31:20 2008
New Revision: 642412
URL: http://svn.apache.org/viewvc?rev=642412&view=rev
Log:
add my last changes
Modified:
tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml
Modified: tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/ 
docs/changelog.xml?rev=642412&r1=642411&r2=642412&view=diff
= 
=

--- tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml (original)
+++ tomcat/sandbox/tomcat-oacc/trunk/docs/changelog.xml Fri Mar 28  
15:31:20 2008

@@ -24,6 +24,7 @@

 Rainer Jung
+Peter Rossbach
 Changelog
   
 @@ -32,6 +33,16 @@
   
  
   
+  	New Membership service  
(org.apache.catalina.cluster.membership.McastService) +  	to  
better control tomcat cluster node start and stop (pero)

+  
+  
+Porting the junit testcases (pero)
+  
+  
+ReplicationValve NPE as requested context is not  
available (pero)

+  
+  
 Initial port of org.apache.catalina.cluster from Tomcat 5.5
 to Tomcat 6.0 (rjung)
   
@@ -39,6 +50,15 @@
   
   
 
+  
+build.xml javadoc generation (pero)
+  
+  
+Update cluster etc/cluster-server.xml example (pero)
+  
+  
+Add cluster membership element docs to OACC (pero)
+  
   
 Initial port of Tomcat 5.5 cluster docs to OACC (rjung)
   


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






svn commit: r642534 - /tomcat/sandbox/tomcat-oacc/trunk/test/src/share/org/apache/catalina/cluster/tcp/DataSenderTest.java

2008-03-29 Thread pero
Author: pero
Date: Sat Mar 29 06:38:26 2008
New Revision: 642534

URL: http://svn.apache.org/viewvc?rev=642534&view=rev
Log:
remove debug println

Modified:

tomcat/sandbox/tomcat-oacc/trunk/test/src/share/org/apache/catalina/cluster/tcp/DataSenderTest.java

Modified: 
tomcat/sandbox/tomcat-oacc/trunk/test/src/share/org/apache/catalina/cluster/tcp/DataSenderTest.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-oacc/trunk/test/src/share/org/apache/catalina/cluster/tcp/DataSenderTest.java?rev=642534&r1=642533&r2=642534&view=diff
==
--- 
tomcat/sandbox/tomcat-oacc/trunk/test/src/share/org/apache/catalina/cluster/tcp/DataSenderTest.java
 (original)
+++ 
tomcat/sandbox/tomcat-oacc/trunk/test/src/share/org/apache/catalina/cluster/tcp/DataSenderTest.java
 Sat Mar 29 06:38:26 2008
@@ -410,7 +410,6 @@
  * @see java.net.Socket#getOutputStream()
  */
 public OutputStream getOutputStream() throws IOException {
-   System.out.println("getOutputString " + isWriteIOException());
 if(isWriteIOException()) {
 throw new IOException("MockSocket");
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r642542 - /tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java

2008-03-29 Thread markt
Author: markt
Date: Sat Mar 29 07:48:24 2008
New Revision: 642542

URL: http://svn.apache.org/viewvc?rev=642542&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=44529
No roles (deny all) trumps no auth-constraint (allow all)

Modified:
tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java

Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java?rev=642542&r1=642541&r2=642542&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java Sat Mar 29 
07:48:24 2008
@@ -776,17 +776,16 @@
 log.debug("No roles ");
 status = false; // No listed roles means no access at all
 denyfromall = true;
+break;
 } else {
 if(log.isDebugEnabled())
 log.debug("Passing all access");
-return (true);
+status = true;
 }
 } else if (principal == null) {
 if (log.isDebugEnabled())
 log.debug("  No user authenticated, cannot grant access");
-status = false;
-} else if(!denyfromall) {
-
+} else {
 for (int j = 0; j < roles.length; j++) {
 if (hasRole(principal, roles[j]))
 status = true;
@@ -796,7 +795,8 @@
 }
 }
 
-if (allRolesMode != AllRolesMode.STRICT_MODE && !status && principal 
!= null) {
+if (!denyfromall && allRolesMode != AllRolesMode.STRICT_MODE &&
+!status && principal != null) {
 if (log.isDebugEnabled()) {
 log.debug("Checking for all roles mode: " + allRolesMode);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r642543 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-29 Thread markt
Author: markt
Date: Sat Mar 29 07:49:45 2008
New Revision: 642543

URL: http://svn.apache.org/viewvc?rev=642543&view=rev
Log:
Propose fix.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=642543&r1=642542&r2=642543&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Mar 29 07:49:45 2008
@@ -106,3 +106,8 @@
   http://svn.apache.org/viewvc?rev=642391&view=rev
   +1: markt
   -1:
+
+* No roles (deny all) trumps no auth-constraint (allow all)
+  https://issues.apache.org/bugzilla/show_bug.cgi?id=44529
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r642544 - /tomcat/current/tc5.5.x/STATUS.txt

2008-03-29 Thread markt
Author: markt
Date: Sat Mar 29 07:49:57 2008
New Revision: 642544

URL: http://svn.apache.org/viewvc?rev=642544&view=rev
Log:
Propose patch

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=642544&r1=642543&r2=642544&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Sat Mar 29 07:49:57 2008
@@ -86,3 +86,8 @@
   http://people.apache.org/~markt/patches/2008-03-28-cgi-env.patch
   +1: markt
   -1:
+
+* No roles (deny all) trumps no auth-constraint (allow all)
+  https://issues.apache.org/bugzilla/show_bug.cgi?id=44529
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 44529] RealmBase authorization via hasResourcePermission not fully servlet spec compliant

2008-03-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44529





--- Comment #1 from Mark Thomas <[EMAIL PROTECTED]>  2008-03-29 07:48:48 PST ---
This has been fixed in trunk and proposed for 6.0.x and 5.5.x


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-29 Thread Mark Thomas

Rainer Jung wrote:
In your case the path is \sys:\..., and I think Mark wants to find out, 
where the leading backslash comes form.


Exactly.

The leading backslash might not be new in TC 4.1.37, but the 
implementation of the test for absolute paths changed a lot between ant 
1.5 and 1.7.


It did. It looks like we have been caught out by Ant getting stricter.

Mark: it is interesting in the stderr log, that the classpath for 
compilation contains items with and items without leading backslash. So 
the difference in code generating the first two items (WEB-INF/classes) 
and the other ones might give an idea.


Yeah - I saw that. I started by looking at the work directory and the test 
code I posted was extracted from key elements of that.


What I really want to do is debug my way through it. Fortunately Novell 
offer a 60-day demo of NetWare so I am just waiting for the install to 
finish - three cheers for Novell and VMWare :)


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 4.1.36 / .37 cant compile jsp on NetWare

2008-03-29 Thread Mark Thomas

Mark Thomas wrote:
What I really want to do is debug my way through it. Fortunately Novell 
offer a 60-day demo of NetWare so I am just waiting for the install to 
finish - three cheers for Novell and VMWare :)


Found it. Test case was slightly wrong. Try the test case below. You should 
see a difference between Windows and NetWare.


This does indeed look like a JVM bug that has been exposed by stricter 
checking in the newer versions of Ant.


Options for a work-around are:
- Try a later JVM. If the test case below works - you should be OK.
- Use an older version of Ant. Ant was upgraded to keep up to date rather 
than for a specific big fix so again, you should be OK.

- Patch Tomcat. You'll need to add a few getCanonicalPath() calls.

We could patch Tomcat but generally I am against patching to work around 
someone else's bug unless we absolutely have to.


As an aside, the Tomcat 4 install with NetWare 6.5 SP7 is a complete mess. 
There are multiple versions of the same libraries present and if you try 
enabling the http connector it fails with a NoSuchMethod exception. A 
little digging showed that the connector jars are from multiple versions of 
Tomcat 4 and are not compatible with each other.


If you do want to use Tomcat on NetWare then you will probably need to 
install a fresh version from Apache rather than trying to use the NetWare one.


Cheers,

Mark

package org.apache.markt;

import java.io.File;
import java.io.IOException;
import java.net.URL;

public class NetWareTest {

public static void main(String[] args) throws IOException {
File testDir1 = new File(".");
URL url = testDir1.toURL();
File testDir2 = new File(url.getFile());

System.out.println(testDir1.toString());
System.out.println(url.toString());
System.out.println(url.getFile().toString());
System.out.println(testDir2.toString());
}
}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 44679] Cookies are treated differently between 6.0. 16 and 6.0.14

2008-03-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44679





--- Comment #5 from David Lewis <[EMAIL PROTECTED]>  2008-03-29 22:13:51 PST ---
Bug 44705 has been listed as a duplicate of this bug - but I am unsure that
this is the case ... 

According the the specification for version 0 (or Netscape) cookies (reference:
http://wp.netscape.com/newsref/std/cookie_spec.html) - the NAME=VALUE portion
of a cookie "is a sequence of characters excluding semi-colon, comma and white
space". The issue that I have been experiencing with Tomcat 5.5.26 if the
cookie NAME name contains a colon (":"), the portion of the name that prefixes
the colon remains, but the value for the cookie is an empty string.

Simply put - colons are valid characters for version 0 and version 1 (RFC
2109/RFC 2965) cookies.

Below is a reproducible example of the problem. It is important to note that
the cookies are initially sent to the Web browser as version 1 cookies, however
when the browser send the cookies back to Tomcat when a request is made, they
only contain the NAME-VALUE component. Essentially, Tomcat has no way to
inherently "know" what version of cookie has been sent.

Tomcat 5.5.25 and earlier:
--
HTTP request contains header:
Cookie: JSESSIONID=87C7E668C6C15E2556C0977F6EAA9F4C; NFIS:profile=lang=en;
DACS:NFIS:NRCAN:dlewis=usjp1tigSqakP8BnWv

* When the HttpServletRequest.getCookies() is called, a Cookie[] is returned:
Cookie: name="JSESSIONID", value="J87C7E668C6C15E2556C0977F6EAA9F4C"
Cookie: name="NFIS:profile", value="lang:en"
Cookie: name="DACS:NFIS:NRCAN:dlewis", value="usjp1tigSqakP8BnWv"

Tomcat 5.5.26:
--
HTTP request contains header:
Cookie: JSESSIONID=87C7E668C6C15E2556C0977F6EAA9F4C; NFIS:profile=lang=en;
DACS:NFIS:NRCAN:dlewis=usjp1tigSqakP8BnWv

* When the HttpServletRequest.getCookies() is called, a Cookie[] is returned:
Cookie: name="JSESSIONID", value="J87C7E668C6C15E2556C0977F6EAA9F4C"
Cookie: name="NFIS", value=""
Cookie: name="DACS", value=""

This issue "breaks" many of the cookies that we use with our applications. The
only solution (for now) is to use Tomcat 5.5.25.

--- When is the next Tomcat 5.5.x slated for release?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]