DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 --- Comment #20 from Suzuki Yuichiro <[EMAIL PROTECTED]> 2008-03-22 09:04:52 PST --- Created an attachment (id=21700) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21700) test case for Reader buffering war for the test -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: renaming jar files
> > Speaking of deps - I'm completely confused by tomcat-dbcp.jar - it
> > seems to break the build ( 'download' ) with JDK1.6, yet I can't find
> >
>
> that's because DBCP implements interfaces, and only implements the
> java.sql/javax.sql up to JDK 1.5.
>
> > any usage in the code - and just removing it doesn't seem to hurt in
> > any way.
>
> it's being used, removing it would prolly upset some users, as the DBCP
> is the core for the tomcat connection pooling.
I did a grep - couldn't find any direct dep in the code, and removing
it from the 'download' and the copy in 'deploy' just worked. There is
only one ref in Constants, which is loaded with Class.forName() by the
naming code.
The dbcp build file actually handles jdk1.5/1.6 changes by doing some 'replace'.
Our build.download just download theirs, replaces the package name and
adds some more stuff.
I understand people using JDBC authenticator would miss the connection
pooling - but maybe they could download it separately ? Would't be
easier to just download the 'official' version ?
I'm also curious, assuming JDK1.5 is used to compile - would the
tomcat distro work in JDK1.6 if dbcp is compiled with 1.5 ?
In any case - it kind of sucks to not be able to build following the
instructions ( ant download, ant ) - I didn't find any ref that JDK1.6
is not supported for build.
Costin
>
> > Am I missing something - the jar name is referenced if few
> > places, and there is a class name in Constants. I assume some JDBC
> > connector stuff would not work so well unless someone install the
> > package.
> >
>
> > Costin
> >
> > On 3/20/08, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:
> >
> >> when the commons-logging jar files got updated, they also got renamed,
> >> we missed a few spots,
> >>
> >> some files in bin and conf still reference the old name, like
> >> catalina.policy
> >> // These permissions apply to the commons-logging API
> >> grant codeBase "file:${catalina.home}/bin/commons-logging-api.jar" {
> >> permission java.security.AllPermission;
> >> };
> >>
> >>
> >> Filip
> >>
> >> -
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >>
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
> >
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 Suzuki Yuichiro <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEEDINFO|ASSIGNED --- Comment #21 from Suzuki Yuichiro <[EMAIL PROTECTED]> 2008-03-22 09:54:44 PST --- (In reply to comment #16) I tested some cases with http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk at r639909 (that includes 639891) of course without my patch. I attached a WAR, that is not a practicable application, but for test. It includes multibyte UTF-8 characters, I'm worry about it might not work correctly in your environment. /index.jsp : using 3 bytes characters The results I tested: read(): expected 24587 Sometimes, more/less length occurs. read(char[1]): expected 8203 Sometimes, more/less length occurs. readLine(): expected 8203 Sometimes, more/less length occurs, or sometimes following exception occurs. java.io.IOException at org.apache.catalina.connector.InputBuffer.reset(InputBuffer.java:456) at org.apache.catalina.connector.CoyoteReader.reset(CoyoteReader.java:134) at org.apache.catalina.connector.CoyoteReader.readLine(CoyoteReader.java:191) at org.apache.jsp.readLine_jsp._jspService(readLine_jsp.java:60) ... That's very rare when the browser is on the same machine with tomcat. But if the browser is on another machine that occurs more easily. I just guess those behavior may depend on the internal buffer state and the buffer of SocketInputStream might be related. (the next data arrived or not?) These tests are passed with my patch in my environment. Does the attached patch (at least for tomcat6.x) not work? (In reply to comment #18) I have not tried yet. I think it is needed at least that the read(char[], int, int) method of underlying-wrapped BufferedReader work correctly. Which revision is suitable for the Filter? All of Tomcat6.0.16, Tomcat6.0.16+r631700(see Comment #4 1.), and r639891(above-mentioned) seems working incorrectly. Are they problems of my environment? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r640023 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Sat Mar 22 10:50:03 2008 New Revision: 640023 URL: http://svn.apache.org/viewvc?rev=640023&view=rev Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=640023&r1=640022&r2=640023&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Mar 22 10:50:03 2008 @@ -62,5 +62,5 @@ * Fix docs re use of maxActive http://svn.apache.org/viewvc?rev=639842&view=rev - +1: markt, fhanik + +1: markt, fhanik, rjung -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r640036 - in /tomcat/current: tc4.1.x/STATUS.txt tc5.5.x/STATUS.txt
Author: rjung Date: Sat Mar 22 11:15:29 2008 New Revision: 640036 URL: http://svn.apache.org/viewvc?rev=640036&view=rev Log: Vote. Modified: tomcat/current/tc4.1.x/STATUS.txt tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc4.1.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc4.1.x/STATUS.txt?rev=640036&r1=640035&r2=640036&view=diff == --- tomcat/current/tc4.1.x/STATUS.txt (original) +++ tomcat/current/tc4.1.x/STATUS.txt Sat Mar 22 11:15:29 2008 @@ -39,5 +39,6 @@ * Fix docs re use of maxActive http://svn.apache.org/viewvc?rev=639842&view=rev - +1: + +1: rjung -1: + rjung: Didn't check though, if this is actually true for the 4.1 bundled DBCP. Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=640036&r1=640035&r2=640036&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sat Mar 22 11:15:29 2008 @@ -62,7 +62,7 @@ * Fix minor HttpServlet bug. Use localised error message. http://svn.apache.org/viewvc?rev=635298&view=rev - +1: markt + +1: markt, rjung -1: * Add system properties docs @@ -72,10 +72,12 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44556 http://people.apache.org/~markt/patches/2008-03-10-bug44556.patch - +1: markt, fhanik + +1: markt, fhanik, rjung -1: + rjung: in realm-howto.xml: "Both of these are included with the Tomcat distribution." + This is not true, we only include the api file. * Fix docs re use of maxActive http://svn.apache.org/viewvc?rev=639842&view=rev - +1: + +1: rjung -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
