Re: svn commit: r634863 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-15 Thread Mark Thomas 

Filip Hanik - Dev Lists wrote:

actually, IE only supports quoting of the value for v0 cookies.
honestly, I wasn't up for the backwards compatible fix, but since it 
turns out that most folks use v0 cookies with v1 values, this is an evil 
must.


without the below fix, every single JSESSIONID cookie will not work on IE.


That's not good.

I've looked at this again and the real problem is that maybeQuote2() may 
change the cookie version but we only check the return value when calling 
maybeQuote2() for the value. We need to check the return value every time 
we call maybeQuote2(). I have an alternative patch which I'll add to the 
status file.


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r637441 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-15 Thread markt 
Author: markt
Date: Sat Mar 15 10:02:49 2008
New Revision: 637441

URL: http://svn.apache.org/viewvc?rev=637441&view=rev
Log:
Propose alternative patch

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=637441&r1=637440&r2=637441&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Mar 15 10:02:49 2008
@@ -113,9 +113,12 @@
 are in very uncertain territory for v0 cookies anyway and
 the chances are that something is going to break. I would
 rather keep the consistency of the quoting that might
-break a browser that have inconsistent handling of
+break a browser than have inconsistent handling of
 elements of the cookie header.
   -1:
+* As an alternative to the above patch, I propose:
+  http://people.apache.org/~markt/patches/2008-03-15-cookie-path.patch
+  +1: markt
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44562
   http://svn.apache.org/viewvc?rev=635294&view=rev (prior code clean up)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r637442 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-15 Thread markt 
Author: markt
Date: Sat Mar 15 10:03:34 2008
New Revision: 637442

URL: http://svn.apache.org/viewvc?rev=637442&view=rev
Log:
Vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=637442&r1=637441&r2=637442&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Mar 15 10:03:34 2008
@@ -102,7 +102,7 @@
  
  return cb.getLength();
 
-  +1 : remm
+  +1 : remm, markt
 
 * Cookie addition - due to how inconsistent browsers are we will only quote 
the value
   for v0 cookies.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r637453 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-15 Thread remm 
Author: remm
Date: Sat Mar 15 11:56:00 2008
New Revision: 637453

URL: http://svn.apache.org/viewvc?rev=637453&view=rev
Log:
- Votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=637453&r1=637452&r2=637453&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Mar 15 11:56:00 2008
@@ -116,9 +116,10 @@
 break a browser than have inconsistent handling of
 elements of the cookie header.
   -1:
+
 * As an alternative to the above patch, I propose:
   http://people.apache.org/~markt/patches/2008-03-15-cookie-path.patch
-  +1: markt
+  +1: markt, remm
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44562
   http://svn.apache.org/viewvc?rev=635294&view=rev (prior code clean up)
@@ -139,5 +140,5 @@
 * Add system property docs
   http://svn.apache.org/viewvc?rev=620335&view=rev
   
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?r1=627743&r2=627742&pathrev=627743
-  +1: markt
+  +1: markt, remm
   -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44611] New: DirContextURLConnection Header Bugs

2008-03-15 Thread bugzilla 
https://issues.apache.org/bugzilla/show_bug.cgi?id=44611

   Summary: DirContextURLConnection Header Bugs
   Product: Tomcat 6
   Version: unspecified
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Created an attachment (id=21673)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21673)
Fix DirContextURLConnection bugs.

DirContextURLConnection has bugs:
1) Does not implement the getHeaderFields() method
2) It's implementation of getHeaderField(String name) is case sensitive.
3) It returns an empty string "", rather than null, for header values which
don't exist.

This means that there is no way to know what header information Tomcat exposes
for a file, and calling getHeaderField("Content-Type") will return "", even
though there is an attribute stored as "content-type".

The attached patch should fix these bugs.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]