dev@tomcat.apache.org
Hi,
I see the following warning with following request "http://localhost:
8080/snoopy/snoopy.jsp?hello=xxx&&world=yyy"
Tomct 5.5.26
==
29.02.2008 13:49:29 org.apache.tomcat.util.http.Parameters
processParameters
WARNUNG: Parameters: Invalid chunk ignored.
===
Both parameter hello and world has the correct values, but every
request logs a warning. At high
traffic sites this anno user fault made admins really unhappy.
At RFC 1738 only the following BNF are reference:
http://tools.ietf.org/html/rfc1738
---
; HTTP
httpurl= "http://"; hostport [ "/" hpath [ "?" search ]]
hpath = hsegment *[ "/" hsegment ]
hsegment = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
search = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
search = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
-
The Wikipedia link ( http://en.wikipedia.org/wiki/Query_string)
is better, but not usefull as implementation reference note.
Why we report a warning ?
s. Parameters LL. 347
public void processParameters( byte bytes[], int start, int len,
String enc ) {
...
Ll 384
if( nameEnd<=nameStart ) {
log.warn("Parameters: Invalid chunk ignored.");
continue;
// invalid chunk - it's better to ignore
}
Regards
Peter
svn commit: r632388 - /tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
Author: jfclere
Date: Fri Feb 29 08:56:23 2008
New Revision: 632388
URL: http://svn.apache.org/viewvc?rev=632388&view=rev
Log:
cleaning.
Modified:
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
Modified:
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java?rev=632388&r1=632387&r2=632388&view=diff
==
---
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
(original)
+++
tomcat/connectors/trunk/jni/test/org/apache/tomcat/jni/SocketServerTestSuite.java
Fri Feb 29 08:56:23 2008
@@ -34,6 +34,9 @@
public class SocketServerTestSuite extends TestCase {
private long serverSock = 0;
+private int port=;
+private String host="localhost";
+
public static long serverPool = 0;
public void testSocketServerTestSuite() throws Exception {
@@ -43,8 +46,8 @@
/* Create the server socket and listen on it */
serverPool = Pool.create(0);
-long inetAddress = Address.info("127.0.0.1", Socket.APR_INET,
-, 0, serverPool);
+long inetAddress = Address.info(host, Socket.APR_INET,
+port, 0, serverPool);
serverSock = Socket.create(Socket.APR_INET, Socket.SOCK_STREAM,
Socket.APR_PROTO_TCP, serverPool);
int rc = Socket.bind(serverSock, inetAddress);
@@ -139,7 +142,7 @@
private class Client extends java.lang.Thread {
java.net.Socket sock;
public Client() throws Exception {
-sock = new java.net.Socket("localhost", );
+sock = new java.net.Socket(host, port);
}
public void run() {
try {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
dev@tomcat.apache.org
Peter Rossbach wrote: Hi, I see the following warning with following request "http://localhost:8080/snoopy/snoopy.jsp?hello=xxx&&world=yyy"; Tomct 5.5.26 == 29.02.2008 13:49:29 org.apache.tomcat.util.http.Parameters processParameters WARNUNG: Parameters: Invalid chunk ignored. === Both parameter hello and world has the correct values, but every request logs a warning. At high traffic sites this anno user fault made admins really unhappy. At RFC 1738 only the following BNF are reference: That RFC is out of date. You want RFC 3986. Neither RFC actually defines how a parameter string should be formatted. I did quite a bit of googling but the best reference I found was the JavaDoc in the servlet spec for HttpUtils.parseQueryString() which suggests your URL above does indeed have a suspect query string because of the double &&. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Bug 42950] ConcurrentModificationException on Shutdown
https://issues.apache.org/bugzilla/show_bug.cgi?id=42950 Diogo Quintela <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
dev@tomcat.apache.org
The HTML 4 spec requires a "name=value" pair between the &'s, by my reading. Not necessarily in every URL, but at least when a form is submitted via a GET request. ref. http://www.w3.org/TR/html4/interact/forms.html#h-17.13.3.4 That's the commonest way to create URL query strings but not the *only* way, so I think it's appropriate to log a warning but not an error for non-compliant URLs. -- Len On Fri, Feb 29, 2008 at 1:43 PM, Mark Thomas <[EMAIL PROTECTED]> wrote: > Peter Rossbach wrote: > > Hi, > > > > I see the following warning with following request > > "http://localhost:8080/snoopy/snoopy.jsp?hello=xxx&&world=yyy"; > > > > Tomct 5.5.26 > > > > == > > 29.02.2008 13:49:29 org.apache.tomcat.util.http.Parameters > > processParameters > > WARNUNG: Parameters: Invalid chunk ignored. > > === > > > > Both parameter hello and world has the correct values, but every request > > logs a warning. At high > > traffic sites this anno user fault made admins really unhappy. > > > > At RFC 1738 only the following BNF are reference: > > That RFC is out of date. You want RFC 3986. > > Neither RFC actually defines how a parameter string should be formatted. I > did quite a bit of googling but the best reference I found was the JavaDoc > in the servlet spec for HttpUtils.parseQueryString() which suggests your > URL above does indeed have a suspect query string because of the double &&. > > Mark > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
