svn commit: r631136 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-26 Thread jfclere 
Author: jfclere
Date: Tue Feb 26 00:52:57 2008
New Revision: 631136

URL: http://svn.apache.org/viewvc?rev=631136&view=rev
Log:
Cast my votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=631136&r1=631135&r2=631136&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 26 00:52:57 2008
@@ -74,7 +74,7 @@
 
 * Fix NPE when iterating through sessions for expiration
   http://svn.apache.org/viewvc?view=rev&revision=627689
-  +1: fhanik, markt, remm
+  +1: fhanik, markt, remm, jfclere
   -1:
   
 * Allow old style cookie values to work(auto switch to v1) (regression)
@@ -110,5 +110,5 @@
 * Update docs. Correct version number, paths and use of $CATALINA_HOME vs.
   $CATALINA_BASE
   http://svn.apache.org/viewvc?rev=630013&view=rev
-  +1: markt, fhanik
+  +1: markt, fhanik, jfclere
   -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44488] New: - JkMount global config doesn't work on mod_jk/1.2.26?

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=44488

   Summary: JkMount global config doesn't work on mod_jk/1.2.26?
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P1
 Component: Native:JK
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Once I used httpd-2.0.63 + mod_jk/1.2.25 + apache-tomcat-6.0.10, and this 
worked well. But when I upgraded mod_jk/1.2.25 to mod_jk/1.2.26, the problem 
was found. It seems that the JKMount global config doesn't work anymore. And I 
also can't access the "/jkmanager-status" page yet. Here are some 
configurations of my httpd.conf:
#

ServerAdmin [EMAIL PROTECTED]
ServerName localhost


# For working with tomcat
LoadModule jk_module modules/mod_jk.so
JkWorkersFile "conf/workers.properties"
JkLogFile "logs/mod_jk.log"
JkShmFile "logs/jk.shm"
JkLogStampFormat "[%a %b %d %H:%M:%S %Y]"
JkLogLevel error
JkMount /* loadbalancer

# Add the jkstatus mount point
JkMount /jkmanager-status/* jkstatus


JkMount jkstatus

#


And the workers.properties:
#
worker.list=loadbalancer, jkstatus

worker.t39.port=8009
worker.t39.host=192.168.0.39
worker.t39.type=ajp13
worker.t39.lbfactor=1
worker.t39.connection_pool_timeout=600
worker.t39.socket_keepalive=true
worker.t39.socket_timeout=30
worker.t39.connect_timeout=15000
worker.t39.prepost_timeout=1
worker.t39.reply_timeout=33

worker.loadbalancer.type=lb
worker.loadbalancer.balance_workers=t39 

#Define a 'jkstatus' worker using status
worker.jkstatus.type=status
#


Is this a bug of mod_jk/1.2.26? Can anyone help me? Thanks!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44488] - JkMount global config doesn't work on mod_jk/1.2.26?

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=44488


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Resolution||INVALID
 Status|NEW |RESOLVED




--- Additional Comments From [EMAIL PROTECTED]  2008-02-26 01:57 ---
Docs page

http://tomcat.apache.org/connectors-doc/reference/apache.html

says for JkMount: For inheritance rules, see: JkMountCopy.

JkMountCopy is explained as:

If this directive is set to "On" in some virtual server, the mounts from the
global server will be copied to the virtual server, more precisely all mounts
defined by JkMount or JkUnMount. The Mounts defined by JkMountFile and
JkAutoAlias will only be inherited, if the VirtualHost does not define it's own
JkMountFile or JkAutoAlias.
If you want all vhost to inherit mounts from the main server, you can set
JkMountCopy to 'All' in the main server.
This directive is only allowed inside VirtualHost (with value "On") and in the
global server (with value "All").
The default is Off. 

Those inheritance rules were always meant like that and for httpd 1.3 also
implemented like that. Dor httpd 2.x there were some gaps closed between 1.2.25
and 1.2.26.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28727] - CLOSE_WAIT connections draw 100 % cpu

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=28727





--- Additional Comments From [EMAIL PROTECTED]  2008-02-26 01:54 ---
also happens with debian:

Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_02-b05, mixed mode)
apache-tomcat-6.0.14
libapache-mod-jk 1.2.18-3etch1


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28727] - CLOSE_WAIT connections draw 100 % cpu

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=28727





--- Additional Comments From [EMAIL PROTECTED]  2008-02-26 02:49 ---
(In reply to comment #21)
> Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_02-b05, mixed mode)
> apache-tomcat-6.0.14
> libapache-mod-jk 1.2.18-3etch1

my fault. Works for me!

I am using apache httpclient class, which doesnt close sockets correctly. See
http://www.mail-archive.com/[EMAIL PROTECTED]/msg04338.html 



-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r631208 - /tomcat/connectors/trunk/jni/native/src/network.c

2008-02-26 Thread jfclere 
Author: jfclere
Date: Tue Feb 26 05:10:02 2008
New Revision: 631208

URL: http://svn.apache.org/viewvc?rev=631208&view=rev
Log:
Otherwise optGet will never work.

Modified:
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?rev=631208&r1=631207&r2=631208&view=diff
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Tue Feb 26 05:10:02 2008
@@ -1120,7 +1120,7 @@
 apr_int32_t on = 0;
 
 UNREFERENCED(o);
-if (s->sock)
+if (!s->sock)
 tcn_ThrowAPRException(e, APR_ENOTSOCK);
 else {
 TCN_THROW_IF_ERR((*s->net->opt_get)(s->opaque, (apr_int32_t)opt,



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Ajp connector giving error with Executor configuration. is this a bug?

2008-02-26 Thread nitin dubey 
Hi,

I tried configuring executor in tomcat 6.0.14 for AJP Connector like following:




While starting tomcat it gives this error.  Any problem with the configuration 
OR this is a bug?

Feb 26, 2008 1:42:36 PM org.apache.tomcat.util.digester.Digester startElement
SEVERE: Begin event threw exception
java.lang.NullPointerException
at 
org.apache.catalina.startup.ConnectorCreateRule._setExecutor(ConnectorCreateRule.java:61)
at 
org.apache.catalina.startup.ConnectorCreateRule.begin(ConnectorCreateRule.java:54)
at org.apache.tomcat.util.digester.Rule.begin(Rule.java:153)
at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1276)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:533)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:220)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:872)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1693)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242)
at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1562)
at org.apache.catalina.startup.Catalina.load(Catalina.java:504)
at org.apache.catalina.startup.Catalina.load(Catalina.java:538)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:412)
Feb 26, 2008 1:42:36 PM org.apache.catalina.startup.Catalina load
WARNING: Catalina.start using C:\java\apache-tomcat-6.0.14\conf\server.xml:
java.lang.NullPointerException
at 
org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2726)
at 
org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2752)
at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1279)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:533)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:220)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:872)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1693)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242)
at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1562)
at org.apache.catalina.startup.Catalina.load(Catalina.java:504)
at org.apache.catalina.startup.Catalina.load(Catalina.java:538)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:412)
Feb 26, 2008 1:42:36 PM org.apache.tomcat.util.digester.Digester startElement
SEVERE: Begin event threw exception
java.lang.NullPointerException
at 
org.apache.catalina.startup.ConnectorCreateRule._setExecutor(ConnectorCreateRule.java:61)
at 
org.apache.catalina.startup.ConnectorCreateRule.begin(ConnectorCreateRule.java:54)
at org.apache.tomcat.util.digester.Rule.begin(Rule.java:153)
at org.apache.tomcat.util.digester.Digester.startElement(Digester.

DO NOT REPLY [Bug 44294] - Support for EL functions with varargs

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=44294





--- Additional Comments From [EMAIL PROTECTED]  2008-02-26 05:42 ---
Created an attachment (id=21593)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21593&action=view)
FunctionMapperImpl.patch

java.lang.NullPointerException
at
org.apache.el.lang.FunctionMapperImpl.resolveFunction(FunctionMapperImpl.java:53)

at org.apache.el.parser.AstFunction.getValue(AstFunction.java:87)

alternative.patch revealed that FunctionMapperImpl doesn't quite comply with
the API

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r631212 - /tomcat/connectors/trunk/jni/native/src/network.c

2008-02-26 Thread jfclere 
Author: jfclere
Date: Tue Feb 26 05:46:57 2008
New Revision: 631212

URL: http://svn.apache.org/viewvc?rev=631212&view=rev
Log:
Don't exception when the JAVA code doesn't.

Modified:
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?rev=631212&r1=631211&r2=631212&view=diff
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Tue Feb 26 05:46:57 2008
@@ -1106,7 +1106,6 @@
 
 UNREFERENCED(o);
 if (!s->sock) {
-tcn_ThrowAPRException(e, APR_ENOTSOCK);
 return APR_ENOTSOCK;
 }
 else



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r631214 - /tomcat/connectors/trunk/jni/xdocs/miscellaneous/changelog.xml

2008-02-26 Thread jfclere 
Author: jfclere
Date: Tue Feb 26 05:49:58 2008
New Revision: 631214

URL: http://svn.apache.org/viewvc?rev=631214&view=rev
Log:
Update changelog according the 2 last changes.

Modified:
tomcat/connectors/trunk/jni/xdocs/miscellaneous/changelog.xml

Modified: tomcat/connectors/trunk/jni/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/xdocs/miscellaneous/changelog.xml?rev=631214&r1=631213&r2=631214&view=diff
==
--- tomcat/connectors/trunk/jni/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/connectors/trunk/jni/xdocs/miscellaneous/changelog.xml Tue Feb 26 
05:49:58 2008
@@ -36,6 +36,16 @@
   new documentation project for  Tomcat Native was started.
   
 
+
+
+  
+
+  Fix optGet that was always throwing exceptions. (jfclere)
+
+
+  Fix optSet don't throw exception as JAVA prototype doesn't. (jfclere)
+
+  
 
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Ajp connector giving error with Executor configuration. is this a bug?

2008-02-26 Thread Filip Hanik - Dev Lists 

please use the tomcat-user list for these kinds of questions.
executor is not a supported attribute for AJP connectors, since it 
doesn't make sense to have it


Filip

nitin dubey wrote:

Hi,

I tried configuring executor in tomcat 6.0.14 for AJP Connector like following:




While starting tomcat it gives this error.  Any problem with the configuration 
OR this is a bug?

Feb 26, 2008 1:42:36 PM org.apache.tomcat.util.digester.Digester startElement
SEVERE: Begin event threw exception
java.lang.NullPointerException
at 
org.apache.catalina.startup.ConnectorCreateRule._setExecutor(ConnectorCreateRule.java:61)
at 
org.apache.catalina.startup.ConnectorCreateRule.begin(ConnectorCreateRule.java:54)
at org.apache.tomcat.util.digester.Rule.begin(Rule.java:153)
at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1276)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:533)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:220)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:872)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1693)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242)
at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1562)
at org.apache.catalina.startup.Catalina.load(Catalina.java:504)
at org.apache.catalina.startup.Catalina.load(Catalina.java:538)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:412)
Feb 26, 2008 1:42:36 PM org.apache.catalina.startup.Catalina load
WARNING: Catalina.start using C:\java\apache-tomcat-6.0.14\conf\server.xml:
java.lang.NullPointerException
at 
org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2726)
at 
org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2752)
at org.apache.tomcat.util.digester.Digester.startElement(Digester.java:1279)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:533)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractXMLDocumentParser.emptyElement(AbstractXMLDocumentParser.java:220)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:872)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1693)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242)
at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1562)
at org.apache.catalina.startup.Catalina.load(Catalina.java:504)
at org.apache.catalina.startup.Catalina.load(Catalina.java:538)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:412)
Feb 26, 2008 1:42:36 PM org.apache.tomcat.util.digester.Digester startElement
SEVERE: Begin event threw exception
java.lang.NullPointerException
at 
org.apache.catalina.startup.ConnectorCreateRule._setExecutor(ConnectorCreateRule.java:61)
at 
org.apache.catalina.startup.

svn commit: r631315 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java

2008-02-26 Thread fhanik 
Author: fhanik
Date: Tue Feb 26 10:10:12 2008
New Revision: 631315

URL: http://svn.apache.org/viewvc?rev=631315&view=rev
Log:
no need to sync, the javadoc says it's thread safe

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java?rev=631315&r1=631314&r2=631315&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
 Tue Feb 26 10:10:12 2008
@@ -308,12 +308,10 @@
 int total = 0;
 if (channel instanceof DatagramChannel) {
 DatagramChannel dchannel = (DatagramChannel)channel;
-//were using a shared channel, it's not thread safe
-//TODO check optimization, one channel per thread
-synchronized (dchannel) {
-while ( total < command.length ) {
-total += dchannel.send(buf, udpaddr);
-}
+//were using a shared channel, document says its thread safe
+//TODO check optimization, one channel per thread?
+while ( total < command.length ) {
+total += dchannel.send(buf, udpaddr);
 }
 } else {
 while ( total < command.length ) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r631316 - /tomcat/trunk/webapps/docs/tribes/introduction.xml

2008-02-26 Thread fhanik 
Author: fhanik
Date: Tue Feb 26 10:10:50 2008
New Revision: 631316

URL: http://svn.apache.org/viewvc?rev=631316&view=rev
Log:
small doco update with the addition on the new features

Modified:
tomcat/trunk/webapps/docs/tribes/introduction.xml

Modified: tomcat/trunk/webapps/docs/tribes/introduction.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/tribes/introduction.xml?rev=631316&r1=631315&r2=631316&view=diff
==
--- tomcat/trunk/webapps/docs/tribes/introduction.xml (original)
+++ tomcat/trunk/webapps/docs/tribes/introduction.xml Tue Feb 26 10:10:50 2008
@@ -146,9 +146,11 @@
   
   
 Guaranteed Messaging
-In the default implementation of Tribes uses TCP for messaging. TCP 
already has guaranteed message delivery
+In the default implementation of Tribes uses TCP or UDP for messaging. TCP 
already has guaranteed message delivery
 and flow control built in. I believe that the performance of Java TCP, 
will outperform an implementation of
-Java/UDP/flow-control/message guarantee since the logic happens further 
down the stack.
+Java/UDP/flow-control/message guarantee since the logic happens further 
down the stack. UDP messaging has been added in for 
+sending messages over UDP instead of TCP when desired. The same guarantee 
scenarios as described below are still available 
+over UDP, however, when a UDP message is lost, it's considered failed.
 Tribes supports both non-blocking and blocking IO operations. The 
recommended setting is to use non blocking
 as it promotes better parallelism when sending and receiving messages. The 
blocking implementation is available
 for those platforms where NIO is still a trouble child.
@@ -260,7 +262,7 @@
 
 
   
-
+Tribes ships as a module with Tomcat, and is released as part of the 
Apache Tomcat release.  
   
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r631321 - in /tomcat/trunk/webapps/docs: changelog.xml tomcat-docs.xsl

2008-02-26 Thread fhanik 
Author: fhanik
Date: Tue Feb 26 10:21:27 2008
New Revision: 631321

URL: http://svn.apache.org/viewvc?rev=631321&view=rev
Log:
update to support  attribute

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/tomcat-docs.xsl

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=631321&r1=631320&r2=631321&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Feb 26 10:21:27 2008
@@ -32,11 +32,16 @@
   
 
 
-
+
   
  
   ExtendedAccessLogValve cs-uri not print empty querystring (pero)
   
+ 
+  
+  
+ 
+  Update changelog to support the  element 
(fhanik)
  
   
 

Modified: tomcat/trunk/webapps/docs/tomcat-docs.xsl
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/tomcat-docs.xsl?rev=631321&r1=631320&r2=631321&view=diff
==
--- tomcat/trunk/webapps/docs/tomcat-docs.xsl (original)
+++ tomcat/trunk/webapps/docs/tomcat-docs.xsl Tue Feb 26 10:21:27 2008
@@ -40,6 +40,7 @@
   
   
   http://issues.apache.org/bugzilla/show_bug.cgi?id='"/>
+  http://svn.apache.org/viewvc?view=rev&rev='"/>
 
   
   
@@ -435,6 +436,12 @@
   
   
   
+  
+  
+  
+  
+  
+  
   
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r631322 - /tomcat/trunk/webapps/docs/changelog.xml

2008-02-26 Thread fhanik 
Author: fhanik
Date: Tue Feb 26 10:21:56 2008
New Revision: 631322

URL: http://svn.apache.org/viewvc?rev=631322&view=rev
Log:
add rev number

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=631322&r1=631321&r2=631322&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Feb 26 10:21:56 2008
@@ -41,7 +41,7 @@
   
   
  
-  Update changelog to support the  element 
(fhanik)
+  631321Update changelog to support the  
element (fhanik)
  
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34222] - TagHandlerPool does not call release on pooled tags

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=34222


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Resolution|INVALID |
 Status|RESOLVED|REOPENED
 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-02-26 12:57 ---
How is this not a bug. The JSP Spec explicitly states that release should be 
called.

http://java.sun.com/products/jsp/tutorial/TagLibraries18.html#62842

The consumer of JSP should not expereince any difference whether pooling is
enabled or not.

If the pool size is N, it seems like the use of N+1 tag (in which case release
will be called) has a different behavior than the tags 1..N.

This could be a real problem a JSP serving requests for multiple users.

Please advise,

Thanks,
Talib Sharif
farecast.com
[EMAIL PROTECTED]

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34222] - TagHandlerPool does not call release on pooled tags

2008-02-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

https://issues.apache.org/bugzilla/show_bug.cgi?id=34222





--- Additional Comments From [EMAIL PROTECTED]  2008-02-26 13:06 ---
Yes, I still agree. I note that the link in the FAQ referred to in comment#1 
no longer exists.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Tomcat Wiki] Update of "FAQ/Miscellaneous" by markt

2008-02-26 Thread Apache Wiki 
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The following page has been changed by markt:
http://wiki.apache.org/tomcat/FAQ/Miscellaneous

The comment on the change is:
Add link that got lost on move to wiki

--
  
  '''Is tag pooling broken? It doesn't call release!'''
  
- It is not broken, your tag probably is. Many bug reports have been filed 
about this. Here is the bug report with all the gory details.
+ It is not broken, your tag probably is. Many bug reports have been filed 
about this. [https://issues.apache.org/bugzilla/show_bug.cgi?id=16001 Bug 
16001] has all the gory details.
  
  '''Why do I get {{{java.lang.IllegalStateException}}} ?'''
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 34222] TagHandlerPool does not call release on pooled tags

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=34222


Mark Thomas <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Comment #4 from Mark Thomas <[EMAIL PROTECTED]>  2008-02-26 15:02:50 ---
(In reply to comment #2)
> http://java.sun.com/products/jsp/tutorial/TagLibraries18.html#62842

Is NOT the spec.

I have fixed the link in the FAQ (comment #1) that goes into more detail.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

async close of comet requests

2008-02-26 Thread Filip Hanik - Dev Lists 

I've implemented a proper async close
http://people.apache.org/~fhanik/patches/comet-async-close.patch
for the NIO connector.

today, when someone calls CometEvent.close() it finishes out the 
request, but nothing happens until the connection actually times out, 
which could be forever. also, any new request, will most likely be 
discarded since the connection is in comet status.


unless anyone objects, I'll commit this to trunk towards the end of this 
week

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 34222] TagHandlerPool does not call release on pooled tags

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=34222





--- Comment #5 from Talib Sharif <[EMAIL PROTECTED]>  2008-02-26 15:25:16 ---
Thanks for the quick reply Mark,

Ok, it might not be part of the spec (I will have to go read what exactly the
spec says. It might turn out to be unclear on this part.). 

But as an implementation point of view don't you think this is problematic
anyway.  Meaning that whoever is writing the Tag and whoever is writing the JSP
needs to know whether pooling is turned on or not, and the tag will be have
differently.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 34222] TagHandlerPool does not call release on pooled tags

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=34222





--- Comment #6 from Adrian Riley <[EMAIL PROTECTED]>  2008-02-26 17:31:22 ---
Ok, I've reread Bug#16001 and the Tag Javadoc, which seems much clearer than I
remember from way back then, and withdraw what I said earlier. If a tag
instance can only be reused with the same attribute set then state can be reset
as required by doEndTag and/or doStartTag.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 34222] TagHandlerPool does not call release on pooled tags

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=34222





--- Comment #7 from Talib Sharif <[EMAIL PROTECTED]>  2008-02-26 18:16:52 ---
Thanks for linking that Bug.

I guess the idea is to never keep any state except for the attributes specified
and because of the fact that using different attribute combination will
guarantee a different instance, you can assume that those attributes will be
intialized.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 44494] New: Requests greater than 8k being truncated.

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=44494

   Summary: Requests greater than 8k being truncated.
   Product: Tomcat 5
   Version: Nightly Build
  Platform: Other
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:Coyote
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


After updating to Tomcat 5.5.26 from Tomcat 5.5.23 we appear to be having
trouble with requests, that are greater than 8k, being truncated with the
CoyoteRequest.getReader() method.

The following steps caused this issue to appear:
1. I constructed a post request from a jsp page which exceeded 8k in size.
2. In the corresponding servlet I call request.getReader() and pipe the
returned BufferedReader into a string.
3. Inspection of the string reveals that the content is  being truncated after
8k.
4. If I replace the request.getReader() method call with
request.getInputStream() no truncation occurs. Also, after reverting back to
Tomcat 5.5.23 and using the request.getReader() method no truncation occurs.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 44494] Requests greater than 8k being truncated.

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=44494


Filip Hanik <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #1 from Filip Hanik <[EMAIL PROTECTED]>  2008-02-26 21:00:48 ---
Bug Confirmed - regression in 6.0.x as well.

SEVERE: Servlet.service() for servlet jsp threw exception
java.lang.ArrayIndexOutOfBoundsException: 8192
at org.apache.tomcat.util.buf.CharChunk.substract(CharChunk.java:388)
at org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:368)
at
org.apache.catalina.connector.CoyoteReader.read(CoyoteReader.java:93)
at org.apache.jsp.upload_jsp._jspService(upload_jsp.java:83)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:337)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
at
org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:879)
at
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:719)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2080)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
at java.lang.Thread.run(Thread.java:595)


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Bug 44494] Requests greater than 8k being truncated.

2008-02-26 Thread bugzilla 
http://issues.apache.org/bugzilla/show_bug.cgi?id=44494


Filip Hanik <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]