Implementing wildcard hostnames or aliases

[Michael Wyraz]

Hi,

I was searching for a way to use wildcard host names in tomcat (e.g. 
*.myhost.com). With the current implementation it seems not to be 
possible. I found some ideas like using a valve at engine level which 
forwards to the correct hostname. The problem with this is that the 
servlets wouln'd see the original hostname then (correct me if I'm wrong 
with that).


So I'm looking for a way to implement this. Since tomcat is very 
modular, maybe it's just one component which needs to be replaced by a 
modified one. But I'm not a tomcat developer and so I have no idea where 
to start with that. So could you help with some ideas how I could 
implement this? I would do the implementation and send the results to 
the devel team.


Regards, Michael.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: tomcat native documentation

[Henri Gomez]

> Ok. /usr/local/lib is not so good because it needs root access to install.

Good point.

A system component (part of Tomcat), should be installed by an admin isn't it ?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Cookies are broken in 6.0.16?

[Filip Hanik - Dev Lists]

Sven Köhler wrote:

The difficulty here is that although '=' is the delimiter between NAME and
VALUE there is no need to encode it if it appears in the name or the value.
This causes some ambiguities when parsing a header of the form:
Set-Cookie: foo=bar=bartoo

Is the name 'foo' or 'foo=bar'? Is the value 'bar=bartoo' or 'bartoo'?

The changes to the cookie parsing mean the second '=' and any text beyond
it are now ignored.



!???

By instinct, i would have chosen the first = to split the string into
NAME and VALUE.

Why have you chosen the second = or maybe eben the last = occuring in
the cookie-string?

Actually, the spec doesn't disagree with chosing any of the = ...
But some users have supplied some reasonable arguments (base64 is
padding with =, etc.) to rather chose the first = over the other ones.
  

in that case, the user should use v1 cookies :)


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: tomcat native documentation

[jean-frederic clere]

Henri Gomez wrote:

Ok. /usr/local/lib is not so good because it needs root access to install.


Good point.

A system component (part of Tomcat), should be installed by an admin isn't it ?


In this case, should it be installed in the directory of the JVM 
installation? I think MINA uses it too.


Cheers

Jean-Frederic



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620720 - /tomcat/connectors/trunk/jni/xdocs/index.xml

[jfclere]

Author: jfclere
Date: Mon Feb 11 23:59:36 2008
New Revision: 620720

URL: http://svn.apache.org/viewvc?rev=620720&view=rev
Log:
Use $CATALINA_HOME and add apt-get and yum install suggestions.

Modified:
tomcat/connectors/trunk/jni/xdocs/index.xml

Modified: tomcat/connectors/trunk/jni/xdocs/index.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/xdocs/index.xml?rev=620720&r1=620719&r2=620720&view=diff
==
--- tomcat/connectors/trunk/jni/xdocs/index.xml (original)
+++ tomcat/connectors/trunk/jni/xdocs/index.xml Mon Feb 11 23:59:36 2008
@@ -67,6 +67,16 @@
 Java SE Development Kit (JDK)
   
 
+
+ In debian based Linux those dependencies could be installed by something 
like:
+  
+apt-get install libapr1.0-dev libssl-dev
+  
+ In rpm based Linux those dependencies could be installed by something 
like:
+  
+yum install apr-devel openssl-devel
+  
+
 
 
 
@@ -82,7 +92,7 @@
 ./configure --with-apr=$HOME/APR \
 --with-java-home=$JAVA_HOME \
 --with-ssl=$HOME/OPENSSL \
---prefix=$HOME/TCNATIVE
+--prefix=$CATALINA_HOME
 
 to create the includes and makefiles to be able to build tc-native.
 Where:
@@ -92,7 +102,7 @@
 installation. Any JDK should work but it is advisable to use the same
 JVM version the JVM you use with Tomcat.
 $HOME/OPENSSL is the path where OpenSSL is installed.
-$HOME/TCNATIVE is the path where the produced libraries will be 
installed.
+$CATALINA_HOME is the path where the produced libraries will be installed. 
Something like $HOME/apache-tomcat-6.0.16/
 
 The configure is able to guess most of OpenSSL standard installations.
 So most of the time the following will be enough:
@@ -100,14 +110,14 @@
 ./configure --with-apr=/usr/bin/apr-1-config \
 --with-java-home=/home/jfclere/JAVA/jdk1.5.0_09/ \
 --with-ssl=yes \
---prefix=/home/jfclere/TCNATIVE
+--prefix=$CATALINA_HOME
 
 
 To build the libraries and install them:
 
 make && make install
 
-The libraries will be found in /home/jfclere/TCNATIVE/lib 
+The libraries will be found in $CATALINA_HOME/lib
   
 
 
@@ -138,10 +148,10 @@
 
 
   
-   Edit the $CATALINA_BASE/bin/setenv.sh and add the path to the tc-native 
libraries to LD_LIBRARY_PATH.
+   Edit the $CATALINA_HOME/bin/setenv.sh and add the path to the tc-native 
libraries to LD_LIBRARY_PATH.
Something like:

-LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/jfclere/TCNATIVE/lib
+LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$CATALINA_HOME/lib
 export LD_LIBRARY_PATH

Start tomcat and check for the messages like this ones:
@@ -181,4 +191,4 @@
 
 
 
- 
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44397] New: - reloadable="false" being ignored

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44397

   Summary: reloadable="false"  being ignored
   Product: Tomcat 6
   Version: 6.0.14
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have Tomcat 6.0.14 installed and have created a context.xml in my
webapps/testApp/META-INF/context.xml




Inspite of the fact that i have explicitly set reloadable="false" anytime i
compile a jsp or java class Tomcat attempts to reload my context.

Is there any other way of disabling the automatic reloading of the context on
changes in the code base?

/sanjay

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: tomcat native documentation

[Henri Gomez]

> In this case, should it be installed in the directory of the JVM
> installation? I think MINA uses it too.

JVM directory may be problematic for those of us who switch between
JVM, ie IBM or Sun.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43925] - org.apache.jasper.runtime.BodyContentImpl causing huge memory allocations

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43925





--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 01:44 ---
Thanks very much, Remy.

> - I don't see where memory usage is bounded in the code (if it's not, you 
> should
> compare performance with the unbounded mode of Jasper, which will never
> reallocate anything); that's a problem

Perhaps you could help me here. The memory usage doesn't appear to be bounded in
the current implementation of BodyContentImpl which *always* appears to
reallocate exponentially-larger blocks (in the reAllocBuff method at the
bottom). I must be missing something, but am not sure what. I'm looking at the
head of 5.5, which is the version affected by this change.


> - The opportunity is the ability to share the buffer list per thread, so the
> CharBuffer.bufList should be ThreadLocal (and should be limited in
> size, which should solve item 1); as a configuration option, it could be a
> concurrent static structure, for use with thread intensive connectors

This would require CharBuffer objects to be pooled to be of use. At the moment
they aren't (and neither are BodyContentImpl objects, as far as I can see). If I
understand you correctly, this would have the undesirable effect of holding onto
blocks of memory once allocated rather than making them available for garbage
collection. This would certainly require a bounded memory pool approach, but its
debatable whether that would be preferable. It would certainly be a bigger 
change.

> - CharBuffer.toArray is expensive (no other option, though), so you should try
> to show a (real) test result

I will put together a suitable test case for this. Is there a set of test cases
for the current implementation? If so I could just add new ones to it.


Regards
Brian

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33774] - JNDIRealm fails when server disconnects after time

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33774


[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version|Linux   |Solaris
Version|5.0.30  |5.5.20




--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 02:14 ---
(In reply to comment #12)
> (In reply to comment #11)
> > This is NOT fixed on a Solaris platform in 5.5.25 although 5.5.17 works ok 
on 
> > Windows XP. See below
> That it works on an earlier release on XP and fails on a later release on
> Solaris is a strong indication of a configuration problem on Solaris. That 
said,
> there was a minor improvement to the fix in 5.5.26. I don't think it will help
> but it is worth trying.
> If you still have problems, please use the users list in the first instance as
> this looks like a configuration issue.

No response from users list. Its just this first time delay after the remote 
server has closed the connection thats the pain.  (it eventually authenticates 
ok once the timeout has expired). Which is this timeout? Can't find what 
configuration to look at ( server.xml 's match on both platforms ). 

Some pointers much appreciated. 


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Cookies are broken in 6.0.16?

[Sven Köhler]

Actually, the spec doesn't disagree with chosing any of the = ...
But some users have supplied some reasonable arguments (base64 is
padding with =, etc.) to rather chose the first = over the other ones.
  

in that case, the user should use v1 cookies :)


Yes, right, you're 100% right - but this thread is not about v1 cookies. 
It's about v0 cookies.


In the case of v0 cookies, we hit the "damn, the spec is messed up - 
what should we do?"-case. And in this case, well - what do we do?


What would REALLY be best, is to throw exception upon setting a name or 
a value containg the = sign, or spaces, or any illegal characters of 
that kind.
Soon, after some future versions of Tomcat, the mailinglist may actually 
experience, that people start using names containg the = character, 
because chosing the last = character in the cookie for splitting permits 
them to do so.


Well, simply make things REALLY safe (throwing exception and the like - 
well, does the servlet spec allow to do so? oh my god - i can see it 
coming: it doesn't.) Or rather try to immitate the old behaviour as good 
as you can without violating the spec, or the TCK test, etc.
And it seems to be the case, that people don't use names containg the = 
character but rather use values that do which was possible with the old 
behaviour - and indeed seems to me to be the use-case used much more 
often then the "name contains =" use-case.


So if satisfying users really matters to you, you developers really have 
the choice, since the spec gives you that freedom, you really should ...




signature.asc
Description: OpenPGP digital signature

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

[jean-frederic clere]

Tim Funk wrote:
Not sure if I understand the question, the problem is our use of 
digester. We had 2 listener rules being created and each called 
addListener. So when an a  was found  - it was being processed 
twice.


Yes. My idea was to prevent add twice the same rule in Digester 
additionally to the actual fix.


Cheers

Jean-Frederic




(Or was I missing something?)

-Tim

jean-frederic clere wrote:

[EMAIL PROTECTED] wrote:

Author: funkman
Date: Tue Feb 12 08:27:45 2008
New Revision: 620848

URL: http://svn.apache.org/viewvc?rev=620848&view=rev
Log:
addition of dupl listener removal and a vote


Won't it be possible to prevent the addition in the Digester instead?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44399] New: - Allow ICY response upon receiving icy-metadata header

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44399

   Summary: Allow ICY response upon receiving icy-metadata header
   Product: Tomcat 5
   Version: 5.5.25
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Connector:HTTP
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Currently, the Http11Connector always responds with HTTP protocol. For
supporting streaming to media players using ICY shoutcast protocol it would be
good when the protocol of the response could be set to ICY when the request
header from the media player contains 'Icy-MetaData'.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

[Tim Funk]

In that case - that would revert the functionality which caused the 
issue to arrive in the first place.


The original bug had a problem because they had the same listener class 
declared multiple times and it was only being fired once. The fix was to 
log a duplicate listener message on the user config error.


It turns out that WebRuleSet was also adding the same item twice. 
(accidently)  and so the duplicate message was being.


So if the digester rules are changed to ignore dups - the original bug 
fix would then be invalid and the user would again silently wonder why 
only one instance is being used.




-Tim

jean-frederic clere wrote:

Tim Funk wrote:
Not sure if I understand the question, the problem is our use of 
digester. We had 2 listener rules being created and each called 
addListener. So when an a  was found  - it was being 
processed twice.


Yes. My idea was to prevent add twice the same rule in Digester 
additionally to the actual fix.




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44397] - reloadable="false" being ignored

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44397





--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 21:17 ---
Regarding the unsupported attributes:
Based on the 6.0 docs debug and distributable are not listed.

I was testing the session replication and had originally got the distributable
attribute from this post:

http://tomcat.apache.org/tomcat-5.5-doc/cluster-howto.html
# Make sure your web.xml has the  element or set at your


The debug="5" attribute I am not sure where that came from. I have removed it.

Regarding reproducing the context reload.

On my installation I am able to reproduce it 100% as follows.

a) Do a build and start Tomcat and open your web browser to the app
b) While Tomcat is running Edit the WEB-INF/web.xml and save it
c) At this point Tomcat immediately starts a reload of the context

/sanjay

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44397] - reloadable="false" being ignored

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44397


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 14:20 ---
There is a difference between re-compiling a JSP and re-loading a context. I
can't reproduce what you are seeing.

Also, you need to read the docs for the context element. 50% of the attributes
you have defined don't exist or are not valid in a context.xml file. See
http://tomcat.apache.org/tomcat-6.0-doc/config/context.html

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44398] - setclasspath

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44398


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 13:59 ---
setclasspath.sh/setclasspath.bat have supported the use JAVA_HOME or JRE_HOME
since 6.0.0

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627110 - /tomcat/current/tc5.5.x/STATUS.txt

[pero]

Author: pero
Date: Tue Feb 12 13:07:41 2008
New Revision: 627110

URL: http://svn.apache.org/viewvc?rev=627110&view=rev
Log:
Backport duplicate listener additions

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=627110&r1=627109&r2=627110&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Tue Feb 12 13:07:41 2008
@@ -29,4 +29,10 @@
   Do call to getClassLoader() in a privileged block.
   http://svn.apache.org/viewvc?rev=616953&view=rev (less the generics stuff)
   +1: markt
-  -1:
\ No newline at end of file
+  -1:
+
+* Remove duplicate listner additions (backport from 6.0 trunk)
+  http://svn.apache.org/viewvc?rev=620844&view=rev
+  +1: pero
+  -1: 
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627079 - /tomcat/tc6.0.x/trunk/STATUS.txt

[jfclere]

Author: jfclere
Date: Tue Feb 12 12:24:06 2008
New Revision: 627079

URL: http://svn.apache.org/viewvc?rev=627079&view=rev
Log:
Cast my vote.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=627079&r1=627078&r2=627079&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 12:24:06 2008
@@ -93,6 +93,6 @@
 
 * Remove duplicate listner additions
   http://svn.apache.org/viewvc?rev=620844&view=rev
-  +1: funkman, pero
+  +1: funkman, pero, jfclere
   -1: 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627069 - /tomcat/container/branches/tc4.1.x/build.properties.default

[markt]

Author: markt
Date: Tue Feb 12 12:05:54 2008
New Revision: 627069

URL: http://svn.apache.org/viewvc?rev=627069&view=rev
Log:
Update version

Modified:
tomcat/container/branches/tc4.1.x/build.properties.default

Modified: tomcat/container/branches/tc4.1.x/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/container/branches/tc4.1.x/build.properties.default?rev=627069&r1=627068&r2=627069&view=diff
==
--- tomcat/container/branches/tc4.1.x/build.properties.default (original)
+++ tomcat/container/branches/tc4.1.x/build.properties.default Tue Feb 12 
12:05:54 2008
@@ -28,7 +28,7 @@
 #flags.hide=on
 
 #Version number
-version=4.1.37
+version=4.1.38
 
 #Proxy to download subproject
 #proxy.host=proxy.domain



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627068 - /tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_37/

[markt]

Author: markt
Date: Tue Feb 12 12:04:51 2008
New Revision: 627068

URL: http://svn.apache.org/viewvc?rev=627068&view=rev
Log:
Tagging 4.1.37

Added:
tomcat/servletapi/tags/servlet2.3-jsp1.2-tc4.x/TOMCAT_4_1_37/
  - copied from r627067, tomcat/servletapi/branches/servlet2.3-jsp1.2-tc4.x/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627067 - /tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_37/

[markt]

Author: markt
Date: Tue Feb 12 12:04:40 2008
New Revision: 627067

URL: http://svn.apache.org/viewvc?rev=627067&view=rev
Log:
Tagging 4.1.37

Added:
tomcat/jasper/tags/tc4.1.x/TOMCAT_4_1_37/
  - copied from r627066, tomcat/jasper/branches/tc4.1.x/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627066 - /tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_37/

[markt]

Author: markt
Date: Tue Feb 12 12:04:31 2008
New Revision: 627066

URL: http://svn.apache.org/viewvc?rev=627066&view=rev
Log:
Tagging 4.1.37

Added:
tomcat/connectors/tags/tc4.1.x/TOMCAT_4_1_37/
  - copied from r627065, tomcat/connectors/trunk/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r627065 - /tomcat/container/tags/tc4.1.x/TOMCAT_4_1_37/

[markt]

Author: markt
Date: Tue Feb 12 12:04:22 2008
New Revision: 627065

URL: http://svn.apache.org/viewvc?rev=627065&view=rev
Log:
Tagging 4.1.37

Added:
tomcat/container/tags/tc4.1.x/TOMCAT_4_1_37/
  - copied from r627064, tomcat/container/branches/tc4.1.x/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

[Peter Rossbach]

Hi Tim,

+1

WebRuleSet  LL 250

 digester.addCallMethod(prefix + "web-app/listener/listener- 
class",

"addApplicationListener", 0);

digester.addRule(prefix + "web-app/jsp-config",
 jspConfig);

digester.addCallMethod(prefix + "web-app/jsp-config/jsp- 
property-group/url-pattern",

   "addJspMapping", 0);

# Remove this...
digester.addCallMethod(prefix + "web-app/listener/listener- 
class",

   "addApplicationListener", 0);


We must also change this at tomcat 5.x.x code base (LL 240)

Peter



Am 12.02.2008 um 19:44 schrieb Tim Funk:

Not sure if I understand the question, the problem is our use of  
digester. We had 2 listener rules being created and each called  
addListener. So when an a  was found  - it was being  
processed twice.



(Or was I missing something?)

-Tim

jean-frederic clere wrote:

[EMAIL PROTECTED] wrote:

Author: funkman
Date: Tue Feb 12 08:27:45 2008
New Revision: 620848

URL: http://svn.apache.org/viewvc?rev=620848&view=rev
Log:
addition of dupl listener removal and a vote

Won't it be possible to prevent the addition in the Digester instead?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

[Tim Funk]

Not sure if I understand the question, the problem is our use of 
digester. We had 2 listener rules being created and each called 
addListener. So when an a  was found  - it was being processed 
twice.



(Or was I missing something?)

-Tim

jean-frederic clere wrote:

[EMAIL PROTECTED] wrote:

Author: funkman
Date: Tue Feb 12 08:27:45 2008
New Revision: 620848

URL: http://svn.apache.org/viewvc?rev=620848&view=rev
Log:
addition of dupl listener removal and a vote


Won't it be possible to prevent the addition in the Digester instead?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44399] - Allow ICY response upon receiving icy-metadata header

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44399





--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 12:38 ---
Created an attachment (id=21512)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21512&action=view)
extended Http11Processor functionality

Http11Processor contains flag which is set to true when icy-metadata is in
request headers. When icy is true, InternalOutputBuffer is called with
sendIcyStatus; otherwise it is called with sendStatus by the processor.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

[jean-frederic clere]

[EMAIL PROTECTED] wrote:

Author: funkman
Date: Tue Feb 12 08:27:45 2008
New Revision: 620848

URL: http://svn.apache.org/viewvc?rev=620848&view=rev
Log:
addition of dupl listener removal and a vote


Won't it be possible to prevent the addition in the Digester instead?

Cheers

Jean-Frederic





Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620848&r1=620847&r2=620848&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 08:27:45 2008
@@ -88,5 +88,11 @@
 
 * ExtendedAccessLogValve cs-uri not print empty querystring

   http://svn.apache.org/viewvc?rev=620778&view=rev
-  +1: pero
+  +1: pero,funkman
+
+
+* Remove duplicate listner additions
+  http://svn.apache.org/viewvc?rev=620844&view=rev
+  +1: funkman
   -1: 
+




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620853 - /tomcat/tc6.0.x/trunk/STATUS.txt

[pero]

Author: pero
Date: Tue Feb 12 08:34:06 2008
New Revision: 620853

URL: http://svn.apache.org/viewvc?rev=620853&view=rev
Log:
Cast my vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620853&r1=620852&r2=620853&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 08:34:06 2008
@@ -93,6 +93,6 @@
 
 * Remove duplicate listner additions
   http://svn.apache.org/viewvc?rev=620844&view=rev
-  +1: funkman
+  +1: funkman, pero
   -1: 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt

[funkman]

Author: funkman
Date: Tue Feb 12 08:27:45 2008
New Revision: 620848

URL: http://svn.apache.org/viewvc?rev=620848&view=rev
Log:
addition of dupl listener removal and a vote


Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620848&r1=620847&r2=620848&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 08:27:45 2008
@@ -88,5 +88,11 @@
 
 * ExtendedAccessLogValve cs-uri not print empty querystring
   http://svn.apache.org/viewvc?rev=620778&view=rev
-  +1: pero
+  +1: pero,funkman
+
+
+* Remove duplicate listner additions
+  http://svn.apache.org/viewvc?rev=620844&view=rev
+  +1: funkman
   -1: 
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Heads up: Bayeux contribution

[Filip Hanik - Dev Lists]

status update, we're just waiting for the API update to have a 
shared/common server side API before we make the proposals


Filip

Filip Hanik - Dev Lists wrote:

Niall Pemberton wrote:

On Feb 5, 2008 2:06 PM, jean-frederic clere <[EMAIL PROTECTED]> wrote:
 

Yoav Shapira wrote:
   

On Feb 5, 2008 3:26 AM, jean-frederic clere <[EMAIL PROTECTED]> wrote:
 

The normal way is to go through the incubator process.


Why?  This is not a new project, Guy is not becoming a committer yet.
This is a code contribution from a committer and a volunteer.  It's
not different in spirit than a small new feature enhancement posted to
Bugzilla.  All we need is the iCLA from the volunteer and the code the
be posted to our public issue tracking system as a contribution.
  

It is just I thing it is too big for that.



Theres a "short form" incubator process for code donations - AIUI you
just vote to accept the donation, fill in the form and then your good
to go - details here:

http://incubator.apache.org/ip-clearance/index.html
  

yes, that would be the way to do it. I'll put it up for a vote

Filip

Niall

 

Cheers

Jean-Frederic


   

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620847 - /tomcat/trunk/PROPOSALS.txt

[fhanik]

Author: fhanik
Date: Tue Feb 12 08:25:49 2008
New Revision: 620847

URL: http://svn.apache.org/viewvc?rev=620847&view=rev
Log:
some more ideas

Modified:
tomcat/trunk/PROPOSALS.txt

Modified: tomcat/trunk/PROPOSALS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/PROPOSALS.txt?rev=620847&r1=620846&r2=620847&view=diff
==
--- tomcat/trunk/PROPOSALS.txt (original)
+++ tomcat/trunk/PROPOSALS.txt Tue Feb 12 08:25:49 2008
@@ -44,6 +44,7 @@
  - periodic ack, time or message count
  - support multicast fire and forget
  - autoswitch TCP/UDP based on size, number of recipients, or on message flag
+ - add in versioning to the message structure
 
 Priority Messaging
  - Being able to send through high priority messages through a channel
@@ -64,4 +65,9 @@
 ===
  - Remove usage of "synchronized" (previously used for JDK 1.4 compatibility)
  - make JDK 1.5 minimum version
- - take advantage of java.util.concurrent
\ No newline at end of file
+ - take advantage of java.util.concurrent
+ 
+Membership
+==
+ - implement payloadChange(...) event on membership listener
+ 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620844 - /tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java

[funkman]

Author: funkman
Date: Tue Feb 12 08:22:19 2008
New Revision: 620844

URL: http://svn.apache.org/viewvc?rev=620844&view=rev
Log:
Only add the listener once (to prevent the dup message from accidently 
appearing)

related to http://issues.apache.org/bugzilla/show_bug.cgi?id=44268


Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java?rev=620844&r1=620843&r2=620844&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java Tue Feb 12 
08:22:19 2008
@@ -204,9 +204,6 @@
 digester.addCallMethod(prefix + 
"web-app/jsp-config/jsp-property-group/url-pattern",
"addJspMapping", 0);
 
-digester.addCallMethod(prefix + "web-app/listener/listener-class",
-   "addApplicationListener", 0);
-
 digester.addRule(prefix + "web-app/login-config",
  loginConfig);
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44337] - Dir listing crashes if no readme-file present

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2008-02-12 08:17 ---
applied to version 6.0.17+

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Cookies are broken in 6.0.16?

[George Sexton]

Sven Köhler wrote:
And it seems to be the case, that people don't use names containg the = 
character but rather use values that do which was possible with the old 
behaviour - and indeed seems to me to be the use-case used much more 
often then the "name contains =" use-case.


I got bit on this once. My app was using = in the value. Worked great 
under Tomcat 5, but under 4.0 (I think) it didn't work. I ended up 
forcing my cookie types to v1.



--
George Sexton
MH Software, Inc.
Voice: +1 303 438 9585
URL:   http://www.mhsoftware.com/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620835 - /tomcat/trunk/PROPOSALS.txt

[fhanik]

Author: fhanik
Date: Tue Feb 12 08:02:28 2008
New Revision: 620835

URL: http://svn.apache.org/viewvc?rev=620835&view=rev
Log:
improvements to tribes

Modified:
tomcat/trunk/PROPOSALS.txt

Modified: tomcat/trunk/PROPOSALS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/PROPOSALS.txt?rev=620835&r1=620834&r2=620835&view=diff
==
--- tomcat/trunk/PROPOSALS.txt (original)
+++ tomcat/trunk/PROPOSALS.txt Tue Feb 12 08:02:28 2008
@@ -32,3 +32,36 @@
   svn revision or other reference
   +1: 
   -1:
+
+
+* catalina-tribes.jar improvements
+Messaging
+=
+Add in support for UDP messages
+ - fire and forget
+ - ack on message
+ - ack on batch of messages
+ - periodic ack, time or message count
+ - support multicast fire and forget
+ - autoswitch TCP/UDP based on size, number of recipients, or on message flag
+
+Priority Messaging
+ - Being able to send through high priority messages through a channel
+   pause existing messages
+
+Failure Detection
+=
+Improvements to the current failure detector
+ - NIO based
+ - avoid multiple member failed messages, keep a lock on a recipient basis
+ - different levels of failure check (accept, send/receive ack)
+Networking
+==
+Add in support to leverage multiple network cards in parallel (research 
+if any OS features are available to leverage this)
+
+Performance/Concurrency
+===
+ - Remove usage of "synchronized" (previously used for JDK 1.4 compatibility)
+ - make JDK 1.5 minimum version
+ - take advantage of java.util.concurrent
\ No newline at end of file



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44398] New: - setclasspath

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44398

   Summary: setclasspath
   Product: Tomcat 6
   Version: unspecified
  Platform: Other
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:Integration
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In the RELEASE-NOTES file: tomcat6 no longer need jdk but jre
===
Dependency Changes:
===
Tomcat 6.0 is designed to run on JSE 5.0 and later.

In addition, Tomcat 6.0 uses the Eclipse JDT Java compiler for compiling
JSP pages.  This means you no longer need to have the complete
Java Development Kit (JDK) to run Tomcat, but a Java Runtime Environment
(JRE) is sufficient.  The Eclipse JDT Java compiler is bundled with the 
binary Tomcat distributions.  Tomcat can also be configured to use the
compiler from the JDK to compile JSPs, or any other Java compiler supported 
by Apache Ant.


In setclasspath.sh/setclasspath.bat check JDK but JRE.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Implementing wildcard hostnames or aliases

[Michael Wyraz]

Hi Pid,
Is there a reason why you can't exploit the defaultHost attribute of 
the Engine element in server.xml?


Using the default host would result in that I can do that wildcard 
mapping only for one host. Additionally also any other host that maps to 
any if der server's IPs and even the IPs itself would be mapped to the 
default domain.


Currently I'm running a workaround with 
apache+mod_rewrite+mod_proxy+mod_header: I set the "host" to one host 
that is mapped in tomcat. Then I set an extra header which contains 
original host.  My Servlet checks if that header exists and uses this 
instead of the host header. Not a fine solution but it works for the moment.


regards,
Michael.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Measures against Session Fixation

[Christoph Lenggenhager]

Hi,

I was discussing the problem of session fixation [1] on the
tomcat-users list [2] and thought that it would be interesting to hear
an opinion of a developer on that subject.

Basically, I'd like to know what you think about a feature request/bug
report that the tomcat container should take care of session fixation
by automatically renew the session (or at least its id) upon a
successful login.

Unfortunately, the possibilities to hook into the login process (e.g.
when using form-based login) are rather limited.
When providing an own realm implementation, it is not possible to gain
access to the current session AFAIK.

What is left (and what I have done): Come up with an own valve
implementation that tries to fix the problem. However, this seems a
rather clumsy way to fight the problem.

If you think a request would be a bad idea, how would you fight the problem?

Thanks.

kind regards,
christoph


[1]: http://www.owasp.org/index.php/Session_Fixation
[2]: http://mail-archives.apache.org/mod_mbox/tomcat-users/200802.mbox/[EMAIL 
PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620821 - /tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java

[fhanik]

Author: fhanik
Date: Tue Feb 12 07:03:29 2008
New Revision: 620821

URL: http://svn.apache.org/viewvc?rev=620821&view=rev
Log:
remove not needed synchronization

Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java

Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java?rev=620821&r1=620820&r2=620821&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java Tue Feb 12 
07:03:29 2008
@@ -25,6 +25,7 @@
 import java.io.ObjectOutputStream;
 import java.io.Serializable;
 import java.nio.ByteBuffer;
+import java.util.concurrent.atomic.AtomicInteger;
 
 /**
  * The XByteBuffer provides a dual functionality.
@@ -562,10 +563,10 @@
 throws IOException, ClassNotFoundException, ClassCastException {
 return deserialize(data,offset,length,null); 
 }
-public static int invokecount = 0;
+public static AtomicInteger invokecount = new AtomicInteger(0);
 public static Serializable deserialize(byte[] data, int offset, int 
length, ClassLoader[] cls) 
 throws IOException, ClassNotFoundException, ClassCastException {
-synchronized (XByteBuffer.class) { invokecount++;}
+invokecount.addAndGet(1);
 Object message = null;
 if ( cls == null ) cls = new ClassLoader[0];
 if (data != null) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620845 - in /tomcat/trunk/java/org/apache/catalina: Server.java core/StandardServer.java startup/Catalina.java

[jfclere]

Author: jfclere
Date: Tue Feb 12 08:22:58 2008
New Revision: 620845

URL: http://svn.apache.org/viewvc?rev=620845&view=rev
Log:
Allow to run the shutdown on another IP that localhost.

Modified:
tomcat/trunk/java/org/apache/catalina/Server.java
tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

Modified: tomcat/trunk/java/org/apache/catalina/Server.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Server.java?rev=620845&r1=620844&r2=620845&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Server.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Server.java Tue Feb 12 08:22:58 2008
@@ -89,6 +89,20 @@
 
 
 /**
+ * Return the address on which we listen to for shutdown commands.
+ */
+public String getAddress();
+
+
+/**
+ * Set the address on which we listen to for shutdown commands.
+ *
+ * @param address The new address
+ */
+public void setAddress(String address);
+
+
+/**
  * Return the shutdown command string we are waiting for.
  */
 public String getShutdown();

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardServer.java?rev=620845&r1=620844&r2=620845&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardServer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardServer.java Tue Feb 12 
08:22:58 2008
@@ -137,6 +137,11 @@
  */
 private int port = 8005;
 
+/**
+ * The address on which we wait for shutdown commands.
+ */
+private String address = "127.0.0.1";
+
 
 /**
  * A random number generator that is only used if
@@ -281,6 +286,27 @@
 
 
 /**
+ * Return the address on which we listen to for shutdown commands.
+ */
+public String getAddress() {
+
+return (this.address);
+
+}
+
+
+/**
+ * Set the address on which we listen to for shutdown commands.
+ *
+ * @param address The new address
+ */
+public void setAddress(String address) {
+
+this.address = address;
+
+}
+
+/**
  * Return the shutdown command string we are waiting for.
  */
 public String getShutdown() {
@@ -372,9 +398,10 @@
 try {
 serverSocket =
 new ServerSocket(port, 1,
- InetAddress.getByName("127.0.0.1"));
+ InetAddress.getByName(address));
 } catch (IOException e) {
 log.error("StandardServer.await: create[" + port
+   + ":" + address
+ "]: ", e);
 System.exit(1);
 }

Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Catalina.java?rev=620845&r1=620844&r2=620845&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Catalina.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Tue Feb 12 
08:22:58 2008
@@ -416,7 +416,7 @@
 
 // Stop the existing server
 try {
-Socket socket = new Socket("127.0.0.1", server.getPort());
+Socket socket = new Socket(server.getAddress(), server.getPort());
 OutputStream stream = socket.getOutputStream();
 String shutdown = server.getShutdown();
 for (int i = 0; i < shutdown.length(); i++)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620842 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

[funkman]

Author: funkman
Date: Tue Feb 12 08:13:54 2008
New Revision: 620842

URL: http://svn.apache.org/viewvc?rev=620842&view=rev
Log:
 Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44337
 Dir listing crashes if no readme-file present


Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620842&r1=620841&r2=620842&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 08:13:54 2008
@@ -70,12 +70,6 @@
   +0: remm: do we really want to fix these sort of "bugs" ?
   -1:
 
-* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44337
-  Dir listing crashes if no readme-file present
-  http://svn.apache.org/viewvc?rev=618150&view=rev
-  +1: funkman, markt, fhanik, pero
-  -1:
-
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43741
   Correctly handle dependencies on tags in JARs
   http://svn.apache.org/viewvc?rev=618481&view=rev

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=620842&r1=620841&r2=620842&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java 
Tue Feb 12 08:13:54 2008
@@ -1415,7 +1415,10 @@
 return buffer.toString();
 }
 } catch (NamingException e) {
-throw new ServletException("Error opening readme resource", e);
+if (debug > 10)
+log("readme '" + readmeFile + "' not found", e);
+
+return null;
 }
 }
 
@@ -1438,7 +1441,10 @@
 return is;
 }
 } catch (NamingException e) {
-throw new ServletException("Error opening XSLT resource", e);
+if (debug > 10)
+log("localXsltFile '" + localXsltFile + "' not found", e);
+
+return null;
 }
 }
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=620842&r1=620841&r2=620842&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Feb 12 08:13:54 2008
@@ -32,6 +32,13 @@
   
 
 
+
+  
+
+44337:   Dir listing crashes if no readme-file present 
(funkman)
+
+  
+
 
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620800 - /tomcat/tc6.0.x/trunk/STATUS.txt

[pero]

Author: pero
Date: Tue Feb 12 05:49:45 2008
New Revision: 620800

URL: http://svn.apache.org/viewvc?rev=620800&view=rev
Log:
Cast my vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620800&r1=620799&r2=620800&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 05:49:45 2008
@@ -73,7 +73,7 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44337
   Dir listing crashes if no readme-file present
   http://svn.apache.org/viewvc?rev=618150&view=rev
-  +1: funkman, markt, fhanik
+  +1: funkman, markt, fhanik, pero
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43741
@@ -84,12 +84,12 @@
 
 * Handle case of NIO/SSL when transferring bytes to a disconnected socket
   http://svn.apache.org/viewvc?rev=618420&view=rev
-  +1: fhanik, markt
+  +1: fhanik, markt, pero
   -1: 
   
 * Use a single lock for synchronized session manipulation
   http://svn.apache.org/viewvc?rev=618823&view=rev
-  +1: fhanik, markt
+  +1: fhanik, markt, pero
   -1: 
 
 * ExtendedAccessLogValve cs-uri not print empty querystring



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Implementing wildcard hostnames or aliases

[Pid]

Michael Wyraz wrote:

Hi,

I have done further research for this topic and I found a solution for 
tomcat 5.5: http://www.mhsoftware.com/~gsexton/Mapper.java
Should this also work on Tomcat 6 (simply to change the Mapper 
implementation)?
Can the mapper class be replaced via configuration (I don't think so 
beause it's final and has no interfaces)?


I've read a discussion about the change above but there was decied not 
to add this to the tomcat sources because it slows down the mapping by 
0,05%. Maybe the code could be changed in a way that there's no 
noticeable slowdown when wildcards are disabled. I have no idea how much 
the slowdown would be if I'd add 100 extra host aliases instead of a 
wildcard but I think it would be similar.


Regards, Michael.

I was searching for a way to use wildcard host names in tomcat (e.g. 
*.myhost.com). With the current implementation it seems not to be 
possible. I found some ideas like using a valve at engine level which 
forwards to the correct hostname. The problem with this is that the 
servlets wouln'd see the original hostname then (correct me if I'm 
wrong with that).


So I'm looking for a way to implement this. Since tomcat is very 
modular, maybe it's just one component which needs to be replaced by a 
modified one. But I'm not a tomcat developer and so I have no idea 
where to start with that. So could you help with some ideas how I 
could implement this? I would do the implementation and send the 
results to the devel team.


Regards, Michael.


Is there a reason why you can't exploit the defaultHost attribute of the 
Engine element in server.xml?


(If you need help with that, then I suggest you try the users list.)

p



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620781 - /tomcat/tc6.0.x/trunk/STATUS.txt

[pero]

Author: pero
Date: Tue Feb 12 04:42:03 2008
New Revision: 620781

URL: http://svn.apache.org/viewvc?rev=620781&view=rev
Log:
Add small fix at ExtendedAccessLogValve

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620781&r1=620780&r2=620781&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 04:42:03 2008
@@ -91,3 +91,8 @@
   http://svn.apache.org/viewvc?rev=618823&view=rev
   +1: fhanik, markt
   -1: 
+
+* ExtendedAccessLogValve cs-uri not print empty querystring
+  http://svn.apache.org/viewvc?rev=620778&view=rev
+  +1: pero
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r620778 - in /tomcat/trunk: java/org/apache/catalina/valves/ExtendedAccessLogValve.java webapps/docs/changelog.xml

[pero]

Author: pero
Date: Tue Feb 12 04:36:00 2008
New Revision: 620778

URL: http://svn.apache.org/viewvc?rev=620778&view=rev
Log:
ExtendedAccessLogValve cs-uri not print empty querystring

Modified:
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=620778&r1=620777&r2=620778&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
Tue Feb 12 04:36:00 2008
@@ -663,7 +663,7 @@
 public void addElement(StringBuffer buf, Date date,
 Request request, Response response, long time) 
{
 String query = request.getQueryString();
-if (query != null) {
+if (query == null) {
 buf.append(request.getRequestURI());
 } else {
 buf.append(request.getRequestURI());

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=620778&r1=620777&r2=620778&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Feb 12 04:36:00 2008
@@ -32,6 +32,14 @@
   
 
 
+
+  
+ 
+  ExtendedAccessLogValve cs-uri not print empty querystring (pero)
+  
+ 
+  
+
 
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Implementing wildcard hostnames or aliases

[Michael Wyraz]

Hi,

I have done further research for this topic and I found a solution for 
tomcat 5.5: http://www.mhsoftware.com/~gsexton/Mapper.java
Should this also work on Tomcat 6 (simply to change the Mapper 
implementation)?
Can the mapper class be replaced via configuration (I don't think so 
beause it's final and has no interfaces)?


I've read a discussion about the change above but there was decied not 
to add this to the tomcat sources because it slows down the mapping by 
0,05%. Maybe the code could be changed in a way that there's no 
noticeable slowdown when wildcards are disabled. I have no idea how much 
the slowdown would be if I'd add 100 extra host aliases instead of a 
wildcard but I think it would be similar.


Regards, Michael.

I was searching for a way to use wildcard host names in tomcat (e.g. 
*.myhost.com). With the current implementation it seems not to be 
possible. I found some ideas like using a valve at engine level which 
forwards to the correct hostname. The problem with this is that the 
servlets wouln'd see the original hostname then (correct me if I'm 
wrong with that).


So I'm looking for a way to implement this. Since tomcat is very 
modular, maybe it's just one component which needs to be replaced by a 
modified one. But I'm not a tomcat developer and so I have no idea 
where to start with that. So could you help with some ideas how I 
could implement this? I would do the implementation and send the 
results to the devel team.


Regards, Michael.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]