DO NOT REPLY [Bug 40775] - Single-sign on session invalidation not working as expected

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40775


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 00:57 ---
I think, that a app session only must register to SSO cache as user really 
login! 
The problem is: Why you got a RemoteUser and UserPrincipal at your testapp2, 
without login?
Currently SingleSignOn valve set  this information  without a auth check. That 
looks strange for me!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40316] - apachectl -k graceful causes segmentation fault

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40316





--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 02:51 ---
(In reply to comment #8)

> I installed the dev snapshot and hope to see the error come up again soon.

The error never occured again since. I tried to make sure that no changes were
introduced in the compile process, so I guess the problem was already fixed by
another code change.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40316] - apachectl -k graceful causes segmentation fault

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40316


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 03:53 ---
Closing now, since at the moment we have no more observations of this for recent
versions.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42347] - getParameter does not return parameter value when submitted as post method occassionally

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42347


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 08:14 ---
we are on 5.5.20 and are still seeing this not work in some cases.

In the example below the call that fails is 
"common/attrConfig/derived2?id=66644",
Ive included surrounding calls for compelteness. The debug on the client is 
also the only place on the client "derived2" is called (it was renamed to 
ensure this fact).

I dont have a solid reproduction, but Ive found if I tax the CPU to 100% I can 
see this occur somewhat "more" offen. Clearly a threading issue. I was able to 
get a trace when this failed which might offer some help on the path taken.

Requesting client (expecting a MtypeProperties[], but got a Map)

Mon Jan 07 10:37:46 EST 2008: AWT-EventQueue-0: requesting path = 
common/attrConfig/derived2?id=12845175
Mon Jan 07 10:37:46 EST 2008: AWT-EventQueue-0: requesting path = 
common/attrConfig/derived2?id=66644
Jan 7, 2008 10:37:46 AM - ClientAttributeConfig.getDerivedMtypesInt failed:
java.lang.ClassCastException: java.util.HashMap cannot be cast to 
[Lcom.aprisma.spectrum.app.util.attribute.MtypeProperties;
Mon Jan 07 10:37:46 EST 2008: AWT-EventQueue-0: requesting path = 
common/attrConfig/derived2?id=66102


AttributeConfigServlet.java (sends a Map on null "id")

else if ( servletPath.endsWith ( "derived2" ) )
{
String mtypeIDStr = request.getParameter ( "id" ) ;

System.out.println( (new Date()).toString() + ": " + 
   Thread.currentThread().getName() + ": mtypeIDStr = " + mtypeIDStr );

if ( mtypeIDStr != null && mtypeIDStr.length () > 0 )
{
// response is a MtypeProperties[]
}
else
{
// response is a Map
}

if ( mtypeIDStr == null )
{
   new Exception().printStackTrace();
}
 }


localhost_access_log.2008-01-07.txt (with format '%h %l %u %t "%r" %s %b')
(clearly see a id=66644, but sends a large value back 29199)

138.42.248.45 - brido02 [07/Jan/2008:10:37:45 -0500] 
"GET /spectrum/common/attrConfig/derived2?id=12845175 HTTP/1.1" 200 253
138.42.248.45 - brido02 [07/Jan/2008:10:37:45 -0500] 
"GET /spectrum/common/attrConfig/derived2?id=66644 HTTP/1.1" 200 29199
138.42.248.45 - brido02 [07/Jan/2008:10:37:45 -0500] 
"GET /spectrum/common/attrConfig/derived2?id=66102 HTTP/1.1" 200 375


catalina.out

Mon Jan 07 10:37:46 EST 2008: http-80-Processor22: mtypeIDStr = 12845175
Mon Jan 07 10:37:46 EST 2008: http-80-Processor21: mtypeIDStr = null
java.lang.Exception
at com.aprisma.spectrum.app.web.servlet.AttributeConfigServlet.doGet
(AttributeConfigServlet.java:159)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
(ApplicationFilterChain.java:252)
at org.apache.catalina.core.ApplicationFilterChain.doFilter
(ApplicationFilterChain.java:173)
at org.apache.catalina.core.StandardWrapperValve.invoke
(StandardWrapperValve.java:213)
at org.apache.catalina.core.StandardContextValve.invoke
(StandardContextValve.java:178)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke
(AuthenticatorBase.java:524)
at org.apache.catalina.core.StandardHostValve.invoke
(StandardHostValve.java:126)
at org.apache.catalina.valves.ErrorReportValve.invoke
(ErrorReportValve.java:105)
at org.apache.catalina.valves.FastCommonAccessLogValve.invoke
(FastCommonAccessLogValve.java:495)
at org.apache.catalina.core.StandardEngineValve.invoke
(StandardEngineValve.java:107)
at org.apache.catalina.connector.CoyoteAdapter.service
(CoyoteAdapter.java:148)
at org.apache.coyote.http11.Http11Processor.process
(Http11Processor.java:869)
at 
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConn
ection(Http11BaseProtocol.java:664)
at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket
(PoolTcpEndpoint.java:527)
at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt
(LeaderFollowerWorkerThread.java:80)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:619)
Mon Jan 07 10:37:46 EST 2008: http-80-P

DO NOT REPLY [Bug 44179] New: - Possible frustration with svn:externals definition for /trunk/native/connector.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44179

   Summary: Possible frustration with svn:externals definition for
/trunk/native/connector.
   Product: Tomcat 6
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: trivial
  Priority: P5
 Component: Native:JK
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The svn:externals definition for /trunk/native/connector is currently set to use
the "https" scheme.

According to the SVN book at
(http://svnbook.red-bean.com/en/1.4/svn.advanced.externals.html):

"Also, the absolute URLs that externals definitions use can cause problems with
repositories that are available via multiple URL schemes. For example, if your
Subversion server is configured to allow everyone to check out the repository
over http:// or https://, but only allow commits to come in via https://, you
have an interesting problem on your hands. If your externals definitions use the
http:// form of the repository URLs, you won't be able to commit anything from
the working copies created by those externals. On the other hand, if they use
the https:// form of the URLs, anyone who might be checking out via http://
because their client doesn't support https:// will be unable to fetch the
external items. Be aware, too, that if you need to re-parent your working copy
(using svn switch --relocate), externals definitions will not also be 
re-parented."

It may be more appropriate if the externals definition was set to use
"http://svn.apache.org/repos/asf/tomcat/connectors/trunk/jni/native";.  If not,
please disregard this bug/issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609751 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h

[rjung]

Author: rjung
Date: Mon Jan  7 11:29:43 2008
New Revision: 609751

URL: http://svn.apache.org/viewvc?rev=609751&view=rev
Log:
Comment reformatting.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h?rev=609751&r1=609750&r2=609751&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h Mon Jan  7 
11:29:43 2008
@@ -284,9 +284,9 @@
 int prepost_timeout;   /* before sending a request cping/cpong timeout 
delay in ms (0 means disabled) */
 
 /*
- * Recovery option
+ * Recovery options
  */
-unsigned int recovery_opts; /* Set the recovery option */
+unsigned int recovery_opts;
 
 unsigned int max_packet_size;  /*  Maximum AJP Packet size */
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609756 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

[rjung]

Author: rjung
Date: Mon Jan  7 11:36:53 2008
New Revision: 609756

URL: http://svn.apache.org/viewvc?rev=609756&view=rev
Log:
We already sync (jk_lb_pull) "retries" from shm to
the lb worker before, so no need to use the shm here.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=609756&r1=609755&r2=609756&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Mon Jan  7 11:36:53 
2008
@@ -971,7 +971,7 @@
 if (p->worker->lblock == JK_LB_LOCK_PESSIMISTIC)
 jk_shm_unlock();

-while ((!(r=rec->w->get_endpoint(rec->w, &end, l)) || !end) && 
(retry < p->worker->s->retries)) {
+while ((!(r=rec->w->get_endpoint(rec->w, &end, l)) || !end) && 
(retry < p->worker->retries)) {
 retry++;
 retry_wait *=2;
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609757 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_service.h common/jk_util.c iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

[rjung]

Author: rjung
Date: Mon Jan  7 11:41:44 2008
New Revision: 609757

URL: http://svn.apache.org/viewvc?rev=609757&view=rev
Log:
Remove "retries" element from service struct, because
we don't use it.

Modified:
tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
tomcat/connectors/trunk/jk/native/common/jk_service.h
tomcat/connectors/trunk/jk/native/common/jk_util.c
tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c
tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?rev=609757&r1=609756&r2=609757&view=diff
==
--- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Mon Jan  7 11:41:44 
2008
@@ -2166,8 +2166,6 @@
 wc_maintain(conf->log);
 jk_init_ws_service(&s);
 
-/* Update retries for this worker */
-s.retries = worker->retries;
 s.ws_private = &private_data;
 s.pool = &private_data.p;
 ap_table_setn(r->notes, JK_NOTE_WORKER_TYPE,

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?rev=609757&r1=609756&r2=609757&view=diff
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Mon Jan  7 11:41:44 
2008
@@ -2251,8 +2251,6 @@
 wc_maintain(xconf->log);
 
 jk_init_ws_service(&s);
-/* Update retries for this worker */
-s.retries = worker->retries;
 s.ws_private = &private_data;
 s.pool = &private_data.p;
 apr_table_setn(r->notes, JK_NOTE_WORKER_TYPE,

Modified: tomcat/connectors/trunk/jk/native/common/jk_service.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_service.h?rev=609757&r1=609756&r2=609757&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_service.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_service.h Mon Jan  7 11:41:44 
2008
@@ -208,10 +208,6 @@
 jk_msg_buf_t *reco_buf;
 int reco_status;
 
-/* Number of retries. Defaults to JK_RETRIES
- */
-int retries;
-
 /*
  * If set call flush after each write
  */

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?rev=609757&r1=609756&r2=609757&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Mon Jan  7 11:41:44 2008
@@ -1865,7 +1865,6 @@
 s->secret = NULL;
 s->reco_buf = NULL;
 s->reco_status = RECO_NONE;
-s->retries = JK_RETRIES;
 s->flush_packets = JK_FALSE;
 s->flush_header = JK_FALSE;
 s->response_started = JK_FALSE;

Modified: tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c?rev=609757&r1=609756&r2=609757&view=diff
==
--- tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c Mon Jan  7 11:41:44 
2008
@@ -1506,8 +1506,6 @@
 
 if (worker) {
 jk_endpoint_t *e = NULL;
-/* Update retries for this worker */
-s.retries = worker->retries;
 if (worker->get_endpoint(worker, &e, logger)) {
 int is_error = JK_HTTP_SERVER_ERROR;
 int result;

Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c?rev=609757&r1=609756&r2=609757&view=diff
==
--- tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c (original)
+++ tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Mon Jan  7 
11:41:44 2008
@@ -380,7 +380,6 @@
 
 s.ws_private = &private_data;
 s.pool = &private_data.p;
-s.retries = worker->retries;
 
 wc_maintain(logger);
 if (init_ws_service(&private_data, &s)) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609760 - in /tomcat/connectors/trunk/jk: native/common/ xdocs/miscellaneous/

[rjung]

Author: rjung
Date: Mon Jan  7 11:51:15 2008
New Revision: 609760

URL: http://svn.apache.org/viewvc?rev=609760&view=rev
Log:
Refactor "retries", remove from service and jk_worker,
move into ajp worker instead, because we don't actually
use it in the other jk workers.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c
tomcat/connectors/trunk/jk/native/common/jk_ajp13_worker.c
tomcat/connectors/trunk/jk/native/common/jk_ajp14_worker.c
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h
tomcat/connectors/trunk/jk/native/common/jk_jni_worker.c
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
tomcat/connectors/trunk/jk/native/common/jk_service.h
tomcat/connectors/trunk/jk/native/common/jk_status.c
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c?rev=609760&r1=609759&r2=609760&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c Mon Jan  7 
11:51:15 2008
@@ -280,7 +280,6 @@
 private_data->worker.get_endpoint = get_endpoint;
 private_data->worker.destroy = destroy;
 private_data->worker.maintain = NULL;
-private_data->worker.retries = JK_RETRIES;
 
 *w = &private_data->worker;
 return JK_AJP12_WORKER_TYPE;

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp13_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp13_worker.c?rev=609760&r1=609759&r2=609760&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp13_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp13_worker.c Mon Jan  7 
11:51:15 2008
@@ -44,12 +44,8 @@
   jk_worker_env_t *we, jk_logger_t *l)
 {
 int rc;
-ajp_worker_t *aw = ( ajp_worker_t *)pThis->worker_private;
 JK_TRACE_ENTER(l);
 
-pThis->retries = jk_get_worker_retries(props, aw->name,
-   JK_RETRIES);
-
 rc = ajp_init(pThis, props, we, l, AJP13_PROTO);
 JK_TRACE_EXIT(l);
 return rc;
@@ -110,7 +106,6 @@
 aw->worker.get_endpoint = get_endpoint;
 aw->worker.destroy = destroy;
 aw->worker.maintain = ajp_maintain;
-aw->worker.retries = JK_RETRIES;
 
 aw->logon = NULL;   /* No Logon on AJP13 */
 

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp14_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp14_worker.c?rev=609760&r1=609759&r2=609760&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp14_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp14_worker.c Mon Jan  7 
11:51:15 2008
@@ -307,8 +307,6 @@
 return JK_FALSE;
 }
 aw = pThis->worker_private;
-pThis->retries = jk_get_worker_retries(props, aw->name,
-   JK_RETRIES);
 
 /* Set Secret Key (used at logon time) */
 aw->login->secret_key = jk_get_worker_secret_key(props, aw->name);
@@ -425,7 +423,6 @@
 aw->worker.get_endpoint = get_endpoint;
 aw->worker.destroy = destroy;
 aw->worker.maintain = ajp_maintain;
-aw->worker.retries = JK_RETRIES;
 
 aw->logon = logon;  /* LogOn Handler for AJP14 */
 *w = &aw->worker;

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=609760&r1=609759&r2=609760&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Mon Jan  7 
11:51:15 2008
@@ -2065,9 +2065,9 @@
 
 if (JK_IS_DEBUG_LEVEL(l)) {
 jk_log(l, JK_LOG_DEBUG, "processing %s with %d retries",
-   p->worker->name, p->worker->worker.retries);
+   p->worker->name, p->worker->retries);
 }
-for (i = 0; i < p->worker->worker.retries; i++) {
+for (i = 0; i < p->worker->retries; i++) {
 /*
  * We're using op->request which hold initial request
  * if Tomcat is stopped or restarted, we will pass op->request
@@ -2375,6 +2375,11 @@
 p->recovery_opts =
 jk_get_worker_recovery_opts(props, p->name,
 AJP_DEF_RECOVERY_OPTS);
+
+p->retries =
+jk_get_worker_retries(props, p->name

DO NOT REPLY [Bug 44179] - Possible frustration with svn:externals definition for /trunk/native/connector.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44179


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 12:43 ---
Apache's svn configuration requires https for check-in.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42347] - getParameter does not return parameter value when submitted as post method occassionally

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42347


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 12:54 ---
This looks similar to bug 40860. The additional logging in 5.5.21 onwards may
shed some light on this. Can you test with 5.5.25?

Please provide the full source for AttributeConfigServlet or better yet a
minimal Servlet with which you can re-produce the same issue.

Could you also update this bug with OS info and whether or nor you are using the
native connector.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r609757 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_service.h common/jk_util.c iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

[Mladen Turk]

[EMAIL PROTECTED] wrote:

Author: rjung
Date: Mon Jan  7 11:41:44 2008
New Revision: 609757

URL: http://svn.apache.org/viewvc?rev=609757&view=rev
Log:
Remove "retries" element from service struct, because
we don't use it.



I don't get it.
This copy was intentionally made so we can pass the
retries from lb to each worker, meaning that if you
set the retries to the lb it'll be propagated to each
worker that is member of this lb, allowing to set the
retries only once.

Can you explain this patch?

Regards,
Mladen



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609778 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/interceptors/ThroughputInterceptor.java transport/nio/NioReceiver.java

[fhanik]

Author: fhanik
Date: Mon Jan  7 13:11:26 2008
New Revision: 609778

URL: http://svn.apache.org/viewvc?rev=609778&view=rev
Log:
minor fixes

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java?rev=609778&r1=609777&r2=609778&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java
 Mon Jan  7 13:11:26 2008
@@ -16,6 +16,10 @@
 
 package org.apache.catalina.tribes.group.interceptors;
 
+import java.text.DecimalFormat;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicLong;
+
 import org.apache.catalina.tribes.ChannelException;
 import org.apache.catalina.tribes.ChannelMessage;
 import org.apache.catalina.tribes.Member;
@@ -23,10 +27,6 @@
 import org.apache.catalina.tribes.group.InterceptorPayload;
 import org.apache.catalina.tribes.io.ChannelData;
 import org.apache.catalina.tribes.io.XByteBuffer;
-import java.text.DecimalFormat;
-import org.apache.catalina.tribes.membership.MemberImpl;
-import java.util.concurrent.atomic.AtomicInteger;
-import java.util.concurrent.atomic.AtomicLong;
 
 
 
@@ -61,7 +61,7 @@
 super.sendMessage(destination, msg, payload);
 }catch ( ChannelException x ) {
 msgTxErr.addAndGet(1);
-access.addAndGet(-1);
+if ( access.get() == 1 ) access.addAndGet(-1);
 throw x;
 } 
 mbTx += ((double)(bytes*destination.length))/(1024d*1024d);
@@ -115,6 +115,46 @@
 
 public int getInterval() {
 return interval;
+}
+
+public double getLastCnt() {
+return lastCnt;
+}
+
+public double getMbAppTx() {
+return mbAppTx;
+}
+
+public double getMbRx() {
+return mbRx;
+}
+
+public double getMbTx() {
+return mbTx;
+}
+
+public AtomicLong getMsgRxCnt() {
+return msgRxCnt;
+}
+
+public AtomicLong getMsgTxCnt() {
+return msgTxCnt;
+}
+
+public AtomicLong getMsgTxErr() {
+return msgTxErr;
+}
+
+public long getRxStart() {
+return rxStart;
+}
+
+public double getTimeTx() {
+return timeTx;
+}
+
+public long getTxStart() {
+return txStart;
 }
 
 }

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java?rev=609778&r1=609777&r2=609778&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java 
Mon Jan  7 13:11:26 2008
@@ -37,6 +37,7 @@
 import java.util.LinkedList;
 import java.util.Set;
 import java.nio.channels.CancelledKeyException;
+import java.nio.channels.ClosedSelectorException;
 
 /**
  * @author Filip Hanik
@@ -303,8 +304,7 @@
 
 }
 serverChannel.close();
-if (selector != null)
-selector.close();
+closeSelector();
 }
 
 
@@ -319,13 +319,34 @@
 if (selector != null) {
 try {
 selector.wakeup();
-selector.close();
+closeSelector();
 } catch (Exception x) {
 log.error("Unable to close cluster receiver selector.", x);
 } finally {
 selector = null;
 }
 }
+}
+
+private void closeSelector() throws IOException {
+Selector selector = this.selector;
+this.selector = null;
+if (selector==null) return;
+try {
+Iterator it = selector.keys().iterator();
+// look at each key in the selected set
+while (it.hasNext()) {
+SelectionKey key = (SelectionKey)it.next();
+key.channel().close();
+key.attach(null);
+key.cancel();
+}
+}catch ( IOException ignore ){
+if (log.isWarnEnabled()) {
+log.warn("Unable to cleanup on selector close.",ignore);
+}
+}catch ( ClosedSelectorException ignore){}
+selector.close();
 }
 
 // --



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additi

svn commit: r609784 - in /tomcat/trunk/java/org/apache/catalina/ha: jmx/ jmx/ClusterJmxHelper.java tcp/SimpleTcpCluster.java

[fhanik]

Author: fhanik
Date: Mon Jan  7 13:25:23 2008
New Revision: 609784

URL: http://svn.apache.org/viewvc?rev=609784&view=rev
Log:
start the cluster JMX impl

Added:
tomcat/trunk/java/org/apache/catalina/ha/jmx/
tomcat/trunk/java/org/apache/catalina/ha/jmx/ClusterJmxHelper.java
Modified:
tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java

Added: tomcat/trunk/java/org/apache/catalina/ha/jmx/ClusterJmxHelper.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/jmx/ClusterJmxHelper.java?rev=609784&view=auto
==
--- tomcat/trunk/java/org/apache/catalina/ha/jmx/ClusterJmxHelper.java (added)
+++ tomcat/trunk/java/org/apache/catalina/ha/jmx/ClusterJmxHelper.java Mon Jan  
7 13:25:23 2008
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.ha.jmx;
+
+import javax.management.DynamicMBean;
+import javax.management.MBeanServer;
+import javax.management.MBeanServerFactory;
+import javax.management.ObjectName;
+
+import org.apache.catalina.core.StandardEngine;
+import org.apache.catalina.core.StandardHost;
+import org.apache.catalina.ha.authenticator.ClusterSingleSignOn;
+import org.apache.catalina.ha.deploy.FarmWarDeployer;
+import org.apache.catalina.ha.session.DeltaManager;
+import org.apache.catalina.ha.tcp.SimpleTcpCluster;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import org.apache.tomcat.util.modeler.ManagedBean;
+import org.apache.tomcat.util.modeler.Registry;
+/**
+ * 
+ * @author Filip Hanik
+ */
+public class ClusterJmxHelper {
+
+protected static Registry registry = Registry.getRegistry(null,null);
+
+protected static Log log = LogFactory.getLog(ClusterJmxHelper.class);
+
+protected static boolean jmxEnabled = true;
+
+protected static MBeanServer mbeanServer = null;
+
+public static Registry getRegistry() {
+return registry;
+}
+
+public static MBeanServer getMBeanServer() throws Exception {
+if (mbeanServer == null) {
+if (MBeanServerFactory.findMBeanServer(null).size() > 0) {
+mbeanServer = (MBeanServer) 
MBeanServerFactory.findMBeanServer(null).get(0);
+} else {
+mbeanServer = MBeanServerFactory.createMBeanServer();
+}
+}
+return mbeanServer;
+}
+
+protected static boolean initMetaData(Class clazz) {
+try {
+if (clazz==null) return false;
+
getRegistry().loadMetadata(clazz.getResourceAsStream("mbeans-descriptors.xml"));
+}catch (Exception x) {
+log.warn("Unable to load meta data for class:"+clazz.getName());
+return false;
+}
+return true;
+}
+
+public static DynamicMBean getManagedBean(Object object) throws Exception {
+DynamicMBean mbean = null;
+if (getRegistry() != null) {
+ManagedBean managedBean = 
registry.findManagedBean(object.getClass().getName());
+mbean = managedBean.createMBean(object);
+}
+return mbean;
+}
+
+
+protected static void initDefaultCluster() {
+initMetaData(SimpleTcpCluster.class);
+initMetaData(DeltaManager.class);
+initMetaData(FarmWarDeployer.class); //not functional yet
+initMetaData(ClusterSingleSignOn.class); //not functional yet
+}
+
+public static boolean registerDefaultCluster(SimpleTcpCluster cluster)  {
+try {
+initDefaultCluster();
+ObjectName clusterName = getDefaultClusterName(cluster);
+if (!getMBeanServer().isRegistered(clusterName)) {
+getMBeanServer().registerMBean(getManagedBean(cluster), 
clusterName);
+}
+return true;
+}catch ( Exception x ) {
+log.warn("Unable to register default cluster implementation with 
JMX",x);
+return false;
+}
+}
+
+public static boolean unregisterDefaultCluster(SimpleTcpCluster cluster) {
+try {
+ObjectName clusterName = getDefaultClusterName(cluster);
+   

svn commit: r609790 [1/3] - in /tomcat/trunk/java/org/apache/catalina: ha/ ha/authenticator/ ha/deploy/ ha/session/ ha/tcp/ tribes/ tribes/membership/ tribes/transport/

[fhanik]

Author: fhanik
Date: Mon Jan  7 13:52:49 2008
New Revision: 609790

URL: http://svn.apache.org/viewvc?rev=609790&view=rev
Log:
reformat, no change, so that the upcoming changes and corrections of mbean 
files can be easily read

Modified:

tomcat/trunk/java/org/apache/catalina/ha/authenticator/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/ha/tcp/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/tribes/mbeans-descriptors.xml

tomcat/trunk/java/org/apache/catalina/tribes/membership/mbeans-descriptors.xml

tomcat/trunk/java/org/apache/catalina/tribes/transport/mbeans-descriptors.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/authenticator/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/authenticator/mbeans-descriptors.xml?rev=609790&r1=609789&r2=609790&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/ha/authenticator/mbeans-descriptors.xml 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/ha/authenticator/mbeans-descriptors.xml 
Mon Jan  7 13:52:49 2008
@@ -6,9 +6,7 @@
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
+  http://www.apache.org/licenses/LICENSE-2.0
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -16,26 +14,24 @@
   limitations under the License.
 -->
 
-
-  
-
-
-
-
-
-
-
+  
+
+
+
   
-
 

Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml?rev=609790&r1=609789&r2=609790&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml Mon 
Jan  7 13:52:49 2008
@@ -6,9 +6,7 @@
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
+  http://www.apache.org/licenses/LICENSE-2.0
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -16,12 +14,11 @@
   limitations under the License.
 -->
 
-  
-  
+type="org.apache.catalina.ha.deploy.FarmWarDeployer"/>
 

Modified: tomcat/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml?rev=609790&r1=609789&r2=609790&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml (original)
+++ tomcat/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml Mon Jan  7 
13:52:49 2008
@@ -6,9 +6,7 @@
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
+  http://www.apache.org/licenses/LICENSE-2.0
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -16,91 +14,82 @@
   limitations under the License.
 -->
 
-
-  
-
-  
-
-
-  
-
-
+  
+
-
-
+
-
-
-
-
+
+
-
-
+
-
-
-
-
+
+
-
-
+
-
-
+
-
+  type="java.lang.String"
+  writeable="false"/>
   
-
-
-
-
-
-
-
-
-
+  
+
+
   
-
-
 

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=609790&r1=609789&r2=609790&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descripto

svn commit: r609803 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

[markt]

Author: markt
Date: Mon Jan  7 15:15:59 2008
New Revision: 609803

URL: http://svn.apache.org/viewvc?rev=609803&view=rev
Log:
Fix bug 43743. Correctly handle nest tag files packaged in a jar.

Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Parser.java?rev=609803&r1=609802&r2=609803&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Parser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Mon Jan  7 
15:15:59 2008
@@ -424,6 +424,13 @@
 if (ctxt.getOptions().isCaching()) {
 ctxt.getOptions().getCache().put(uri, impl);
 }
+} else {
+// Current compilation context needs location of cached
+// tag files
+for (TagFileInfo info : impl.getTagFiles()) {
+ctxt.setTagFileJarUrl(info.getPath(),
+ctxt.getTagFileJarUrl());
+}
 }
 pageInfo.addTaglib(uri, impl);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609805 - /tomcat/tc6.0.x/trunk/STATUS.txt

[markt]

Author: markt
Date: Mon Jan  7 15:28:48 2008
New Revision: 609805

URL: http://svn.apache.org/viewvc?rev=609805&view=rev
Log:
Propose fix for 43743.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=609805&r1=609804&r2=609805&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jan  7 15:28:48 2008
@@ -72,3 +72,9 @@
   http://svn.apache.org/viewvc?rev=609003&view=rev
   +1: markt
   -1: 
+
+  Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43743
+  Correctly handle nest tag files packaged in a jar.
+  http://svn.apache.org/viewvc?rev=609803&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43742] - .tag compiles performed one at a time -- extremely slow

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43742


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 15:43 ---
I've no doubt this could be better.

The fix for bug43878 may offer some improvements when not using development 
mode.

Improving this further is likely to require fairly major changes to Jasper so I
am marking this as an enhancement.

If you (or anyone else) feels the urge to scratch this itch then patches (in
diff -u format) are always welcome.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r609757 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_service.h common/jk_util.c iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

[Rainer Jung]

Mladen Turk schrieb:

[EMAIL PROTECTED] wrote:

Author: rjung
Date: Mon Jan  7 11:41:44 2008
New Revision: 609757

URL: http://svn.apache.org/viewvc?rev=609757&view=rev
Log:
Remove "retries" element from service struct, because
we don't use it.



I don't get it.
This copy was intentionally made so we can pass the
retries from lb to each worker, meaning that if you
set the retries to the lb it'll be propagated to each
worker that is member of this lb, allowing to set the
retries only once.


But that's not what the code does, see below. The retries in the lb and 
in the members serve a different and independant purpose. Of course it 
would have been nice to give those different names and then inherit from 
lb to the members, but we can't change the meaning of the parameters 
now. See details below.



Can you explain this patch?


Yes. We had "retries" in three places:

A) in the service struct
B) in the lb_worker struct
C) in the jk_worker struct

Ad A)

The element retries in the service struct was set in the web server 
plugins to JK_RETRIES, but never read. It was not used in any place.


Ad B)

The retries in the lb_worker is the number of times we try to get and 
endpoint from the cache. For Apache with default settings, this should 
be noop, because we have as many endpoints as we have threads, for IIS 
and netscape, this will wait a bit and retry to get a free endpoint.


The value gets set during lb initialization and is read from the 
workers.properties, attribite retries of the lb worker itself.


Ad C)

The retries in jk_worker is set in all types of workers (status, jni, 
ajp12, ajp13, ajp14) but only used in ajp13 and ajp14. Therefore I moved 
it from jk_worker to ajp_worker, because that's a good fit.


The value gets set during ajp worker initialization rom the retries 
attribute of the ajp worker (or lb member). It is independent from the 
retries on any lb.


It gets used, when the service call of the worker gets an error, e.g. if 
all connections are dead.


Does that make sense for you?

Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43741] - .tag files in a .tar recompiled for each .jsp -- extremely slow (with fix)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43741





--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 15:52 ---
I'd much rather fix the cause than the symptom. The proper fix for this will be
to implement the enhancement described in bug 43742.

I'll check the code to see if the JSP -> JAR dependency has been fixed (and if
it hasn't - fix it) but if you have a bug number that would save me some time.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609813 - /tomcat/tc6.0.x/trunk/STATUS.txt

[fhanik]

Author: fhanik
Date: Mon Jan  7 16:04:46 2008
New Revision: 609813

URL: http://svn.apache.org/viewvc?rev=609813&view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=609813&r1=609812&r2=609813&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jan  7 16:04:46 2008
@@ -34,7 +34,7 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43868
   MBean methods getInvoke() and getSetter() were broken
   http://svn.apache.org/viewvc?rev=607483&view=rev
-  +1: markt, jim
+  +1: markt, jim, fhanik
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43840
@@ -46,35 +46,35 @@
 * Improve Jasper docs. Note rather than remove unused option, it will be
   deprecated in 6.0.x.
   http://svn.apache.org/viewvc?rev=607860&view=rev
-  +1: markt, funkman
+  +1: markt, funkman, fhanik
   -1: 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43800
   Make link between APR and Native clearer
   http://svn.apache.org/viewvc?rev=607875&view=rev
-  +1: markt, funkman
+  +1: markt, funkman, fhanik
   -1:
 
   Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43775
   Don't change line endings for binary files
   http://svn.apache.org/viewvc?rev=607888&view=rev
-  +1: markt, funkman
+  +1: markt, funkman, fhanik
   -1:
 
   Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43758
   Prevent NPEs when scripting elements are empty
   http://svn.apache.org/viewvc?rev=607903&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
   Fix possible NPE in previous fix for
   http://issues.apache.org/bugzilla/show_bug.cgi?id=43839
   http://svn.apache.org/viewvc?rev=609003&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
   Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43743
   Correctly handle nest tag files packaged in a jar.
   http://svn.apache.org/viewvc?rev=609803&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43636] - Redeployment should replace all Threads with new Threads to clear ThreadLocals

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43636


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement
 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 16:08 ---
There have been a number of memory leaks, the most recent one logging related,
fixed within Tomcat. There have also been changes to a libraries such as
commons-logging to better handle the multi-classloader environment of a J2EE
server. This fixes/changes will all help.

By default, org.apache.catalina.loader.WebappClassLoader.ENABLE_CLEAR_REFERENCES
is true which should work around most of the remaining issues.

I would much rather fix a specific issue than add more workarounds that are
likely to cause just as many problems as they set out to solve (threads are per
connector, not per context, would need to handle long running threads in other
contexts etc)

I you have a test case that demonstrates a memory leak with the latest stable
6.0.x release, please feel free to open a new issue, attach the test case and I
will take a look.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43699] - symlink in WEB-INF, to an NFS mount, and tomcat does not come up.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43699


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2008-01-07 16:27 ---
That looks like a JVM problem to me. It appears to have hung on
java.io.UnixFileSystem.checkAccess(Native Method). It is just doing a
File.canRead() so I don't see what Tomcat can be doing that is wrong here.

I am closing this as INVALID on the basis that it is a JVM bug.

The other option is that you have some sort of network issue that is holding
things up.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r609757 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_service.h common/jk_util.c iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

[Mladen Turk]

Rainer Jung wrote:


Does that make sense for you?



Yes it does. The most important is that if
there was no retries set for ajp worker, it gets copied
from lb worker.

Regards,
Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r609757 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_service.h common/jk_util.c iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

[Rainer Jung]

Mladen Turk wrote:

Rainer Jung wrote:


Does that make sense for you?



Yes it does. The most important is that if
there was no retries set for ajp worker, it gets copied
from lb worker.


In fact we don't copy (this is not new), because the retries for an lb 
has a different functional meaning than for an lb sub worker. If an ajp 
worker (main worker or lb sub worker) doesn't have a retries set, it 
gets the default value JK_RETRIES (=2).



Regards,
Mladen


Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]