Re: svn commit: r599259 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/authenticator/FormAuthenticator.java webapps/docs/changelog.xml

[Peter Rossbach]

Hi Bill,

can we fix this bug also at Tomcat 5.5?

regards
Peter



Am 29.11.2007 um 05:19 schrieb [EMAIL PROTECTED]:


Author: billbarker
Date: Wed Nov 28 20:19:46 2007
New Revision: 599259

URL: http://svn.apache.org/viewvc?rev=599259&view=rev
Log:
Remove conditional headers on Form Auth replay, since the UA (esp.  
FireFox) isn't expecting it.


Fix for bug #43687

Reported by:   Przemyslaw Madzik


Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/authenticator/ 
FormAuthenticator.java

tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt? 
rev=599259&r1=599258&r2=599259&view=diff
== 


--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Nov 28 20:19:46 2007
@@ -31,11 +31,6 @@
   +1: jfclere
   -1: fhanik - Can we add the 'package' directive to make the  
package match the dir structure


-* Remove conditional headers on Form Auth replay, since the UA  
(esp. FireFox) isn't expecting it.

-  http://issues.apache.org/bugzilla/show_bug.cgi?id=43687
-  +1: billbarker, remm, jfclere, pero
-  -1:
-
 * Fix another license issue
   http://svn.apache.org/viewvc?rev=598412&view=rev
   +1: markt, fhanik, pero, remm, billbarker

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/ 
authenticator/FormAuthenticator.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/ 
apache/catalina/authenticator/FormAuthenticator.java? 
rev=599259&r1=599258&r2=599259&view=diff
== 

--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/authenticator/ 
FormAuthenticator.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/authenticator/ 
FormAuthenticator.java Wed Nov 28 20:19:46 2007

@@ -402,12 +402,20 @@

 MimeHeaders rmh = request.getCoyoteRequest().getMimeHeaders 
();

 rmh.recycle();
+boolean cachable = "GET".equalsIgnoreCase(saved.getMethod 
()) ||
+   "HEAD".equalsIgnoreCase(saved.getMethod 
());

 Iterator names = saved.getHeaderNames();
 while (names.hasNext()) {
 String name = (String) names.next();
-Iterator values = saved.getHeaderValues(name);
-while (values.hasNext()) {
-rmh.addValue(name).setString( (String)values.next 
() );
+// The browser isn't expecting this conditional  
response now.
+// Assuming that it can quietly recover from an  
unexpected 412.

+// BZ 43687
+if(!("If-Modified-Since".equalsIgnoreCase(name) ||
+ (cachable && "If-None-Match".equalsIgnoreCase 
(name {

+Iterator values = saved.getHeaderValues(name);
+while (values.hasNext()) {
+rmh.addValue(name).setString( (String) 
values.next() );

+}
 }
 }


Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/ 
changelog.xml?rev=599259&r1=599258&r2=599259&view=diff
== 


--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed Nov 28  
20:19:46 2007

@@ -72,6 +72,9 @@
 Improve the webDAV Servlet Javadocs to make clear that the  
WebDAV

 Servlet can not be used as the default servlet. (markt)
   
+  43687 Remove conditional headers on Form  
Auth replay,

+   since the UA (esp. FireFox) isn't expecting it.
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43991] - Contributing a URLResourceFactory

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43991





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 03:00 ---
Created an attachment (id=21203)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21203&action=view)
JAVA code


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43991] New: - Contributing a URLResourceFactory

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43991

   Summary: Contributing a URLResourceFactory
   Product: Tomcat 5
   Version: 5.5.25
  Platform: PC
OS/Version: Windows 2000
Status: NEW
  Severity: enhancement
  Priority: P4
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Please find attached a factory for creating and storing java.net.URL objects
inside the JNDI of Tomcat

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43992] New: - Solve the problem

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43992

   Summary: Solve the problem
   Product: Tomcat 5
   Version: 5.5.17
  Platform: PC
   URL: http://[EMAIL PROTECTED]
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43992] - Solve the problem

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43992


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43993] - mime mapping for WS-Policy

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43993





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 04:32 ---
Created an attachment (id=21204)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21204&action=view)
Patch for conf/web.xml that adds application/wspolicy+xml mime type mapping

Patch for conf/web.xml that adds application/wspolicy+xml mime type mapping

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38814] - CGIServlet applies wrong charset

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38814


[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version|All |Windows XP
   Platform|All |PC
Version|Unknown |5.5.17




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43993] New: - mime mapping for WS-Policy

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43993

   Summary: mime mapping for WS-Policy
   Product: Tomcat 6
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The web.xml ought to have a default MIME mapping as described in 
:

MIME media type name:
application

MIME subtype name:
wspolicy+xml

Required parameters:
none

Optional parameters:
charset

...

Additional information:

File extension:
wspolicy

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43578] - Tomcat fails to start on linux if CATALINA_HOME contains a space

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43578





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 04:53 ---
I encountered a similar problem this morning, with CATALINA_BASE containing a 
space.

Here's what I have found:

1. The problem seems to be in the setting of JAVA_OPTS in the following:
# Set juli LogManager if it is present
if [ -r "$CATALINA_HOME"/bin/tomcat-juli.jar ]; then
  JAVA_OPTS="$JAVA_OPTS 
"-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager" "-
Djava.util.logging.config.file="$CATALINA_BASE/conf/logging.properties"
fi

If CATALINA_BASE has spaces, the shell splits JAVA_OPTS on the spaces when 
running the Java 
command line, causing the NCDFE.

2. I confirmed this by removing tomcat-juli.jar from bin, and tomcat started 
fine. This changed logging, 
so it wasn't a proper fix.

3. I was able to get things running, including logging, by making the following 
changes to catalina.sh

# Set juli LogManager if it is present
if [ -r "$CATALINA_HOME"/bin/tomcat-juli.jar ]; then
  JAVA_OPTS="$JAVA_OPTS 
-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager" 
  
LOGGING_CONFIG="-Djava.util.logging.config.file=$CATALINA_BASE/conf/logging.properties"
fi

and then adding "$LOGGING_CONFIG" (note the quotes) to all places where 
JAVA_OPTS is passed to the 
java command line. For example:

  exec "$_RUNJDB" $JAVA_OPTS "$LOGGING_CONFIG" $CATALINA_OPTS \

I'm not sure if this is the best way to fix this, but it works by keeping the 
spaces inside CATALINA_BASE 
within quotes when passing the arguments to the java command line.

4. The problem exists in the latest 5.5 (5.5.25) and 6.0 (6.0.14), but not in 
5.0.x.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 05:19 ---
Your patch contains a lot of style correction that makes difficult to see what
is really changed. Could please attach a patch without the style corrections?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21199|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 06:01 ---
(From update of attachment 21199)
Replacing patch with a new version


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 06:03 ---
Created an attachment (id=21205)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21205&action=view)
Patch implementing the proposed IO abstraction

New patch without all the reformattings.

Sorry, didn't remember all my Eclipse Save Actions ...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43995] New: - Sendfile thread uses 100% cpu for long periods

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43995

   Summary: Sendfile thread uses 100% cpu for long periods
   Product: Tomcat 5
   Version: 5.5.25
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:Integration
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Issue 42925 that was reported for Tomcat 6 also applies to Tomcat 5.5. When
using the Apache Portable Runtime, the sendfile thread can take 100% CPU load
when a poll descriptor time-out occurs. This happens because Poll.maintain() is
never called for the sendfile thread.

The proposed patch (http://issues.apache.org/bugzilla/attachment.cgi?id=20930)
can also be applied to Tomcat 5.5.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43995] - Sendfile thread uses 100% cpu for long periods

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43995





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 06:24 ---
Link to the original issue: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=42925

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

GHOP #23

[Vitezslav Smid]

Hello,
I've just claimed GHOP Issue #23 so I'm writing for more information.
How should the printer-friendly version look? Should it simply copy the
current layout?

I know CSS very well, but with XSLT I'm rather a beginner.


Vitezslav Smid
---
jabber:: [EMAIL PROTECTED]
www:: http://vitezslav-smid.net

Re: GHOP #23

[Yoav Shapira]

On Nov 29, 2007 12:33 PM, Vitezslav Smid <[EMAIL PROTECTED]> wrote:
> I've just claimed GHOP Issue #23 so I'm writing for more information.
> How should the printer-friendly version look? Should it simply copy the
> current layout?
>
> I know CSS very well, but with XSLT I'm rather a beginner.

Tim, I believe this was your idea.  Can you please share some details
with Vitezslav?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Our FAQ has been moved to the wiki...

[Yoav Shapira]

... at http://wiki.apache.org/tomcat/FAQ

I think it looks pretty good.  The question is, what's next: do we
(HTTP 301) redirect from tomcat.apache.org/FAQ to the wiki?

-- 
Thanks,

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43992] - Solve the problem

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43992


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 11:19 ---
Please don't use the Apache Bugzilla to experiment with. If you want to try it
out, it really isn't that hard to install your own copy.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43992] - Solve the problem

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43992


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: GHOP #23

[Tim Funk]

(I swamped with other projects this week)

Hopefully here is enough detail:

For the site
1) In site/trunk/xdocs/stylesheets/tomcat-site.xsl - this is the file to 
change.

Below

add
rel="stylesheet" media='printer'/>


2)
In tomcat-printer.css - add a style
.noPrint {display:none}

3) Back in site/trunk/xdocs/stylesheets/tomcat-site.xsl - sprinkle 
class='noPrint' as needed


---
For tomcat {version} its a little more involved. Preferably this is done 
on trunk.


There is some XSL to chuck in webapps/docs/tomcat-docs.xsl which has 
some if/else logic to decide when to hide stuff in printer freindly 
versions. Since those physical docs will go away - many of those if 
checks can go away and be altered with class='noPrint'


For example:


  LEFT SIDE NAVIGATION
  

  

Becomes:
LEFT SIDE NAVIGATION

  



Also in webapps/docs/build.xml there will be some code to trim out since 
 the style task doesn't need run additional times for printer friendly 
versions.



One gotcha about the style task, if you change the xsl file and re-run 
the build - typically nothing happens. You need to chuck the generated 
files (or touch the xml files)



I'll try to get more details this evening if I was too vague about the 
above.


-Tim

Yoav Shapira wrote:

On Nov 29, 2007 12:33 PM, Vitezslav Smid <[EMAIL PROTECTED]> wrote:

I've just claimed GHOP Issue #23 so I'm writing for more information.
How should the printer-friendly version look? Should it simply copy the
current layout?

I know CSS very well, but with XSLT I'm rather a beginner.


Tim, I believe this was your idea.  Can you please share some details
with Vitezslav?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599605 - /tomcat/trunk/java/org/apache/jasper/compiler/ErrorDispatcher.java

[markt]

Author: markt
Date: Thu Nov 29 14:27:23 2007
New Revision: 599605

URL: http://svn.apache.org/viewvc?rev=599605&view=rev
Log:
Fix bug 43757. Rather than use string matching to work out the line in the JSP 
with the error, use the SMAP info and the knowledge that for a scriptlet there 
is a one to one line mapping.

Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ErrorDispatcher.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/ErrorDispatcher.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/ErrorDispatcher.java?rev=599605&r1=599604&r2=599605&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/ErrorDispatcher.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/ErrorDispatcher.java Thu Nov 
29 14:27:23 2007
@@ -527,13 +527,26 @@
 page.visit(errVisitor);
 Node errNode = errVisitor.getJspSourceNode();
 if ((errNode != null) && (errNode.getStart() != null)) {
-javacError = new JavacErrorDetail(
-fname,
-lineNum,
-errNode.getStart().getFile(),
-errNode.getStart().getLineNumber(),
-errMsgBuf,
-ctxt);
+// If this is a scriplet node then there is a one to one mapping
+// between JSP lines and Java lines
+if (errVisitor.getJspSourceNode() instanceof Node.Scriptlet) {
+javacError = new JavacErrorDetail(
+fname,
+lineNum,
+errNode.getStart().getFile(),
+errNode.getStart().getLineNumber() + lineNum -
+errVisitor.getJspSourceNode().getBeginJavaLine(),
+errMsgBuf,
+ctxt);
+} else {
+javacError = new JavacErrorDetail(
+fname,
+lineNum,
+errNode.getStart().getFile(),
+errNode.getStart().getLineNumber(),
+errMsgBuf,
+ctxt);
+}
 } else {
 /*
  * javac error line number cannot be mapped to JSP page



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599606 - /tomcat/tc6.0.x/trunk/STATUS.txt

[markt]

Author: markt
Date: Thu Nov 29 14:30:29 2007
New Revision: 599606

URL: http://svn.apache.org/viewvc?rev=599606&view=rev
Log:
Propose fix for 43757

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=599606&r1=599605&r2=599606&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Nov 29 14:30:29 2007
@@ -52,3 +52,9 @@
   http://svn.apache.org/viewvc?rev=598800&view=rev
   +1: markt, jfclere, pero
   -1: 
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43757
+  Use SMAP info rather than string matching to ID line number in JSP
+  http://svn.apache.org/viewvc?rev=599605&view=rev
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599607 - /tomcat/current/tc5.5.x/STATUS.txt

[markt]

Author: markt
Date: Thu Nov 29 14:32:07 2007
New Revision: 599607

URL: http://svn.apache.org/viewvc?rev=599607&view=rev
Log:
Propose fix for 43757

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=599607&r1=599606&r2=599607&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Nov 29 14:32:07 2007
@@ -118,3 +118,9 @@
   http://svn.apache.org/viewvc?rev=595805&view=rev
   +1: markt, remm, fhanik, pero
   -1:
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43757
+  Use SMAP info rather than string matching to ID line number in JSP
+  http://svn.apache.org/viewvc?rev=599605&view=rev
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43757] - Improper parsing of response.sendRedirect() in JSP source

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43757





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 14:34 ---
On inspection this wasn't an SMAP problem with comments but an issue with how we
were finding the right JSP line given the Java line.

I have fixed it in trunk and proposed it for backport to 6.0.x and 5.5.x

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599608 - /tomcat/current/tc5.5.x/STATUS.txt

[markt]

Author: markt
Date: Thu Nov 29 14:34:24 2007
New Revision: 599608

URL: http://svn.apache.org/viewvc?rev=599608&view=rev
Log:
Remove dup

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=599608&r1=599607&r2=599608&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Nov 29 14:34:24 2007
@@ -84,11 +84,6 @@
   +1: markt
   -1:
 
-* Fix bug 43702. Inner classes have long names
-  http://svn.apache.org/viewvc?rev=595805&view=rev
-  +1: markt
-  -1:
-
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43887
   Include exception in log message
   http://svn.apache.org/viewvc?rev=597738&view=rev



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599610 - /tomcat/current/tc5.5.x/STATUS.txt

[markt]

Author: markt
Date: Thu Nov 29 14:42:47 2007
New Revision: 599610

URL: http://svn.apache.org/viewvc?rev=599610&view=rev
Log:
Votes

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=599610&r1=599609&r2=599610&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Nov 29 14:42:47 2007
@@ -49,17 +49,17 @@
 * JDT location return 404
   http://people.apache.org/~fhanik/patches/jdt-loc.patch
   Backport from Tomcat 6
-  +1: pero
+  +1: pero, markt
   -1: 
  
 * Fix NPE situation
   
http://people.apache.org/~pero/patches/tc55/2007-11-16-AccessLogValve-tc55.patch
-  +1: pero
+  +1: pero, markt
   -1:
 
 * Fix wrong && (Also needed at tomcat 6)
   
http://people.apache.org/~pero/patches/tc55/2007-11-16-1-ReplicationValve-tc55.patch
-  +1: pero
+  +1: pero, markt
   -1:
 
 * Fix  FarmWarDeployer can be only config at Host Element (Also needed at 
tomcat 6)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599616 - in /tomcat: container/tc5.5.x/webapps/docs/changelog.xml current/tc5.5.x/STATUS.txt jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Generator.java

[markt]

Author: markt
Date: Thu Nov 29 14:56:01 2007
New Revision: 599616

URL: http://svn.apache.org/viewvc?rev=599616&view=rev
Log:
Port fix for bug 43702. Reduce length of inner class names.

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
tomcat/current/tc5.5.x/STATUS.txt
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Generator.java

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=599616&r1=599615&r2=599616&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Thu Nov 29 14:56:01 2007
@@ -65,6 +65,14 @@

 
   
+  
+
+  
+43702: Reduce length of unnecessarily long class names for
+the inner helper class when using simple tags. (markt)
+  
+
+  
   
 
   

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=599616&r1=599615&r2=599616&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Nov 29 14:56:01 2007
@@ -108,12 +108,6 @@
   +1: markt
   -1: 
 
-* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43702
-  Inner class files have unnecessarily long names
-  http://svn.apache.org/viewvc?rev=595805&view=rev
-  +1: markt, remm, fhanik, pero
-  -1:
-
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43757
   Use SMAP info rather than string matching to ID line number in JSP
   http://svn.apache.org/viewvc?rev=599605&view=rev

Modified: 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Generator.java?rev=599616&r1=599615&r2=599616&view=diff
==
--- tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Generator.java 
(original)
+++ tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/Generator.java 
Thu Nov 29 14:56:01 2007
@@ -3253,8 +3253,7 @@
 charArrayBuffer = null;
 err = compiler.getErrorDispatcher();
 ctxt = compiler.getCompilationContext();
-fragmentHelperClass =
-new FragmentHelperClass(ctxt.getServletClassName() + "Helper");
+fragmentHelperClass = new FragmentHelperClass("Helper");
 pageInfo = compiler.getPageInfo();
 
 /*



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43702] - Class Files Have Unnecessarily Long Names when Using SimpleTags

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43702


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 14:56 ---
Fixed in svn for 5.5.x. Will be in 5.5.26 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599619 - /tomcat/current/tc5.5.x/STATUS.txt

[markt]

Author: markt
Date: Thu Nov 29 15:10:09 2007
New Revision: 599619

URL: http://svn.apache.org/viewvc?rev=599619&view=rev
Log:
Propose fix for 43995

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=599619&r1=599618&r2=599619&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Nov 29 15:10:09 2007
@@ -113,3 +113,10 @@
   http://svn.apache.org/viewvc?rev=599605&view=rev
   +1: markt
   -1:
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43995
+  Backport fix from TC6. Also fix memory leak
+  
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?view=diff&r1=583649&r2=583650&pathrev=583650
+  +1: markt
+  -1:
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42925] - Sendfile thread uses 100% cpu for long periods

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42925


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 15:12 ---
This was fixed in rev 583650.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43995] - Sendfile thread uses 100% cpu for long periods

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43995





--- Additional Comments From [EMAIL PROTECTED]  2007-11-29 15:13 ---
A port of the TC6 fix has been formerly proposed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r599676 - /tomcat/current/tc5.5.x/STATUS.txt

[billbarker]

Author: billbarker
Date: Thu Nov 29 18:36:15 2007
New Revision: 599676

URL: http://svn.apache.org/viewvc?rev=599676&view=rev
Log:
On Peter's request, propose fix for 43687 for backport

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=599676&r1=599675&r2=599676&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Thu Nov 29 18:36:15 2007
@@ -120,3 +120,8 @@
   +1: markt
   -1:
 
+* Remove conditional headers on Form Auth replay, since the UA (esp. FireFox) 
isn't expecting it.
+  http://issues.apache.org/bugzilla/show_bug.cgi?id=43687 (the patch for 5.5 
is the same as for 6.0)
+  +1: billbarker
+  -1:
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44000] New: - After Adding tomcat service and start tomcat service is using 50% CPU

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44000

   Summary: After Adding tomcat service and start tomcat service is
using 50% CPU
   Product: Tomcat 5
   Version: Unknown
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: major
  Priority: P4
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I am adding a tomcat service through Installer.For adding tomcat service I am 
doing nothing, From custom action just call one command line exe which is 
running "service.bat". After adding the service,I am starting tomcat service 
using command line application only. That exe uses "net start Tomcat5"  
command to run the service. Now after doing all these stpes using installer 
tomcat.exe often uses 50% CPU and even "Shutdown.bat" cannot stop the service. 
One need to manually kill the process.

I have tried to put some delay in adding service and starting the service but 
problem is still exists.. I am not able to figure out why this problem occure. 

Someone can give any guidline to resolve this.
Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]