svn commit: r598587 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread billbarker 
Author: billbarker
Date: Tue Nov 27 02:54:45 2007
New Revision: 598587

URL: http://svn.apache.org/viewvc?rev=598587&view=rev
Log:
Adding my objection

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598587&r1=598586&r2=598587&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 02:54:45 2007
@@ -50,7 +50,8 @@
 * Fix another license issue
   http://svn.apache.org/viewvc?rev=598412&view=rev
   +1: markt, fhanik, pero
-  -1: 
+  -1: billbarker  It is clear that simply making a copy doesn't release you 
from the original license.  
+  It is clear that Sun ownes the license on these files, and 
that will never change.  
   
 * Add get/set methods for properties in the Tcp Failure detector
   http://people.apache.org/~fhanik/patches/tcpfaildet-getset.patch



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r598587 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread William A. Rowe, Jr. 

Guys - this isn't how you use voting ... if there is an incorrectly
branded file in svn, it doesn't matter which branch it is on.

It's commit then review; review r598412 already, and either justify
it or revert the original change.  It's not subject to a backport
debate.  Citation of whatever justification exists to remove a
license/notice is absolutely mandatory in the svn commit history.


[EMAIL PROTECTED] wrote:

Author: billbarker
Date: Tue Nov 27 02:54:45 2007
New Revision: 598587

URL: http://svn.apache.org/viewvc?rev=598587&view=rev
Log:
Adding my objection

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598587&r1=598586&r2=598587&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 02:54:45 2007
@@ -50,7 +50,8 @@
 * Fix another license issue
   http://svn.apache.org/viewvc?rev=598412&view=rev
   +1: markt, fhanik, pero
-  -1: 
+  -1: billbarker  It is clear that simply making a copy doesn't release you from the original license.  
+  It is clear that Sun ownes the license on these files, and that will never change.  
   
 * Add get/set methods for properties in the Tcp Failure detector

   http://people.apache.org/~fhanik/patches/tcpfaildet-getset.patch



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598638 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread remm 
Author: remm
Date: Tue Nov 27 05:36:04 2007
New Revision: 598638

URL: http://svn.apache.org/viewvc?rev=598638&view=rev
Log:
- Votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598638&r1=598637&r2=598638&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 05:36:04 2007
@@ -33,23 +33,23 @@
 
 * WebDAV JavaDoc update as a result of bug 43893
   http://svn.apache.org/viewvc?rev=597719&view=rev
-  +1: markt, pero
+  +1: markt, pero, remm
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43887
   Include exception in log message
   http://svn.apache.org/viewvc?rev=597738&view=rev
-  +1: markt, pero
+  +1: markt, pero, remm
   -1:
 
 * Remove conditional headers on Form Auth replay, since the UA (esp. FireFox) 
isn't expecting it.
   http://issues.apache.org/bugzilla/show_bug.cgi?id=43687
-  +1: billbarker
+  +1: billbarker, remm
   -1:
 
 * Fix another license issue
   http://svn.apache.org/viewvc?rev=598412&view=rev
-  +1: markt, fhanik, pero
+  +1: markt, fhanik, pero, remm
   -1: billbarker  It is clear that simply making a copy doesn't release you 
from the original license.  
   It is clear that Sun ownes the license on these files, and 
that will never change.  
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r598587 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread Mark Thomas 
[EMAIL PROTECTED] wrote:
> Author: billbarker
> Date: Tue Nov 27 02:54:45 2007
> New Revision: 598587
> 
> URL: http://svn.apache.org/viewvc?rev=598587&view=rev
> Log:
> Adding my objection
> 
> Modified:
> tomcat/tc6.0.x/trunk/STATUS.txt
> 
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: 
> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598587&r1=598586&r2=598587&view=diff
> ==
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 02:54:45 2007
> @@ -50,7 +50,8 @@
>  * Fix another license issue
>http://svn.apache.org/viewvc?rev=598412&view=rev
>+1: markt, fhanik, pero
> -  -1: 
> +  -1: billbarker  It is clear that simply making a copy doesn't release you 
> from the original license.  
> +  It is clear that Sun ownes the license on these files, and 
> that will never change.

I should have put more info in the log messages although it is all there if
 you dig through the svn history.

The files in trunk (and therefore 6.0.x) were copied (but not using svn cp)
from /servletapi/servlet2.4-jsp2.0-tc5.x/

The history of the files in /servletapi/servlet2.4-jsp2.0-tc5.x/ shows that
they were first committed by a Sun employees (kinman), patches provided by
a second Sun employee (Mark Roth) and the AL2 license added by a third
(Jean-Francois). This took place over a period of 18 months.

I therefore concluded that the files were committed with Sun's knowledge
and consent and therefore came under kinman's and Jean-Francois' CLA which
means the Sun license just shouldn't be there.

I accept there is a small assumption on my part here. I will explicitly
forward this e-mail to Jean-Francois and ask for confirmation (to the dev
list) that the Sun text can be removed.

Assuming he confirms this, I'll include a link to his message in the 6.0.x
commit. If for some reason we can't remove the text then we can always fall
back to using the Geronimo ones or the CDDL ones.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

FW: Delays in mod_jk

2007-11-27 Thread Larry Reisler 
Rainer --

I recently changed replaced the version of JBOSS Web we were using to 
JBOSSWEB_2_0_0_GA_CP04.  It included several patches to the AJP code.  That 
appears to have solved the problem.  The FIN packets from the back end come 
back immediately now.  I'm guessing that the fix to JBPAPP-366 
(http://jira.jboss.org/jira/browse/JBPAPP-366) fixed this too.

I still see the mod_jk architecture as problematic -- it would be better if 
cleaning up the sockets would occur on a different thread and without the 
critical section locked.

Larry

-Original Message-
From: Larry Reisler [mailto:[EMAIL PROTECTED] 
Sent: Monday, November 26, 2007 10:08 AM
To: Rainer Jung; Tomcat Developers List
Subject: RE: Delays in mod_jk

Rainer --

I am using out of the box JBOSS 4.21 -- no special connector, and no firewall 
between the httpd tier and the other tier.

Indeed, I agree that the FIN packet from the back end is missing.  It seems to 
come much later in the dump (exactly 4 minutes later).  I can't help but think 
this is an issue on the JBOSS side, but I'm not sure where to go to try to 
debug that.

I will send you the full capture file separately by private Mail.

Larry


-Original Message-
From: Rainer Jung [mailto:[EMAIL PROTECTED] 
Sent: Sunday, November 25, 2007 4:35 PM
To: Tomcat Developers List
Subject: Re: Delays in mod_jk

Hi Larry,

I'm again investigating your problem report concerning 2 second pauses 
during socket shutdown in JK maintenance. Sorry for the long pause, but 
I want to see, if there is something we need to fix before 1.2.26 
related to this case.

I couldn't reproduce the behaviour on Linux. Do you use a special 
connector for AJP in JBoss, like Tomcats APR connector, or is it just 
the plain Coyote connector? Is there a firewall in between httpd and 
JBoss? If so, would it be possible to sniff again on both sides?

Larry Reisler wrote:
> I got a trace using some of the settings you have below.  I'm not
> quite sure how to get the whole thing to you, as it is fairly large,
> and I don't wish to post it to the mailing list.

If you like, you can send it by private Mail.

> In any event the relevant lines from one example of an interaction I
> am attaching below.  10.45.3.22 is the apache 2.2 server and
> 10.45.3.21 and 10.45.3.24 are the tomcat servers.  The trace was
> taken from the apache server.  There are numerous other examples of
> this type of interaction.
> 
> 02:49:04.329952 IP 10.45.3.22.34977 > 10.45.3.21.8009: F
> 2991069804:2991069804(0) ack 1909717451 win 8244  865633671 2700468480> 02:49:04.370343 IP 10.45.3.21.8009 >
> 10.45.3.22.34977: . ack 1 win 1448  865633671> 02:49:06.329558 IP 10.45.3.22.34972 > 10.45.3.24.8009: F
> 2991428814:2991428814(0) ack 330342931 win 4624  865635671 4202573488> 02:49:06.369533 IP 10.45.3.24.8009 >
> 10.45.3.22.34972: . ack 1 win 2269  865635671> 02:49:08.329843 IP 10.45.3.22.35008 > 10.45.3.24.8009: S
> 3372523679:3372523679(0) win 5840  865637671 0,nop,wscale 2> 02:49:08.329961 IP 10.45.3.24.8009 >
> 10.45.3.22.35008: S 707449532:707449532(0) ack 3372523680 win 5792
>  
> 02:49:08.329972 IP 10.45.3.22.35008 > 10.45.3.24.8009: . ack 1 win
> 1460  02:49:08.330001 IP
> 10.45.3.22.35008 > 10.45.3.24.8009: P 1:821(820) ack 1 win 1460
>  02:49:08.330023 IP
> 10.45.3.22.35008 > 10.45.3.24.8009: P 821:921(100) ack 1 win 1460
> 
> 
> My analysis of this is as follows: 1) A request comes in to the
> apache server, which has two timed out socket connections to the
> tomcat servers on ports 34977 and 34972.  At 02:49:04.329952 it sends
> a FIN packet to the tomcat server and receives a response at
> 02:49:04.370343.  It then waits two seconds from the time it sent the
> FIN packet. 2) At 02:49:06.329558 it sends a FIN packet to the other
> tomcat server and receives a response at 02:49:06.369533.  It then
> waits two seconds from the time it sent the FIN packet, and then
> creates a new socket (35008) on which it successfully sends the
> transaction.

The tcpdump excerpt seems to be incomplete. After the FIN and the 
accompanying ACK, the final FIN/ACK from the backend is missing. Does it 
occur later in the dump? If not, there should be a RST or the connection 
should still be in CLOSE_WAIT on the JBoss machine.

Regards,

Rainer

DO NOT REPLY [Bug 43841] - Tomcat 6.0.14 crashed at JDK 1.6.0_03

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43841


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 13:07 ---
That looks like a JVM bug to me. Bug reporting instructions are in included in
the crash report.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43929] - JSP POST SSI, JSP sub request does not complete

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43929


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 13:42 ---
I can not reproduce this with completely clean installs of:
 - Windows Server 2003 Ent, SP2 with latest pacthes
 - JDK 1.6.0_03
 - httpd 2.0.59 (no ssl binary installer)
 - Tomcat 5.5.25 (zip distribution)
 - mod_jk 1.2.25

All software installed on localhost using standard configuration.

I also tried your exact connector configuration and it all works as expected.

It looks like you have some other issue going on here. Could be configuration,
could be network / firewall related.

What ever it is Bugzilla isn't really suited to helping you track this down. I
suggest you try with a completely clean install and if you still have the
problem seek help on the users mailing list. If you can provide a set of steps
that reproduces the issue from a clean installation and you are as sure as you
can be that it is not related to your environment, please feel free to re-open
this bug and I'll take another look.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Skeleton javax.wsdl.* and javax.xml.rpc.*

2007-11-27 Thread Mark Thomas 
I recently created some skeleton implementations of the above packages to
stop Eclipse complaining all the time about not being able to compile the
entire TC6 source tree.

Is there any interest in adding them to trunk to join the other skeleton
classes in TC6?

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598783 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 14:05:57 2007
New Revision: 598783

URL: http://svn.apache.org/viewvc?rev=598783&view=rev
Log:
Fix bug 43706. Copy/move should return 201 if successful. Based on a patch by 
Panagiotis Astithas.

Modified:
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java

Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=598783&r1=598782&r2=598783&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Tue Nov 
27 14:05:57 2007
@@ -1729,6 +1729,9 @@
 
 }
 
+// Copy was successful
+resp.setStatus(WebdavStatus.SC_CREATED);
+
 // Removing any lock-null resource which would be present at
 // the destination path
 lockNullResources.remove(destinationPath);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598792 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 14:34:44 2007
New Revision: 598792

URL: http://svn.apache.org/viewvc?rev=598792&view=rev
Log:
Port rev 597719. Improved Javadocs for WebDAV servlet that make it clear it can 
not be used at the default Servlet

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598792&r1=598791&r2=598792&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 14:34:44 2007
@@ -31,11 +31,6 @@
   +1: jfclere
   -1: fhanik - Can we add the 'package' directive to make the package match 
the dir structure
 
-* WebDAV JavaDoc update as a result of bug 43893
-  http://svn.apache.org/viewvc?rev=597719&view=rev
-  +1: markt, pero, remm
-  -1:
-
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43887
   Include exception in log message
   http://svn.apache.org/viewvc?rev=597738&view=rev

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=598792&r1=598791&r2=598792&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java 
Tue Nov 27 14:34:44 2007
@@ -67,7 +67,49 @@
 
 /**
  * Servlet which adds support for WebDAV level 2. All the basic HTTP requests
- * are handled by the DefaultServlet.
+ * are handled by the DefaultServlet. The WebDAVServlet must not be used as the
+ * default servlet (ie mapped to '/') as it will not work in this 
configuration.
+ * To enable WebDAV for a context add the following to web.xml:
+ * 
+ *  webdav
+ *  
org.apache.catalina.servlets.WebdavServlet
+ *
+ *  debug
+ *  0
+ *
+ *
+ *  listings
+ *  true
+ *
+ *  
+ *  
+ *webdav
+ */*
+ *  
+ * 
+ * 
+ * This will enable read only access. To enable read-write access add:
+ * 
+ *
+ *  readonly
+ *  false
+ *
+ * 
+ * 
+ * To make the content editable via a different URL, using the following
+ * mapping:
+ * 
+ *  
+ *webdav
+ */webdavedit/*
+ *  
+ * 
+ * 
+ * Don't forget to secure access appropriately to the editing URLs. With this
+ * configuration the context will be accessible to normal users as before. 
Those
+ * users with the necessary access will be able to edit content available via
+ * http://host:port/context/content using
+ * http://host:port/context/webdavedit/content
  *
  * @author Remy Maucherat
  * @version $Revision$ $Date$
@@ -327,7 +369,6 @@
  * @param request The servlet request we are processing
  */
 protected String getRelativePath(HttpServletRequest request) {
-
 // Are we being processed by a RequestDispatcher.include()?
 if (request.getAttribute(Globals.INCLUDE_REQUEST_URI_ATTR) != null) {
 String result = (String) request.getAttribute(

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=598792&r1=598791&r2=598792&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Nov 27 14:34:44 2007
@@ -63,6 +63,10 @@
   
 Fix a bug that causes CGI Servlet to fail when it is included. (markt)
   
+  
+Improve the webDAV Servlet Javadocs to make clear that the WebDAV
+Servlet can not be used as the default servlet. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598788 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 14:27:13 2007
New Revision: 598788

URL: http://svn.apache.org/viewvc?rev=598788&view=rev
Log:
Add fix for 43706 and a note against Bill's veto.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598788&r1=598787&r2=598788&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 14:27:13 2007
@@ -51,9 +51,18 @@
   http://svn.apache.org/viewvc?rev=598412&view=rev
   +1: markt, fhanik, pero, remm
   -1: billbarker  It is clear that simply making a copy doesn't release you 
from the original license.  
-  It is clear that Sun ownes the license on these files, and 
that will never change.  
+  It is clear that Sun ownes the license on these files, and 
that will never change.
+  (markt) Agreed. However, I believe when originally commited 
these files were covered
+  by a CLA and the Sun text should never have been 
included. I am waiting for
+  confirmation of this from Sun before commit/revert.
   
 * Add get/set methods for properties in the Tcp Failure detector
   http://people.apache.org/~fhanik/patches/tcpfaildet-getset.patch
   +1: fhanik, pero
-  -1: 
\ No newline at end of file
+  -1: 
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43706
+  Copy/move should return 201
+  http://svn.apache.org/viewvc?rev=598783&view=rev
+  +1: markt
+  -1:
\ No newline at end of file



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598795 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/StandardWrapper.java webapps/docs/changelog.xml

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 14:43:49 2007
New Revision: 598795

URL: http://svn.apache.org/viewvc?rev=598795&view=rev
Log:
Port rev 597738. Fix 43887 with some improved error messages.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598795&r1=598794&r2=598795&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 14:43:49 2007
@@ -31,12 +31,6 @@
   +1: jfclere
   -1: fhanik - Can we add the 'package' directive to make the package match 
the dir structure
 
-* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43887
-  Include exception in log message
-  http://svn.apache.org/viewvc?rev=597738&view=rev
-  +1: markt, pero, remm
-  -1:
-
 * Remove conditional headers on Form Auth replay, since the UA (esp. FireFox) 
isn't expecting it.
   http://issues.apache.org/bugzilla/show_bug.cgi?id=43687
   +1: billbarker, remm

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=598795&r1=598794&r2=598795&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java Tue 
Nov 27 14:43:49 2007
@@ -1787,7 +1787,7 @@
 broadcaster.sendNotification(notification);
 }
 } catch( Exception ex ) {
-log.info("Error registering servlet with jmx " + this);
+log.info("Error registering servlet with jmx " + this, ex);
 }
 
 if (isJspServlet) {
@@ -1802,7 +1802,7 @@
 .registerComponent(instance, jspMonitorON, null);
 } catch( Exception ex ) {
 log.info("Error registering JSP monitoring with jmx " +
- instance);
+ instance, ex);
 }
 }
 }

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=598795&r1=598794&r2=598795&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Nov 27 14:43:49 2007
@@ -61,6 +61,11 @@
 43675: Fix a possible logging related classloader leak. 
(markt)
   
   
+43887: Make error messages much more helpful when illegal
+Servlet names are used. Based on a patch provided by Mike Baranczak.
+(markt)
+  
+  
 Fix a bug that causes CGI Servlet to fail when it is included. (markt)
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598801 - /tomcat/current/tc5.5.x/STATUS.txt

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 15:00:26 2007
New Revision: 598801

URL: http://svn.apache.org/viewvc?rev=598801&view=rev
Log:
Propose backport of fix for bug 43957

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=598801&r1=598800&r2=598801&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Tue Nov 27 15:00:26 2007
@@ -105,4 +105,10 @@
   and port the following:
   http://svn.apache.org/viewvc?rev=598412&view=rev
   +1: markt
-  -1:
\ No newline at end of file
+  -1:
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43957
+  Service.bat doesn't configure logging correctly
+  http://svn.apache.org/viewvc?rev=598800&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598802 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 15:00:51 2007
New Revision: 598802

URL: http://svn.apache.org/viewvc?rev=598802&view=rev
Log:
Propose backport of fix for bug 43957

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598802&r1=598801&r2=598802&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 15:00:51 2007
@@ -54,4 +54,10 @@
   Copy/move should return 201
   http://svn.apache.org/viewvc?rev=598783&view=rev
   +1: markt
-  -1:
\ No newline at end of file
+  -1:
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43957
+  Service.bat doesn't configure logging correctly
+  http://svn.apache.org/viewvc?rev=598800&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43957] - service.bat doesn't configure logging like the Windows installer

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43957





--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 15:01 ---
Fixed in trunk and proposed for back port for 6.0.x and 5.5.x.

Many thanks for the patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598804 - /tomcat/current/tc5.5.x/STATUS.txt

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 15:04:56 2007
New Revision: 598804

URL: http://svn.apache.org/viewvc?rev=598804&view=rev
Log:
Propose fix for bug 43702

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=598804&r1=598803&r2=598804&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Tue Nov 27 15:04:56 2007
@@ -112,3 +112,9 @@
   http://svn.apache.org/viewvc?rev=598800&view=rev
   +1: markt
   -1: 
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43702
+  Inner class files have unnecessarily long names
+  http://svn.apache.org/viewvc?rev=595805&view=rev
+  +1: markt, remm, fhanik, pero
+  -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43702] - Class Files Have Unnecessarily Long Names when Using SimpleTags

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43702





--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 15:04 ---
Fixed in trunk and 6.0.x. Proposed for 5.5.x.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43675] - Classloader leak in org.apache.tomcat.util.http.ServerCookie

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43675





--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 15:10 ---
Fixed in 6.0.x.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43887] - StandardWrapper.registerJMX() doesn't log exceptions correctly

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43887





--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 14:44 ---
Fixed in 6.0.x.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598800 - /tomcat/trunk/bin/service.bat

2007-11-27 Thread markt 
Author: markt
Date: Tue Nov 27 14:57:28 2007
New Revision: 598800

URL: http://svn.apache.org/viewvc?rev=598800&view=rev
Log:
Fix bug 43957. Service.bat doesn't configure logging correctly. Patch provided 
by  Richard Fearn.

Modified:
tomcat/trunk/bin/service.bat

Modified: tomcat/trunk/bin/service.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/service.bat?rev=598800&r1=598799&r2=598800&view=diff
==
--- tomcat/trunk/bin/service.bat (original)
+++ tomcat/trunk/bin/service.bat Tue Nov 27 14:57:28 2007
@@ -120,7 +120,7 @@
 set PR_LOGPATH=%CATALINA_BASE%\logs
 set PR_STDOUTPUT=auto
 set PR_STDERROR=auto
-"%EXECUTABLE%" //US//%SERVICE_NAME% ++JvmOptions 
"-Djava.io.tmpdir=%CATALINA_BASE%\temp" --JvmMs 128 --JvmMx 256
+"%EXECUTABLE%" //US//%SERVICE_NAME% ++JvmOptions 
"-Djava.io.tmpdir=%CATALINA_BASE%\temp;-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager;-Djava.util.logging.config.file=%CATALINA_BASE%\conf\logging.properties"
 --JvmMs 128 --JvmMx 256
 echo The service '%SERVICE_NAME%' has been installed.
 
 :end



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Skeleton javax.wsdl.* and javax.xml.rpc.*

2007-11-27 Thread Yoav Shapira 
On Nov 27, 2007 4:51 PM, Mark Thomas <[EMAIL PROTECTED]> wrote:
> I recently created some skeleton implementations of the above packages to
> stop Eclipse complaining all the time about not being able to compile the
> entire TC6 source tree.
>
> Is there any interest in adding them to trunk to join the other skeleton
> classes in TC6?

I'm interested, +1.


Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Skeleton javax.wsdl.* and javax.xml.rpc.*

2007-11-27 Thread Filip Hanik - Dev Lists 

I don't think our source tree contents should reflect IDE usage.
in my IDE, I just simply create a filter about what I dont want to be 
compiled each time.


Filip

Mark Thomas wrote:

I recently created some skeleton implementations of the above packages to
stop Eclipse complaining all the time about not being able to compile the
entire TC6 source tree.

Is there any interest in adding them to trunk to join the other skeleton
classes in TC6?

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43979] New: - Add abstraction for Java and Classfile output

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979

   Summary: Add abstraction for Java and Classfile output
   Product: Tomcat 6
   Version: 6.0.14
  Platform: Other
OS/Version: other
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In the incubating project Sling, we are using Jasper to compile JSP scripts
which are located in a JCR repository (e.g. Apache Jackrabbit). This may
perfectly be done using a customized ServletContext.

Likewise we would like to store the generated Java source files as well as the
generated class files in the same repository for later consumption. By storing
the Java and class files in the repository, we are able to remotely inspect the
java files in case of spurious issues or to remove the generated files
alltogether during development. In addition, we are thinking of distributing
generated class files between repositories in distributed or staged 
environments.

Upto now we have been working on a private patched version of Jasper 5.5.20, but
are not able to keep up with more recent Jasper releases. So we wonder whether
it would be possible to include this functionality into the Jasper release.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43979] - Add abstraction for Java and Classfile output

2007-11-27 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43979





--- Additional Comments From [EMAIL PROTECTED]  2007-11-27 16:54 ---
Created an attachment (id=21199)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21199&action=view)
Patch implementing the proposed IO abstraction

Appending a patch implementing the proposal of abstracting the output. The
abstraction also contains an input case, which replaces several uses of File
for reading in Jasper.

Finally, this patch also fixes a minor inconvenience, where classloaders are
cast to URLClassLoader without type checking thus potentially throwing
ClassCastExceptions.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r598851 - /tomcat/tc6.0.x/trunk/STATUS.txt

2007-11-27 Thread billbarker 
Author: billbarker
Date: Tue Nov 27 18:10:33 2007
New Revision: 598851

URL: http://svn.apache.org/viewvc?rev=598851&view=rev
Log:
withdrawing my objection

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=598851&r1=598850&r2=598851&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Nov 27 18:10:33 2007
@@ -38,13 +38,9 @@
 
 * Fix another license issue
   http://svn.apache.org/viewvc?rev=598412&view=rev
-  +1: markt, fhanik, pero, remm
-  -1: billbarker  It is clear that simply making a copy doesn't release you 
from the original license.  
-  It is clear that Sun ownes the license on these files, and 
that will never change.
-  (markt) Agreed. However, I believe when originally commited 
these files were covered
-  by a CLA and the Sun text should never have been 
included. I am waiting for
-  confirmation of this from Sun before commit/revert.
-  
+  +1: markt, fhanik, pero, remm, billbarker 
+  -1: 
+
 * Add get/set methods for properties in the Tcp Failure detector
   http://people.apache.org/~fhanik/patches/tcpfaildet-getset.patch
   +1: fhanik, pero



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Bootstrap redirecting stdout/err via system.set

2007-11-27 Thread William L. Thomson Jr. 
Recently on Gentoo I was looking to improve how we start Tomcat.
Specifically how we capture stdout/stderr output from Tomcat on start
and redirect it to catalina.out. Presently due to our use of
start-stop-daemon and some issues it comes with. We are using the normal
redirection to capture the output. >> catalina.out 2>&1

In getting feedback to alternatives to our present approach, like that
suggested in comment #5 on the following bug[1]. Another inquired as to
why Tomcat wasn't capturing and redirecting it's own stdout/stderr via
system properties?

Like how .home and .base are set now.

public void setCatalinaHome(String s) {
System.setProperty( "catalina.home", s );
}
public void setCatalinaBase(String s) {
System.setProperty( "catalina.base", s );
}

Which would alleviate the need to capture and redirect that stuff
externally of Tomcat. Is there a reason this is not currently done? Has
this approach been considered before? Something like 

System.setOut(aPrintStream);
System.setErr(aPrintStream);

Where the location would be configurable via a var or etc with a default
specified.

Basically others are suggesting I write a wrapper class or etc to
Bootstrap to set those properties there. I guess we could do that on
Gentoo. But would like to get upstreams input there. Much less I would
likely patch Bootstrap before wrapping it.


http://bugs.gentoo.org/show_bug.cgi?id=162379

-- 
William L. Thomson Jr.
Gentoo/Java


signature.asc
Description: This is a digitally signed message part