New Tomcat release? Out of the box bundle with Harmony?

[Alexey Petrenko]

Hey.

I'm working on Apache Harmony [1] which is J2SE implementation.

I want to suggest you to create Tomcat out of the box bundle on top of Harmony.
I've created such a bundle with the previous Harmony milestone release
[2]. It works but has areas for improvements... For example it's
possible to remove debug info from Harmony which is not needed in such
a bundle.

What do you think? Is such bundle interesting for Tomcat?

Thanks in advance.

SY, Alexey

[1] http://harmony.apache.org/
[2] http://harmony.apache.org/bundles.html

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r593171 - /tomcat/tc6.0.x/trunk/STATUS

[jfclere]

Author: jfclere
Date: Thu Nov  8 06:38:54 2007
New Revision: 593171

URL: http://svn.apache.org/viewvc?rev=593171&view=rev
Log:
Cast my vote.

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=593171&r1=593170&r2=593171&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Thu Nov  8 06:38:54 2007
@@ -47,7 +47,7 @@
   +1: markt
   -1:
 
-* Fix cookie $Version parsing
+* Fix cookie $Version parsing 
   Index: java/org/apache/tomcat/util/http/Cookies.java
   ===
   --- java/org/apache/tomcat/util/http/Cookies.java(revision 589807)
@@ -62,5 +62,5 @@
} else {
// unknown version (Versioning is not very strict)
   
- +1: fhanik
- -1: 
\ No newline at end of file
+ +1: fhanik, jfclere
+ -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tomcat release? Out of the box bundle with Harmony?

[Yoav Shapira]

Hey,

On Nov 8, 2007 9:10 AM, Alexey Petrenko <[EMAIL PROTECTED]> wrote:
> I want to suggest you to create Tomcat out of the box bundle on top of 
> Harmony.
> I've created such a bundle with the previous Harmony milestone release
> [2]. It works but has areas for improvements... For example it's
> possible to remove debug info from Harmony which is not needed in such
> a bundle.
>
> What do you think? Is such bundle interesting for Tomcat?

Personally, I want to move the Tomcat downloads in a simpler
direction, removing options not adding them.  So I'm not in favor of
various bundles and combinations.

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tomcat release? Out of the box bundle with Harmony?

[Costin Manolache]

On Nov 8, 2007 6:15 AM, Yoav Shapira <[EMAIL PROTECTED]> wrote:

> Hey,
>
> On Nov 8, 2007 9:10 AM, Alexey Petrenko <[EMAIL PROTECTED]>
> wrote:
> > I want to suggest you to create Tomcat out of the box bundle on top of
> Harmony.
> > I've created such a bundle with the previous Harmony milestone release
> > [2]. It works but has areas for improvements... For example it's
> > possible to remove debug info from Harmony which is not needed in such
> > a bundle.
> >
> > What do you think? Is such bundle interesting for Tomcat?
>
> Personally, I want to move the Tomcat downloads in a simpler
> direction, removing options not adding them.  So I'm not in favor of
> various bundles and combinations.
>
> Yoav


On the other side - it may be a good thing to have a 'all apache java
software' bundle, or to bundle tomcat with harmony ( but on harmony side ).

I agree tomcat should go to less options and bundles.


Costin



>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

svn commit: r593173 - /tomcat/tc6.0.x/trunk/STATUS

[jfclere]

Author: jfclere
Date: Thu Nov  8 06:41:50 2007
New Revision: 593173

URL: http://svn.apache.org/viewvc?rev=593173&view=rev
Log:
Add another proposal.

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=593173&r1=593172&r2=593173&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Thu Nov  8 06:41:50 2007
@@ -64,3 +64,7 @@
   
  +1: fhanik, jfclere
  -1:
+
+* Fix double quoting of quoted-string. 
http://people.apache.org/~jfclere/patches/cookies.tck.patch
+  +1: jfclere
+  -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r593238 - /tomcat/tc6.0.x/trunk/STATUS

[fhanik]

Author: fhanik
Date: Thu Nov  8 09:53:25 2007
New Revision: 593238

URL: http://svn.apache.org/viewvc?rev=593238&view=rev
Log:
2nd Patch includes the first, so combine them

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=593238&r1=593237&r2=593238&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Thu Nov  8 09:53:25 2007
@@ -47,24 +47,7 @@
   +1: markt
   -1:
 
-* Fix cookie $Version parsing 
-  Index: java/org/apache/tomcat/util/http/Cookies.java
-  ===
-  --- java/org/apache/tomcat/util/http/Cookies.java(revision 589807)
-  +++ java/org/apache/tomcat/util/http/Cookies.java(working copy)
-  @@ -487,7 +487,7 @@
-   if (equals( "Version", bytes, nameStart, nameEnd) && 
-   sc == null) {
-   // Set version
-  -if( bytes[valueStart] =='1' && valueEnd == valueStart) {
-  +if( bytes[valueStart] =='1' && valueEnd == 
(valueStart+1)) {
-   version=1;
-   } else {
-   // unknown version (Versioning is not very strict)
-  
- +1: fhanik, jfclere
- -1:
-
 * Fix double quoting of quoted-string. 
http://people.apache.org/~jfclere/patches/cookies.tck.patch
-  +1: jfclere
+  and $Version parsing
+  +1: jfclere, fhanik
   -1:



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tomcat release? Out of the box bundle with Harmony?

[Peter Rossbach]

Hi Alexey,

I think it is a great idea to bundle harmony with tomcat. Ok, I also  
agree with Yoav and Costin that bundle building and hosting is  
harmony team job.
How can I help you to made the harmony/tomcat bundle ready? But I am  
working at a Mac and I am very interested to get a java 6  up and  
running:-(


Regards
Peter


Am 08.11.2007 um 15:10 schrieb Alexey Petrenko:


Hey.

I'm working on Apache Harmony [1] which is J2SE implementation.

I want to suggest you to create Tomcat out of the box bundle on top  
of Harmony.

I've created such a bundle with the previous Harmony milestone release
[2]. It works but has areas for improvements... For example it's
possible to remove debug info from Harmony which is not needed in such
a bundle.

What do you think? Is such bundle interesting for Tomcat?

Thanks in advance.

SY, Alexey

[1] http://harmony.apache.org/
[2] http://harmony.apache.org/bundles.html

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tomcat release? Out of the box bundle with Harmony?

[Preston L. Bannister]

Yes, any such bundle should be under Harmony, not Tomcat.

Speaking as an application developer, the (outside?) chance that a customer
could go to download Tomcat, and end up with Harmony - this does not make me
happy.  At least until I have a *lot* more confidence in Harmony.  Tomcat is
expected to be mature and reliable.

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Lucas Galfaso]

Is CDDL Apache compatible?



On Nov 8, 2007 8:15 PM,  <[EMAIL PROTECTED]> wrote:
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> .
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
> INSERTED IN THE BUG DATABASE.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=43819
>
>
> [EMAIL PROTECTED] changed:
>
>What|Removed |Added
> 
>  CC||[EMAIL PROTECTED]
>
>
>
>
>
> --
> Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> --- You are receiving this mail because: ---
> You are the assignee for the bug, or are watching the assignee.
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21097|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2007-11-08 15:27 ---
(From update of attachment 21097)
CDDL is not compatible with AL2 for source code.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2007-11-08 14:52 ---
Created an attachment (id=21097)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21097&action=view)
Patch to make EL self-contained

Added patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] New: - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819

   Summary: Support latest JSR245 proposal to make EL "self-
contained"
   Product: Tomcat 6
   Version: 6.0.14
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Please add the two static methods ExpressionFactory.newInstance(..) as described
in http://jcp.org/aboutJava/communityprocess/maintenance/jsr245/245-MR1.html.
These changes make the EL "self-contained" and allow to plug-in third party EL
implementations like JUEL (http://juel.sf.net).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Mark Thomas]

Filip Hanik - Dev Lists wrote:
> I believe (and correct me if I am wrong) that Apache software may
> include the binary distribution of CDDL code.

Correct.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Filip Hanik - Dev Lists]

I believe (and correct me if I am wrong) that Apache software may 
include the binary distribution of CDDL code.


Filip

Lucas Galfaso wrote:

Is CDDL Apache compatible?



On Nov 8, 2007 8:15 PM,  <[EMAIL PROTECTED]> wrote:
  

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]





--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Filip Hanik - Dev Lists]

Filip Hanik - Dev Lists wrote:

Mark Thomas wrote:

Filip Hanik - Dev Lists wrote:
 

Mark Thomas wrote:
   

Filip Hanik - Dev Lists wrote:
 
 

Mark Thomas wrote:
  

jean-frederic clere wrote:
  

and we are re escaping already escaped strings.


The spec isn't 100% clear on who is responsible for escaping the
values if
required.


... The value can be anything the server chooses to send. ...


...
setValue(String)
  

what j-f-c is saying here, is that if there is a value of
Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;

when it is being parsed, it double escapes it
Path="\\"/foo/bar\\""


I get that ;)

What I was trying (not very well) to say was I don't think the spec is
clear whether we should escape everything, regardless of if it 
looks like
it is already escaped. I am in favour of the current behaviour 
because:

a) the spec isn't clear but I think it is leaning in the escape
everything
direction

b) I don't like the complexity of adding an "is this value already
escaped"
function. I think we would be setting ourselves up for another 
round of

cookie handling bugs.


the spec says

  A string of text is parsed as a single word if it is quoted using
  double-quote marks.

  quoted-string  = ( <"> *(qdtext | quoted-pair ) <"> )
  qdtext = >

  The backslash character ("\") MAY be used as a single-character
  quoting mechanism only within quoted-string and comment constructs.

  quoted-pair= "\" CHAR

now I have to digest that :) and will comment some more.



Isn't that the http spec rather than the servlet spec?
  
absolutely. there is no syntax definition for HTTP header (and cookies 
being such) in the servlet spec

to be more specific, it might still be broken.


Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;
results in
Set-Cookie: C1=C1; Version=1; Domain=d1; Path="\\"/foo/bar\\""

this is invalid syntax, cause \ only escapes one character, and " is not 
allowed within "" value



with 6.0.15
Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;
results in
Set-Cookie: C1=C1; Domain=d1; Path=\"/foo/bar\"

This is also invalid, since we parsed it wrong. the actual value for 
path is "/foo/bar" with the quotes,


btw, all my test JSP is doing is response.addCookie for each cookie 
found in request.getCookies, without modifying them


Filip





Filip

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tomcat release? Out of the box bundle with Harmony?

[Preston L. Bannister]

On Nov 8, 2007 12:59 PM, Henri Gomez <[EMAIL PROTECTED]> wrote:

> 2007/11/8, Preston L. Bannister <[EMAIL PROTECTED]>:
> > Yes, any such bundle should be under Harmony, not Tomcat.
>
> Why not Tomcat ?
>

If you are looking at Harmony, you are (or should be) expecting something
experimental.


> Speaking as an application developer, the (outside?) chance that a
> customer
> > could go to download Tomcat, and end up with Harmony - this does not
> make me
> > happy.  At least until I have a *lot* more confidence in Harmony.
>  Tomcat is
> > expected to be mature and reliable.
>
> If you're confident in Tomcat ,so a 'bundled' Harmoy/Tomcat will help
> Harmony team fix failures in the Java Runtime you could detect.
>

Sadly, I have no interest in testing Harmony.  Thanks for the offer, but my
plate is already far too full.  Nor am I interested in my customers testing
Harmony, for pretty much the same reason.

Pragmatically, as a web application developer, the Sun JVM is free for my
customers, which eliminates any interest (aside from theoretical) in
non-Sun, maybe-sorta-kinda-mostly working, and non-performant JVMs.  Sun is
doing a good job, looks to continue to do so, and seems generally to have a
clue about not screwing customers.  Good enough.

Flip this around - who *does* have a pragmatic interest in testing and
development of an open-source JVM?  That should suggest a venue.

Re: [VOTE] Release build 6.0.15

[Mark Thomas]

Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> Filip Hanik - Dev Lists wrote:
>>  
>>> Mark Thomas wrote:
>>>
 jean-frederic clere wrote:
  
> and we are re escaping already escaped strings.
> 
 The spec isn't 100% clear on who is responsible for escaping the
 values if
 required.

 
 ... The value can be anything the server chooses to send. ...
 
 
 ...
 setValue(String)
 
>>> what j-f-c is saying here, is that if there is a value of
>>> Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;
>>>
>>> when it is being parsed, it double escapes it
>>> Path="\\"/foo/bar\\""
>>> 
>>
>> I get that ;)
>>
>> What I was trying (not very well) to say was I don't think the spec is
>> clear whether we should escape everything, regardless of if it looks like
>> it is already escaped. I am in favour of the current behaviour because:
>> a) the spec isn't clear but I think it is leaning in the escape
>> everything
>> direction
>>
>> b) I don't like the complexity of adding an "is this value already
>> escaped"
>> function. I think we would be setting ourselves up for another round of
>> cookie handling bugs.
>>   
> the spec says
> 
>   A string of text is parsed as a single word if it is quoted using
>   double-quote marks.
> 
>   quoted-string  = ( <"> *(qdtext | quoted-pair ) <"> )
>   qdtext = >
> 
>   The backslash character ("\") MAY be used as a single-character
>   quoting mechanism only within quoted-string and comment constructs.
> 
>   quoted-pair= "\" CHAR
> 
> now I have to digest that :) and will comment some more.

Isn't that the http spec rather than the servlet spec?

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Tomcat release? Out of the box bundle with Harmony?

[Henri Gomez]

2007/11/8, Preston L. Bannister <[EMAIL PROTECTED]>:
> Yes, any such bundle should be under Harmony, not Tomcat.

Why not Tomcat ?

> Speaking as an application developer, the (outside?) chance that a customer
> could go to download Tomcat, and end up with Harmony - this does not make me
> happy.  At least until I have a *lot* more confidence in Harmony.  Tomcat is
> expected to be mature and reliable.

If you're confident in Tomcat ,so a 'bundled' Harmoy/Tomcat will help
Harmony team fix failures in the Java Runtime you could detect.

BTW, Harmony people, may I suggest you be to contact the JPackage team
(www.jpackage.org).

They bundle in RPM format major Java applications for Linux boxes and
having an OSS JRE/JDK like Harmony will be very usefull to them.

Regards and long life to Harmony and others Java Opened implementations :)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Mark Thomas]

Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> jean-frederic clere wrote:
>>> and we are re escaping already escaped strings.
>>> 
>> The spec isn't 100% clear on who is responsible for escaping the
>> values if
>> required.
>>
>> 
>> ... The value can be anything the server chooses to send. ...
>> 
>> 
>> ...
>> setValue(String)
>>   
> what j-f-c is saying here, is that if there is a value of
> Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;
> 
> when it is being parsed, it double escapes it
> Path="\\"/foo/bar\\""

I get that ;)

What I was trying (not very well) to say was I don't think the spec is
clear whether we should escape everything, regardless of if it looks like
it is already escaped. I am in favour of the current behaviour because:
a) the spec isn't clear but I think it is leaning in the escape everything
direction

b) I don't like the complexity of adding an "is this value already escaped"
function. I think we would be setting ourselves up for another round of
cookie handling bugs.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Mark Thomas]

Lucas Galfaso wrote:
> Is CDDL Apache compatible?

Not for java source, no. See http://people.apache.org/~rubys/3party.html

We can't use this patch.

Mark

> 
> 
> 
> On Nov 8, 2007 8:15 PM,  <[EMAIL PROTECTED]> wrote:
>> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
>> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
>> .
>> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
>> INSERTED IN THE BUG DATABASE.
>>
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=43819
>>
>>
>> [EMAIL PROTECTED] changed:
>>
>>What|Removed |Added
>> 
>>  CC||[EMAIL PROTECTED]
>>
>>
>>
>>
>>
>> --
>> Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
>> --- You are receiving this mail because: ---
>> You are the assignee for the bug, or are watching the assignee.
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Filip Hanik - Dev Lists]

Mark Thomas wrote:

Filip Hanik - Dev Lists wrote:
  

Mark Thomas wrote:


jean-frederic clere wrote:
  

and we are re escaping already escaped strings.



The spec isn't 100% clear on who is responsible for escaping the
values if
required.


... The value can be anything the server chooses to send. ...


...
setValue(String)
  
  

what j-f-c is saying here, is that if there is a value of
Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;

when it is being parsed, it double escapes it
Path="\\"/foo/bar\\""



I get that ;)

What I was trying (not very well) to say was I don't think the spec is
clear whether we should escape everything, regardless of if it looks like
it is already escaped. I am in favour of the current behaviour because:
a) the spec isn't clear but I think it is leaning in the escape everything
direction

b) I don't like the complexity of adding an "is this value already escaped"
function. I think we would be setting ourselves up for another round of
cookie handling bugs.
  

the spec says

  A string of text is parsed as a single word if it is quoted using
  double-quote marks.

  quoted-string  = ( <"> *(qdtext | quoted-pair ) <"> )
  qdtext = >

  The backslash character ("\") MAY be used as a single-character
  quoting mechanism only within quoted-string and comment constructs.

  quoted-pair= "\" CHAR

now I have to digest that :) and will comment some more.
Filip


Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r593264 - /tomcat/tc6.0.x/trunk/STATUS

[markt]

Author: markt
Date: Thu Nov  8 11:18:07 2007
New Revision: 593264

URL: http://svn.apache.org/viewvc?rev=593264&view=rev
Log:
Add vote on cookie patch

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=593264&r1=593263&r2=593264&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Thu Nov  8 11:18:07 2007
@@ -50,4 +50,5 @@
 * Fix double quoting of quoted-string. 
http://people.apache.org/~jfclere/patches/cookies.tck.patch
   and $Version parsing
   +1: jfclere, fhanik
-  -1:
+  -1: markt - only the double quoting part - see 
http://marc.info/?l=tomcat-dev&m=119454915422424&w=2 for reasons
+



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r593270 - /tomcat/tc6.0.x/trunk/STATUS

[pero]

Author: pero
Date: Thu Nov  8 11:37:59 2007
New Revision: 593270

URL: http://svn.apache.org/viewvc?rev=593270&view=rev
Log:
add my vote

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=593270&r1=593269&r2=593270&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Thu Nov  8 11:37:59 2007
@@ -49,6 +49,6 @@
 
 * Fix double quoting of quoted-string. 
http://people.apache.org/~jfclere/patches/cookies.tck.patch
   and $Version parsing
-  +1: jfclere, fhanik
+  +1: jfclere, fhanik, pero
   -1: markt - only the double quoting part - see 
http://marc.info/?l=tomcat-dev&m=119454915422424&w=2 for reasons
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Filip Hanik - Dev Lists]

Mark Thomas wrote:

Filip Hanik - Dev Lists wrote:
  

Mark Thomas wrote:


Filip Hanik - Dev Lists wrote:
 
  

Mark Thomas wrote:
   


jean-frederic clere wrote:
 
  

and we are re escaping already escaped strings.



The spec isn't 100% clear on who is responsible for escaping the
values if
required.


... The value can be anything the server chooses to send. ...


...
setValue(String)

  

what j-f-c is saying here, is that if there is a value of
Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;

when it is being parsed, it double escapes it
Path="\\"/foo/bar\\""



I get that ;)

What I was trying (not very well) to say was I don't think the spec is
clear whether we should escape everything, regardless of if it looks like
it is already escaped. I am in favour of the current behaviour because:
a) the spec isn't clear but I think it is leaning in the escape
everything
direction

b) I don't like the complexity of adding an "is this value already
escaped"
function. I think we would be setting ourselves up for another round of
cookie handling bugs.
  
  

the spec says

  A string of text is parsed as a single word if it is quoted using
  double-quote marks.

  quoted-string  = ( <"> *(qdtext | quoted-pair ) <"> )
  qdtext = >

  The backslash character ("\") MAY be used as a single-character
  quoting mechanism only within quoted-string and comment constructs.

  quoted-pair= "\" CHAR

now I have to digest that :) and will comment some more.



Isn't that the http spec rather than the servlet spec?
  
absolutely. there is no syntax definition for HTTP header (and cookies 
being such) in the servlet spec


Filip

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r593356 - /tomcat/tc6.0.x/trunk/STATUS

[fhanik]

Author: fhanik
Date: Thu Nov  8 15:32:52 2007
New Revision: 593356

URL: http://svn.apache.org/viewvc?rev=593356&view=rev
Log:
change vote, still couldn't get the tests through

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=593356&r1=593355&r2=593356&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Thu Nov  8 15:32:52 2007
@@ -49,6 +49,7 @@
 
 * Fix double quoting of quoted-string. 
http://people.apache.org/~jfclere/patches/cookies.tck.patch
   and $Version parsing
-  +1: jfclere, fhanik, pero
+  +1: jfclere, pero
   -1: markt - only the double quoting part - see 
http://marc.info/?l=tomcat-dev&m=119454915422424&w=2 for reasons
+  -1: fhanik - I still think it needs some work, will discuss on dev list
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43821] New: - provide client AJP IP address

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43821

   Summary: provide client AJP IP address
   Product: Tomcat 5
   Version: Unknown
  Platform: All
OS/Version: other
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Connector:AJP
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Methods getRemoteAddr() and getRemoteHost() provide real user information, but
information about AJP client (AJP connection peer) has to be accessible if
possible. It would be nice to access it in some request.getAttribute(). It must
be accessible independent of ForwardLocalAddress mod_jk option (and it even
exposes web-server address it listens on, not address from which connection to
AJP connector was made).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]