DO NOT REPLY [Bug 43805] New: - NullPointerException at Ctrl-Break shutdown

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43805

   Summary: NullPointerException at Ctrl-Break shutdown
   Product: Tomcat 6
   Version: 6.0.0
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P3
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Here's stack trace:
java.lang.NullPointerException
at org.apache.juli.FileHandler.publish(FileHandler.java:139)
at java.util.logging.Logger.log(Logger.java:452)
at java.util.logging.Logger.doLog(Logger.java:474)
at java.util.logging.Logger.logp(Logger.java:590)
at org.apache.commons.logging.impl.Jdk14Logger.log(Jdk14Logger.java:91)
at org.apache.commons.logging.impl.Jdk14Logger.info
(Jdk14Logger.java:162)
at org.apache.coyote.http11.Http11BaseProtocol.pause
(Http11BaseProtocol.java:168)
at org.apache.catalina.connector.Connector.pause(Connector.java:1032)
at org.apache.catalina.core.StandardService.stop
(StandardService.java:489)
at org.apache.catalina.core.StandardServer.stop(StandardServer.java:734)
at org.apache.catalina.startup.Catalina.stop(Catalina.java:602)
at org.apache.catalina.startup.Catalina$CatalinaShutdownHook.run
(Catalina.java:645)

This problem occurs very offen (almost every time) when I shut tomcat down after
execution of stress-tests for the product being developed by our team.

OS: Windows XP Pro;
Tomcat: 5.5.23 and 6.0.14;
JDK: SUN J2SE 1.5.0_12-b04;

I have investigated source-codes and figured out, that this could happen 
because of simultenious execution of shutdown-hook of J2SE's 
java.util.logging.LogManager and stopping process of Tomcat's juli.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Filip Hanik - Dev Lists]

the problem is beyond that as well.

for the header

Cookie: name1=value1; Version=1; Path="/testcookies"

The cookie parsing mechanism adds 3 server cookies, one for each header 
value, the end result is still one valid cookie, when the request 
creates javax.servlet.http.Cookie object, since the latter two throw 
illegal argument exception.


however, the parsing is quite broken, let me know if you want me to 
provide a fix, or if you are already into it


Filip


jean-frederic clere wrote:

Filip Hanik - Dev Lists wrote:
  

I'm having problems with the cookie parsing




It is seems there are 2 problems... The version (only TCK will complain)
and we are re escaping already escaped strings. I will prepare a patch
later today.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Filip Hanik - Dev Lists]

ignore the invalid cookie header, I was mocking around too much, I'm 
still looking into the parsing a bit


Filip

Filip Hanik - Dev Lists wrote:

the problem is beyond that as well.

for the header

Cookie: name1=value1; Version=1; Path="/testcookies"

The cookie parsing mechanism adds 3 server cookies, one for each 
header value, the end result is still one valid cookie, when the 
request creates javax.servlet.http.Cookie object, since the latter two 
throw illegal argument exception.


however, the parsing is quite broken, let me know if you want me to 
provide a fix, or if you are already into it


Filip


jean-frederic clere wrote:

Filip Hanik - Dev Lists wrote:
 

I'm having problems with the cookie parsing




It is seems there are 2 problems... The version (only TCK will complain)
and we are re escaping already escaped strings. I will prepare a patch
later today.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43501] - Automatic reload not possible for webapplications in user directories

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43501


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[jean-frederic clere]

Filip Hanik - Dev Lists wrote:
> I'm having problems with the cookie parsing
> 

It is seems there are 2 problems... The version (only TCK will complain)
and we are re escaping already escaped strings. I will prepare a patch
later today.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Time to organise svn - Take 4

[Jim Jagielski]

On Nov 6, 2007, at 7:37 PM, Rémy Maucherat wrote:


On Sun, 2007-11-04 at 16:10 +, Mark Thomas wrote:
Do the (unless there is a pressing need - eg a major security  
issue) final

stable release of 6.0.x.
Freeze development of the 6.0.x branch.


-1. Branches should continue to be open as long as committers want to
propose patches and make releases.



+1


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Mark Thomas]

jean-frederic clere wrote:
> Filip Hanik - Dev Lists wrote:
>> I'm having problems with the cookie parsing
>>
> It is seems there are 2 problems... The version (only TCK will complain)
Haven't looked at this

> and we are re escaping already escaped strings.
The spec isn't 100% clear on who is responsible for escaping the values if
required.


... The value can be anything the server chooses to send. ...


...
setValue(String)
...
With Version 0 cookies, values should not contain white space, brackets,
parentheses, equals signs, commas, double quotes, slashes, question marks,
at signs, colons, and semicolons. Empty values may not behave the same way
on all browsers.
...


This suggests to me that the webapp writer can set what they like for a
version 1 cookie and it is the server's responsibility to escape it.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r592920 - /tomcat/tc6.0.x/trunk/STATUS

[fhanik]

Author: fhanik
Date: Wed Nov  7 14:01:25 2007
New Revision: 592920

URL: http://svn.apache.org/viewvc?rev=592920&view=rev
Log:
Added proposed fix for version number fix

Modified:
tomcat/tc6.0.x/trunk/STATUS

Modified: tomcat/tc6.0.x/trunk/STATUS
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=592920&r1=592919&r2=592920&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS (original)
+++ tomcat/tc6.0.x/trunk/STATUS Wed Nov  7 14:01:25 2007
@@ -46,4 +46,21 @@
   http://people.apache.org/~markt/patches/2007-10-30-Bug43675.patch
   +1: markt
   -1:
-  
\ No newline at end of file
+
+* Fix cookie $Version parsing
+  Index: java/org/apache/tomcat/util/http/Cookies.java
+  ===
+  --- java/org/apache/tomcat/util/http/Cookies.java(revision 589807)
+  +++ java/org/apache/tomcat/util/http/Cookies.java(working copy)
+  @@ -487,7 +487,7 @@
+   if (equals( "Version", bytes, nameStart, nameEnd) && 
+   sc == null) {
+   // Set version
+  -if( bytes[valueStart] =='1' && valueEnd == valueStart) {
+  +if( bytes[valueStart] =='1' && valueEnd == 
(valueStart+1)) {
+   version=1;
+   } else {
+   // unknown version (Versioning is not very strict)
+  
+ +1: fhanik
+ -1: 
\ No newline at end of file



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.15

[Filip Hanik - Dev Lists]

Mark Thomas wrote:

jean-frederic clere wrote:
  

Filip Hanik - Dev Lists wrote:


I'm having problems with the cookie parsing

  

It is seems there are 2 problems... The version (only TCK will complain)


Haven't looked at this
  
yes, this is a bug, the version number will never be anything but 0 for 
any parsed cookie.
should that stop a release? I think 6.0.15 is very stable, and long 
needed bug fixes, I'll let Remy as the release manager make the call 
unless someone feels otherwise



  

and we are re escaping already escaped strings.


The spec isn't 100% clear on who is responsible for escaping the values if
required.


... The value can be anything the server chooses to send. ...


...
setValue(String)
  

what j-f-c is saying here, is that if there is a value of
Cookie: $Version=1; C1=C1;$Path="\"/foo/bar\"";$Domain=d1;

when it is being parsed, it double escapes it
Path="\\"/foo/bar\\""

Filip


...
With Version 0 cookies, values should not contain white space, brackets,
parentheses, equals signs, commas, double quotes, slashes, question marks,
at signs, colons, and semicolons. Empty values may not behave the same way
on all browsers.
...


This suggests to me that the webapp writer can set what they like for a
version 1 cookie and it is the server's responsibility to escape it.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]