DO NOT REPLY [Bug 43129] New: - Support logging of response headers

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43129

   Summary: Support logging of response headers
   Product: Tomcat 5
   Version: Unknown
  Platform: Other
OS/Version: other
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


According to http://tomcat.apache.org/tomcat-5.0-doc/config/valve.html the
access log format supports "%{xxx}i for incoming headers", but there is no
corresponding "%{xxx}o for outgoing headers". This is however supported by
Apache HTTPD, see http://httpd.apache.org/docs/1.3/mod/mod_log_config.html, so
this complicates porting configurations a bit.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r566170 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

[fhanik]

Author: fhanik
Date: Wed Aug 15 07:06:45 2007
New Revision: 566170

URL: http://svn.apache.org/viewvc?view=rev&rev=566170
Log:
Set the interval in a distributed env, patch by Takayuki Kaneko


Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?view=diff&rev=566170&r1=566169&r2=566170
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Wed Aug 
15 07:06:45 2007
@@ -256,6 +256,9 @@
 
 

+public void setMaxInactiveInterval(int interval) {
+this.setMaxInactiveInterval(interval,true);
+}
 public void setMaxInactiveInterval(int interval, boolean addDeltaRequest) {
 super.maxInactiveInterval = interval;
 if (isValid && interval == 0) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r566174 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

[fhanik]

Author: fhanik
Date: Wed Aug 15 07:07:38 2007
New Revision: 566174

URL: http://svn.apache.org/viewvc?view=rev&rev=566174
Log:
backport from trunk

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?view=diff&rev=566174&r1=566173&r2=566174
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/DeltaSession.java 
Wed Aug 15 07:07:38 2007
@@ -256,6 +256,9 @@
 
 

+public void setMaxInactiveInterval(int interval) {
+this.setMaxInactiveInterval(interval,true);
+}
 public void setMaxInactiveInterval(int interval, boolean addDeltaRequest) {
 super.maxInactiveInterval = interval;
 if (isValid && interval == 0) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Filip Hanik - Dev Lists]

this should have been done in trunk, way too big change for a minor dot 
release upgrade
I suggest we move it there, revert in 6.0, and if it works well in 
trunk, we backport


Filip

[EMAIL PROTECTED] wrote:

Author: remm
Date: Mon Aug 13 11:13:47 2007
New Revision: 565464

URL: http://svn.apache.org/viewvc?view=rev&rev=565464
Log:
- Experiment with reporting warnings for unmatched elements and attributes, 
based on Bill's ideas.
- The NIO HTTP protocol handler does not seem very reporting friendly at the 
moment.
- The change should be rather safe, if it causes problems that cannot be fixed 
easily I will revert it.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Embedded.java

tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/SetAllPropertiesRule.java

tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/SetContextPropertiesRule.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java

tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/SetPropertiesRule.java

tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/SetPropertyRule.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java?view=diff&rev=565464&r1=565463&r2=565464
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java Mon 
Aug 13 11:13:47 2007
@@ -318,6 +318,20 @@
 if (replacements.get(name) != null) {
 repl = (String) replacements.get(name);
 }
+if (!IntrospectionUtils.setProperty(protocolHandler, repl, value)) {
+log.warn("Property " + name + " not found on the protocol 
handler.");
+}
+}
+
+
+/**
+ * Set a configured property.
+ */
+public void setPropertyInternal(String name, String value) {
+String repl = name;
+if (replacements.get(name) != null) {
+repl = (String) replacements.get(name);
+}
 IntrospectionUtils.setProperty(protocolHandler, repl, value);
 }
 
@@ -388,7 +402,7 @@

 public void setAllowTrace(boolean allowTrace) {
 
 this.allowTrace = allowTrace;

-setProperty("allowTrace", String.valueOf(allowTrace));
+setPropertyInternal("allowTrace", String.valueOf(allowTrace));
 
 }
 
@@ -466,7 +480,7 @@

 public void setEmptySessionPath(boolean emptySessionPath) {
 
 this.emptySessionPath = emptySessionPath;

-setProperty("emptySessionPath", String.valueOf(emptySessionPath));
+setPropertyInternal("emptySessionPath", 
String.valueOf(emptySessionPath));
 
 }
 
@@ -489,7 +503,7 @@

 public void setEnableLookups(boolean enableLookups) {
 
 this.enableLookups = enableLookups;

-setProperty("enableLookups", String.valueOf(enableLookups));
+setPropertyInternal("enableLookups", String.valueOf(enableLookups));
 
 }
 
@@ -559,7 +573,7 @@

 public void setMaxSavePostSize(int maxSavePostSize) {
 
 this.maxSavePostSize = maxSavePostSize;

-setProperty("maxSavePostSize", String.valueOf(maxSavePostSize));
+setPropertyInternal("maxSavePostSize", 
String.valueOf(maxSavePostSize));
 }
 
 
@@ -581,7 +595,7 @@

 public void setPort(int port) {
 
 this.port = port;

-setProperty("port", String.valueOf(port));
+setPropertyInternal("port", String.valueOf(port));
 
 }
 
@@ -745,7 +759,7 @@
 
 if(proxyName != null && proxyName.length() > 0) {

 this.proxyName = proxyName;
-setProperty("proxyName", proxyName);
+setPropertyInternal("proxyName", proxyName);
 } else {
 this.proxyName = null;
 removeProperty("proxyName");
@@ -772,7 +786,7 @@
 public void setProxyPort(int proxyPort) {
 
 this.proxyPort = proxyPort;

-setProperty("proxyPort", String.valueOf(proxyPort));
+setPropertyInternal("proxyPort", String.valueOf(proxyPort));
 
 }
 
@@ -797,7 +811,7 @@

 public void setRedirectPort(int redirectPort) {
 
 this.redirectPort = redirectPort;

-setProperty("redirectPort", String.valueOf(redirectPort));
+setPropertyInternal("redirectPort", String.valueOf(re

Re: svn commit: r565964 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11: InternalNioInputBuffer.java InternalNioOutputBuffer.java

[Filip Hanik - Dev Lists]

I believe the same problem exists on the APR connector

it is the Http11AprProcessor.event doesn't call nextRequest() like the 
process method does
hence filters don't get reset, and this affects regular future HTTP 
requests as well


Filip

[EMAIL PROTECTED] wrote:

Author: fhanik
Date: Tue Aug 14 16:03:52 2007
New Revision: 565964

URL: http://svn.apache.org/viewvc?view=rev&rev=565964
Log:
backport from trunk

Modified:

tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java

tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java?view=diff&rev=565964&r1=565963&r2=565964
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java 
Tue Aug 14 16:03:52 2007
@@ -294,6 +294,10 @@
  * connection.
  */
 public void recycle() {
+// Recycle filters
+for (int i = 0; i <= lastActiveFilter; i++) {
+activeFilters[i].recycle();
+}
 
 // Recycle Request object

 request.recycle();

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?view=diff&rev=565964&r1=565963&r2=565964
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java 
Tue Aug 14 16:03:52 2007
@@ -333,6 +333,10 @@
  * connection.
  */
 public void recycle() {
+// Recycle filters
+for (int i = 0; i <= lastActiveFilter; i++) {
+activeFilters[i].recycle();
+}
 
 // Recycle Request object

 response.recycle();



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Remy Maucherat]

Filip Hanik - Dev Lists wrote:
this should have been done in trunk, way too big change for a minor dot 
release upgrade
I suggest we move it there, revert in 6.0, and if it works well in 
trunk, we backport


Personally, I will not be working in trunk, which is your toy branch. I 
considered this change to be appropriate to be committed in 6.0.x. Are 
you vetoing this commit ?


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565964 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11: InternalNioInputBuffer.java InternalNioOutputBuffer.java

[Remy Maucherat]

Filip Hanik - Dev Lists wrote:

I believe the same problem exists on the APR connector

it is the Http11AprProcessor.event doesn't call nextRequest() like the 
process method does
hence filters don't get reset, and this affects regular future HTTP 
requests as well


Yes, there is a similar recycling glitch.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Tim Funk]

I thought changes were going into trunk and then when applicable, 
backported to 6.0.x.


Since this change is only writing warning messages. It seems appropriate 
that it can remain in 6.0.x.


-Tim

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
this should have been done in trunk, way too big change for a minor 
dot release upgrade
I suggest we move it there, revert in 6.0, and if it works well in 
trunk, we backport


Personally, I will not be working in trunk, which is your toy branch. I 
considered this change to be appropriate to be committed in 6.0.x. Are 
you vetoing this commit ?




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Remy Maucherat]

Tim Funk wrote:
I thought changes were going into trunk and then when applicable, 
backported to 6.0.x.


While I initiated the creation of the trunk branch, I can no longer work 
with Filip since I disagree with him on API design, and I don't like his 
ideas on collaboration. As a result, I do not wish to participate in 
trunk development, and I have to do my development activities elsewhere 
:( I now think removing the trunk branch or moving it to the sandbox 
would be best.


Since this change is only writing warning messages. It seems appropriate 
that it can remain in 6.0.x.


Yes, it should only display warnings, but if we display bad warnings in 
a stable release, we'll get zillions of angry users. So it's important 
to get it right. I committed this in the 6.0.x branch since I don't have 
any other sensible place to commit it.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r566237 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

[remm]

Author: remm
Date: Wed Aug 15 08:59:28 2007
New Revision: 566237

URL: http://svn.apache.org/viewvc?view=rev&rev=566237
Log:
- Fix recycling glitch. I prefer using nextRequest although it's a bit slower, 
since it's identical to regular request
  processing.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?view=diff&rev=566237&r1=566236&r2=566237
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java 
Wed Aug 15 08:59:28 2007
@@ -750,9 +750,13 @@
 rp.setStage(org.apache.coyote.Constants.STAGE_ENDED);
 
 if (error) {
+inputBuffer.nextRequest();
+outputBuffer.nextRequest();
 recycle();
 return SocketState.CLOSED;
 } else if (!comet) {
+inputBuffer.nextRequest();
+outputBuffer.nextRequest();
 recycle();
 return SocketState.OPEN;
 } else {
@@ -905,6 +909,8 @@
 
 if (comet) {
 if (error) {
+inputBuffer.nextRequest();
+outputBuffer.nextRequest();
 recycle();
 return SocketState.CLOSED;
 } else {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Filip Hanik - Dev Lists]

Remy Maucherat wrote:

Tim Funk wrote:
I thought changes were going into trunk and then when applicable, 
backported to 6.0.x.


While I initiated the creation of the trunk branch, I can no longer 
work with Filip since I disagree with him on API design, and I don't 
like his ideas on collaboration. As a result, I do not wish to 
participate in trunk development, and I have to do my development 
activities elsewhere :( 

it's community development, you can participate or not. That's your call.
You've threatened to start other branches elsewhere, you've threatened 
to leave, you can keep threatening, if the community is strong enough it 
will survive. If it is not, then it will fall, just like Rome did.
 I now think removing the trunk branch or moving it to the sandbox 
would be best.
I'm gonna propose for trunk to stay, we specifically made that cause you 
decided changes the Geronimo team needed were not appropriate.

And there are other changes that have gone in there since then.


Since this change is only writing warning messages. It seems 
appropriate that it can remain in 6.0.x.


Yes, it should only display warnings, but if we display bad warnings 
in a stable release, we'll get zillions of angry users. 

right up your ally ;)
So it's important to get it right. I committed this in the 6.0.x 
branch since I don't have any other sensible place to commit it.


it not backwards compatible, that's why 6.0 would be inappropriate for 
such a change


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r566319 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml webapps/docs/config/valve.xml

[pero]

Author: pero
Date: Wed Aug 15 13:01:27 2007
New Revision: 566319

URL: http://svn.apache.org/viewvc?view=rev&rev=566319
Log:
Support logging of response headers at AccessLogValve (ex. add %{Set-Cookie}o 
to your pattern)

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
tomcat/container/tc5.5.x/webapps/docs/config/valve.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java?view=diff&rev=566319&r1=566318&r2=566319
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
 Wed Aug 15 13:01:27 2007
@@ -90,6 +90,7 @@
  * It is modeled after the apache syntax:
  * 
  * %{xxx}i for incoming headers
+ * %{xxx}o for outgoing headers
  * %{xxx}c for a specific cookie
  * %{xxx}r xxx is an attribute in the ServletRequest
  * %{xxx}s xxx is an attribute in the HttpSession
@@ -105,6 +106,7 @@
  *
  * @author Craig R. McClanahan
  * @author Jason Brittain
+ * @author Peter Rossbach
  * @version $Revision$ $Date$
  */
 
@@ -924,11 +926,22 @@
 else
 value= "??";
 break;
-/*
-// Someone please make me work
 case 'o':
+if (null != response) {
+String[] values = response.getHeaderValues(header);
+if(values.length > 0) {
+StringBuffer buf = new StringBuffer() ;
+for (int i = 0; i < values.length; i++) {
+String string = values[i];
+buf.append(string) ;
+if(i+1http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=566319&r1=566318&r2=566319
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Wed Aug 15 13:01:27 2007
@@ -80,6 +80,9 @@
   
 Improve large-file support (more then 4 Gb) at all AccessLogValves. 
(pero)
   
+  
+43129: Support logging of response headers at 
AccessLogValve (ex. add %{Set-Cookie}o to your pattern). (pero)
+  
 
   
   

Modified: tomcat/container/tc5.5.x/webapps/docs/config/valve.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/config/valve.xml?view=diff&rev=566319&r1=566318&r2=566319
==
--- tomcat/container/tc5.5.x/webapps/docs/config/valve.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/config/valve.xml Wed Aug 15 13:01:27 
2007
@@ -180,11 +180,12 @@
 
 
 There is also support to write information from the cookie, incoming
-header, the Session or something else in the ServletRequest.
+header, outgoing response headers, the Session or something else in the 
ServletRequest.
 It is modeled after the apache syntax:
 
-%{xxx}i for incoming headers
-%{xxx}c for a specific cookie
+%{xxx}i for incoming request headers
+%{xxx}o for outgoing response headers
+%{xxx}c for a specific request cookie
 %{xxx}r xxx is an attribute in the 
ServletRequest
 %{xxx}s xxx is an attribute in the HttpSession
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43129] - Support logging of response headers

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43129


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-08-15 13:07 ---
Look at  Revision: 566319 at tomcat 5.5.x trunk and give my fix a try :-)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Remy Maucherat]

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Tim Funk wrote:
I thought changes were going into trunk and then when applicable, 
backported to 6.0.x.


While I initiated the creation of the trunk branch, I can no longer 
work with Filip since I disagree with him on API design, and I don't 
like his ideas on collaboration. As a result, I do not wish to 
participate in trunk development, and I have to do my development 
activities elsewhere :( 

it's community development, you can participate or not. That's your call.
You've threatened to start other branches elsewhere, you've threatened 
to leave, you can keep threatening, if the community is strong enough it 
will survive. If it is not, then it will fall, just like Rome did.


No, trunk is Filip's development, and that's it. I've been working 
elsewhere since I had no other choice, and I regret there is no way to 
collaborate. ASF projects cannot go anywhere if two parties are in 
constant opposition, so basically one of us needs to go away for the 
project to move forward.


 I now think removing the trunk branch or moving it to the sandbox 
would be best.
I'm gonna propose for trunk to stay, we specifically made that cause you 
decided changes the Geronimo team needed were not appropriate.

And there are other changes that have gone in there since then.


Maybe switching to a tigher patch inclusion process like what is done in 
httpd, and reboot trunk, could be a solution. As you may have noticed, I 
disagreed with all your Comet related commits, and you never cared in 
any way. This would have avoided the initial divide.


Unless I missed something, the patch which Geronimo needs is API 
incompatible with Tomcat 6.0.x, and external projects are already using 
the said API for integration with Tomcat, so I don't see a way to do it. 
Let me know if I missed something.


Since this change is only writing warning messages. It seems 
appropriate that it can remain in 6.0.x.


Yes, it should only display warnings, but if we display bad warnings 
in a stable release, we'll get zillions of angry users. 

right up your ally ;)


Huh ?

So it's important to get it right. I committed this in the 6.0.x 
branch since I don't have any other sensible place to commit it.


it not backwards compatible, that's why 6.0 would be inappropriate for 
such a change


Feel free to veto the patch and then revert it if you think it's 
inappropriate.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43127] - Tomcat's windows service doesn't start up when run in guest OS in MS Virtual Server

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43127





--- Additional Comments From [EMAIL PROTECTED]  2007-08-15 15:19 ---
The log is taken for an Atlassian application, which uses a customized Tomcat
installer to install the service. Exactly the same output is in the Tomcat's 
log file.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r565464 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ catalina/startup/ coyote/ajp/ coyote/http11/ tomcat/util/ tomcat/util/digester/

[Bill Barker]

"Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message 
news:[EMAIL PROTECTED]
> this should have been done in trunk, way too big change for a minor dot 
> release upgrade
> I suggest we move it there, revert in 6.0, and if it works well in trunk, 
> we backport
>

Tomcat has never made any promise that the core API won't 
change between versions.  If you depend on the Tomcat API at any version 
level, then you are required to review at the next level.  Therefore, I'm 
officially voting -1 (veto) on your suggestion.  Remy's patch is useful, and 
if any minor bugs are found, easily fixed.

> Filip
>
> [EMAIL PROTECTED] wrote:
>> Author: remm
>> Date: Mon Aug 13 11:13:47 2007
>> New Revision: 565464
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=565464
>> Log:
>> - Experiment with reporting warnings for unmatched elements and 
>> attributes, based on Bill's ideas.
>> - The NIO HTTP protocol handler does not seem very reporting friendly at 
>> the moment.
>> - The change should be rather safe, if it causes problems that cannot be 
>> fixed easily I will revert it.
>>
>> Modified:
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Embedded.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/SetAllPropertiesRule.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/SetContextPropertiesRule.java
>> tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java
>> tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11Protocol.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/Digester.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/SetPropertiesRule.java
>> 
>> tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/digester/SetPropertyRule.java
>>
>> Modified: 
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java?view=diff&rev=565464&r1=565463&r2=565464
>> ==
>> ---  
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java 
>> (original)
>> +++ 
>> tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java 
>> Mon Aug 13 11:13:47 2007
>> @@ -318,6 +318,20 @@
>>  if (replacements.get(name) != null) {
>>  repl = (String) replacements.get(name);
>>  }
>> +if (!IntrospectionUtils.setProperty(protocolHandler, repl, 
>> value)) {
>> +log.warn("Property " + name + " not found on the protocol 
>> handler.");
>> +}
>> +}
>> +
>> +
>> +/**
>> + * Set a configured property.
>> + */
>> +public void setPropertyInternal(String name, String value) {
>> +String repl = name;
>> +if (replacements.get(name) != null) {
>> +repl = (String) replacements.get(name);
>> +}
>>  IntrospectionUtils.setProperty(protocolHandler, repl, value);
>>  }
>>  @@ -388,7 +402,7 @@
>>  public void setAllowTrace(boolean allowTrace) {
>>  this.allowTrace = allowTrace;
>> -setProperty("allowTrace", String.valueOf(allowTrace));
>> +setPropertyInternal("allowTrace", String.valueOf(allowTrace));
>>  }
>>  @@ -466,7 +480,7 @@
>>  public void setEmptySessionPath(boolean emptySessionPath) {
>>  this.emptySessionPath = emptySessionPath;
>> -setProperty("emptySessionPath", 
>> String.valueOf(emptySessionPath));
>> +setPropertyInternal("emptySessionPath", 
>> String.valueOf(emptySessionPath));
>>  }
>>  @@ -489,7 +503,7 @@
>>  public void setEnableLookups(boolean enableLookups) {
>>  this.enableLookups = enableLookups;
>> -setProperty("enableLookups", String.valueOf(enableLookups));
>> +setPropertyInternal("enableLookups", 
>> String.valueOf(enableLookups));
>>  }
>>  @@ -559,7 +573,7 @@
>>  public void setMaxSavePostSize(int maxSavePostSize) {
>>  this.maxSavePostSize = maxSavePostSize;
>> -setProperty("maxSavePostSize", String.valueOf(maxSavePostSize));
>> +setPropertyInternal("maxSavePostSize", 
>> String.valueOf(maxSavePostSize));
>>  }
>>  @@ -581,7 +595,7 @@
>>  public void setPort(int port) {
>>  this.port = port;
>> -setProperty("port", String.valueOf(port));
>> +setPropertyInternal("port", String.valueOf(port));
>>  }
>>  @@ -745,7 +759,7 @@
>>  if(proxyName != null && proxyName.length() > 0) {
>>  this.proxyName = proxyName;
>> -setProperty("proxyName", proxyName);
>> +setPropertyIn