Re: mod_jk 1.2.24 withdrawal?

[Guenter Knauf]

Hi,
> I agree. Remove 1.2.24 and include all the patches.
> Let's roll that ASAP.
+1, same oppinion here.

Guen.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43020] - Tomcat always tries to install as service on Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43020





--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 06:10 ---
OK - so I was simply mislead by the terse "Service" (or whatever the checkbox 
was labeled with) to believe, that this would NOT install a service, if 
unchecked. Thanks for clarifing this!

BTW: how about separating this into TWO checkboxes, one labeled e.g. "register 
as service" and an indented "sub-checkbox" labeled "automatically start with 
the system", i.e. something like:

...
[ ] register as service
[ ] automatically start this service when system boots.
...
Ideally, the indented checkbox would only be accessible, if the parent is 
deselected, i.e. grayed out, if the register is deselected.

And, in that latter case (i.e. if the user deselected the "register..." 
option) then install that startup.bat file to /bin instead. 

Or frankly, I don't really see, why one could not install that startup.bat 
*always*. If the user has stopped or disabled the service, but still wants to 
start tomcat temporarily by hand, (s)he could use that startup.bat.

At least *I* would find that very handy for testing! :-)

Michael


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43020] - Tomcat always tries to install as service on Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43020


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 04:53 ---
This is by design.

The installer has been updated to make is clearer what the checkbox actually
means which is "do you want this service to start automatically when windows
starts" rather than what it previously suggested "do you want to install a
Tomcat service"

This fix will be in the next 5.5.x release.

If you want to install multiple instances, use the zip. It includes service.bat
which can be used to add multiple services with different names.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Juli/Logging

[Len Popp]

OK, that's a useful compromise that makes log files easier to deal with.

Suggestion: If the timestamp appeared on the first line of the stack
trace (in addition to the preceding error message line), it would be
easier to search a log file for an exception, say
"OutOfMemoryException", and then locate that line in the file to see
the rest of the info. For example:

2-Aug-2007 9:41:28 PM SEVERE: Servlet.service() for servlet Test threw exception
2-Aug-2007 9:41:28 PM java.lang.OutOfMemoryError
at com.example.app.Test.testGenerateException(Test.java:115)
at com.example.app.Test.doGet(Test.java:35)
  [etc.]

-- 
Len

On 8/3/07, Rainer Jung <[EMAIL PROTECTED]> wrote:
> Stacks are always special. It's usually unfeasible to push them into one
> line. My argument was about usual log messages. Of course in a fully
> fledged new formatter, one would wish things like configuring the depth
> of the stack printed.
>
> Len Popp wrote:
> > On 7/31/07, Rainer Jung <[EMAIL PROTECTED]> wrote:
> >> My personal opinion: java.util.logging very much lacks a good formatter.
> >> The default 2 line formatting of messages, splitting timestamps and
> >> message in separate lines, is not really useful in production. Many ad
> >> hoc log analysis practices work on a line oriented basis.
> >
> > How would exception stack traces be handled? That's an important
> > consideration because a stack trace is the first thing people ask for
> > when someone has a problem. :-)
> > I like the idea of one line per entry, but stack traces don't seem to
> > fit into that format. If you collapse a stack trace onto one line,
> > it's a lot harder to read. If you keep the multi-line format for stack
> > traces, you keep the same problem with log analysis practices that
> > work on a line oriented basis.
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r562478 - in /tomcat/connectors/trunk/jni: java/org/apache/tomcat/jni/Socket.java native/include/tcn_version.h native/os/win32/libtcnative.rc native/src/network.c

[mturk]

Author: mturk
Date: Fri Aug  3 07:33:51 2007
New Revision: 562478

URL: http://svn.apache.org/viewvc?view=rev&rev=562478
Log:
Add two new 'immediate' methods for sending the data.
It is the responsibility of the Java callee to deal with
the returned values and retry if the error was non-fatal.

Modified:
tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java
tomcat/connectors/trunk/jni/native/include/tcn_version.h
tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java?view=diff&rev=562478&r1=562477&r2=562478
==
--- tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java 
(original)
+++ tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java Fri Aug  
3 07:33:51 2007
@@ -241,11 +241,42 @@
  */
 public static native int sendb(long sock, ByteBuffer buf,
int offset, int len);
+
+/**
+ * Send data over a network without retry
+ * 
+ * This functions acts like a blocking write by default.  To change
+ * this behavior, use apr_socket_timeout_set() or the APR_SO_NONBLOCK
+ * socket option.
+ *
+ * It is possible for both bytes to be sent and an error to be returned.
+ *
+ * 
+ * @param sock The socket to send the data over.
+ * @param buf The Byte buffer which contains the data to be sent.
+ * @param offset The offset within the buffer array of the first buffer 
from
+ *   which bytes are to be retrieved; must be non-negative
+ *   and no larger than buf.length
+ * @param len The maximum number of buffers to be accessed; must be 
non-negative
+ *and no larger than buf.length - offset
+ * @return The number of bytes send.
+ *
+ */
+public static native int sendib(long sock, ByteBuffer buf,
+int offset, int len);
+
 /**
  * Send data over a network using internally set ByteBuffer
  */
 public static native int sendbb(long sock,
int offset, int len);
+
+/**
+ * Send data over a network using internally set ByteBuffer
+ * without internal retry.
+ */
+public static native int sendibb(long sock,
+ int offset, int len);
 
 /**
  * Send multiple packets of data over a network.

Modified: tomcat/connectors/trunk/jni/native/include/tcn_version.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/include/tcn_version.h?view=diff&rev=562478&r1=562477&r2=562478
==
--- tomcat/connectors/trunk/jni/native/include/tcn_version.h (original)
+++ tomcat/connectors/trunk/jni/native/include/tcn_version.h Fri Aug  3 
07:33:51 2007
@@ -69,7 +69,7 @@
 #define TCN_MINOR_VERSION   1
 
 /** patch level */
-#define TCN_PATCH_VERSION   11
+#define TCN_PATCH_VERSION   12
 
 /**
  *  This symbol is defined for internal, "development" copies of TCN. This

Modified: tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc?view=diff&rev=562478&r1=562477&r2=562478
==
--- tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc (original)
+++ tomcat/connectors/trunk/jni/native/os/win32/libtcnative.rc Fri Aug  3 
07:33:51 2007
@@ -3,7 +3,7 @@
 LANGUAGE 0x9,0x1
 1 11 logmessages.bin
 
-#define TCN_COPYRIGHT "Copyright 2000-2006 The Apache Software " \
+#define TCN_COPYRIGHT "Copyright 2000-2007 The Apache Software " \
   "Foundation or its licensors, as applicable."
 
 #define TCN_LICENSE "Licensed under the Apache License, Version 2.0 " \
@@ -19,7 +19,7 @@
 "specific language governing permissions and " \
 "limitations under the License."
 
-#define TCN_VERISON "1.1.11"
+#define TCN_VERISON "1.1.12"
 1000 ICON "apache.ico"
 
 1001 DIALOGEX 0, 0, 252, 51
@@ -35,8 +35,8 @@
 END
 
 1 VERSIONINFO
- FILEVERSION 1,1,11,0
- PRODUCTVERSION 1,1,11,0
+ FILEVERSION 1,1,12,0
+ PRODUCTVERSION 1,1,12,0
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?view=diff&rev=562478&r1=562477&r2=562478
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Fri Aug  3 07:33:51 2007
@@ -540,6 +540,4

DO NOT REPLY [Bug 43020] New: - Tomcat always tries to install as service on Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43020

   Summary: Tomcat always tries to install as service on Windows
   Product: Tomcat 5
   Version: 5.5.23
  Platform: Other
OS/Version: Windows XP
Status: NEW
  Severity: minor
  Priority: P2
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello,
for test reasons I had to install several versions of Tomcat (v6.0 and 5.5.23 
in this case). Doing so, I had to learn, that the Windows-Installer for Tomcat 
obviously ALWAYS tries to enter Tomcat as a system service, even if the 
corresponding checkbox in the config dialog has been UNchecked. This is a bit 
annoying, since 
1.) if another Tomcat version has already been installed before, then during 
the installation one gets an error, that entering Tomcat as a system service 
failed (=> abort/retry/ignore).
2.) during subsequent reboots one is now always pestered with an error message 
that a service(namely the one whose entry failed - see above) failed to start.

So, the Tomcat installer would either have to obey the check box and NOT enter 
the app as a service unless told so, 
OR
the *names* (and maybe further settings - don't know what's all required for 
the installation of a Windows Service) would need to be sufficiently distinct 
so that several installations could happily co-exist as different services. Of 
course, in that case, one would need to make sure that portnumbers (and 
probably misc. other settings, too) would have to be distinct, or that at any 
time only one of those installed services would actually be running, but 
that's another issue, that the user/admin would have to take care of.

Regards,
Michael

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43002





--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 09:19 ---
Created an attachment (id=20589)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20589&action=view)
Response generator servlet


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38897] - Invalid TLDs receive cryptic error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38897





--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 04:38 ---
I think this bug may be fixed in tomcat 6.

I get helpful messages like:
org.apache.jasper.JasperException: File "/META-INF/tags/mm/u/option.tagx" not 
found

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[patch] [rfc] mod_jk: Use Apache's REMOTE_USER variable for ajp

[Johann Hanne]

Hi,

I currently have the following requirement:
- "Include" a JSP script within a PHP script
- Let PHP do the authentication

My first try was to use mod_jk, PHP's virtual() command (which triggers Apache 
subrequests) and Apache authentication (although I actually need to let PHP 
do the authentication).

This worked with the following problems:
- I had to configure "AuthType Basic" twice: Once for the directory where the 
PHP script resides (using .htaccess) and once for the virtual path controlled 
with JkMount (using  in a global configuration file which only adds 
bloat to it)
- Apache authentication is not what I wanted and I could not control the 
username which is passed to tomcat within the PHP script

The attached patch modifies mod_jk in order to use the "REMOTE_USER" 
environment variable instead of the "user" field in the request structure. 
This improves two things:
- Configuring "AuthType Basic" for the JkMount path is no longer required, 
i.e. it's sufficient to configure authentication for the PHP script
- The username passed to tomcat can be modified in the PHP script 
using 'apache_setenv("REMOTE_USER", "fakeduser");' before the virtual() call

Comments, please?

Cheers, Johann
--- tomcat-connectors-1.2.23-src/native/apache-2.0/mod_jk.c.orig	2007-08-03 12:46:47.0 +0200
+++ tomcat-connectors-1.2.23-src/native/apache-2.0/mod_jk.c	2007-08-03 12:48:31.0 +0200
@@ -548,7 +548,8 @@
 s->reco_status = RECO_NONE;
 
 s->auth_type = NULL_FOR_EMPTY(r->ap_auth_type);
-s->remote_user = NULL_FOR_EMPTY(r->user);
+s->remote_user = NULL_FOR_EMPTY((char *)apr_table_get(r->subprocess_env,
+  "REMOTE_USER"));
 
 s->protocol = r->protocol;
 s->remote_host = (char *)ap_get_remote_host(r->connection,

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Tomcat6 and JVMTI Interface provided by SUN for Java profiler.

[Liang, Chong]

Hi there, 
I am working on a Java profiler using JVMTI interface provided by JDK 5 and 
above. I always get abnormal termination of tomcat 6 as service when stopping 
it. I ran through DevStudio debugger and found the callback of 
jvmtiEventVMDeath in JVMTI is never activated when shutting down tomcat 6 and 
an unhandled exception is caught. It doesn't happen on tomcat 5.5 as service 
and also it works fine with tomcat 6 as commandline. I have asked this question 
to tomcat-user list but no response.Is there something about shutting down the 
server different between 6 and 5.5 to make this happen?
Thanks, 
Chong
The contents of this e-mail are intended for the named addressee only. It 
contains information that may be confidential. Unless you are the named 
addressee or an authorized designee, you may not copy or use it, or disclose it 
to anyone else. If you received it in error please notify us immediately and 
then destroy it.

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43002





--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 07:40 ---
Can you please try with 6.0.14, numerous bug fixes since .13
http://people.apache.org/~remm/tomcat-6/v6.0.14/

also, don't use direct buffers, there is a good chance the system is faster
without .

early next week I will examine your test cases
Filip

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r562594 - /tomcat/trunk/java/org/apache/juli/JdkLoggerFormatter.java

[fhanik]

Author: fhanik
Date: Fri Aug  3 14:40:20 2007
New Revision: 562594

URL: http://svn.apache.org/viewvc?view=rev&rev=562594
Log:
Forward port from 6.0

Added:
tomcat/trunk/java/org/apache/juli/JdkLoggerFormatter.java

Added: tomcat/trunk/java/org/apache/juli/JdkLoggerFormatter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/JdkLoggerFormatter.java?view=auto&rev=562594
==
--- tomcat/trunk/java/org/apache/juli/JdkLoggerFormatter.java (added)
+++ tomcat/trunk/java/org/apache/juli/JdkLoggerFormatter.java Fri Aug  3 
14:40:20 2007
@@ -0,0 +1,109 @@
+/*
+ * Copyright 2001-2004 The Apache Software Foundation.
+ * Copyright 2004 Costin Manolache
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */ 
+
+package org.apache.juli;
+
+import java.util.logging.Formatter;
+import java.util.logging.LogRecord;
+
+
+
+/**
+ * A more compact formatter. 
+ * 
+ * Equivalent log4j config:
+ *   
+ *  log4j.rootCategory=WARN, A1   
+ *  log4j.appender.A1=org.apache.log4j.ConsoleAppender
+ *  log4j.appender.A1.layout=org.apache.log4j.PatternLayout
+ *  log4j.appender.A1.Target=System.err
+ *  log4j.appender.A1.layout.ConversionPattern=%r %-15.15c{2} %-1.1p %m %n
+ *  
+ *
+ * Example:
+ *  1130122891846 Http11BaseProtocol I Initializing Coyote HTTP/1.1 on 
http-8800
+ *  
+ * 
+ * @author Costin Manolache
+ */
+public class JdkLoggerFormatter extends Formatter {
+// values from JDK Level
+public static final int LOG_LEVEL_TRACE  = 400;
+public static final int LOG_LEVEL_DEBUG  = 500;
+public static final int LOG_LEVEL_INFO   = 800;
+public static final int LOG_LEVEL_WARN   = 900;
+public static final int LOG_LEVEL_ERROR  = 1000;
+public static final int LOG_LEVEL_FATAL  = 1000;
+
+public String format(LogRecord record) {
+Throwable t=record.getThrown();
+int level=record.getLevel().intValue();
+String name=record.getLoggerName();
+long time=record.getMillis();
+String message=formatMessage(record);
+
+
+if( name.indexOf(".") >= 0 ) 
+name = name.substring(name.lastIndexOf(".") + 1);
+
+// Use a string buffer for better performance
+StringBuffer buf = new StringBuffer();
+
+buf.append(time);
+buf.append(" ");
+
+// pad to 8 to make it more readable 
+for( int i=0; i<8-buf.length(); i++ ) { buf.append(" "); }
+
+//  Append a readable representation of the log level.
+switch(level) {
+ case LOG_LEVEL_TRACE: buf.append(" T "); break;
+ case LOG_LEVEL_DEBUG: buf.append(" D "); break;
+ case LOG_LEVEL_INFO:  buf.append(" I ");  break;
+ case LOG_LEVEL_WARN:  buf.append(" W ");  break;
+ case LOG_LEVEL_ERROR: buf.append(" E "); break;
+ //case : buf.append(" F "); break;
+ default: buf.append("   ");
+ }
+ 
+
+// Append the name of the log instance if so configured
+buf.append(name);
+
+// pad to 20 chars 
+for( int i=0; i<8-buf.length(); i++ ) { buf.append(" "); }
+
+// Append the message
+buf.append(message);
+
+// Append stack trace if not null
+if(t != null) {
+buf.append(" \n");
+
+java.io.StringWriter sw= new java.io.StringWriter(1024);
+java.io.PrintWriter pw= new java.io.PrintWriter(sw);
+t.printStackTrace(pw);
+pw.close();
+buf.append(sw.toString());
+}
+
+buf.append("\n");
+// Print to the appropriate destination
+return buf.toString();
+}
+
+} 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43002





--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 14:31 ---
the BufferOverflowExceptions are happening in the underlying JDK code, and not
in the Tomcat code base. 
I suggest you try to upgrade to the 02 update of JDK 1.6



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42944] - plus sign in url-pattern in servlet-mapping does not work

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42944


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 17:10 ---
This has been fixed in svn for 5.5.x and 6.0.x and will be included in the next
release of each.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r562625 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/util/RequestUtil.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri Aug  3 17:15:53 2007
New Revision: 562625

URL: http://svn.apache.org/viewvc?view=rev&rev=562625
Log:
Fix bug 42944. + should only decoded to space in query strings. All current 
uses of URLDecide() are not for query strings.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/util/RequestUtil.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/util/RequestUtil.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/util/RequestUtil.java?view=diff&rev=562625&r1=562624&r2=562625
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/util/RequestUtil.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/util/RequestUtil.java
 Fri Aug  3 17:15:53 2007
@@ -74,7 +74,6 @@
 buf.append("\"");
 }
 
-long age = cookie.getMaxAge();
 if (cookie.getMaxAge() >= 0) {
 buf.append("; Max-Age=\"");
 buf.append(cookie.getMaxAge());
@@ -308,7 +307,7 @@
  * Decode and return the specified URL-encoded String.
  * When the byte array is converted to a string, the system default
  * character encoding is used...  This may be different than some other
- * servers.
+ * servers. It is assumed the string is not a query string.
  *
  * @param str The url-encoded string
  *
@@ -316,14 +315,13 @@
  * by a valid 2-digit hexadecimal number
  */
 public static String URLDecode(String str) {
-
 return URLDecode(str, null);
-
 }
-
-
+
+
 /**
- * Decode and return the specified URL-encoded String.
+ * Decode and return the specified URL-encoded String. It is assumed the
+ * string is not a query string.
  *
  * @param str The url-encoded string
  * @param enc The encoding to use; if null, the default encoding is used
@@ -331,7 +329,19 @@
  * by a valid 2-digit hexadecimal number
  */
 public static String URLDecode(String str, String enc) {
-
+return URLDecode(str, enc, false);
+}
+
+/**
+ * Decode and return the specified URL-encoded String.
+ *
+ * @param str The url-encoded string
+ * @param enc The encoding to use; if null, the default encoding is used
+ * @param isQuery Is this a query string being processed
+ * @exception IllegalArgumentException if a '%' character is not followed
+ * by a valid 2-digit hexadecimal number
+ */
+public static String URLDecode(String str, String enc, boolean isQuery) {
 if (str == null)
 return (null);
 
@@ -347,13 +357,14 @@
 }
 } catch (UnsupportedEncodingException uee) {}
 
-return URLDecode(bytes, enc);
+return URLDecode(bytes, enc, isQuery);
 
 }
 
 
 /**
- * Decode and return the specified URL-encoded byte array.
+ * Decode and return the specified URL-encoded byte array. It is assumed
+ * the string is not a query string.
  *
  * @param bytes The url-encoded byte array
  * @exception IllegalArgumentException if a '%' character is not followed
@@ -365,7 +376,8 @@
 
 
 /**
- * Decode and return the specified URL-encoded byte array.
+ * Decode and return the specified URL-encoded byte array. It is assumed
+ * the string is not a query string.
  *
  * @param bytes The url-encoded byte array
  * @param enc The encoding to use; if null, the default encoding is used
@@ -373,7 +385,20 @@
  * by a valid 2-digit hexadecimal number
  */
 public static String URLDecode(byte[] bytes, String enc) {
+return URLDecode(bytes, null, false);
+}
 
+/**
+ * Decode and return the specified URL-encoded byte array.
+ *
+ * @param bytes The url-encoded byte array
+ * @param enc The encoding to use; if null, the default encoding is used
+ * @param isQuery Is this a query string being processed
+ * @exception IllegalArgumentException if a '%' character is not followed
+ * by a valid 2-digit hexadecimal number
+ */
+public static String URLDecode(byte[] bytes, String enc, boolean isQuery) {
+
 if (bytes == null)
 return (null);
 
@@ -382,7 +407,7 @@
 int ox = 0;
 while (ix < len) {
 byte b = bytes[ix++]; // Get byte to test
-if (b == '+') {
+if (b == '+' && isQuery) {
 b = (byte)' ';
 } else if (b == '%') {
 b = (byte) ((convertHexDigit(bytes[ix++]) << 4)
@@ -461,7 +486,6 @@
 throws UnsupportedEncodingException {
 
 if (data != null && data.length > 0) {
-intpos = 0;
 intix = 0;
 intox = 0;
 String key = null;

Modified: tomcat/conta

svn commit: r562632 - /tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JasperLoader.java

[markt]

Author: markt
Date: Fri Aug  3 17:39:12 2007
New Revision: 562632

URL: http://svn.apache.org/viewvc?view=rev&rev=562632
Log:
Code clean up in o.a.jasper.servlet package - no functional change

Modified:
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JasperLoader.java

Modified: 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JasperLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JasperLoader.java?view=diff&rev=562632&r1=562631&r2=562632
==
--- tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JasperLoader.java 
(original)
+++ tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JasperLoader.java 
Fri Aug  3 17:39:12 2007
@@ -37,8 +37,6 @@
 public class JasperLoader extends URLClassLoader {
 
 private PermissionCollection permissionCollection;
-private CodeSource codeSource;
-private String className;
 private ClassLoader parent;
 private SecurityManager securityManager;
 
@@ -47,7 +45,6 @@
CodeSource codeSource) {
super(urls, parent);
this.permissionCollection = permissionCollection;
-   this.codeSource = codeSource;
this.parent = parent;
this.securityManager = System.getSecurityManager();
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43002





--- Additional Comments From [EMAIL PROTECTED]  2007-08-03 18:08 ---
Hi Filip,
 I upgraded to JDK 1.6.0_02 and reran the tests with virtually the same 
results.   Rats!!!

Let me know if there is anything else I can do.

Guy



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]