DO NOT REPLY [Bug 42566] - hangs including jsp with < symbol

2007-06-25 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42566





--- Additional Comments From [EMAIL PROTECTED]  2007-06-25 00:07 ---
(In reply to comment #0)
> This works with tomcat 2.2.20

I wrote the wrong version...it's 5.5.20



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42573] - mod_jk 1.2.23 transfer data corrupted

2007-06-25 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42573


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2007-06-25 01:55 ---
If you turn on debug level logging in mod_jk and replicate this bug, someone may
be able to tell what's going on - there isn't enough in this report to replicate
the issue (given that it's almost certainly environment specific).
A WireShark trace of the traffic between Apache and the browser when the error
occurs would also be great.

It could also be the bug in your while loop (if fi.read ever returns 0 bytes
read, then your loop will terminate without writing the entire image).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: 5.5.24 candidate binaries

2007-06-25 Thread Niall Pemberton 

On 6/21/07, Peter Rossbach <[EMAIL PROTECTED]> wrote:

Hi,

many thanks to the very quick fix. I have test the svn head and it
works. After you have the next offiziel build we can update
the tomcat dependency.


Commons Modeler 2.0.1 has been released - it'll be 24 hours before the
official announcement goes out to give time for all the mirrors to
pick it up.

http://jakarta.apache.org/commons/modeler/downloads.html

Niall


Best regards
peter



Am 21.06.2007 um 13:46 schrieb Niall Pemberton:

> On 6/21/07, Niall Pemberton <[EMAIL PROTECTED]> wrote:
>> On 6/21/07, Peter Rossbach <[EMAIL PROTECTED]> wrote:
>> > No, and I think we can fix it later at 5.5.25.
>> > At  commons modeler nightly build the bug is not fixed.
>>
>> I created a Jira issue for this:
>>   https://issues.apache.org/jira/browse/MODELER-22
>>
>> ..and have patched modeler (m1 build) to include it:
>>   http://svn.apache.org/viewvc?view=rev&revision=549450
>>
>> Should be available to verify that its been fixed in the next
>> nightly build:
>>http://svn.apache.org/viewvc?view=rev&revision=549450
>
> Sorry, should have been:
> http://people.apache.org/builds/jakarta-commons/nightly/commons-
> modeler/
>
>> We can't change the existing modeler 2.0 jar - but we could release a
>> new Modeler bug fix version (2.0.1 or 2.1) - which I can help with
>> and/or RM in Commons.
>>
>> Niall
>>
>> > Peter
>> >
>> >
>> > Am 21.06.2007 um 03:42 schrieb Filip Hanik - Dev Lists:
>> >
>> > > my question to you earlier was, is this different from 5.5.23?
>> > >
>> > > Filip
>> > >
>> > > Peter Rossbach wrote:
>> > >
>> > >> Hi Filip.
>> > >>
>> > >>
>> > >> The commons-modeler 2.0 not include ant.properties, but we need
>> > >> the modeler jmx task:
>> > >>
>> > >>
>> > >> localhost:~/develop/server/apache-tomcat-5.5.24-embed peter$ ant
>> > >> Buildfile: build.xml
>> > >>
>> > >> init:
>> > >>   [taskdef] Could not load definitions from resource org/apache/
>> > >> commons/modeler/ant/ant.properties. It could not be found.
>> > >>
>> > >> ==
>> > >> Tomcat Embed is currently broken, only chance is to patch
>> commons-
>> > >> modeler-2.0.jar with ant.properties from 1.1 release.
>> > >>
>> > >> regards
>> > >> Peter
>> > >>
>> > >>
>> > >> Am 20.06.2007 um 15:13 schrieb Filip Hanik - Dev Lists:
>> > >>
>> > >>> how is 5.5.24 looking, if no one objects, I'll plan to start a
>> > >>> vote on friday
>> > >>>
>> > >>> Filip
>> > >>>
>> > >>> Filip Hanik - Dev Lists wrote:
>> >  http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.24/
>> >  will let these sit to mid next week, and then we can take a
>> vote.
>> >  feedback between now and then is welcome at any time.
>> > 
>> >  Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r550530 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

2007-06-25 Thread rjung 
Author: rjung
Date: Mon Jun 25 09:04:31 2007
New Revision: 550530

URL: http://svn.apache.org/viewvc?view=rev&rev=550530
Log:
Fix comparison between signed and unsigned type.
Uncritical here, because value of this config parameter
won't be negative or very large.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?view=diff&rev=550530&r1=550529&r2=550530
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Mon Jun 25 09:04:31 
2007
@@ -1094,7 +1094,7 @@
 rec->s->reply_timeouts++;
 }
 if (service_stat != JK_REPLY_TIMEOUT ||
-rec->s->reply_timeouts > 
p->worker->s->max_reply_timeouts) {
+rec->s->reply_timeouts > 
(unsigned)p->worker->s->max_reply_timeouts) {
 
 /*
 * Service failed !!!



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread remm 
Author: remm
Date: Mon Jun 25 10:29:58 2007
New Revision: 550556

URL: http://svn.apache.org/viewvc?view=rev&rev=550556
Log:
- Use a new package as suggested by Costin (maybe o.a.servlets.comet ?). This 
also has benefits for the documentation.
- Consider a HttpServlet-like CometServlet abstract class rather than the 
CometProcessor interface.

Added:
tomcat/sandbox/comet/java/org/apache/comet/
tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java   (with props)
tomcat/sandbox/comet/java/org/apache/comet/CometFilter.java   (with props)
tomcat/sandbox/comet/java/org/apache/comet/CometFilterChain.java   (with 
props)
tomcat/sandbox/comet/java/org/apache/comet/CometProcessor.java   (with 
props)
tomcat/sandbox/comet/java/org/apache/comet/CometServlet.java   (with props)

Added: tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java?view=auto&rev=550556
==
--- tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java (added)
+++ tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java Mon Jun 25 
10:29:58 2007
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.comet;
+
+import java.io.IOException;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+/**
+ * The CometEvent interface.
+ * 
+ * @author Filip Hanik
+ * @author Remy Maucherat
+ */
+public interface CometEvent {
+
+/**
+ * Enumeration describing the major events that the container can invoke 
+ * the CometProcessor event() method with:
+ * 
+ * BEGIN - will be called at the beginning 
+ *  of the processing of the connection. It can be used to initialize any 
relevant 
+ *  fields using the request and response objects. Between the end of the 
processing 
+ *  of this event, and the beginning of the processing of the end or error 
events,
+ *  it is possible to use the response object to write data on the open 
connection.
+ *  Note that the response object and depedent OutputStream and Writer are 
still 
+ *  not synchronized, so when they are accessed by multiple threads, 
+ *  synchronization is mandatory. After processing the initial event, the 
request 
+ *  is considered to be committed.
+ * READ - This indicates that input data is available, and that one 
read can be made
+ *  without blocking. The available and ready methods of the InputStream or
+ *  Reader may be used to determine if there is a risk of blocking: the 
servlet
+ *  should read while data is reported available. When encountering a read 
error, 
+ *  the servlet should report it by propagating the exception properly. 
Throwing 
+ *  an exception will cause the error event to be invoked, and the 
connection 
+ *  will be closed. 
+ *  Alternately, it is also possible to catch any exception, perform clean 
up
+ *  on any data structure the servlet may be using, and using the close 
method
+ *  of the event. It is not allowed to attempt reading data from the 
request 
+ *  object outside of the execution of this method.
+ * END - End may be called to end the processing of the request. 
Fields that have
+ *  been initialized in the begin method should be reset. After this event 
has
+ *  been processed, the request and response objects, as well as all their 
dependent
+ *  objects will be recycled and used to process other requests.
+ * ERROR - Error will be called by the container in the case where an 
IO exception
+ *  or a similar unrecoverable error occurs on the connection. Fields that 
have
+ *  been initialized in the begin method should be reset. After this event 
has
+ *  been processed, the request and response objects, as well as all their 
dependent
+ *  objects will be recycled and used to process other requests.
+ * EVENT - Event will be called by the container after the resume() 
method is called.
+ *  This allows you get an event instantly, and you can perform IO actions
+ *  or

Re: 5.5.24 candidate binaries

2007-06-25 Thread Filip Hanik - Dev Lists 

Niall Pemberton wrote:

On 6/21/07, Peter Rossbach <[EMAIL PROTECTED]> wrote:

Hi,

many thanks to the very quick fix. I have test the svn head and it
works. After you have the next offiziel build we can update
the tomcat dependency.


Commons Modeler 2.0.1 has been released - it'll be 24 hours before the
official announcement goes out to give time for all the mirrors to
pick it up.

http://jakarta.apache.org/commons/modeler/downloads.html

Niall

so is this worth a new release?

Filip



Best regards
peter



Am 21.06.2007 um 13:46 schrieb Niall Pemberton:

> On 6/21/07, Niall Pemberton <[EMAIL PROTECTED]> wrote:
>> On 6/21/07, Peter Rossbach <[EMAIL PROTECTED]> wrote:
>> > No, and I think we can fix it later at 5.5.25.
>> > At  commons modeler nightly build the bug is not fixed.
>>
>> I created a Jira issue for this:
>>   https://issues.apache.org/jira/browse/MODELER-22
>>
>> ..and have patched modeler (m1 build) to include it:
>>   http://svn.apache.org/viewvc?view=rev&revision=549450
>>
>> Should be available to verify that its been fixed in the next
>> nightly build:
>>http://svn.apache.org/viewvc?view=rev&revision=549450
>
> Sorry, should have been:
> http://people.apache.org/builds/jakarta-commons/nightly/commons-
> modeler/
>
>> We can't change the existing modeler 2.0 jar - but we could release a
>> new Modeler bug fix version (2.0.1 or 2.1) - which I can help with
>> and/or RM in Commons.
>>
>> Niall
>>
>> > Peter
>> >
>> >
>> > Am 21.06.2007 um 03:42 schrieb Filip Hanik - Dev Lists:
>> >
>> > > my question to you earlier was, is this different from 5.5.23?
>> > >
>> > > Filip
>> > >
>> > > Peter Rossbach wrote:
>> > >
>> > >> Hi Filip.
>> > >>
>> > >>
>> > >> The commons-modeler 2.0 not include ant.properties, but we need
>> > >> the modeler jmx task:
>> > >>
>> > >>
>> > >> localhost:~/develop/server/apache-tomcat-5.5.24-embed peter$ ant
>> > >> Buildfile: build.xml
>> > >>
>> > >> init:
>> > >>   [taskdef] Could not load definitions from resource org/apache/
>> > >> commons/modeler/ant/ant.properties. It could not be found.
>> > >>
>> > >> ==
>> > >> Tomcat Embed is currently broken, only chance is to patch
>> commons-
>> > >> modeler-2.0.jar with ant.properties from 1.1 release.
>> > >>
>> > >> regards
>> > >> Peter
>> > >>
>> > >>
>> > >> Am 20.06.2007 um 15:13 schrieb Filip Hanik - Dev Lists:
>> > >>
>> > >>> how is 5.5.24 looking, if no one objects, I'll plan to start a
>> > >>> vote on friday
>> > >>>
>> > >>> Filip
>> > >>>
>> > >>> Filip Hanik - Dev Lists wrote:
>> >  http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.24/
>> >  will let these sit to mid next week, and then we can take a
>> vote.
>> >  feedback between now and then is welcome at any time.
>> > 
>> >  Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread Filip Hanik - Dev Lists 
I would suggest org.apache.tomcat.comet, pretty much standard across ASF 
java projects to have org.apache..


no reason to create even more divergence in Tomcat, rather start 
consolidating it


Filip

[EMAIL PROTECTED] wrote:

Author: remm
Date: Mon Jun 25 10:29:58 2007
New Revision: 550556

URL: http://svn.apache.org/viewvc?view=rev&rev=550556
Log:
- Use a new package as suggested by Costin (maybe o.a.servlets.comet ?). This 
also has benefits for the documentation.
- Consider a HttpServlet-like CometServlet abstract class rather than the 
CometProcessor interface.

Added:
tomcat/sandbox/comet/java/org/apache/comet/
tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java   (with props)
tomcat/sandbox/comet/java/org/apache/comet/CometFilter.java   (with props)
tomcat/sandbox/comet/java/org/apache/comet/CometFilterChain.java   (with 
props)
tomcat/sandbox/comet/java/org/apache/comet/CometProcessor.java   (with 
props)
tomcat/sandbox/comet/java/org/apache/comet/CometServlet.java   (with props)

Added: tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java?view=auto&rev=550556
==
--- tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java (added)
+++ tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java Mon Jun 25 
10:29:58 2007
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software

+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.comet;
+
+import java.io.IOException;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+/**
+ * The CometEvent interface.
+ * 
+ * @author Filip Hanik

+ * @author Remy Maucherat
+ */
+public interface CometEvent {
+
+/**
+ * Enumeration describing the major events that the container can invoke 
+ * the CometProcessor event() method with:

+ * 
+ * BEGIN - will be called at the beginning 
+ *  of the processing of the connection. It can be used to initialize any relevant 
+ *  fields using the request and response objects. Between the end of the processing 
+ *  of this event, and the beginning of the processing of the end or error events,

+ *  it is possible to use the response object to write data on the open 
connection.
+ *  Note that the response object and depedent OutputStream and Writer are still 
+ *  not synchronized, so when they are accessed by multiple threads, 
+ *  synchronization is mandatory. After processing the initial event, the request 
+ *  is considered to be committed.

+ * READ - This indicates that input data is available, and that one 
read can be made
+ *  without blocking. The available and ready methods of the InputStream or
+ *  Reader may be used to determine if there is a risk of blocking: the 
servlet
+ *  should read while data is reported available. When encountering a read error, 
+ *  the servlet should report it by propagating the exception properly. Throwing 
+ *  an exception will cause the error event to be invoked, and the connection 
+ *  will be closed. 
+ *  Alternately, it is also possible to catch any exception, perform clean up

+ *  on any data structure the servlet may be using, and using the close 
method
+ *  of the event. It is not allowed to attempt reading data from the request 
+ *  object outside of the execution of this method.

+ * END - End may be called to end the processing of the request. 
Fields that have
+ *  been initialized in the begin method should be reset. After this event 
has
+ *  been processed, the request and response objects, as well as all their 
dependent
+ *  objects will be recycled and used to process other requests.
+ * ERROR - Error will be called by the container in the case where an 
IO exception
+ *  or a similar unrecoverable error occurs on the connection. Fields that 
have
+ *  been initialized in the begin method should be reset. After this event 
has
+ *  been processed, the request and response objects, as well as all their 
dependent
+ *  objects will be rec

Re: svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread Mark Thomas 
Filip Hanik - Dev Lists wrote:
> I would suggest org.apache.tomcat.comet, pretty much standard across ASF
> java projects to have org.apache..
> 
> no reason to create even more divergence in Tomcat, rather start
> consolidating it

+1

Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread Remy Maucherat 

Filip Hanik - Dev Lists wrote:
I would suggest org.apache.tomcat.comet, pretty much standard across ASF 
java projects to have org.apache..


no reason to create even more divergence in Tomcat, rather start 
consolidating it


Costin proposed this package name, and I liked it.

Mark Thomas wrote:
> Filip Hanik - Dev Lists wrote:
>> I would suggest org.apache.tomcat.comet, pretty much standard across ASF
>> java projects to have org.apache..
>>
>> no reason to create even more divergence in Tomcat, rather start
>> consolidating it
>
> +1

Nope, bad idea, -1.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread Niall Pemberton 

On 6/26/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

Filip Hanik - Dev Lists wrote:
> I would suggest org.apache.tomcat.comet, pretty much standard across ASF
> java projects to have org.apache..
>
> no reason to create even more divergence in Tomcat, rather start
> consolidating it

Costin proposed this package name, and I liked it.

Mark Thomas wrote:
 > Filip Hanik - Dev Lists wrote:
 >> I would suggest org.apache.tomcat.comet, pretty much standard across ASF
 >> java projects to have org.apache..
 >>
 >> no reason to create even more divergence in Tomcat, rather start
 >> consolidating it
 >
 > +1

Nope, bad idea, -1.


Why is it a bad idea?

Niall


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread Remy Maucherat 

Niall Pemberton wrote:

Why is it a bad idea?


This API does not seem particularly tied to Tomcat, and the other reason 
is that I value Costin's opinion and usually try to incorporate his ideas.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r550556 - in /tomcat/sandbox/comet/java/org/apache/comet: ./ CometEvent.java CometFilter.java CometFilterChain.java CometProcessor.java CometServlet.java

2007-06-25 Thread Niall Pemberton 

On 6/26/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

Niall Pemberton wrote:
> Why is it a bad idea?

This API does not seem particularly tied to Tomcat, and the other reason
is that I value Costin's opinion and usually try to incorporate his ideas.


Thanks for the explanation - I guess the danger is if another project
chooses to use the same package name theres a potential for class
names to conflict. Not that its stopped other projects doing this in
the past (the whole of Jakarta, Shale, Tiles for a few examples).
Perhaps the ASF should have a way for projects to reserve/register
package names that don't align with the project's domain name to
prevent that possibility.

Niall


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r550649 - /tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java

2007-06-25 Thread remm 
Author: remm
Date: Mon Jun 25 17:57:54 2007
New Revision: 550649

URL: http://svn.apache.org/viewvc?view=rev&rev=550649
Log:
- More javadocs cleanups.

Modified:
tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java

Modified: tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java?view=diff&rev=550649&r1=550648&r2=550649
==
--- tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java (original)
+++ tomcat/sandbox/comet/java/org/apache/comet/CometEvent.java Mon Jun 25 
17:57:54 2007
@@ -40,21 +40,22 @@
  *  fields using the request and response objects. Between the end of the 
processing 
  *  of this event, and the beginning of the processing of the end or error 
events,
  *  it is possible to use the response object to write data on the open 
connection.
- *  Note that the response object and depedent OutputStream and Writer are 
still 
- *  not synchronized, so when they are accessed by multiple threads, 
- *  synchronization is mandatory. After processing the initial event, the 
request 
+ *  Note that the response object and depedent OutputStream and Writer are 
 
+ *  not synchronized, so when they are accessed by multiple threads 
adequate
+ *  synchronization is needed. After processing the initial event, the 
request 
  *  is considered to be committed.
- * READ - This indicates that input data is available, and that one 
read can be made
- *  without blocking. The available and ready methods of the InputStream or
+ * READ - This indicates that input data is available, and that at 
least one 
+ *  read can be made without blocking. The available and ready methods of 
the InputStream or
  *  Reader may be used to determine if there is a risk of blocking: the 
servlet
- *  should read while data is reported available. When encountering a read 
error, 
+ *  must continue reading while data is reported available. When 
encountering a read error, 
  *  the servlet should report it by propagating the exception properly. 
Throwing 
  *  an exception will cause the error event to be invoked, and the 
connection 
  *  will be closed. 
  *  Alternately, it is also possible to catch any exception, perform clean 
up
  *  on any data structure the servlet may be using, and using the close 
method
  *  of the event. It is not allowed to attempt reading data from the 
request 
- *  object outside of the execution of this method.
+ *  object outside of the processing of this event, unless the suspend() 
method
+ *  has been used.
  * END - End may be called to end the processing of the request. 
Fields that have
  *  been initialized in the begin method should be reset. After this event 
has
  *  been processed, the request and response objects, as well as all their 
dependent
@@ -64,26 +65,33 @@
  *  been initialized in the begin method should be reset. After this event 
has
  *  been processed, the request and response objects, as well as all their 
dependent
  *  objects will be recycled and used to process other requests.
- * EVENT - Event will be called by the container after the resume() 
method is called.
- *  This allows you get an event instantly, and you can perform IO actions
- *  or close the Comet connection.
+ * EVENT - Event will be called by the container after the resume() 
method is called,
+ *  during which any operations can be performed, including closing the 
Comet connection
+ *  using the close() method.
  * WRITE - Write is sent if the servlet is using the ready method. 
This means that 
- *  the connection is ready to receive data to be written out.
+ *  the connection is ready to receive data to be written out. This event 
will never
+ *  be recieved if the Servlet is not using the ready() method, or if the 
ready() 
+ *  method always returns true.
  * 
  */
 public enum EventType {BEGIN, READ, END, ERROR, WRITE, EVENT}
 
 
 /**
- * Event details:
+ * Enumeration containing event sub categories.
+ * 
+ * END events sub types:
  * 
- * TIMEOUT - the connection timed out (sub type of ERROR); note that 
this ERROR type is not fatal, and
+ * WEBAPP_RELOAD - the webapplication is being reloaded
+ * SERVER_SHUTDOWN - the server is shutting down
+ * SESSION_END - the servlet ended the session
+ * 
+ * ERROR events sub types:
+ * 
+ * TIMEOUT - the connection timed out; note that this ERROR type is 
not fatal, and
  *   the connection will not be closed unless the servlet uses the close 
method of the event
- * CLIENT_DISCONNECT - the client connection was closed (sub type of 
ERROR)
- * IOEXCEPTION - an IO exception occurred, such as invalid content, 
for e

svn commit: r550652 - /tomcat/sandbox/comet/java/org/apache/comet/CometServlet.java

2007-06-25 Thread remm 
Author: remm
Date: Mon Jun 25 18:11:41 2007
New Revision: 550652

URL: http://svn.apache.org/viewvc?view=rev&rev=550652
Log:
- Remove servlet experiment.

Removed:
tomcat/sandbox/comet/java/org/apache/comet/CometServlet.java


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]