Re: 5.5.24?

[Filip Hanik - Dev Lists]

Yoav Shapira wrote:

Hi,

On 5/30/07, Jess Holle <[EMAIL PROTECTED]> wrote:

Doing a quick scan, it looks like a good number of small fixes to 5.5.23
have accumulated over the last number of months.  [See
http://marc.info/?l=tomcat-dev&w=2&r=1&s=5.5.24&q=b]

I know the Tomcat developers are largely focused on 6.0 now, but is
there any chance of a 5.5.24 being rolled to wrap up this backlog.

There are a few spec violations in this batch (e.g. 41869) plus the
embarrassing missing MailSessionFactory.

Overall it would seem good to roll these all up one of these days --
especially given that the number of bugs fixes per month seems to be
dropping off -- and thus one could argue that 5.5.24 may stand "as is"
for a long time.  There are a good number of open bugs against 5.5.x,
but few serious ones seem to: (1) not be in a NEEDINFO state and (2) be
in another area than the native connector (which is separately versioned
and optional).

Thoughts?


+1 for a 5.5.24 release within the next couple of weeks.  Filip, does
that seem reasonable?

sure does, and I agree
Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: mod_jk build: threading detection broken

[Rainer Jung]

William A. Rowe, Jr. wrote:

Rainer Jung wrote:

I checked installed Apache httpd to find out, how we could detect the
threading model of the apache httpd against we compile. Unfortunately we
can only find out the name of the MPM, but not (at least not in a robust
way) if it is threaded or not.


ap_mpm_query (ap_mpm.h) is what you want.  Yes - you can ask
AP_MPMQ_IS_THREADED on win32, netware, unix, etc etc.


I guess no. We are talking about build time, not runtime. I know about 
the query API, but here we want to use defines to decide on the type og 
lock we are using.


Of course we could do it during runtime with if/than/else, but from the 
existing situation I describe for the most prominent platforms my 
suggestion should be OK.


Would be a nice add-on for apxs by the way.

Regards,

Rainer



Bill


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: mod_jk build: threading detection broken

[Rainer Jung]

Henri Gomez wrote:

BTW, configure fail since some release and can't works with apx2-mpm
(The SLES apxs2 for mpm mode). I located the problem in configure and
will report it later.


Yes, let me know.


BTW, on i5/OS, the -D_REENTRANT is forced in module compilation.


OK, so my proposal wouldn't make a difference on i5 too. Good.

Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42090] - tcnative badly handles some OpenSSL disconnections.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42090


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543086 - in /tomcat/trunk/java/org/apache: catalina/connector/CometEventImpl.java coyote/http11/Http11NioProcessor.java tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Thu May 31 01:48:01 2007
New Revision: 543086

URL: http://svn.apache.org/viewvc?view=rev&rev=543086
Log:
simplify register and poller interest for comet, all can be done in one call

Modified:
tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java?view=diff&rev=543086&r1=543085&r2=543086
==
--- tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java Thu May 
31 01:48:01 2007
@@ -28,6 +28,7 @@
 import org.apache.catalina.util.StringManager;
 import org.apache.coyote.ActionCode;
 import org.apache.tomcat.util.net.PollerInterest;
+import java.util.Arrays;
 
 public class CometEventImpl implements CometEvent {
 
@@ -160,23 +161,15 @@
 public void register(CometEvent.CometOperation... operations)
 throws IOException, IllegalStateException {
 //add it to the registered set
-for (CometEvent.CometOperation co : operations) {
-if (!cometOperations.contains(co)) {
-cometOperations.add(co);
-request.action(ActionCode.ACTION_COMET_REGISTER, 
translate(co));
-}
-}
+cometOperations.addAll(Arrays.asList(operations));
+request.action(ActionCode.ACTION_COMET_REGISTER, 
translate(cometOperations.toArray(new CometOperation[0])));
 }
 
 public void unregister(CometOperation... operations)
 throws IOException, IllegalStateException {
 //remove from the registered set
-for (CometEvent.CometOperation co : operations) {
-if (cometOperations.contains(co)) {
-cometOperations.remove(co);
-request.action(ActionCode.ACTION_COMET_UNREGISTER, 
translate(co));
-}
-}
+cometOperations.removeAll(Arrays.asList(operations));
+request.action(ActionCode.ACTION_COMET_UNREGISTER, 
translate(cometOperations.toArray(new CometOperation[0])));
 }
 
 public CometConfiguration[] getConfiguration() {
@@ -211,15 +204,19 @@
 throw new IllegalStateException("The operation can only be 
performed when invoked by a Tomcat worker thread.");
 }
 
-protected PollerInterest translate(CometOperation op) {
-if ( op == CometEvent.CometOperation.OP_READ )
-return PollerInterest.READ;
-else if ( op == CometEvent.CometOperation.OP_WRITE )
-return PollerInterest.WRITE;
-else if ( op == CometEvent.CometOperation.OP_CALLBACK )
-return PollerInterest.CALLBACK;
-else 
-throw new IllegalArgumentException(op!=null?op.toString():"null");
+protected PollerInterest[] translate(CometOperation... op) {
+PollerInterest[] result = new PollerInterest[op.length];
+for (int i=0; ihttp://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?view=diff&rev=543086&r1=543085&r2=543086
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Thu May 
31 01:48:01 2007
@@ -1242,18 +1242,20 @@
 }
 
 private int getPollerInterest(Object param) throws 
IllegalArgumentException {
-if ( param == null || (!(param instanceof PollerInterest)) )
-throw new IllegalArgumentException("Action parameter must be a 
PollerInterest object.");
+if ( param == null || (!(param instanceof PollerInterest[])) )
+throw new IllegalArgumentException("Action parameter must be a 
PollerInterest[] object.");
 int interest = 0;
-PollerInterest pi = (PollerInterest)param;
-if ( pi == PollerInterest.CALLBACK )
-interest = NioEndpoint.OP_CALLBACK;
-else if ( pi == PollerInterest.READ ) 
-interest  = SelectionKey.OP_READ;
-else if ( pi == PollerInterest.WRITE ) 
-interest = SelectionKey.OP_WRITE;
-else
-throw new IllegalArgumentException(pi!=null?pi.toString():"null");
+PollerInterest[] piarr = (PollerInterest[])param;
+for ( PollerInterest pi : piarr ) {
+if (pi == PollerInterest.CALLBACK)
+interest = interest | NioEndpoint.OP_CALLBACK;
+else if (pi == PollerInterest.READ)
+interest = interest | SelectionKey.OP_READ;
+else if (pi == PollerInterest.WRITE)
+interest = interest | SelectionKey.OP_WRITE;
+  

svn commit: r543091 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Thu May 31 02:09:04 2007
New Revision: 543091

URL: http://svn.apache.org/viewvc?view=rev&rev=543091
Log:
implement CALLBACK and WRITE events

Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?view=diff&rev=543091&r1=543090&r2=543091
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Thu May 
31 02:09:04 2007
@@ -169,6 +169,26 @@
 request.getEvent().setEventSubType(null);
 }
 }
+} else if (status == SocketStatus.OPEN_WRITE) {
+if (response.isClosed()) {
+// The event has been closed asynchronously, so call 
end instead of
+// read to cleanup the pipeline
+
request.getEvent().setEventType(CometEvent.EventType.END);
+request.getEvent().setEventSubType(null);
+} else {
+
request.getEvent().setEventType(CometEvent.EventType.WRITE);
+request.getEvent().setEventSubType(null);
+}
+} else if (status == SocketStatus.OPEN_CALLBACK) {
+if (response.isClosed()) {
+// The event has been closed asynchronously, so call 
end instead of
+// read to cleanup the pipeline
+
request.getEvent().setEventType(CometEvent.EventType.END);
+request.getEvent().setEventSubType(null);
+} else {
+
request.getEvent().setEventType(CometEvent.EventType.CALLBACK);
+request.getEvent().setEventSubType(null);
+}
 } else if (status == SocketStatus.DISCONNECT) {
 
request.getEvent().setEventType(CometEvent.EventType.ERROR);
 
request.getEvent().setEventSubType(CometEvent.EventSubType.CLIENT_DISCONNECT);

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=543091&r1=543090&r2=543091
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Thu May 31 
02:09:04 2007
@@ -1515,7 +1515,7 @@
 //check if thread is available
 if ( isWorkerAvailable() ) {
 //set interest ops to 0 so we don't get 
multiple
-//invokations
+//invokations for both read and write on 
separate threads
 reg(sk, attachment, 0);
 //read goes before write
 if (sk.isReadable())
@@ -1617,6 +1617,10 @@
 cancelledKey(key, SocketStatus.ERROR,false); //we 
don't support any keys without attachments
 } else if ( ka.getError() ) {
 cancelledKey(key, SocketStatus.ERROR,true);
+} else if (ka.getComet() && ka.getCometNotify() ) {
+ka.setCometNotify(false);//this will get reset after 
invokation if callback is still in there
+reg(key,ka,0);//avoid multiple calls, this gets 
reregistered after invokation
+if (!processSocket(ka.getChannel(), 
SocketStatus.OPEN_CALLBACK)) processSocket(ka.getChannel(), 
SocketStatus.DISCONNECT);
 }else if ((ka.interestOps()&SelectionKey.OP_READ) == 
SelectionKey.OP_READ) {
 //only timeout sockets that we are waiting for a read 
from
 long delta = now - ka.getLastAccess();



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543093 - in /tomcat/connectors/trunk/jk: native/common/jk_mt.h xdocs/miscellaneous/changelog.xml xdocs/webserver_howto/apache.xml

[rjung]

Author: rjung
Date: Thu May 31 02:27:59 2007
New Revision: 543093

URL: http://svn.apache.org/viewvc?view=rev&rev=543093
Log:
Always build thread safe against Apache httpd 2.0/2.2
(unless configure detects --enable-prefork).
_REENTRANT flag for APR is not a safe threading detection
for all platforms.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_mt.h
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_mt.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_mt.h?view=diff&rev=543093&r1=543092&r2=543093
==
--- tomcat/connectors/trunk/jk/native/common/jk_mt.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_mt.h Thu May 31 02:27:59 2007
@@ -33,18 +33,10 @@
 #define getpid()   ((int)GetThreadGroupID())
 #endif
 
-/*
- * All WIN32 code is MT, UNIX code that uses pthreads is marked by the POSIX
- * _REENTRANT define.
- */
-#if defined (WIN32) || defined(_REENTRANT) || (defined(NETWARE) && 
defined(__NOVELL_LIBC__))
 #ifdef JK_PREFORK 
 #define _MT_CODE 0
 #else
 #define _MT_CODE 1
-#endif
-#else
-#define _MT_CODE 0
 #endif
 
 /*

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?view=diff&rev=543093&r1=543092&r2=543093
==
--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Thu May 31 
02:27:59 2007
@@ -27,6 +27,10 @@
   
   
 
+  
+  Always build with thread support, unless flag --enable-prefork
+  is set during for configure. (rjung)
+  
   
   i5/OS (AS/400) V5R4 port where Apache 2.0 modules should now use UTF8. 
(hgomez)
   

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml?view=diff&rev=543093&r1=543092&r2=543093
==
--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Thu May 31 
02:27:59 2007
@@ -838,25 +838,26 @@
 
 
 
-If you want to build mod_jk for Apache 1.3 and 2.0/2.2, you should
+If you want to build mod_jk for different version of Apache httpd, like 1.3, 
2.0 and 2.2,
+you need to go through the full build process for each of them.
+Please note, that httpd 2.0 and 2.2 modules are not compatible. The 
mod_jk directory
+used is "apache-2.0" in both cases, but you need to compile separately.
 
 
-use configure and indicate Apache 1.3 apxs location (--with-apxs)
+use configure and indicate the correct Apache httpd apxs location (--with-apxs)
 
 
 use make
 
 
-copy the mod_jk binary to the apache modules location
+copy the resulting mod_jk.so binary from the apache-1.3 or apache-2.0 
subdirectory
+to the Apache httpd modules location.
 
 
-make clean (to remove all previously compiled modules)
+make clean (to remove all previously compiled object files)
 
 
-use configure and indicate Apache 2.0/2.2 apxs location,
-
-
-then make.
+Start over with the apxs location for your next Apache httpd version.
 
 
 
@@ -886,17 +887,14 @@
 
   --enable-prefork
   
-In case you build mod_jk for a multi-threaded Apache 2.0/2.2 MPM 
(Multi-Processing Module),
+In case you build mod_jk for a multi-threaded Apache httpd 2.0/2.2 MPM 
(Multi-Processing Module),
 some areas of mod_jk code need to be synchronized to make it thread-safe.
-Configure autodetects, whether your are using a multi-threaded MPM.
-For instance, the worker MPM is multi-threaded, the prefork MPM is not.
-Depending on how you build your Apache httpd, in some cases configure
-detects that it needs to build thread safe, although actually it would not be 
necessary.
-One such case is, if you build against Apache httpd with prefork MPM,
-and your APR (Apache Portable Runtime) libraries have been build with thread 
support
-(the output of "apxs -q EXTRA_CPPFLAGS" will contain "-D_REENTRANT").
+Because configure can not easily detect, whether your are using a 
multi-threaded MPM,
+mod_jk by default is always build thread-safe for Apache httpd 2.0/2.2.
 If you are sure, that your MPM is not multi-threaded, you can use 
"--enable-prefork"
-to force the removal of the synchronization code (thus increasing performance 
a bit).
+to force the removal of the synchronization code (thus increasing performance 
a bit).
+For instance, the prefork MPM is not multi-threaded. For Apache httpd 1.3
+this flag will be set automatically.
 
   --enable-flock
   



-
To

DO NOT REPLY [Bug 42553] New: - JK-1.2.23 is conflict with mod_dir

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42553

   Summary: JK-1.2.23 is conflict with mod_dir
   Product: Tomcat 5
   Version: 5.0.0
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P4
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When I config the httpd.conf with following:


ServerName wap.caimintong.com
DocumentRoot /usr/local/bocaitong
DirectoryIndex /gq/portal.jsp
JkMount /gq/*.jsp loadbalancer



When I browse the domain with http://wap.caimintong.com

The server list the file directory to me, and not the portal.jsp.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42553] - JK-1.2.23 is conflict with mod_dir

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42553


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 02:43 ---
Do not use DirectoryIndex.
Use what Servlet Specification is telling you to do and that is wellcome-file
inside your web.xml


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543107 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Thu May 31 03:34:27 2007
New Revision: 543107

URL: http://svn.apache.org/viewvc?view=rev&rev=543107
Log:
add brackets to clarify what were trying to do

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=543107&r1=543106&r2=543107
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Thu May 31 
03:34:27 2007
@@ -1518,10 +1518,13 @@
 //invokations for both read and write on 
separate threads
 reg(sk, attachment, 0);
 //read goes before write
-if (sk.isReadable())
-if (!processSocket(channel, 
SocketStatus.OPEN_READ)) processSocket(channel, SocketStatus.DISCONNECT);
-else
-if (!processSocket(channel, 
SocketStatus.OPEN_WRITE)) processSocket(channel, SocketStatus.DISCONNECT);
+if (sk.isReadable()) {
+if (!processSocket(channel, 
SocketStatus.OPEN_READ))
+processSocket(channel, 
SocketStatus.DISCONNECT);
+} else {
+if (!processSocket(channel, 
SocketStatus.OPEN_WRITE))
+processSocket(channel, 
SocketStatus.DISCONNECT);
+}
 } else {
 result = false;
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: mod_jk build: threading detection broken

[Henri Gomez]

The SLES 9 problem with apxs-worker is fixed (bad configuration).

I just check the configure and build and -D_REENTRANT is set :

powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker



make


make[1]: Entering directory `/root/tomcat-connectors-1.2.23-src/native/common'
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-worker -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-worker -I/usr/include/apache2-worker -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_ajp12_worker.c -o jk_ajp12_worker.lo
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-worker -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-worker -I/usr/include/apache2-worker -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_connect.c -o jk_connect.lo



2007/5/31, Rainer Jung <[EMAIL PROTECTED]>:

Henri Gomez wrote:
> BTW, configure fail since some release and can't works with apx2-mpm
> (The SLES apxs2 for mpm mode). I located the problem in configure and
> will report it later.

Yes, let me know.

> BTW, on i5/OS, the -D_REENTRANT is forced in module compilation.

OK, so my proposal wouldn't make a difference on i5 too. Good.

Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: mod_jk build: threading detection broken

[Henri Gomez]

BTW, the same configure with the apxs-prefork also set the
-D_REENTRANT on SLES 9 ;(

alaska:~/tomcat-connectors-1.2.23-src/native # make
Making all in common
make[1]: Entering directory `/root/tomcat-connectors-1.2.23-src/native/common'
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-prefork -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-prefork -I/usr/include/apache2-prefork -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_ajp12_worker.c -o jk_ajp12_worker.lo
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-prefork -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-prefork -I/usr/include/apache2-prefork -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_connect.c -o jk_connect.lo



2007/5/31, Henri Gomez <[EMAIL PROTECTED]>:

The SLES 9 problem with apxs-worker is fixed (bad configuration).

I just check the configure and build and -D_REENTRANT is set :

powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker



make


make[1]: Entering directory `/root/tomcat-connectors-1.2.23-src/native/common'
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-worker -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-worker -I/usr/include/apache2-worker -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_ajp12_worker.c -o jk_ajp12_worker.lo
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-worker -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-worker -I/usr/include/apache2-worker -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_connect.c -o jk_connect.lo



2007/5/31, Rainer Jung <[EMAIL PROTECTED]>:
> Henri Gomez wrote:
> > BTW, configure fail since some release and can't works with apx2-mpm
> > (The SLES apxs2 for mpm mode). I located the problem in configure and
> > will report it later.
>
> Yes, let me know.
>
> > BTW, on i5/OS, the -D_REENTRANT is forced in module compilation.
>
> OK, so my proposal wouldn't make a difference on i5 too. Good.
>
> Regards,
>
> Rainer
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543117 - /tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

[fhanik]

Author: fhanik
Date: Thu May 31 04:51:34 2007
New Revision: 543117

URL: http://svn.apache.org/viewvc?view=rev&rev=543117
Log:
return the amount of bytes written

Modified:
tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?view=diff&rev=543117&r1=543116&r2=543117
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Thu 
May 31 04:51:34 2007
@@ -419,7 +419,7 @@
 
 }
 
-private synchronized void writeToSocket(ByteBuffer bytebuffer, boolean 
flip) throws IOException {
+private synchronized int writeToSocket(ByteBuffer bytebuffer, boolean 
flip) throws IOException {
 //int limit = bytebuffer.position();
 if ( flip ) bytebuffer.flip();
 int written = 0;
@@ -440,6 +440,7 @@
 }
 socket.getBufHandler().getWriteBuffer().clear();
 this.total = 0;
+return written;
 } 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 05:15 ---
I too tested this scenario on Jetty, as well as on WebSphere Application Server
(WAS) binaries and this problem doesn't occur with them. In both Jetty and WAS,
I am able to see the extra response header even when using custom error page.

My search of specification for anything against it has been in vain.

Following is the piece of code that I have looked into:
org.apache.catalina.core.StandardHostValve
protected void status(Request request, Response response);
protected boolean custom(Request request, Response response, ErrorPage 
errorPage);

Here are my observations:
1) When a custom error page is used, client request is "forwarded" to the custom
error page. 

Now, as per Servlet 2.4 specification (page 65, SRV.8.4):
"The forward method of the RequestDispatcher interface may be called by the
calling servlet only when no output has been committed to the client. If output
data exists in the response buffer that has not been committed, the content must
be cleared before the target servlet’s service method is called. If the response
has been committed, an IllegalStateException must be thrown."

I see that in current Tomcat code, in "protected boolean custom(Request request,
Response response,ErrorPage errorPage)" method we are calling
"response.reset(statusCode, message)" to clear the response content. This also
clears the response headers that users might have set in their code.

Question for Committers:
I am seeing that the specification asks us to reset just the response buffer
(before 'forwarding' requests) while we are resetting the entire response object
(which also resets response headers). 

Can we replace the call to "response.reset(statusCode, message)" with a call to
"response.resetBuffer()"? 

If yes, some of the "request.getAttribute(..)" calls in "protected boolean
custom(Request request, Response response, ErrorPage errorPage)" method and
hence some of the "request.setAttribute(..)" calls in "protected void
status(Request request, Response response)" method might become redundant and
could be removed as well.

2) When default error page is used, there is no request "forwarding" and hence
no response resets (and hence the response headers that users set in their code
are preserved). I think an error message is simply added to existing response's
body and response is pushed to client.

- Shiva

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 05:24 ---
Created an attachment (id=20297)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20297&action=view)
WAR with custom error page; extra response headers not seen

page to run: http://localhost:8080/Bug_42409_error/test

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 05:25 ---
Created an attachment (id=20298)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20298&action=view)
WAR with default error page; extra response headers seen

page to run: http://localhost:8080/Bug_42409_correct/test

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]   |tomcat-
   ||[EMAIL PROTECTED]
 Status|NEEDINFO|NEW




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: mod_jk build: threading detection broken

[Rainer Jung]

Hi Henri,

Henri Gomez wrote:

BTW, the same configure with the apxs-prefork also set the
-D_REENTRANT on SLES 9 ;(


Yes, those flags all come from apxs. The difference with my new commit 
is, that we don't use them to decide, if we should synchronize between 
threads.


Now we only use JK_PREFORK, which gets set either when you are compiling 
against Apache 1.3, or if you use --enable-prefork.


I committed these changes this morning in r543093.

Regards,

Rainer


alaska:~/tomcat-connectors-1.2.23-src/native # make
Making all in common
make[1]: Entering directory 
`/root/tomcat-connectors-1.2.23-src/native/common'

/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-prefork -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-prefork -I/usr/include/apache2-prefork -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_ajp12_worker.c -o jk_ajp12_worker.lo
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-prefork -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-prefork -I/usr/include/apache2-prefork -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_connect.c -o jk_connect.lo



2007/5/31, Henri Gomez <[EMAIL PROTECTED]>:

The SLES 9 problem with apxs-worker is fixed (bad configuration).

I just check the configure and build and -D_REENTRANT is set :

powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker



make


make[1]: Entering directory 
`/root/tomcat-connectors-1.2.23-src/native/common'

/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-worker -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-worker -I/usr/include/apache2-worker -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_ajp12_worker.c -o jk_ajp12_worker.lo
/bin/sh /usr/share/apache2/build/libtool --silent --mode=compile gcc
-I/usr/include/apache2-worker -g -O2 -O2 -fsigned-char
-fmessage-length=0 -Wall -fPIC -Wall -fno-strict-aliasing
-D_LARGEFILE_SOURCE -g -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -pthread -DHAVE_APR
-I/usr/include/apache2-worker -I/usr/include/apache2-worker -g -O2
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
-D_SVID_SOURCE -D_GNU_SOURCE -DAP_DEBUG -I /usr/lib/java/include -I
/usr/lib/java/include/ -c jk_connect.c -o jk_connect.lo



2007/5/31, Rainer Jung <[EMAIL PROTECTED]>:
> Henri Gomez wrote:
> > BTW, configure fail since some release and can't works with apx2-mpm
> > (The SLES apxs2 for mpm mode). I located the problem in configure and
> > will report it later.
>
> Yes, let me know.
>
> > BTW, on i5/OS, the -D_REENTRANT is forced in module compilation.
>
> OK, so my proposal wouldn't make a difference on i5 too. Good.
>
> Regards,
>
> Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|5.0.0   |5.0.29




--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 06:08 ---
The data you ask me for:

Apache/2.0.59 (Win32) mod_ssl/2.0.59 OpenSSL/0.9.8d mod_jk/1.2.21 Server at 
localhost Port 80.




Thanks a lot.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|5.0.29  |5.0.23




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 06:18 ---
Yes, please look at httpd error log and mod_jk log file.

Your config looks OK (and works on a test system).

What could be: if mod_jk can not resolve the name of your backend during
startup, it will not start and will log this problem in your jk log file.

There's nothing wrong about an lb worker with only one member. On the contrary:
because of the additional status you can get from a status worker, it is good
practise to use an lb worker even for single workers.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 07:22 ---
Hi, 

Thanks for your response.

Another data that can help to you to solve the problem:

If we set workers.properties as:

worker.list=lb_worker,status_worker

worker.lb_worker.type=lb
worker.lb_worker.balance_workers=workerW02
worker.lb_worker.method=B
worker.lb_worker.lock=O
worker.lb_worker.sticky_session=1

worker.status_worker.type=status

worker.workerW02.type=ajp13
worker.workerW02.port=8009
worker.workerW02.host=VPBRPRESIDW02
worker.workerW02.lbfactor=1

and we comment the line SSLEngine On as:

#   SSLEngine On
CustomLog logs/ssl_request_log.log "%t %h %{SSL_PROTOCOL}x %{SSL_CIPHER}
x \"%r\" %b"


Apache starts perfectly.

Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 07:53 ---
Created an attachment (id=20299)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20299&action=view)
call "response.resetBuffer()" instead of "response.reset(statusCode, message)"

does anyone foresee any regressions out of this?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42547] - Same env-entry (web.xml) and ResourceLink (context) names causes NPE

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42547





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 08:33 ---
(In reply to comment #1)
> More info on having duplicate names in the following scenarios
> 
> web.xml   context descriptor   winner
>    
> no entry  
>
>no entry 
> no entry 
>   blows up

This needs to be updated slightly to take into account the override property of
the  tag in the context descriptor. 

web.xml   context descriptorwinner
    
no entry
  
(same as 
previous)

   no entry   
no entry   
blows up

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r543093 - in /tomcat/connectors/trunk/jk: native/common/jk_mt.h xdocs/miscellaneous/changelog.xml xdocs/webserver_howto/apache.xml

[Peter Rossbach]

Hi Rainer,


your _REENTRANT fix trigger a next MAC OS X problem:

eragon:~/workshop/tomcat-connectors-1.2.23-src/native peter$ make
Making all in common
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc -I/ 
Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/opt/ 
local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/Home/ 
include -I /Library/Java/Home/include/ -c jk_ajp12_worker.c -o  
jk_ajp12_worker.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc -I/ 
Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/opt/ 
local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/Home/ 
include -I /Library/Java/Home/include/ -c jk_connect.c -o jk_connect.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc -I/ 
Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/opt/ 
local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/Home/ 
include -I /Library/Java/Home/include/ -c jk_msg_buff.c -o  
jk_msg_buff.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc -I/ 
Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/opt/ 
local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/Home/ 
include -I /Library/Java/Home/include/ -c jk_util.c -o jk_util.lo

jk_util.c: In function 'jk_gettid':
jk_util.c:1723: error: invalid operands to binary &
make[1]: *** [jk_util.lo] Error 1
make: *** [all-recursive] Error 1


testet with apache 2.2.4.

Regards
peter



Am 31.05.2007 um 11:28 schrieb [EMAIL PROTECTED]:


Author: rjung
Date: Thu May 31 02:27:59 2007
New Revision: 543093

URL: http://svn.apache.org/viewvc?view=rev&rev=543093
Log:
Always build thread safe against Apache httpd 2.0/2.2
(unless configure detects --enable-prefork).
_REENTRANT flag for APR is not a safe threading detection
for all platforms.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_mt.h
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_mt.h
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/ 
common/jk_mt.h?view=diff&rev=543093&r1=543092&r2=543093
== 


--- tomcat/connectors/trunk/jk/native/common/jk_mt.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_mt.h Thu May 31  
02:27:59 2007

@@ -33,18 +33,10 @@
 #define getpid()   ((int)GetThreadGroupID())
 #endif

-/*
- * All WIN32 code is MT, UNIX code that uses pthreads is marked by  
the POSIX

- * _REENTRANT define.
- */
-#if defined (WIN32) || defined(_REENTRANT) || (defined(NETWARE) &&  
defined(__NOVELL_LIBC__))

 #ifdef JK_PREFORK
 #define _MT_CODE 0
 #else
 #define _MT_CODE 1
-#endif
-#else
-#define _MT_CODE 0
 #endif

 /*

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/ 
miscellaneous/changelog.xml?view=diff&rev=543093&r1=543092&r2=543093
== 

--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml  
(original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml  
Thu May 31 02:27:59 2007

@@ -27,6 +27,10 @@
   
   
 
+  
+  Always build with thread support, unless flag --enable-prefork
+  is set during for configure. (rjung)
+  
   
   i5/OS (AS/400) V5R4 port where Apache 2.0 modules should now  
use UTF8. (hgomez)

   

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/ 
webserver_howto/apache.xml?view=diff&rev=543093&r1=543092&r2=543093
== 

--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml  
(original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Thu  
May 31 02:27:59 2007

@@ -838,25 +838,26 @@
 

 
-If you want to build mod_jk for Apache 1.3 and 2.0/2.2, you should
+If you want to build mod_jk for different version of Apache httpd,  
like 1.3, 2.0 and 2.2,

+you need to go through the full build process for each of them.
+Please note, that httpd 2.0 and 2.2 modules are not  
compatible. The mod_jk directory
+used is "apache-2.0" in both cases, but you need to compile  
separately.

 
 
-use configure and indicate Apache 1.3 apxs location (--with-apxs)
+use configure and indicate the correct Apache httpd apxs location  
(--with-apxs)

 
 
 use make
 
 
-copy the mod_jk binary to the apache modules location
+copy the resulting mod_jk.so binary from

DO NOT REPLY [Bug 42559] New: - ErrorReportValve does not provide an error report

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42559

   Summary: ErrorReportValve does not provide an error report
   Product: Tomcat 6
   Version: unspecified
  Platform: All
OS/Version: All
Status: NEW
  Severity: regression
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


rev 535915 changed the behavior of ErrorReportValve in tomcat6 to not produce an
error report when response.sendError() is called. For example, using this code
in a servlet's service() does not produce an error report:

response.sendError(HttpServletResponse.SC_GONE, "error occurred");

The underlying cause is that the valve's check for response.isCommitted() was
replaced with response.isAppCommitted().  The latter returns true, which causes
the Valve's invoke() method to immediately return instead of producing the 
report.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42559] - ErrorReportValve does not provide an error report

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42559





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 09:10 ---
Created an attachment (id=20302)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20302&action=view)
patch reverts check for isAppCommitted back to isCommitted


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 09:11 ---
No, I don't think we're going to change this. We'll keep the current code which
sets the status code + message, but your customization for your own is fine too.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42547] - Same env-entry (web.xml) and ResourceLink (context) names causes NPE

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42547





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 09:12 ---
This is related to a change made to fix the following bug:

http://issues.apache.org/bugzilla/show_bug.cgi?id=29727

First, it appears that contrary to the documentation (located at
http://tomcat.apache.org/tomcat-5.5-doc/config/globalresources.html#Enviroment%20Entries),
setting the 'override' attribute of a  tag inside
 to 'true' will never be (and perhaps never was) 
obeyed. 

Allowing  overrides of global  entries (through
 in the context descriptor) may, it could be argued, be illegal
(not the mention confusing). The current behavior, with the NPE, makes it
illegal (intentional or not).

However, it could also be argued that, with an external context descriptor, you
should be able to override anything set via  in web.xml if you wanted
to (and this is what the documentation seems to indicate). 

Finally, there's restoring the previous behavior, which never allows any
overriding and always (silently) takes the global value, regardless of any
corresponding s or any reloading.

Essentially, you can a) make it work as described by the documentation, b) blow
up, or c) silently take the global values on load (or reload) always. 

If b, I recommend blowing up with something more descriptive than the NPE we
have now and changing the doco.

If c, you could just check if (in
org.apache.catalina.deploy.NamingResources.java, line 188), findEnviroment()
retuns null. If it does, log a warning and return. If not, do the getOverride()
if. You should also update the doco in this case too.

if (entries.containsKey(environment.getName())) {
ContextEnvironment ce = findEnvironment(environment.getName());
if (ce == null) {
// Log a warning: 
return;
}
if (findEnvironment(environment.getName()).getOverride()) {
removeEnvironment(environment.getName());
} else {
return;
}
}


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 09:59 ---
If the code is kept as is, how would one use a custom error page and still be
able to set response headers?  I'm a little confused, is it not a bug?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r543093 - in /tomcat/connectors/trunk/jk: native/common/jk_mt.h xdocs/miscellaneous/changelog.xml xdocs/webserver_howto/apache.xml

[Rainer Jung]

Could you try to find out, how pthread_t is defined on OS X?
Does the following patch help?

Index: jk_util.c
===
--- jk_util.c   (revision 542900)
+++ jk_util.c   (working copy)
@@ -1686,12 +1686,87 @@
 pthread_getunique_np(&t, &tid);
 return ((int)(tid.intId.lo & 0x));
 #else
-int tid = (int)(t & 0x);
+int tid = ((int)t) & 0x;
 return tid;
 #endif /* AS400 */
 }
 #endif


Regards,

Rainer

Peter Rossbach wrote:

Hi Rainer,


your _REENTRANT fix trigger a next MAC OS X problem:

eragon:~/workshop/tomcat-connectors-1.2.23-src/native peter$ make
Making all in common
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc 
-I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  
-I/opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN 
-DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I 
/Library/Java/Home/include -I /Library/Java/Home/include/ -c 
jk_ajp12_worker.c -o jk_ajp12_worker.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc 
-I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  
-I/opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN 
-DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I 
/Library/Java/Home/include -I /Library/Java/Home/include/ -c 
jk_connect.c -o jk_connect.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc 
-I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  
-I/opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN 
-DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I 
/Library/Java/Home/include -I /Library/Java/Home/include/ -c 
jk_msg_buff.c -o jk_msg_buff.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc 
-I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  
-I/opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN 
-DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I 
/Library/Java/Home/include -I /Library/Java/Home/include/ -c jk_util.c 
-o jk_util.lo

jk_util.c: In function 'jk_gettid':
jk_util.c:1723: error: invalid operands to binary &
make[1]: *** [jk_util.lo] Error 1
make: *** [all-recursive] Error 1


testet with apache 2.2.4.

Regards
peter



Am 31.05.2007 um 11:28 schrieb [EMAIL PROTECTED]:


Author: rjung
Date: Thu May 31 02:27:59 2007
New Revision: 543093

URL: http://svn.apache.org/viewvc?view=rev&rev=543093
Log:
Always build thread safe against Apache httpd 2.0/2.2
(unless configure detects --enable-prefork).
_REENTRANT flag for APR is not a safe threading detection
for all platforms.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_mt.h
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_mt.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_mt.h?view=diff&rev=543093&r1=543092&r2=543093 

== 


--- tomcat/connectors/trunk/jk/native/common/jk_mt.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_mt.h Thu May 31 
02:27:59 2007

@@ -33,18 +33,10 @@
 #define getpid()   ((int)GetThreadGroupID())
 #endif

-/*
- * All WIN32 code is MT, UNIX code that uses pthreads is marked by 
the POSIX

- * _REENTRANT define.
- */
-#if defined (WIN32) || defined(_REENTRANT) || (defined(NETWARE) && 
defined(__NOVELL_LIBC__))

 #ifdef JK_PREFORK
 #define _MT_CODE 0
 #else
 #define _MT_CODE 1
-#endif
-#else
-#define _MT_CODE 0
 #endif

 /*

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?view=diff&rev=543093&r1=543092&r2=543093 

== 

--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml 
(original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Thu 
May 31 02:27:59 2007

@@ -27,6 +27,10 @@
   
   
 
+  
+  Always build with thread support, unless flag --enable-prefork
+  is set during for configure. (rjung)
+  
   
   i5/OS (AS/400) V5R4 port where Apache 2.0 modules should now 
use UTF8. (hgomez)

   

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml?view=diff&rev=543093&r1=543092&r2=543093 

== 

--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml 
(original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Thu 
May 31 02:27:59 2007

@@ -838,25 +838,26 @@
 

 
-If you want to build mod_jk for Apache 1.3 and 2.0/2.2, you should
+If you want to build mod_jk for different version of Apache httpd, 
like 1.3, 2.0 and 2.2,

+y

DO NOT REPLY [Bug 41791] - Tomcat behaves inconsistently concerning flush-packets

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41791


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|unspecified |6.0.10




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33374] - Connections are not reset under heavy load with lots of closed remote connections

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33374





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 11:11 ---
Hi Bill (or anyone else who can help here),

I just checked and neither 5.5.20 nor 6.0 of Tomcat does have that patch applied
to it. Could you please advise why?

Also, if you are involved in 6.0, do you know if anything discussed has been
improved in 6.0? I mean there were a few design issue with the ChannelSocket and
related classes. Is there a better alternative?

Please note, that we still have the same problem as back then.

Thanks and best regards,
Lars


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42560] New: - Tomact quits unexpectedly

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42560

   Summary: Tomact quits unexpectedly
   Product: Tomcat 5
   Version: 5.5.17
  Platform: PC
   URL: http://www.msdis.missouri.edu
OS/Version: Windows Server 2003
Status: UNCONFIRMED
  Severity: normal
  Priority: P2
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Windows 2003 with all the latest patches. Tomcat 5.5.17

Tomcat is set as a windows service with automatic startup. It keeps on stopping
randomly and the following error code 7034 shows up in the error log. I looked
up this error. We are not runnung SMTP on this server. Any help would be much
appreciated.

Link to screen shot http://www.msdis.missouri.edu/tomcat_error.jpg

"The Apache Tomcat service terminated unexpectedly. It has done this 5 time(s)

For more information, see Help and Support Center at
http://go.microsoft.com/fwlink/events.asp";

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543226 - in /tomcat/trunk/java/org/apache: catalina/connector/ coyote/ coyote/http11/ tomcat/util/ tomcat/util/net/

[fhanik]

Author: fhanik
Date: Thu May 31 12:32:33 2007
New Revision: 543226

URL: http://svn.apache.org/viewvc?view=rev&rev=543226
Log:
1. Timeouts are now per connection, not using fixed timeouts anywhere. by 
default the connection gets the timeout defined in server.xml
2. Implemented all Comet operations, including the ability to have none
3. Implemented CometEvent.isReadable and isWriteable
   isAvailable - means data is available to the servlet
   isReadable - means there is data from the socket also checks the socket, by 
doing a read, in a non blocking fashion to verify this to be true
   isWriteable - the last write attempted on this socket was 0, hence we are 
probably blocking
4. simplified CometEvent.register/unregister, they are now just one call and no 
syncs
5. After each event, the connection is registered with the same operations it 
had before
6. CoyoteAdapter respects when the servlet doesn't want to be notified of the 
READ event, hence it doesn't invoke it automatically
7. Let me know if MutableBoolean and MutableInteger should be elsewhere(in 
terms of package), they are used since ActionHook doesn't have a return value 
and also valuable in the output buffers since SSL writing is two steps, one 
through the engine and the other to the socket
I'm pretty happy with how isReadable,isWriteable works, they are completly non 
blocking and very accurate
True non blocking in the buffers and filters seems like a major surgery, still 
holding off on that.
Need to fix the NioBlockingSelector as it is almost impossible to make the 
poller interest declaration thread safe


Added:
tomcat/trunk/java/org/apache/tomcat/util/MutableBoolean.java
tomcat/trunk/java/org/apache/tomcat/util/MutableInteger.java
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/java/org/apache/catalina/connector/Response.java
tomcat/trunk/java/org/apache/coyote/ActionCode.java
tomcat/trunk/java/org/apache/coyote/Response.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java
tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioChannel.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java
tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java?view=diff&rev=543226&r1=543225&r2=543226
==
--- tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java Thu May 
31 12:32:33 2007
@@ -29,6 +29,7 @@
 import org.apache.coyote.ActionCode;
 import org.apache.tomcat.util.net.PollerInterest;
 import java.util.Arrays;
+import org.apache.tomcat.util.MutableBoolean;
 
 public class CometEventImpl implements CometEvent {
 
@@ -142,12 +143,16 @@
 }
 
 public boolean isReadable() {
-return request.isReadable();
+return request.isAvailable() || request.isReadable();
 }
 public boolean isWriteable() {
 return response.isWriteable();
 }
 
+public boolean hasOp(CometEvent.CometOperation op) {
+return cometOperations.contains(op);
+}
+
 public void configure(CometEvent.CometConfiguration... options)
 throws IOException, IllegalStateException {
 checkWorkerThread();
@@ -169,7 +174,7 @@
 throws IOException, IllegalStateException {
 //remove from the registered set
 cometOperations.removeAll(Arrays.asList(operations));
-request.action(ActionCode.ACTION_COMET_UNREGISTER, 
translate(cometOperations.toArray(new CometOperation[0])));
+request.action(ActionCode.ACTION_COMET_REGISTER, 
translate(cometOperations.toArray(new CometOperation[0])));
 }
 
 public CometConfiguration[] getConfiguration() {

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?view=diff&rev=543226&r1=543225&r2=543226
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Thu May 
31 12:32:33 2007
@@ 

svn commit: r543227 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

[fhanik]

Author: fhanik
Date: Thu May 31 12:34:05 2007
New Revision: 543227

URL: http://svn.apache.org/viewvc?view=rev&rev=543227
Log:
rearrange

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?view=diff&rev=543227&r1=543226&r2=543227
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Thu 
May 31 12:34:05 2007
@@ -97,15 +97,6 @@
 return written;
 }
 
-private static void cancelKey(final NioChannel socket, final SelectionKey 
key) {
-socket.getPoller().addEvent(
-new Runnable() {
-public void run() {
-socket.getPoller().cancelledKey(key,SocketStatus.ERROR,false);
-}
-});
-}
-
 /**
  * Performs a blocking read using the bytebuffer for data to be read
  * If the selector parameter is null, then it will perform a 
busy read that could
@@ -162,6 +153,15 @@
 }
 }
 return read;
+}
+
+private static void cancelKey(final NioChannel socket, final SelectionKey 
key) {
+socket.getPoller().addEvent(
+new Runnable() {
+public void run() {
+socket.getPoller().cancelledKey(key,SocketStatus.ERROR,false);
+}
+});
 }
 
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543228 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioBlockingSelector.java NioSelectorPool.java

[fhanik]

Author: fhanik
Date: Thu May 31 12:44:27 2007
New Revision: 543228

URL: http://svn.apache.org/viewvc?view=rev&rev=543228
Log:
consolidate the usage of the NioChannel buffers  

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?view=diff&rev=543228&r1=543227&r2=543228
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Thu 
May 31 12:44:27 2007
@@ -48,10 +48,6 @@
 boolean timedout = false;
 int keycount = 1; //assume we can write
 long time = System.currentTimeMillis(); //start the timeout timer
-if (socket.getBufHandler().getWriteBuffer() != buf) {
-socket.getBufHandler().getWriteBuffer().put(buf);
-buf = socket.getBufHandler().getWriteBuffer();
-}
 try {
 while ( (!timedout) && buf.hasRemaining()) {
 if (keycount > 0) { //only write if we were registered for a 
write

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java?view=diff&rev=543228&r1=543227&r2=543228
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java Thu May 
31 12:44:27 2007
@@ -29,7 +29,6 @@
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
 import org.apache.tomcat.util.MutableInteger;
-import java.util.Iterator;
 
 /**
  *
@@ -138,6 +137,10 @@
 
 public int write(ByteBuffer buf, NioChannel socket, Selector selector, 
  long writeTimeout, boolean block,MutableInteger 
lastWrite) throws IOException {
+if (socket.getBufHandler().getWriteBuffer() != buf) {
+socket.getBufHandler().getWriteBuffer().put(buf);
+buf = socket.getBufHandler().getWriteBuffer();
+}
 if ( SHARED && block ) {
 return 
NioBlockingSelector.write(buf,socket,writeTimeout,lastWrite);
 }
@@ -146,10 +149,6 @@
 boolean timedout = false;
 int keycount = 1; //assume we can write
 long time = System.currentTimeMillis(); //start the timeout timer
-if ( socket.getBufHandler().getWriteBuffer()!= buf ) {
-socket.getBufHandler().getWriteBuffer().put(buf);
-buf = socket.getBufHandler().getWriteBuffer();
-}
 try {
 while ( (!timedout) && buf.hasRemaining() ) {
 int cnt = 0;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543235 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

[fhanik]

Author: fhanik
Date: Thu May 31 12:53:25 2007
New Revision: 543235

URL: http://svn.apache.org/viewvc?view=rev&rev=543235
Log:
restore original interest ops

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?view=diff&rev=543235&r1=543234&r2=543235
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Thu 
May 31 12:53:25 2007
@@ -44,6 +44,9 @@
  */
 public static int write(ByteBuffer buf, NioChannel socket, long 
writeTimeout,MutableInteger lastWrite) throws IOException {
 SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
+if ( key == null ) throw new IOException("Key no longer registered");
+KeyAttachment att = (KeyAttachment) key.attachment();
+int prevOps = att.interestOps() | 
(att.getCometOps()&NioEndpoint.OP_CALLBACK);
 int written = 0;
 boolean timedout = false;
 int keycount = 1; //assume we can write
@@ -61,12 +64,10 @@
 continue; //we successfully wrote, try again without a 
selector
 }
 }
-if ( key == null ) throw new IOException("Key no longer 
registered");
-KeyAttachment att = (KeyAttachment) key.attachment();
 try {
 if ( att.getWriteLatch()==null || 
att.getWriteLatch().getCount()==0) att.startWriteLatch(1);
 //only register for write if a write has not yet been 
issued
-if ( (att.interestOps() & SelectionKey.OP_WRITE) == 0) 
socket.getPoller().add(socket,SelectionKey.OP_WRITE);
+if ( (att.interestOps() & SelectionKey.OP_WRITE) == 0) 
socket.getPoller().add(socket,prevOps|SelectionKey.OP_WRITE);
 att.awaitWriteLatch(writeTimeout,TimeUnit.MILLISECONDS);
 }catch (InterruptedException ignore) {
 Thread.interrupted();
@@ -90,6 +91,7 @@
 cancelKey(socket, key);
 }
 }
+socket.getPoller().add(socket,prevOps);
 return written;
 }
 
@@ -107,7 +109,10 @@
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic
  */
 public static int read(ByteBuffer buf, NioChannel socket, long 
readTimeout) throws IOException {
-final SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
+SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
+if ( key == null ) throw new IOException("Key no longer registered");
+KeyAttachment att = (KeyAttachment) key.attachment();
+int prevOps = att.interestOps() | 
(att.getCometOps()&NioEndpoint.OP_CALLBACK);
 int read = 0;
 boolean timedout = false;
 int keycount = 1; //assume we can write
@@ -122,10 +127,9 @@
 if (cnt > 0)
 break;
 }
-KeyAttachment att = (KeyAttachment) key.attachment();
 try {
 if ( att.getReadLatch()==null || 
att.getReadLatch().getCount()==0) att.startReadLatch(1);
-if ( att.interestOps() == 0) 
socket.getPoller().add(socket,SelectionKey.OP_READ);
+if ( (att.interestOps() & SelectionKey.OP_READ) == 0) 
socket.getPoller().add(socket,prevOps|SelectionKey.OP_READ);
 att.awaitReadLatch(readTimeout,TimeUnit.MILLISECONDS);
 }catch (InterruptedException ignore) {
 Thread.interrupted();
@@ -148,6 +152,7 @@
 cancelKey(socket,key);
 }
 }
+socket.getPoller().add(socket,prevOps);
 return read;
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543237 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Thu May 31 12:55:12 2007
New Revision: 543237

URL: http://svn.apache.org/viewvc?view=rev&rev=543237
Log:
remove not used, at least until I've figured out the concurrency issue around 
the read/write

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=543237&r1=543236&r2=543237
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Thu May 31 
12:55:12 2007
@@ -484,8 +484,6 @@
 return poller;
 }
 
-protected Poller readWritePoller = null;
-
 /**
  * Dummy maxSpareThreads property.
  */



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543307 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

[remm]

Author: remm
Date: Thu May 31 16:08:24 2007
New Revision: 543307

URL: http://svn.apache.org/viewvc?view=rev&rev=543307
Log:
- 42559: I did not make equivalent modifications (the isCommitted method was 
not invoked on the facade).

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java?view=diff&rev=543307&r1=543306&r2=543307
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java 
Thu May 31 16:08:24 2007
@@ -104,7 +104,7 @@
 Throwable throwable =
 (Throwable) request.getAttribute(Globals.EXCEPTION_ATTR);
 
-if (response.isAppCommitted()) {
+if (response.isCommitted()) {
 return;
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42560] - Tomact quits unexpectedly

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42560


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 16:43 ---
Without a test case or steps to reproduce there is no way any one here is going
to be able to fix this for you. You would be better off asking for help on the
users list.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 16:47 ---
Configuration questions belong on the user list.

Also,

# Per prohibir que els usuaris accedeixin al WEB-INF de Tomcat

AllowOverride None
deny from all


suggests you are overlapping your httpd document root and one or more Tomcat
docBases. This is asking for a world of security pain. These should be kept
separate unless you are 100% sure of what you are doing and fully understand the
risks. Ask on the users list of you need information about this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543366 - in /tomcat/connectors/trunk/jk/xdocs: reference/apache.xml webserver_howto/apache.xml

[markt]

Author: markt
Date: Thu May 31 19:35:40 2007
New Revision: 543366

URL: http://svn.apache.org/viewvc?view=rev&rev=543366
Log:
Add a warning to the httpd docs. There have been a couple of security reports, 
bugs and questions to the users list about this recently.

Modified:
tomcat/connectors/trunk/jk/xdocs/reference/apache.xml
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/xdocs/reference/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/reference/apache.xml?view=diff&rev=543366&r1=543365&r2=543366
==
--- tomcat/connectors/trunk/jk/xdocs/reference/apache.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/reference/apache.xml Thu May 31 19:35:40 
2007
@@ -13,7 +13,8 @@
 
 
 
- 
+
+
 Most of the directives are allowed once in the global part of the Apache httpd
 configuration and once in every  elements. Exceptions from 
this rule are
 explicitely listed in the table below.
@@ -24,6 +25,10 @@
 Exceptions from this rule are
 again explicitely listed in the table below.
 
+The Apache httpd DocumentRoot should not overlap with a Tomcat Host's
+appBase or the docBase of any Context. Configuring httpd/Tomcat this way is 
very
+likely to result in JSP source code disclosure and/or other security issues.
+
 
 Here are the all directives supported by Apache:
 

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml?view=diff&rev=543366&r1=543365&r2=543366
==
--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Thu May 31 
19:35:40 2007
@@ -44,6 +44,11 @@
 and Apache.
 
 
+The Apache httpd DocumentRoot should not overlap with a Tomcat Host's
+appBase or the docBase of any Context. Configuring httpd/Tomcat this way is 
very
+likely to result in JSP source code disclosure and/or other security issues.
+
+
 
 This document was originally part of Tomcat: A Minimalistic User's 
Guide written by Gal Shachor,
 but has been split off for organizational reasons.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r543366 - in /tomcat/connectors/trunk/jk/xdocs: reference/apache.xml webserver_howto/apache.xml

[Bill Barker]

<[EMAIL PROTECTED]> wrote in message 
news:[EMAIL PROTECTED]
> Author: markt
> Date: Thu May 31 19:35:40 2007
> New Revision: 543366
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=543366
> Log:
> Add a warning to the httpd docs. There have been a couple of security 
> reports, bugs and questions to the users list about this recently.
>
> Modified:
>tomcat/connectors/trunk/jk/xdocs/reference/apache.xml
>tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
>
> Modified: tomcat/connectors/trunk/jk/xdocs/reference/apache.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/reference/apache.xml?view=diff&rev=543366&r1=543365&r2=543366
> ==
> --- tomcat/connectors/trunk/jk/xdocs/reference/apache.xml (original)
> +++ tomcat/connectors/trunk/jk/xdocs/reference/apache.xml Thu May 31 
> 19:35:40 2007
> @@ -13,7 +13,8 @@
>
> 
>
> - 
> +
> +
> Most of the directives are allowed once in the global part of the Apache 
> httpd
> configuration and once in every  elements. Exceptions 
> from this rule are
> explicitely listed in the table below.
> @@ -24,6 +25,10 @@
> Exceptions from this rule are
> again explicitely listed in the table below.
> 
> +The Apache httpd DocumentRoot should not overlap with a Tomcat 
> Host's
> +appBase or the docBase of any Context. Configuring httpd/Tomcat this way 
> is very
> +likely to result in JSP source code disclosure and/or other security 
> issues.
> +

IMHO, this is misleading.  It requires a lot more httpd configuration to 
make this secure, but it isn't in and of itself insecure.

And, if you are going to go this route, you should also warn about:
   Alias /myapp /var/tomcat/webapps/myapp


> 
> Here are the all directives supported by Apache:
> 
>
> Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
> URL: 
> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml?view=diff&rev=543366&r1=543365&r2=543366
> ==
> --- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml (original)
> +++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Thu May 31 
> 19:35:40 2007
> @@ -44,6 +44,11 @@
> and Apache.
> 
>
> +The Apache httpd DocumentRoot should not overlap with a Tomcat 
> Host's
> +appBase or the docBase of any Context. Configuring httpd/Tomcat this way 
> is very
> +likely to result in JSP source code disclosure and/or other security 
> issues.
> +
> +
> 
> This document was originally part of Tomcat: A Minimalistic User's 
> Guide written by Gal Shachor,
> but has been split off for organizational reasons. 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r543366 - in /tomcat/connectors/trunk/jk/xdocs: reference/apache.xml webserver_howto/apache.xml

[Mark Thomas]

Bill Barker wrote:
> <[EMAIL PROTECTED]> wrote in message 
>> +The Apache httpd DocumentRoot should not overlap with a Tomcat 
>> Host's
>> +appBase or the docBase of any Context. Configuring httpd/Tomcat this way 
>> is very
>> +likely to result in JSP source code disclosure and/or other security 
>> issues.
>> +
> 
> IMHO, this is misleading.  It requires a lot more httpd configuration to 
> make this secure, but it isn't in and of itself insecure.
> 
> And, if you are going to go this route, you should also warn about:
>Alias /myapp /var/tomcat/webapps/myapp
> 

I am not going to get upset if you want to commit some alternative
guidance. My main concern is that there is some warning as a number of
how-to guides seem to recommend it without the extra security and
there has been a rash of related e-mails recently.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 22:26 ---
Forgot to mention the answer to your question. Extra response headers set in the
Custom error page will be preserved and passed back to the client. 

Is there any strong reason why you are not doing this and why you want to set
the extra response headers in the Servlet/JSP from where error is thrown?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42409] - Extra response headers not sent when using custom error page

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42409





--- Additional Comments From [EMAIL PROTECTED]  2007-05-31 22:10 ---
James,
If you have any strong use-case for your requirement, this might be 
reconsidered.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

please publish a snapshot

[Paul McMahan]

Could someone please publish a snapshot of  http://svn.apache.org/ 
repos/asf/tomcat/trunk/  to the Apache snapshot repo?



Best wishes,
Paul


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r543093 - in /tomcat/connectors/trunk/jk: native/common/jk_mt.h xdocs/miscellaneous/changelog.xml xdocs/webserver_howto/apache.xml

[Peter Rossbach]

Hi Rainer,

patch works ;)

Thanks
Peter


Am 31.05.2007 um 19:09 schrieb Rainer Jung:


Could you try to find out, how pthread_t is defined on OS X?
Does the following patch help?

Index: jk_util.c
===
--- jk_util.c   (revision 542900)
+++ jk_util.c   (working copy)
@@ -1686,12 +1686,87 @@
 pthread_getunique_np(&t, &tid);
 return ((int)(tid.intId.lo & 0x));
 #else
-int tid = (int)(t & 0x);
+int tid = ((int)t) & 0x;
 return tid;
 #endif /* AS400 */
 }
 #endif


Regards,

Rainer

Peter Rossbach wrote:

Hi Rainer,
your _REENTRANT fix trigger a next MAC OS X problem:
eragon:~/workshop/tomcat-connectors-1.2.23-src/native peter$ make
Making all in common
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc - 
I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/ 
opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/ 
Home/include -I /Library/Java/Home/include/ -c jk_ajp12_worker.c - 
o jk_ajp12_worker.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc - 
I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/ 
opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/ 
Home/include -I /Library/Java/Home/include/ -c jk_connect.c -o  
jk_connect.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc - 
I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/ 
opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/ 
Home/include -I /Library/Java/Home/include/ -c jk_msg_buff.c -o  
jk_msg_buff.lo
/opt/local/share/apr-1/build/libtool --silent --mode=compile gcc - 
I/Users/peter/workshop/apache2/include -Wall -g -O2 -DHAVE_APR  -I/ 
opt/local/include/apr-1 -I/opt/local/include/apr-1 -Wall -DDARWIN - 
DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I /Library/Java/ 
Home/include -I /Library/Java/Home/include/ -c jk_util.c -o  
jk_util.lo

jk_util.c: In function 'jk_gettid':
jk_util.c:1723: error: invalid operands to binary &
make[1]: *** [jk_util.lo] Error 1
make: *** [all-recursive] Error 1
testet with apache 2.2.4.
Regards
peter
Am 31.05.2007 um 11:28 schrieb [EMAIL PROTECTED]:

Author: rjung
Date: Thu May 31 02:27:59 2007
New Revision: 543093

URL: http://svn.apache.org/viewvc?view=rev&rev=543093
Log:
Always build thread safe against Apache httpd 2.0/2.2
(unless configure detects --enable-prefork).
_REENTRANT flag for APR is not a safe threading detection
for all platforms.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_mt.h
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_mt.h
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/ 
native/common/jk_mt.h?view=diff&rev=543093&r1=543092&r2=543093
 
==

--- tomcat/connectors/trunk/jk/native/common/jk_mt.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_mt.h Thu May 31  
02:27:59 2007

@@ -33,18 +33,10 @@
 #define getpid()   ((int)GetThreadGroupID())
 #endif

-/*
- * All WIN32 code is MT, UNIX code that uses pthreads is marked  
by the POSIX

- * _REENTRANT define.
- */
-#if defined (WIN32) || defined(_REENTRANT) || (defined(NETWARE)  
&& defined(__NOVELL_LIBC__))

 #ifdef JK_PREFORK
 #define _MT_CODE 0
 #else
 #define _MT_CODE 1
-#endif
-#else
-#define _MT_CODE 0
 #endif

 /*

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/ 
changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/ 
xdocs/miscellaneous/changelog.xml? 
view=diff&rev=543093&r1=543092&r2=543093
 
==
--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml  
(original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml  
Thu May 31 02:27:59 2007

@@ -27,6 +27,10 @@
   
   
 
+  
+  Always build with thread support, unless flag --enable- 
prefork

+  is set during for configure. (rjung)
+  
   
   i5/OS (AS/400) V5R4 port where Apache 2.0 modules should  
now use UTF8. (hgomez)

   

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/ 
apache.xml
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/ 
xdocs/webserver_howto/apache.xml? 
view=diff&rev=543093&r1=543092&r2=543093
 
==
--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml  
(original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml  
Thu May 31 02:27:59 2007

@@ -838,25 +838,26 @@
 

 
-If you want to build mod_jk for Apache 1.3 and 

Re: please publish a snapshot

[Filip Hanik - Dev Lists]

Paul McMahan wrote:
Could someone please publish a snapshot of  
http://svn.apache.org/repos/asf/tomcat/trunk/  to the Apache snapshot 
repo?
you sure you want trunk, this branch is in modification mode and doesn't 
even have a scheduled release date nor has all changes yet been agreed 
upon,

I can publish the tc6.0.x snapshot if you wish

Filip



Best wishes,
Paul


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--No virus found in this incoming message.
Checked by AVG Free Edition.Version: 7.5.472 / Virus Database: 
269.8.4/825 - Release Date: 5/30/2007 3:03 PM






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]