[VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Rainer Jung

Hello to all Tomcat project members,

mod_jk 1.2.23 is available for testing under

http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/

It has been created from a branch based on 1.2.22 with only one code 
change (default forwarding option for Apache httpd module) and the 
corresponding clarification in the docs.


Please have a look. The updated documentation can be found at

http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/docs/jk-1.2.23

So here's the vote. Because we need to release soon, the vote, which 
will be open until today, Friday May 18, 24:00 GMT. I know this is 
pretty short, but I'm confident, that all usual suspects are on board.


Apache Tomcat Connectors 1.2.23 is:
[ ] Stable - no major issues, no regressions
[ ] Beta - at least one significant issue -- tell us what it is
[ ] Alpha - multiple significant issues -- tell us what they are

Thank you,

Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: tomcat 6.0.13 and maven 2

2007-05-18 Thread Sebastiaan van Erk

Anybody? :-)

Regards,
Sebastiaan

Sebastiaan van Erk wrote:

Hi,

I noticed the tomcat web pages are updated and the 6.0.13 version is 
available.


With maven I was able to use 6.0.10 with the following repository:

   
   tomcat-repository
   http://tomcat.apache.org/dev/dist/m2-repository/
   

However the 6.0.13 version is not there yet. Are there any plans to 
release the 6.0.13 version in this repository?


While I'm asking, is this the correct repository to use for the tomcat 
6 branch jars?


Regards,
Sebastiaan

-
To start a new topic, e-mail: [EMAIL PROTECTED]
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r539322 - /tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml

2007-05-18 Thread pero
Author: pero
Date: Fri May 18 01:50:57 2007
New Revision: 539322

URL: http://svn.apache.org/viewvc?view=rev&rev=539322
Log:
Add selectorTimeout default and a lot of value formatings.

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml?view=diff&rev=539322&r1=539321&r2=539322
==
--- tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml Fri May 18 01:50:57 2007
@@ -378,7 +378,7 @@
 Most of these attributes are directly linked to the socket implementation 
in the JDK so you can find out 
 about the actual meaning in the JDK API documentation.
 NoteOn some JDK versions, setTrafficClass causes a 
problem, a work around for this is to add 
-the -Djava.net.preferIPv4Stack=true value to your command line
+the -Djava.net.preferIPv4Stack=true value to your command 
line
 
 
   
@@ -398,11 +398,11 @@
   
   
 (int)The number of threads to be used to accept connections. 
Increase this value on a multi CPU machine,
-although you would never really need more than 2. Also, with a lot of 
non keep alive connections,
-you might want to increase this value as well. Default value is 1.
+although you would never really need more than 2. Also, 
with a lot of non keep alive connections,
+you might want to increase this value as well. Default value is 
1.
   
   
-(int)The number of threads to be used to run for the polling 
events. Default value is 1.
+(int)The number of threads to be used to run for the polling 
events. Default value is 1.
Can't see a reason to go above that. But experiment and find your 
own results.
   
   
@@ -423,15 +423,15 @@
   
 (int)The time in milliseconds to timeout on a select() for the 
poller.
This value is important, since connection clean up is done on the 
same thread, so dont set this 
-   value to an extremely high one.
+   value to an extremely high one. The default value is 
1000 milliseconds.
   
   
-(bool)Whether to allow comet servlets or not, Default value is 
true.
+(bool)Whether to allow comet servlets or not, Default value is 
true.
   
   
 (int)The protocol handler caches Http11NioProcessor objects to 
speed up performance.
This setting dictates how many of these objects get cached.
-   -1 means unlimited, default is 200. Set this value somewhere close 
to your maxThreads value.
+   -1 means unlimited, default is 200. Set 
this value somewhere close to your maxThreads value.
 
   
   
@@ -440,20 +440,20 @@
 direct memory space. On Sun's JDK that would be something like 
-XX:MaxDirectMemorySize=256m
   
   
-(int)The socket receive buffer (SO_RCVBUF) size in bytes. Default 
value is 25188
+(int)The socket receive buffer (SO_RCVBUF) size in bytes. Default 
value is 25188
   
   
-(int)The socket send buffer (SO_SNDBUF) size in bytes. Default 
value is 43800
+(int)The socket send buffer (SO_SNDBUF) size in bytes. Default 
value is 43800
   
   
 (int)Each connection that is opened up in Tomcat get associated 
with a read and a write ByteBuffer
-   This attribute controls the size of these buffers. By default this 
read buffer is sized at 8192 bytes.
+   This attribute controls the size of these buffers. By default this 
read buffer is sized at 8192 bytes.
For lower concurrency, you can increase this to buffer more data.
For an extreme amount of keep alive connections, decrease this 
number or increase your heap size.
   
   
 (int)Each connection that is opened up in Tomcat get associated 
with a read and a write ByteBuffer
-   This attribute controls the size of these buffers. By default this 
write buffer is sized at 8192 bytes.
+   This attribute controls the size of these buffers. By default this 
write buffer is sized at 8192 bytes.
For low concurrency you can increase this to buffer more response 
data.
For an extreme amount of keep alive connections, decrease this 
number or increase your heap size.

@@ -464,36 +464,36 @@
 (int)The Nio connector uses a class called NioChannel that holds 
elements linked to a socket.
To reduce garbage collection, the Nio connector caches these 
channel objects.
This value specifies the size of this cache.
-   The default value is 500, and represents that the cache will hold 
500 NioChannel objects.
-   Other values are -1. unlimited cache, and 0, no cache.
+   The default va

DO NOT REPLY [Bug 42451] New: - Tomcat 6 does not run with "Java Service Wrapper".

2007-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42451

   Summary: Tomcat 6 does not run with "Java Service Wrapper".
   Product: Tomcat 6
   Version: 6.0.10
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Starting Tomcat 6.0.x using the "Java Service Wrapper"
(http://sourceforge.net/projects/wrapper/) Tomcat stops immediately after start.
The wrapper logging displays:

...
jvm 1| 18.05.2007 12:56:07 org.apache.catalina.startup.Catalina start
jvm 1| INFO: Server startup in 1149 ms
jvm 1| WrapperStartStopApp: start main method completed
jvm 1| Wrapper Manager: ShutdownHook started
jvm 1| WrapperManager.stop(0) called by thread: Wrapper-Shutdown-Hook
jvm 1| Send a packet STOP : 0
jvm 1| 18.05.2007 12:56:07 org.apache.coyote.http11.Http11Protocol pause
jvm 1| INFO: Pausing Coyote HTTP/1.1 on http-8080
wrapperp | read a packet STOP : 0
wrapper  | JVM requested a shutdown. (0)
wrapper  | wrapperStopProcess(0) called.
wrapper  | Sending stop signal to JVM
wrapperp | send a packet STOP : NULL
...
jvm 1| Server daemon shut down
wrapper  | <-- Wrapper Stopped

It seems to be a Tomcat problem; (nearly) the same wrapper configuration file
can be used without problems with Tomcat 4.1.x, 5.0.x and 5.5.x.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42451] - Tomcat 6 does not run with "Java Service Wrapper".

2007-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42451


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-05-18 04:20 ---
Nothing here suggests a Tomcat issue, rather it suggests a JavaServiceWrapper
configuration issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: tomcat 6.0.13 and maven 2

2007-05-18 Thread Yoav Shapira

Hi,

On 5/18/07, Sebastiaan van Erk <[EMAIL PROTECTED]> wrote:

Anybody? :-)


There's typically a time lag between the release announcement and the
appearance of the files in the Maven repositories.  Want to contribute
scripts/time or otherwise help in making this faster?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Mark Thomas
Rainer Jung wrote:
> Apache Tomcat Connectors 1.2.23 is:
> [X] Stable - no major issues, no regressions
> [ ] Beta - at least one significant issue -- tell us what it is
> [ ] Alpha - multiple significant issues -- tell us what they are

No testing. I only reviewed the commit messages for 1.2.23

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: tomcat 6.0.13 and maven 2

2007-05-18 Thread Sebastiaan van Erk

Sure, no problem.

Just tell me what you need and where I should start and I'll look into it.

Regards,
Sebastiaan

Yoav Shapira wrote:

Hi,

On 5/18/07, Sebastiaan van Erk <[EMAIL PROTECTED]> wrote:

Anybody? :-)


There's typically a time lag between the release announcement and the
appearance of the files in the Maven repositories.  Want to contribute
scripts/time or otherwise help in making this faster?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: tomcat 6.0.13 and maven 2

2007-05-18 Thread Peter Rossbach
I think the script is res/maven/mvn-pub.xml, but  
mvn.properties.default is not up to date.

Hope Remy or Filip know correct username/password for upload.

Peter



Am 18.05.2007 um 13:00 schrieb Yoav Shapira:


Hi,

On 5/18/07, Sebastiaan van Erk <[EMAIL PROTECTED]> wrote:

Anybody? :-)


There's typically a time lag between the release announcement and the
appearance of the files in the Maven repositories.  Want to contribute
scripts/time or otherwise help in making this faster?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






DO NOT REPLY [Bug 42451] - Tomcat 6 does not run with "Java Service Wrapper".

2007-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42451





--- Additional Comments From [EMAIL PROTECTED]  2007-05-18 05:46 ---
JSW run with Tomcat 6!

You must start/stop tomcat with following setup:
...

wrapper.app.parameter.1=org.apache.catalina.startup.Bootstrap
wrapper.app.parameter.2=1
wrapper.app.parameter.3=start

wrapper.app.parameter.4=org.apache.catalina.startup.Bootstrap
wrapper.app.parameter.5=true
wrapper.app.parameter.6=1
wrapper.app.parameter.7=stop

Before send a bug report,  please wrote a mail to user list.
Peter

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Mladen Turk

Rainer Jung wrote:

Hello to all Tomcat project members,

Apache Tomcat Connectors 1.2.23 is:
[X] Stable - no major issues, no regressions
[ ] Beta - at least one significant issue -- tell us what it is
[ ] Alpha - multiple significant issues -- tell us what they are



Tested on Linux and Windoze.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: New branch ?

2007-05-18 Thread Remy Maucherat

Remy Maucherat wrote:

Hi,

Because of the amount of proposed API changes, it could be a good idea 
to start a new 6.x branch (with a short release cycle). Or is it 
acceptable to do these in 6.0.x ?


The list would be:
- new Comet capabilities, with non blocking IO
- revised EE integration APIs (for annotation processing)
- (proposed) port of storeconfig module, admin webapp, tester webapp (if 
there are volunteers)


Comments ?


According to the general consensus, the idea would be to have a branch 
to hold the 6.0.x code, and continue development in an independent way.


http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tc6.0.x ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Rainer Jung

Apache Tomcat Connectors 1.2.23 is:
[X] Stable - no major issues, no regressions
[ ] Beta - at least one significant issue -- tell us what it is
[ ] Alpha - multiple significant issues -- tell us what they are


Tested on Linux 64 Bit.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Guenter Knauf
Hi,
> Apache Tomcat Connectors 1.2.23 is:
> [x] Stable - no major issues, no regressions
> [ ] Beta - at least one significant issue -- tell us what it is
> [ ] Alpha - multiple significant issues -- tell us what they are

tested on NetWare with our standard Tomcat applications.

Binaries uploaded to:
http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/binaries/netware/

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Jim Jagielski


On May 18, 2007, at 3:33 AM, Rainer Jung wrote:


Hello to all Tomcat project members,

mod_jk 1.2.23 is available for testing under

http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/

It has been created from a branch based on 1.2.22 with only one  
code change (default forwarding option for Apache httpd module) and  
the corresponding clarification in the docs.


Please have a look. The updated documentation can be found at

http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/docs/jk-1.2.23

So here's the vote. Because we need to release soon, the vote,  
which will be open until today, Friday May 18, 24:00 GMT. I know  
this is pretty short, but I'm confident, that all usual suspects  
are on board.


Apache Tomcat Connectors 1.2.23 is:
[X] Stable - no major issues, no regressions
[ ] Beta - at least one significant issue -- tell us what it is
[ ] Alpha - multiple significant issues -- tell us what they are



Tested.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: New branch ?

2007-05-18 Thread Remy Maucherat

Yoav Shapira wrote:

Hola,

On 5/18/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tc6.0.x ?


Or 
http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/annotationsAndComet 


If it gets that experimental, it should go to the sandbox instead. 
Overall, I don't like a branch named against a random feature.


If development remains in trunk, then the version number or eventual 
release is not implied by anything.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: New branch ?

2007-05-18 Thread Yoav Shapira

Hola,

On 5/18/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tc6.0.x ?


Or 
http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/annotationsAndComet

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42438] - Duplicate JSP temp variable declaration when jsp:attribute used in conjunction with custom tags

2007-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42438





--- Additional Comments From [EMAIL PROTECTED]  2007-05-18 08:49 ---
I've checked the Tomcat 5.5.23 code, and it looks like it exhibits the exact
same problem.  I believe that the two patches I listed would solve the problem
in 5.5.23, as well.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r539541 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-05-18 Thread pero
Author: pero
Date: Fri May 18 11:01:34 2007
New Revision: 539541

URL: http://svn.apache.org/viewvc?view=rev&rev=539541
Log:
Remove unused local variable step 

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=539541&r1=539540&r2=539541
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
May 18 11:01:34 2007
@@ -949,7 +949,6 @@
  */
 protected boolean setSocketOptions(SocketChannel socket) {
 // Process the connection
-int step = 1;
 try {
 //disable blocking, APR style, we are gonna be polling it
 socket.configureBlocking(false);
@@ -958,9 +957,7 @@
 
 NioChannel channel = nioChannels.poll();
 if ( channel == null ) {
-// 2: SSL setup
-step = 2;
-
+// SSL setup
 if (sslContext != null) {
 SSLEngine engine = createSSLEngine();
 int appbufsize = 
engine.getSession().getApplicationBufferSize();
@@ -969,14 +966,14 @@

socketProperties.getDirectBuffer());
 channel = new SecureNioChannel(socket, engine, bufhandler, 
selectorPool);
 } else {
+// normal tcp setup
 NioBufferHandler bufhandler = new 
NioBufferHandler(socketProperties.getAppReadBufSize(),

socketProperties.getAppWriteBufSize(),

socketProperties.getDirectBuffer());
 
 channel = new NioChannel(socket, bufhandler);
 }
-} else {
-
+} else {
 channel.setIOChannel(socket);
 if ( channel instanceof SecureNioChannel ) {
 SSLEngine engine = createSSLEngine();
@@ -986,7 +983,6 @@
 }
 }
 getPoller0().register(channel);
-
 } catch (Throwable t) {
 try {
 log.error("",t);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r539539 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-05-18 Thread pero
Author: pero
Date: Fri May 18 10:57:16 2007
New Revision: 539539

URL: http://svn.apache.org/viewvc?view=rev&rev=539539
Log:
Remove unsused firstReadTimeout attribute 
Set correct default pollerThreadCount

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=539539&r1=539538&r2=539539
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
May 18 10:57:16 2007
@@ -32,7 +32,6 @@
 import java.nio.channels.SocketChannel;
 import java.security.KeyStore;
 import java.util.Collection;
-import java.util.Comparator;
 import java.util.Iterator;
 import java.util.Set;
 import java.util.StringTokenizer;
@@ -430,15 +429,6 @@
 public int getSoTimeout() { return socketProperties.getSoTimeout(); }
 public void setSoTimeout(int soTimeout) { 
socketProperties.setSoTimeout(soTimeout); }
 
-
-/**
- * Timeout on first request read before going to the poller, in ms.
- */
-protected int firstReadTimeout = 6;
-public int getFirstReadTimeout() { return firstReadTimeout; }
-public void setFirstReadTimeout(int firstReadTimeout) { 
this.firstReadTimeout = firstReadTimeout; }
-
-
 /**
  * The default is true - the created threads will be
  *  in daemon mode. If set to false, the control thread
@@ -478,7 +468,7 @@
 /**
  * Poller thread count.
  */
-protected int pollerThreadCount = 0;
+protected int pollerThreadCount = 1;
 public void setPollerThreadCount(int pollerThreadCount) { 
this.pollerThreadCount = pollerThreadCount; }
 public int getPollerThreadCount() { return pollerThreadCount; }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: New branch ?

2007-05-18 Thread Rainer Jung

Hi,

I think Yoav might have misunderstood your suggestion. I interprete the 
branch you posted as the one, you suggest to use for the maintenance of 
the existing 6.0.x source and to use trunk to proceed with working on 
annotations, comet etc.


What I would find a little strange, would be using

http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/

as the trunk and working on 6.next there. Unfortunately svn does neither 
have tags nor branches, so we are free to produce very complicated 
constructions if we like :)


My impression is, that

http://svn.apache.org/repos/asf/tomcat/tc6.0.x/

in fact is a branch, namely the 6.0 development branch and should 
contain all 6.0 development. The mainstream parts in


http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/

(it's actually the head of 6.0), the more experimental parts, which are 
still planned for first release in 6.0 and not in 6.next would be 
developped in


http://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches

So development which is targeted against 6.next in my opinion should go 
into


http://svn.apache.org/repos/asf/tomcat/trunk/

(which means we would have several paths with the word trunk in them) or 
we reorganize (puuh) by moving


http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/

into

http://svn.apache.org/repos/asf/tomcat/branches/tc6.0.x/
http://svn.apache.org/repos/asf/tomcat/branches/
http://svn.apache.org/repos/asf/tomcat/tags/

and delete the then empty 
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/


Of course this will break a lot and at the end we will most likely use a 
construction close to what we have now, but this layout seems to be the 
most traditional.


Regards,

Rainer

Remy Maucherat wrote:

Yoav Shapira wrote:

Hola,

On 5/18/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tc6.0.x ?


Or 
http(s)://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/annotationsAndComet 



If it gets that experimental, it should go to the sandbox instead. 
Overall, I don't like a branch named against a random feature.


If development remains in trunk, then the version number or eventual 
release is not implied by anything.


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r539542 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-05-18 Thread pero
Author: pero
Date: Fri May 18 11:05:40 2007
New Revision: 539542

URL: http://svn.apache.org/viewvc?view=rev&rev=539542
Log:
Hups, Http11NioProcessor need FirstReadTimeout at strange way.. Sorry!

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=539542&r1=539541&r2=539542
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
May 18 11:05:40 2007
@@ -430,6 +430,13 @@
 public void setSoTimeout(int soTimeout) { 
socketProperties.setSoTimeout(soTimeout); }
 
 /**
+  * Timeout on first request read before going to the poller, in ms.
+ */
+protected int firstReadTimeout = 6;
+public int getFirstReadTimeout() { return firstReadTimeout; }
+public void setFirstReadTimeout(int firstReadTimeout) { 
this.firstReadTimeout = firstReadTimeout; }
+
+/**
  * The default is true - the created threads will be
  *  in daemon mode. If set to false, the control thread
  *  will not be daemon - and will keep the process alive.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[RESULT][VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Rainer Jung
We received five stable votes (Mark, Mladen, Günter, Jim and me) and no 
other votes.


Since we should do this release quick, I'm now starting to publish the 
release.


Thanks to everyone who helped in immediate testing!

Regards,

Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r539553 - in /tomcat/site/trunk: docs/download-connectors.html xdocs/download-connectors.xml

2007-05-18 Thread rjung
Author: rjung
Date: Fri May 18 11:41:58 2007
New Revision: 539553

URL: http://svn.apache.org/viewvc?view=rev&rev=539553
Log:
Update connectors download page for new release 1.2.23.

Modified:
tomcat/site/trunk/docs/download-connectors.html
tomcat/site/trunk/xdocs/download-connectors.xml

Modified: tomcat/site/trunk/docs/download-connectors.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-connectors.html?view=diff&rev=539553&r1=539552&r2=539553
==
--- tomcat/site/trunk/docs/download-connectors.html (original)
+++ tomcat/site/trunk/docs/download-connectors.html Fri May 18 11:41:58 2007
@@ -222,7 +222,7 @@
 
 
 JK 1.2 (
-WARNING: Critical vulnerabilities in previous 
versions
+WARNING: Important vulnerabilities in previous 
versions
 ) 
 
 
@@ -233,18 +233,18 @@
 
 
 
-JK
 1.2.22 Source Release tar.gz
+JK
 1.2.23 Source Release tar.gz
 
 
-[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/tomcat-connectors-1.2.22-src.tar.gz.asc";>pgp]
+[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.23/tomcat-connectors-1.2.23-src.tar.gz.asc";>pgp]
 
 
 
 
-JK
 1.2.22 Source Release zip
+JK
 1.2.23 Source Release zip
 
 
-[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/tomcat-connectors-1.2.22-src.zip.asc";>pgp]
+[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.23/tomcat-connectors-1.2.23-src.zip.asc";>pgp]
 
 
 

Modified: tomcat/site/trunk/xdocs/download-connectors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/download-connectors.xml?view=diff&rev=539553&r1=539552&r2=539553
==
--- tomcat/site/trunk/xdocs/download-connectors.xml (original)
+++ tomcat/site/trunk/xdocs/download-connectors.xml Fri May 18 11:41:58 2007
@@ -26,17 +26,17 @@
 
 
 
-JK 1.2 (WARNING: Critical vulnerabilities in previous 
versions) 
+JK 1.2 (WARNING: Important vulnerabilities in previous 
versions) 
 
 
 Source
-JK
 1.2.22 Source Release tar.gz
-[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/tomcat-connectors-1.2.22-src.tar.gz.asc";>pgp]
+JK
 1.2.23 Source Release tar.gz
+[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.23/tomcat-connectors-1.2.23-src.tar.gz.asc";>pgp]
 
 
 
-JK
 1.2.22 Source Release zip
-[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/tomcat-connectors-1.2.22-src.zip.asc";>pgp]
+JK
 1.2.23 Source Release zip
+[http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.23/tomcat-connectors-1.2.23-src.zip.asc";>pgp]
 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r539565 - in /tomcat/site/trunk: docs/security-jk.html xdocs/security-jk.xml

2007-05-18 Thread rjung
Author: rjung
Date: Fri May 18 12:10:19 2007
New Revision: 539565

URL: http://svn.apache.org/viewvc?view=rev&rev=539565
Log:
Update jk connectors security pages.

Modified:
tomcat/site/trunk/docs/security-jk.html
tomcat/site/trunk/xdocs/security-jk.xml

Modified: tomcat/site/trunk/docs/security-jk.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-jk.html?view=diff&rev=539565&r1=539564&r2=539565
==
--- tomcat/site/trunk/docs/security-jk.html (original)
+++ tomcat/site/trunk/docs/security-jk.html Fri May 18 12:10:19 2007
@@ -2,7 +2,7 @@
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
 
 
-Apache Tomcat - Apache Tomcat 6.x vulnerabilities
+Apache Tomcat - Apache Tomcat JK Connectors vulnerabilities
 
 
 
@@ -196,6 +196,62 @@
and the CVE list. Please send comments or corrections for these
vulnerabilities to the mailto:[EMAIL PROTECTED]">Tomcat
Security Team.
+
+  
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+Fixed in Apache Tomcat JK Connector 1.2.23
+
+
+
+
+
+
+
+
+
+important: Information disclosure
+   http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-1860";>
+   CVE-2007-1860 (patch for CVE-2007-0450 was insufficient)
+
+
+When multiple components (firewalls, caches, proxies and Tomcat)
+   process a request, the request URL should not get decoded multiple times
+   in an iterative way by these components. Otherwise it might be possible
+   to pass access control rules implemented on front of the last component
+   by applying multiple URL encoding to the request.
+   
+
+mod_jk before version 1.2.23 by default decoded request URLs inside 
Apache
+   httpd and forwarded the encoded URL to Tomcat, which itself did a second
+   decoding. This made it possible to pass a prefix JkMount for /someapp,
+   but actually access /otherapp on Tomcat. Starting with version 1.2.23
+   by default mod_jk forwards the original unchanged request URL to Tomcat.
+   You can achieve the same level of security for older versions by setting
+   the forwarding option "JkOption ForwardURICompatUnparsed".
+   
+
+Please note, that your configuration might contain a different 
forwarding
+   JkOption. In this case, please consult the
+   http://tomcat.apache.org/connectors-doc/reference/apache.html#Forwarding";>
+   forwarding documentation concerning the security implications.
+   The new default setting is more secure than before, but it breaks
+   interoperability with mod_rwrite.
+   
+
+Affects: All versions of JK, but only the Apache httpd mod_jk module
 
   
 

Modified: tomcat/site/trunk/xdocs/security-jk.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-jk.xml?view=diff&rev=539565&r1=539564&r2=539565
==
--- tomcat/site/trunk/xdocs/security-jk.xml (original)
+++ tomcat/site/trunk/xdocs/security-jk.xml Fri May 18 12:10:19 2007
@@ -3,7 +3,7 @@
 
   
 Apache Tomcat Project
-Apache Tomcat 6.x vulnerabilities
+Apache Tomcat JK Connectors vulnerabilities
   
 
 
@@ -21,6 +21,39 @@
and the CVE list. Please send comments or corrections for these
vulnerabilities to the mailto:[EMAIL PROTECTED]">Tomcat
Security Team.
+
+  
+
+  
+important: Information disclosure
+   http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-1860";>
+   CVE-2007-1860 (patch for CVE-2007-0450 was insufficient)
+
+When multiple components (firewalls, caches, proxies and Tomcat)
+   process a request, the request URL should not get decoded multiple times
+   in an iterative way by these components. Otherwise it might be possible
+   to pass access control rules implemented on front of the last component
+   by applying multiple URL encoding to the request.
+   
+
+mod_jk before version 1.2.23 by default decoded request URLs inside 
Apache
+   httpd and forwarded the encoded URL to Tomcat, which itself did a second
+   decoding. This made it possible to pass a prefix JkMount for /someapp,
+   but actually access /otherapp on Tomcat. Starting with version 1.2.23
+   by default mod_jk forwards the original unchanged request URL to Tomcat.
+   You can achieve the same level of security for older versions by setting
+   the forwarding option "JkOption ForwardURICompatUnparsed".
+   
+
+Please note, that your configuration might contain a different 
forwarding
+   JkOption. In this case, please consult the
+   http://tomcat.apache.org/connectors-doc/reference/apache.html#Forwarding";>
+   forwarding documentation concerning the security implications.
+   The new default setting is more secure than before, but it breaks
+   interoperability with mod_rwrite.
+   
+
+Affects: All versions of JK, but only the Apach

svn commit: r539573 - in /tomcat/site/trunk: docs/security-jk.html xdocs/security-jk.xml

2007-05-18 Thread rjung
Author: rjung
Date: Fri May 18 12:33:35 2007
New Revision: 539573

URL: http://svn.apache.org/viewvc?view=rev&rev=539573
Log:
Fix typo in connectors security page.

Modified:
tomcat/site/trunk/docs/security-jk.html
tomcat/site/trunk/xdocs/security-jk.xml

Modified: tomcat/site/trunk/docs/security-jk.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-jk.html?view=diff&rev=539573&r1=539572&r2=539573
==
--- tomcat/site/trunk/docs/security-jk.html (original)
+++ tomcat/site/trunk/docs/security-jk.html Fri May 18 12:33:35 2007
@@ -248,7 +248,7 @@
http://tomcat.apache.org/connectors-doc/reference/apache.html#Forwarding";>
forwarding documentation concerning the security implications.
The new default setting is more secure than before, but it breaks
-   interoperability with mod_rwrite.
+   interoperability with mod_rewrite.

 
 Affects: All versions of JK, but only the Apache httpd mod_jk module

Modified: tomcat/site/trunk/xdocs/security-jk.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-jk.xml?view=diff&rev=539573&r1=539572&r2=539573
==
--- tomcat/site/trunk/xdocs/security-jk.xml (original)
+++ tomcat/site/trunk/xdocs/security-jk.xml Fri May 18 12:33:35 2007
@@ -50,7 +50,7 @@
http://tomcat.apache.org/connectors-doc/reference/apache.html#Forwarding";>
forwarding documentation concerning the security implications.
The new default setting is more secure than before, but it breaks
-   interoperability with mod_rwrite.
+   interoperability with mod_rewrite.

 
 Affects: All versions of JK, but only the Apache httpd mod_jk module



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[ANN] Apache Tomcat JK 1.2.23 Web Server Connector released

2007-05-18 Thread Rainer Jung

The Apache Tomcat team is pleased to announce the immediate availability
of version 1.2.23 of the Apache Tomcat Connectors.

It contains connectors, which allow a web server such as Apache HTTPD,
Microsoft IIS and Sun Web Server to act as a front end to the Tomcat web
application server.

This version contains only one security fix:

CVE-2007-1860: Information disclosure
(patch for CVE-2007-0450 was insufficient)

With the mod_jk default configuration, double encoded URLs could break 
JkMount access control. A complete fix might need configuration 
adjustments. Please consult


http://tomcat.apache.org/security-jk.html

for a more detailed description. Please note, that this issue only 
affected the Apache HTTPD module mod_jk.


Source distribtions can be downloaded from an
Apache Software Foundation mirror at:

http://tomcat.apache.org/download-connectors.cgi

Binary distributions for a number of different operating systems and
web servers can be downloaded from an
Apache Software Foundation mirror at:

http://tomcat.apache.org/download-connectors.cgi

Documentation for using JK with Tomcat 3.3, 4.1, 5.0 and 5.5
can be found at:

http://tomcat.apache.org/connectors-doc/

Thank you,

-- The Apache Tomcat Team




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: New branch ?

2007-05-18 Thread Remy Maucherat

Rainer Jung wrote:

Hi,

I think Yoav might have misunderstood your suggestion. I interprete the 
branch you posted as the one, you suggest to use for the maintenance of 
the existing 6.0.x source and to use trunk to proceed with working on 
annotations, comet etc.


What I would find a little strange, would be using

http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/

as the trunk and working on 6.next there. Unfortunately svn does neither 
have tags nor branches, so we are free to produce very complicated 
constructions if we like :)


My impression is, that

http://svn.apache.org/repos/asf/tomcat/tc6.0.x/

in fact is a branch, namely the 6.0 development branch and should 
contain all 6.0 development. The mainstream parts in


http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/

(it's actually the head of 6.0), the more experimental parts, which are 
still planned for first release in 6.0 and not in 6.next would be 
developped in


http://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches

So development which is targeted against 6.next in my opinion should go 
into


http://svn.apache.org/repos/asf/tomcat/trunk/

(which means we would have several paths with the word trunk in them) or 
we reorganize (puuh) by moving


http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/

into

http://svn.apache.org/repos/asf/tomcat/branches/tc6.0.x/
http://svn.apache.org/repos/asf/tomcat/branches/
http://svn.apache.org/repos/asf/tomcat/tags/

and delete the then empty 
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/


Yes, it could maybe be the cleanest, but too annoying to do IMO. I would 
prefer the easy way you suggested and move current development to 
http://svn.apache.org/repos/asf/tomcat/trunk/ until there's a release 
plan and it is moved to a /tcy.y.x/trunk/ with the appropriate name.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42455] New: - localhost:8080 -- many (?all?) jsp code samples are 404...broken links?

2007-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42455

   Summary: localhost:8080 -- many (?all?) jsp code samples are
404...broken links?
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
   URL: http://localhost:8080/examples/jsp/jsp2/simpletag/hello.
jsp.html
OS/Version: Windows 2000
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I just installed Apache Tomcat/6.0.13 (in the default directory), and I was
looking for some jsp samples.  I found that the hyperlinks to the examples were
broken (404).  I searched the directory for the linked html file, and it really
isn't in the directory tree (=it isn't on disk).  I told the installer to add
examples.

This is the path on the local drive:
D:\Program Files\Apache Software Foundation\Tomcat 
6.0\webapps\examples\jsp\jsp2\el

This is the network path:
http://localhost:8080/examples/jsp/jsp2/simpletag/hello.jsp.html

After default install for windows (except, of course, include examples), your
localhost jsp code samples are 404.

http://localhost:8080/examples/jsp/jsp2/simpletag/hello.jsp.html

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42456] New: - JspC fails to generate valid code with TLD java.lang.String[]

2007-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42456

   Summary: JspC fails to generate valid code with TLD
java.lang.String[]
   Product: Tomcat 6
   Version: 6.0.10
  Platform: Other
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have a tag library with this attribute definition in the TLD:


  emphasis
  false
  true
  java.lang.String[]
  description


The JSP will compile if running inside of Tomcat, but I am using the
jspc-maven-plugin to execute JspC during my build, and it will not produce valid
Java code:

Embedded error: Unable to compile class for JSP

An error occurred at line: 6 in the jsp file: /a.jsp
Generated servlet error:
Syntax error on token "[", delete this token

An error occurred at line: 6 in the jsp file: /a.jsp
Generated servlet error:
Syntax error on token ";", delete this token

An error occurred at line: 6 in the jsp file: /a.jsp
Generated servlet error:
Syntax error, insert ")" to complete Expression

An error occurred at line: 6 in the jsp file: /a.jsp
Generated servlet error:
Syntax error on token ";", delete this token

An error occurred at line: 6 in the jsp file: /a.jsp
Generated servlet error:
Syntax error, insert "]" to complete Expression

An error occurred at line: 6 in the jsp file: /a.jsp
Generated servlet error:
Syntax error on token ")", delete this token

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]