svn commit: r531795 - in /tomcat/connectors/branches/tc5.0.x: coyote/src/java/org/apache/coyote/Request.java util/java/org/apache/tomcat/util/http/MimeHeaders.java

[jfclere]

Author: jfclere
Date: Tue Apr 24 00:16:14 2007
New Revision: 531795

URL: http://svn.apache.org/viewvc?view=rev&rev=531795
Log:
As per RFC2616, requests with multiple content-length headers are invalid.
Ported from tc5.5.x

Modified:

tomcat/connectors/branches/tc5.0.x/coyote/src/java/org/apache/coyote/Request.java

tomcat/connectors/branches/tc5.0.x/util/java/org/apache/tomcat/util/http/MimeHeaders.java

Modified: 
tomcat/connectors/branches/tc5.0.x/coyote/src/java/org/apache/coyote/Request.java
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/branches/tc5.0.x/coyote/src/java/org/apache/coyote/Request.java?view=diff&rev=531795&r1=531794&r2=531795
==
--- 
tomcat/connectors/branches/tc5.0.x/coyote/src/java/org/apache/coyote/Request.java
 (original)
+++ 
tomcat/connectors/branches/tc5.0.x/coyote/src/java/org/apache/coyote/Request.java
 Tue Apr 24 00:16:14 2007
@@ -308,7 +308,7 @@
 public long getContentLengthLong() {
 if( contentLength > -1 ) return contentLength;
 
-MessageBytes clB = headers.getValue("content-length");
+MessageBytes clB = headers.getUniqueValue("content-length");
 contentLength = (clB == null || clB.isNull()) ? -1 : clB.getLong();
 
 return contentLength;

Modified: 
tomcat/connectors/branches/tc5.0.x/util/java/org/apache/tomcat/util/http/MimeHeaders.java
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/branches/tc5.0.x/util/java/org/apache/tomcat/util/http/MimeHeaders.java?view=diff&rev=531795&r1=531794&r2=531795
==
--- 
tomcat/connectors/branches/tc5.0.x/util/java/org/apache/tomcat/util/http/MimeHeaders.java
 (original)
+++ 
tomcat/connectors/branches/tc5.0.x/util/java/org/apache/tomcat/util/http/MimeHeaders.java
 Tue Apr 24 00:16:14 2007
@@ -286,6 +286,25 @@
 return null;
 }
 
+/**
+ * Finds and returns a unique header field with the given name. If no such
+ * field exists, null is returned. If the specified header field is not
+ * unique then an [EMAIL PROTECTED] IllegalArgumentException} is thrown.
+ */
+public MessageBytes getUniqueValue(String name) {
+MessageBytes result = null;
+for (int i = 0; i < count; i++) {
+if (headers[i].getName().equalsIgnoreCase(name)) {
+if (result == null) {
+result = headers[i].getValue();
+} else {
+throw new IllegalArgumentException();
+}
+}
+}
+return result;
+}
+
 // bad shortcut - it'll convert to string ( too early probably,
 // encoding is guessed very late )
 public String getHeader(String name) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531811 - /tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

[hgomez]

Author: hgomez
Date: Tue Apr 24 00:53:59 2007
New Revision: 531811

URL: http://svn.apache.org/viewvc?view=rev&rev=531811
Log:
Update changelog with works in progress on i5/OS V5R4 port

Modified:
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?view=diff&rev=531811&r1=531810&r2=531811
==
--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Tue Apr 24 
00:53:59 2007
@@ -9,6 +9,7 @@
   
 Mladen Turk
 Rainer Jung
+Henri Gomez
 Changelog
   
 
@@ -21,6 +22,19 @@
   It should contain fixes made only after November 10th 2004, when the
   new documentation project for JK was started.
   
+
+
+  
+  
+
+  
+  i5/OS (AS/400) V5R4 port where Apache 2.0 modules should now use UTF8. 
(hgomez)
+  
+  
+  Docs: Add comments on i5/OS build for V5R4 and previous releases. 
(hgomez)
+  
+
+  
 
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531812 - /tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

[hgomez]

Author: hgomez
Date: Tue Apr 24 00:54:36 2007
New Revision: 531812

URL: http://svn.apache.org/viewvc?view=rev&rev=531812
Log:
Update documentation on i5/OS builds

Modified:
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml?view=diff&rev=531812&r1=531811&r2=531812
==
--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Tue Apr 24 
00:54:36 2007
@@ -206,7 +206,7 @@
 
 
 mod_jk.xxx - The Apache module, depending on your operating system, it 
will be mod_jk.so, mod_jk.nlm or
-or QZTCJK.SRVPGM (see the build section).
+or MOD_JK.SRVPGM (see the build section).
 
 
 workers.properties - A file that describes the host(s) and port(s) used 
by the workers (Tomcat processes).
@@ -1060,7 +1060,7 @@
 
 
 Create mod_jk library
-CRTLIB MOD_JK TEXT(‘Apache mod_jk tomcat connector 
module’)
+CRTLIB MOD_JK TEXT(‘Apache mod'jk tomcat connector 
module')
 Create service program source file
 CRTSRCPF MOD_JK/QSRVSRC TEXT(‘Service program source 
file’)
 Create the CL build program source file
@@ -1081,16 +1081,28 @@
 
 
 
-You could start to build all the modules of mod_jk :
+You could start to build all the modules of mod_jk (cases for V5R4 or previous 
releases):
 
 
-Copy the CL build program source from IFS
+Copy the CL build program source for i5/OS before V5R4 from IFS
 CPYFRMSTMF 
FROMSTMF('/home/apache/jk/native/apache-2.0/bldjk.qclsrc') +
 TOMBR('/QSYS.LIB/MOD_JK.LIB/QCLSRC.FILE/BLDJK.MBR') 
MBROPT(*REPLACE)
 Build the CL build program
 CRTCLPGM PGM(MOD_JK/BLDJK) SRCFILE(MOD_JK/QCLSRC) TEXT('Apache 
mod_jk build program')
 Launch the build
 CALL MOD_JK/BLDJK
+If the build if successfull, copy the new mod_jk module
+CRTDUPOBJ OBJ(MOD_JK) FROMLIB(MOD_JK) OBJTYPE(*SRVPGM) 
TOLIB(QHTTPSVR) NEWOBJ(MOD_JK)
+
+
+
+Copy the CL build program source for i5/OS V5R4 from IFS
+CPYFRMSTMF 
FROMSTMF('/home/apache/jk/native/apache-2.0/bldjk54.qclsrc') +
+TOMBR('/QSYS.LIB/MOD_JK.LIB/QCLSRC.FILE/BLDJK54.MBR') 
MBROPT(*REPLACE)
+Build the CL build program for i5/OS V5R4
+CRTCLPGM PGM(MOD_JK/BLDJK54) SRCFILE(MOD_JK/QCLSRC) TEXT('Apache 
mod_jk build program') TGTRLS(*CURRENT)
+Launch the build for i5/OS V5R4
+CALL MOD_JK/BLDJK54
 If the build if successfull, copy the new mod_jk module
 CRTDUPOBJ OBJ(MOD_JK) FROMLIB(MOD_JK) OBJTYPE(*SRVPGM) 
TOLIB(QHTTPSVR) NEWOBJ(MOD_JK)
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531813 - /tomcat/connectors/trunk/jk/native/common/jk_map.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 00:57:36 2007
New Revision: 531813

URL: http://svn.apache.org/viewvc?view=rev&rev=531813
Log:
Not more need for AS400 #ifdef since it use _REETRANT. Also make use of 
file_exists() instead of stat

Modified:
tomcat/connectors/trunk/jk/native/common/jk_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_map.c?view=diff&rev=531813&r1=531812&r2=531813
==
--- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue Apr 24 00:57:36 2007
@@ -249,7 +249,7 @@
 const char *l = jk_map_get_string(m, name, def);
 char **ar = NULL;
 
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *lasts;
 #endif
 
@@ -269,7 +269,7 @@
  * GS, in addition to VG's patch, we now need to
  * strtok also by a "*"
  */
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 for (p = strtok_r(v, " \t,", &lasts);
  p; p = strtok_r(NULL, " \t,", &lasts))
 #else
@@ -305,7 +305,7 @@
 {
 const char *l = jk_map_get_string(m, name, def);
 
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *lasts;
 #endif
 
@@ -326,7 +326,7 @@
  * GS, in addition to VG's patch, we now need to
  * strtok also by a "*"
  */
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 for (p = strtok_r(v, " \t,", &lasts);
  p; p = strtok_r(NULL, " \t,", &lasts))
 #else
@@ -849,9 +849,8 @@
 int rc = JK_FALSE;
 
 if (m && f) {
-struct stat statbuf;
 FILE *fp;
-if ((rc = stat(f, &statbuf)) == -1)
+if (jk_file_exists(f) != JK_TRUE)
 return JK_FALSE;
 #if defined(AS400) && !defined(AS400_UTF8)
 fp = fopen(f, "r, o_ccsid=0");



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531814 - /tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 00:58:44 2007
New Revision: 531814

URL: http://svn.apache.org/viewvc?view=rev&rev=531814
Log:
Not more need for AS400 #ifdef since it use _REENTRANT.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c?view=diff&rev=531814&r1=531813&r2=531814
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c Tue Apr 24 
00:58:44 2007
@@ -518,7 +518,7 @@
 char *line = NULL;
 char *name = NULL;
 char *value = NULL;
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *lasts;
 #endif
 
@@ -566,7 +566,7 @@
 jk_log(l, JK_LOG_DEBUG, "ajpv12_handle_response, read %s=%s", name,
value);
 if (0 == strcmp("Status", name)) {
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *numeric = strtok_r(value, " \t", &lasts);
 #else
 char *numeric = strtok(value, " \t");
@@ -578,7 +578,7 @@
"ajpv12_handle_response, invalid status code");
 return JK_FALSE;
 }
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 reason = jk_pool_strdup(s->pool, strtok_r(NULL, " \t", &lasts));
 #else
 reason = jk_pool_strdup(s->pool, strtok(NULL, " \t"));



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531815 - in /tomcat/connectors/trunk/jk/native/common: jk_util.c jk_util.h

[hgomez]

Author: hgomez
Date: Tue Apr 24 01:00:07 2007
New Revision: 531815

URL: http://svn.apache.org/viewvc?view=rev&rev=531815
Log:
define jk_stat(). On i5/OS the jk_stat will do the ASCII->EBCDIC conversion and 
next call stat().
On others platform jk_stat is just stat

Modified:
tomcat/connectors/trunk/jk/native/common/jk_util.c
tomcat/connectors/trunk/jk/native/common/jk_util.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?view=diff&rev=531815&r1=531814&r2=531815
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Tue Apr 24 01:00:07 2007
@@ -525,7 +525,15 @@
 used = usable_size;
 }
 buf[used] = 0;
+
+/*
+ * MCH errors encountered on i5/OS (V5R3/V5R4) when using jk_logger, use the 
JOBLOB QPRINT instead for now
+ */
+#ifdef AS400
+   printf("%s\n", buf);
+#else
 l->log(l, level, buf);
+#endif
 #ifdef NETWARE
 free(buf);
 #endif
@@ -1390,43 +1398,33 @@
 }
 
 
-int jk_file_exists(const char *f)
-{
-  int   rc;
-  char *ptr;
-
-if (f) {
-struct stat st;
-
-#ifdef AS400
-
 /**
  * i5/OS V5R4 expect filename in ASCII for fopen but required them in EBCDIC 
for stat()
  */
 #ifdef AS400_UTF8
 
-   ptr = (char *)malloc(strlen(f) + 1);
-   jk_ascii2ebcdic((char *)f, ptr);
-   rc = stat(ptr, &st);
-   free(ptr);
-
-if ((0 == rc) && (st.st_mode & _S_IFREG))
-   return JK_TRUE;
+int jk_stat(const char *f, struct stat * statbuf)
+{
+   char *ptr;
+   int rc;
 
-#else /* AS400_UTF8 */
+   ptr = (char *)malloc(strlen(f) + 1);
+   jk_ascii2ebcdic((char *)f, ptr);
+   rc = stat(ptr, statbuf);
+   free(ptr);
 
-if ((0 == stat(f, &st)) && (st.st_mode & _S_IFREG))
-   return JK_TRUE;
+   return (rc);
+}
 
-#endif /* AS400_UTF8 */
+#endif
 
-#else /* AS400 */
+int jk_file_exists(const char *f)
+{
+if (f) {
+struct stat st;
 
-if ((0 == stat(f, &st)) && (st.st_mode & S_IFREG))
+if ((0 == jk_stat(f, &st)) && (st.st_mode & S_IFREG))
return JK_TRUE;
-
-#endif /* AS400 */
-
 }
 
 return JK_FALSE;
@@ -1582,7 +1580,7 @@
 char **jk_parse_sysprops(jk_pool_t *p, const char *sysprops)
 {
 char **rc = NULL;
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *lasts;
 #endif
 
@@ -1600,7 +1598,7 @@
 rc = jk_pool_alloc(p, (num_of_prps + 1) * sizeof(char *));
 if (rc) {
 unsigned i = 0;
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *tmp = strtok_r(prps, "*", &lasts);
 #else
 char *tmp = strtok(prps, "*");
@@ -1608,7 +1606,7 @@
 
 while (tmp && i < num_of_prps) {
 rc[i] = tmp;
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 tmp = strtok_r(NULL, "*", &lasts);
 #else
 tmp = strtok(NULL, "*");

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.h?view=diff&rev=531815&r1=531814&r2=531815
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.h Tue Apr 24 01:00:07 2007
@@ -211,10 +211,26 @@
 #define TC41_BRIDGE_TYPE41
 #define TC50_BRIDGE_TYPE50
 
+#ifdef AS400
+
+#define S_IFREG _S_IFREG
+
 #ifdef AS400_UTF8
+
 void jk_ascii2ebcdic(char *src, char *dst);
 void jk_ebcdic2ascii(char *src, char *dst);
+
+/* i5/OS V5R4 need ASCII-EBCDIC conversion before stat() call */
+int jk_stat(const char *f, struct stat * statbuf);
+
+#else /* AS400_UTF8 */
+
+#define jk_stat(a, b) stat(a, b)
+
+#endif /* AS400_UTF8 */
+
 #endif
+
 
 #ifdef __cplusplus
 extern "C"



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531816 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 01:00:50 2007
New Revision: 531816

URL: http://svn.apache.org/viewvc?view=rev&rev=531816
Log:
Not more need for AS400 #ifdef since it use _REENTRANT.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=531816&r1=531815&r2=531816
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Apr 24 01:00:50 
2007
@@ -917,7 +917,7 @@
 {
 jk_map_t *m;
 status_worker_t *w = p->worker;
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 char *lasts;
 #endif
 char *param;
@@ -949,7 +949,7 @@
 JK_TRACE_EXIT(l);
 return JK_FALSE;
 }
-#if defined(AS400) || defined(_REENTRANT)
+#ifdef _REENTRANT
 for (param = strtok_r(query, "&", &lasts);
  param; param = strtok_r(NULL, "&", &lasts)) {
 #else
@@ -2437,7 +2437,7 @@
 int mime;
 const char *arg;
 unsigned int hide_legend;
-
+
 JK_TRACE_ENTER(l);
 status_get_string(p, JK_STATUS_ARG_MIME, NULL, &arg, l);
 mime = status_mime_int(arg);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531817 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 01:01:29 2007
New Revision: 531817

URL: http://svn.apache.org/viewvc?view=rev&rev=531817
Log:
Make use of jk_stat()

Modified:
tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c?view=diff&rev=531817&r1=531816&r2=531817
==
--- tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c Tue Apr 24 
01:01:29 2007
@@ -715,7 +715,7 @@
 if (uw_map->reload > 0 && difftime(now, uw_map->checked) > uw_map->reload) 
{
 struct stat statbuf;
 uw_map->checked = now;
-if ((rc = stat(uw_map->fname, &statbuf)) == -1) {
+if ((rc = jk_stat(uw_map->fname, &statbuf)) == -1) {
 jk_log(l, JK_LOG_ERROR,
"Unable to stat the %s (errno=%d)",
uw_map->fname, errno);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531819 - in /tomcat/connectors/trunk/jk/native/common: jk_connect.c jk_connect.h

[hgomez]

Author: hgomez
Date: Tue Apr 24 01:02:47 2007
New Revision: 531819

URL: http://svn.apache.org/viewvc?view=rev&rev=531819
Log:
Define a jk_inet_addr. On i5/OS jk_inet_addr make ASCII-EBCDIC conversion then 
call inet_addr.
On other platform jk_inet_addr = inet_addr

Modified:
tomcat/connectors/trunk/jk/native/common/jk_connect.c
tomcat/connectors/trunk/jk/native/common/jk_connect.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_connect.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_connect.c?view=diff&rev=531819&r1=531818&r2=531819
==
--- tomcat/connectors/trunk/jk/native/common/jk_connect.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_connect.c Tue Apr 24 01:02:47 
2007
@@ -222,6 +222,27 @@
 }
 #endif
 
+
+#ifdef AS400_UTF8
+
+/*
+ *  i5/OS V5R4 need EBCDIC for its runtime calls but APR/APACHE works in UTF
+ */
+in_addr_t jk_inet_addr(const char * addrstr)
+{
+   in_addr_t addr;
+   char *ptr;
+
+   ptr = (char *)malloc(strlen(addrstr) + 1);
+   jk_ascii2ebcdic((char *)addrstr, ptr);
+   addr = inet_addr(ptr);
+   free(ptr);
+
+   return(addr);
+}
+
+#endif
+
 /** resolve the host IP */
 
 int jk_resolve(const char *host, int port, struct sockaddr_in *rc)
@@ -271,11 +292,7 @@
 
 apr_sockaddr_ip_get(&remote_ipaddr, remote_sa);
 
-   /* i5/OS V5R4 need EBCDIC for its runtime calls but APR/APACHE 
works in UTF */
-#ifdef AS400_UTF8
-jk_ascii2ebcdic(remote_ipaddr, remote_ipaddr);
-#endif
-laddr.s_addr = inet_addr(remote_ipaddr);
+laddr.s_addr = jk_inet_addr(remote_ipaddr);
 
 #else /* HAVE_APR */
 
@@ -295,12 +312,8 @@
 #endif /* HAVE_APR */
 }
 else {
-   /* i5/OS V5R4 need EBCDIC for its runtime calls but APR/APACHE 
works in UTF */
-#ifdef AS400_UTF8
-jk_ascii2ebcdic((char *)host, (char *)host);
-#endif
 /* If we found only digits we use inet_addr() */
-laddr.s_addr = inet_addr(host);
+laddr.s_addr = jk_inet_addr(host);
 }
 memcpy(&(rc->sin_addr), &laddr, sizeof(laddr));
 

Modified: tomcat/connectors/trunk/jk/native/common/jk_connect.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_connect.h?view=diff&rev=531819&r1=531818&r2=531819
==
--- tomcat/connectors/trunk/jk/native/common/jk_connect.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_connect.h Tue Apr 24 01:02:47 
2007
@@ -56,6 +56,17 @@
 
 int jk_is_socket_connected(jk_sock_t sd);
 
+
+/***
+ * i5/OS V5R4 need ASCII<->EBCDIC translation for inet_addr() call
+ */
+#if !defined(AS400_UTF8)
+
+#define jk_inet_addr inet_addr
+
+#endif
+
+
 #ifdef __cplusplus
 }
 #endif  /* __cplusplus */



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531821 - /tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc

[hgomez]

Author: hgomez
Date: Tue Apr 24 01:03:37 2007
New Revision: 531821

URL: http://svn.apache.org/viewvc?view=rev&rev=531821
Log:
Restore previous settings

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc?view=diff&rev=531821&r1=531820&r2=531821
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc Tue Apr 24 
01:03:37 2007
@@ -1,214 +1,256 @@
 PGM
 CRTCMOD MODULE(MOD_JK/MOD_JK) +
SRCSTMF('/home/apache/jk/native/apache-2.0/mod_jk.c') +
-   DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' + 
+   DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
   'USE_APACHE_MD5' '_REENTRANT') +
TEXT('mod_jk.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_AJP_COM) +
 SRCSTMF('/home/apache/jk/native/common/jk_ajp_common.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT') +
 TEXT('jk_ajp_common.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_AJP12_W) +
 SRCSTMF('/home/apache/jk/native/common/jk_ajp12_worker.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT') +
 TEXT('jk_ajp12_worker.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_AJP13) +
 SRCSTMF('/home/apache/jk/native/common/jk_ajp13.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +   
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT') +
 TEXT('jk_ajp13.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_AJP13_W) +
 SRCSTMF('/home/apache/jk/native/common/jk_ajp13_worker.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT') +
 TEXT('jk_ajp13_worker.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_AJP14) +
 SRCSTMF('/home/apache/jk/native/common/jk_ajp14.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT') +
 TEXT('jk_ajp14.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_AJP14_W) +
 SRCSTMF('/home/apache/jk/native/common/jk_ajp14_worker.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT') +
 TEXT('jk_ajp14_worker.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_CONNECT) +
 SRCSTMF('/home/apache/jk/native/common/jk_connect.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=520' +
'USE_APACHE_MD5' '_REENTRANT' 'USE_SO_RCVTIMEO' +
'USE_SO_SNDTIMEO' ) +
 TEXT('jk_connect.c') +
 OPTIMIZE(40) +
 LOCALETYPE(*LOCALE) +
+SYSIFCOPT(*IFSIO) +
 LANGLVL(*EXTENDED) +
+TGTRLS(*CURRENT) +
 INCDIR('/home/apache/jk/native/common' '/QIBM/ProdData/HTTPA/Include')
 
 CRTCMOD MODULE(MOD_JK/JK_CONTEXT) +
 SRCSTMF('/home/apache/jk/native/common/jk_context.c') +
-DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_SOURCE=530' +  
+DEFINE('AS400' 'HAVE_JNI' 'HAVE_APR' '_XOPEN_S

UNSUBRSCRIBE...

[mahadevan iyer]

UNSUBRSCRIBE...

__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

UNSUBRSCRIBE...

[mahadevan iyer]

UNSUBRSCRIBE...

A.Mahadevan

__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

Hi to all,

I commited on the changes to make jk works on i5/OS V5R4 (didn't test
anymore on previous release since we upgraded to V5R4).

I still see 2 problems :

- Call to jk_logger still generate thread exceptions, so I temporary
fix that by using printf instead of l->log in jk_log() (jk_util.c).

/*
* MCH errors encountered on i5/OS (V5R3/V5R4) when using jk_logger,
use the JOBLOB QPRINT instead for now
*/
#ifdef AS400
printf("%s\n", buf);
#else
   l->log(l, level, buf);
#endif

- Another annoying problem is the HTTP 500 error in SOAP mode. It
seems the sent_bodyct flag is not set in Apache 2 side, which is
strange since I got reply from Tomcat (HTTP 500 in HEADER and
SOAPFault in BODY).

   if (rc > 0) {
   /* If tomcat returned no body and the status is not OK,
  let apache handle the error code */
   if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST) {
   jk_log(xconf->log, JK_LOG_INFO, "No body with status=%d"
  " for worker=%s",
  r->status, worker_name);
   JK_TRACE_EXIT(xconf->log);
   return r->status;
   }



[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (603):
status = 500
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (610):
Number of headers is = 1
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (666):
Header[0] [Content-Type] = [text/xml;charset=utf-8]
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=456 max=8192



[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] mod_jk.c (446): written
452 out of 452
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192



[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=2 max=8192
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1043):
05 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (1506):
AJP13 protocol: Reuse is OK
[Tue Apr 24 10:04:33 2007] [5620:0259] [debug] jk_ajp_common.c (2286):
recycling connection pool slot=0 for worker xylos-soa-850
[Tue Apr 24 10:04:33 2007] [5620:0259] [info]  mod_jk.c (2225): No
body with status=500 for worker=xylos-soa-850

Since the sent_bodyct should be set inside Apache 2.x, it may be
something specific to i5/OS IBM implementation of Apache 2.0. I'm
still looking for informations from Rochester Labs.

Do you know where the sent_bodyct is set in Apache 2.x, it will be
usefull to diagnose problem with IBMers ?


Regards

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531850 - /tomcat/site/trunk/xdocs/security-5.xml

[jfclere]

Author: jfclere
Date: Tue Apr 24 02:36:23 2007
New Revision: 531850

URL: http://svn.apache.org/viewvc?view=rev&rev=531850
Log:
Ported from tc5.5.x

Modified:
tomcat/site/trunk/xdocs/security-5.xml

Modified: tomcat/site/trunk/xdocs/security-5.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-5.xml?view=diff&rev=531850&r1=531849&r2=531850
==
--- tomcat/site/trunk/xdocs/security-5.xml (original)
+++ tomcat/site/trunk/xdocs/security-5.xml Tue Apr 24 02:36:23 2007
@@ -40,7 +40,7 @@
content-length headers.

 
-Affects: 5.0.0-5.0.HEAD, 5.5.0-5.5.22
+Affects: 5.0.0-5.0.30, 5.5.0-5.5.22
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Rainer Jung]

Hi Henri,

> - Another annoying problem is the HTTP 500 error in SOAP mode. It
> seems the sent_bodyct flag is not set in Apache 2 side, which is
> strange since I got reply from Tomcat (HTTP 500 in HEADER and
> SOAPFault in BODY).
>
> Since the sent_bodyct should be set inside Apache 2.x, it may be
> something specific to i5/OS IBM implementation of Apache 2.0. I'm
> still looking for informations from Rochester Labs.
>
> Do you know where the sent_bodyct is set in Apache 2.x, it will be
> usefull to diagnose problem with IBMers ?

include/httpd.h

/** A structure that represents the current request */
struct request_rec {
...
/** byte count in stream is for body */
apr_off_t sent_bodyct;
...

Initialization in server/protocol.c:

Value set to 0 in request_rec *ap_read_request(conn_rec *conn)

During request processing the value gets set to 1 in
modules/http/http_protocol.c.

AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_header_filter(ap_filter_t
*f, apr_bucket_brigade *b)
...
if (r->assbackwards) {
r->sent_bodyct = 1;
ap_remove_output_filter(f);
return ap_pass_brigade(f->next, b);
}
...
(further equest processing)
...
if (r->header_only) {
apr_brigade_destroy(b);
ctx->headers_sent = 1;
return OK;
}

r->sent_bodyct = 1;   /* Whatever follows is real body stuff... */
...

assbackwards is documented as:

/** HTTP/0.9, "simple" request (e.g. GET /foo\n w/no headers) */
int assbackwards;

Regards,

Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531857 - /tomcat/site/trunk/xdocs/security-5.xml

[jfclere]

Author: jfclere
Date: Tue Apr 24 02:59:19 2007
New Revision: 531857

URL: http://svn.apache.org/viewvc?view=rev&rev=531857
Log:
typo.

Modified:
tomcat/site/trunk/xdocs/security-5.xml

Modified: tomcat/site/trunk/xdocs/security-5.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-5.xml?view=diff&rev=531857&r1=531856&r2=531857
==
--- tomcat/site/trunk/xdocs/security-5.xml (original)
+++ tomcat/site/trunk/xdocs/security-5.xml Tue Apr 24 02:59:19 2007
@@ -81,7 +81,7 @@
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-7195";>
CVE-2006-7195
 
-The implict-objects.jsp in the examples webapp displayed a number of
+The implicit-objects.jsp in the examples webapp displayed a number of
unfiltered header values. This enabled a XSS attack. These values are 
now
filtered.
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

Ok, just add some log in mod_jk.c and see :

   if (rc > 0) {^M
   /* If tomcat returned no body and the status is not OK,^M
  let apache handle the error code */^M
jk_log(xconf->log, JK_LOG_INFO, "sent_bodyct=%d status=%d
header_only=%d" , r->sent_bodyct, r->status, r->header_only);
   if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST) {^M


SOAP reply (HTTP 200)

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=2 max=8192
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
05 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1506):
AJP13 protocol: Reuse is OK
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (2286):
recycling connection pool slot=0 for worker soa-850
[Tue Apr 24 11:57:48 2007] [5833:0273] [info]  mod_jk.c (2224):
sent_bodyct=0 status=200 header_only=0
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] mod_jk.c (2233):
Service finished with status=200 for worker=soa-850

SOAP FAULT (HTTP 500)

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=2 max=8192
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
05 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1506):
AJP13 protocol: Reuse is OK
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (2286):
recycling connection pool slot=0 for worker soa-850
[Tue Apr 24 11:55:27 2007] [5833:0024] [info]  mod_jk.c (2224):
sent_bodyct=0 status=500 header_only=0
[Tue Apr 24 11:55:27 2007] [5833:0024] [info]  mod_jk.c (2226): No
body with status=500 for worker=soa-850

It's strange but the sent_body is never set, so when HTTP 500 is
encountered, we think we got no BODY from Tomcat and fall back to
Apache 500 error.

Any idea ?

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:

Hi Henri,

> - Another annoying problem is the HTTP 500 error in SOAP mode. It
> seems the sent_bodyct flag is not set in Apache 2 side, which is
> strange since I got reply from Tomcat (HTTP 500 in HEADER and
> SOAPFault in BODY).
>
> Since the sent_bodyct should be set inside Apache 2.x, it may be
> something specific to i5/OS IBM implementation of Apache 2.0. I'm
> still looking for informations from Rochester Labs.
>
> Do you know where the sent_bodyct is set in Apache 2.x, it will be
> usefull to diagnose problem with IBMers ?

include/httpd.h

/** A structure that represents the current request */
struct request_rec {
...
/** byte count in stream is for body */
apr_off_t sent_bodyct;
...

Initialization in server/protocol.c:

Value set to 0 in request_rec *ap_read_request(conn_rec *conn)

During request processing the value gets set to 1 in
modules/http/http_protocol.c.

AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_header_filter(ap_filter_t
*f, apr_bucket_brigade *b)
...
if (r->assbackwards) {
r->sent_bodyct = 1;
ap_remove_output_filter(f);
return ap_pass_brigade(f->next, b);
}
...
(further equest processing)
...
if (r->header_only) {
apr_brigade_destroy(b);
ctx->headers_sent = 1;
return OK;
}

r->sent_bodyct = 1;   /* Whatever follows is real body stuff... */
...

assbackwards is documented as:

/** HTTP/0.9, "simple" request (e.g. GET /foo\n w/no headers) */
int assbackwards;

Regards,

Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

On my Linux test box, sent_body is allways set.

Did there is some default configuration in Apache 2.0 to flush header
automatically ?



2007/4/24, Henri Gomez <[EMAIL PROTECTED]>:

Ok, just add some log in mod_jk.c and see :

if (rc > 0) {^M
/* If tomcat returned no body and the status is not OK,^M
   let apache handle the error code */^M
jk_log(xconf->log, JK_LOG_INFO, "sent_bodyct=%d status=%d
header_only=%d" , r->sent_bodyct, r->status, r->header_only);
if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST) {^M


SOAP reply (HTTP 200)

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=2 max=8192
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1043):
05 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (1506):
AJP13 protocol: Reuse is OK
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] jk_ajp_common.c (2286):
recycling connection pool slot=0 for worker soa-850
[Tue Apr 24 11:57:48 2007] [5833:0273] [info]  mod_jk.c (2224):
sent_bodyct=0 status=200 header_only=0
[Tue Apr 24 11:57:48 2007] [5833:0273] [debug] mod_jk.c (2233):
Service finished with status=200 for worker=soa-850

SOAP FAULT (HTTP 500)

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=4 max=8192
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
received from ajp13 pos=0 len=2 max=8192
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1043):
05 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  -

[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (1506):
AJP13 protocol: Reuse is OK
[Tue Apr 24 11:55:27 2007] [5833:0024] [debug] jk_ajp_common.c (2286):
recycling connection pool slot=0 for worker soa-850
[Tue Apr 24 11:55:27 2007] [5833:0024] [info]  mod_jk.c (2224):
sent_bodyct=0 status=500 header_only=0
[Tue Apr 24 11:55:27 2007] [5833:0024] [info]  mod_jk.c (2226): No
body with status=500 for worker=soa-850

It's strange but the sent_body is never set, so when HTTP 500 is
encountered, we think we got no BODY from Tomcat and fall back to
Apache 500 error.

Any idea ?

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:
> Hi Henri,
>
> > - Another annoying problem is the HTTP 500 error in SOAP mode. It
> > seems the sent_bodyct flag is not set in Apache 2 side, which is
> > strange since I got reply from Tomcat (HTTP 500 in HEADER and
> > SOAPFault in BODY).
> >
> > Since the sent_bodyct should be set inside Apache 2.x, it may be
> > something specific to i5/OS IBM implementation of Apache 2.0. I'm
> > still looking for informations from Rochester Labs.
> >
> > Do you know where the sent_bodyct is set in Apache 2.x, it will be
> > usefull to diagnose problem with IBMers ?
>
> include/httpd.h
>
> /** A structure that represents the current request */
> struct request_rec {
> ...
> /** byte count in stream is for body */
> apr_off_t sent_bodyct;
> ...
>
> Initialization in server/protocol.c:
>
> Value set to 0 in request_rec *ap_read_request(conn_rec *conn)
>
> During request processing the value gets set to 1 in
> modules/http/http_protocol.c.
>
> AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_header_filter(ap_filter_t
> *f, apr_bucket_brigade *b)
> ...
> if (r->assbackwards) {
> r->sent_bodyct = 1;
> ap_remove_output_filter(f);
> return ap_pass_brigade(f->next, b);
> }
> ...
> (further equest processing)
> ...
> if (r->header_only) {
> apr_brigade_destroy(b);
> ctx->headers_sent = 1;
> return OK;
> }
>
> r->sent_bodyct = 1;   /* Whatever follows is real body stuff... */
> ...
>
> assbackwards is documented as:
>
> /** HTTP/0.9, "simple" request (e.g. GET /foo\n w/no headers) */
> int assbackwards;
>
> Regards,
>
> Rainer
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
>

Re: More on i5/OS and some modifications needed

[Henri Gomez]

checked that assbackwards is 0 on i5/OS

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:

Hi Henri,

> - Another annoying problem is the HTTP 500 error in SOAP mode. It
> seems the sent_bodyct flag is not set in Apache 2 side, which is
> strange since I got reply from Tomcat (HTTP 500 in HEADER and
> SOAPFault in BODY).
>
> Since the sent_bodyct should be set inside Apache 2.x, it may be
> something specific to i5/OS IBM implementation of Apache 2.0. I'm
> still looking for informations from Rochester Labs.
>
> Do you know where the sent_bodyct is set in Apache 2.x, it will be
> usefull to diagnose problem with IBMers ?

include/httpd.h

/** A structure that represents the current request */
struct request_rec {
...
/** byte count in stream is for body */
apr_off_t sent_bodyct;
...

Initialization in server/protocol.c:

Value set to 0 in request_rec *ap_read_request(conn_rec *conn)

During request processing the value gets set to 1 in
modules/http/http_protocol.c.

AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_header_filter(ap_filter_t
*f, apr_bucket_brigade *b)
...
if (r->assbackwards) {
r->sent_bodyct = 1;
ap_remove_output_filter(f);
return ap_pass_brigade(f->next, b);
}
...
(further equest processing)
...
if (r->header_only) {
apr_brigade_destroy(b);
ctx->headers_sent = 1;
return OK;
}

r->sent_bodyct = 1;   /* Whatever follows is real body stuff... */
...

assbackwards is documented as:

/** HTTP/0.9, "simple" request (e.g. GET /foo\n w/no headers) */
int assbackwards;

Regards,

Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531876 - in /tomcat/site/trunk: docs/security-5.html xdocs/security-5.xml

[markt]

Author: markt
Date: Tue Apr 24 04:04:57 2007
New Revision: 531876

URL: http://svn.apache.org/viewvc?view=rev&rev=531876
Log:
Update 5.0.x version in section headers.

Modified:
tomcat/site/trunk/docs/security-5.html
tomcat/site/trunk/xdocs/security-5.xml

Modified: tomcat/site/trunk/docs/security-5.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-5.html?view=diff&rev=531876&r1=531875&r2=531876
==
--- tomcat/site/trunk/docs/security-5.html (original)
+++ tomcat/site/trunk/docs/security-5.html Tue Apr 24 04:04:57 2007
@@ -211,8 +211,8 @@
 
 
 
-
-Fixed in Apache Tomcat 5.5.23
+
+Fixed in Apache Tomcat 5.5.23, 5.0.HEAD
 
 
 
@@ -238,7 +238,7 @@
content-length headers.

 
-Affects: 5.0.0-5.0.HEAD, 5.5.0-5.5.22
+Affects: 5.0.0-5.0.30, 5.5.0-5.5.22
   
 
 
@@ -294,7 +294,7 @@
restricting context access was used.
 
 
-Affects: 5.5.0-5.5.21, 5.0.0-5.0.30
+Affects: 5.0.0-5.0.30, 5.5.0-5.5.21
   
 
 
@@ -309,8 +309,8 @@
 
 
 
-
-Fixed in Apache Tomcat 5.5.18
+
+Fixed in Apache Tomcat 5.5.18, 5.0.HEAD
 
 
 
@@ -325,11 +325,11 @@
CVE-2006-7195
 
 
-The implict-objects.jsp in the examples webapp displayed a number of
+The implicit-objects.jsp in the examples webapp displayed a number of
unfiltered header values. This enabled a XSS attack. These values are 
now
filtered.
 
-Affects: 5.0.0-5.0.HEAD, 5.5.0-5.5.17
+Affects: 5.0.0-5.0.30, 5.5.0-5.5.17
   
 
 
@@ -344,8 +344,8 @@
 
 
 
-
-Fixed in Apache Tomcat 5.5.17
+
+Fixed in Apache Tomcat 5.5.17, 5.0.HEAD
 
 
 
@@ -364,7 +364,7 @@
including the anonymous cipher suite. The default configuration no
longer permits the use of insecure cipher suites.
 
-Affects: 5.0.0-5.0.HEAD, 5.5.0-5.5.17
+Affects: 5.0.0-5.0.30, 5.5.0-5.5.17
   
 
 

Modified: tomcat/site/trunk/xdocs/security-5.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-5.xml?view=diff&rev=531876&r1=531875&r2=531876
==
--- tomcat/site/trunk/xdocs/security-5.xml (original)
+++ tomcat/site/trunk/xdocs/security-5.xml Tue Apr 24 04:04:57 2007
@@ -24,7 +24,7 @@
 
   
 
-  
+  
 important: Information disclosure
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-2090";>
CVE-2005-2090
@@ -73,10 +73,10 @@
restricting context access was used.
 
 
-Affects: 5.5.0-5.5.21, 5.0.0-5.0.30
+Affects: 5.0.0-5.0.30, 5.5.0-5.5.21
   
 
-  
+  
 moderate: Cross-site scripting
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2006-7195";>
CVE-2006-7195
@@ -88,7 +88,7 @@
 Affects: 5.0.0-5.0.30, 5.5.0-5.5.17
   
 
-  
+  
 important: Information disclosure
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-1858";>
CVE-2007-1858



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42217] New: - Memory Leak with Comet

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42217

   Summary: Memory Leak with Comet
   Product: Tomcat 6
   Version: 6.0.11
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When I run my corrected test webapp from bug 42198 (
http://issues.apache.org/bugzilla/attachment.cgi?id=20025 ) in Tomcat 6
compiled from trunk, and load the index page of the webapp into a number of
browsers, the browsers start sending poll requests which are answered
asynchronously.

Tomcat consumes more and more memory with both Http11AprProtocol and
Http11NioProtocol.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42217] - Memory Leak with Comet

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42217


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 04:55 ---
This is not an appropriate bug report, sorry. You should be posting about your
Comet issues on the user list, only bug discussion is appropriate in bugzilla.
It is normal for memory allocation to occur, and processors used for Comet are
recycled for future usage.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42218] New: - CLIENT_DISCONNECT event missing

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42218

   Summary: CLIENT_DISCONNECT event missing
   Product: Tomcat 6
   Version: 6.0.11
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The behavior is easily reproducible for both Http11AprProtocol and
Http11NioProtocol by running my corrected test webapp from bug 42198 (
http://issues.apache.org/bugzilla/attachment.cgi?id=20025 ) in Tomcat 6 compiled
from trunk with the Servlet init parameter 'maxTimeout' set to 100 in web.xml.

Load the index page into a browser. When the page has started polling, close the
browser.
The Servlet's event method will get a READ event, tries to read from the input
stream, but there is nothing to read. Therefore, it simply returns.
However, it gets the READ presented again and again (with 100% CPU) until the
response is closed by the response provider thread.

Should the Servlet itself interpret a READ event with no bytes to read as a
client disconnect and close the event?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42218] - CLIENT_DISCONNECT event missing

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42218


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 05:11 ---
On some platforms, at least with APR, it is not possible to get the disconnect
status, in which case you get a READ and an exception trying to read data.
Again, please use the user list to discuss things before filing a bug report.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: 6.0.12 build

[Remy Maucherat]

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Peter Rossbach wrote:

Opps,

you are right! After a long night and two much test setups...


Ok, so after making the necessary fixes, I would like to propose a new 
6.0.12 build early next week.

sounds good!


Is it still good ? If it is, I could tag it tomorrow.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531901 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java

[remm]

Author: remm
Date: Tue Apr 24 05:24:34 2007
New Revision: 531901

URL: http://svn.apache.org/viewvc?view=rev&rev=531901
Log:
- Port Mark's patch.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java?view=diff&rev=531901&r1=531900&r2=531901
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/ManagerBase.java Tue 
Apr 24 05:24:34 2007
@@ -701,6 +701,8 @@
 if( initialized ) return;
 initialized=true;
 
+log = LogFactory.getLog(ManagerBase.class);
+
 if( oname==null ) {
 try {
 StandardContext ctx=(StandardContext)this.getContainer();



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

I'm looking for the exception in jk_log. It happen in ws_write right
now and I wonder what's the life cycle of main_log.

On i5/OS, the init / post are done on the same thread (not the same on Unixes).

How is reset the main_log ?

2007/4/24, Henri Gomez <[EMAIL PROTECTED]>:

checked that assbackwards is 0 on i5/OS

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:
> Hi Henri,
>
> > - Another annoying problem is the HTTP 500 error in SOAP mode. It
> > seems the sent_bodyct flag is not set in Apache 2 side, which is
> > strange since I got reply from Tomcat (HTTP 500 in HEADER and
> > SOAPFault in BODY).
> >
> > Since the sent_bodyct should be set inside Apache 2.x, it may be
> > something specific to i5/OS IBM implementation of Apache 2.0. I'm
> > still looking for informations from Rochester Labs.
> >
> > Do you know where the sent_bodyct is set in Apache 2.x, it will be
> > usefull to diagnose problem with IBMers ?
>
> include/httpd.h
>
> /** A structure that represents the current request */
> struct request_rec {
> ...
> /** byte count in stream is for body */
> apr_off_t sent_bodyct;
> ...
>
> Initialization in server/protocol.c:
>
> Value set to 0 in request_rec *ap_read_request(conn_rec *conn)
>
> During request processing the value gets set to 1 in
> modules/http/http_protocol.c.
>
> AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_header_filter(ap_filter_t
> *f, apr_bucket_brigade *b)
> ...
> if (r->assbackwards) {
> r->sent_bodyct = 1;
> ap_remove_output_filter(f);
> return ap_pass_brigade(f->next, b);
> }
> ...
> (further equest processing)
> ...
> if (r->header_only) {
> apr_brigade_destroy(b);
> ctx->headers_sent = 1;
> return OK;
> }
>
> r->sent_bodyct = 1;   /* Whatever follows is real body stuff... */
> ...
>
> assbackwards is documented as:
>
> /** HTTP/0.9, "simple" request (e.g. GET /foo\n w/no headers) */
> int assbackwards;
>
> Regards,
>
> Rainer
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Rainer Jung]

The flag is about the response body. We send the response back via a
webserver specific method. It's ws_write() ind mod_jk.c.

ws_write() calls e.g. ap_rwrite() which should in my opinion set
sent_bodyct. I'm careful about that, because I don't fully understand
the filter architecture involved.

But ws_write() also contains iSeries specific code. Maybe some of those
methods fail. You can log p->r->sent_bodyct inside ws_write and also add
some debug log to find out, if it stopps prematurely. Especially
ap_change_response_body_xlate() does not seem to be part of standard
apache code. No idea, if that has an interaction bug with filters.

Regards,

Rainer

Henri Gomez schrieb:
> On my Linux test box, sent_body is allways set.
> 
> Did there is some default configuration in Apache 2.0 to flush header
> automatically ?
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Rainer Jung]

main_log is a static in mod_jk.c, which is initialized as NULL.

It gets set inside open_jklog() which gets called once for every virtual
server by jk_post_config() during server initialization.

The first virtual server inherits its logger conf->log from its
configuration to main_log. It also registers a cleanup handler which
will NULL its conf->log, but that should not change main_log.

main_log should never get reset.

To find the problem, it would be best to first reduce the apache config
to not use any virtual servers.

You can log the value of main_log for debug purposes anywhere in
mod_jk.c, because its a global static.

Regards,

Rainer

Henri Gomez schrieb:
> I'm looking for the exception in jk_log. It happen in ws_write right
> now and I wonder what's the life cycle of main_log.
> 
> On i5/OS, the init / post are done on the same thread (not the same on
> Unixes).
> 
> How is reset the main_log ?
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

I made it works by adding main_log = NULL in jklog_cleanup

static apr_status_t jklog_cleanup(void *d)
{
   /* set the main_log to NULL */
   d = NULL;
   main_log = NULL;
   return APR_SUCCESS;
}

Don't forget that jk is initialized twice and on i5/OS in the same
thread, so may be the static var should be reset.

What do you think of the patch ?


2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:

main_log is a static in mod_jk.c, which is initialized as NULL.

It gets set inside open_jklog() which gets called once for every virtual
server by jk_post_config() during server initialization.

The first virtual server inherits its logger conf->log from its
configuration to main_log. It also registers a cleanup handler which
will NULL its conf->log, but that should not change main_log.

main_log should never get reset.

To find the problem, it would be best to first reduce the apache config
to not use any virtual servers.

You can log the value of main_log for debug purposes anywhere in
mod_jk.c, because its a global static.

Regards,

Rainer

Henri Gomez schrieb:
> I'm looking for the exception in jk_log. It happen in ws_write right
> now and I wonder what's the life cycle of main_log.
>
> On i5/OS, the init / post are done on the same thread (not the same on
> Unixes).
>
> How is reset the main_log ?
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:

The flag is about the response body. We send the response back via a
webserver specific method. It's ws_write() ind mod_jk.c.

ws_write() calls e.g. ap_rwrite() which should in my opinion set
sent_bodyct. I'm careful about that, because I don't fully understand
the filter architecture involved.

But ws_write() also contains iSeries specific code. Maybe some of those
methods fail. You can log p->r->sent_bodyct inside ws_write and also add
some debug log to find out, if it stopps prematurely. Especially
ap_change_response_body_xlate() does not seem to be part of standard
apache code. No idea, if that has an interaction bug with filters.


No more, we're is AS400_UTF8 mode so the ws_write in i5/OS and Linux
is the same...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531924 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 06:20:19 2007
New Revision: 531924

URL: http://svn.apache.org/viewvc?view=rev&rev=531924
Log:
A possible fix for i5/OS implementation where all inits are done twice in the 
same thread

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531924&r1=531923&r2=531924
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 06:20:19 
2007
@@ -2540,6 +2540,10 @@
 static apr_status_t jklog_cleanup(void *d)
 {
 /* set the main_log to NULL */
+#idef AS400
+   main_log = null;
+#endif
+
 d = NULL;
 return APR_SUCCESS;
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531925 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 06:21:42 2007
New Revision: 531925

URL: http://svn.apache.org/viewvc?view=rev&rev=531925
Log:
no more needed on i5/OS 

Modified:
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?view=diff&rev=531925&r1=531924&r2=531925
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Tue Apr 24 06:21:42 2007
@@ -525,15 +525,8 @@
 used = usable_size;
 }
 buf[used] = 0;
-
-/*
- * MCH errors encountered on i5/OS (V5R3/V5R4) when using jk_logger, use the 
JOBLOB QPRINT instead for now
- */
-#ifdef AS400
-   printf("%s\n", buf);
-#else
 l->log(l, level, buf);
-#endif
+
 #ifdef NETWARE
 free(buf);
 #endif



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531926 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 06:22:12 2007
New Revision: 531926

URL: http://svn.apache.org/viewvc?view=rev&rev=531926
Log:
Oups

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531926&r1=531925&r2=531926
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 06:22:12 
2007
@@ -2540,7 +2540,7 @@
 static apr_status_t jklog_cleanup(void *d)
 {
 /* set the main_log to NULL */
-#idef AS400
+#ifdef AS400
main_log = null;
 #endif
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Rainer Jung]

Great. I think I now understand the problem.

Could you try this one relativ to your last change:

Index: mod_jk.c
===
--- mod_jk.c(revision 531926)
+++ mod_jk.c(working copy)
@@ -2539,11 +2539,7 @@

 static apr_status_t jklog_cleanup(void *d)
 {
-/* set the main_log to NULL */
-#ifdef AS400
-   main_log = null;
-#endif
-
+/* set the log to NULL */
 d = NULL;
 return APR_SUCCESS;
 }
@@ -2616,9 +2612,10 @@
 jkl->logger_private = flp;
 flp->jklogfp = conf->jklogfp;
 conf->log = jkl;
-if (main_log == NULL)
+if (main_log == NULL) {
 main_log = conf->log;
-apr_pool_cleanup_register(p, conf->log, jklog_cleanup,
jklog_cleanup);
+apr_pool_cleanup_register(p, main_log, jklog_cleanup,
jklog_cleanup);
+}
 return 0;
 }

The point is: when I added full virtual server support for all configs I
changed the cleanup function to NULL the virtual server logger. It
NULLed main_log before. But the only reason it should NULL a logger was
the check for NULL in

if (main_log == NULL)
main_log = conf->log;

So if main_log is set once, it never gets reset. This is bad, if the
pool from which it got acquired is dead. So we actually need to register
the log cleanup only for main_log, because otherwise main_log will
always reference an outdated logger. conf->log will be overwritten
during each init, no need to reset those.

At least that's my theory for it. Could you test this patch?

Regards,

Rainer



Henri Gomez schrieb:
> I made it works by adding main_log = NULL in jklog_cleanup
> 
> static apr_status_t jklog_cleanup(void *d)
> {
>/* set the main_log to NULL */
>d = NULL;
>main_log = NULL;
>return APR_SUCCESS;
> }
> 
> Don't forget that jk is initialized twice and on i5/OS in the same
> thread, so may be the static var should be reset.
> 
> What do you think of the patch ?
> 
> 
> 2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:
>> main_log is a static in mod_jk.c, which is initialized as NULL.
>>
>> It gets set inside open_jklog() which gets called once for every virtual
>> server by jk_post_config() during server initialization.
>>
>> The first virtual server inherits its logger conf->log from its
>> configuration to main_log. It also registers a cleanup handler which
>> will NULL its conf->log, but that should not change main_log.
>>
>> main_log should never get reset.
>>
>> To find the problem, it would be best to first reduce the apache config
>> to not use any virtual servers.
>>
>> You can log the value of main_log for debug purposes anywhere in
>> mod_jk.c, because its a global static.
>>
>> Regards,
>>
>> Rainer
>>
>> Henri Gomez schrieb:
>> > I'm looking for the exception in jk_log. It happen in ws_write right
>> > now and I wonder what's the life cycle of main_log.
>> >
>> > On i5/OS, the init / post are done on the same thread (not the same on
>> > Unixes).
>> >
>> > How is reset the main_log ?
>> >
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

You remove completly the apr_pool_cleanup_register(p, conf->log, jklog_cleanup,
jklog_cleanup) ?

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:

Great. I think I now understand the problem.

Could you try this one relativ to your last change:

Index: mod_jk.c
===
--- mod_jk.c(revision 531926)
+++ mod_jk.c(working copy)
@@ -2539,11 +2539,7 @@

 static apr_status_t jklog_cleanup(void *d)
 {
-/* set the main_log to NULL */
-#ifdef AS400
-   main_log = null;
-#endif
-
+/* set the log to NULL */
 d = NULL;
 return APR_SUCCESS;
 }
@@ -2616,9 +2612,10 @@
 jkl->logger_private = flp;
 flp->jklogfp = conf->jklogfp;
 conf->log = jkl;
-if (main_log == NULL)
+if (main_log == NULL) {
 main_log = conf->log;
-apr_pool_cleanup_register(p, conf->log, jklog_cleanup,
jklog_cleanup);
+apr_pool_cleanup_register(p, main_log, jklog_cleanup,
jklog_cleanup);
+}
 return 0;
 }

The point is: when I added full virtual server support for all configs I
changed the cleanup function to NULL the virtual server logger. It
NULLed main_log before. But the only reason it should NULL a logger was
the check for NULL in

if (main_log == NULL)
main_log = conf->log;

So if main_log is set once, it never gets reset. This is bad, if the
pool from which it got acquired is dead. So we actually need to register
the log cleanup only for main_log, because otherwise main_log will
always reference an outdated logger. conf->log will be overwritten
during each init, no need to reset those.

At least that's my theory for it. Could you test this patch?

Regards,

Rainer



Henri Gomez schrieb:
> I made it works by adding main_log = NULL in jklog_cleanup
>
> static apr_status_t jklog_cleanup(void *d)
> {
>/* set the main_log to NULL */
>d = NULL;
>main_log = NULL;
>return APR_SUCCESS;
> }
>
> Don't forget that jk is initialized twice and on i5/OS in the same
> thread, so may be the static var should be reset.
>
> What do you think of the patch ?
>
>
> 2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:
>> main_log is a static in mod_jk.c, which is initialized as NULL.
>>
>> It gets set inside open_jklog() which gets called once for every virtual
>> server by jk_post_config() during server initialization.
>>
>> The first virtual server inherits its logger conf->log from its
>> configuration to main_log. It also registers a cleanup handler which
>> will NULL its conf->log, but that should not change main_log.
>>
>> main_log should never get reset.
>>
>> To find the problem, it would be best to first reduce the apache config
>> to not use any virtual servers.
>>
>> You can log the value of main_log for debug purposes anywhere in
>> mod_jk.c, because its a global static.
>>
>> Regards,
>>
>> Rainer
>>
>> Henri Gomez schrieb:
>> > I'm looking for the exception in jk_log. It happen in ws_write right
>> > now and I wonder what's the life cycle of main_log.
>> >
>> > On i5/OS, the init / post are done on the same thread (not the same on
>> > Unixes).
>> >
>> > How is reset the main_log ?
>> >
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531938 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java

[remm]

Author: remm
Date: Tue Apr 24 06:42:07 2007
New Revision: 531938

URL: http://svn.apache.org/viewvc?view=rev&rev=531938
Log:
- 42202: Fix a problem handling %xx encoded URLs (unfortunately, some are 
encoded - the webapp CL and the system CL -
  and some are not - the URL CL).

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java?view=diff&rev=531938&r1=531937&r2=531938
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java Tue 
Apr 24 06:42:07 2007
@@ -26,6 +26,7 @@
 import java.io.InputStream;
 import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
+import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.ArrayList;
@@ -427,8 +428,18 @@
   resourcePath));
 }
 
-File file = new File(url.getFile());
-file = file.getCanonicalFile();
+File file = null;
+try {
+file = new File(url.toURI());
+} catch (URISyntaxException e) {
+// Ignore, probably an unencoded char
+file = new File(url.getFile());
+}
+try {
+file = file.getCanonicalFile();
+} catch (IOException e) {
+// Ignore
+}
 tldScanJar(file);
 
 }
@@ -674,11 +685,18 @@
 if (loader instanceof URLClassLoader) {
 URL[] urls = ((URLClassLoader) loader).getURLs();
 for (int i=0; i

DO NOT REPLY [Bug 42202] - if you install tomcat in a directory with spaces it ignores TLD files inside jar files

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42202





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 06:42 ---
Ok, but your patch was not good (not all URLs are %xx encoded).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: More on i5/OS and some modifications needed

[Henri Gomez]

It works ! great.

Could I commit ?

Also find a way to fix for i5/OS the HTTP 500 problem

2007/4/24, Henri Gomez <[EMAIL PROTECTED]>:

You remove completly the apr_pool_cleanup_register(p, conf->log, jklog_cleanup,
jklog_cleanup) ?

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:
> Great. I think I now understand the problem.
>
> Could you try this one relativ to your last change:
>
> Index: mod_jk.c
> ===
> --- mod_jk.c(revision 531926)
> +++ mod_jk.c(working copy)
> @@ -2539,11 +2539,7 @@
>
>  static apr_status_t jklog_cleanup(void *d)
>  {
> -/* set the main_log to NULL */
> -#ifdef AS400
> -   main_log = null;
> -#endif
> -
> +/* set the log to NULL */
>  d = NULL;
>  return APR_SUCCESS;
>  }
> @@ -2616,9 +2612,10 @@
>  jkl->logger_private = flp;
>  flp->jklogfp = conf->jklogfp;
>  conf->log = jkl;
> -if (main_log == NULL)
> +if (main_log == NULL) {
>  main_log = conf->log;
> -apr_pool_cleanup_register(p, conf->log, jklog_cleanup,
> jklog_cleanup);
> +apr_pool_cleanup_register(p, main_log, jklog_cleanup,
> jklog_cleanup);
> +}
>  return 0;
>  }
>
> The point is: when I added full virtual server support for all configs I
> changed the cleanup function to NULL the virtual server logger. It
> NULLed main_log before. But the only reason it should NULL a logger was
> the check for NULL in
>
> if (main_log == NULL)
> main_log = conf->log;
>
> So if main_log is set once, it never gets reset. This is bad, if the
> pool from which it got acquired is dead. So we actually need to register
> the log cleanup only for main_log, because otherwise main_log will
> always reference an outdated logger. conf->log will be overwritten
> during each init, no need to reset those.
>
> At least that's my theory for it. Could you test this patch?
>
> Regards,
>
> Rainer
>
>
>
> Henri Gomez schrieb:
> > I made it works by adding main_log = NULL in jklog_cleanup
> >
> > static apr_status_t jklog_cleanup(void *d)
> > {
> >/* set the main_log to NULL */
> >d = NULL;
> >main_log = NULL;
> >return APR_SUCCESS;
> > }
> >
> > Don't forget that jk is initialized twice and on i5/OS in the same
> > thread, so may be the static var should be reset.
> >
> > What do you think of the patch ?
> >
> >
> > 2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:
> >> main_log is a static in mod_jk.c, which is initialized as NULL.
> >>
> >> It gets set inside open_jklog() which gets called once for every virtual
> >> server by jk_post_config() during server initialization.
> >>
> >> The first virtual server inherits its logger conf->log from its
> >> configuration to main_log. It also registers a cleanup handler which
> >> will NULL its conf->log, but that should not change main_log.
> >>
> >> main_log should never get reset.
> >>
> >> To find the problem, it would be best to first reduce the apache config
> >> to not use any virtual servers.
> >>
> >> You can log the value of main_log for debug purposes anywhere in
> >> mod_jk.c, because its a global static.
> >>
> >> Regards,
> >>
> >> Rainer
> >>
> >> Henri Gomez schrieb:
> >> > I'm looking for the exception in jk_log. It happen in ws_write right
> >> > now and I wonder what's the life cycle of main_log.
> >> >
> >> > On i5/OS, the init / post are done on the same thread (not the same on
> >> > Unixes).
> >> >
> >> > How is reset the main_log ?
> >> >
> >>
> >> -
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531939 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 06:47:23 2007
New Revision: 531939

URL: http://svn.apache.org/viewvc?view=rev&rev=531939
Log:
Fix the sent_bodyct flag unset under i5/OS

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531939&r1=531938&r2=531939
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 06:47:23 
2007
@@ -314,6 +314,11 @@
 }
 }
 
+   /* under i5/OS this flag is not set correctly */
+#ifdef AS400
+r->sent_bodyct = 1;
+#endif
+
 /* this NOP function was removed in apache 2.0 alpha14 */
 /* ap_send_http_header(r); */
 p->response_started = JK_TRUE;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TC 5.0.x releases

[Remy Maucherat]

Jean-Frederic wrote:

Hi,

Does someone plan to release a TC 5.0.x for the last security fixes?

I have arranged jasper and the build and I still have to patch the code
for the latest security fixes. (I have already ported the CVE-2007-0450
corrections)


Yoav is the current RM for this branch. If he has no time to continue 
doing it, I think we would need a new RM for Tomcat 5.0.x.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TC 5.0.x releases

[Yoav Shapira]

Hi,

On 4/24/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

Jean-Frederic wrote:
> Hi,
>
> Does someone plan to release a TC 5.0.x for the last security fixes?
>
> I have arranged jasper and the build and I still have to patch the code
> for the latest security fixes. (I have already ported the CVE-2007-0450
> corrections)

Yoav is the current RM for this branch. If he has no time to continue
doing it, I think we would need a new RM for Tomcat 5.0.x.


I guess I am ;)

I would prefer if someone else could take over the RM duties for
5.0.x.  I unfortunately am very busy with work these days ;(

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TC 5.0.x releases

[Remy Maucherat]

Yoav Shapira wrote:

Hi,

On 4/24/07, Remy Maucherat <[EMAIL PROTECTED]> wrote:

Jean-Frederic wrote:
> Hi,
>
> Does someone plan to release a TC 5.0.x for the last security fixes?
>
> I have arranged jasper and the build and I still have to patch the code
> for the latest security fixes. (I have already ported the CVE-2007-0450
> corrections)

Yoav is the current RM for this branch. If he has no time to continue
doing it, I think we would need a new RM for Tomcat 5.0.x.


I guess I am ;)

I would prefer if someone else could take over the RM duties for
5.0.x.  I unfortunately am very busy with work these days ;(


Ok. Any candidates ? Mark ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42202] - if you install tomcat in a directory with spaces it ignores TLD files inside jar files

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42202





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 07:17 ---
but the URI class understand all URI formats, being it %xx encoded or not ...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42202] - if you install tomcat in a directory with spaces it ignores TLD files inside jar files

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42202


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 07:44 ---
How about stopping using "..." ?
The issue has been fixed in the 6 branch, but not using your patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42202] - if you install tomcat in a directory with spaces it ignores TLD files inside jar files

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42202





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 08:02 ---
Ok, I'll not use "..." 
the fix is already in the trunk? I have just tested it and it still not working

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531985 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 08:31:31 2007
New Revision: 531985

URL: http://svn.apache.org/viewvc?view=rev&rev=531985
Log:
Rainer fixes for log reinit. i5/OS V5R4 now works

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531985&r1=531984&r2=531985
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:31:31 
2007
@@ -2545,10 +2545,6 @@
 static apr_status_t jklog_cleanup(void *d)
 {
 /* set the main_log to NULL */
-#ifdef AS400
-   main_log = null;
-#endif
-
 d = NULL;
 return APR_SUCCESS;
 }
@@ -2621,9 +2617,11 @@
 jkl->logger_private = flp;
 flp->jklogfp = conf->jklogfp;
 conf->log = jkl;
-if (main_log == NULL)
+if (main_log == NULL) {
 main_log = conf->log;
-apr_pool_cleanup_register(p, conf->log, jklog_cleanup, jklog_cleanup);
+   apr_pool_cleanup_register(p, main_log, jklog_cleanup, 
jklog_cleanup);
+}
+
 return 0;
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r531985 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[Henri Gomez]

Tried the current jk on a machine on i5/OS with 2 Virtual servers and
it core again.


2007/4/24, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:

Author: hgomez
Date: Tue Apr 24 08:31:31 2007
New Revision: 531985

URL: http://svn.apache.org/viewvc?view=rev&rev=531985
Log:
Rainer fixes for log reinit. i5/OS V5R4 now works

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531985&r1=531984&r2=531985
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:31:31 
2007
@@ -2545,10 +2545,6 @@
 static apr_status_t jklog_cleanup(void *d)
 {
 /* set the main_log to NULL */
-#ifdef AS400
-   main_log = null;
-#endif
-
 d = NULL;
 return APR_SUCCESS;
 }
@@ -2621,9 +2617,11 @@
 jkl->logger_private = flp;
 flp->jklogfp = conf->jklogfp;
 conf->log = jkl;
-if (main_log == NULL)
+if (main_log == NULL) {
 main_log = conf->log;
-apr_pool_cleanup_register(p, conf->log, jklog_cleanup, jklog_cleanup);
+   apr_pool_cleanup_register(p, main_log, jklog_cleanup, 
jklog_cleanup);
+}
+
 return 0;
 }




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r531988 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 08:46:42 2007
New Revision: 531988

URL: http://svn.apache.org/viewvc?view=rev&rev=531988
Log:
On i5/OS it seems mandatory to reset the main_log. tested on an Apache instance 
with multi virtual hosts and it's required...

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531988&r1=531987&r2=531988
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:46:42 
2007
@@ -2545,6 +2545,10 @@
 static apr_status_t jklog_cleanup(void *d)
 {
 /* set the main_log to NULL */
+#ifdef AS400
+   main_log = NULL;
+#endif
+
 d = NULL;
 return APR_SUCCESS;
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40111] - HttpSession's getLastAccessedTime() does not always return previous request's access time

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40111





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 09:34 ---
According to the Servlet specification v2.4 (which Tomcat 5.5 implements) method
 HttpSession.getLastAccessedTime() should NOT throw any exceptions (even if
accessed on invalidated session).
Here is snapshot of the method description from the Servlet v2.4 API:
--
public long getLastAccessedTime()

Returns the last time the client sent a request associated with this
session, as the number of milliseconds since midnight January 1, 1970 GMT, and
marked by the time the container received the request.

Actions that your application takes, such as getting or setting a value
associated with the session, do not affect the access time.

Returns:
a long representing the last time the client sent a request associated
with this session, expressed in milliseconds since 1/1/1970 GMT
--

As you can see there is no 'Throws' section for the method description (like it
is for the HttpSession.getCreationTime() )


RESOLUTION:
This bug is caused by the
org.apache.catalina.session.StandardSession.getLastAccessedTime() method which
for version 5.5.23 currently throws IllegalStateException (but it should not):
-
/**
 * Return the last time the client sent a request associated with this
 * session, as the number of milliseconds since midnight, January 1, 1970
 * GMT.  Actions that your application takes, such as getting or setting
 * a value associated with the session, do not affect the access time.
 */
public long getLastAccessedTime() {

if ( !isValid() ) {
throw new IllegalStateException
(sm.getString("standardSession.getLastAccessedTime.ise"));
}

return (this.lastAccessedTime);
}
-

So I think Tomcat developers should FOLLOW the specification and FIX this bug.



Also for me it is strange why the getLastAccessedTime() method in the Servlet
v2.5 API (Tomcat 6.0.x) was changed to the throw IllegalStateException:


long getLastAccessedTime()

Returns the last time the client sent a request associated with this
session, as the number of milliseconds since midnight January 1, 1970 GMT, and
marked by the time the container received the request.

Actions that your application takes, such as getting or setting a value
associated with the session, do not affect the access time.

Returns:
a long representing the last time the client sent a request associated
with this session, expressed in milliseconds since 1/1/1970 GMT 
Throws:
IllegalStateException - if this method is called on an invalidated 
session
--

API Spec Group have broken the way to determine if session is valid.
For example if my application contains the following code that calculates if the
session is valid:
--
if (System.currentTimeMillis - sess.getLastAccessedTime() >
sess.getMaxInactiveInterval() * 1000) {
  ...
}
-
it should correctly work in the containers that implement v2.3 and v2.4 Servlet
API. After migrating to v2.5 container the app will fail as it does not catches
the IllegalStateException.
And after all throwing exception is much expensive opration then math
calculation. Isn't it?


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r532006 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[remm]

Author: remm
Date: Tue Apr 24 09:53:00 2007
New Revision: 532006

URL: http://svn.apache.org/viewvc?view=rev&rev=532006
Log:
- This error shouldn't happen, and it's out of the servlet, so it is not going 
to be possible to send another event.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?view=diff&rev=532006&r1=532005&r2=532006
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
Tue Apr 24 09:53:00 2007
@@ -174,8 +174,6 @@
 log.error(sm.getString("coyoteAdapter.service"), t);
 }
 error = true;
-// FIXME: Since there's likely some structures kept in the 
servlet or elsewhere,
-// a cleanup event of some sort could be needed ?
 return false;
 } finally {
 req.getRequestProcessor().setWorkerThreadName(null);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project jakarta-tomcat (in module jakarta-tomcat) failed

[Stefan Bodewig]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat has an issue affecting its community integration.
This issue affects 9 projects,
 and has been outstanding for 56 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-ojb :  Commons Jelly
- db-ojb-from-packages-1-0-release :  ObjectRelationalBridge
- db-torque :  Persistence Layer
- fulcrum-cache :  Services Framework
- jakarta-slide :  Content Management System based on WebDAV technology
- jakarta-tomcat :  Servlet 2.2 and JSP 1.1 Reference Implementation
- jakarta-tomcat-coyote-tomcat3 :  Connectors to various web servers
- jakarta-turbine-jcs :  Cache
- test-ojb-from-packages-1-0-release :  ObjectRelationalBridge


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat/jakarta-tomcat/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Output [tomcat-util.jar] identifier set to output basename: 
[tomcat-util]
 -DEBUG- Output [tomcat_core.jar] identifier set to output basename: 
[tomcat_core]
 -DEBUG- Output [tomcat_modules.jar] identifier set to output basename: 
[tomcat_modules]
 -DEBUG- Output [facade22.jar] identifier set to output basename: [facade22]
 -DEBUG- Output [core_util.jar] identifier set to output basename: [core_util]
 -DEBUG- Output [jasper.jar] identifier set to output basename: [jasper]
 -DEBUG- Output [container_util.jar] identifier set to output basename: 
[container_util]
 -DEBUG- Output [tomcat.jar] identifier set to output basename: [tomcat]
 -DEBUG- Dependency on jakarta-servletapi exists, no need to add for property 
servlet22.jar.
 -DEBUG- Dependency on jmx exists, no need to add for property jmxtools.jar.
 -DEBUG- Dependency on ant exists, no need to add for property ant.home.
 -DEBUG- Dependency on jsse exists, no need to add for property jsse.home.
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat/jakarta-tomcat/gump_work/build_jakarta-tomcat_jakarta-tomcat.html
Work Name: build_jakarta-tomcat_jakarta-tomcat (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djakarta-tomcat-connectors=/usr/local/gump/public/workspace/jakarta-tomcat-connectors
 
-Djtc.coyote.home=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/coyote
 -Djaxp.home=/usr/local/gump/packages/jaxp-1_3 
-Dcommons-modeler.jar=/usr/local/gump/public/workspace/jakarta-commons/modeler/dist/commons-modeler-24042007.jar
 -Djmxtools.jar=/usr/local/gump/packages/jmx-1_2_1-bin/lib/jmxtools.jar 
-Djmx.jar=/usr/local/gump/packages/jmx-1_2_1-bin/lib/jmxri.jar 
-Dtomcat-util.jar=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar
 -Dant.home=/usr/local/gump/public/workspace/ant/dist 
-Dservlet22.jar=/usr/local/gump/public/workspace/jakarta-servletapi/dist/lib/servlet.jar
 
-Dcommons-logging.jar=/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-24042007.jar
 
-Djtc.http11.home=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/http11/build
 -Djsse.home=/usr/local/gump/packages/jsse1.0.3 main.lite 
[Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-tomcat/build/tomcat/classes:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-servletapi/dist/lib/servlet.jar:/usr/local/gump/packages/j

[EMAIL PROTECTED]: Project jakarta-tomcat (in module jakarta-tomcat) failed

[Stefan Bodewig]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat has an issue affecting its community integration.
This issue affects 9 projects,
 and has been outstanding for 56 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-ojb :  Commons Jelly
- db-ojb-from-packages-1-0-release :  ObjectRelationalBridge
- db-torque :  Persistence Layer
- fulcrum-cache :  Services Framework
- jakarta-slide :  Content Management System based on WebDAV technology
- jakarta-tomcat :  Servlet 2.2 and JSP 1.1 Reference Implementation
- jakarta-tomcat-coyote-tomcat3 :  Connectors to various web servers
- jakarta-turbine-jcs :  Cache
- test-ojb-from-packages-1-0-release :  ObjectRelationalBridge


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat/jakarta-tomcat/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Output [tomcat-util.jar] identifier set to output basename: 
[tomcat-util]
 -DEBUG- Output [tomcat_core.jar] identifier set to output basename: 
[tomcat_core]
 -DEBUG- Output [tomcat_modules.jar] identifier set to output basename: 
[tomcat_modules]
 -DEBUG- Output [facade22.jar] identifier set to output basename: [facade22]
 -DEBUG- Output [core_util.jar] identifier set to output basename: [core_util]
 -DEBUG- Output [jasper.jar] identifier set to output basename: [jasper]
 -DEBUG- Output [container_util.jar] identifier set to output basename: 
[container_util]
 -DEBUG- Output [tomcat.jar] identifier set to output basename: [tomcat]
 -DEBUG- Dependency on jakarta-servletapi exists, no need to add for property 
servlet22.jar.
 -DEBUG- Dependency on jmx exists, no need to add for property jmxtools.jar.
 -DEBUG- Dependency on ant exists, no need to add for property ant.home.
 -DEBUG- Dependency on jsse exists, no need to add for property jsse.home.
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat/jakarta-tomcat/gump_work/build_jakarta-tomcat_jakarta-tomcat.html
Work Name: build_jakarta-tomcat_jakarta-tomcat (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djakarta-tomcat-connectors=/usr/local/gump/public/workspace/jakarta-tomcat-connectors
 
-Djtc.coyote.home=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/coyote
 -Djaxp.home=/usr/local/gump/packages/jaxp-1_3 
-Dcommons-modeler.jar=/usr/local/gump/public/workspace/jakarta-commons/modeler/dist/commons-modeler-24042007.jar
 -Djmxtools.jar=/usr/local/gump/packages/jmx-1_2_1-bin/lib/jmxtools.jar 
-Djmx.jar=/usr/local/gump/packages/jmx-1_2_1-bin/lib/jmxri.jar 
-Dtomcat-util.jar=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar
 -Dant.home=/usr/local/gump/public/workspace/ant/dist 
-Dservlet22.jar=/usr/local/gump/public/workspace/jakarta-servletapi/dist/lib/servlet.jar
 
-Dcommons-logging.jar=/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-24042007.jar
 
-Djtc.http11.home=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/http11/build
 -Djsse.home=/usr/local/gump/packages/jsse1.0.3 main.lite 
[Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-tomcat/build/tomcat/classes:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-servletapi/dist/lib/servlet.jar:/usr/local/gump/packages/j

[EMAIL PROTECTED]: Project jakarta-tomcat-4.0 (in module jakarta-tomcat-4.0) failed

[Stefan Bodewig]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-4.0 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 56 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-4.0 :  Servlet 2.3 and JSP 1.2 Reference Implementation


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/jakarta-tomcat-4.0/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Output [naming-resources.jar] identifier set to output basename: 
[naming-resources]
 -DEBUG- Output [servlets-default.jar] identifier set to output basename: 
[servlets-default]
 -DEBUG- Output [naming-common.jar] identifier set to output basename: 
[naming-common]
 -DEBUG- Output [catalina.jar] identifier set to output basename: [catalina]
 -DEBUG- Output [bootstrap.jar] identifier set to output basename: [bootstrap]
 -DEBUG- Output [servlets-common.jar] identifier set to output basename: 
[servlets-common]
 -DEBUG- Output [servlets-invoker.jar] identifier set to output basename: 
[servlets-invoker]
 -DEBUG- Dependency on javamail exists, no need to add for property mail.jar.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.jar.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.jar.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
servlet.jar.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
xerces.jar.
 -DEBUG- Dependency on jakarta-tomcat-util exists, no need to add for property 
tomcat-util.jar.
 -DEBUG- Dependency on commons-logging exists, no need to add for property 
commons-logging-api.jar.
 -DEBUG- Dependency on ant exists, no need to add for property ant.home.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
servlet.home.
 -DEBUG- Dependency on jsse exists, no need to add for property jsse.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmxtools.jar.
 -DEBUG- Dependency on jndi exists, no need to add for property jndi.home.
 -DEBUG- Dependency on javamail exists, no need to add for property mail.home.
 -DEBUG- Dependency on jakarta-regexp exists, no need to add for property 
regexp.home.
 -DEBUG- Dependency on jakarta-regexp exists, no need to add for property 
regexp.jar.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.home.
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/jakarta-tomcat-4.0/gump_work/build_jakarta-tomcat-4.0_jakarta-tomcat-4.0.html
Work Name: build_jakarta-tomcat-4.0_jakarta-tomcat-4.0 (Type: Build)
Work ended in a state of : Failed
Elapsed: 45 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djmx.license=/usr/local/gump/public/workspace/jakarta-tomcat-4.0/RUNNING.txt 
-Djaas.jar=/usr/local/gump/packages/jaas1_0/lib/jaas.jar 
-Djmx.jar=/usr/local/gump/packages/jmx-1_2_1-bin/lib/jmxri.jar 
-Djmx.home=/usr/local/gump/packages/jmx-1_2_1-bin 
-Djdbc20ext.jar=/usr/local/gump/packages/jdbc2_0/jdbc2_0-stdext.jar 
-Dregexp.jar=/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-24042007.jar
 -Dmail.home=/usr/local/gump/packages/javamail-1.4 
-Dant.home=/usr/local/gump/public/workspace/ant/dist 
-Dservlet.jar=/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar
 -Dxerces.jar=/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar 
-Dcommons-collections.jar=/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-24042007.jar
 -Dldap.jar=/usr/local/gump/packages/ldap-1_2_4/lib/ldap.jar 
-Djsse.home=/usr/local/gump/packages/jsse1.0.3 
-Dtomcat-coyote.jar=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/coyote/build/lib/tomcat-coyote.jar
 -Dmail.jar=/usr/local/gump/packages/javamail-1.4/mail.jar 
-Dcommons-digester.jar=/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar
 -Djndi.jar=/usr/local/gump/packages/jndi1_2_1/lib/jndi.jar 
-Djmxtools.jar=/usr/local/

[EMAIL PROTECTED]: Project jakarta-tomcat-4.0 (in module jakarta-tomcat-4.0) failed

[Stefan Bodewig]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-4.0 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 56 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-4.0 :  Servlet 2.3 and JSP 1.2 Reference Implementation


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/jakarta-tomcat-4.0/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Output [naming-resources.jar] identifier set to output basename: 
[naming-resources]
 -DEBUG- Output [servlets-default.jar] identifier set to output basename: 
[servlets-default]
 -DEBUG- Output [naming-common.jar] identifier set to output basename: 
[naming-common]
 -DEBUG- Output [catalina.jar] identifier set to output basename: [catalina]
 -DEBUG- Output [bootstrap.jar] identifier set to output basename: [bootstrap]
 -DEBUG- Output [servlets-common.jar] identifier set to output basename: 
[servlets-common]
 -DEBUG- Output [servlets-invoker.jar] identifier set to output basename: 
[servlets-invoker]
 -DEBUG- Dependency on javamail exists, no need to add for property mail.jar.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.jar.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.jar.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
servlet.jar.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
xerces.jar.
 -DEBUG- Dependency on jakarta-tomcat-util exists, no need to add for property 
tomcat-util.jar.
 -DEBUG- Dependency on commons-logging exists, no need to add for property 
commons-logging-api.jar.
 -DEBUG- Dependency on ant exists, no need to add for property ant.home.
 -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property 
servlet.home.
 -DEBUG- Dependency on jsse exists, no need to add for property jsse.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmx.home.
 -DEBUG- Dependency on jmx exists, no need to add for property jmxtools.jar.
 -DEBUG- Dependency on jndi exists, no need to add for property jndi.home.
 -DEBUG- Dependency on javamail exists, no need to add for property mail.home.
 -DEBUG- Dependency on jakarta-regexp exists, no need to add for property 
regexp.home.
 -DEBUG- Dependency on jakarta-regexp exists, no need to add for property 
regexp.jar.
 -DEBUG- Dependency on jaf exists, no need to add for property activation.home.
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/jakarta-tomcat-4.0/gump_work/build_jakarta-tomcat-4.0_jakarta-tomcat-4.0.html
Work Name: build_jakarta-tomcat-4.0_jakarta-tomcat-4.0 (Type: Build)
Work ended in a state of : Failed
Elapsed: 45 secs
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/build/serializer.jar:/usr/local/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only 
-Djmx.license=/usr/local/gump/public/workspace/jakarta-tomcat-4.0/RUNNING.txt 
-Djaas.jar=/usr/local/gump/packages/jaas1_0/lib/jaas.jar 
-Djmx.jar=/usr/local/gump/packages/jmx-1_2_1-bin/lib/jmxri.jar 
-Djmx.home=/usr/local/gump/packages/jmx-1_2_1-bin 
-Djdbc20ext.jar=/usr/local/gump/packages/jdbc2_0/jdbc2_0-stdext.jar 
-Dregexp.jar=/usr/local/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-24042007.jar
 -Dmail.home=/usr/local/gump/packages/javamail-1.4 
-Dant.home=/usr/local/gump/public/workspace/ant/dist 
-Dservlet.jar=/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar
 -Dxerces.jar=/usr/local/gump/public/workspace/xml-xerces2/build/xercesImpl.jar 
-Dcommons-collections.jar=/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-24042007.jar
 -Dldap.jar=/usr/local/gump/packages/ldap-1_2_4/lib/ldap.jar 
-Djsse.home=/usr/local/gump/packages/jsse1.0.3 
-Dtomcat-coyote.jar=/usr/local/gump/public/workspace/jakarta-tomcat-connectors/coyote/build/lib/tomcat-coyote.jar
 -Dmail.jar=/usr/local/gump/packages/javamail-1.4/mail.jar 
-Dcommons-digester.jar=/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar
 -Djndi.jar=/usr/local/gump/packages/jndi1_2_1/lib/jndi.jar 
-Djmxtools.jar=/usr/local/

Re: svn commit: r531988 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[Rainer Jung]

Hi Henri,

could you please remove the tabs ...

This change here I don't understand: when we set main_log we register
for this function call. We only send main_log as an argument, so now on
iSeries whenever jklog_cleanup runs, we set main_log to NULL twice. Why
should that be better than doing it once per call?

Regards,

Rainer

[EMAIL PROTECTED] schrieb:
> Author: hgomez
> Date: Tue Apr 24 08:46:42 2007
> New Revision: 531988
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=531988
> Log:
> On i5/OS it seems mandatory to reset the main_log. tested on an Apache 
> instance with multi virtual hosts and it's required...
> 
> Modified:
> tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
> 
> Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
> URL: 
> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531988&r1=531987&r2=531988
> ==
> --- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
> +++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:46:42 
> 2007
> @@ -2545,6 +2545,10 @@
>  static apr_status_t jklog_cleanup(void *d)
>  {
>  /* set the main_log to NULL */
> +#ifdef AS400
> + main_log = NULL;
> +#endif
> +
>  d = NULL;
>  return APR_SUCCESS;
>  }
> 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jk-native has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 38 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-jk-native :  Connectors to various web servers


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html
Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: 
Build)
Work ended in a state of : Failed
Elapsed: 1 min 26 secs
Command Line: make 
[Working Directory: 
/usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native]
-
Making all in common
make[1]: Entering directory 
`/x1/gump/public/workspace/jakarta-tomcat-connectors/jk/native/common'
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_ajp12_worker.c -o 
jk_ajp12_worker.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_connect.c -o jk_connect.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_msg_buff.c -o jk_msg_buff.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_util.c -o jk_util.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_ajp13.c -o jk_ajp13.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_pool.c -o jk_pool.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_worker.c -o jk_worker.lo
/u

[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project jakarta-tomcat-jk-native has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 38 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- jakarta-tomcat-jk-native :  Connectors to various web servers


Full details are available at:

http://vmgump.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html
Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: 
Build)
Work ended in a state of : Failed
Elapsed: 1 min 26 secs
Command Line: make 
[Working Directory: 
/usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native]
-
Making all in common
make[1]: Entering directory 
`/x1/gump/public/workspace/jakarta-tomcat-connectors/jk/native/common'
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_ajp12_worker.c -o 
jk_ajp12_worker.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_connect.c -o jk_connect.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_msg_buff.c -o jk_msg_buff.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_util.c -o jk_util.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_ajp13.c -o jk_ajp13.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_pool.c -o jk_pool.lo
/usr/local/gump/public/workspace/apr/dest-24042007/build-1/libtool --silent 
--mode=compile ccache gcc 
-I/usr/local/gump/public/workspace/apache-httpd/dest-24042007/include -g -O2 -g 
-O2 -pthread -DHAVE_APR  
-I/usr/local/gump/public/workspace/apr/dest-24042007/include/apr-1 
-I/usr/local/gump/public/workspace/apr-util/dest-24042007/include/apr-1 -g -O2 
-DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I 
/opt/jdk1.5/include -I /opt/jdk1.5/include/ -c jk_worker.c -o jk_worker.lo
/u

Re: 6.0.12 build

[Filip Hanik - Dev Lists]

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Peter Rossbach wrote:

Opps,

you are right! After a long night and two much test setups...


Ok, so after making the necessary fixes, I would like to propose a 
new 6.0.12 build early next week.

sounds good!


Is it still good ? If it is, I could tag it tomorrow.

still good :)
Filip


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r531988 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[Henri Gomez]

I don't know but don't forget that we have all init stage in the same
thread, no fork there ;(

2007/4/24, Rainer Jung <[EMAIL PROTECTED]>:

Hi Henri,

could you please remove the tabs ...

This change here I don't understand: when we set main_log we register
for this function call. We only send main_log as an argument, so now on
iSeries whenever jklog_cleanup runs, we set main_log to NULL twice. Why
should that be better than doing it once per call?

Regards,

Rainer

[EMAIL PROTECTED] schrieb:
> Author: hgomez
> Date: Tue Apr 24 08:46:42 2007
> New Revision: 531988
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=531988
> Log:
> On i5/OS it seems mandatory to reset the main_log. tested on an Apache 
instance with multi virtual hosts and it's required...
>
> Modified:
> tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
>
> Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
> URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531988&r1=531987&r2=531988
> ==
> --- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
> +++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:46:42 
2007
> @@ -2545,6 +2545,10 @@
>  static apr_status_t jklog_cleanup(void *d)
>  {
>  /* set the main_log to NULL */
> +#ifdef AS400
> + main_log = NULL;
> +#endif
> +
>  d = NULL;
>  return APR_SUCCESS;
>  }
>
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r532053 - /tomcat/connectors/trunk/jk/native/common/jk_map.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 12:42:24 2007
New Revision: 532053

URL: http://svn.apache.org/viewvc?view=rev&rev=532053
Log:
Missing statbuf

Modified:
tomcat/connectors/trunk/jk/native/common/jk_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_map.c?view=diff&rev=532053&r1=532052&r2=532053
==
--- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue Apr 24 12:42:24 2007
@@ -872,8 +872,11 @@
 }
 }
 fclose(fp);
-if (modified)
+if (modified) {
+   struct stat statbuf;
+   jk_stat(f, &statbuf);
 *modified = statbuf.st_mtime;
+}
 }
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r532054 - /tomcat/connectors/trunk/jk/native/common/jk_map.c

[hgomez]

Author: hgomez
Date: Tue Apr 24 12:43:57 2007
New Revision: 532054

URL: http://svn.apache.org/viewvc?view=rev&rev=532054
Log:
fix Missing statbuf

Modified:
tomcat/connectors/trunk/jk/native/common/jk_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_map.c?view=diff&rev=532054&r1=532053&r2=532054
==
--- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue Apr 24 12:43:57 2007
@@ -873,9 +873,9 @@
 }
 fclose(fp);
 if (modified) {
-   struct stat statbuf;
-   jk_stat(f, &statbuf);
-*modified = statbuf.st_mtime;
+struct stat statbuf;
+if (jk_stat(f, &statbuf) != -1)
+   *modified = statbuf.st_mtime;
 }
 }
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22679] - how to access ssl session ID out of tomcat to prevent session hijacking and allow for phishing protection

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22679


[EMAIL PROTECTED] changed:

   What|Removed |Added

URL|http://jakarta.apache.org/to|http://www.fec.uff.br
   |mcat/tomcat-4.1-doc/ssl-|
   |howto.html  |
  Component|Connector:Coyote|Catalina
Product|Tomcat 5|Tomcat 6
   Platform|All |HP
   Target Milestone|--- |default
Version|Nightly Build   |6.0.0




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r531988 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[Henri Gomez]

I don't know but don't forget that we have all init stage in the same
thread, no fork there ;(


All in the same thread on i5/OS

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22679] - how to access ssl session ID out of tomcat to prevent session hijacking and allow for phishing protection

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22679


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|VERIFIED|REOPENED
  Component|Catalina|Jasper
 OS/Version|other   |Linux
 Resolution|FIXED   |
Version|6.0.0   |6.0.10




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42198] - Insufficient synchronization for CometEvent.close

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42198





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 14:04 ---
Hi, I know that this is no discussion forum but I wanted to comment on

(In reply to comment #8)
> - in svn head, you will get an END event in certain cases (like if the event 
> or
> stream is closed asynchronously), but it is not required to close the event
> again since it's been done already; if the request is closed synchronously ...

If and when you get an END event depends very much on the connection type you
are using.

When you are using a Keep-Alive connection you dont get an END event when
calling event.close() synchronously. You will get it at some point later when
the browser decides to release the connection.

Otherwise (Connection: close) the connection will be released instantly and an
END event will be triggered. In that case the comet event object will become
kind of invalid, because if you call event.close() a NullPointerException will
by thrown. Unfortunately there is no way to query the event if it is already
closed. 

Personally I find that the event.close() method should never fail in that way
but rather return silently when being called on a closed event.

I wonder if there is a way to close the connection from the server side (other
than using Connection: close).

It's also a bit strange that you can keep on writing into a response output
stream of a closed event without getting an error when using Keep-Alive
connections. It seems to me that an exception should be thrown when trying to
write. 

Just my 5C


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r532092 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Tue Apr 24 14:42:00 2007
New Revision: 532092

URL: http://svn.apache.org/viewvc?view=rev&rev=532092
Log:
reset timeout counter upon registration

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=532092&r1=532091&r2=532092
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Tue 
Apr 24 14:42:00 2007
@@ -1252,6 +1252,7 @@
 if (key != null) {
 final KeyAttachment att = (KeyAttachment) 
key.attachment();
 if ( att!=null ) {
+att.access();//to prevent timeout
 //we are registering the key to start with, reset 
the fairness counter.
 att.setFairness(0);
 att.interestOps(interestOps);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22679] - how to access ssl session ID out of tomcat to prevent session hijacking and allow for phishing protection

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22679





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 15:49 ---
It is not possible to change the session id of a session, it has to be asssumed.
If you want to submit a valve which would enforce "better" security (= a lame
hack which would pretend to be secure), then I would be ok to commit it and let
this bug report live. Despite the dynamic IP thing, I think 3 out of 3 is a
minimum requirement, despite possible problems (IPs do not change every 5s, so I
don't see the point, and if they do, let the user log back in). Otherwise ->
INVALID.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42198] - Insufficient synchronization for CometEvent.close

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42198





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 16:05 ---
This should be posted on the user list.

I doubt what you described corresponds to what actually happens (with the
exception of write being a noop after closing the stream - it is the same in a
regular servlet).

If you are playing with the Connection header, the client could assume things
and abruptly close the connection. You should not be playing with the connection
state (it's also true in a regular servlet), but it should not make any
difference as long as the client does not get confused.

After the END event, it is clearly mentioned that the request is done, and
objects will be recycled, so it's up to you to stop doing things with that
request (if you want to code more freely, you should use
org.apache.catalina.connector.RECYCLE_FACADES set to true, which will avoid all
invalid accesses).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40111] - HttpSession's getLastAccessedTime() does not always return previous request's access time

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40111


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 16:14 ---
This is not going to be fixed. This got clarified by the Servlet EG: the old
javadocs were simply wrong (it's obvious there's no reason that this method is
the only one which doesn't throw ISE). As for the rest, you should upgrade to
Tomcat 6.0, and use the strict compliance flag. Please do not reopen the report.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

download page a mess

[William A. Rowe, Jr.]

http://www.apache.org/dist/tomcat/tomcat-5/

is rather gross - any hope of cleaning up the chaos?  3x 5.5.20 + 2x 5.0.30?

Bill



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r532182 - /tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

[markt]

Author: markt
Date: Tue Apr 24 20:53:59 2007
New Revision: 532182

URL: http://svn.apache.org/viewvc?view=rev&rev=532182
Log:
Fix build. Stop Gump nags.

Modified:
tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml

Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml?view=diff&rev=532182&r1=532181&r2=532182
==
--- tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/apache.xml Tue Apr 24 
20:53:59 2007
@@ -1094,7 +1094,6 @@
 If the build if successfull, copy the new mod_jk module
 CRTDUPOBJ OBJ(MOD_JK) FROMLIB(MOD_JK) OBJTYPE(*SRVPGM) 
TOLIB(QHTTPSVR) NEWOBJ(MOD_JK)
 
-
 
 Copy the CL build program source for i5/OS V5R4 from IFS
 CPYFRMSTMF 
FROMSTMF('/home/apache/jk/native/apache-2.0/bldjk54.qclsrc') +
@@ -1108,11 +1107,11 @@
 
 
 Next, you should restart your Apache 2.0 instance and enjoy this piece of 
OpenSource on System I.
+
 
 ENDTCPSVR SERVER(*HTTP) HTTPSVR(MYSERVER)
 STRTCPSVR SERVER(*HTTP) HTTPSVR(MYSERVER)
 
-
 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: download page a mess

[Jean-Frederic]

On Tue, 2007-04-24 at 18:56 -0500, William A. Rowe, Jr. wrote:
> http://www.apache.org/dist/tomcat/tomcat-5/
> 
> is rather gross - any hope of cleaning up the chaos?  3x 5.5.20 + 2x 5.0.30?

IMHO: The 5.5.20 should be removed.
The v5.0.30-beta is a link to v5.0.30

Cheers

Jean-Frederic

> 
> Bill
> 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]