DO NOT REPLY [Bug 41797] New: - CNFE thrown from function mapper when remapping reference back to instance

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41797

   Summary: CNFE thrown from function mapper when remapping
reference back to instance
   Product: Tomcat 6
   Version: 6.0.2
  Platform: All
OS/Version: All
Status: NEW
  Severity: major
  Priority: P2
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


ClassNotFoundException is thrown from function mapper when it is (re)mapping a
given class/method name pair back to method instance. This may happen due to
serialization.

Patch is simply to replace used Class.forName with ReflectionUtil.forName 

java.lang.ClassNotFoundException: 
at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:164)
at
org.apache.el.lang.FunctionMapperImpl$Function.getMethod(FunctionMapperImpl.java:147)
at
org.apache.el.lang.FunctionMapperImpl.resolveFunction(FunctionMapperImpl.java:53)
at org.apache.el.parser.AstFunction.getValue(AstFunction.java:71)
at 
org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:186)
at 
com.sun.facelets.el.TagValueExpression.getValue(TagValueExpression.java:71)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 41797] - CNFE thrown from function mapper when remapping reference back to instance

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41797





--- Additional Comments From [EMAIL PROTECTED]  2007-03-09 01:11 ---
Created an attachment (id=19687)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19687&action=view)
FunctionMapperImpl


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tagging 5.5.23

2007-03-09 Thread Jess Holle

What became of 5.5.23?

--
Jess Holle

Filip Hanik - Dev Lists wrote:
Due to a number of important bug fixes, we will skip the 5.5.22 
release and go directly to a 5.5.23.

I will tag SVN tomorrow at noon Mountain time.

Let me know if this conflicts with anyone

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tagging 5.5.23

2007-03-09 Thread Rahul Akolkar

On 3/9/07, Jess Holle <[EMAIL PROTECTED]> wrote:

What became of 5.5.23?




Its being voted on, I haven't seen a result yet. Here [1] is the top
of that thread.

-Rahul

(long URL, may be fragmented)
[1]  http://mail-archives.apache.org/mod_mbox/tomcat-dev/200703.mbox/[EMAIL 
PROTECTED]



--
Jess Holle

Filip Hanik - Dev Lists wrote:
> Due to a number of important bug fixes, we will skip the 5.5.22
> release and go directly to a 5.5.23.
> I will tag SVN tomorrow at noon Mountain time.
>
> Let me know if this conflicts with anyone
>
> Filip
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tagging 5.5.23

2007-03-09 Thread Filip Hanik - Dev Lists

coming out today

Jess Holle wrote:

What became of 5.5.23?

--
Jess Holle

Filip Hanik - Dev Lists wrote:
Due to a number of important bug fixes, we will skip the 5.5.22 
release and go directly to a 5.5.23.

I will tag SVN tomorrow at noon Mountain time.

Let me know if this conflicts with anyone

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[RESULT] [VOTE] Release build 5.5.23 - Take 2

2007-03-09 Thread Filip Hanik - Dev Lists

+1(stable) from fhanik,remm,yoavs,markt,jimj

No beta or alpha votes

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r516438 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha: deploy/FarmWarDeployer.java deploy/mbeans-descriptors.xml mbeans-descriptors.xml

2007-03-09 Thread fhanik
Author: fhanik
Date: Fri Mar  9 07:46:20 2007
New Revision: 516438

URL: http://svn.apache.org/viewvc?view=rev&rev=516438
Log:
Took care of JMX error upon startup, component still not working, but at least 
its not spitting out ugly messages

Added:

tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java?view=diff&rev=516438&r1=516437&r2=516438
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java 
Fri Mar  9 07:46:20 2007
@@ -149,15 +149,18 @@
 // Check to correct engine and host setup
 Object parent = getCluster().getContainer();
 Engine engine = null;
+String hostname = null;
 if ( parent instanceof Host ) {
 host = (Host) parent;
 engine = (Engine) host.getParent();
+hostname = host.getName();
 }else {
 engine = (Engine)parent;
+hostname = engine.getDefaultHost();
 }
 try {
 oname = new ObjectName(engine.getName() + ":type=Deployer,host="
-+ host.getName());
++ hostname);
 } catch (Exception e) {
 log.error("Can't construct MBean object name" + e);
 }

Added: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml?view=auto&rev=516438
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml 
(added)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/deploy/mbeans-descriptors.xml 
Fri Mar  9 07:46:20 2007
@@ -0,0 +1,11 @@
+
+
+  
+  
+

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml?view=diff&rev=516438&r1=516437&r2=516438
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/mbeans-descriptors.xml Fri 
Mar  9 07:46:20 2007
@@ -8,10 +8,6 @@
 group="Cluster"
  type="org.apache.catalina.ha.tcp.SimpleTcpCluster">
 
-
-
   
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [RESULT] [VOTE] Release build 5.5.23 - Take 2

2007-03-09 Thread Henri Gomez

+1

2007/3/9, Filip Hanik - Dev Lists <[EMAIL PROTECTED]>:

+1(stable) from fhanik,remm,yoavs,markt,jimj

No beta or alpha votes

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 41780] - cannot clear header with setHeader(name,null)

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41780





--- Additional Comments From [EMAIL PROTECTED]  2007-03-09 08:04 ---
Can you point out a paragraph that says that headers must be sent with empty
value anyway when set to null instead of empty value?


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[ANN] Apache Tomcat 5.5.23 released

2007-03-09 Thread Filip Hanik - Dev Lists

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 5.5.23 stable. This release has numerous bug fixes and 
maintenance updates.

It also includes the corrected source code for the JK CVE-2007-0774 issue.

Please refer to the change log for the list of changes:
http://tomcat.apache.org/tomcat-5.5-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-55.cgi

Thank you,

-- The Apache Tomcat Team

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r516457 - in /tomcat/tc6.0.x/trunk/res/maven: mvn-pub.xml mvn.properties.default

2007-03-09 Thread fhanik
Author: fhanik
Date: Fri Mar  9 08:45:15 2007
New Revision: 516457

URL: http://svn.apache.org/viewvc?view=rev&rev=516457
Log:
Added in the ASF main repository, need to figure out how to get .asc signatures 
attached to the jars as they get deployed

Modified:
tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default

Modified: tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml?view=diff&rev=516457&r1=516456&r2=516457
==
--- tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml Fri Mar  9 08:45:15 2007
@@ -143,11 +143,19 @@
 
   
 
-  
+  
 
   
   
   
+
+  
+
+  
+
+  
+  
+  
 
   
 

Modified: tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default?view=diff&rev=516457&r1=516456&r2=516457
==
--- tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default Fri Mar  9 08:45:15 
2007
@@ -8,10 +8,16 @@
 maven.snapshot.repo.repositoryId=apache.snapshots
 maven.snapshot.deploy.version=6.0.X-SNAPSHOT
 
-#Maven release properties
+#Maven release properties for Tomcat staging
 
maven.release.repo.url=scp://people.apache.org/www/tomcat.apache.org/dev/dist/m2-repository
 maven.release.repo.repositoryId=tomcat-staging
 maven.release.deploy.version=6.0.8
+
+#Maven release properties for the main ASF repo
+maven.asf.release.repo.url=scp://people.apache.org/www/people.apache.org/repo/m2-ibiblio-rsync-repository
+maven.asf.release.repo.repositoryId=apache.releases
+maven.asf.release.deploy.version=6.0.8
+
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38797] - 5.5.12 and 5.5.15 emit different code on

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38797


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38797] - 5.5.12 and 5.5.15 emit different code on

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38797





--- Additional Comments From [EMAIL PROTECTED]  2007-03-09 08:52 ---
I noticed too the change. The behaviour is in Tomcat 5.5.20, here is the
following exception :
org.apache.jasper.JasperException: Tentative d''opération bean sur un objet nul.
org.apache.jasper.runtime.JspRuntimeLibrary.handleGetProperty(JspRuntimeLibrary.java:601)
org.apache.jsp.test3_005f2_jsp._jspService(test3_005f2_jsp.java:77)

This not the same bug as 37933. It is an error that is due to the bug correction
:(. (well but the correction of the bug 37933 is not easy)
I explain.

I have a custom tag that defines a scripting variable. This variable is in a
request attribute. The custom tag library defines a scripting variable with a
Tag Extra Info class. The TLD declares a tag with the tag class implementation
and the Tag Extra Info class implementation.
The tag is named "variable".
The tag has 3 attributes "id", "className", "scopeIn".

The object "Song" has a property "title".

Here is where it fails : 
<%@ taglib uri="http://www.scort.com/test"; prefix="test" %> 
...


...
Title : 

=> mysong is said to be null

But here is a page where it works : 
<%@ taglib uri="http://www.scort.com/test"; prefix="test" %> 
...


...
Title : 

Finally it always works with jsp:useBean :


...
Title : 


The custom library i wrote defined a VariableInfo that expose a scripting
variable into the page. So i thought (think) it was the key to allow it into the
 jspGetProperty.

--

Reference in the specification JSP 2.0 JSP5.3 :

"The value of the name attribute in jsp:setProperty andjsp:getProperty will
refer to an object that is obtained from the pageContext object through its
findAttribute method."

Hope it helps.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [ANN] Apache Tomcat 5.5.23 released

2007-03-09 Thread William L. Thomson Jr.
Packaged and available in a few hours for sync and emerge on Gentoo.

Does this release effective make 5.0.28 obsolete? Or more so than
before, since it seemed there were some outstanding issues keeping
people from migrating beyond 5.0.28?

Curious because I want to remove 5.0.28 from Gentoo entirely. It's been
masked for the past couple of months. Which makes it pretty hard for
anyone to install it, much less see recommendations to use >=5.5.x.

Thanks

-- 
William L. Thomson Jr.
Gentoo/Java


signature.asc
Description: This is a digitally signed message part


Tomcat 6 Scales

2007-03-09 Thread Filip Hanik - Dev Lists
I wrote a blog entry on how one of our connectors was developed the 
challenges you face doing that.

Its not super technical as I'm saving the juicy details for ApacheCon

And since no one reads my blog, I'll let you guys get it from here :)

http://blog.covalent.net/roller/covalent/entry/20070308

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 41606] - The jspInit method is called twice.

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41606





--- Additional Comments From [EMAIL PROTECTED]  2007-03-09 12:42 ---
Created an attachment (id=19692)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19692&action=view)
Patch to prevent double jspInit() when a JSP is set in web.xml to
load-on-startup

Confirmed in 5.5.23.  I've attached a patch based on the OP's suggested fix.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r516561 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-03-09 Thread rjung
Author: rjung
Date: Fri Mar  9 13:39:16 2007
New Revision: 516561

URL: http://svn.apache.org/viewvc?view=rev&rev=516561
Log:
Log real value instead of default value.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?view=diff&rev=516561&r1=516560&r2=516561
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Fri Mar  9 
13:39:16 2007
@@ -1992,7 +1992,7 @@
 return JK_TRUE;
 }
 jk_log(l, JK_LOG_ERROR,
-   "can't resolve tomcat address %s", host);
+   "can't resolve tomcat address %s", p->host);
 }
 jk_log(l, JK_LOG_ERROR,
"invalid host and port %s %d",



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r516564 - in /tomcat/connectors/trunk/jk/native/common: jk_map.c jk_map.h

2007-03-09 Thread rjung
Author: rjung
Date: Fri Mar  9 13:42:05 2007
New Revision: 516564

URL: http://svn.apache.org/viewvc?view=rev&rev=516564
Log:
Log individual error messages when failing during map parsing.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_map.c
tomcat/connectors/trunk/jk/native/common/jk_map.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_map.c?view=diff&rev=516564&r1=516563&r2=516564
==
--- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_map.c Fri Mar  9 13:42:05 2007
@@ -352,8 +352,12 @@
 char buf[LENGTH_OF_LINE + 1];
 char *prp = &buf[0];
 
-if (strlen(str) > LENGTH_OF_LINE)
+if (strlen(str) > LENGTH_OF_LINE) {
+jk_log(l, JK_LOG_WARNING,
+   "Line to long (%d > %d), ignoring entry",
+   strlen(str), LENGTH_OF_LINE);
 return JK_FALSE;
+}
 
 strcpy(prp, str);
 if (trim(prp)) {
@@ -415,6 +419,7 @@
 jk_map_put(m, prp, v, NULL);
 }
 else {
+JK_LOG_NULL_PARAMS(l);
 rc = JK_FALSE;
 }
 }
@@ -636,54 +641,66 @@
 
 JK_TRACE_ENTER(l);
 
-if (m && prefix && depth <= JK_MAP_RECURSION) {
-size_t prelen = strlen(prefix);
-unsigned int i;
-rc = JK_TRUE;
-if (JK_IS_DEBUG_LEVEL(l))
-jk_log(l, JK_LOG_DEBUG,
-   "Checking for references with prefix %s with%s wildcard 
(recursion %d)",
-   prefix, wildcard? "" : "out", depth);
-for (i = 0; i < m->size; i++) {
-if (m->values[i] && !strncmp(m->names[i], prefix, prelen)) {
-size_t remain = strlen(m->names[i]) - prelen;
-if ((remain == JK_MAP_REFERENCE_SZ ) || (wildcard && remain > 
JK_MAP_REFERENCE_SZ)) {
-remain = strlen(m->names[i]) - JK_MAP_REFERENCE_SZ;
-if (!strncmp(m->names[i] + remain, JK_MAP_REFERENCE, 
JK_MAP_REFERENCE_SZ)) {
-char *from = jk_pool_alloc(&m->p,
-   (sizeof(char) *
-   (strlen(m->values[i]) + 
2)));
-char *to = jk_pool_alloc(&m->p,
- (sizeof(char) *
- (remain + 2)));
-if (!from || !to) {
-rc = JK_FALSE;
-break;
-}
-strcpy(from, m->values[i]);
-*(from+strlen(m->values[i]))   = '.';
-*(from+strlen(m->values[i])+1) = '\0';
-strncpy(to, m->names[i], remain);
-*(to+remain)   = '.';
-*(to+remain+1) = '\0';
-
-rc = jk_map_resolve_references(m, m->values[i], 0, 
depth+1, l);
-if (rc == JK_FALSE) {
-break;
-}
-if (JK_IS_DEBUG_LEVEL(l))
-jk_log(l, JK_LOG_DEBUG,
-   "Copying values from %s to %s",
-   from, to);
-rc = jk_map_inherit_properties(m, from, to);
-if (rc == JK_FALSE) {
-break;
+if (m && prefix) {
+if (depth <= JK_MAP_RECURSION) {
+size_t prelen = strlen(prefix);
+unsigned int i;
+rc = JK_TRUE;
+if (JK_IS_DEBUG_LEVEL(l))
+jk_log(l, JK_LOG_DEBUG,
+   "Checking for references with prefix %s with%s wildcard 
(recursion %d)",
+   prefix, wildcard? "" : "out", depth);
+for (i = 0; i < m->size; i++) {
+if (m->values[i] && !strncmp(m->names[i], prefix, prelen)) {
+size_t remain = strlen(m->names[i]) - prelen;
+if ((remain == JK_MAP_REFERENCE_SZ ) || (wildcard && 
remain > JK_MAP_REFERENCE_SZ)) {
+remain = strlen(m->names[i]) - JK_MAP_REFERENCE_SZ;
+if (!strncmp(m->names[i] + remain, JK_MAP_REFERENCE, 
JK_MAP_REFERENCE_SZ)) {
+char *from = jk_pool_alloc(&m->p,
+   (sizeof(char) *
+   (strlen(m->values[i]) + 
2)));
+char *to = jk_pool_alloc(&m->p,
+ (sizeof(char) *
+ (remain + 2)));
+if (!

Re: Tomcat 6 Scales

2007-03-09 Thread Remy Maucherat

Filip Hanik - Dev Lists wrote:
I wrote a blog entry on how one of our connectors was developed the 
challenges you face doing that.

Its not super technical as I'm saving the juicy details for ApacheCon

And since no one reads my blog, I'll let you guys get it from here :)

http://blog.covalent.net/roller/covalent/entry/20070308


And what about the APR connector (assuming you increase the pollerSize 
to an appropriate value, since it's "only" 8000 by default) ?


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39627] - JULI ignores a ".level = XXX" directive in logging.properties

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39627


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




--- Additional Comments From [EMAIL PROTECTED]  2007-03-09 14:42 ---
5.5.22 wasn't released so this is fixed in 5.5.23.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36231] - getCause() null for ServletException

2007-03-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36231





--- Additional Comments From [EMAIL PROTECTED]  2007-03-09 15:16 ---
(In reply to comment #22)
> 
> I would be extremely glad if you were switching to Glassfish :) When do you 
> plan
> to do it ? Also, let us know if you convince them to fix this issue.
>
OK. I am letting you know.  I am a little late though. The issue was fixed in
Glassfish on August 22, 2005, more than 6 months before Remy made the above
snide remark. 
https://glassfish.dev.java.net/source/browse/glassfish/servlet-api/src/jakarta-servletapi-5/jsr154/src/share/javax/servlet/ServletException.java

And it probably was either Gili or me that convinced them to fix it. I had
posted a comment to the related Java bug, and 4 days later it was fixed in
Glassfish and replied to:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4395719.  Gili also mentioned
opening an issue with Sun.

I also haven't seen the hypothetical portability issue materialize in the year
and a half that Glassfish has been fixed and Tomcat hasn't.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 6 Scales

2007-03-09 Thread Filip Hanik - Dev Lists

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
I wrote a blog entry on how one of our connectors was developed the 
challenges you face doing that.

Its not super technical as I'm saving the juicy details for ApacheCon

And since no one reads my blog, I'll let you guys get it from here :)

http://blog.covalent.net/roller/covalent/entry/20070308


And what about the APR connector (assuming you increase the pollerSize 
to an appropriate value, since it's "only" 8000 by default) ?
That will be in the next blog, this time I only wanted to compare NIO 
connector, as the coding of it gets complex since you have to "force" 
blocking IO on a non blocking API.


There is an area of the AprEndpoint that needs to be fixed before it 
happens though, currently the "Acceptor" thread in APR does this

 long socket = Socket.accept(serverSock);
 if (!processSocketWithOptions(socket)) {
 Socket.destroy(socket);
 }

The processSocketWithOptions is a blocking call, hence you wont be able 
to acccept new connections as long as your worker threads are all busy. 
What we need to do, is set the socket options, then simply add the 
socket to the poller waiting for a read event, the poller will assign it 
a worker thread when one is available and the socket has data to be read.


This was one of the major improvements I just did in the NIO connector. 
otherwise you can't accept connections fast enough and they will get 
dropped.


I'll attempt a patch that you can review, unless you wanna jump on it 
directly.


I will contact you before I run the test to make sure I got everything 
configured, I see
But before ApacheCon I will have those numbers, as in my presentation I 
will focus on APR and NIO, the old connector is not of that much 
interest anymore :)


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r516602 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-03-09 Thread fhanik
Author: fhanik
Date: Fri Mar  9 15:38:29 2007
New Revision: 516602

URL: http://svn.apache.org/viewvc?view=rev&rev=516602
Log:
added fairness counter, using this counter, I will be able to make sure that 
connections are treated evenly in my next revision of the NioEndpoint. No point 
in having 20k connections if only half get love.



Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=diff&rev=516602&r1=516601&r2=516602
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
Mar  9 15:38:29 2007
@@ -1095,6 +1095,8 @@
 } else {
 final SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
 final KeyAttachment att = (KeyAttachment) key.attachment();
+//we are registering the key to start with, reset the fairness 
counter.
+att.setFairness(0);
 try {
 if (key != null) {
 key.interestOps(interestOps);
@@ -1304,6 +1306,8 @@
 if (!processSocket(channel, 
SocketStatus.OPEN))
 processSocket(channel, 
SocketStatus.DISCONNECT);
 } else {
+//increase the fairness counter
+attachment.incFairness();
 //reregister it
 attachment.interestOps(interestOps);
 sk.interestOps(interestOps);
@@ -1319,6 +1323,8 @@
 
channel.getIOChannel().socket().close();
 }
 } else {
+//increase the fairness counter
+attachment.incFairness();
 //reregister it
 attachment.interestOps(interestOps);
 sk.interestOps(interestOps);
@@ -1393,6 +1399,7 @@
 comet = false;
 timeout = -1;
 error = false;
+fairness = 0;
 }
 
 public void reset() {
@@ -1425,6 +1432,9 @@
 if ( latch == null || latch.getCount() == 0 ) this.latch = new 
CountDownLatch(cnt); 
 else throw new IllegalStateException("Latch must be at count 0 or 
null.");
 }
+public int getFairness() { return fairness; }
+public void setFairness(int f) { fairness = f;}
+public void incFairness() { fairness++; }
 protected Object mutex = new Object();
 protected long lastAccess = -1;
 protected boolean currentAccess = false;
@@ -1433,7 +1443,7 @@
 protected boolean error = false;
 protected NioChannel channel = null;
 protected CountDownLatch latch = null;
-
+protected int fairness = 0;
 }
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 6 Scales

2007-03-09 Thread Remy Maucherat

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
I wrote a blog entry on how one of our connectors was developed the 
challenges you face doing that.

Its not super technical as I'm saving the juicy details for ApacheCon

And since no one reads my blog, I'll let you guys get it from here :)

http://blog.covalent.net/roller/covalent/entry/20070308


Ok, I did read it in detail. Really good results since it has only 1GB 
of RAM (did I read it right ?).


There is an area of the AprEndpoint that needs to be fixed before it 
happens though, currently the "Acceptor" thread in APR does this

 long socket = Socket.accept(serverSock);
 if (!processSocketWithOptions(socket)) {
 Socket.destroy(socket);
 }

The processSocketWithOptions is a blocking call, hence you wont be able 
to acccept new connections as long as your worker threads are all busy. 
What we need to do, is set the socket options, then simply add the 
socket to the poller waiting for a read event, the poller will assign it 
a worker thread when one is available and the socket has data to be read.


I don't really believe in this sort of solution (especially since APR 
uses deferred accepts automagically). For sure, I am against always 
adding the socket to a poller right away, this would be most likely be 
useless overhead. If there are no threads available, then using the main 
poller could be sensible, but it could be more productive (and easier) 
simply adding the socket to a structure containing longs and processing 
it later.


If using a poller all the time, you can try a test where you bombard the 
server with HTTP/1.0 requests - no keep-alive - and it would most likely 
perform somewhat worse due to the poller overhead (could be worth 
measuring).


I will contact you before I run the test to make sure I got everything 
configured, I see
But before ApacheCon I will have those numbers, as in my presentation I 
will focus on APR and NIO, the old connector is not of that much 
interest anymore :)


I am not sure blocking IO is bad, actually. It's very easy to program, 
and IMO it could work quite well in the future with the exploding amount 
of CPU cores and smarters OSes, the only remaining issue being the 
higher memory usage due to the resource usage of a thread (most likely 
this could be fixed as well).


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 6 Scales

2007-03-09 Thread William A. Rowe, Jr.
Remy Maucherat wrote:
> 
> I don't really believe in this sort of solution (especially since APR
> uses deferred accepts automagically).


To clarify, httpd 2.2 automagically adds default socket filters (data,
or http headers, where the platform supports them).  AFAIK APR does not
by default.  If it did, the other 'half' of the protocols would be borked.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 6 Scales

2007-03-09 Thread Remy Maucherat

William A. Rowe, Jr. wrote:

Remy Maucherat wrote:

I don't really believe in this sort of solution (especially since APR
uses deferred accepts automagically).


To clarify, httpd 2.2 automagically adds default socket filters (data,
or http headers, where the platform supports them).  AFAIK APR does not
by default.  If it did, the other 'half' of the protocols would be borked.


I meant I was told it is supposed to do it when adding the right option 
(which is done in the APR connector). I can imagine it could cause 
problems if enabled by default.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 6 Scales

2007-03-09 Thread Filip Hanik - Dev Lists

correct, only 1GB of RAM, -Xmx512m for the Tomcat container.

Filip

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
I wrote a blog entry on how one of our connectors was developed the 
challenges you face doing that.

Its not super technical as I'm saving the juicy details for ApacheCon

And since no one reads my blog, I'll let you guys get it from here :)

http://blog.covalent.net/roller/covalent/entry/20070308


Ok, I did read it in detail. Really good results since it has only 1GB 
of RAM (did I read it right ?).


There is an area of the AprEndpoint that needs to be fixed before it 
happens though, currently the "Acceptor" thread in APR does this

 long socket = Socket.accept(serverSock);
 if (!processSocketWithOptions(socket)) {
 Socket.destroy(socket);
 }

The processSocketWithOptions is a blocking call, hence you wont be 
able to acccept new connections as long as your worker threads are 
all busy. What we need to do, is set the socket options, then simply 
add the socket to the poller waiting for a read event, the poller 
will assign it a worker thread when one is available and the socket 
has data to be read.


I don't really believe in this sort of solution (especially since APR 
uses deferred accepts automagically). For sure, I am against always 
adding the socket to a poller right away, this would be most likely be 
useless overhead. If there are no threads available, then using the 
main poller could be sensible, but it could be more productive (and 
easier) simply adding the socket to a structure containing longs and 
processing it later.


If using a poller all the time, you can try a test where you bombard 
the server with HTTP/1.0 requests - no keep-alive - and it would most 
likely perform somewhat worse due to the poller overhead (could be 
worth measuring).


I will contact you before I run the test to make sure I got 
everything configured, I see
But before ApacheCon I will have those numbers, as in my presentation 
I will focus on APR and NIO, the old connector is not of that much 
interest anymore :)


I am not sure blocking IO is bad, actually. It's very easy to program, 
and IMO it could work quite well in the future with the exploding 
amount of CPU cores and smarters OSes, the only remaining issue being 
the higher memory usage due to the resource usage of a thread (most 
likely this could be fixed as well).


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 6 Scales

2007-03-09 Thread Mladen Turk

Filip Hanik - Dev Lists wrote:


The processSocketWithOptions is a blocking call, hence you wont be able 
to acccept new connections as long as your worker threads are all busy. 


Not entirely true.

What we need to do, is set the socket options, then simply add the 
socket to the poller waiting for a read event, the poller will assign it 
a worker thread when one is available and the socket has data to be read.


This was one of the major improvements I just did in the NIO connector. 
otherwise you can't accept connections fast enough and they will get 
dropped.




Basically you simulate the OS socket implementation pending connections
queue (backlog) on the OSI layer 7 instead depending on the layer 5
provided by the OS.

The only beneficiary for that would be lab test environment where you
have a lots of burst connections, then a void, then a connection burst
again (not an real-life situation thought). The point is that no matter
how large your queue is (and how it's done) if the connection rate is
higher then a processing rate, your connections will be rejected at some
point. So, it's all about tuning.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]