Problems detected with ClusterSingleSignOn

2007-01-19 Thread Peter Rossbach 

Hi!

I have test a little bit the ClusterSingleSignOn implementation and  
something are bad:


-	At normal shutdown a cluster  node all auth HttpSessions are  
destroyed.
	ClusterSingleSignOn is a HttpSession Listener and remove all SSO  
registered sessions. That
	is correct for normal session invalidation, but not for a  
DeltaManager.stop call.


-   The SSO cache have no automatic sync, after restart a node.

Anyone have a idea at this topics?

I have also made some small refactoring and will it backport to  
tomcat 6.0, but only as we have a complete solution.


Regards
Peter

DO NOT REPLY [Bug 40820] - Default JSP factory not initialized early enough

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40820





--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 04:48 ---
I try to use the Sun implementation of JSF 1.2 with Tomcat 6.0.8.

I still get a NullPointerException:
Servlet.service() for servlet jsp threw exception
java.lang.NullPointerException
at org.apache.jsp.VDVRequest_jsp._jspInit(VDVRequest_jsp.java:25)
at org.apache.jasper.runtime.HttpJspBase.init(HttpJspBase.java:80)
at
org.apache.jasper.servlet.JspServletWrapper.getServlet(JspServletWrapper.java:157)
at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:320)
at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:212)
at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:634)
at 
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:445)
at java.lang.Thread.run(Unknown Source)


in VDVRequest_jsp.java:
  public void _jspInit() {
_005fjspx_005ftagPool_005ff_005fview =
org.apache.jasper.runtime.TagHandlerPool.getTagHandlerPool(getServletConfig());
_005fjspx_005ftagPool_005fh_005foutputText_005fvalue_005fnobody =
org.apache.jasper.runtime.TagHandlerPool.getTagHandlerPool(getServletConfig());
[here is line no. 37]
_el_expressionfactory =
JspFactory.getDefaultFactory().getJspApplicationContext(getServletConfig().getServletContext()).getExpressionFactory();
_jsp_annotationprocessor = (org.apache.AnnotationProcessor)
getServletConfig().getServletContext().getAttribute(org.apache.AnnotationProcessor.class.getName());
  }

I suppose JspFactory.getDefaultFactory() is null.

Is there any workaround to initialize it?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41407] - CLIENT-CERT Authentication with JAASRealm not working

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41407


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 05:37 ---

You try to do authorization with client certs?
I'm afraid this is not implemented tomcat's JAASRealm.

I am sure it is possible to create an extended JAASRealm2 which is
able to provide full JAAS functionality with client certs also.
The way to do it could be:
1. Implement authenticate(X509Certificate certs[]) just like
   the user/pwd-authenticate in JAASrealm.
2. Add an appropriate CallbackHandler for the cert chain
   to pass the certificates to the custom LoginModule.

The custom authorization stuff has to go to the LoginModule
so the new JAASRealm2 should be finished.

Please let me know if you plan to implement it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40820] - Default JSP factory not initialized early enough

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40820





--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 05:18 ---
-> [EMAIL PROTECTED] list

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41420] New: - Memory leak on Tomcat5.exe

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41420

   Summary: Memory leak on Tomcat5.exe
   Product: Tomcat 5
   Version: 5.0.0
  Platform: PC
OS/Version: Windows Server 2003
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Daily/hourly memory usage increase (in Task Manager) on our EDM (Documentum) 
Server running tomcat5.exe. When activity 'hits', the server memory usage will 
increase and will not drop back down. We have scheduled a task to stop and 
start tomcat services during non-production hours to release memory usage. Its 
now increasing to over 900mb to 1GB daily. How can I stop these memory leaks? 
What is the best recourse to apply?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41420] - Memory leak on Tomcat5.exe

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41420


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 11:04 ---
Tomcat5.exe (service runner) has nothng to do with memory leaks.
It launches the JVM when started and does nothing untill stopped.

So the memory leak has nothing to do with the program that only
launches the JVM. I suppose you will observe the same thing if you
start your Tomcat from command line


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41420] - Memory leak on Tomcat5.exe

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41420





--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 11:16 ---
Is there a way to release memory usage that Tomcat uses while in production? 
I'd really don't want to stop services on Tomcat while in production.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r498049 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/core/StandardWrapper.java webapps/docs/changelog.xml

2007-01-19 Thread markt 
Author: markt
Date: Fri Jan 19 18:47:25 2007
New Revision: 498049

URL: http://svn.apache.org/viewvc?view=rev&rev=498049
Log:
Improved patch for 39088 based on patch by Wouter Zelle.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java?view=diff&rev=498049&r1=498048&r2=498049
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
 Fri Jan 19 18:47:25 2007
@@ -28,6 +28,8 @@
 import java.security.AccessController;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
+import java.sql.SQLException;
+
 import javax.servlet.Servlet;
 import javax.servlet.ServletConfig;
 import javax.servlet.ServletContext;
@@ -36,6 +38,7 @@
 import javax.servlet.ServletResponse;
 import javax.servlet.SingleThreadModel;
 import javax.servlet.UnavailableException;
+import javax.servlet.jsp.JspException;
 import javax.management.ListenerNotFoundException;
 import javax.management.MBeanNotificationInfo;
 import javax.management.Notification;
@@ -56,7 +59,6 @@
 import org.apache.catalina.security.SecurityUtil;
 import org.apache.catalina.util.Enumerator;
 import org.apache.catalina.util.InstanceSupport;
-import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.log.SystemLogHandler;
 import org.apache.commons.modeler.Registry;
 
@@ -632,23 +634,33 @@
  * @param e The servlet exception
  */
 public static Throwable getRootCause(ServletException e) {
-Throwable rootCause = e;
-Throwable rootCauseCheck = null;
-// Extra aggressive rootCause finding
-do {
-try {
-rootCauseCheck = (Throwable)IntrospectionUtils.getProperty
-(rootCause, "rootCause");
-if (rootCause == rootCauseCheck)
-rootCauseCheck = null;
-else if (rootCauseCheck != null)
-rootCause = rootCauseCheck;
+Throwable rootCause = e.getRootCause();
+return findRootCause(e, rootCause);
+}
 
-} catch (ClassCastException ex) {
-rootCauseCheck = null;
-}
-} while (rootCauseCheck != null);
-return rootCause;
+/*
+ * Work through the root causes using specific methods for well known types
+ * and getCause() for the rest. Stop when the next rootCause is null or
+ * an exception is found that has itself as its own rootCause. 
+ */
+private static final Throwable findRootCause(Throwable theException,
+Throwable theRootCause) {
+
+Throwable deeperRootCause = null;
+
+if (theRootCause == null || theRootCause == theException) {
+deeperRootCause = theException;
+} else if (theRootCause instanceof ServletException) {
+deeperRootCause = ((ServletException) theRootCause).getRootCause();
+} else if (theRootCause instanceof JspException) {
+deeperRootCause = ((JspException) theRootCause).getRootCause();
+} else if (theRootCause instanceof SQLException) {
+deeperRootCause = ((SQLException) theRootCause).getNextException();
+} else {
+deeperRootCause = theRootCause.getCause();
+}
+
+return deeperRootCause;
 }
 
 

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=498049&r1=498048&r2=498049
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Jan 19 18:47:25 2007
@@ -79,7 +79,8 @@
   
   
 39088: Prevent infinte loops when an exception is thrown
-that returns itself for getRootCause(). (markt)
+that returns itself for getRootCause(). Based on a patch by Wouter
+Zelle. (markt)
   
   
 39436: Correct MIME type for SVG. (markt)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39088] - StandardWrapper getRootCause() infinite loop

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39088


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 18:48 ---
Thanks for the new patch. I have committed a variation to svn and will be in
5.5.21 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r498052 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-19 Thread markt 
Author: markt
Date: Fri Jan 19 18:58:37 2007
New Revision: 498052

URL: http://svn.apache.org/viewvc?view=rev&rev=498052
Log:
Revert this while I figure why the build broke

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java?view=diff&rev=498052&r1=498051&r2=498052
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
 Fri Jan 19 18:58:37 2007
@@ -28,8 +28,6 @@
 import java.security.AccessController;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
-import java.sql.SQLException;
-
 import javax.servlet.Servlet;
 import javax.servlet.ServletConfig;
 import javax.servlet.ServletContext;
@@ -38,7 +36,6 @@
 import javax.servlet.ServletResponse;
 import javax.servlet.SingleThreadModel;
 import javax.servlet.UnavailableException;
-import javax.servlet.jsp.JspException;
 import javax.management.ListenerNotFoundException;
 import javax.management.MBeanNotificationInfo;
 import javax.management.Notification;
@@ -59,6 +56,7 @@
 import org.apache.catalina.security.SecurityUtil;
 import org.apache.catalina.util.Enumerator;
 import org.apache.catalina.util.InstanceSupport;
+import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.log.SystemLogHandler;
 import org.apache.commons.modeler.Registry;
 
@@ -634,33 +632,23 @@
  * @param e The servlet exception
  */
 public static Throwable getRootCause(ServletException e) {
-Throwable rootCause = e.getRootCause();
-return findRootCause(e, rootCause);
-}
+Throwable rootCause = e;
+Throwable rootCauseCheck = null;
+// Extra aggressive rootCause finding
+do {
+try {
+rootCauseCheck = (Throwable)IntrospectionUtils.getProperty
+(rootCause, "rootCause");
+if (rootCause == rootCauseCheck)
+rootCauseCheck = null;
+else if (rootCauseCheck != null)
+rootCause = rootCauseCheck;
 
-/*
- * Work through the root causes using specific methods for well known types
- * and getCause() for the rest. Stop when the next rootCause is null or
- * an exception is found that has itself as its own rootCause. 
- */
-private static final Throwable findRootCause(Throwable theException,
-Throwable theRootCause) {
-
-Throwable deeperRootCause = null;
-
-if (theRootCause == null || theRootCause == theException) {
-deeperRootCause = theException;
-} else if (theRootCause instanceof ServletException) {
-deeperRootCause = ((ServletException) theRootCause).getRootCause();
-} else if (theRootCause instanceof JspException) {
-deeperRootCause = ((JspException) theRootCause).getRootCause();
-} else if (theRootCause instanceof SQLException) {
-deeperRootCause = ((SQLException) theRootCause).getNextException();
-} else {
-deeperRootCause = theRootCause.getCause();
-}
-
-return deeperRootCause;
+} catch (ClassCastException ex) {
+rootCauseCheck = null;
+}
+} while (rootCauseCheck != null);
+return rootCause;
 }
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-19 Thread markt 
Author: markt
Date: Fri Jan 19 19:07:36 2007
New Revision: 498053

URL: http://svn.apache.org/viewvc?view=rev&rev=498053
Log:
Put the fix back for 39088 now the build is fixed. Sorry for the noise.

Modified:
tomcat/container/tc5.5.x/catalina/build.xml

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java

Modified: tomcat/container/tc5.5.x/catalina/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/build.xml?view=diff&rev=498053&r1=498052&r2=498053
==
--- tomcat/container/tc5.5.x/catalina/build.xml (original)
+++ tomcat/container/tc5.5.x/catalina/build.xml Fri Jan 19 19:07:36 2007
@@ -30,6 +30,7 @@
   
   
   
+  
   
   
 
 
+
 
 
 
@@ -101,6 +103,7 @@
 
 
 
+
 
 
 

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java?view=diff&rev=498053&r1=498052&r2=498053
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardWrapper.java
 Fri Jan 19 19:07:36 2007
@@ -28,6 +28,8 @@
 import java.security.AccessController;
 import java.security.PrivilegedActionException;
 import java.security.PrivilegedExceptionAction;
+import java.sql.SQLException;
+
 import javax.servlet.Servlet;
 import javax.servlet.ServletConfig;
 import javax.servlet.ServletContext;
@@ -36,6 +38,7 @@
 import javax.servlet.ServletResponse;
 import javax.servlet.SingleThreadModel;
 import javax.servlet.UnavailableException;
+import javax.servlet.jsp.JspException;
 import javax.management.ListenerNotFoundException;
 import javax.management.MBeanNotificationInfo;
 import javax.management.Notification;
@@ -56,7 +59,6 @@
 import org.apache.catalina.security.SecurityUtil;
 import org.apache.catalina.util.Enumerator;
 import org.apache.catalina.util.InstanceSupport;
-import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.log.SystemLogHandler;
 import org.apache.commons.modeler.Registry;
 
@@ -632,23 +634,33 @@
  * @param e The servlet exception
  */
 public static Throwable getRootCause(ServletException e) {
-Throwable rootCause = e;
-Throwable rootCauseCheck = null;
-// Extra aggressive rootCause finding
-do {
-try {
-rootCauseCheck = (Throwable)IntrospectionUtils.getProperty
-(rootCause, "rootCause");
-if (rootCause == rootCauseCheck)
-rootCauseCheck = null;
-else if (rootCauseCheck != null)
-rootCause = rootCauseCheck;
+Throwable rootCause = e.getRootCause();
+return findRootCause(e, rootCause);
+}
 
-} catch (ClassCastException ex) {
-rootCauseCheck = null;
-}
-} while (rootCauseCheck != null);
-return rootCause;
+/*
+ * Work through the root causes using specific methods for well known types
+ * and getCause() for the rest. Stop when the next rootCause is null or
+ * an exception is found that has itself as its own rootCause. 
+ */
+private static final Throwable findRootCause(Throwable theException,
+Throwable theRootCause) {
+
+Throwable deeperRootCause = null;
+
+if (theRootCause == null || theRootCause == theException) {
+deeperRootCause = theException;
+} else if (theRootCause instanceof ServletException) {
+deeperRootCause = ((ServletException) theRootCause).getRootCause();
+} else if (theRootCause instanceof JspException) {
+deeperRootCause = ((JspException) theRootCause).getRootCause();
+} else if (theRootCause instanceof SQLException) {
+deeperRootCause = ((SQLException) theRootCause).getNextException();
+} else {
+deeperRootCause = theRootCause.getCause();
+}
+
+return deeperRootCause;
 }
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r498058 - in /tomcat: container/tc5.5.x/webapps/docs/changelog.xml jasper/tc5.5.x/src/share/org/apache/jasper/EmbeddedServletOptions.java

2007-01-19 Thread markt 
Author: markt
Date: Fri Jan 19 19:38:23 2007
New Revision: 498058

URL: http://svn.apache.org/viewvc?view=rev&rev=498058
Log:
Fix bug 41265 by removing the code that resets checkInterval values of zero to 
300. If not checkInterval is not specified it defaults to zero anyway and 
removing the code was easier than trying to explain in the documentation why 
the stated default could not be explicitly set.

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/EmbeddedServletOptions.java

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=498058&r1=498057&r2=498058
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Jan 19 19:38:23 2007
@@ -275,6 +275,11 @@
 (markt)
   
   
+41265: Allow JspServlet checkInterval init parameter to be
+explicitly set to the stated default value of zero by removing the
+code that resets it to 300 if explicitly specified as zero. (markt)
+  
+  
 Display the JSP source when a compilation error occurs and display
 the correct line number rather than start of a scriptlet block. (markt)
   

Modified: 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/EmbeddedServletOptions.java
URL: 
http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/EmbeddedServletOptions.java?view=diff&rev=498058&r1=498057&r2=498058
==
--- 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/EmbeddedServletOptions.java 
(original)
+++ 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/EmbeddedServletOptions.java 
Fri Jan 19 19:38:23 2007
@@ -469,12 +469,6 @@
 if (checkInterval != null) {
 try {
 this.checkInterval = Integer.parseInt(checkInterval);
-if (this.checkInterval == 0) {
-this.checkInterval = 300;
-if (log.isWarnEnabled()) {
-
log.warn(Localizer.getMessage("jsp.warning.checkInterval"));
-}
-}
 } catch(NumberFormatException ex) {
 if (log.isWarnEnabled()) {
 
log.warn(Localizer.getMessage("jsp.warning.checkInterval"));



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41265] - JspServlet's checkInterval parameter cannot be set to 0 implicitly

2007-01-19 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41265


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-01-19 19:40 ---
This is fixed in svn and will be in 5.5.21 onwards. I removed the code that
reset the value to 300 if specified as zero.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]