svn commit: r479939 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[pero]

Author: pero
Date: Tue Nov 28 00:12:13 2006
New Revision: 479939

URL: http://svn.apache.org/viewvc?view=rev&rev=479939
Log:
Fix correct table formating at 'Edit worker dialog'

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=479939&r1=479938&r2=479939
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Nov 28 00:12:13 
2006
@@ -1277,6 +1277,7 @@
 status_start_form(s, "GET", JK_STATUS_CMD_UPDATE,
   0, from, refresh, worker, wr->s->name);
 
+jk_puts(s, "\n");
 jk_putv(s, "", JK_STATUS_ARG_LBM_TEXT_ACTIVATION,
 ":\n", NULL);
 jk_putv(s, "  Active\n", wr->s->lb_factor);
-jk_putv(s, "\n", JK_STATUS_ARG_LBM_TEXT_ROUTE,
+jk_putv(s, "", JK_STATUS_ARG_LBM_TEXT_ROUTE,
 ":\n", wr->s->jvm_route);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479953 - /tomcat/tc6.0.x/trunk/webapps/docs/apr.xml

[mturk]

Author: mturk
Date: Tue Nov 28 00:51:21 2006
New Revision: 479953

URL: http://svn.apache.org/viewvc?view=rev&rev=479953
Log:
Fix example AprSLL. We have a new param SSLEnabled.

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/apr.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/apr.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/apr.xml?view=diff&rev=479953&r1=479952&r2=479953
==
--- tomcat/tc6.0.x/trunk/webapps/docs/apr.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/apr.xml Tue Nov 28 00:51:21 2006
@@ -114,13 +114,16 @@
 
 
   Name of the SSLEngine to use. off: Do not use SSL, on: Use SSL but no 
specific ENGINE.
-  The default value is on.
+  The default value is on.
   This initializes the native SSL engine, then enable the use of this 
engine in the connector 
   using the SSLEnabled attribute. Example:
   
 
   
 
+See the http://www.openssl.org";>Official OpenSSL 
+   website for more details on SSL hardware engines and manufacturers.
+
 
 
   
@@ -287,7 +290,7 @@
maxThreads="150" minSpareThreads="25" maxSpareThreads="75"
enableLookups="false" disableUploadTimeout="true"
acceptCount="100" scheme="https" secure="true"
-   SSLEngine="on" 
+   SSLEnabled="true" 
SSLCertificateFile="${catalina.base}/conf/localhost.crt"
SSLCertificateKeyFile="${catalina.base}/conf/localhost.key" 
/>
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Tomcat web site admin problems.

[Mladen Turk]

Remy,

Can you change the permissions for the files in
/x1/www/tomcat.apache.org/tomcat-6.0-doc-v6.0.2
from 0644 to 0664?
Add group write permission, so other can modify the docs.

I know, it's a version related, but we should not
create a new tag if there is error in the docs thought.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479961 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[rjung]

Author: rjung
Date: Tue Nov 28 01:33:48 2006
New Revision: 479961

URL: http://svn.apache.org/viewvc?view=rev&rev=479961
Log:
Fix compiler warnings.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=479961&r1=479960&r2=479961
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Nov 28 01:33:48 
2006
@@ -151,7 +151,7 @@
 const char*doctype;
 int   read_only;
 char  **user_names;
-int   num_of_users;
+unsigned int  num_of_users;
 jk_worker_t   worker;
 status_endpoint_t ep;
 jk_worker_env_t   *we;
@@ -2316,7 +2316,7 @@
 
 if (w->num_of_users) {
 if (s->remote_user) {
-int i;
+unsigned int i;
 denied = 1;
 for (i = 0; i < w->num_of_users; i++) {
 if (!strcmp(s->remote_user, w->user_names[i])) {
@@ -2654,7 +2654,7 @@
 JK_TRACE_ENTER(log);
 if (pThis && pThis->worker_private) {
 status_worker_t *p = pThis->worker_private;
-int i;
+unsigned int i;
 p->we = we;
 p->css = jk_get_worker_style_sheet(props, p->name, NULL);
 p->ns = jk_get_worker_name_space(props, p->name, JK_NSDEF);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479963 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[rjung]

Author: rjung
Date: Tue Nov 28 01:44:04 2006
New Revision: 479963

URL: http://svn.apache.org/viewvc?view=rev&rev=479963
Log:
Adding "back" links to the form views (edit) of the status worker.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=479963&r1=479962&r2=479963
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Nov 28 01:44:04 
2006
@@ -678,6 +678,13 @@
 lb_worker_t *lb = NULL;
 
 JK_TRACE_ENTER(l);
+if (single) {
+jk_puts(s, "\n");
+status_write_uri(s, "Back to full worker list", JK_STATUS_CMD_LIST,
+ 0, 0, refresh, NULL, NULL);
+jk_puts(s, "\n");
+from = JK_STATUS_CMD_SHOW;
+}
 if (w->type == JK_LB_WORKER_TYPE) {
 lb = (lb_worker_t *)w->worker_private;
 name = lb->s->name;
@@ -702,13 +709,6 @@
 JK_TRACE_EXIT(l);
 return;
 }
-if (single) {
-jk_puts(s, "\n");
-status_write_uri(s, "Back to full worker list", JK_STATUS_CMD_LIST,
- 0, 0, refresh, NULL, NULL);
-jk_puts(s, "\n");
-from = JK_STATUS_CMD_SHOW;
-}
 
 if (lb) {
 time_t now = time(NULL);
@@ -1128,6 +1128,10 @@
 lb_worker_t *lb = NULL;
 
 JK_TRACE_ENTER(l);
+jk_puts(s, "\n");
+status_write_uri(s, "Back to worker view", from,
+ 0, 0, refresh, NULL, NULL);
+jk_puts(s, "\n");
 if (w->type == JK_LB_WORKER_TYPE) {
 lb = (lb_worker_t *)w->worker_private;
 name = lb->s->name;
@@ -1272,6 +1276,11 @@
 jk_log(l, JK_LOG_DEBUG,
"producing edit form for sub worker '%s' of lb worker '%s'",
wr->s->name, worker);
+
+jk_puts(s, "\n");
+status_write_uri(s, "Back to worker view", from,
+ 0, 0, refresh, NULL, NULL);
+jk_puts(s, "\n");
 jk_putv(s, "Edit worker settings for ",
 wr->s->name, "\n", NULL);
 status_start_form(s, "GET", JK_STATUS_CMD_UPDATE,
@@ -1336,6 +1345,10 @@
 unsigned int i;
 
 JK_TRACE_ENTER(l);
+jk_puts(s, "\n");
+status_write_uri(s, "Back to worker view", from,
+ 0, 0, refresh, NULL, NULL);
+jk_puts(s, "\n");
 if (!attribute) {
 jk_log(l, JK_LOG_WARNING,
"missing request parameter '%s'",



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41016] - tomcat 5.5 multiple contexts using same realm bug

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41016





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 01:44 ---
(In reply to comment #3)
> Hi
>  Not so sure, when we spotted the "issues". I told elliot to add the
> "localDatasource" attribute to "true" in the *realm* (
>
http://mail-archives.apache.org/mod_mbox/tomcat-users/200611.mbox/[EMAIL 
PROTECTED]
> )
> Perhaps it a bug in the bugreport :-)

Apologies and correct. I did add "localDataSource" to the realm - my bug report
does in fact have a bug in it! But App A and App B context's are exactly the
same but for the names/paths. I also do not believe there is a problem with them
as either runs independantly or both sort of work with the localDataSource fix.
I have noticed since I tried this "fix" that sometimes on tomcat start up it
doesn't seem to work and takes a redeploy to resolve the issue. This may be an
error my side (that I am looking at) but is part of some strange behaviour
generally. 


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479965 - /tomcat/connectors/trunk/jni/native/src/ssl.c

[mturk]

Author: mturk
Date: Tue Nov 28 01:47:42 2006
New Revision: 479965

URL: http://svn.apache.org/viewvc?view=rev&rev=479965
Log:
The AprLifecycleListener depend on the SSL.initialize
throwing exception. Make sure exception is thrown together
with error code returned.

Modified:
tomcat/connectors/trunk/jni/native/src/ssl.c

Modified: tomcat/connectors/trunk/jni/native/src/ssl.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/ssl.c?view=diff&rev=479965&r1=479964&r2=479965
==
--- tomcat/connectors/trunk/jni/native/src/ssl.c (original)
+++ tomcat/connectors/trunk/jni/native/src/ssl.c Tue Nov 28 01:47:42 2006
@@ -369,6 +369,7 @@
 UNREFERENCED(o);
 if (!tcn_global_pool) {
 TCN_FREE_CSTRING(engine);
+tcn_ThrowAPRException(e, APR_EINVAL);
 return (jint)APR_EINVAL;
 }
 /* Check if already initialized */
@@ -378,6 +379,8 @@
 }
 if (SSLeay() < 0x0090700L) {
 TCN_FREE_CSTRING(engine);
+tcn_ThrowAPRException(e, APR_EINVAL);
+ssl_initialized = 0;
 return (jint)APR_EINVAL;
 }
 /* We must register the library in full, to ensure our configuration
@@ -418,6 +421,7 @@
 if (err != APR_SUCCESS) {
 TCN_FREE_CSTRING(engine);
 ssl_init_cleanup(NULL);
+tcn_ThrowAPRException(e, err);
 return (jint)err;
 }
 tcn_ssl_engine = ee;
@@ -437,6 +441,7 @@
 if (r) {
 TCN_FREE_CSTRING(engine);
 ssl_init_cleanup(NULL);
+tcn_ThrowAPRException(e, APR_ENOTIMPL);
 return APR_ENOTIMPL;
 }
 /*
@@ -820,8 +825,9 @@
 
 TCN_IMPLEMENT_CALL(jint, SSL, initialize)(TCN_STDARGS, jstring engine)
 {
-UNREFERENCED_STDARGS;
+UNREFERENCED(o);
 UNREFERENCED(engine);
+tcn_ThrowAPRException(e, APR_ENOTIMPL);
 return (jint)APR_ENOTIMPL;
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479966 - /tomcat/connectors/trunk/jni/native/src/sslnetwork.c

[mturk]

Author: mturk
Date: Tue Nov 28 01:48:30 2006
New Revision: 479966

URL: http://svn.apache.org/viewvc?view=rev&rev=479966
Log:
Add missing stub for SSLSocket.handskake if the
OpenSSL was not compiled in.

Modified:
tomcat/connectors/trunk/jni/native/src/sslnetwork.c

Modified: tomcat/connectors/trunk/jni/native/src/sslnetwork.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/sslnetwork.c?view=diff&rev=479966&r1=479965&r2=479966
==
--- tomcat/connectors/trunk/jni/native/src/sslnetwork.c (original)
+++ tomcat/connectors/trunk/jni/native/src/sslnetwork.c Tue Nov 28 01:48:30 2006
@@ -567,6 +567,13 @@
  * Create empty stubs.
  */
 
+TCN_IMPLEMENT_CALL(jint, SSLSocket, handshake)(TCN_STDARGS, jlong sock)
+{
+UNREFERENCED_STDARGS;
+UNREFERENCED(sock);
+return (jint)APR_ENOTIMPL;
+}
+
 TCN_IMPLEMENT_CALL(jint, SSLSocket, attach)(TCN_STDARGS, jlong ctx,
 jlong sock)
 {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479969 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[rjung]

Author: rjung
Date: Tue Nov 28 01:56:10 2006
New Revision: 479969

URL: http://svn.apache.org/viewvc?view=rev&rev=479969
Log:
Add easier to detect result message to the end of status worker output.
Should help with automation.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=479969&r1=479968&r2=479969
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Nov 28 01:56:10 
2006
@@ -2609,14 +2609,30 @@
 }
 if (err) {
 if (mime == JK_STATUS_MIME_HTML) {
-jk_putv(s, "", err, "", NULL);
+jk_putv(s, "Result: ERROR - ", err, "", NULL);
 jk_putv(s, "req_uri, "\">JK Status Manager", 
NULL);
 }
 else if (mime == JK_STATUS_MIME_XML) {
-jk_putv(s, "", err, "", NULL);
+jk_putv(s, "  <", w->ns, "result\n", NULL);
+jk_puts(s, "   type=\"ERROR\"\n");
+jk_putv(s, "   msg=\"", err, "\"/>\n", NULL);
 }
 else {
-jk_puts(s, err);
+jk_putv(s, "ERROR - ", err, NULL);
+}
+}
+else {
+if (mime == JK_STATUS_MIME_HTML) {
+jk_puts(s, "Result: OK - Action finished");
+jk_putv(s, "req_uri, "\">JK Status Manager", 
NULL);
+}
+else if (mime == JK_STATUS_MIME_XML) {
+jk_putv(s, "  <", w->ns, "result\n", NULL);
+jk_puts(s, "   type=\"OK\"\n");
+jk_puts(s, "   msg=\"Action finished\"/>\n");
+}
+else {
+jk_puts(s, "OK - Action finished");
 }
 }
 if (mime == JK_STATUS_MIME_HTML) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r479995 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

[mturk]

Author: mturk
Date: Tue Nov 28 03:21:38 2006
New Revision: 479995

URL: http://svn.apache.org/viewvc?view=rev&rev=479995
Log:
Refactor AprLifecycleListener by putting the logic into separate methods.
1. Do not call terminate in case initialize failed
2. Call terminate if version is below required.
3. Do not initialize SSL if APR was not initialized.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java?view=diff&rev=479995&r1=479994&r2=479995
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/AprLifecycleListener.java 
Tue Nov 28 03:21:38 2006
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -50,20 +50,21 @@
 protected StringManager sm =
 StringManager.getManager(Constants.Package);
 
-
-// -- Constants
+
+// -- Constants
 
 
-protected static final int REQUIRED_MAJOR = 1;
-protected static final int REQUIRED_MINOR = 1;
-protected static final int REQUIRED_PATCH = 3;
-protected static final int RECOMMENDED_PV = 7;
+protected static final int TCN_REQUIRED_MAJOR = 1;
+protected static final int TCN_REQUIRED_MINOR = 1;
+protected static final int TCN_REQUIRED_PATCH = 3;
+protected static final int TCN_RECOMMENDED_PV = 7;
 
 
 // -- Properties
 protected static String SSLEngine = "on"; //default on
 protected static boolean sslInitialized = false;
-
+protected static boolean aprInitialized = false;
+
 // -- LifecycleListener Methods
 
 /**
@@ -74,59 +75,21 @@
 public void lifecycleEvent(LifecycleEvent event) {
 
 if (Lifecycle.INIT_EVENT.equals(event.getType())) {
-int major = 0;
-int minor = 0;
-int patch = 0;
-try {
-String methodName = "initialize";
-Class paramTypes[] = new Class[1];
-paramTypes[0] = String.class;
-Object paramValues[] = new Object[1];
-paramValues[0] = null;
-Class clazz = Class.forName("org.apache.tomcat.jni.Library");
-Method method = clazz.getMethod(methodName, paramTypes);
-method.invoke(null, paramValues);
-major = clazz.getField("TCN_MAJOR_VERSION").getInt(null);
-minor = clazz.getField("TCN_MINOR_VERSION").getInt(null);
-patch = clazz.getField("TCN_PATCH_VERSION").getInt(null);
-} catch (Throwable t) {
-if (!log.isDebugEnabled()) {
-log.info(sm.getString("aprListener.aprInit", 
-System.getProperty("java.library.path")));
-} else {
-log.debug(sm.getString("aprListener.aprInit", 
-System.getProperty("java.library.path")), t);
+aprInitialized = initializeAPR();
+if (aprInitialized) {
+try {
+initializeSSL();
+} catch (Throwable t) {
+log.error(sm.getString("aprListener.sslInit",
+   t.getMessage()), t);
 }
-return;
-}
-if ((major != REQUIRED_MAJOR) || (minor != REQUIRED_MINOR)
-|| (patch < REQUIRED_PATCH)) {
-log.error(sm.getString("aprListener.tcnInvalid", major + "." 
-+ minor + "." + patch, REQUIRED_MAJOR + "." 
-+ REQUIRED_MINOR + "." + REQUIRED_PATCH));
-}
-if (patch < RECOMMENDED_PV) {
-if (!log.isDebugEnabled()) {
-log.info(sm.getString("aprListener.tcnVersion", major + 
"." 
-+ minor + "." + patch, REQUIRED_MAJOR + "." 
-+ REQUIRED_MINOR + "." + RECOMMENDED_PV));
-} else {
-log.debug(sm.getString("aprListener.tcnVersion", major + 
"." 
-   

svn commit: r480000 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java

[mturk]

Author: mturk
Date: Tue Nov 28 03:31:04 2006
New Revision: 48

URL: http://svn.apache.org/viewvc?view=rev&rev=48
Log:
Avoid initializing APR for each connector.
Also test the minimum version required.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java?view=diff&rev=48&r1=47&r2=48
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java Tue 
Nov 28 03:31:04 2006
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -65,7 +65,7 @@
 public static final boolean RECYCLE_FACADES =
 
Boolean.valueOf(System.getProperty("org.apache.catalina.connector.RECYCLE_FACADES",
 "false")).booleanValue();
 
-
+
 //  Constructor
 
 
@@ -73,8 +73,8 @@
 throws Exception {
 this(null);
 }
-
-public Connector(String protocol) 
+
+public Connector(String protocol)
 throws Exception {
 setProtocol(protocol);
 // Instantiate protocol handler
@@ -87,8 +87,8 @@
  ("coyoteConnector.protocolHandlerInstantiationFailed", e));
 }
 }
-
-
+
+
 // - Instance Variables
 
 
@@ -193,7 +193,7 @@
 
 
 /**
- * Maximum size of a POST which will be automatically parsed by the 
+ * Maximum size of a POST which will be automatically parsed by the
  * container. 2MB by default.
  */
 protected int maxPostSize = 2 * 1024 * 1024;
@@ -293,8 +293,8 @@
  replacements.put("sslProtocol", "protocol");
  replacements.put("sslProtocols", "protocols");
  }
- 
- 
+
+
 // - Properties
 
 
@@ -309,7 +309,7 @@
 return IntrospectionUtils.getProperty(protocolHandler, repl);
 }
 
-
+
 /**
  * Set a configured property.
  */
@@ -321,7 +321,7 @@
 IntrospectionUtils.setProperty(protocolHandler, repl, value);
 }
 
-
+
 /**
  * Return a configured property.
  */
@@ -329,7 +329,7 @@
 return getProperty(name);
 }
 
-
+
 /**
  * Set a configured property.
  */
@@ -337,8 +337,8 @@
 setProperty(name, String.valueOf(value));
 }
 
-
-/** 
+
+/**
  * remove a configured property.
  */
 public void removeProperty(String name) {
@@ -346,7 +346,7 @@
 //protocolHandler.removeAttribute(name);
 }
 
-
+
 /**
  * Return the Service with which we are associated (if any).
  */
@@ -404,7 +404,7 @@
 
 /**
  * Return the input buffer size for this Connector.
- * 
+ *
  * @deprecated
  */
 public int getBufferSize() {
@@ -420,7 +420,7 @@
 public void setBufferSize(int bufferSize) {
 }
 
-
+
 /**
  * Return the Container used for processing requests received by this
  * Connector.
@@ -428,7 +428,7 @@
 public Container getContainer() {
 if( container==null ) {
 // Lazy - maybe it was added later
-findContainer(); 
+findContainer();
 }
 return (container);
 
@@ -529,7 +529,7 @@
  * Set the maximum size of a POST which will be automatically
  * parsed by the container.
  *
- * @param maxPostSize The new maximum size in bytes of a POST which will 
+ * @param maxPostSize The new maximum size in bytes of a POST which will
  * be automatically parsed by the container
  */
 public void setMaxPostSize(int maxPostSize) {
@@ -605,32 +605,67 @@
 return getProtocolHandlerClassName();
 
 }
+
+// -- APR Version Constants
 
+private static final int TCN_REQUIRED_MAJOR = 1;
+private static final int TCN_REQUIRED_MINOR = 1;
+private static final int TCN_REQUIRED_PATCH = 3;
+private static boolean aprInitialized = false;
 
-/**
- * Set the Coyote protocol which will be used by the connector.
- *
- * @param protocol The Coyote protocol name
- */
-public void setProtocol(String protocol) {
-
-// Test APR sup

[TC6] Minimum coding style

[Mladen Turk]

Hi,

Just committed two files, and again I've bumped
upon the coding style.
Although it seems we are quite good relating to the
tabs, the trailing spaces are a real mess in some files.
There are lots of files where we have
if (...) {
followed with the one or more spaces.
Also there are lots empty lines that contains only
one more space chars.

I propose I make a simple script that will remove
all the trailing spaces from all files in the repository,
and after that we should take care on that just like
we take care on tabs.

I know it's not something critical, but neither are
unused imports, etc...
IMHO, it's better to do that at once rather then
having commits changing lots of irrelevant coding style
related issues.

Comments?

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Remy Maucherat]

Mladen Turk wrote:

Hi,

Just committed two files, and again I've bumped
upon the coding style.
Although it seems we are quite good relating to the
tabs, the trailing spaces are a real mess in some files.
There are lots of files where we have
if (...) {
followed with the one or more spaces.
Also there are lots empty lines that contains only
one more space chars.

I propose I make a simple script that will remove
all the trailing spaces from all files in the repository,
and after that we should take care on that just like
we take care on tabs.

I know it's not something critical, but neither are
unused imports, etc...
IMHO, it's better to do that at once rather then
having commits changing lots of irrelevant coding style
related issues.

Comments?


-1. This will screw up diffs, and these really irrelevant things will be 
added back very quickly. Tabs is one thing since it can be hard to work 
with, but this is simply ridiculous. Also, don't do commits that include 
these cosmetic changes and real changes if you can avoid it.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Mladen Turk]

Remy Maucherat wrote:

Mladen Turk wrote:


Comments?


-1. This will screw up diffs, and these really irrelevant things will be 
added back very quickly. Tabs is one thing since it can be hard to work 
with, but this is simply ridiculous.


Right, but at least the empty lines with spaces are very well
ridiculous, don't you think?
Most of those things come as a copy/paste from older Tomcat versions.

Also, don't do commits that include 
these cosmetic changes and real changes if you can avoid it.




I'm using editor (UltraEdit) that has an option to
remove the trailing spaces on save. I'm sure most
other editors have something similar, so I occasionally forget
the rule of different ASF project.

Anyhow, we still don't have a release for TC6, so
we might consider cleaning up the code style at this early stage.

Also, I love the Filip style (sorry if that doesn't originates from you):
for example, MessageDispatchInterceptor:

}//end if
}//sync
}//end if

Now, that is what I call ridiculous.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Remy Maucherat]

Mladen Turk wrote:

Also, I love the Filip style (sorry if that doesn't originates from you):
for example, MessageDispatchInterceptor:

}//end if
}//sync
}//end if

Now, that is what I call ridiculous.


Nice comment :( And what if he likes it and it makes his programming 
easier ?


-1 for enforcing any coding style (except tabs, since it can make code 
unreadable very easily).


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Filip Hanik - Dev Lists]

Mladen Turk wrote:

Remy Maucherat wrote:

Mladen Turk wrote:


Comments?


-1. This will screw up diffs, and these really irrelevant things will 
be added back very quickly. Tabs is one thing since it can be hard to 
work with, but this is simply ridiculous.


Right, but at least the empty lines with spaces are very well
ridiculous, don't you think?
Most of those things come as a copy/paste from older Tomcat versions.

Also, don't do commits that include these cosmetic changes and real 
changes if you can avoid it.




I'm using editor (UltraEdit) that has an option to
remove the trailing spaces on save. I'm sure most
other editors have something similar, so I occasionally forget
the rule of different ASF project.

Anyhow, we still don't have a release for TC6, so
we might consider cleaning up the code style at this early stage.

Also, I love the Filip style (sorry if that doesn't originates from you):
for example, MessageDispatchInterceptor:

}//end if
}//sync
}//end if

Now, that is what I call ridiculous.

I guess any publicity is good publicity ;)

Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Mladen Turk]

Remy Maucherat wrote:


-1 for enforcing any coding style (except tabs, since it can make code 
unreadable very easily).




You must be joking, right?

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Jim Jagielski]

On Nov 28, 2006, at 9:36 AM, Mladen Turk wrote:


Remy Maucherat wrote:
-1 for enforcing any coding style (except tabs, since it can make  
code unreadable very easily).




You must be joking, right?



One hopes...


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Tim Funk]

+1 trailing spaces always annoy me and text editors can easily be 
configured to strip them out.


An alternative is to change the email diffs to diff ignoring whitespace 
changes. Then lines can have all the trailing spaces they want and we 
won't see those diffs.


-Tim

Mladen Turk wrote:

Hi,

Just committed two files, and again I've bumped
upon the coding style.
Although it seems we are quite good relating to the
tabs, the trailing spaces are a real mess in some files.
There are lots of files where we have
if (...) {
followed with the one or more spaces.
Also there are lots empty lines that contains only
one more space chars.

I propose I make a simple script that will remove
all the trailing spaces from all files in the repository,
and after that we should take care on that just like
we take care on tabs.

I know it's not something critical, but neither are
unused imports, etc...
IMHO, it's better to do that at once rather then
having commits changing lots of irrelevant coding style
related issues.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37869] - Cannot obtain client certificate with SSL / client certificate authentication using APR components

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37869





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 07:35 ---

I have the same problem (Tomcat 6.0.2, Tomcat-Native 1.1.7-win32, Windows XPSP2,
OpenSSL 0.9.8d, APR from Apache-2.2.3).

1) when I HTTP-GET some sample servlet from browser (IE, FireFox),
Http11APRProcessor doesn't insert user certificate into request object

2) when I use "openssl s_client", everything's fine

Simple debug reveals one problem - in request from browser, there is no data in:
int certLength = SSLSocket.getInfoI(socket, SSL.SSL_INFO_CLIENT_CERT_CHAIN)

and so there is no cert chain in:
byte[] data = SSLSocket.getInfoB(socket, SSL.SSL_INFO_CLIENT_CERT_CHAIN + i);

but there IS client's certificate in (my added sample line):
SSLSocket.getInfoB(socket, org.apache.tomcat.jni.SSL.SSL_INFO_CLIENT_CERT)

and it is the client's certificate.

I think the problem is with not looking for data under key
"org.apache.tomcat.jni.SSL.SSL_INFO_CLIENT_CERT" but only under
"org.apache.tomcat.jni.SSL.SSL_INFO_CLIENT_CERT_CHAIN"...

with regards
Grzegorz Grzybek



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Remy Maucherat]

Jim Jagielski wrote:


On Nov 28, 2006, at 9:36 AM, Mladen Turk wrote:


Remy Maucherat wrote:
-1 for enforcing any coding style (except tabs, since it can make 
code unreadable very easily).




You must be joking, right?



One hopes...


Why ? Because arbitrary rules only create tensions ? It's obvious there 
isn't going a unified enforced standard.


Again: -1 to change this.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Jim Jagielski]

On Nov 28, 2006, at 10:44 AM, Remy Maucherat wrote:


Jim Jagielski wrote:

On Nov 28, 2006, at 9:36 AM, Mladen Turk wrote:

Remy Maucherat wrote:
-1 for enforcing any coding style (except tabs, since it can  
make code unreadable very easily).




You must be joking, right?


One hopes...


Why ?


Coding styles exist to *help* make code more readable
by being more consistent.

I'm a firm believer in the One True Tab, but I lost that
battle lng ago :)

In any case, I agree that patches that have maybe 90% of
the diffs due to such formatting changes make it awfully
hard to figure out just what the heck in going on.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Remy Maucherat]

Jim Jagielski wrote:

I'm a firm believer in the One True Tab, but I lost that
battle lng ago :)


Yes, I used to push for one coding style a long time ago, but it's not 
going to happen (I figured it was better to collaborate with Costin 
rather than keep the "clean" - ahem - coding style and not get any help).


Creative coding "styles" are not allowed if they are not readable at 
all, of course (it's implied when one asserts tabs are avoided).


Like:

String


my_stupid_field_prefix__FOO="bar";

is not good.

Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Henri Gomez]

I remember the cold days of the 'Tab brigade' :)

2006/11/28, Remy Maucherat <[EMAIL PROTECTED]>:

Jim Jagielski wrote:
> I'm a firm believer in the One True Tab, but I lost that
> battle lng ago :)

Yes, I used to push for one coding style a long time ago, but it's not
going to happen (I figured it was better to collaborate with Costin
rather than keep the "clean" - ahem - coding style and not get any help).

Creative coding "styles" are not allowed if they are not readable at
all, of course (it's implied when one asserts tabs are avoided).

Like:

 String


my_stupid_field_prefix__FOO="bar";

is not good.

Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37869] - Cannot obtain client certificate with SSL / client certificate authentication using APR components

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37869





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 09:04 ---
If you have tested a patch to also consider SSL_INFO_CLIENT_CERT if the chain is
empty, you can submit it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 39120] - Create semantics for "path" attribute in embedded context.xml

[Kris Nuttycombe]

Hi, Mark,

Thanks for your reply. Perhaps I should be stating the problem in terms
of how I would like to be able to deploy a web application and what was
possible under 5.0 instead of in terms of the problems I have
encountered. Here is what I would like to do:

I have a warfile, myapp-1.3.5.war which has an embedded
META-INF/context.xml file with information like the JNDI data source
configuration. This webapp is to be deployed on the host foo.example.com
at the path http://foo.example.com/fooco/webapps/somecategory/myapp. I
also do not have any access to our production webserver; in order to
deploy a web application, I need to be able to give this warfile to a
system administrator who knows nothing about Tomcat and have him deploy
the application. Under Tomcat 5.0 and previous releases, I was able to
simply have him drop the warfile in the $CATALINA-HOME/webapps directory
and everything would work fine. If I gave him a new version,
myapp-1.4.0.war, he could look in the webapps directory and see that
myapp-1.3.5 needed to be replaced.

From my experience, under tomcat 5.5, myapp-1.3.5.war has to be put
into some other tomcat-accessible directory on the server, and the
content of the embedded context.xml file has to be extracted and added
to the server.xml file. This means that manual intervention of the
sysadmin is required, where before we were able to have an rsync'ed
staging directory on a server to which our developers have access; we
would simply drop the warfile there and it would automatically be copied
out to the production server during the maintainance window.

If there is a way to make things work like they did under Tomcat 5.0,
please, please let me know. I interspersed a few more comments below.

Thanks,

Kris

Mark Thomas wrote:

Kris Nuttycombe wrote:
  

Is there any documentation on the rationale behind this change?


As far as I recall, there were a number of posts to the dev list back
when the 5.5.x branch was being proposed. The (very) short version was
to make things simpler and less buggy.
  

It is
extraordinarily inconvenient as it prevents the deployment of a
context at any path other than the server root unless you unpack the
warfile - effectively making straight warfile deployment impossible in
such a case.


Maybe I am missing your point but you can deploy a war at any path you
like without having to unpack it. Options include:
- in individual files (with a ".xml" extension) in the
$CATALINA_HOME/conf/[enginename]/[hostname]/ directory
  


You're talking here about the context.xml file. When a warfile is simply
dropped in to the $CATALINA_HOME/webapps directory, the context.xml file
is extracted from META-INF and placed in the correct location; however,
the value of the "path" attribute appears to be ignored.


- in individual files (with a ".xml" extension) in the
$CATALINA_HOME/webapps directory




I have not been able to get this approach to work at all. I presume that
you're talking about the context.xml file here? When I put myapp.xml in
this directory, the webapp is not found at all.


- rename the war
  


This doesn't solve the problem of having the webapp deployed in some
deep directory structure.


In my shop, developers use the
manager web application to deploy our applications and don't have
write permissions for server.xml - but need to be able to deploy
applications that don't have paths at the server root.


And the manager doesn't (or at least it shouldn't) stop them doing this.

Mark

  


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41057] New: - Tomcat leaks memory on every request

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41057

   Summary: Tomcat leaks memory on every request
   Product: Tomcat 5
   Version: 5.5.20
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


POST parameter values stay referenced by a static field in
org.apache.tomcat.util.buf.StringCache - thus the GC can never release the 
memory.

Steps to Reproduce:
1) install and start tomcat 5.5
(http://apache.zone-h.org/tomcat/tomcat-5/v5.5.20/bin/apache-tomcat-5.5.20.zip)

2) see the example webapp "Request Parameters Example" included in the install
(http://localhost:8080/servlets-examples/servlet/RequestParamExample)

3) run script "send.sh" to create heavy load
#!/bin/bash

export LEAK_COMMAND='curl --silent
http://localhost:8080/servlets-examples/servlet/RequestParamExample --output
response.htm --data @send.txt'

#create initial POST parameter with value about 10kB

echo "firstname=" > send.txt
for((i=0;$i<=1;i=$(($i+1;do
  echo -n "x" >> send.txt
done


#send the request
for((i=0;$i<=1000;i=$(($i+1;do
  echo $i
  # modify the param value to send (append i)
  echo -n $i >> send.txt
  
  $LEAK_COMMAND

done

4) running the script causes heap usage to increase for some 40MB

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41057] - Tomcat leaks memory on every request

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41057





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 10:13 ---
Created an attachment (id=19184)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19184&action=view)
some JRockit Memory Leak Detector pictures and the script to send data


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 11:06 ---
What version of JDK are you using?

I've tried to repro this on both WinXP and Linux with JDK1.4.2 and JDK1.5 and
both create keystore entries with downcased aliases.

e.g.:
C:\Documents and Settings\Chris>"c:\Program Files\Java\j2re1.4.2_13\bin\keytool.
exe" -genkey -alias CamelCase -keystore keystore -keyalg RSA


Produces:

C:\Documents and Settings\Chris>"c:\Program Files\Java\j2re1.4.2_13\bin\keytool.
exe" -list -v -keystore keystore
Enter keystore password:  changeit

Keystore type: jks
Keystore provider: SUN

Your keystore contains 1 entry

Alias name: camelcase
Creation date: Nov 28, 2006
Entry type: keyEntry
Certificate chain length: 1
Certificate[1]:
Owner: CN=www.test.org, OU=Test, O="Test, Inc.", L=Seattle, ST=WA, C=US
Issuer: CN=www.test.org, OU=Test, O="Test, Inc.", L=Seattle, ST=WA, C=US
Serial number: 456c8054
Valid from: Tue Nov 28 10:30:44 PST 2006 until: Mon Feb 26 10:30:44 PST 2007
Certificate fingerprints:
 MD5:  E7:D4:DA:25:0F:FD:FD:55:E7:DF:B2:21:F4:82:09:B2
 SHA1: 2E:FE:63:F6:1C:0F:20:FF:96:18:20:D9:82:6D:A1:70:2A:69:C6:D2


Furthermore, specifying keyAlias="CamelCase" in the SSL connector config (TC
5.0.28 on WinXP) does not cause an error for me - the connector works fine with
no complaint.  I've also tested 5.0.28 and 5.5.20 on Linux (with both JDK1.4.2
and JDK1.5) with no observed problems.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.20

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40668





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 11:19 ---
Created an attachment (id=19186)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19186&action=view)
Patch for missing libraries from Tomcat 5.5.20 distibution

Until the next version is released, you can unzip the attached class files
(from the Tomcat 5.5.17 release) to your TOMCAT_HOME\common\classes\ directory.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41059] New: - WebAppClassLoader clearReferences code break running threads

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41059

   Summary: WebAppClassLoader clearReferences code break running
threads
   Product: Tomcat 5
   Version: 5.5.20
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P3
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


When the WebAppClassLoader stops it manually sets all static and final 
variables to null in the clearReferences method.  This results in NPEs for any 
thread that was not stopped and not expecting its final or static variables to 
be null.  This is particularly a problem with hot deploys since the unload 
fails and terminating the deploy.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Mladen Turk]

Henri Gomez wrote:

I remember the cold days of the 'Tab brigade' :)



Right.
Anyhow, the point of my post was 'minimal', and
removing the trailing spaces.

It seems that the trailing spaces are very important,
so fine with me.

Cheers,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 12:25 ---
I am using Java 1.6 b103. My keystore file was generated programmatically, not
using keystore.exe. I'll attach it for you to try on your end.

My configuration reads:

keystoreFile="classServer.keystore" keystorePass="classServer"
keystoreType="JCEKS" keyAlias="classserver"

if you then modify keyAlias to "classServer" it gives the aforementioned 
exception.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 12:26 ---
Created an attachment (id=19187)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19187&action=view)
The keystore file


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Rainer Jung]

>From a very personal view I'm tempted to share Mladens dislike of
trailing spaces. If I try to express, why I don't like them, then it all
comes back to diffs.

Trailing spaces increase the potential of diff lines with no functional
differences. Nevertheless one wastes time to check very carefully, if
there's really no functional change in them.

And why do trailing spaces produce diff deltas? I think most of the time
because of copy and paste. Copy and paste is able to remove trailing
spaces, when you do it from a screen output of code. So you attempt to
clone code (I know, we never want to do that) and the result looks the
same, but in fact it will produce diff lines because of whitespace
differences.

Omitting all whitespace differences from the subversion diff mails is
something I really find dangerous, because there are cases, where you
need to see whitespace changes.

Removing all trailing whitespace from Java source files might be doable
by a script, although I didn't think about that deeply enough.

All in all I would be

+0 for a policy of not introducing new trailing whitespace (as long as
we don't shoot at each other if it happens nevertheless, but we agree,
that we should avoid it)

and

no idea about the best way of cleaning up existing code (once per script
or during the usual editing process over time).

Regards,

Rainer

Mladen Turk schrieb:
> Henri Gomez wrote:
>> I remember the cold days of the 'Tab brigade' :)
>>
> 
> Right.
> Anyhow, the point of my post was 'minimal', and
> removing the trailing spaces.
> 
> It seems that the trailing spaces are very important,
> so fine with me.
> 
> Cheers,
> Mladen.
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Darryl Miles]

Just in case people didn't know,
diff does have a number of options
to modify white space behavior,
such that you can check in a massive
whitespace cleanup patch but still
view a clean diff which ignores
blank lines, crlf/lf and
leading/trailing whitespace, etc...

So really its not that bad. With
the right options.



AS FOR STYLE, I THINK ALL UNNECESSARY
WHITESPACE SHOULD BE BANNED AND TABS
MADE ILLEGAL, THEY JUST INCREASE
FILE SIZE TOO MUCH AND MY COMMODORE
64 JUST CAN'T HANDLE SOME OF THOSE
LARGE SOURCE FILES ALL IN ONE GO.

PLEASE WRITE YOUR JAVA LIKE THIS:

public class Foobar{private String
NAME;public void Foobar(){}public
String getName(){return this.NAME;
public void setName(String NAME){
this.NAME=NAME;}


Darryl

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [TC6] Minimum coding style

[Kris Nuttycombe]

Darryl Miles wrote:

Just in case people didn't know,
diff does have a number of options
to modify white space behavior,
such that you can check in a massive
whitespace cleanup patch but still
view a clean diff which ignores
blank lines, crlf/lf and
leading/trailing whitespace, etc...

So really its not that bad. With
the right options. 


Agreed; "diff -u -b" is your friend. That being said, I don't think that 
the version of diff used by current SVN clients supports the -b switch, 
so it could still be a problem in terms of source control.


Kris

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41057] - Tomcat leaks memory on every request

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41057





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 15:46 ---
You seem to be in a hurry. You did not seem to notice it, but the cache is
bounded and also configurable. Using the Servlet API provided methods for
parameters handling with very large POSTs is inefficient and will lead to large
amounts of garbage collections.

If you'd like me to look into adjusting the defaults or some of the behavior of
the cache, you should send me an explanation I can understand (unlike these
scripts).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41059] - WebAppClassLoader clearReferences code break running threads

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41059


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 15:48 ---
You are not supposed to have any threads associated with this classloader at
this point.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41059] - WebAppClassLoader clearReferences code break running threads

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41059





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 15:53 ---
Note that if you want a "fix", you can offer a patch disabling this code (with a
system property or some other mechanism like that).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41057] - Tomcat leaks memory on every request

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41057





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 16:06 ---
Ok, I understand the script I think. The first one generate a:
"firstname=xxx[long]" line. The second makes a number of requests
while appending a number to it. Solution: the string cache is useful, but
there's little point caching large strings.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r480302 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java

[remm]

Author: remm
Date: Tue Nov 28 16:30:07 2006
New Revision: 480302

URL: http://svn.apache.org/viewvc?view=rev&rev=480302
Log:
- 41057: Caching large strings uses too much memory and is a bit pointless, so 
add an upper bound to the String length.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java?view=diff&rev=480302&r1=480301&r2=480302
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf/StringCache.java Tue 
Nov 28 16:30:07 2006
@@ -56,7 +56,11 @@
 
Integer.parseInt(System.getProperty("tomcat.util.buf.StringCache.cacheSize", 
"200"));
 
 
-/**
+protected static int maxStringSize = 
+
Integer.parseInt(System.getProperty("tomcat.util.buf.StringCache.maxStringSize",
 "128"));
+
+
+   /**
  * Statistics hash map for byte chunk.
  */
 protected static HashMap bcStats = new HashMap(cacheSize);
@@ -210,7 +214,7 @@
 // still training
 if (bcCache == null) {
 String value = bc.toStringInternal();
-if (byteEnabled) {
+if (byteEnabled && (value.length() < maxStringSize)) {
 // If training, everything is synced
 synchronized (bcStats) {
 // If the cache has been generated on a previous invocation
@@ -324,7 +328,7 @@
 // still training
 if (ccCache == null) {
 String value = cc.toStringInternal();
-if (charEnabled) {
+if (charEnabled && (value.length() < maxStringSize)) {
 // If training, everything is synced
 synchronized (ccStats) {
 // If the cache has been generated on a previous invocation



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41034] - Classloader leak caused by request recycle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41034





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 18:20 ---
BTW, if you would like to clear those references on every request (to ensure
everything gets garbage collected as quickly as possible), you should be able to
clear the mapped filters like this:

Index: ApplicationFilterChain.java
===
--- ApplicationFilterChain.java (revision 480297)
+++ ApplicationFilterChain.java (working copy)
@@ -529,6 +529,9 @@
  */
 void release() {
 
+for (int i = 0; i < n; i++) {
+filters[i] = null;
+}
 n = 0;
 pos = 0;
 servlet = null;


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40809] - Tomcat 5.5.20 fails to load ServletContextListener in tld!

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40809





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 18:26 ---
There are also no apparently relevant changes between 5.5.17 and 5.5.20. All the
processing is done in code in the o.a.catalina.startup.TldConfig class, and it
hasn't changed since 5.5.17. You can trace things in there if you need to.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r480346 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java

[remm]

Author: remm
Date: Tue Nov 28 18:39:45 2006
New Revision: 480346

URL: http://svn.apache.org/viewvc?view=rev&rev=480346
Log:
- Update JAR list for no-tld-scan.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java?view=diff&rev=480346&r1=480345&r2=480346
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java Tue 
Nov 28 18:39:45 2006
@@ -77,35 +77,29 @@
  */
 static {
 noTldJars = new HashSet();
+// Bootstrap JARs
+noTldJars.add("bootstrap.jar");
+noTldJars.add("commons-daemon.jar");
+noTldJars.add("tomcat-juli.jar");
+// Main JARs
+noTldJars.add("annotations-api.jar");
 noTldJars.add("catalina.jar");
 noTldJars.add("catalina-ant.jar");
-noTldJars.add("catalina-cluster.jar");
-noTldJars.add("catalina-optional.jar");
-noTldJars.add("commons-el.jar");
-noTldJars.add("commons-logging-api.jar");
-noTldJars.add("commons-modeler.jar");
-noTldJars.add("jasper-compiler.jar");
-noTldJars.add("jasper-compiler-jdt.jar");
-noTldJars.add("jasper-runtime.jar");
+noTldJars.add("catalina-ha.jar");
+noTldJars.add("catalina-tribes.jar");
+noTldJars.add("el-api.jar");
+noTldJars.add("jasper.jar");
+noTldJars.add("jasper-el.jar");
+noTldJars.add("jasper-jdt.jar");
 noTldJars.add("jsp-api.jar");
-noTldJars.add("naming-resources.jar");
-noTldJars.add("naming-factory.jar");
-noTldJars.add("naming-factory-dbcp.jar");
 noTldJars.add("servlet-api.jar");
-noTldJars.add("servlets-cgi.jar");
-noTldJars.add("servlets-default.jar");
-noTldJars.add("servlets-invoker.jar");
-noTldJars.add("servlets-ssi.jar");
-noTldJars.add("servlets-webdav.jar");
-noTldJars.add("tomcat-ajp.jar");
 noTldJars.add("tomcat-coyote.jar");
-noTldJars.add("tomcat-http.jar");
-noTldJars.add("tomcat-util.jar");
+noTldJars.add("tomcat-dbcp.jar");
 // i18n JARs
-noTldJars.add("catalina-i18n-en.jar");
-noTldJars.add("catalina-i18n-es.jar");
-noTldJars.add("catalina-i18n-fr.jar");
-noTldJars.add("catalina-i18n-ja.jar");
+noTldJars.add("tomcat-i18n-en.jar");
+noTldJars.add("tomcat-i18n-es.jar");
+noTldJars.add("tomcat-i18n-fr.jar");
+noTldJars.add("tomcat-i18n-ja.jar");
 // Misc JARs not included with Tomcat
 noTldJars.add("ant.jar");
 noTldJars.add("commons-dbcp.jar");
@@ -125,6 +119,8 @@
 noTldJars.add("ldapsec.jar");
 noTldJars.add("localedata.jar");
 noTldJars.add("dnsns.jar");
+noTldJars.add("tools.jar");
+noTldJars.add("sunpkcs11.jar");
 }
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 22:00 ---
OK, so the important part you left out of the original bug report was the
keystore type.  Using a JCEKS keystore I did replicate the issue.  For some
reason still unknown to me JSSE isn't tolerant of mismatched case in the alias
name when using a JCEKS keystore (with plain old JKS seems it doesn't give a
whit about case).  The aliases in a JCEKS keystore are downcased internally just
like in a JKS keystore, which is why changing your keyAlias to all lower case
makes the problem go away (try a 'keygen -list -v' on your keystore and you'll
see the alias name all lower case).

I'm attaching patches for 5.0.x and 5.5.x that downcase the incoming alias name
in the JSSEKeyManager constructor.  This eliminates the issue in my testing.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 22:01 ---
ack...I meant 'keytool -list -v', not 'keygen -list -v'

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 22:03 ---
Created an attachment (id=19191)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19191&action=view)
Patch to tc50x to fix case-sensitivity issues with JCEKS keystore aliases


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 22:03 ---
Created an attachment (id=19192)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19192&action=view)
Patch to tc55x to fix case-sensitivity issues with JCEKS keystore aliases


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 22:03 ---
Good catch! Thanks :)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

adding communication between mod_jk and servlet code

[Chris Lamprecht]

Hi all,
I previously submitted the lb 'busyness' patch for mod_jk, and it has worked
well for us.

Now we need some additional functionality from mod_jk and I'd like to get
feedback here first before I start patching.  I'd prefer to implement
something that is generally useful to others, and submit the patch, so it
becomes part of the mod_jk codebase.

First, the problem.  Currently there isn't any direct way for a servlet to
tell mod_jk that it should be marked as being in 'Error' state (as being
down).  We have a backend HTTP service that requires high availability.  If
the servlet detects that something is wrong, it should "take itself out" of
the mod_jk load balancer, at least temporarily.  There are two ways I can
think of to accomplish this right now.  The first, which I've done, is set
the reply_timeout to a fairly low value, like 4000ms, and then make the
servlet intentionally sleep for 5000ms to cause it to go into Error state.
This works, but having the reply_timeout so low is a risk -- if the backend
servers are slow for some reason (copying large files, etc), they can all be
marked as down -- oops.  The second method, which I have not tried, is to
have the servlet do a GET request to the mod_jk JkStatus page, to take
itself out of rotation.  While it may work, I just don't have good feelings
about this method.  If anyone has  other suggestions on ways for a servlet
to force itself to be marked as in 'Error' state, please reply.

So, I looked through mod_jk code hoping that I could have the servlet throw
an HTTP 50x error that mod_jk would interpret as "down", but no such luck.
There has been talk before about writing a "meta" communication layer
between servlets and mod_jk.  This could open up the doors to some cool
things:  Servlets could provide JK with load information, average response
times, available webapp contexts, etc.  See this thread:
http://mail-archives.apache.org/mod_mbox/httpd-dev/200606.mbox/[EMAIL PROTECTED]

For my current purposes, I just need the servlet to tell mod_jk "even though
I'm available, mark me as in Error state!".   How should we do this?  Using
a "hidden" HTTP response header might work for communicating general
strings, or returning certain "reserved" HTTP responses (HTTP 599 = error,
etc) -- these are two options that come to mind.  I'm willing to implement
and test the mods, including under heavy load.


Thanks,
Chris

DO NOT REPLY [Bug 41051] - Keystore alias shouldn't be case sensitive

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41051





--- Additional Comments From [EMAIL PROTECTED]  2006-11-28 23:48 ---
It looks like then that this is a work-around for a Sun JDK bug.  I have no 
objection to Chris' patch, other than that (since a KeyStore alias *should* be 
case-insensitive according to the javadocs).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]