DO NOT REPLY [Bug 40606] - Excessive CPU usage

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40606





--- Additional Comments From [EMAIL PROTECTED]  2006-09-26 07:24 ---
Created an attachment (id=18915)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18915&action=view)
apache configuration


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40606] New: - Excessive CPU usage

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40606

   Summary: Excessive CPU usage
   Product: Tomcat 5
   Version: 5.5.17
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: major
  Priority: P2
 Component: Connector:AJP
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Install tomcat5.5 and APR binaries, apache httpd 2.0 or 2.2 add appropriate 
mod_jk. 

Add following lines to httpd.conf:
LoadModule jk_module modules/mod_jk-apache-2.2.3.so
JkWorkersFile   conf/workers.properties
JkLogFile   logs/mod_jk.log
JkLogLevel  error
JkLogStampFormat"[%a %b %d %H:%M:%S %Y] "
JkOptions   +ForwardKeySize +ForwardURICompat -ForwardDirectories
JkRequestLogFormat  "%w %V %T"
JkShmFile   logs/jk.shm
JkMount /*  jvm1

Create following workers.properties in apache conf directory
worker.list=jvm1
worker.jvm1.type=ajp13
worker.jvm1.host=localhost
worker.jvm1.port=8009

In server.conf modify default engine - add jvmRoute="jvm1" eg.


Start apache, start tomcat. Open browser, enter: http://localhost, then select 
any tomcat context for example jsp-examples. Now you can see on task manager 
constant 100% CPU usage generated by Tomcat's java. This happens for java 
1.5.0_08 and java 1.4.2_12 both, and for Internet Explorer and Mozilla.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40606] - Excessive CPU usage

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40606





--- Additional Comments From [EMAIL PROTECTED]  2006-09-26 07:23 ---
Created an attachment (id=18913)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18913&action=view)
tomcat server configuration


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40606] - Excessive CPU usage

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40606





--- Additional Comments From [EMAIL PROTECTED]  2006-09-26 07:24 ---
Created an attachment (id=18914)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18914&action=view)
apache 2.2.3 configuration


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39711] - WebappLoader checkInterval documentation

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39711


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2006-09-26 09:33 ---
The backgroundProcessorDelay attribute is located in ContainerBase, so 
the attribute should be removed from the loader document (WebappLoader 
does not have such attribute). 
In addition, the "Host Container" link that in your commited code is broken.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40606] - Excessive CPU usage

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40606





--- Additional Comments From [EMAIL PROTECTED]  2006-09-26 10:28 ---
"you can see": of course, I cannot see it. You could try providing thread dumps,
for starters.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[6.0] Updates

2006-09-26 Thread Remy Maucherat

Hi,

I think the new APIs are more or less finalized (clustering and comet), 
and I'm quite happy the way it turned out so far. If there's an 
agreement on this, then it would be a good idea to proceed with 
bugfixing and (more importantly) documentation, and then release a first 
build.


Some leftover topics include porting (or not) the admin webapp and the 
companion storeconfig. At the moment, it seems it won't be done for the 
first build.


Comments ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r450040 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy: ContextService.java NamingResources.java

2006-09-26 Thread remm
Author: remm
Date: Tue Sep 26 06:18:43 2006
New Revision: 450040

URL: http://svn.apache.org/viewvc?view=rev&rev=450040
Log:
- Use the interface rather than the type (which is apparently null here).

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/ContextService.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/NamingResources.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/ContextService.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/ContextService.java?view=diff&rev=450040&r1=450039&r2=450040
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/ContextService.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/ContextService.java 
Tue Sep 26 06:18:43 2006
@@ -203,6 +203,10 @@
 sb.append(", displayname=");
 sb.append(displayname);
 }
+if (serviceinterface != null) {
+sb.append(", serviceinterface=");
+sb.append(serviceinterface);
+}
 if (icon != null) {
 sb.append(", icon=");
 sb.append(icon);

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/NamingResources.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/NamingResources.java?view=diff&rev=450040&r1=450039&r2=450040
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/NamingResources.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/NamingResources.java 
Tue Sep 26 06:18:43 2006
@@ -336,11 +336,11 @@
  * @param service New web service reference
  */
 public void addService(ContextService service) {
-
+
 if (entries.containsKey(service.getName())) {
 return;
 } else {
-entries.put(service.getName(), service.getType());
+entries.put(service.getName(), service.getServiceinterface());
 }
 
 synchronized (services) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Periodic events for servlets

2006-09-26 Thread Henri Gomez

Good idea, let save threads for AJP/HTTP connections :)

Till we could disable this feature (many use precompiled JSP), it
seems reasonable.

2006/9/26, Remy Maucherat <[EMAIL PROTECTED]>:

Hi,

In Jasper, there's a feature allowing having background checking of JSP
modifications. I think this is good to have in production, as on access
checks is quite expensive, however, I do not like its implementation,
which is using a thread for each webapp.

Instead, I am considering an interface (in the org.apache package, like
the annotation processing one) that could be implemented by servlets
(here, the JasperServlet), and which would be called by
StandardWrapper.backgroundProcess. Pretty trivial stuff overall.

Comments ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Periodic events for servlets

2006-09-26 Thread Remy Maucherat

Hi,

In Jasper, there's a feature allowing having background checking of JSP 
modifications. I think this is good to have in production, as on access 
checks is quite expensive, however, I do not like its implementation, 
which is using a thread for each webapp.


Instead, I am considering an interface (in the org.apache package, like 
the annotation processing one) that could be implemented by servlets 
(here, the JasperServlet), and which would be called by 
StandardWrapper.backgroundProcess. Pretty trivial stuff overall.


Comments ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Periodic events for servlets

2006-09-26 Thread Remy Maucherat

Henri Gomez wrote:

Good idea, let save threads for AJP/HTTP connections :)

Till we could disable this feature (many use precompiled JSP), it
seems reasonable.


Obviously, there has been a lot of problems with on access 
(re)compilation, due to its inherent complexity and heavy resource 
usage. While precompilation is better in real production environments, 
it doesn't hurt improving dynamic compilation if possible.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [6.0] Updates

2006-09-26 Thread Peter Rossbach

Hmm,

I thing we must add the current cluster 5.5 implementation also for  
backward compatibilty. But first I want do some changes at tomcat 5.5  
that
user can easier switch between both implementations. But I have  
currently a lot of work and can to this not before mid of next month.


Regards
Peter

Am 26.09.2006 um 16:00 schrieb Remy Maucherat:


Hi,

I think the new APIs are more or less finalized (clustering and  
comet), and I'm quite happy the way it turned out so far. If  
there's an agreement on this, then it would be a good idea to  
proceed with bugfixing and (more importantly) documentation, and  
then release a first build.


Some leftover topics include porting (or not) the admin webapp and  
the companion storeconfig. At the moment, it seems it won't be done  
for the first build.


Comments ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [6.0] Updates

2006-09-26 Thread Yoav Shapira

Hi,
(Gradually coming back from vacation, still catching up on stuff)

On 9/26/06, Remy Maucherat <[EMAIL PROTECTED]> wrote:

Hi,

I think the new APIs are more or less finalized (clustering and comet),
and I'm quite happy the way it turned out so far. If there's an
agreement on this, then it would be a good idea to proceed with
bugfixing and (more importantly) documentation, and then release a first
build.


Overall, yes, +1.


Some leftover topics include porting (or not) the admin webapp and the
companion storeconfig. At the moment, it seems it won't be done for the
first build.


It'd be nice to junk the admin webapp in favor of a more standard JMX
console.  Maybe the number of operations we don't already support via
JMX is smaller than the work to port the admin webapp?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [6.0] Updates

2006-09-26 Thread Filip Hanik - Dev Lists
I'd -1 that, simply because of the overhead of keeping two branches 
alive, there is plenty of new stuff in 6 that needs the attention as has 
been pointed out.


Filip

Peter Rossbach wrote:

Hmm,

I thing we must add the current cluster 5.5 implementation also for 
backward compatibilty. But first I want do some changes at tomcat 5.5 
that
user can easier switch between both implementations. But I have 
currently a lot of work and can to this not before mid of next month.


Regards
Peter

Am 26.09.2006 um 16:00 schrieb Remy Maucherat:


Hi,

I think the new APIs are more or less finalized (clustering and 
comet), and I'm quite happy the way it turned out so far. If there's 
an agreement on this, then it would be a good idea to proceed with 
bugfixing and (more importantly) documentation, and then release a 
first build.


Some leftover topics include porting (or not) the admin webapp and 
the companion storeconfig. At the moment, it seems it won't be done 
for the first build.


Comments ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.1.405 / Virus Database: 268.12.9/456 - Release Date: 9/25/2006





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39120] - Create semantics for "path" attribute in embedded context.xml

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39120





--- Additional Comments From [EMAIL PROTECTED]  2006-09-26 17:56 ---
I'm giving this bug a bump to see if anyone could possibly take a look at it. As
Carsten stated, this has broken the upgrade path for webapps from Tomcat 5.0 to
5.5 and is quite inconvenient. At very least, could one of the Tomcat developers
possibly comment upon it?

Kris

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [6.0] Updates

2006-09-26 Thread Remy Maucherat

Filip Hanik - Dev Lists wrote:
I'd -1 that, simply because of the overhead of keeping two branches 
alive, there is plenty of new stuff in 6 that needs the attention as has 
been pointed out.


About the same: there should be only one clustering implementation. I 
did leave the debate open for a very long time on which implementation, 
though ;)


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r450262 - /tomcat/tc6.0.x/trunk/dist.xml

2006-09-26 Thread remm
Author: remm
Date: Tue Sep 26 17:21:36 2006
New Revision: 450262

URL: http://svn.apache.org/viewvc?view=rev&rev=450262
Log:
- No admin for now.

Modified:
tomcat/tc6.0.x/trunk/dist.xml

Modified: tomcat/tc6.0.x/trunk/dist.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/dist.xml?view=diff&rev=450262&r1=450261&r2=450262
==
--- tomcat/tc6.0.x/trunk/dist.xml (original)
+++ tomcat/tc6.0.x/trunk/dist.xml Tue Sep 26 17:21:36 2006
@@ -495,8 +495,8 @@
 
 
   
-  
+  
 
 
 

svn commit: r450274 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml

2006-09-26 Thread markt
Author: markt
Date: Tue Sep 26 18:19:13 2006
New Revision: 450274

URL: http://svn.apache.org/viewvc?view=rev&rev=450274
Log:
Fixed typos.

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=450274&r1=450273&r2=450274
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Tue Sep 26 18:19:13 2006
@@ -36,7 +36,7 @@
   
 40518: Use correct message when a RuntimeException is
 thrown from the requestInitialized or requestDestroyed method of
-a listener that inplements ServletRequestListener. (markt)
+a listener that implements ServletRequestListener. (markt)
   
 

@@ -65,7 +65,7 @@
   
 
   
-34399: Disable undeploy for applciations that have not
+34399: Disable undeploy for applications that have not
 been deployed such as those defined in server.xml (markt)
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40578] - There is a typing error in the change log

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40578


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-09-27 01:15 ---
Fixed. will be in 5.5.21 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34769] - ArrayIndexOutOfBoundsException occurs when reading more than 8192 bytes from the BufferedReader supplied by HttpServletRequest.getReader()

2006-09-26 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34769


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-09-27 01:56 ---
Reading the OP's comments, the issue is, AFAICT, the same as described in bug 
38346.

Having tested the latest code extensively I can recreate the conditions
described in this bug but Tomcat always behaves correctly. I am taking this as
sufficient evidence that the root cause of this issue is the same as that in 
38346.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r450288 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/InputBuffer.java

2006-09-26 Thread markt
Author: markt
Date: Tue Sep 26 19:03:58 2006
New Revision: 450288

URL: http://svn.apache.org/viewvc?view=rev&rev=450288
Log:
Code clean-up. No functional change.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/InputBuffer.java

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/InputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/InputBuffer.java?view=diff&rev=450288&r1=450287&r2=450288
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/InputBuffer.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/InputBuffer.java
 Tue Sep 26 19:03:58 2006
@@ -79,30 +79,12 @@
 
 
 /**
- * Number of bytes read.
- */
-private int bytesRead = 0;
-
-
-/**
- * Number of chars read.
- */
-private int charsRead = 0;
-
-
-/**
  * Flag which indicates if the input buffer is closed.
  */
 private boolean closed = false;
 
 
 /**
- * Byte chunk used to input bytes.
- */
-private ByteChunk inputChunk = new ByteChunk();
-
-
-/**
  * Encoding to use.
  */
 private String enc;
@@ -186,7 +168,7 @@
  * @param coyoteRequest Associated Coyote request
  */
 public void setRequest(Request coyoteRequest) {
-   this.coyoteRequest = coyoteRequest;
+this.coyoteRequest = coyoteRequest;
 }
 
 
@@ -209,8 +191,6 @@
 public void recycle() {
 
 state = INITIAL_STATE;
-bytesRead = 0;
-charsRead = 0;
 
 // If usage of mark made the buffer too big, reallocate it
 if (cb.getChars().length > size) {
@@ -272,7 +252,7 @@
  * @throws IOException An underlying IOException occurred
  */
 public int realReadBytes(byte cbuf[], int off, int len)
-   throws IOException {
+throws IOException {
 
 if (closed)
 return -1;
@@ -340,7 +320,7 @@
 
 int limit = bb.getLength()+cb.getStart();
 if( cb.getLimit() < limit ) 
-   cb.setLimit(limit);
+cb.setLimit(limit);
 conv.convert(bb, cb);
 bb.setOffset(bb.getEnd());
 state = CHAR_STATE;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [6.0] Updates

2006-09-26 Thread Peter Rossbach

Hi Filip,

I thing many people use the current cluster implementation. For those  
people I want spend my time to sync two branches :-)
Some people ask me to start experiments with new Servlet and JSP  
API's or the new connector implementation but with
the old cluster API. Let the user the choice,like APR or Java HTTP  
Connector.


Peter



Am 26.09.2006 um 18:15 schrieb Filip Hanik - Dev Lists:

I'd -1 that, simply because of the overhead of keeping two branches  
alive, there is plenty of new stuff in 6 that needs the attention  
as has been pointed out.


Filip

Peter Rossbach wrote:

Hmm,

I thing we must add the current cluster 5.5 implementation also  
for backward compatibilty. But first I want do some changes at  
tomcat 5.5 that
user can easier switch between both implementations. But I have  
currently a lot of work and can to this not before mid of next month.


Regards
Peter

Am 26.09.2006 um 16:00 schrieb Remy Maucherat:


Hi,

I think the new APIs are more or less finalized (clustering and  
comet), and I'm quite happy the way it turned out so far. If  
there's an agreement on this, then it would be a good idea to  
proceed with bugfixing and (more importantly) documentation, and  
then release a first build.


Some leftover topics include porting (or not) the admin webapp  
and the companion storeconfig. At the moment, it seems it won't  
be done for the first build.


Comments ?

Rémy

 
-

To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.1.405 / Virus Database: 268.12.9/456 - Release Date:  
9/25/2006






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]