DO NOT REPLY [Bug 40111] - HttpSession's getLastAccessedTime() does not always return previous request's access time

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40111





--- Additional Comments From [EMAIL PROTECTED]  2006-09-05 10:02 ---
Yes, unfortunately, this is not what we will implement. There will be (some day)
a setting to enable this behavior, though.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40111] - HttpSession's getLastAccessedTime() does not always return previous request's access time

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40111





--- Additional Comments From [EMAIL PROTECTED]  2006-09-05 10:23 ---
(In reply to comment #2)
Apart from that you probably have more important bugs and functions to work on,
why not?
Maybe I am just misinterpreting your comment, but are you planning to implement
some other similar functionality?
I read the commit log where I think you took this behaviour out, but I did not
understand it. Why is it improved now? What was wrong with the old behaviour?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38713] - java.io.IOException: tmpFile.renameTo(classFile) failed when compiling new JSP (upon redeploy)

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38713


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|minor   |major




--- Additional Comments From [EMAIL PROTECTED]  2006-09-05 10:54 ---
I have the same problem using tomcat bundled with JBoss 4.0.4. fork=true did not
solve the problem for me.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r440328 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina: Globals.java core/StandardHostValve.java session/StandardSession.java

2006-09-05 Thread remm
Author: remm
Date: Tue Sep  5 04:55:59 2006
New Revision: 440328

URL: http://svn.apache.org/viewvc?view=rev&rev=440328
Log:
- Add a master flag for compliance issues, for ease of use.
- Add back session access on all requests.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/Globals.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/Globals.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/Globals.java?view=diff&rev=440328&r1=440327&r2=440328
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/Globals.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/Globals.java Tue Sep  5 
04:55:59 2006
@@ -321,4 +321,12 @@
 "javax.servlet.context.tempdir";
 
 
+/**
+ * The master flag which controls strict servlet specification 
+ * compliance.
+ */
+public static final boolean STRICT_SERVLET_COMPLIANCE =
+
Boolean.valueOf(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
 "false")).booleanValue();
+
+
 }

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java?view=diff&rev=440328&r1=440327&r2=440328
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java 
Tue Sep  5 04:55:59 2006
@@ -125,6 +125,12 @@
 // Ask this Context to process this request
 context.getPipeline().getFirst().invoke(request, response);
 
+// Access a session (if present) to update last accessed time, based 
on a
+// strict interpretation of the specification
+if (Globals.STRICT_SERVLET_COMPLIANCE) {
+request.getSession(false);
+}
+
 // Error page processing
 response.setSuspended(false);
 

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java?view=diff&rev=440328&r1=440327&r2=440328
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/session/StandardSession.java 
Tue Sep  5 04:55:59 2006
@@ -84,7 +84,8 @@
 
 
 protected static final boolean ACTIVITY_CHECK = 
-
Boolean.valueOf(System.getProperty("org.apache.catalina.session.StandardSession.ACTIVITY_CHECK",
 "false")).booleanValue();
+Globals.STRICT_SERVLET_COMPLIANCE
+|| 
Boolean.valueOf(System.getProperty("org.apache.catalina.session.StandardSession.ACTIVITY_CHECK",
 "false")).booleanValue();
 
 
 // --- Constructors



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40111] - HttpSession's getLastAccessedTime() does not always return previous request's access time

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40111





--- Additional Comments From [EMAIL PROTECTED]  2006-09-05 12:03 ---
It is a bit worrying you need to ask: accessing the session is not a trivial
operation (although it's not the end of the world either), so for requests which
would otherwise not need the session, it's best not to do it. It's also obvious
this stuff is useless: in almost all sites, trivial requests (like static files,
since that's what you mention as the super useful use case) are going to either
be served or cached by a front end server. So your little session activity
tricks are not going to work, and you should instead use a sensible session 
timeout.

You have a wide variety of easy workarounds (a valve, a filter, etc).


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39090] - Memory Leak: Tomcat files keep references to classes loaded by WebappClassLoader

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39090





--- Additional Comments From [EMAIL PROTECTED]  2006-09-05 12:58 ---
I had exactly the same problem as described in bug #39090 when starting Tomcat
5.5.17:

java.lang.NullPointerException
   at org.apache.log4j.Category.isEnabledFor(Category.java:757)
   at
org.apache.commons.logging.impl.Log4JLogger.isTraceEnabled(Log4JLogger.java:327)

After replacing commons-logging.jar (1.1) with an older version (1.0.4), the
problem was gone. Before that I replaced log4j-1.2.13 with 1.2.8, but I still
had the problem.

This problem, in particular, does not seem to be related to Tomcat.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r440368 - in /tomcat/sandbox/tomcat-lite: java/org/apache/tomcat/lite/ java/org/apache/tomcat/servlets/jsp/ webapps/ROOT/WEB-INF/

2006-09-05 Thread costin
Author: costin
Date: Tue Sep  5 08:14:12 2006
New Revision: 440368

URL: http://svn.apache.org/viewvc?view=rev&rev=440368
Log:
Few more fixes

Modified:

tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletConfigImpl.java

tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletContextImpl.java

tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/servlets/jsp/JspCompileServlet.java

tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/servlets/jsp/JspProxyServlet.java
tomcat/sandbox/tomcat-lite/webapps/ROOT/WEB-INF/web.xml

Modified: 
tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletConfigImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletConfigImpl.java?view=diff&rev=440368&r1=440367&r2=440368
==
--- 
tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletConfigImpl.java 
(original)
+++ 
tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletConfigImpl.java 
Tue Sep  5 08:14:12 2006
@@ -23,6 +23,7 @@
 import java.lang.reflect.Method;
 import java.util.Enumeration;
 import java.util.HashSet;
+import java.util.Map;
 import java.util.Stack;
 
 import javax.servlet.Servlet;
@@ -57,10 +58,16 @@
 public static final String JSP_SERVLET_CLASS =
 "org.apache.tomcat.servlets.jsp.JspProxyServlet";
 
+public static final String JSP_SERVLET_NAME = "jsp";
+
+public static final String JSP_SERVLET_COMPILER_CLASS =
+"org.apache.tomcat.servlets.jsp.JspCompileServlet";
+
+public static final String JSP_SERVLET_COMPILER_NAME = "jspCompiler";
+
 public static final String SINGLE_THREADED_PROXY =
 "org.apache.tomcat.servlets.jsp.SingleThreadedProxyServlet";
 
-public static final String JSP_SERVLET_NAME = "jsp";
 
 ServletData data;
 
@@ -110,6 +117,14 @@
 ctx.facade.notifyAdd(this);
 }
 
+public ServletConfigImpl(ServletContextImpl ctx, String name, 
+ String classname) {
+data = new ServletData();
+data.servletName = name;
+data.servletClass = classname;
+this.ctx = ctx;
+ctx.facade.notifyAdd(this);
+}
 
 /**
  * Return the available date/time for this servlet, in milliseconds since

Modified: 
tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletContextImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletContextImpl.java?view=diff&rev=440368&r1=440367&r2=440368
==
--- 
tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletContextImpl.java 
(original)
+++ 
tomcat/sandbox/tomcat-lite/java/org/apache/tomcat/lite/ServletContextImpl.java 
Tue Sep  5 08:14:12 2006
@@ -36,6 +36,7 @@
 import java.util.Properties;
 import java.util.Set;
 import java.util.Map.Entry;
+import java.util.concurrent.ConcurrentHashMap;
 
 import javax.servlet.Filter;
 import javax.servlet.RequestDispatcher;
@@ -97,6 +98,8 @@
 
 transient Log log;
 
+public static String CONTAINER_PREFIX = "__x_";
+
 /** 
  * Prefix to use in servlet names that are used internally.
  */
@@ -125,7 +128,7 @@
 /**
  * The context attributes for this context.
  */
-private transient HashMap attributes = new HashMap();
+private transient Map attributes = new ConcurrentHashMap();
 
 /**
  * List of read only attributes for this context.
@@ -291,11 +294,48 @@
  * @param name Name of the context attribute to return
  */
 public Object getAttribute(String name) {
+if (name.startsWith(CONTAINER_PREFIX)) {
+Object o = getContainerAttribute(name);
+if (o != null) return o;
+}
+return (attributes.get(name));
+}
 
-synchronized (attributes) {
-return (attributes.get(name));
+/**
+ * Tomcat-lite core has the goal to provide maximum power to webapps, by
+ * exposing internals and allowing apps to take container-specific 
+ * optimizations. However it tries to avoid the need for a servlet to
+ * depend on tomcat-lite, so servlets can be generic, but still check 
+ * and use special features if tomcat-lite is detected.
+ * 
+ * Example use of attributes ( and the tomcat-lite independent way ):
+ *  - CONTAINER_PREFIX + servlet_ + servletname -> returns a servlet, 
+ *  similar with the old deprecated getServlet() method. Equivalent 
+ *  mechanism: have the serlvet load-on-startup and set the attribute with
+ *  'this'. Benefit: more power to the app on controlling the lifecycle,
+ *  more flexiblity, use servlets as java beans, with real methods insted
+ *  of just service() - a mini-component model based on servlets. 
+ *  
+ * 
+ * @param name
+ */
+private Object getContainerAttribute(String name) {
+  

Re: parameters in URL path segments

2006-09-05 Thread James Berry

Bill and others,

I think we fell into agreement regarding how this should work.

What does it take to go about getting this fixed in tomcat? A patch?

	- Is there sufficient agreement from others that the behavior I  
described is desired?


	- Can anybody point me at where I might go about changing this  
behavior, and whether there are any pitfalls I might look out for?


	- Can somebody comment on how a change to this behavior might  
interact with the recent change (http://marc.theaimsgroup.com/? 
l=tomcat-dev&m=115344110306194&w=2) or affect the motivation for that  
change?


Thanks!

James


On Aug 23, 2006, at 4:05 PM, James Berry wrote:


Hi Bill,

On Aug 23, 2006, at 3:35 PM, William A. Rowe, Jr. wrote:


James Berry wrote:

What I'm saying is that they should not be treated independently or
differently. They should be treated not as metadata, but as part  
of the

segment.


To be 100% clear; this is what Apache httpd does today.  If you  
ask for
foo.html;v=1 it will open the -file- foo.html;v=1 or fail.  What  
jk or

tomcat does with the same is up to those components, but httpd has no
magic whatsoever which is what you want.  You would like the same of
Tomcat.  But...

...this would be valid if /servlet/MyApplication;v=1 invokes the  
class

MyApplication;v=1


Yes, I would expect it to invoke the class "MyApplication;v=1". I  
hadn't considered the other behavior.



and not MyApplication with a parameter of v=1.
If it invokes the class MyApplication then we can't follow your  
philosophy
since the permissions were likely to apply to the servlet class  
and not

to the precise syntax the user called MyApplication with.


That's not  what I'm asking for. It's an interesting idea, but as  
you've pointed out, might require significantly more work and  
thought to get right.


I'm simply asking that Tomcat not mangle urls that contain  
parameters. The cases in which I'd be interested in using  
parameters are below the servlet level (in pathinfo), so invoking  
servlets with such parameters, while conceivably interesting, is by  
no means necessary.


I'd ask that, for now, special case handling of parameters be  
removed. If at some point in the future support was added to  
specially parse parameters and pass them into servlets, then I'd  
assume there would have to be special configuration to enable such  
behavior. So allowing the more wide open general case behavior that  
I'm asking for now wouldn't prevent such support in the future, as  
parameters to servlets would presumably only be parsed if such  
behavior was enabled.


Given the present behavior, however, any use of parameters is  
disallowed, which seems overly restrictive, and certainly prevents  
a broad range of interesting application for segment parameters.


James




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40418] New: - APR connector deadlock

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40418

   Summary: APR connector deadlock
   Product: Tomcat 5
   Version: 5.5.17
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:HTTP
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Under high ssl load (SPECweb2005 Banking application) the acceptor thread stops
accepting new connections. The acceptor blocks in getWorkerThread() because
there isn't Worker threads available and maxThreads has been reached. The
problem is that all Worker threads are blocked waiting for a socket to process,
but this socket is never assigned because there is a leak in the Acceptor thread
code. I can attach the stacktrace of the relevant threads if necessary.

Regards,
 
- Vicenç


This modification remove the leak of Worker threads.

Index: connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java
===
--- connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java   
(revision 130)
+++ connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java(working
copy)
@@ -980,6 +980,7 @@
  */
 public void run() {

+Worker workerThread = null;
 // Loop until we receive a shutdown command
 while (running) {

@@ -994,12 +995,15 @@

 try {
 // Allocate a new worker thread
-Worker workerThread = getWorkerThread();
+if (workerThread == null)
+workerThread = getWorkerThread();
+
 // Accept the next incoming connection from the server 
socket
 long socket = Socket.accept(serverSock);
 // Hand this socket off to an appropriate processor
 if (setSocketOptions(socket)) {
 workerThread.assign(socket);
+if(socket != 0) workerThread = null;
 } else {
 // Close socket and pool right away
 Socket.destroy(socket);

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r440410 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c

2006-09-05 Thread rjung
Author: rjung
Date: Tue Sep  5 10:21:55 2006
New Revision: 440410

URL: http://svn.apache.org/viewvc?view=rev&rev=440410
Log:
Detect broken connection to client in Apache.

Modified:
tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?view=diff&rev=440410&r1=440409&r2=440410
==
--- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Tue Sep  5 10:21:55 
2006
@@ -381,6 +381,8 @@
 }
 
 }
+if (p->r->connection->aborted)
+return JK_FALSE;
 }
 
 return JK_TRUE;

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=440410&r1=440409&r2=440410
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Sep  5 10:21:55 
2006
@@ -423,6 +423,8 @@
 ll -= r;
 bb += r;
 }
+if (p->r->connection->aborted)
+return JK_FALSE;
 }
 
 return JK_TRUE;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r440412 - in /tomcat/tc6.0.x/trunk: conf/server.xml java/org/apache/catalina/ha/ClusterRuleSet.java

2006-09-05 Thread fhanik
Author: fhanik
Date: Tue Sep  5 10:24:10 2006
New Revision: 440412

URL: http://svn.apache.org/viewvc?view=rev&rev=440412
Log:
Still prepping for cluster integration. 
To dos: 
 - documentation
 - integrate test cases
 - sample webapp


Modified:
tomcat/tc6.0.x/trunk/conf/server.xml
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java

Modified: tomcat/tc6.0.x/trunk/conf/server.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/conf/server.xml?view=diff&rev=440412&r1=440411&r2=440412
==
--- tomcat/tc6.0.x/trunk/conf/server.xml (original)
+++ tomcat/tc6.0.x/trunk/conf/server.xml Tue Sep  5 10:24:10 2006
@@ -188,130 +188,45 @@
unpackWARs="true" autoDeploy="true"
xmlValidation="false" xmlNamespaceAware="false">
 
- 
-
 
 
 

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java?view=diff&rev=440412&r1=440411&r2=440412
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java Tue 
Sep  5 10:24:10 2006
@@ -119,7 +119,7 @@
 digester.addSetProperties(channelPrefix + "Sender/Transport");
 digester.addSetNext(channelPrefix + "Sender/Transport",
 "setTransport",
-
"org.apache.catalina.tribes.tcp.MultiPointSender");
+
"org.apache.catalina.tribes.transport.MultiPointSender");
 
 
 digester.addObjectCreate(channelPrefix + "Receiver",



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r440413 - /tomcat/connectors/trunk/jk/xdocs/changelog.xml

2006-09-05 Thread mturk
Author: mturk
Date: Tue Sep  5 10:24:11 2006
New Revision: 440413

URL: http://svn.apache.org/viewvc?view=rev&rev=440413
Log:
Hope this will satisfy all language purist.
Note the changes between releases.

Modified:
tomcat/connectors/trunk/jk/xdocs/changelog.xml

Modified: tomcat/connectors/trunk/jk/xdocs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/changelog.xml?view=diff&rev=440413&r1=440412&r2=440413
==
--- tomcat/connectors/trunk/jk/xdocs/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/changelog.xml Tue Sep  5 10:24:11 2006
@@ -21,7 +21,7 @@
   new documentation project for JK was started.
   
 
-
+
   
   
 
@@ -126,7 +126,7 @@
 
   
 
-
+
   
   
 
@@ -139,7 +139,7 @@
 
   
 
-
+
   
   
 
@@ -154,7 +154,7 @@
 
   
 
-
+
   
   
 
@@ -266,7 +266,7 @@
 
   
 
-
+
   
   
 
@@ -281,7 +281,7 @@
 
   
 
-
+
   
   
 
@@ -313,7 +313,7 @@
 
   
 
-
+
   
   
 
@@ -353,7 +353,7 @@
   
 
 
-
+
   
   
 
@@ -370,7 +370,7 @@
   
 
 
-
+
   
   
 
@@ -429,7 +429,7 @@
 
   
 
-
+
   
   
 
@@ -495,7 +495,7 @@
 
   
 
-
+
   
   
 
@@ -554,7 +554,7 @@
 
   
 
-
+
   
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [DRAFT] Board Report for September 2006

2006-09-05 Thread Yoav Shapira

Hi,
OK, so the updated draft looks like this:


Attachment [TBD]: Status report for the Apache Tomcat Project
- We have no issues that require attention from the Board at this time

Development:
- Continued work on Tomcat 6.0 development: we expect to have release
6.0.0 ready roughly at the same time that Servlet Specification v2.5
and JSP Specification v2.1 are finalized.  No change here since
previous Board report.
- Much work has been done on the mod_jk connector, improving
reliability, performance, and monitoring options for httpd / mod_jk
administrators.  It's been great to see the increased level of energy
and enthusiasm around the connectors, and the new connector releases
have been getting pre-release testing from a number of committers on
various platforms.
- We've also added a non-blocking HTTPS protocol connector written in
Java to provide users with another choice on platforms that handle
non-blocking IO threads well.
- We're also diversifying release managers: Mark Thomas is the current
release manager for Tomcat 4.x, Filip Hanik for Tomcat 5.x, Remy
Maucherat for 6.x, and Rainer Jung for the connectors.

Releases:
- mod_jk 1.2.17 and 1.2.18 were released.  1.2.18 is currently the
stable release (it was put out on July 20th).  mod_jk 1.2.19 is in the
works, expected to release in the first half of September.
- Tomcat 4.1.34 was released in the first week of September, and
addresses virtually all the issues reported against the previous 4.1
release.
- Tomcat 5.5.18 is also in the middle of its release process, with
expected release in the next two weeks.  Tomcat 5.5.17 is still the
latest stable Tomcat release.

People:
- No changes since last Board report.


(End of draft)
Yoav

On 9/2/06, Rainer Jung <[EMAIL PROTECTED]> wrote:

+1 (thanks for the nice comments on the recent connectors work) and +1
to Mladens Comments on the connector stuff.

Maybe you might like to add myself to the "diversifying release managers
part concerning tomcat-connectors.

Regards,

Rainer

Yoav Shapira schrieb:
> Hey,
> We need to submit a quarterly report to the Board this month.  I've
> put together a first draft below.  Comments and edits are welcome:
> we've got a while before we have to submit this (the Board meeting is
> September 20th, so let's stick the comments deadline somewhere in the
> middle, September 10th.
>
> Yoav
>
> 
> Attachment [TBD]: Status report for the Apache Tomcat Project
> - We have no issues that require attention from the Board at this time
>
> Development:
> - Continued work on Tomcat 6.0 development: we expect to have release
> 6.0.0 ready roughly at the same time that Servlet Specification v2.5
> and JSP Specification v2.1 are finalized.  No change here since
> previous Board report.
> - Much work has been done on the mod_jk connector, improving
> reliability, performance, and monitoring options for httpd / mod_jk
> administrators.  It's been great to see the increased level of energy
> and enthusiasm around the connectors, and the new connector releases
> have been getting pre-release testing from a number of committers on
> various platforms.
> - We're also diversifying release managers: Mark Thomas is the current
> release manager for Tomcat 4.x, Filip Hanik for Tomcat 5.x, and Remy
> Maucherat for 6.x.
>
> Releases:
> - mod_jk 1.2.17 and 1.2.18 were released.  1.2.18 is currently the
> stable release (it was put out on July 20th).  mod_jk 1.2.19 is in the
> works, expected to release in September.
> - Tomcat 4.1.34 is being voted on right now, with expected final
> release next week.  This is a bug fix, documentation update, and
> limited back-porting of features release.
> - Tomcat 5.5.18 is also in the middle of its release process, with
> expected release in the next two weeks.  Tomcat 5.5.17 is still the
> latest stable Tomcat release.
>
> People:
> - No changes since last Board report.
> 
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [DRAFT] Board Report for September 2006

2006-09-05 Thread Filip Hanik - Dev Lists

looking good

Yoav Shapira wrote:

Hi,
OK, so the updated draft looks like this:


Attachment [TBD]: Status report for the Apache Tomcat Project
- We have no issues that require attention from the Board at this time

Development:
- Continued work on Tomcat 6.0 development: we expect to have release
6.0.0 ready roughly at the same time that Servlet Specification v2.5
and JSP Specification v2.1 are finalized.  No change here since
previous Board report.
- Much work has been done on the mod_jk connector, improving
reliability, performance, and monitoring options for httpd / mod_jk
administrators.  It's been great to see the increased level of energy
and enthusiasm around the connectors, and the new connector releases
have been getting pre-release testing from a number of committers on
various platforms.
- We've also added a non-blocking HTTPS protocol connector written in
Java to provide users with another choice on platforms that handle
non-blocking IO threads well.
- We're also diversifying release managers: Mark Thomas is the current
release manager for Tomcat 4.x, Filip Hanik for Tomcat 5.x, Remy
Maucherat for 6.x, and Rainer Jung for the connectors.

Releases:
- mod_jk 1.2.17 and 1.2.18 were released.  1.2.18 is currently the
stable release (it was put out on July 20th).  mod_jk 1.2.19 is in the
works, expected to release in the first half of September.
- Tomcat 4.1.34 was released in the first week of September, and
addresses virtually all the issues reported against the previous 4.1
release.
- Tomcat 5.5.18 is also in the middle of its release process, with
expected release in the next two weeks.  Tomcat 5.5.17 is still the
latest stable Tomcat release.

People:
- No changes since last Board report.


(End of draft)
Yoav

On 9/2/06, Rainer Jung <[EMAIL PROTECTED]> wrote:

+1 (thanks for the nice comments on the recent connectors work) and +1
to Mladens Comments on the connector stuff.

Maybe you might like to add myself to the "diversifying release managers
part concerning tomcat-connectors.

Regards,

Rainer

Yoav Shapira schrieb:
> Hey,
> We need to submit a quarterly report to the Board this month.  I've
> put together a first draft below.  Comments and edits are welcome:
> we've got a while before we have to submit this (the Board meeting is
> September 20th, so let's stick the comments deadline somewhere in the
> middle, September 10th.
>
> Yoav
>
> 
> Attachment [TBD]: Status report for the Apache Tomcat Project
> - We have no issues that require attention from the Board at this time
>
> Development:
> - Continued work on Tomcat 6.0 development: we expect to have release
> 6.0.0 ready roughly at the same time that Servlet Specification v2.5
> and JSP Specification v2.1 are finalized.  No change here since
> previous Board report.
> - Much work has been done on the mod_jk connector, improving
> reliability, performance, and monitoring options for httpd / mod_jk
> administrators.  It's been great to see the increased level of energy
> and enthusiasm around the connectors, and the new connector releases
> have been getting pre-release testing from a number of committers on
> various platforms.
> - We're also diversifying release managers: Mark Thomas is the current
> release manager for Tomcat 4.x, Filip Hanik for Tomcat 5.x, and Remy
> Maucherat for 6.x.
>
> Releases:
> - mod_jk 1.2.17 and 1.2.18 were released.  1.2.18 is currently the
> stable release (it was put out on July 20th).  mod_jk 1.2.19 is in the
> works, expected to release in September.
> - Tomcat 4.1.34 is being voted on right now, with expected final
> release next week.  This is a bug fix, documentation update, and
> limited back-porting of features release.
> - Tomcat 5.5.18 is also in the middle of its release process, with
> expected release in the next two weeks.  Tomcat 5.5.17 is still the
> latest stable Tomcat release.
>
> People:
> - No changes since last Board report.
> 
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40420] New: - gaps in logic of org.apache.jasper.compiler.Compiler.isOutDated()

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40420

   Summary: gaps in logic of
org.apache.jasper.compiler.Compiler.isOutDated()
   Product: Tomcat 5
   Version: 5.5.9
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Hi guys,

i've been meaning to report this problem quite a while ago but it is better late
then never... so here it goes:

We have a deployment system based on the back of Subversion, which facilitates
rolling application back as well as forward. The system also maintains file
dates to be consistent with the dates in the repository. 

We started noticing problems when Tomcat would choose not to compile JSPs that
have been updated. On the closer inspection it appears that isOutDated()
function would return as positive only if targetLastModified < jspLastModified,
which is not always the case when JSP files are rolled back in time.

I think it would be more accurate to compile the JSP if "targetLastModified !=
jspLastModified" and when the generated servlet and the compiled class have the
same "lastModified" value as the source JSP file. 

There is also more complicated problem to fix, which is to do with how "include"
files affect isOutDated() function. isOutDated() should be called recursively on
the included files instead of comparing their dates to the master jsp date.

I'd be happy to submit a patch should you want me to.

Regards,
Vlad

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40420] - gaps in logic of org.apache.jasper.compiler.Compiler.isOutDated()

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40420


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-09-06 01:46 ---


*** This bug has been marked as a duplicate of 33453 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-09-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-09-06 01:46 ---
*** Bug 40420 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r440566 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java

2006-09-05 Thread markt
Author: markt
Date: Tue Sep  5 19:02:37 2006
New Revision: 440566

URL: http://svn.apache.org/viewvc?view=rev&rev=440566
Log:
Remove unused code identified by Eclipse before starting work on bug 30762.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java?view=diff&rev=440566&r1=440565&r2=440566
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core/StandardContext.java
 Tue Sep  5 19:02:37 2006
@@ -19,12 +19,9 @@
 
 import java.io.BufferedReader;
 import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
-import java.io.ObjectOutputStream;
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -97,7 +94,6 @@
 import org.apache.naming.resources.FileDirContext;
 import org.apache.naming.resources.ProxyDirContext;
 import org.apache.naming.resources.WARDirContext;
-import org.apache.tomcat.util.compat.JdkCompat;
 
 /**
  * Standard implementation of the Context interface.  Each
@@ -142,12 +138,6 @@
 
 
 /**
- * JDK compatibility support
- */
-private static final JdkCompat jdkCompat = JdkCompat.getJdkCompat();
-
-
-/**
  * Array containing the safe characters set.
  */
 protected static URLEncoder urlEncoder;
@@ -4316,23 +4306,6 @@
}
  }
 
-private void cacheContext() {
-try {
-File workDir=new File( getWorkPath() );
-
-File ctxSer=new File( workDir, "_tomcat_context.ser");
-FileOutputStream fos=new FileOutputStream( ctxSer );
-ObjectOutputStream oos=new ObjectOutputStream( fos );
-oos.writeObject(this);
-oos.close();
-fos.close();
-} catch( Throwable t ) {
-if(log.isInfoEnabled())
-log.info("Error saving context.ser ", t);
-}
-}
-
-
 /**
  * Stop this Context component.
  *
@@ -4664,24 +4637,6 @@
 
 
 /**
- * Get app base.
- */
-private String getAppBase() {
-String appBase = null;
-Container container = this;
-while (container != null) {
-if (container instanceof Host)
-break;
-container = container.getParent();
-}
-if (container != null) {
-appBase = ((Host) container).getAppBase();
-}
-return appBase;
-}
-
-
-/**
  * Get config base.
  */
 public File getConfigBase() {
@@ -4729,46 +4684,6 @@
 
 
 /**
- * Copy a file.
- */
-private boolean copy(File src, File dest) {
-FileInputStream is = null;
-FileOutputStream os = null;
-try {
-is = new FileInputStream(src);
-os = new FileOutputStream(dest);
-byte[] buf = new byte[4096];
-while (true) {
-int len = is.read(buf);
-if (len < 0)
-break;
-os.write(buf, 0, len);
-}
-is.close();
-os.close();
-} catch (IOException e) {
-return false;
-} finally {
-try {
-if (is != null) {
-is.close();
-}
-} catch (Exception e) {
-// Ignore
-}
-try {
-if (os != null) {
-os.close();
-}
-} catch (Exception e) {
-// Ignore
-}
-}
-return true;
-}
-
-
-/**
  * Get naming context full name.
  */
 private String getNamingContextName() {
@@ -4800,18 +4715,6 @@
 public boolean getPaused() {
 
 return (this.paused);
-
-}
-
-
-/**
- * Post a copy of our web application resources as a servlet context
- * attribute.
- */
-private void postResources() {
-
-getServletContext().setAttribute
-(Globals.RESOURCES_ATTR, getResources());
 
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [DRAFT] Board Report for September 2006

2006-09-05 Thread Peter Rossbach

+1

fine :-)
Peter



Am 05.09.2006 um 22:09 schrieb Yoav Shapira:


Hi,
OK, so the updated draft looks like this:


Attachment [TBD]: Status report for the Apache Tomcat Project
- We have no issues that require attention from the Board at this time

Development:
- Continued work on Tomcat 6.0 development: we expect to have release
6.0.0 ready roughly at the same time that Servlet Specification v2.5
and JSP Specification v2.1 are finalized.  No change here since
previous Board report.
- Much work has been done on the mod_jk connector, improving
reliability, performance, and monitoring options for httpd / mod_jk
administrators.  It's been great to see the increased level of energy
and enthusiasm around the connectors, and the new connector releases
have been getting pre-release testing from a number of committers on
various platforms.
- We've also added a non-blocking HTTPS protocol connector written in
Java to provide users with another choice on platforms that handle
non-blocking IO threads well.
- We're also diversifying release managers: Mark Thomas is the current
release manager for Tomcat 4.x, Filip Hanik for Tomcat 5.x, Remy
Maucherat for 6.x, and Rainer Jung for the connectors.

Releases:
- mod_jk 1.2.17 and 1.2.18 were released.  1.2.18 is currently the
stable release (it was put out on July 20th).  mod_jk 1.2.19 is in the
works, expected to release in the first half of September.
- Tomcat 4.1.34 was released in the first week of September, and
addresses virtually all the issues reported against the previous 4.1
release.
- Tomcat 5.5.18 is also in the middle of its release process, with
expected release in the next two weeks.  Tomcat 5.5.17 is still the
latest stable Tomcat release.

People:
- No changes since last Board report.


(End of draft)
Yoav

On 9/2/06, Rainer Jung <[EMAIL PROTECTED]> wrote:
+1 (thanks for the nice comments on the recent connectors work)  
and +1

to Mladens Comments on the connector stuff.

Maybe you might like to add myself to the "diversifying release  
managers

part concerning tomcat-connectors.

Regards,

Rainer

Yoav Shapira schrieb:
> Hey,
> We need to submit a quarterly report to the Board this month.  I've
> put together a first draft below.  Comments and edits are welcome:
> we've got a while before we have to submit this (the Board  
meeting is
> September 20th, so let's stick the comments deadline somewhere  
in the

> middle, September 10th.
>
> Yoav
>
> 
> Attachment [TBD]: Status report for the Apache Tomcat Project
> - We have no issues that require attention from the Board at  
this time

>
> Development:
> - Continued work on Tomcat 6.0 development: we expect to have  
release
> 6.0.0 ready roughly at the same time that Servlet Specification  
v2.5

> and JSP Specification v2.1 are finalized.  No change here since
> previous Board report.
> - Much work has been done on the mod_jk connector, improving
> reliability, performance, and monitoring options for httpd / mod_jk
> administrators.  It's been great to see the increased level of  
energy
> and enthusiasm around the connectors, and the new connector  
releases
> have been getting pre-release testing from a number of  
committers on

> various platforms.
> - We're also diversifying release managers: Mark Thomas is the  
current
> release manager for Tomcat 4.x, Filip Hanik for Tomcat 5.x, and  
Remy

> Maucherat for 6.x.
>
> Releases:
> - mod_jk 1.2.17 and 1.2.18 were released.  1.2.18 is currently the
> stable release (it was put out on July 20th).  mod_jk 1.2.19 is  
in the

> works, expected to release in September.
> - Tomcat 4.1.34 is being voted on right now, with expected final
> release next week.  This is a bug fix, documentation update, and
> limited back-porting of features release.
> - Tomcat 5.5.18 is also in the middle of its release process, with
> expected release in the next two weeks.  Tomcat 5.5.17 is still the
> latest stable Tomcat release.
>
> People:
> - No changes since last Board report.
> 
>
>  
-

> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]