svn commit: r437990 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

[mturk]

Author: mturk
Date: Tue Aug 29 00:19:18 2006
New Revision: 437990

URL: http://svn.apache.org/viewvc?rev=437990&view=rev
Log:
We are using C not C++ compiler, so make sure
variable declarations are before any variable
usage. Not sure if GCC allows that, but MSVC
certainly does not.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=437990&r1=437989&r2=437990&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Tue Aug 29 00:19:18 
2006
@@ -822,10 +822,10 @@
"recoverable error... will try to recover on other 
worker");
 }
 if (first == 1 && s->add_log_items) {
-first = 0;
 const char **log_names = jk_pool_alloc(s->pool, sizeof(char *) 
* JK_LB_NOTES_COUNT);
 const char **log_values = jk_pool_alloc(s->pool, sizeof(char 
*) * JK_LB_NOTES_COUNT);
 char *buf = jk_pool_alloc(s->pool, sizeof(char *) * 
JK_LB_NOTES_COUNT * JK_LB_MAX_SZ);;
+first = 0;
 if (log_names && log_values && buf) {
 log_names[0] = JK_NOTE_LB_FIRST_NAME;
 log_values[0] = prec->s->name;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r437994 - in /tomcat/connectors/trunk/jk/native/common: jk_lb_worker.c jk_util.c

[mturk]

Author: mturk
Date: Tue Aug 29 00:37:23 2006
New Revision: 437994

URL: http://svn.apache.org/viewvc?rev=437994&view=rev
Log:
Fix return values from jk_get_worker_activation.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=437994&r1=437993&r2=437994&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Tue Aug 29 00:37:23 
2006
@@ -1003,7 +1003,13 @@
 p->lb_workers[i].s->lb_value = 0;
 p->lb_workers[i].s->state = JK_LB_STATE_NA;
 p->lb_workers[i].s->error_time = 0;
-p->lb_workers[i].s->activation = 
jk_get_worker_activation(props, worker_names[i]);
+if ((p->lb_workers[i].s->activation = 
+ jk_get_worker_activation(props, worker_names[i])) < 0) {
+ jk_log(l, JK_LOG_ERROR,
+"Invalid Activation mode for worker %s",
+worker_names[i]);
+ break;
+}
 if (!wc_create_worker(p->lb_workers[i].s->name, 0,
   props,
   &(p->lb_workers[i].w),

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?rev=437994&r1=437993&r2=437994&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Tue Aug 29 00:37:23 2006
@@ -781,6 +781,8 @@
 return JK_LB_ACTIVATION_STOPPED;
 else if (*v == 'd' || *v == 'D')
 return JK_LB_ACTIVATION_DISABLED;
+else
+return -1;
 }
 else if (jk_get_is_worker_stopped(m, wname))
 return JK_LB_ACTIVATION_STOPPED;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r437995 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

[mturk]

Author: mturk
Date: Tue Aug 29 00:38:16 2006
New Revision: 437995

URL: http://svn.apache.org/viewvc?rev=437995&view=rev
Log:
Fix const char* -> char * problem by duping the
provided config value.

Modified:
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?rev=437995&r1=437994&r2=437995&view=diff
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Aug 29 00:38:16 
2006
@@ -1036,7 +1036,7 @@
 (jk_server_conf_t *) ap_get_module_config(s->module_config,
   &jk_module);
 
-conf->alias_dir = directory;
+conf->alias_dir = apr_pstrdup(cmd->pool, directory);
 
 if (conf->alias_dir == NULL)
 return "JkAutoAlias directory invalid";



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r437996 - /tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c

[mturk]

Author: mturk
Date: Tue Aug 29 00:39:09 2006
New Revision: 437996

URL: http://svn.apache.org/viewvc?rev=437996&view=rev
Log:
Update because of the changed jk_map_resolve_references
function API.

Modified:
tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?rev=437996&r1=437995&r2=437996&view=diff
==
--- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Tue Aug 29 00:39:09 
2006
@@ -2180,7 +2180,7 @@
 ap_add_version_component(JK_EXPOSED_VERSION);
 #endif
 
-if (jk_map_resolve_references(JK_WORKER_NAME_TAG ".", 1, 1) == JK_FALSE) {
+if (jk_map_resolve_references(init_map, "worker.", 1, 1, conf->log) == 
JK_FALSE) {
 jk_error_exit(APLOG_MARK, APLOG_EMERG, s, p, "Error in resolving 
configuration references");
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Quality check mod_jk 1.2.19-dev

[Mladen Turk]

Henri Gomez wrote:


BTW, a windows binary will be usefull also



http://people.apache.org/~mturk/jk1219/

Done some bug fixes to be able to compile,
so they are in sync with trunk.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Quality check mod_jk 1.2.19-dev

[Henri Gomez]

What does 'ls -l usr/sbin/apxs2-worker' say?



On Suse Linux distribution, rpm packager provide one apxs by MPM model.

apxs2-worker is for worker mode, apxs2-prefork for prefork mode;

Cheers

Re: Quality check mod_jk 1.2.19-dev

[Henri Gomez]

2006/8/29, Mladen Turk <[EMAIL PROTECTED]>:


Henri Gomez wrote:
>
> BTW, a windows binary will be usefull also
>

http://people.apache.org/~mturk/jk1219/

Done some bug fixes to be able to compile,
so they are in sync with trunk.



Thanks.

BTW,  what about releasing a new tarball including this fixes ?

Re: Quality check mod_jk 1.2.19-dev

[Rainer Jung]

If no one stops me, I'll do so at in 30 minutes :)

Henri Gomez schrieb:
> 2006/8/29, Mladen Turk <[EMAIL PROTECTED]>:
>>
>> Henri Gomez wrote:
>> >
>> > BTW, a windows binary will be usefull also
>> >
>>
>> http://people.apache.org/~mturk/jk1219/
>>
>> Done some bug fixes to be able to compile,
>> so they are in sync with trunk.
> 
> 
> Thanks.
> 
> BTW,  what about releasing a new tarball including this fixes ?
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r438007 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

[rjung]

Author: rjung
Date: Tue Aug 29 01:27:06 2006
New Revision: 438007

URL: http://svn.apache.org/viewvc?rev=438007&view=rev
Log:
Add another deprecated directive.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?rev=438007&r1=438006&r2=438007&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Tue Aug 29 01:27:06 2006
@@ -1169,6 +1169,7 @@
 LIBPATH_OF_WORKER,
 CMD_LINE_OF_WORKER,
 NATIVE_LIB_OF_WORKER,
+BALANCED_WORKERS,
 IS_WORKER_DISABLED,
 IS_WORKER_STOPPED,
 NULL



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r438008 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[rjung]

Author: rjung
Date: Tue Aug 29 01:30:53 2006
New Revision: 438008

URL: http://svn.apache.org/viewvc?rev=438008&view=rev
Log:
Make string handling in new function a little more robust.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?rev=438008&r1=438007&r2=438008&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Aug 29 01:30:53 
2006
@@ -897,14 +897,14 @@
 if ( cmd == 0 ) {
 jk_putv(s, "[req_uri, NULL);
 if (refresh >= 0) {
-char *buf = jk_pool_alloc(s->pool, sizeof(char *) * 
BIG_POOL_SIZE);
 const char *str = s->query_string;
+char *buf = jk_pool_alloc(s->pool, sizeof(char *) * 
(strlen(str)+1));
 int result = 0;
 int scan = 0;
 
 while (str[scan] != 0) {
-if (strncmp(&str[scan], "refresh=", 8) == 0) {
-scan += 8;
+if (strncmp(&str[scan], "refresh=", strlen("refresh=")) == 
0) {
+scan += strlen("refresh=");
 while (str[scan] != 0 && str[scan] != '&')
 scan++;
 if (str[scan] == '&')
@@ -924,7 +924,7 @@
 scan++;
 }
 }
-buf[result] = 0;
+buf[result] = '\0';
 
 if (buf && buf[0])
 jk_putv(s, "?", buf, NULL);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r438010 - in /tomcat/connectors/trunk/jk/native/common: jk_lb_worker.c jk_lb_worker.h

[rjung]

Author: rjung
Date: Tue Aug 29 01:32:05 2006
New Revision: 438010

URL: http://svn.apache.org/viewvc?rev=438010&view=rev
Log:
Give new constant a more eprecise name.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=438010&r1=438009&r2=438010&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Tue Aug 29 01:32:05 
2006
@@ -824,32 +824,32 @@
 if (first == 1 && s->add_log_items) {
 const char **log_names = jk_pool_alloc(s->pool, sizeof(char *) 
* JK_LB_NOTES_COUNT);
 const char **log_values = jk_pool_alloc(s->pool, sizeof(char 
*) * JK_LB_NOTES_COUNT);
-char *buf = jk_pool_alloc(s->pool, sizeof(char *) * 
JK_LB_NOTES_COUNT * JK_LB_MAX_SZ);;
+char *buf = jk_pool_alloc(s->pool, sizeof(char *) * 
JK_LB_NOTES_COUNT * JK_LB_UINT64_STR_SZ);;
 first = 0;
 if (log_names && log_values && buf) {
 log_names[0] = JK_NOTE_LB_FIRST_NAME;
 log_values[0] = prec->s->name;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, 
prec->s->lb_value);
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT64_T_FMT, 
prec->s->lb_value);
 log_names[1] = JK_NOTE_LB_FIRST_VALUE;
 log_values[1] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, 
prec->s->elected);
+buf += JK_LB_UINT64_STR_SZ;
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT64_T_FMT, 
prec->s->elected);
 log_names[2] = JK_NOTE_LB_FIRST_ACCESSED;
 log_values[2] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, 
prec->s->readed);
+buf += JK_LB_UINT64_STR_SZ;
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT64_T_FMT, 
prec->s->readed);
 log_names[3] = JK_NOTE_LB_FIRST_READ;
 log_values[3] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, 
prec->s->transferred);
+buf += JK_LB_UINT64_STR_SZ;
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT64_T_FMT, 
prec->s->transferred);
 log_names[4] = JK_NOTE_LB_FIRST_TRANSFERRED;
 log_values[4] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT32_T_FMT, 
prec->s->errors);
+buf += JK_LB_UINT64_STR_SZ;
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT32_T_FMT, 
prec->s->errors);
 log_names[5] = JK_NOTE_LB_FIRST_ERRORS;
 log_values[5] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%d", prec->s->busy);
+buf += JK_LB_UINT64_STR_SZ;
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%d", prec->s->busy);
 log_names[6] = JK_NOTE_LB_FIRST_BUSY;
 log_values[6] = buf;
 log_names[7] = JK_NOTE_LB_FIRST_ACTIVATION;
@@ -879,31 +879,31 @@
 if (prec && s->add_log_items) {
 const char **log_names = jk_pool_alloc(s->pool, sizeof(char *) * 
JK_LB_NOTES_COUNT);
 const char **log_values = jk_pool_alloc(s->pool, sizeof(char *) * 
JK_LB_NOTES_COUNT);
-char *buf = jk_pool_alloc(s->pool, sizeof(char *) * JK_LB_NOTES_COUNT 
* JK_LB_MAX_SZ);;
+char *buf = jk_pool_alloc(s->pool, sizeof(char *) * JK_LB_NOTES_COUNT 
* JK_LB_UINT64_STR_SZ);;
 if (log_names && log_values && buf) {
 log_names[0] = JK_NOTE_LB_LAST_NAME;
 log_values[0] = prec->s->name;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, 
prec->s->lb_value);
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT64_T_FMT, 
prec->s->lb_value);
 log_names[1] = JK_NOTE_LB_LAST_VALUE;
 log_values[1] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, prec->s->elected);
+buf += JK_LB_UINT64_STR_SZ;
+snprintf(buf, JK_LB_UINT64_STR_SZ, "%" JK_UINT64_T_FMT, 
prec->s->elected);
 log_names[2] = JK_NOTE_LB_LAST_ACCESSED;
 log_values[2] = buf;
-buf += JK_LB_MAX_SZ;
-snprintf(buf, JK_LB_MAX_SZ, "%" JK_UINT64_T_FMT, prec->s->readed);
+buf += JK_LB_UINT64_STR_SZ;
+   

svn commit: r438020 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

[rjung]

Author: rjung
Date: Tue Aug 29 02:03:09 2006
New Revision: 438020

URL: http://svn.apache.org/viewvc?rev=438020&view=rev
Log:
Only apply usable values for activation from status worker updates.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_status.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?rev=438020&r1=438019&r2=438020&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_status.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_status.c Tue Aug 29 02:03:09 
2006
@@ -738,7 +738,7 @@
 else
 memset(wr->s->domain, 0, JK_SHM_STR_SIZ);
 i = status_int("wa", s->query_string, wr->s->activation);
-if (wr->s->activation != i) {
+if (wr->s->activation != i && i>0 && i<= JK_LB_ACTIVATION_STOPPED) {
 wr->s->activation = i;
 reset_lb_values(lb, l);
 jk_log(l, JK_LOG_INFO,



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r438031 - in /tomcat/connectors/trunk/jk/native/common: jk_lb_worker.c jk_util.c

[rjung]

Author: rjung
Date: Tue Aug 29 02:35:33 2006
New Revision: 438031

URL: http://svn.apache.org/viewvc?rev=438031&view=rev
Log:
Set a valid default activation. Delete check for valid activation values.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=438031&r1=438030&r2=438031&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Tue Aug 29 02:35:33 
2006
@@ -1003,13 +1003,8 @@
 p->lb_workers[i].s->lb_value = 0;
 p->lb_workers[i].s->state = JK_LB_STATE_NA;
 p->lb_workers[i].s->error_time = 0;
-if ((p->lb_workers[i].s->activation = 
- jk_get_worker_activation(props, worker_names[i])) < 0) {
- jk_log(l, JK_LOG_ERROR,
-"Invalid Activation mode for worker %s",
-worker_names[i]);
- break;
-}
+p->lb_workers[i].s->activation = 
+jk_get_worker_activation(props, worker_names[i]);
 if (!wc_create_worker(p->lb_workers[i].s->name, 0,
   props,
   &(p->lb_workers[i].w),

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?rev=438031&r1=438030&r2=438031&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Tue Aug 29 02:35:33 2006
@@ -782,7 +782,7 @@
 else if (*v == 'd' || *v == 'D')
 return JK_LB_ACTIVATION_DISABLED;
 else
-return -1;
+return JK_LB_ACTIVATION_ACTIVE;
 }
 else if (jk_get_is_worker_stopped(m, wname))
 return JK_LB_ACTIVATION_STOPPED;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Remy Maucherat]

Dies Koper wrote:

Hello Filip,

In my application I used a pageContext.include which once threw a 
JasperException (ServletException) while it was supposed to (according 
to the spec) propagate the IOException as-is.
I noticed that setting the "deployment" init param in conf\web.xml to 
"false" made it propagate the IOException correctly.


Apparently JspServletWrapper checks this flag and decides to handle 
exceptions differently depending on this value.
I did not look further into it as my problem is resolved, but I have 
been wondering why it would do this and whether to bring it up here.


It's "development". Indeed, it seems to be the reason: the original 
exception gets wrapped for nicer error reporting purposes. If 
development mode is off, then the original exception will be passed, so 
the test should then work.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Update] Quality check mod_jk 1.2.19-dev

[Rainer Jung]

Hi all,

Mladen and I applied some minor but partly important fixes. The result
is available from trunk, but also as a tarball from

http://people.apache.org/~rjung/mod_jk-1.2.19-438031/

Under this URL you can also find the docs (no changes form previous
quality check).

Feel free to send any observations.

No new features since the last quality check. The only fixes have been
applied to the load balancer, the status worker, and one small fix
respectively for the module for apache 1.3 and apache 2.0.

Thanks for testing again.

Regards,

Rainer



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Filip Hanik - Dev Lists]

I'm still running the tests, I had some funky results come up when I 
turned off development, and I am re-running the tests to make sure it 
wasn't me screwing it up


Filip


Remy Maucherat wrote:

Dies Koper wrote:

Hello Filip,

In my application I used a pageContext.include which once threw a 
JasperException (ServletException) while it was supposed to 
(according to the spec) propagate the IOException as-is.
I noticed that setting the "deployment" init param in conf\web.xml to 
"false" made it propagate the IOException correctly.


Apparently JspServletWrapper checks this flag and decides to handle 
exceptions differently depending on this value.
I did not look further into it as my problem is resolved, but I have 
been wondering why it would do this and whether to bring it up here.


It's "development". Indeed, it seems to be the reason: the original 
exception gets wrapped for nicer error reporting purposes. If 
development mode is off, then the original exception will be passed, 
so the test should then work.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40347] New: - Manager displays spurious contexts when multi-level context paths are used

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40347

   Summary: Manager displays spurious contexts when multi-level
context paths are used
   Product: Tomcat 5
   Version: 5.5.17
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Webapps:Manager
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


We deploy Web applications using three-level context paths like
"/webinfra/access/webapp".  When an app is deployed this way in Tomcat 5.5 using
a Context XML file, spurious "applications" are created that then appear in the
app list displayed by the Manager.  In the case mentioned here (for example),
"/webinfra" appears in the list once the real application has been deployed. 
The spurious application can be undeployed from the Manager, and that
effectively undeploys the original as well.

This is operationally troublesome and confusing, and it differs from the
behavior in Tomcat 5.0 (from which we want to convert).

Note that the spurious contexts only appear if "unpackWARs" is set to "true"
(the default) so that WAR files are expanded into Tomcat's work area.  (Running
with "unpackWARs" set to "false" is no longer a viable option for us because, in
that configuration, changes to the underlying WAR files, which we can't reliably
prevent, often lead to JVM crashes on a running system.)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Remy Maucherat]

Filip Hanik - Dev Lists wrote:
I'm still running the tests, I had some funky results come up when I 
turned off development, and I am re-running the tests to make sure it 
wasn't me screwing it up


This is not really related, but where's the 5.5.18 build ?

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Filip Hanik - Dev Lists]

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
I'm still running the tests, I had some funky results come up when I 
turned off development, and I am re-running the tests to make sure it 
wasn't me screwing it up


This is not really related, but where's the 5.5.18 build ?

http://people.apache.org/~fhanik/v5.5.18-beta/


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Filip Hanik - Dev Lists]

ok, development=false took care of the three errors, the TCK now runs 
error free for the first run, any subsequent runs I get about 50 or so 
errors.
If I delete the contents of the work directory, it again runs error 
free, I'll do some investigations to see if its an actual issue


Filip


Remy Maucherat wrote:

Dies Koper wrote:

Hello Filip,

In my application I used a pageContext.include which once threw a 
JasperException (ServletException) while it was supposed to 
(according to the spec) propagate the IOException as-is.
I noticed that setting the "deployment" init param in conf\web.xml to 
"false" made it propagate the IOException correctly.


Apparently JspServletWrapper checks this flag and decides to handle 
exceptions differently depending on this value.
I did not look further into it as my problem is resolved, but I have 
been wondering why it would do this and whether to bring it up here.


It's "development". Indeed, it seems to be the reason: the original 
exception gets wrapped for nicer error reporting purposes. If 
development mode is off, then the original exception will be passed, 
so the test should then work.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Remy Maucherat]

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
I'm still running the tests, I had some funky results come up when I 
turned off development, and I am re-running the tests to make sure it 
wasn't me screwing it up


This is not really related, but where's the 5.5.18 build ?

http://people.apache.org/~fhanik/v5.5.18-beta/


Ok, thanks. There's something wrong with the .exe file size (it's about 
2x as big as it should be). Maybe you're using a recent NSIS version 
(you should be using 2.0.0, newer versions tend to do crap when 
selecting files - I added workarounds so that it does not happen with 
Tomcat 6, but for 5.5, there are issues).


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

[Filip Hanik - Dev Lists]

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:
I'm still running the tests, I had some funky results come up when 
I turned off development, and I am re-running the tests to make 
sure it wasn't me screwing it up


This is not really related, but where's the 5.5.18 build ?

http://people.apache.org/~fhanik/v5.5.18-beta/


Ok, thanks. There's something wrong with the .exe file size (it's 
about 2x as big as it should be). Maybe you're using a recent NSIS 
version (you should be using 2.0.0, newer versions tend to do crap 
when selecting files - I added workarounds so that it does not happen 
with Tomcat 6, but for 5.5, there are issues).

ok, will downgrade


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Filip Hanik - Dev Lists]

Yoav Shapira wrote:

Hi,
Cool.  The directory structure and signatures look good.  We need to
update the release notes
(http://people.apache.org/~fhanik/v5.5.18-beta/RELEASE-NOTES) to
remove the LD_ASSUME_KERNEL section on Linux, as Bill (IIRC) pointed
out the day.
ok before I remove the LD_ASSUME_KERNEL, the question is why? is the 
reco wrong?

on the older distros this setting used to fix our problems

Filip



Yoav

On 8/28/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:

I have created a 5.5.18 distribution located at
http://people.apache.org/~fhanik/v5.5.18-beta/

I'm about to setup the TCK tests, servlet and JSP, to validate against
it. In the meantime feel free to play around with it.

Once we deem that it looks correct, we can setup a vote for it.

Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Rainer Jung]

Hi Filip,

I can't give the correct recommendations, but explain the flag:

The flag tells the loader not to load the default thread library, but
instead another - usually older - one. Linux had incompatible changes in
it's thread implementation and since the distros bundle so much
software, they had to deliver the different implementations side by side.

The flag has been implemented in the loader to allow old software to run
on new systems, because with setting the flag the old software loaded
the old thread libraries.

For old versions (definitely before 1.4.29 of Java, using older libs was
necessary or recommended.

The problems with the flag:

- different distros use different numeric values to switch between the
thread implementations, so there's *no* distro independant recommendation.

- once you put in into a start script, people will not recognize, that
their software version gets newer and newer and compatible with the last
(and nowadays not so new any more) thread implementation, and they still
run their software on the very outdated thread implementation.

I don't know, what teh problem with JVM/Tomcat in these old days really
was, so I cannot judge, if there is any sense in the recommendation. At
least with JVM 1.4.2 and newer, it should be dropped.

By the way: thanks for volunteering as RM!

Regards,

Rainer


Filip Hanik - Dev Lists schrieb:
> Yoav Shapira wrote:
>> Hi,
>> Cool.  The directory structure and signatures look good.  We need to
>> update the release notes
>> (http://people.apache.org/~fhanik/v5.5.18-beta/RELEASE-NOTES) to
>> remove the LD_ASSUME_KERNEL section on Linux, as Bill (IIRC) pointed
>> out the day.
> ok before I remove the LD_ASSUME_KERNEL, the question is why? is the
> reco wrong?
> on the older distros this setting used to fix our problems
> 
> Filip
> 
>>
>> Yoav
>>
>> On 8/28/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:
>>> I have created a 5.5.18 distribution located at
>>> http://people.apache.org/~fhanik/v5.5.18-beta/
>>>
>>> I'm about to setup the TCK tests, servlet and JSP, to validate against
>>> it. In the meantime feel free to play around with it.
>>>
>>> Once we deem that it looks correct, we can setup a vote for it.
>>>
>>> Filip
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Yoav Shapira]

Hi,
We need to clarify the message according to Bill's comments from a
thread on this list last week.  The message is still correct for some
users, especially those using Tomcat 4.1, JDK 1.4, and certain Linux
kernels.  We should make it clear the message does not apply to all
situations, should not be standard operating procedure, and should
only be attempted if you have an older Linux kernel that you can't
update plus a stability problem that you can't solve otherwise.  Or
something to that effect...

Yoav

On 8/29/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:

Yoav Shapira wrote:
> Hi,
> Cool.  The directory structure and signatures look good.  We need to
> update the release notes
> (http://people.apache.org/~fhanik/v5.5.18-beta/RELEASE-NOTES) to
> remove the LD_ASSUME_KERNEL section on Linux, as Bill (IIRC) pointed
> out the day.
ok before I remove the LD_ASSUME_KERNEL, the question is why? is the
reco wrong?
on the older distros this setting used to fix our problems

Filip

>
> Yoav
>
> On 8/28/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:
>> I have created a 5.5.18 distribution located at
>> http://people.apache.org/~fhanik/v5.5.18-beta/
>>
>> I'm about to setup the TCK tests, servlet and JSP, to validate against
>> it. In the meantime feel free to play around with it.
>>
>> Once we deem that it looks correct, we can setup a vote for it.
>>
>> Filip
>>
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Jean-frederic Clere]

Yoav Shapira wrote:


Hi,
We need to clarify the message according to Bill's comments from a
thread on this list last week.  The message is still correct for some
users, especially those using Tomcat 4.1, JDK 1.4, and certain Linux
kernels.


It was for RH9 JDK1.4.0 and 1.3.1... Old stuff.
Look to http://linux-sxs.org/programming/ibm-java.html

Cheers

Jean-Frederic


  We should make it clear the message does not apply to all
situations, should not be standard operating procedure, and should
only be attempted if you have an older Linux kernel that you can't
update plus a stability problem that you can't solve otherwise.  Or
something to that effect...

Yoav

On 8/29/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:


Yoav Shapira wrote:
> Hi,
> Cool.  The directory structure and signatures look good.  We need to
> update the release notes
> (http://people.apache.org/~fhanik/v5.5.18-beta/RELEASE-NOTES) to
> remove the LD_ASSUME_KERNEL section on Linux, as Bill (IIRC) pointed
> out the day.
ok before I remove the LD_ASSUME_KERNEL, the question is why? is the
reco wrong?
on the older distros this setting used to fix our problems

Filip

>
> Yoav
>
> On 8/28/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:
>> I have created a 5.5.18 distribution located at
>> http://people.apache.org/~fhanik/v5.5.18-beta/
>>
>> I'm about to setup the TCK tests, servlet and JSP, to validate 
against

>> it. In the meantime feel free to play around with it.
>>
>> Once we deem that it looks correct, we can setup a vote for it.
>>
>> Filip
>>
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Remy Maucherat]

Jean-frederic Clere wrote:

Yoav Shapira wrote:


Hi,
We need to clarify the message according to Bill's comments from a
thread on this list last week.  The message is still correct for some
users, especially those using Tomcat 4.1, JDK 1.4, and certain Linux
kernels.


It was for RH9 JDK1.4.0 and 1.3.1... Old stuff.
Look to http://linux-sxs.org/programming/ibm-java.html


I don't think it works better with JDK 1.5, actually. Many kernels from 
RH EL 3 (which is based on RH 9) have the issue, too. This flag will not 
impact performance in any measurable way on these systems, so IMO it 
should be used on these systems.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Jason Brittain]

Hi guys.

On 8/29/06, Yoav Shapira <[EMAIL PROTECTED]> wrote:


Hi,
We need to clarify the message according to Bill's comments from a
thread on this list last week.



Clarifying it would be preferable.

The message is still correct for some

users, especially those using Tomcat 4.1, JDK 1.4, and certain Linux
kernels.



Here's one data point on it..

Here is the setup that I used to run where I needed the setting:

OS: RH9 i386 with kernel 2.4.20-18.9 (stock RH kernel)
Java: Sun j2sdk1.4.1_03
Tomcat 4.1.30 (official release binary)

Then, later, I needed Java 1.5.x features, so I upgraded it to
Sun Java 1.5.0.  At the time that I upgraded just the JDK, I
knew very well that I have LD_ASSUME_KERNEL set, but I
since I didn't upgrade the OS (same kernel & libs) I left that
setting alone to see if it would cause any ill effects.  That was
a couple of years ago, and it has been working perfectly
ever since.

We should make it clear the message does not apply to all

situations, should not be standard operating procedure, and should
only be attempted if you have an older Linux kernel that you can't
update plus a stability problem that you can't solve otherwise.  Or
something to that effect...



Yes, that would be excellent.

Thanks.

--
Jason

Re: Tomcat 5.5.18-beta preview

[William A. Rowe, Jr.]

Jason Brittain wrote:
> 
> Then, later, I needed Java 1.5.x features, so I upgraded it to
> Sun Java 1.5.0.  At the time that I upgraded just the JDK, I
> knew very well that I have LD_ASSUME_KERNEL set, but I
> since I didn't upgrade the OS (same kernel & libs) I left that
> setting alone to see if it would cause any ill effects.  That was
> a couple of years ago, and it has been working perfectly
> ever since.

FYI we have consistent failures with Sun Java 1.5.0_06 using the older
LD_ASSUME_KERNEL choices where Sun Java 1.4.2_12 works just fine with them.

Buyer beware.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 5.5.18-beta preview

[Remy Maucherat]

William A. Rowe, Jr. wrote:

Jason Brittain wrote:

Then, later, I needed Java 1.5.x features, so I upgraded it to
Sun Java 1.5.0.  At the time that I upgraded just the JDK, I
knew very well that I have LD_ASSUME_KERNEL set, but I
since I didn't upgrade the OS (same kernel & libs) I left that
setting alone to see if it would cause any ill effects.  That was
a couple of years ago, and it has been working perfectly
ever since.


FYI we have consistent failures with Sun Java 1.5.0_06 using the older
LD_ASSUME_KERNEL choices where Sun Java 1.4.2_12 works just fine with them.


Ah, ok, so this is more complex than I thought then.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Improvement of Catalina ant task

[Didier Donsez]

Dear all

Catalina ant task  sets only one mbean attribute
My improvement proposes to set several attributes by using
 sun-elements
The MBeanServer.setAttributes(ObjectName name,AttributeList attributes)
method is used instead of the MBeanServer.setAttribute(ObjectName
name,Attribute attribute) method

Modified files are in attachment and modified and new code lines are
bracketed between // ADDED comments
My ICLA is signed and I'm a contributor of Felix (Apache incubated project).

Kind regards

Didier

PS: I hope to post this mail to the right mailing list ! I did not seen
Tomcat in https://issues.apache.org/jira/secure/BrowseProject.jspa

--
-
Didier DONSEZ
Laboratoire LSR, Institut Imag, Universite Joseph Fourier
Bat. C, 220 rue de la Chimie, Domaine Universitaire
BP 53, 38041 Grenoble Cedex 9, France
GPS : lat 45°11'38.3"N, lon 05°46'14.7"E, alt 223m
http://www-adele.imag.fr/users/Didier.Donsez/map/map.html
Tel : +33 4 76 63 55 49   Fax : +33 4 76 63 55 50
mailto:[EMAIL PROTECTED]
URL: http://www-adele.imag.fr/users/Didier.Donsez
-


/*
 * Copyright 2002,2004-2005 The Apache Software Foundation.
 * 
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 * 
 *  http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */


package org.apache.catalina.ant.jmx;


import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

import javax.management.Attribute;
import javax.management.AttributeList;
import javax.management.MBeanAttributeInfo;
import javax.management.MBeanInfo;
import javax.management.MBeanServerConnection;
import javax.management.ObjectName;

import org.apache.tools.ant.BuildException;


/**
 * Access JMX JSR 160 MBeans Server. 
 * 
 * Set Mbeans attributes
 * 
 * 
 * Examples:
 * Set a Mbean Manager attribute maxActiveSessions.
 * Set this attribute with fresh jmx connection without save reference 
 * 
 *   
 *   />
 * 
 *
 * or 
 * 
 * 
 *   
 *   >
 *   
 *
 *
 *   
 *
 * 
 * 
 * 
 * First call to a remote MBeanserver save the JMXConnection a referenz 
jmx.server
 * 
 * These tasks require Ant 1.6 or later interface.
 *
 * @author Peter Rossbach
 * @contributor Didier Donsez (add 
 * @version $Revision: 304089 $ $Date: 2005-09-14 09:28:29 -0400 (Wed, 14 Sep 
2005) $
 * @since 5.5.10
 */

public class JMXAccessorSetTask extends JMXAccessorTask {

// - Instance Variables

private String attribute;
private String value;
private String type;
private boolean convert = false ;

// ADDED BEGIN
private List attributes=new ArrayList();
// ADDED END



// - Instance Info

/**
 * Descriptive information describing this implementation.
 */
private static final String info = 
"org.apache.catalina.ant.JMXAccessorSetTask/1.0";

/**
 * Return descriptive information about this implementation and the
 * corresponding version number, in the format
 * /.
 */
public String getInfo() {

return (info);

}

// - Properties

// ADDED BEGIN
public void addAttribute(org.apache.catalina.ant.jmx.Attribute attribute) {
attributes.add(attribute);
}

public List getAttributes() {
return attributes;
}

// ADDED END


/**
 * @return Returns the attribute.
 */
public String getAttribute() {
return attribute;
}

/**
 * @param attribute The attribute to set.
 

DO NOT REPLY [Bug 31804] - setParent() is not called on nested tags in a tag file (.tagx)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31804


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |




--- Additional Comments From [EMAIL PROTECTED]  2006-08-29 23:24 ---
This isn't working correctly.  However I think the examples given so far have 
been incomplete.  I will try 
to give a full example.

Lets suppose we have two traditional custom tags, for this example I'm going to 
use the Spring 2.0 
form tag libraries as they are the ones that led me here.

The first tag is form:form tag, which sets up context to be accessed by nested 
tags via the setParent 
mechanism.

The second tag is form:label tag, which makes use of the context created by the 
form:form tag and only 
functions properly when nested within a form:form tag.

So we might have an example jsp as follows.

 
  hello


the generated java file for this jsp would invoke setParent(null) on the 
form:form tag and would invoke 
setParent([reference to the form tag]) on the label tag.  This would be correct.

Now let us assume that we create a tag file which makes use of the form:label 
tag because we tired of 
typing "Hello" everywhere.

Our tag file might look like this.

Hello

and our revised jsp page would look like this.


  


In this case the form:form tag would again get a setParent invoked with null, 
(still correct) and 
mycustomtag would get it's setParent invoked with the reference to the 
form:form tag, (also still 
correct), but the form:label tag inside of mycustomtag would get it's setParent 
method invoked with 
"null".  This is "Not Correct".  The label tag is nested inside of an outer tag 
and should have it's 
setParent method invoked with the reference to that outer tag.

Here is the logic I would propose for this section of code.

if (myParent == null) {
  // set parent of any top level tags used in tag file to null
} else {
  // set parent of any top level tags used in tag file to "this"
}


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40354] New: - jsp-examples webapp comes with old, broken standard.jar and/or jstl.jar

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40354

   Summary: jsp-examples webapp comes with old, broken standard.jar
and/or jstl.jar
   Product: Tomcat 5
   Version: 5.5.7
  Platform: Other
OS/Version: other
Status: NEW
  Severity: minor
  Priority: P2
 Component: Webapps:Examples
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I downloaded Tomcat 5.5.17 this morning and tried to run my app in it (we're
currently using resin). Found I needed to put standard.jar and jstl.jar in
common/lib. Searched for them and found that the jsp-examples webapp comes with
them, so I copied these into common/lib.

However, I immediately found that my jsps were broken due to all the c:url tags
getting an extra / at the beginning of the url (the app is running in the root
context).

I searched the web and tried lots of variations but finally went and got the
standard.jar and jstl.jar from my last project and the problem went away. I took
a look at the file times on the two versions of the jars and the ones that came
with tomcat are from 2003, whereas the ones I replaced them with are from 2004.

I'm not sure exactly what the problem was here -- old bug in jstl or what -- but
it seems like it would be simple enough to put the latest versions of those jars
in the jsp-examples webapp and avoid problems for anyone else.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40347] - Manager displays spurious contexts when multi-level context paths are used

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40347


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:00 ---
The handling of directories in a host's appBase has changed from 5.0.x to 5.5.x

This is a config issue. If you are going to deploy apps with a multi-level
context you need to do one of the following:
- disable autoDeploy and deployOnStartup
- set unpackWARs to false
- move the WAR file outside the host's appBase 

If you have further questions, please follow up on the users mailing list.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40354] - jsp-examples webapp comes with old, broken standard.jar and/or jstl.jar

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40354


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:01 ---
Well, the page generated correctly when I first copied the jars into the tomcat
common/lib directory, but now it's broken again. So, I apparently have some
other problem.

Sorry for the noise. Really wish I knew why it's doing this though... guess I
can't run this app in tomcat. :-(

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33262] - Service Manager autostart should check for administrative rights

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33262


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement
 OS/Version|Mac System 8.5  |Windows XP




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:08 ---
Guessing at correct OS. Since this is an enhancement, marking it as such.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33806] - Session tracking using URL rewriting fails, if client URL-encodes reserved characters ; and =

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33806


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:18 ---
The root cause of this is the same although the observed effects are very 
different.

I have tested using the servlet examples and the behaviour is now correct.

*** This bug has been marked as a duplicate of 36905 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36905] - Tomcat WebDAV characters bug

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36905


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:18 ---
*** Bug 33806 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36853] - https

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36853


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:35 ---


Works for me. This looks like a configuration issue. Please follow up on Tomcat
user.

BTW, I assume you mean port="443" rather than port="449"

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37054] - NoClassDefFoundError using ServletContextListener WITH CUSTOM LOADER

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37054


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:41 ---


*** This bug has been marked as a duplicate of 39704 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39704] - context with privileged="true" do not setup properly inner loaders

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39704


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:41 ---
*** Bug 37054 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39309] - tomcat can't compile big jsp, hitting a compiler limit

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39309


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:54 ---
This is an enhancement, marking it as such.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40335] - Sample of isapi_redirect.properties in the documentation is incomplete

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40335


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-08-30 03:56 ---
This is a bug in the connector code. This file should not be required. This has
alreday been fixed in SVN.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40356] New: - expressions in XML attributes evaluated in wrong order

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40356

   Summary: expressions in XML attributes evaluated in wrong order
   Product: Tomcat 5
   Version: 5.5.17
  Platform: All
OS/Version: All
Status: NEW
  Severity: minor
  Priority: P3
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I am trying to run an application that worked fine on Tomcat 4.1 and encounter
the following problem on Tomcat 5.5.

I have a JSP using a custom tag and which has expressions in its attributes:



I expect the expressions to be evaluated left to right: "last - s" is passed to
the first attribute, "last" to the second, and in the next line of code variable
"last" will have been increased by one.
This works fine on Tomcat 4.1. However, on Tomcat 5.5 it passed "last - s + 1"
to the first attribute.

I discovered the generated code for the JSP is different.
Tomcat 4.1:
_jspx_th_vsi_loop_2.setBegin(last - s);
_jspx_th_vsi_loop_2.setEnd(last++);

Tomcat 5.5:
_jspx_th_vsi_loop_2.setEnd(last++);
_jspx_th_vsi_loop_2.setBegin(last - s);

This JSP is a JSP Document (XML base), for a "normal" JSP the order has not
changed since Tomcat 4.1.

The following change seems to be the cause:
Before:
int len = attrs.getLength();
for (int i=0; i= 0; i--) {

Revision: 305679
Author: luehe
Date: 8:26:50, 2003年4月22日
Message:
Due to a bug in the underlying SAX parser, the XML attributes must be
enumerated in descending order. When enumerated in ascending order,
qName may be null, causing NPE. (This sucks!)

Modified :
/tomcat/jasper/trunk/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java

I could not find any more details, but I wonder if the bug in the underlying SAX
parser was that it returned attributes in opposite order and that this has been
fixed (breaking the order again). I don't know how the NPE fits in, though.

It seems this issue has been brought up in the Tomcat dev ML before, but
received no replies.
http://mail-archives.apache.org/mod_mbox/tomcat-dev/200402.mbox/[EMAIL 
PROTECTED]

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]