Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Henri Gomez

I'll make a build on our Linux PPC box and make some tests.

Stay tuned

BTW, a windows binary will be usefull also

2006/8/28, Rainer Jung <[EMAIL PROTECTED]>:


Hi all,

I applied some bigger changes to mod_jk. The result is available from
trunk, but also from

http://people.apache.org/~rjung/mod_jk-1.2.19-437488/

Under this URL you can also find the updated docs.

Since we need to decide, if we release Mladens Windows fixes from a
branch (not including most of my changes), or if we simply release from
trunk, I would appreciate any tests against trunk.

Feel free to send any observations.

The most important new features:

- Implement hierarchical worker configuration via attribute "reference".
- Load-Balancer: Combine different runtime states and configuration
states into one runtime state and one configuration state.
- Logging: pass interesting result info as Apache notes, especially for
load balancer
- Log use of deprecated properties
- All servers use same default log level INFO
- 40107: Rewrite is_socket_connected function. Non blocking socket is
not used any more.
- Connection no-reuse patch
- Make rewrite_rule_map and log_level as non mandatory directives for
isapi_redirect.
- Update GUI-handling for jk status worker forms; include auto-update.

Thanks for your valuable time!

Regards,

Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Mladen Turk

Henri Gomez wrote:

I'll make a build on our Linux PPC box and make some tests.

Stay tuned

BTW, a windows binary will be usefull also



I'll made them later today.
Rainer,
can you make some tomcat-connectors-1.2.19-dev.tar.gz?

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Henri Gomez

Build problem on SUSE SLES 9 PPC (Linux LPAR on an i5/OS)

powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker



checking for setsockopt in -lsocket... no
checking whether to use SO_RCVTIMEO with setsockopt()... yes
checking whether to use SO_SNDTIMEO with setsockopt()... yes
need to check for Perl first, apxs depends on it...
checking for perl... /usr/bin/perl
could not find /usr/sbin/apxs2-worker
configure: error: You must specify a valid --with-apxs path

This configure worked for previous version ;'(

2006/8/28, Henri Gomez <[EMAIL PROTECTED]>:


I'll make a build on our Linux PPC box and make some tests.

Stay tuned

BTW, a windows binary will be usefull also

2006/8/28, Rainer Jung < [EMAIL PROTECTED]>:

> Hi all,
>
> I applied some bigger changes to mod_jk. The result is available from
> trunk, but also from
>
> 
http://people.apache.org/~rjung/mod_jk-1.2.19-437488/
>
> Under this URL you can also find the updated docs.
>
> Since we need to decide, if we release Mladens Windows fixes from a
> branch (not including most of my changes), or if we simply release from
> trunk, I would appreciate any tests against trunk.
>
> Feel free to send any observations.
>
> The most important new features:
>
> - Implement hierarchical worker configuration via attribute "reference".
>
> - Load-Balancer: Combine different runtime states and configuration
> states into one runtime state and one configuration state.
> - Logging: pass interesting result info as Apache notes, especially for
> load balancer
> - Log use of deprecated properties
> - All servers use same default log level INFO
> - 40107: Rewrite is_socket_connected function. Non blocking socket is
> not used any more.
> - Connection no-reuse patch
> - Make rewrite_rule_map and log_level as non mandatory directives for
> isapi_redirect.
> - Update GUI-handling for jk status worker forms; include auto-update.
>
> Thanks for your valuable time!
>
> Regards,
>
> Rainer
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Rainer Jung

Hi Henri,

there were no changes in configure between 1.2.18 and 1.2.19. The 
message occurs, if


/usr/sbin/apxs2-worker -q PREFIX

doesn't work. Could you please try that?

I used the version on Solaris Sparc and 32Bit and 64Bit Linux and it 
seems very strange to me, that there should be a problem during 
configure. At least not a problem, that is new since 1.2.18.


Thanks!

Regards,

Rainer

Henri Gomez wrote:

Build problem on SUSE SLES 9 PPC (Linux LPAR on an i5/OS)

powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker



checking for setsockopt in -lsocket... no
checking whether to use SO_RCVTIMEO with setsockopt()... yes
checking whether to use SO_SNDTIMEO with setsockopt()... yes
need to check for Perl first, apxs depends on it...
checking for perl... /usr/bin/perl
could not find /usr/sbin/apxs2-worker
configure: error: You must specify a valid --with-apxs path

This configure worked for previous version ;'(

2006/8/28, Henri Gomez <[EMAIL PROTECTED]>:



I'll make a build on our Linux PPC box and make some tests.

Stay tuned

BTW, a windows binary will be usefull also

2006/8/28, Rainer Jung < [EMAIL PROTECTED]>:

> Hi all,
>
> I applied some bigger changes to mod_jk. The result is available from
> trunk, but also from
>
> 
http://people.apache.org/~rjung/mod_jk-1.2.19-437488/ 


>
> Under this URL you can also find the updated docs.
>
> Since we need to decide, if we release Mladens Windows fixes from a
> branch (not including most of my changes), or if we simply release from
> trunk, I would appreciate any tests against trunk.
>
> Feel free to send any observations.
>
> The most important new features:
>
> - Implement hierarchical worker configuration via attribute 
"reference".

>
> - Load-Balancer: Combine different runtime states and configuration
> states into one runtime state and one configuration state.
> - Logging: pass interesting result info as Apache notes, especially for
> load balancer
> - Log use of deprecated properties
> - All servers use same default log level INFO
> - 40107: Rewrite is_socket_connected function. Non blocking socket is
> not used any more.
> - Connection no-reuse patch
> - Make rewrite_rule_map and log_level as non mandatory directives for
> isapi_redirect.
> - Update GUI-handling for jk status worker forms; include auto-update.
>
> Thanks for your valuable time!
>
> Regards,
>
> Rainer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Rainer Jung

Mladen Turk wrote:

Rainer,
can you make some tomcat-connectors-1.2.19-dev.tar.gz?

Regards,
Mladen.


Hi Mladen,

isn't that what's under

http://people.apache.org/~rjung/mod_jk-1.2.19-437488/

The numver is the subversion revision. The contents are 1.2.19-dev with 
everything like in the release tarball.


I don't want to make it available under /dev/dist, since it's a little 
early. If a couple of people give a little feedback, I would feel more 
comfortable.


By the way: I added the final parts of logging for deprecated 
directives, that you started. I think we should now put all the 
deprecated ones (*chache*, balance_workers etc.) in the list? It will 
give users a good feedback about changes they should apply to their 
configuration, without breaking it.


Regards,

Rrainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Henri Gomez

Well /usr/sbin/apxs2-worker -q PREFIX didn't works (tried previously) and
got :

:~/tomcat-connectors-1.2.19-437488-src/native # /usr/sbin/apxs2-worker
-q PREFIX
apxs:Error: /usr/sbin/httpd2-worker not found or not executable.

It works with apxs2-prefork :

:~/tomcat-connectors-1.2.19-437488-src/native # /usr/sbin/apxs2-prefork
-q PREFIX
/srv/www

Strange, but build and tested in prefork mode, the 1.2.19 seems to works.

2006/8/28, Rainer Jung <[EMAIL PROTECTED]>:


Hi Henri,

there were no changes in configure between 1.2.18 and 1.2.19. The
message occurs, if

/usr/sbin/apxs2-worker -q PREFIX

doesn't work. Could you please try that?

I used the version on Solaris Sparc and 32Bit and 64Bit Linux and it
seems very strange to me, that there should be a problem during
configure. At least not a problem, that is new since 1.2.18.

Thanks!

Regards,

Rainer

Henri Gomez wrote:
> Build problem on SUSE SLES 9 PPC (Linux LPAR on an i5/OS)
>
> powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker
>
> 
>
> checking for setsockopt in -lsocket... no
> checking whether to use SO_RCVTIMEO with setsockopt()... yes
> checking whether to use SO_SNDTIMEO with setsockopt()... yes
> need to check for Perl first, apxs depends on it...
> checking for perl... /usr/bin/perl
> could not find /usr/sbin/apxs2-worker
> configure: error: You must specify a valid --with-apxs path
>
> This configure worked for previous version ;'(
>
> 2006/8/28, Henri Gomez <[EMAIL PROTECTED]>:
>
>>
>> I'll make a build on our Linux PPC box and make some tests.
>>
>> Stay tuned
>>
>> BTW, a windows binary will be usefull also
>>
>> 2006/8/28, Rainer Jung < [EMAIL PROTECTED]>:
>>
>> > Hi all,
>> >
>> > I applied some bigger changes to mod_jk. The result is available from
>> > trunk, but also from
>> >
>> >
>> http://people.apache.org/~rjung/mod_jk-1.2.19-437488/<
http://people.apache.org/%7Erjung/mod_jk-1.2.19-437488/>
>>
>> >
>> > Under this URL you can also find the updated docs.
>> >
>> > Since we need to decide, if we release Mladens Windows fixes from a
>> > branch (not including most of my changes), or if we simply release
from
>> > trunk, I would appreciate any tests against trunk.
>> >
>> > Feel free to send any observations.
>> >
>> > The most important new features:
>> >
>> > - Implement hierarchical worker configuration via attribute
>> "reference".
>> >
>> > - Load-Balancer: Combine different runtime states and configuration
>> > states into one runtime state and one configuration state.
>> > - Logging: pass interesting result info as Apache notes, especially
for
>> > load balancer
>> > - Log use of deprecated properties
>> > - All servers use same default log level INFO
>> > - 40107: Rewrite is_socket_connected function. Non blocking socket is
>> > not used any more.
>> > - Connection no-reuse patch
>> > - Make rewrite_rule_map and log_level as non mandatory directives for
>> > isapi_redirect.
>> > - Update GUI-handling for jk status worker forms; include
auto-update.
>> >
>> > Thanks for your valuable time!
>> >
>> > Regards,
>> >
>> > Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Mladen Turk

Rainer Jung wrote:


I don't want to make it available under /dev/dist, since it's a little 
early. If a couple of people give a little feedback, I would feel more 
comfortable.




You can put tarball inside your http://people.apache.org/~rjung/
It's much easier to handle tarball then doing svn co for each platform.


By the way: I added the final parts of logging for deprecated 
directives, that you started. I think we should now put all the 
deprecated ones (*chache*, balance_workers etc.) in the list? It will 
give users a good feedback about changes they should apply to their 
configuration, without breaking it.




Sure.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36976] - Tomcat VM does not shutdown with remote jmx enabled

2006-08-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36976





--- Additional Comments From [EMAIL PROTECTED]  2006-08-28 09:19 ---
Tomcat does not shutdown properly.
It does not call the destroy method of the servelet that start on startup of 
tomcat.

Please verify

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40306] - mod_jk, POST request bodies are not restored on successful login when using mod_jk

2006-08-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40306





--- Additional Comments From [EMAIL PROTECTED]  2006-08-28 09:21 ---
No, to be consistent with the HTTP connector, it should be
setContentLength(bc.getLength()). In practice, it won't make much difference, I
think, but you never know.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r437620 - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/ajp/AjpAprProcessor.java coyote/ajp/AjpProcessor.java jk/core/MsgContext.java

2006-08-28 Thread remm
Author: remm
Date: Mon Aug 28 02:26:51 2006
New Revision: 437620

URL: http://svn.apache.org/viewvc?rev=437620&view=rev
Log:
- Adjust content length fix so that it does the same as for the HTTP connector.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/jk/core/MsgContext.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=437620&r1=437619&r2=437620&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Mon 
Aug 28 02:26:51 2006
@@ -571,9 +571,9 @@
 } else if (actionCode == ActionCode.ACTION_REQ_SET_BODY_REPLAY) {
 
 // Set the given bytes as the content
-request.setContentLength(-1); // reset content length
 ByteChunk bc = (ByteChunk) param;
 bodyBytes.setBytes(bc.getBytes(), bc.getStart(), bc.getLength());
+request.setContentLength(bc.getLength());
 first = false;
 empty = false;
 replay = true;

Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=437620&r1=437619&r2=437620&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Mon Aug 
28 02:26:51 2006
@@ -543,6 +543,7 @@
 // Set the given bytes as the content
 ByteChunk bc = (ByteChunk) param;
 bodyBytes.setBytes(bc.getBytes(), bc.getStart(), bc.getLength());
+request.setContentLength(bc.getLength());
 first = false;
 empty = false;
 replay = true;

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jk/core/MsgContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jk/core/MsgContext.java?rev=437620&r1=437619&r2=437620&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jk/core/MsgContext.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jk/core/MsgContext.java Mon Aug 28 
02:26:51 2006
@@ -351,8 +351,8 @@
 } else if ( actionCode == ActionCode.ACTION_REQ_SET_BODY_REPLAY ) {
 if( log.isTraceEnabled() )
 log.trace("Replay ");
-req.setContentLength(-1); // reset content length
 ByteChunk bc = (ByteChunk)param;
+req.setContentLength(bc.getLength());
 jkIS.setReplay(bc);
 }
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Rainer Jung

Mladen Turk wrote:



You can put tarball inside your http://people.apache.org/~rjung/
It's much easier to handle tarball then doing svn co for each platform.


Somehow I don't get the problem: the tarball was already on 
people.apache.org when I sent the original message. It's in the 
directory I gave with a URL. The full URL is


http://people.apache.org/~rjung/mod_jk-1.2.19-437488/tomcat-connectors-1.2.19-437488-src.tar.gz

Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release Tomcat 4.1.34 as beta

2006-08-28 Thread Remy Maucherat

Mark Thomas wrote:

All,

Please vote on releasing Apache Tomcat 4.1.34 as beta.

Download from:
http://tomcat.apache.org/dev/dist/

MD5s:
apache-tomcat-4.1.34-src.tar.gz  3c6aaa47279a33d8e256af620ddaac9b

The vote will run for approximately 72 hours.

If this VOTE passes, a stability vote will be held a suitable period
(at least 2 weeks) after the beta release.


+1.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r433689 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina: core/ApplicationContext.java session/StandardSession.java

2006-08-28 Thread Remy Maucherat

Filip Hanik - Dev Lists wrote:

Remy Maucherat wrote:

[EMAIL PROTECTED] wrote:

Author: fhanik
Date: Tue Aug 22 09:52:29 2006
New Revision: 433689

URL: http://svn.apache.org/viewvc?rev=433689&view=rev
Log:
Prepare for cluster integration


I like that, thanks. BTW, I thought you were planning to use a 
separate module for the source.
separate package works easier, and we become consistent across the 
platform.


Of course.

So the only remaining item to release a build for testing from the 6.0 
branch is to finalize the comet API.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release Tomcat 4.1.34 as beta

2006-08-28 Thread Yoav Shapira

+1.

Yoav

On 8/27/06, Mark Thomas <[EMAIL PROTECTED]> wrote:

All,

Please vote on releasing Apache Tomcat 4.1.34 as beta.

Download from:
http://tomcat.apache.org/dev/dist/

MD5s:
apache-tomcat-4.1.34-src.tar.gz  3c6aaa47279a33d8e256af620ddaac9b

The vote will run for approximately 72 hours.

If this VOTE passes, a stability vote will be held a suitable period
(at least 2 weeks) after the beta release.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r437686 - /tomcat/connectors/trunk/jk/xdocs/config/apache.xml

2006-08-28 Thread jim
Author: jim
Date: Mon Aug 28 05:22:21 2006
New Revision: 437686

URL: http://svn.apache.org/viewvc?rev=437686&view=rev
Log:
Note that FlushPackets can be a real performance dog. Provide a
little more detail on what it actually does and why.

Modified:
tomcat/connectors/trunk/jk/xdocs/config/apache.xml

Modified: tomcat/connectors/trunk/jk/xdocs/config/apache.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/config/apache.xml?rev=437686&r1=437685&r2=437686&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/config/apache.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/config/apache.xml Mon Aug 28 05:22:21 2006
@@ -363,8 +363,11 @@
 
 
 
-JkOptions FlushPackets, you ask mod_jk to make a flush after each AJP
-packet received from Tomcat.
+JkOptions FlushPackets, you ask mod_jk to flush Apache's connection
+buffer after each AJP packet chunk received from Tomcat. This option can have
+a strong performance penalty for Apache and Tomcat as writes are performed
+more often than would normally be required (ie: at the end of each
+response).
 
   
   JkOptions +FlushPackets



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40335] New: - Sample of isapi_redirect.properties in the documentation is incomplete

2006-08-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40335

   Summary: Sample of isapi_redirect.properties in the documentation
is incomplete
   Product: Tomcat 5
   Version: Unknown
  Platform: Other
   URL: http://tomcat.apache.org/connectors-doc/config/iis.html
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:JK
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


The sample properties file in the in the above URL don't have the obligatory 
parameter  "rewrite_rule_file" , if a  user  copies this  file and adjust the
parameter listed, the connector don't initialize correctly.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r437717 - /tomcat/container/branches/tc5.0.x/catalina/src/share/org/apache/naming/resources/ResourceCache.java

2006-08-28 Thread fhanik
Author: fhanik
Date: Mon Aug 28 07:45:53 2006
New Revision: 437717

URL: http://svn.apache.org/viewvc?rev=437717&view=rev
Log:
Fixed resource cache array index out of bounds exception, bug 40170

Modified:

tomcat/container/branches/tc5.0.x/catalina/src/share/org/apache/naming/resources/ResourceCache.java

Modified: 
tomcat/container/branches/tc5.0.x/catalina/src/share/org/apache/naming/resources/ResourceCache.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/branches/tc5.0.x/catalina/src/share/org/apache/naming/resources/ResourceCache.java?rev=437717&r1=437716&r2=437717&view=diff
==
--- 
tomcat/container/branches/tc5.0.x/catalina/src/share/org/apache/naming/resources/ResourceCache.java
 (original)
+++ 
tomcat/container/branches/tc5.0.x/catalina/src/share/org/apache/naming/resources/ResourceCache.java
 Mon Aug 28 07:45:53 2006
@@ -283,10 +283,11 @@
 public CacheEntry lookup(String name) {
 
 CacheEntry cacheEntry = null;
+CacheEntry[] currentCache = cache;
 accessCount++;
-int pos = find(cache, name);
-if ((pos != -1) && (name.equals(cache[pos].name))) {
-cacheEntry = cache[pos];
+int pos = find(currentCache, name);
+if ((pos != -1) && (name.equals(currentCache[pos].name))) {
+cacheEntry = currentCache[pos];
 }
 if (cacheEntry == null) {
 try {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 40170] - ArrayIndexOutOfBoundsException in ResourceCache

2006-08-28 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40170





--- Additional Comments From [EMAIL PROTECTED]  2006-08-28 14:43 ---
Fixed in 5.0 as well.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tomcat 5.5.18-beta preview

2006-08-28 Thread Filip Hanik - Dev Lists

I have created a 5.5.18 distribution located at
http://people.apache.org/~fhanik/v5.5.18-beta/

I'm about to setup the TCK tests, servlet and JSP, to validate against 
it. In the meantime feel free to play around with it.


Once we deem that it looks correct, we can setup a vote for it.

Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 5.5.18-beta preview

2006-08-28 Thread Yoav Shapira

Hi,
Cool.  The directory structure and signatures look good.  We need to
update the release notes
(http://people.apache.org/~fhanik/v5.5.18-beta/RELEASE-NOTES) to
remove the LD_ASSUME_KERNEL section on Linux, as Bill (IIRC) pointed
out the day.

Yoav

On 8/28/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:

I have created a 5.5.18 distribution located at
http://people.apache.org/~fhanik/v5.5.18-beta/

I'm about to setup the TCK tests, servlet and JSP, to validate against
it. In the meantime feel free to play around with it.

Once we deem that it looks correct, we can setup a vote for it.

Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat 5.5.18-beta preview

2006-08-28 Thread Filip Hanik - Dev Lists
great, I will let the feedback gather up a little bit, (waiting for the 
TCK tests to complete)

then make the adjustments

Filip

Yoav Shapira wrote:

Hi,
Cool.  The directory structure and signatures look good.  We need to
update the release notes
(http://people.apache.org/~fhanik/v5.5.18-beta/RELEASE-NOTES) to
remove the LD_ASSUME_KERNEL section on Linux, as Bill (IIRC) pointed
out the day.

Yoav

On 8/28/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:

I have created a 5.5.18 distribution located at
http://people.apache.org/~fhanik/v5.5.18-beta/

I'm about to setup the TCK tests, servlet and JSP, to validate against
it. In the meantime feel free to play around with it.

Once we deem that it looks correct, we can setup a vote for it.

Filip


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Quality check mod_jk 1.2.19-dev

2006-08-28 Thread Jim Jagielski


On Aug 28, 2006, at 4:22 AM, Henri Gomez wrote:


Build problem on SUSE SLES 9 PPC (Linux LPAR on an i5/OS)

powerpc32 ./configure --with-apxs=/usr/sbin/apxs2-worker



checking for setsockopt in -lsocket... no
checking whether to use SO_RCVTIMEO with setsockopt()... yes
checking whether to use SO_SNDTIMEO with setsockopt()... yes
need to check for Perl first, apxs depends on it...
checking for perl... /usr/bin/perl
could not find /usr/sbin/apxs2-worker
configure: error: You must specify a valid --with-apxs path

This configure worked for previous version ;'(



What does 'ls -l usr/sbin/apxs2-worker' say?


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release Tomcat 4.1.34 as beta

2006-08-28 Thread Jim Jagielski

+1

On Aug 28, 2006, at 7:14 AM, Yoav Shapira wrote:


+1.

Yoav

On 8/27/06, Mark Thomas <[EMAIL PROTECTED]> wrote:

All,

Please vote on releasing Apache Tomcat 4.1.34 as beta.

Download from:
http://tomcat.apache.org/dev/dist/

MD5s:
apache-tomcat-4.1.34-src.tar.gz  3c6aaa47279a33d8e256af620ddaac9b

The vote will run for approximately 72 hours.

If this VOTE passes, a stability vote will be held a suitable period
(at least 2 weeks) after the beta release.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



TCK Failed Was: Tomcat 5.5.18-beta preview

2006-08-28 Thread Filip Hanik - Dev Lists
Looks like the TCK is expecting a IOException, and not a runtime jasper 
exception when you have invalid TLD files is one of the errors.



---
Test FAILED.  Exception thrown by forwardedresource, but was not an 
instance of IOException

Type thrown: org.apache.jasper.JasperException
---
ERROR: Exception at:
ERROR: com.sun.ts.tests.common.webclient.TestFailureException: Test FAILED!
   at 
com.sun.ts.tests.common.webclient.WebTestCase.execute(WebTestCase.java:168)
   at 
com.sun.ts.tests.common.webclient.BaseUrlClient.invoke(BaseUrlClient.java:378)
   at 
com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.pageContextForwardIOExceptionTest(URLClient.java:166)

   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

   at java.lang.reflect.Method.invoke(Method.java:324)
   at com.sun.ts.lib.harness.EETest.run(EETest.java:473)
   at com.sun.ts.lib.harness.EETest.getPropsReady(EETest.java:370)
   at com.sun.ts.lib.harness.EETest.run(EETest.java:229)
   at 
com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.main(URLClient.java:26)


---
java.lang.RuntimeException: org.apache.jasper.JasperException: 
/WEB-INF/tags/negativeFragmentRtexprvalue.tag(6,1) Cannot
specify both 'fragment' and 'type' attributes.  If 'fragment' is 
present, 'type' is fixed as 'javax.servlet.jsp.tagext.

JspFragment'
   at 
org.apache.jasper.compiler.ImplicitTagLibraryInfo.getTagFile(ImplicitTagLibraryInfo.java:129)
   at 
org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1315)

   at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1573)
   at org.apache.jasper.compiler.Parser.parse(Parser.java:126)
   at 
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:211)
   at 
org.apache.jasper.compiler.ParserController.parse(ParserController.java:100)
   at 
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:155)

   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:295)
   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:276)
   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:264)
   at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:563)
   at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:305)
   at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)

   at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
   at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
   at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
   at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
   at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
   at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
   at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
   at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
   at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
   at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
   at 
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java

:664)
   at 
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
   at 
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
   at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)

   at java.lang.Thread.run(Thread.java:595)
java.lang.RuntimeException: org.apache.jasper.JasperException: 
/WEB-INF/tags/negativeFragmentType.tag(6,1) Cannot specif
y both 'fragment' and 'type' attributes.  If 'fragment' is present, 
'type' is fixed as 'javax.servlet.jsp.tagext.JspFrag

ment'
   at 
org.apache.jasper.compiler.ImplicitTagLibraryInfo.getTagFile(ImplicitTagLibraryInfo.java:129)
   at 
org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1315)

   at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1573)
   at org.apache.jasper.compiler.Parser.parse(Parser.java:126)
   at 
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:211)
   at 
org.apache.jasper.compiler.ParserController.parse(ParserController.java:100)
   at 
org.apache.jasper.compiler.Compiler.generateJava(Compile

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

2006-08-28 Thread Filip Hanik - Dev Lists

in hindsight I think its ok to let these slip

filip

Filip Hanik - Dev Lists wrote:
Looks like the TCK is expecting a IOException, and not a runtime 
jasper exception when you have invalid TLD files is one of the errors.



---
Test FAILED.  Exception thrown by forwardedresource, but was not an 
instance of IOException

Type thrown: org.apache.jasper.JasperException
---
ERROR: Exception at:
ERROR: com.sun.ts.tests.common.webclient.TestFailureException: Test 
FAILED!
   at 
com.sun.ts.tests.common.webclient.WebTestCase.execute(WebTestCase.java:168) 

   at 
com.sun.ts.tests.common.webclient.BaseUrlClient.invoke(BaseUrlClient.java:378) 

   at 
com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.pageContextForwardIOExceptionTest(URLClient.java:166) 


   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) 

   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 


   at java.lang.reflect.Method.invoke(Method.java:324)
   at com.sun.ts.lib.harness.EETest.run(EETest.java:473)
   at com.sun.ts.lib.harness.EETest.getPropsReady(EETest.java:370)
   at com.sun.ts.lib.harness.EETest.run(EETest.java:229)
   at 
com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.main(URLClient.java:26) 



---
java.lang.RuntimeException: org.apache.jasper.JasperException: 
/WEB-INF/tags/negativeFragmentRtexprvalue.tag(6,1) Cannot
specify both 'fragment' and 'type' attributes.  If 'fragment' is 
present, 'type' is fixed as 'javax.servlet.jsp.tagext.

JspFragment'
   at 
org.apache.jasper.compiler.ImplicitTagLibraryInfo.getTagFile(ImplicitTagLibraryInfo.java:129) 

   at 
org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1315)
   at 
org.apache.jasper.compiler.Parser.parseElements(Parser.java:1573)

   at org.apache.jasper.compiler.Parser.parse(Parser.java:126)
   at 
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:211) 

   at 
org.apache.jasper.compiler.ParserController.parse(ParserController.java:100) 

   at 
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:155)

   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:295)
   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:276)
   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:264)
   at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:563) 

   at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:305) 

   at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
   at 
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)

   at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
   at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) 

   at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) 

   at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) 

   at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) 

   at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) 

   at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) 

   at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) 

   at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) 

   at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) 

   at 
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java 


:664)
   at 
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) 

   at 
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) 

   at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) 


   at java.lang.Thread.run(Thread.java:595)
java.lang.RuntimeException: org.apache.jasper.JasperException: 
/WEB-INF/tags/negativeFragmentType.tag(6,1) Cannot specif
y both 'fragment' and 'type' attributes.  If 'fragment' is present, 
'type' is fixed as 'javax.servlet.jsp.tagext.JspFrag

ment'
   at 
org.apache.jasper.compiler.ImplicitTagLibraryInfo.getTagFile(ImplicitTagLibraryInfo.java:129) 

   at 
org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1315)
   at 
org.apache.jasper.compiler.Parser.parseElements(Parser.java:1573)

   at org.apache.jasper.compiler.Parser.parse(Parser.java:126)
   at 
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:211) 

   at 
or

Re: TCK Failed Was: Tomcat 5.5.18-beta preview

2006-08-28 Thread Remy Maucherat

Filip Hanik - Dev Lists wrote:

in hindsight I think its ok to let these slip


Probably. The first thing to check is if it's required somewhere in the 
specification for that (and if it's required, well ... lol). The main 
problem is that IOE is a checked exception, so there's a throws clause 
which would trickle down quite a bit in the code.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: TCK Failed Was: Tomcat 5.5.18-beta preview

2006-08-28 Thread Dies Koper

Hello Filip,

In my application I used a pageContext.include which once threw a 
JasperException (ServletException) while it was supposed to (according 
to the spec) propagate the IOException as-is.
I noticed that setting the "deployment" init param in conf\web.xml to 
"false" made it propagate the IOException correctly.


Apparently JspServletWrapper checks this flag and decides to handle 
exceptions differently depending on this value.
I did not look further into it as my problem is resolved, but I have 
been wondering why it would do this and whether to bring it up here.


Regards,
Dies

Filip Hanik - Dev Lists wrote:
Looks like the TCK is expecting a IOException, and not a runtime jasper 
exception when you have invalid TLD files is one of the errors.



---
Test FAILED.  Exception thrown by forwardedresource, but was not an 
instance of IOException

Type thrown: org.apache.jasper.JasperException
---
ERROR: Exception at:
ERROR: com.sun.ts.tests.common.webclient.TestFailureException: Test FAILED!
   at 
com.sun.ts.tests.common.webclient.WebTestCase.execute(WebTestCase.java:168)
   at 
com.sun.ts.tests.common.webclient.BaseUrlClient.invoke(BaseUrlClient.java:378) 

   at 
com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.pageContextForwardIOExceptionTest(URLClient.java:166) 


   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) 

   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 


   at java.lang.reflect.Method.invoke(Method.java:324)
   at com.sun.ts.lib.harness.EETest.run(EETest.java:473)
   at com.sun.ts.lib.harness.EETest.getPropsReady(EETest.java:370)
   at com.sun.ts.lib.harness.EETest.run(EETest.java:229)
   at 
com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.main(URLClient.java:26) 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: stale RELEASE-NOTES commentary

2006-08-28 Thread Jason Brittain

On 8/23/06, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote:


Yoav Shapira wrote:
> Hi,
> It's not only in the 4.1.31 release, it's even in the latest stable
> 5.5.17.  Let's change it in the next releases of 4.x and 5.x, starting
> with 5.5.18 which should happen any day now.
>
> I think the advice was decent (and based on empirical evidence IIRC)
> when originally issued, but that was more than two years ago, and it's
> now stale or worse.

Worse.  That's the trouble with LD_ASSUME_KERNEL, it's a bandaid that
gets gross and crusty when left on too long :)



I agree that this is a bandaid that isn't real pleasant, and I agree that
people
should upgrade either to a better working JVM or a newer kernel so they do
not have to deal with this situation.  However, not everyone can do that.
Regardless, setting LD_ASSUME_KERNEL like this is the only known way
for Tomcat to stay running with that kind of set up.  Without it, Tomcat
starts,
appears to serve pages fine for a while, and eventually locks up, probably
due to the JVM locking up.

If something isn't said in the release notes about this, users in this
situation
will end up with a locked up Tomcat and they won't know why.

As one data point on whether this is a helpful option or not, I have been
running Tomcat 4.1 on my server for around 4 years now with the option
set, and it has been perfectly stable.  Without the option set, Tomcat locks
up within 1 day, and sometimes within hours.



When I suggested we point
to README, I ment their corresponding VM's readme, not ours; let the VM
vendor lead or mislead our users and not take ownership of VM quirks.



By at least mentioning that there is a potential for lock up, you don't take
any ownership of the bandaid.  Also, by mentioning that in some cases one
can set that particular option with no ill effects, and that the user's
mileage
may vary, at least they have the option to try it, instead of having to
restart
their Tomcat at least once a day and wonder why they have to.

Thanks.

--
Jason