Re: svn commit: r423967 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[Jean-frederic Clere]

William A. Rowe, Jr. wrote:


Remy Maucherat wrote:


William A. Rowe, Jr. wrote:

Guys, let me clarify, you are only paying attention to ';' following 
the

QUERY_STRING delimiter '?', correct?

';' means nothing special before the '?', double check your 
interpretation
of RFC 2616.  I can have /foo.bar;bash?v1=a;v2=b (or ...?v1=a&v2=b) 
and that

semi is part of the foo.bar;bash filename.  Right?



No. We talked about it before. ";" is a reserved character (and since 
there's no document describing mapping of the thing, I am removing 
the portion of the URL after it).



Dude, there is, it's called RFC2396 and you can read my other note, 
just sent,

for a lengthy description ;-)


Returning to my example:
kMount /*.jsp worker1
http://localhost/;jsp-examples/jsp2/;simpletag/;hello.jsp

.jsp-examples simpletag and hello.jsp are parameters. (According to the 
3.3 of the ref).

So the mapping is
//jsp2// -> no worker.
http://localhost/jsp-examples;.titi/jsp2/simpletag;toto/hello.jsp;tutu
.titi toto and tutu are parameters.
And the mapping is:
/jsp-examples/jsp2/simpletag/hello.jsp match worker1

Comments?

Cheers

Jean-Frederic



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r423967 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[William A. Rowe, Jr.]

Jean-frederic Clere wrote:


Returning to my example:
JkMount /*.jsp worker1
http://localhost/;jsp-examples/jsp2/;simpletag/;hello.jsp

.jsp-examples simpletag and hello.jsp are parameters. (According to the 
3.3 of the ref).

So the mapping is
//jsp2// -> no worker.


I would concur...


http://localhost/jsp-examples;.titi/jsp2/simpletag;toto/hello.jsp;tutu
.titi toto and tutu are parameters.
And the mapping is:
/jsp-examples/jsp2/simpletag/hello.jsp match worker1


I'm a little hesitant.  I almost assure you that the typical configuration
is broken in this case, various  blocks, etc won't apply and
the administrator will be "surprised" by the results.

With that said, I'll add that I've always detested this particular mounting
semantic, since it was never really guarenteed that it would coincide with
the appropriate apache-side configuration directives, and so with that,
I'd say stay with your patch :)

Bill


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 08:34 ---
Created an attachment (id=18620)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18620&action=view)
JSP Page Test Buggy


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|NEW




--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 08:38 ---
And another "me too", We're also unable to compile a simple JSP because Javac
Compiler generates strange Generic compilation problem with Tomcat 5.5.17.

org.apache.jasper.JasperException: Impossible de compiler la classe pour la JSP

Une erreur s'est produite à la ligne: 2 dans le fichier jsp: /test.jsp
Erreur de servlet générée:
The type Map is not generic; it cannot be parameterized with arguments 

With JSP generation using JAR files of Jasper (located in common/lib of Tomcat)
5.5.9, it works correctly.

I provided attached JSP which cannot compile, and Java generated files, with
5.5.9 and 5.5.17

Output of JSP with 5.5.9 is :

Result is : Hop
(normal output)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 08:39 ---
Created an attachment (id=18621)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18621&action=view)
Generated Java file with 5.5.17 Jasper


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 08:39 ---
Created an attachment (id=18622)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18622&action=view)
Generated Java file with 5.5.9 Jasper (the one which works)


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 08:52 ---
You JSP works for me with TC 5.5.17/Java 1.5.0_06 (Solaris Sparc):

Result is :
Hop

No errors or other strangeness.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cluster SimpleTcpCluster in 5.5.17

[Jean-frederic Clere]

Hi,

I have trying to get the SimpleTcpCluster running but I only get:
+++
INFO: Replication member 
added:org.apache.catalina.cluster.mcast.McastMember[tcp://192.168.4.88:4001,catalina,192.168.4.88,4001, 
alive=5006428]
Jul 20, 2006 6:50:46 PM org.apache.catalina.cluster.tcp.SimpleTcpCluster 
memberDisappeared
INFO: Received member 
disappeared:org.apache.catalina.cluster.mcast.McastMember[tcp://192.168.4.88:4001,catalina,192.168.4.88,4001, 
alive=5006428]
Jul 20, 2006 6:52:48 PM org.apache.catalina.cluster.tcp.SimpleTcpCluster 
memberAdded

+++

Any hints?

Cheers

Jean-Frederic







  
  
  
  
  

  
  







  

  

  
  






	
	













 
 



  
  

  

  
  

  
  

  

  

  

  

  
  

  

 











   

  














  



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r423967 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[Remy Maucherat]

Jean-frederic Clere wrote:

Returning to my example:
kMount /*.jsp worker1
http://localhost/;jsp-examples/jsp2/;simpletag/;hello.jsp

.jsp-examples simpletag and hello.jsp are parameters. (According to the 
3.3 of the ref).

So the mapping is
//jsp2// -> no worker.
http://localhost/jsp-examples;.titi/jsp2/simpletag;toto/hello.jsp;tutu
.titi toto and tutu are parameters.
And the mapping is:
/jsp-examples/jsp2/simpletag/hello.jsp match worker1

Comments?


Another tactic is to give up, and return an error code of some sort in 
Tomcat if the URL contains a path parameter (since they are not part of 
the path, are not handled properly, and have no useful usage at the moment).


The latest RFC (3986) gives an interesting example of usage: For 
example, one URI producer might use a segment such as "name;v=1.1" to 
indicate a reference to version 1.1 of "name".


Personally, I dislike the "optimized" mappings, like *.jsp, that in the 
end make the webapp non portable and full of security holes. I think 
full webapp mappings are preferable (and for static resources that 
"need" to be served by Apache, it still seems possible to me to use 
relative URLs to them - as if they were in a separate webapp).


Rémy


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424265 - /tomcat/connectors/trunk/jk/native/common/jk_global.h

[mturk]

Author: mturk
Date: Fri Jul 21 04:08:16 2006
New Revision: 424265

URL: http://svn.apache.org/viewvc?rev=424265&view=rev
Log:
Add VStudio 2005 compile flags. Copied from apr.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_global.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?rev=424265&r1=424264&r2=424265&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Jul 21 04:08:16 
2006
@@ -33,6 +33,37 @@
 #endif
 #endif
 
+#if defined(WIN32)
+
+/* Ignore most warnings (back down to /W3) for poorly constructed headers
+ */
+#if defined(_MSC_VER) && _MSC_VER >= 1200
+#pragma warning(push, 3)
+#endif
+
+/* disable or reduce the frequency of...
+ *   C4057: indirection to slightly different base types
+ *   C4075: slight indirection changes (unsigned short* vs short[])
+ *   C4100: unreferenced formal parameter
+ *   C4127: conditional expression is constant
+ *   C4163: '_rotl64' : not available as an intrinsic function
+ *   C4201: nonstandard extension nameless struct/unions
+ *   C4244: int to char/short - precision loss
+ *   C4514: unreferenced inline function removed
+ */
+#pragma warning(disable: 4100 4127 4163 4201 4514; once: 4057 4075 4244)
+
+/* Ignore Microsoft's interpretation of secure development
+ * and the POSIX string handling API
+ */
+#if defined(_MSC_VER) && _MSC_VER >= 1400
+#ifndef _CRT_SECURE_NO_DEPRECATE
+#define _CRT_SECURE_NO_DEPRECATE
+#endif
+#pragma warning(disable: 4996)
+#endif
+#endif
+
 #include "jk_version.h"
 
 #ifdef HAVE_APR



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424266 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp12_worker.c jk_ajp_common.c jk_connect.c jk_jni_worker.c jk_lb_worker.c jk_shm.c jk_sockbuf.c jk_sockbuf.h jk_status.c jk_util

[mturk]

Author: mturk
Date: Fri Jul 21 04:09:26 2006
New Revision: 424266

URL: http://svn.apache.org/viewvc?rev=424266&view=rev
Log:
Fix compile time warnings.
No functional change, but it allows to build
on win64 platforms.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
tomcat/connectors/trunk/jk/native/common/jk_connect.c
tomcat/connectors/trunk/jk/native/common/jk_jni_worker.c
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
tomcat/connectors/trunk/jk/native/common/jk_shm.c
tomcat/connectors/trunk/jk/native/common/jk_sockbuf.c
tomcat/connectors/trunk/jk/native/common/jk_sockbuf.h
tomcat/connectors/trunk/jk/native/common/jk_status.c
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c?rev=424266&r1=424265&r2=424266&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp12_worker.c Fri Jul 21 
04:09:26 2006
@@ -313,7 +313,7 @@
 {
 int bufferlen;
 
-if (buffer && (bufferlen = strlen(buffer))) {
+if (buffer && (bufferlen = (int)strlen(buffer))) {
 #if defined(AS400) || defined(_OSD_POSIX)
 char buf[2048];
 if (bufferlen < 2048) {

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=424266&r1=424265&r2=424266&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Fri Jul 21 
04:09:26 2006
@@ -738,7 +738,7 @@
 {
 int rc;
 ajp_worker_t *aw = ae->worker;
-int sock = ae->sd;
+jk_sock_t sock = ae->sd;
 
 /* Mark existing endpoint socket as closed */
 ae->sd = JK_INVALID_SOCKET;
@@ -775,7 +775,7 @@
 tv.tv_usec = (timeout % 1000) * 1000;
 
 do {
-rc = select(ae->sd + 1, &rset, NULL, NULL, &tv);
+rc = select((int)ae->sd + 1, &rset, NULL, NULL, &tv);
 } while (rc < 0 && errno == EINTR);
 
 if (rc == 0) {
@@ -2082,7 +2082,8 @@
 
 JK_ENTER_CS(&w->cs, rc);
 if (rc) {
-int i, sock = JK_INVALID_SOCKET;
+int i;
+jk_sock_t sock = JK_INVALID_SOCKET;
 
 if (p->sd > 0 && !p->reuse) {
 sock  = p->sd;

Modified: tomcat/connectors/trunk/jk/native/common/jk_connect.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_connect.c?rev=424266&r1=424265&r2=424266&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_connect.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_connect.c Fri Jul 21 04:09:26 
2006
@@ -52,7 +52,7 @@
 typedef const char* SET_TYPE;
 #endif
 
-static int soblock(int sd)
+static int soblock(jk_sock_t sd)
 {
 /* BeOS uses setsockopt at present for non blocking... */
 #ifndef WIN32
@@ -136,7 +136,7 @@
 
 tv.tv_sec  = timeout;
 tv.tv_usec = 0;
-rc = select(sock + 1, NULL, &wfdset, &efdset, &tv);
+rc = select((int)sock + 1, NULL, &wfdset, &efdset, &tv);
 if (rc == SOCKET_ERROR || rc == 0) {
 rc = WSAGetLastError();
 soblock(sock);
@@ -634,7 +634,7 @@
 tv.tv_usec = 1;
 
 /* If we get a timeout, then we are still connected */
-if ((rc = select(sock + 1, &fd, NULL, NULL, &tv)) == 0) {
+if ((rc = select((int)sock + 1, &fd, NULL, NULL, &tv)) == 0) {
 errno = 0;
 return 1;
 }

Modified: tomcat/connectors/trunk/jk/native/common/jk_jni_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_jni_worker.c?rev=424266&r1=424265&r2=424266&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_jni_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_jni_worker.c Fri Jul 21 
04:09:26 2006
@@ -834,7 +834,7 @@
 jk_log(l, JK_LOG_DEBUG, "got default jvm args");
 
 if (vm_args.classpath) {
-unsigned len = strlen(vm_args.classpath) +
+size_t len = strlen(vm_args.classpath) +
 strlen(p->tomcat_classpath) + 3;
 char *tmp = jk_pool_alloc(&p->p, len);
 if (tmp) {
@@ -907,7 +907,7 @@
 static char *build_opt_str(jk_pool_t *p,
char *opt_name, char *opt_value, jk_logger_t *l)
 {
-unsigned len = strlen(opt_name) + strlen(opt_value) + 2;
+size_t len = strlen(opt_name) + strlen(opt_value) + 2;
 
 /* [V] IMHO, these should not be deallocated as long 

svn commit: r424267 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

[mturk]

Author: mturk
Date: Fri Jul 21 04:14:23 2006
New Revision: 424267

URL: http://svn.apache.org/viewvc?rev=424267&view=rev
Log:
Fix compile time warnings.
I simply hate all those int.size_t transformations.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?rev=424267&r1=424266&r2=424267&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Fri Jul 21 04:14:23 2006
@@ -133,13 +133,13 @@
 
 const char *jk_log_fmt = JK_TIME_FORMAT;
 
-static size_t set_time_str(char *str, int len)
+static int set_time_str(char *str, int len)
 {
 time_t t = time(NULL);
 struct tm *tms;
 
 tms = localtime(&t);
-return strftime(str, len, jk_log_fmt, tms);
+return (int)strftime(str, len, jk_log_fmt, tms);
 }
 
 /* Write at most n characters to the buffer in str, return the
@@ -299,7 +299,7 @@
 #endif
 char *f = (char *)(file + strlen(file) - 1);
 va_list args;
-size_t used = 0;
+int used = 0;
 
 while (f != file && '\\' != *f && '/' != *f) {
 f--;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 12:34 ---
We're also using JDK version "1.5.0_06", with the Server HotSpot VM, under a Red
Hat RHEL 3 Linux, hope it can help.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 12:35 ---
Works fine on apache-tomcat-5.5.17.zip on Fedora Core 4, JDK 1.5.0_07
Are you sure you haven't changed your compilerTargetVM and compilerSourceVM in
conf/web.xml

Please try on 5.5.17 and reopen if it exists in there, we'll work through it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 12:45 ---
I just tested 5.5.15, 16 and 17 all work fine.

are you sure you're not using GNU java or something else installed on your 
system?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Excessive Lock/Unlock Traffic

[Costin Manolache]

Good to hear from infrastructure@ !

We all agree that the svn lock/svn unlock traffic was a bad thing, and
even worse that 2 mails were sent for each file in the repository.
AFAIK this is result of changing a simple property in the tomcat repository
( for
line ending ), and it's a serious bug in svn or how svn is configured to
generate all this spam. I think the change made in tomcat is perfectly
reasonable, and other projects may do similar things - I hope svn
will be fixed, or maybe infrastructure can add some filters to drop
such messages.

Costin


On 7/20/06, Garrett Rooney <[EMAIL PROTECTED]> wrote:


So, I'm not entirely clear what the justification for all the 'svn
lock'/'svn unlock' traffic from the Tomcat section of the Subversion
repository was this morning, but I do know that judging from the files
that were involved (uhh, all of them, I think), the log message
(something about setting properties) and the fact that they were
immediately unlocked, there's no reason it should have been done.

That caused a ridiculous number of email notifications to be sent,
filling the outbound mail queue for quite some time.  Please don't
ever do that again.  There is almost no reason for locking files in
our Subversion repository, and there is literally no reason for
locking ALL the files in a given ASF project.

-garrett, on behalf of the ASF Infrastructure team

Re: SVN propset branch for tc6

[Jim Jagielski]

On Jul 20, 2006, at 3:35 PM, Mladen Turk wrote:


Jim Jagielski wrote:

I'm assuming this the the reason for the slew of svn lock messages :)


Right :(
Any chance to suppress that in future?
If someone else accidentally hits the svn lock
on the trunk the same will happen again.



With SVN the need to actually lock files, especially the
whole tree, is pretty minimal. I've never done it, even
when doing wholesale propsets, indenting changes, etc...
(stuff that affects almost every file)


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 13:42 ---
No Jasper options defined in conf/web.xml (compilerTargetVM and 
compilerSourceVM)

I'm now using JDK 1.5.07, without any GNU Classpath nor Kaffe, and it still
cannot compile

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38211] - Unable to compiler JSP-Files with Tomcat > 5.5.9

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38211





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 14:00 ---
Can you zip up your tomcat directory and put it somewhere for me to download I
will run the same test over here

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Problems with always sending Content-Type, Expires and Pragma headers

[J Ross Nicoll]

I've been adapting my web application to handle the Range and If- 
Range headers. Problem is, if I send back a 206 response (partial  
content), sometimes I don't want to be sending Content-Type.  
Specifically, from RFC 2616, section 10.2.7:


"If the response is the result of an If-Range request that used a  
weak validator, the response MUST NOT include other entity-headers;  
this prevents inconsistencies between cached entity-bodies and  
updated headers."



Now; I may not entirely agree that this is a good idea, but that's  
what the spec says, and Content-Type is one of the "other entity- 
headers". However, if I don't specify a Content-Type, Tomcat (5.5.17)  
sets it to text/plain . So, I'm looking for Tomcat not to auto-set  
Content-Type in some cases. I'm saying this in e-mail, rather than  
submitting a bug report, because I'm not entirely sure of the best  
solution to this.


Now the simplest solution would, of course, be to not send Content- 
Type automatically on status code 206. However, that would break any  
applications that have come to depend on such behaviour. Also, I have  
a separate problem with Expires and Pragma always being sent on  
secure connections; while Expires can be overriden, Pragma should be  
excluded if not suitable.


The best solution I can think of to all these problems, would be to  
make headers to always be sent, a configuration option on the HTTP  
and AJP connectors. Thoughts?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424335 - in /tomcat/connectors/trunk/jk/native/common: jk_map.c jk_uri_worker_map.c

[mturk]

Author: mturk
Date: Fri Jul 21 07:41:47 2006
New Revision: 424335

URL: http://svn.apache.org/viewvc?rev=424335&view=rev
Log:
Fix #40087 by using case sensitive maps like
it was with <= 1.2.6. The regression is that
the worker names must be case sensitive,
again as they were with 1.2.6

Modified:
tomcat/connectors/trunk/jk/native/common/jk_map.c
tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_map.c?rev=424335&r1=424334&r2=424335&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_map.c Fri Jul 21 07:41:47 2006
@@ -145,7 +145,7 @@
 unsigned int key;
 COMPUTE_KEY_CHECKSUM(name, key)
 for (i = 0; i < m->size; i++) {
-if (m->keys[i] == key && strcasecmp(m->names[i], name) == 0) {
+if (m->keys[i] == key && strcmp(m->names[i], name) == 0) {
 rc = m->values[i];
 break;
 }
@@ -163,7 +163,7 @@
 unsigned int key;
 COMPUTE_KEY_CHECKSUM(name, key)
 for (i = 0; i < m->size; i++) {
-if (m->keys[i] == key && strcasecmp(m->names[i], name) == 0) {
+if (m->keys[i] == key && strcmp(m->names[i], name) == 0) {
 rc = i;
 break;
 }
@@ -182,7 +182,7 @@
 unsigned int key;
 COMPUTE_KEY_CHECKSUM(name, key)
 for (i = 0; i < m->size; i++) {
-if (m->keys[i] == key && strcasecmp(m->names[i], name) == 0) {
+if (m->keys[i] == key && strcmp(m->names[i], name) == 0) {
 rc = m->values[i];
 break;
 }

Modified: tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c?rev=424335&r1=424334&r2=424335&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c Fri Jul 21 
07:41:47 2006
@@ -440,7 +440,7 @@
 /* Map is already sorted by context_len */
 if (wildchar_match(uri, uwr->context,
 #ifdef WIN32
-   1
+   0
 #else
0
 #endif
@@ -529,7 +529,7 @@
 /* Map is already sorted by context_len */
 if (wildchar_match(url, uwr->context,
 #ifdef WIN32
-   1
+   0
 #else
0
 #endif



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40087] - JKMount case sensitivity

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40087


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 14:41 ---
Fixed in the SVN.
Not may use something like that, but since it follows the servlet spec,
we must implement it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424339 - /tomcat/connectors/trunk/jk/xdocs/config/workers.xml

[mturk]

Author: mturk
Date: Fri Jul 21 07:46:38 2006
New Revision: 424339

URL: http://svn.apache.org/viewvc?rev=424339&view=rev
Log:
Note that the worker names are case sensitive
caused by the #40087 fix. A small price to pay
for being servlet spec compatible.

Modified:
tomcat/connectors/trunk/jk/xdocs/config/workers.xml

Modified: tomcat/connectors/trunk/jk/xdocs/config/workers.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/config/workers.xml?rev=424339&r1=424338&r2=424339&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/config/workers.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/config/workers.xml Fri Jul 21 07:46:38 2006
@@ -57,7 +57,7 @@
 
 
 
-The name of the worker can contain only the alphanumeric characters 
[a-z][A-Z][0-9] and is case insensitive.
+The name of the worker can contain only the alphanumeric characters 
[a-z][A-Z][0-9] and is case sensitive.
 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Excessive Lock/Unlock Traffic

[Costin Manolache]

I'm pretty sure Mladen didn't intentionally do a 'svn lock/unlock' on each
file. Maybe his IDE did - he can
comment on what commands he used to perform the operation.

However, I don't see any reason for svn to send a mail whenever a file is
locked or unlocked - the
purpose ( AFAIK ) is to allow review and inform people of repository
activity - locking a file
doesn't look like something you would "-1", it's more of an internal svn/dav
thing.

Changing a property on all files in a repository is a normal, legal
operation that other
projects may do ( tomcat will probably avoid this in future :-).

If you think svn is correct in sending lock/unlock/proppatch mails for each
individual file ( without at least agreggating them ) - then
it would be good to inform projects on what to expect, how to turn off mail
before doing such changes, or
how to do this kind of changes without locking.

Costin


On 7/21/06, Garrett Rooney <[EMAIL PROTECTED]> wrote:


On 7/21/06, Costin Manolache <[EMAIL PROTECTED]> wrote:
> Good to hear from infrastructure@ !
>
> We all agree that the svn lock/svn unlock traffic was a bad thing, and
> even worse that 2 mails were sent for each file in the repository.
> AFAIK this is result of changing a simple property in the tomcat
repository
> ( for
> line ending ), and it's a serious bug in svn or how svn is configured to
> generate all this spam. I think the change made in tomcat is perfectly
> reasonable, and other projects may do similar things - I hope svn
> will be fixed, or maybe infrastructure can add some filters to drop
> such messages.

It's not a bug in how svn is configured, it's a "bug" in the user
understanding of the need for use of 'svn lock'.  You do not need to
use svn lock just because you want to change the line endings.  Anyone
who tells you otherwise is just plain wrong, and I'm saying that both
with my ASF infra hat on and my Subversion developer hat on.  People
change eol styles in repositories all over the world constantly
without ever using 'svn lock' and 'svn unlock'.

The only real justification for use of 'svn lock' is when you're
making modifications to a file that intrinsically cannot be merged,
and thus you want to prevent someone else from modifying it at the
same time.  This might include images, .doc files, etc.  In that case
the notification is critical because you don't want people to find out
that the file has been locked when they go to do their commit.  In
virtually all other cases (and especially in the ASF repository with
its goal of collaborative development) there is no reason to ever use
'svn lock' at all.

-garrett

Iso Demirkaya/CH/BALOISE ist außer Haus. Ferien!

[iso . demirkaya]

Ich werde ab  21.07.2006 nicht im Büro sein. Ich kehre zurück am
07.08.2006.

Ferien. Bin zurück am 8. August 2006. In dringenden Fällen wenden Sie sich
bitte an Rainer König 032 626 08 35 oder Roland Käser 032 626 08 24.

Disclaimer: The contents of this email and any attachment thereto are
intended exclusively for the attention of the addressee(s).
The email and any such attachment(s) may contain information that is
confidential and protected on the strength of professional,
official or business secrecy laws and regulations or contractual
obligations. Should you have received this email by mistake,
you may neither make use of nor divulge the contents of the email or of any
attachment thereto. In such a case,
please inform the email's sender and delete the message and all attachments
without delay from your systems.
You can find our e-mail disclaimer statement in other languages under
http://www.baloise.ch/disclaimer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Excessive Lock/Unlock Traffic

[Mladen Turk]

Costin Manolache wrote:

I'm pretty sure Mladen didn't intentionally do a 'svn lock/unlock' on each
file. Maybe his IDE did - he can
comment on what commands he used to perform the operation.



$> svn lock trunk
$> svn propset ...
$> svn unlock trunk



Changing a property on all files in a repository is a normal, legal
operation that other
projects may do ( tomcat will probably avoid this in future :-).



At least I won't do that any more.
I will rather depend on the atomic lock,
and advertising repository lock on tomcay-dev list, requesting
everyone to be patient for limited amount of time :)



If you think svn is correct in sending lock/unlock/proppatch mails for each
individual file ( without at least agreggating them ) - then
it would be good to inform projects on what to expect, how to turn off mail
before doing such changes, or
how to do this kind of changes without locking.



That's the problem.
It's easy to be a general after the battle, saying
you don't need to use the svn lock, etc...
But according to the SVN manual its a perfectly
legitimate operation. Like said if I was aware of the
consequences I would never do it like I did.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424374 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Fri Jul 21 09:27:42 2006
New Revision: 424374

URL: http://svn.apache.org/viewvc?rev=424374&view=rev
Log:
Dereference socket after its been used

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=424374&r1=424373&r2=424374&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
Jul 21 09:27:42 2006
@@ -1333,7 +1333,6 @@
 
 // Process requests until we receive a shutdown signal
 while (running) {
-
 // Wait for the next socket to be assigned
 SocketChannel socket = await();
 if (socket == null)
@@ -1357,12 +1356,11 @@
 log.error("",x);
 }
 }
-
+//dereference socket to let GC do its job
+socket = null;
 // Finish up this request
 recycleWorkerThread(this);
-
 }
-
 }
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Excessive Lock/Unlock Traffic

[Mladen Turk]

Paul Querna wrote:


If you think svn is correct in sending lock/unlock/proppatch mails for 
each individual file ( without at least agreggating them ) - then


It was done separately BECAUSE it was not done in a SINGLE ATOMIC COMMIT.

THIS IS CAUSED BY USER ERROR, AND NOT BY A PROBLEM WITH SUBVERSION OR 
OUR CONFIGURATION.




Then you might put that somewhere inside www.apache.org/dev
How could one EVER KNOW THAT if this is nowhere mentioned?
Now we know, and if you said that:
"And this can be done in a single atomic commit. There is NEVER a reason 
to use locking to do this. Never."


The I suggest you simply disable the lock/unlock inside ASF.

Regards,
Mladen



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Excessive Lock/Unlock Traffic

[Mladen Turk]

Mladen Turk wrote:

Paul Querna wrote:


THIS IS CAUSED BY USER ERROR, AND NOT BY A PROBLEM WITH SUBVERSION OR 
OUR CONFIGURATION.




Then you might put that somewhere inside www.apache.org/dev


One note:

Sorry, seems it was caused by the Tortoise SVN client.
It has an option to 'Get Lock' on the entire directory,
probably internally traversing trough the entire tree.
Garret said he'll file the bug to tortoisesvn guys,
but in any case some notification inside www.apache.org/dev
would be great, cause there are many projects that could
suffer from something like that.

Regards,
Mladen


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28727] - CLOSE_WAIT connections draw 100 % cpu

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28727





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 16:48 ---
I think it is been resolved. Please check this
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6215050 
The java 1.4.2.12 and java 1.5.0.07 should fix the problem.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39817] - Include File Failure for Parent|Top Relative References

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39817


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |




--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 17:56 ---
I have just upgraded from 5.5.7 to 5.5.17 and I immediately found a problem
similar to the one described above.

Those web applications which have include statements similar to

<%@ include file="/_jspf/global.jspf" %>

in files contained within a sub directory of the appBase throw the following
error when the page is accessed:

org.apache.jasper.JasperException: /index.jsp(2,0) File "/_jspf/global.jspf" not
found

The same line works perfectly in files contained within the appBase itself.

This has happened across the board with every one of my web applications, none
of which displayed a problem 5 minutes before, when running within Tomcat 5.5.7.

I have tried substituting the include line for the following:

<%@ include file="../_jspf/global.jspf" %>

which merely changes the error description string to the following:

org.apache.jasper.JasperException: /index.jsp(2,0) File "/../_jspf/global.jspf"
not found

I am convinced this problem in not related to a typo or other such developer
mistake due to the blanket effect on all my applications and the abscenece of
any problem during build in Netbeans IDE 5.0 which helpfully checks all include
file references on compile.

Tomcat is running as a service on my Windows XP machine, is using jre1.5.0_07,
and is connected to Apache HTTP Server 2.0.58 using the appropriate build of 
mod_jk.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn lock: /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/jni/Error.java

[Ian Darwin]

Wade Chandler wrote:

Yes this sucks.  We can't even easily filter the mails
out on our ends because of the way they are sent.  We
could look for svn, but what if a message is really
related to svn.


This is unlikely to happen again but, of course, if it does
you can just (as I imagine most ppl did) filter on "svn: lock"
and "svn: unlock"


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r423967 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[William A. Rowe, Jr.]

Remy Maucherat wrote:

Jean-frederic Clere wrote:


Comments?


Another tactic is to give up, and return an error code of some sort in 
Tomcat if the URL contains a path parameter (since they are not part of 
the path, are not handled properly, and have no useful usage at the 
moment).


+1 - this is a very reasonable suggestion; or, make it toggleable...

The latest RFC (3986) gives an interesting example of usage: For 
example, one URI producer might use a segment such as "name;v=1.1" to 
indicate a reference to version 1.1 of "name".


... so the bleeding edge of technology user can do something like this above.

Personally, I dislike the "optimized" mappings, like *.jsp, that in the 
end make the webapp non portable and full of security holes. I think 
full webapp mappings are preferable (and for static resources that 
"need" to be served by Apache, it still seems possible to me to use 
relative URLs to them - as if they were in a separate webapp).


+++1 - My personal favorite approach is more of a JkMountRequest /target
where this directive is deposited into a  or  block...
the same block that the user is likely to add security related permissions.

It leaves no ambiguity ;-)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424429 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Fri Jul 21 12:30:31 2006
New Revision: 424429

URL: http://svn.apache.org/viewvc?rev=424429&view=rev
Log:
Make sure the key is valid before processing it

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=424429&r1=424428&r2=424429&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
Jul 21 12:30:31 2006
@@ -1133,29 +1133,31 @@
 iterator.remove();
 KeyAttachment attachment = (KeyAttachment)sk.attachment();
 try {
-if(attachment == null) attachment = new 
KeyAttachment();
-attachment.access();
-sk.attach(attachment);
-
-int readyOps = sk.readyOps();
-sk.interestOps(sk.interestOps() & ~readyOps);
-SocketChannel channel = (SocketChannel)sk.channel();
-boolean read = sk.isReadable();
-if (read) {
-if ( attachment.getWakeUp() ) {
-attachment.setWakeUp(false);
-synchronized (attachment.getMutex()) 
{attachment.getMutex().notifyAll();}
-} else if ( attachment.getComet() ) {
-if (!processSocket(channel,false)) 
processSocket(channel,true);
-} else {
-boolean close = (!processSocket(channel));
-if ( close ) {
-channel.socket().close();
-channel.close();
+if ( sk.isValid() ) {
+if(attachment == null) attachment = new 
KeyAttachment();
+attachment.access();
+sk.attach(attachment);
+int readyOps = sk.readyOps();
+sk.interestOps(sk.interestOps() & ~readyOps);
+SocketChannel channel = 
(SocketChannel)sk.channel();
+boolean read = sk.isReadable();
+if (read) {
+if ( attachment.getWakeUp() ) {
+attachment.setWakeUp(false);
+synchronized (attachment.getMutex()) 
{attachment.getMutex().notifyAll();}
+} else if ( attachment.getComet() ) {
+if (!processSocket(channel,false)) 
processSocket(channel,true);
+} else {
+boolean close = (!processSocket(channel));
+if ( close ) {
+channel.socket().close();
+channel.close();
+}
 }
 }
-}
-if (sk.isValid() && sk.isWritable()) {
+} else {
+//invalid key
+cancelledKey(sk);
 }
 } catch ( CancelledKeyException ckx ) {
 if (attachment!=null && attachment.getComet()) 
processSocket( (SocketChannel) sk.channel(), true);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424441 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

[fhanik]

Author: fhanik
Date: Fri Jul 21 13:15:35 2006
New Revision: 424441

URL: http://svn.apache.org/viewvc?rev=424441&view=rev
Log:
Remove old APR references

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=424441&r1=424440&r2=424441&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Fri 
Jul 21 13:15:35 2006
@@ -24,8 +24,6 @@
 import java.nio.channels.Selector;
 import java.nio.channels.ServerSocketChannel;
 import java.nio.channels.SocketChannel;
-import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.Iterator;
 import java.util.LinkedList;
 import java.util.Set;
@@ -33,11 +31,7 @@
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
-import org.apache.tomcat.jni.Error;
-import org.apache.tomcat.jni.Library;
-import org.apache.tomcat.jni.Poll;
 import org.apache.tomcat.jni.SSL;
-import org.apache.tomcat.jni.Status;
 import org.apache.tomcat.util.res.StringManager;
 
 /**
@@ -545,9 +539,9 @@
 // Initialize SSL
 // FIXME: one per VM call ?
 if ("on".equalsIgnoreCase(SSLEngine)) {
-SSL.initialize(null);
+//SSL.initialize(null);
 } else {
-SSL.initialize(SSLEngine);
+//SSL.initialize(SSLEngine);
 }
 // SSL protocol
 int value = SSL.SSL_PROTOCOL_ALL;
@@ -844,24 +838,6 @@
 workers.push(workerThread);
 curThreadsBusy--;
 workers.notify();
-}
-}
-
-
-/**
- * Allocate a new poller of the specified size.
- */
-protected long allocatePoller(int size, long pool, int timeout) {
-try {
-return Poll.create(size, pool, 0, timeout * 1000);
-} catch (Error e) {
-if (Status.APR_STATUS_IS_EINVAL(e.getError())) {
-log.info(sm.getString("endpoint.poll.limitedpollsize", "" + 
size));
-return 0;
-} else {
-log.error(sm.getString("endpoint.poll.initfail"), e);
-return -1;
-}
 }
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Help needed HTTP response header

[Surya Bob]

Hi all,
  I am trying to tighten up our Apache and Tomcat implementation. I want
to suppress server type and version to make fingerprinting harder.
   
  HTTP response header

HTTP/1.1 200 OK
Date: Tue, 05 Nov 2002 17:49:51 GMT
Server: XXX
Set-Cookie2: JSESSIONID=naa2in3fj1;Version=1;Discard;Path="/"
Set-Cookie: JSESSIONID=naa2in3fj1;Path=/
Servlet-Engine: Tomcat Web Server/3.2.3 (JSP 1.1; Servlet 2.2; Java
   
  How can i hide the server information.it would be great if someone can Help 
me in this
   
  Thanks
  Sbob.



-
Do you Yahoo!?
 Get on board. You're invited to try the new Yahoo! Mail Beta.

DO NOT REPLY [Bug 39817] - Include File Failure for Parent|Top Relative References

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39817





--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 22:38 ---
Given I cannot re-reproduce this, please attach a minimal test war that
demonstrates this issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Help needed HTTP response header

[Mark Thomas]

Surya Bob wrote:
> Hi all,
>   I am trying to tighten up our Apache and Tomcat implementation. I want
> to suppress server type and version to make fingerprinting harder.

This question belongs on the users list. Please repost it there.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r424503 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/servlets/CGIServlet.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri Jul 21 17:19:37 2006
New Revision: 424503

URL: http://svn.apache.org/viewvc?rev=424503&view=rev
Log:
Partial fix for bug part of 34801. Add handling of IOExceptions during long 
running CGI requests.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/CGIServlet.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/CGIServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/CGIServlet.java?rev=424503&r1=424502&r2=424503&view=diff
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/CGIServlet.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/CGIServlet.java
 Fri Jul 21 17:19:37 2006
@@ -1685,103 +1685,118 @@
 command.append(cmdAndArgs.toString());
 cmdAndArgs = command;
 
-rt = Runtime.getRuntime();
-proc = rt.exec(cmdAndArgs.toString(), hashToStringArray(env), wd);
-
-String sContentLength = (String) env.get("CONTENT_LENGTH");
-
-if(!"".equals(sContentLength)) {
-commandsStdIn = new 
BufferedOutputStream(proc.getOutputStream());
-IOTools.flow(stdin, commandsStdIn);
-commandsStdIn.flush();
-commandsStdIn.close();
-}
-
-/* we want to wait for the process to exit,  Process.waitFor()
- * is useless in our situation; see
- * http://developer.java.sun.com/developer/
- *   bugParade/bugs/4223650.html
- */
-
-boolean isRunning = true;
-commandsStdErr = new BufferedReader
-(new InputStreamReader(proc.getErrorStream()));
-final BufferedReader stdErrRdr = commandsStdErr ;
+try {
+rt = Runtime.getRuntime();
+proc = rt.exec(cmdAndArgs.toString(), hashToStringArray(env), 
wd);
+
+String sContentLength = (String) env.get("CONTENT_LENGTH");
 
-new Thread() {
-public void run () {
-sendToLog(stdErrRdr) ;
-} ;
-}.start() ;
+if(!"".equals(sContentLength)) {
+commandsStdIn = new 
BufferedOutputStream(proc.getOutputStream());
+IOTools.flow(stdin, commandsStdIn);
+commandsStdIn.flush();
+commandsStdIn.close();
+}
 
-InputStream cgiHeaderStream =
-new HTTPHeaderInputStream(proc.getInputStream());
-BufferedReader cgiHeaderReader =
-new BufferedReader(new InputStreamReader(cgiHeaderStream));
+/* we want to wait for the process to exit,  Process.waitFor()
+ * is useless in our situation; see
+ * http://developer.java.sun.com/developer/
+ *   bugParade/bugs/4223650.html
+ */
+
+boolean isRunning = true;
+commandsStdErr = new BufferedReader
+(new InputStreamReader(proc.getErrorStream()));
+final BufferedReader stdErrRdr = commandsStdErr ;
+
+new Thread() {
+public void run () {
+sendToLog(stdErrRdr) ;
+} ;
+}.start() ;
+
+InputStream cgiHeaderStream =
+new HTTPHeaderInputStream(proc.getInputStream());
+BufferedReader cgiHeaderReader =
+new BufferedReader(new InputStreamReader(cgiHeaderStream));
 
-while (isRunning) {
-try {
-//set headers
-String line = null;
-while (((line = cgiHeaderReader.readLine()) != null)
-   && !("".equals(line))) {
-if (debug >= 2) {
-log("runCGI: addHeader(\"" + line + "\")");
-}
-if (line.startsWith("HTTP")) {
-response.setStatus(getSCFromHttpStatusLine(line));
-} else if (line.indexOf(":") >= 0) {
-String header =
-line.substring(0, line.indexOf(":")).trim();
-String value =
-line.substring(line.indexOf(":") + 1).trim(); 
-if (header.equalsIgnoreCase("status")) {
-
response.setStatus(getSCFromCGIStatusHeader(value));
+while (isRunning) {
+t

svn commit: r424504 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java

[markt]

Author: markt
Date: Fri Jul 21 17:19:59 2006
New Revision: 424504

URL: http://svn.apache.org/viewvc?rev=424504&view=rev
Log:
Port partial fix for 34801

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=424504&r1=424503&r2=424504&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java Fri 
Jul 21 17:19:59 2006
@@ -1685,103 +1685,118 @@
 command.append(cmdAndArgs.toString());
 cmdAndArgs = command;
 
-rt = Runtime.getRuntime();
-proc = rt.exec(cmdAndArgs.toString(), hashToStringArray(env), wd);
-
-String sContentLength = (String) env.get("CONTENT_LENGTH");
-
-if(!"".equals(sContentLength)) {
-commandsStdIn = new 
BufferedOutputStream(proc.getOutputStream());
-IOTools.flow(stdin, commandsStdIn);
-commandsStdIn.flush();
-commandsStdIn.close();
-}
-
-/* we want to wait for the process to exit,  Process.waitFor()
- * is useless in our situation; see
- * http://developer.java.sun.com/developer/
- *   bugParade/bugs/4223650.html
- */
-
-boolean isRunning = true;
-commandsStdErr = new BufferedReader
-(new InputStreamReader(proc.getErrorStream()));
-final BufferedReader stdErrRdr = commandsStdErr ;
+try {
+rt = Runtime.getRuntime();
+proc = rt.exec(cmdAndArgs.toString(), hashToStringArray(env), 
wd);
+
+String sContentLength = (String) env.get("CONTENT_LENGTH");
 
-new Thread() {
-public void run () {
-sendToLog(stdErrRdr) ;
-} ;
-}.start() ;
+if(!"".equals(sContentLength)) {
+commandsStdIn = new 
BufferedOutputStream(proc.getOutputStream());
+IOTools.flow(stdin, commandsStdIn);
+commandsStdIn.flush();
+commandsStdIn.close();
+}
 
-InputStream cgiHeaderStream =
-new HTTPHeaderInputStream(proc.getInputStream());
-BufferedReader cgiHeaderReader =
-new BufferedReader(new InputStreamReader(cgiHeaderStream));
+/* we want to wait for the process to exit,  Process.waitFor()
+ * is useless in our situation; see
+ * http://developer.java.sun.com/developer/
+ *   bugParade/bugs/4223650.html
+ */
+
+boolean isRunning = true;
+commandsStdErr = new BufferedReader
+(new InputStreamReader(proc.getErrorStream()));
+final BufferedReader stdErrRdr = commandsStdErr ;
+
+new Thread() {
+public void run () {
+sendToLog(stdErrRdr) ;
+} ;
+}.start() ;
+
+InputStream cgiHeaderStream =
+new HTTPHeaderInputStream(proc.getInputStream());
+BufferedReader cgiHeaderReader =
+new BufferedReader(new InputStreamReader(cgiHeaderStream));
 
-while (isRunning) {
-try {
-//set headers
-String line = null;
-while (((line = cgiHeaderReader.readLine()) != null)
-   && !("".equals(line))) {
-if (debug >= 2) {
-log("runCGI: addHeader(\"" + line + "\")");
-}
-if (line.startsWith("HTTP")) {
-response.setStatus(getSCFromHttpStatusLine(line));
-} else if (line.indexOf(":") >= 0) {
-String header =
-line.substring(0, line.indexOf(":")).trim();
-String value =
-line.substring(line.indexOf(":") + 1).trim(); 
-if (header.equalsIgnoreCase("status")) {
-
response.setStatus(getSCFromCGIStatusHeader(value));
+while (isRunning) {
+try {
+//set headers
+String line = null;
+while (((line = cgiHeaderReader.readLine()) != null)
+   && !("".equals(line))) 

DO NOT REPLY [Bug 34801] - PATCH: CGIServlet does not terminate child after a timeout

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34801


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement
   Priority|P2  |P3
Summary|PATCH: CGIServlet does not  |PATCH: CGIServlet does not
   |kill CGI child process on   |terminate child after a
   |IOException, nor terminate  |timeout
   |child after a timeout   |
Version|5.5.9   |5.5.17




--- Additional Comments From [EMAIL PROTECTED]  2006-07-22 00:35 ---
I have applied the IOException part of the patch but left the watchdog element
for future consideration. I have changed the severity and summary accordingly.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]