Jk_status doesn't generate valid html (patch included)

2006-06-23 Thread Johan Bergström 

Hello dev-list.
I'm quite new to both tomcat and mod_jk.. really liking it so far!  
Thought I could contribute back with some minor things I found.


Jk_status throws out some garbled html;

 * Ampersands (&) are not escaped
 * Input hiddens are wrapped in a table (?)
 * Superfluous td/tr/table and invalid closures scattered throughout  
the file.

 and
 * (Tabbed in an comment to follow guidelines)

Maybe i missed something (like a reason why they should be there) but  
here's an proposed diff:


(have a nice weekend)


Index: jk/native/common/jk_status.c
===
--- jk/native/common/jk_status.c(revision 416584)
+++ jk/native/common/jk_status.c(working copy)
@@ -432,7 +432,7 @@
 jk_putv(s, "req_uri, "?cmd=show\">",  
NULL);

 }
 else
-jk_putv(s, "req_uri, "?cmd=show&w=",
+jk_putv(s, "req_uri, "?cmd=show&w=",
 sw->we->worker_list[i], "\">", NULL);
 jk_putv(s, sw->we->worker_list[i], "\n", NULL);
 if (lb != NULL) {
@@ -462,7 +462,7 @@
 worker_record_t *wr = &(lb->lb_workers[j]);
 ajp_worker_t *a = (ajp_worker_t *)wr->w- 
>worker_private;

 jk_putv(s, "\nreq_uri,
-"?cmd=show&w=",
+"?cmd=show&w=",
 wr->s->name, "\">",
 wr->s->name, "", NULL);
 if (dworker && strcmp(dworker, wr->s->name) == 0)
@@ -511,19 +511,19 @@
 wr->s->jvm_route, ")\n", NULL);
 jk_putv(s, "req_uri, "\">\n", NULL);
-jk_puts(s, "\n\"cmd\" ");

+jk_puts(s, "\n");
 jk_puts(s, "s->name, "\">\n", NULL);
 jk_puts(s, "\n\n", selected);
+jk_printf(s, "value=\"%u\">\n", selected);
 jk_puts(s, "\n\n", i);
+jk_printf(s, "value=\"%u\">", i);
 jk_puts(s, "\nDistance:td> jk_printf(s, "value=\"%d\"/>\n", wr->s- 
>distance);
 jk_puts(s, "Load factor:name=\"wf\" type=\"text\" ");
-jk_printf(s, "value=\"%d\"/>\n", wr->s- 
>lb_factor);
+jk_printf(s, "value=\"%d\"/>\n", wr->s- 
>lb_factor);
 jk_puts(s, "Route Redirect:name=\"wr\" type=\"text\" ");

 jk_putv(s, "value=\"", wr->s->redirect, NULL);
 jk_puts(s, "\"/>\n");
@@ -537,7 +537,7 @@
 jk_puts(s, "Stopped:\"ws\" type=\"checkbox\"");

 if (wr->s->is_stopped)
 jk_puts(s, "  checked=\"checked\"");
-jk_puts(s, "/>\n");
+jk_puts(s, "/>\n");
 jk_puts(s, "\n\n");
 jk_puts(s, "\"Update Worker\"/>\n\n");

@@ -782,7 +782,7 @@
 i = status_int("wf", s->query_string, wr->s->lb_factor);
 if (i > 0 && wr->s->lb_factor != i) {
 wr->s->lb_factor = i;
-/* Recalculate the load multiplicators wrt. lb_factor */
+/* Recalculate the load multiplicators wrt. lb_factor */
 update_mult(lb, l);
 }
 }


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

HTTP Protocol + Auth BoF @ApacheCon Wed 9pm

2006-06-23 Thread William A. Rowe, Jr. 

Communities,

I believe this should be interesting to several participants of these three
lists with respect to the HTTP protocol, associated protocols and the future
direction of authentication.

Lisa asked me to forward you all this invitation to the BoF, 9pm - 10pm Wed
at ApacheCon this coming week (bypassing the inevitable moderation hassles :)

Lisa Dusseault writes:


IETF is discussing a number of possible standardization efforts 
around HTTP.  Most notably there are many people interested in tackling 
"Meta-authentication", or the ability to provide an identity that one 
site can validate to another site, and also people interested in seeing 
whether protocol standards might address phishing issues somewhat (both 
of these topics will be discussed in the IETF WAE BoF in Montreal in 
July).  In addition there have been proposals on cookie applicability 
and usage of ETags on PUT responses.


For a full list of topics that you might impact (that Mark suggests might
be up for discussion) see this post;

http://lists.w3.org/Archives/Public/ietf-http-wg/2006AprJun/0111.html

The HTTP Working Group <[EMAIL PROTECTED]> list is where this all
percolates back to, and if these issues really appeal to you, please do
subscribe to that list.

I believe Lisa will attend IETF Montreal 06 in July at that 'official' BoF
and would be happy to propagate concerns raised here at AC, to the IETF
attendees, there.

We hope if protocol level issues interest you, especially the future of auth,
you will join us Wed eve!

Bill

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

2006-06-23 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project tomcat-tc6 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/gump_work/build_tomcat-tc6_tomcat-tc6.html
Work Name: build_tomcat-tc6_tomcat-tc6 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-logging-api.jar=/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-23062006.jar
 
-Dtomcat-dbcp.jar=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-23062006.jar
 
-Djasper-jdt.jar=/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar
 
[Working Directory: /usr/local/gump/public/workspace/tomcat-tc6]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/tomcat-tc6/classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/packages/javamail-1.4/mail.jar:/usr/local/gump/packages/javamail-1.4/lib/mailapi.jar:/usr/local/gump/packages/jaf-1.1ea/activation.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-23062006.jar:/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar:/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-23062006.jar
-
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/DefaultContextMBean.java:40:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:46:15 +0200 
(dim., 29 ao??t 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/DefaultContextMBean.java:40:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:46:15 +0200 
(dim., 29 ao??t 2004) $
[javac] 
  ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/MBeanUtils.java:62:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303558 $ $Date: 2004-12-01 12:17:34 +0100 
(mer., 01 d??c. 2004) $
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/MBeanUtils.java:62:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303558 $ $Date: 2004-12-01 12:17:34 +0100 
(mer., 01 d??c. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/NamingResourcesMBean.java:39:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:46:15 +0200 
(dim., 29 ao??t 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/NamingResourcesMBean.java:39:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

2006-06-23 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project tomcat-tc6 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/gump_work/build_tomcat-tc6_tomcat-tc6.html
Work Name: build_tomcat-tc6_tomcat-tc6 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-logging-api.jar=/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-23062006.jar
 
-Dtomcat-dbcp.jar=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-23062006.jar
 
-Djasper-jdt.jar=/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar
 
[Working Directory: /usr/local/gump/public/workspace/tomcat-tc6]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/tomcat-tc6/classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/packages/javamail-1.4/mail.jar:/usr/local/gump/packages/javamail-1.4/lib/mailapi.jar:/usr/local/gump/packages/jaf-1.1ea/activation.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-23062006.jar:/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar:/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-23062006.jar
-
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/DefaultContextMBean.java:40:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:46:15 +0200 
(dim., 29 ao??t 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/DefaultContextMBean.java:40:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:46:15 +0200 
(dim., 29 ao??t 2004) $
[javac] 
  ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/MBeanUtils.java:62:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303558 $ $Date: 2004-12-01 12:17:34 +0100 
(mer., 01 d??c. 2004) $
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/MBeanUtils.java:62:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303558 $ $Date: 2004-12-01 12:17:34 +0100 
(mer., 01 d??c. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/NamingResourcesMBean.java:39:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:46:15 +0200 
(dim., 29 ao??t 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/NamingResourcesMBean.java:39:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133 $ $Date: 2004-08-29 18:

Re: svn commit: r415549 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-06-23 Thread William A. Rowe, Jr. 

Mladen, maybe you aught to have deleted the @author tag while you were at it :)

prakash shanmugam wrote:

hello mturk
 i want to know how to store a *.doc file ,or *.pdf file in MYSQL
database using JSP or SERVLET as a front end
if you know the asnwer please reply me soon its very important.
bye



On 6/20/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:


Author: mturk
Date: Tue Jun 20 00:56:27 2006
New Revision: 415549

URL: http://svn.apache.org/viewvc?rev=415549&view=rev
Log:
Ups. Deleted the crucial Revision tag :)

Modified:
   tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?rev=415549&r1=415548&r2=415549&view=diff 



== 


--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Tue Jun 20 00:56:27
2006
@@ -16,7 +16,7 @@
/*
*
* @author Mladen Turk
- * @version
+ * @version $Revision$, $Date$
*/

#include "tcn.h"



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]







-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Feature List

2006-06-23 Thread William A. Rowe, Jr. 

prakash shanmugam wrote:

hai if you can help me it will be a big relief for me
now iam using tomcat 5.0 and linux as my server machine and the client
machine are windows xp
in my coding iam using JSP and SERVLETS. the problem is i want to store
images and pdf files into mydatabase . the backend is mysql 4.0
can u able to help. if u are able todo this i will be really helpful to u.


Take your request to the users list, this list is for the dev-elopers of the
software to discuss the development of tomcat.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r415549 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-06-23 Thread Mladen Turk 

William A. Rowe, Jr. wrote:
Mladen, maybe you aught to have deleted the @author tag while you were 
at it :)




Right. It seems so :)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39875] New: - RealmBase#init() needs cleanup

2006-06-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39875

   Summary: RealmBase#init() needs cleanup
   Product: Tomcat 5
   Version: Nightly Build
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


In RealmBase#init():


public void init() {
this.containerLog = container.getLogger();
if( initialized && container != null ) return;

initialized=true;
if( container== null ) {


If the container is null, then a NPE will occurs.
The container is not null, then the if block is no longer needed.

The first line is changed at revision r372854.
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java?r1=371686&r2=372854

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39876] New: - Typo in webapps/docs/changelog.xml

2006-06-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39876

   Summary: Typo in webapps/docs/changelog.xml
   Product: Tomcat 5
   Version: Nightly Build
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Webapps:Documentation
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I found a trivial typo in webapps/docs/changelog.xml
The "doen" should be "done".

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39876] - Typo in webapps/docs/changelog.xml

2006-06-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39876





--- Additional Comments From [EMAIL PROTECTED]  2006-06-23 11:22 ---
Created an attachment (id=18515)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18515&action=view)
Patch against /tomcat/container/tc5.5.x


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Feature List

2006-06-23 Thread Yoav Shapira 

Riyaz,
New contributors are always welcome.

A decent place to start looking for work are the open issues for
Tomcat in Bugzilla.  You will see a number marked as Enhancement
Requests, and a number whose solution is not trivial at all.  Work on
whatever interests you...

Yoav

On 6/23/06, Riyaz Mansoor <[EMAIL PROTECTED]> wrote:


i'll keep it brief.

i'm looking to spend time on working on the new features coming to
tomcat 5.5 or 6

on the website, i could find no info on this. i was hoping there would
be a page listing the features being worked in 5.5 and the coming
features in 6

riyaz

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





--
Yoav Shapira
Nimalex LLC
1 Mifflin Place, Suite 310
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Feature List

2006-06-23 Thread Filip Hanik - Dev Lists 

Look at the "Get Involved" section of Tomcat's home page

http://tomcat.apache.org/getinvolved.html

Yoav Shapira wrote:

Riyaz,
New contributors are always welcome.

A decent place to start looking for work are the open issues for
Tomcat in Bugzilla.  You will see a number marked as Enhancement
Requests, and a number whose solution is not trivial at all.  Work on
whatever interests you...

Yoav

On 6/23/06, Riyaz Mansoor <[EMAIL PROTECTED]> wrote:


i'll keep it brief.

i'm looking to spend time on working on the new features coming to
tomcat 5.5 or 6

on the website, i could find no info on this. i was hoping there would
be a page listing the features being worked in 5.5 and the coming
features in 6

riyaz

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]








--


Filip Hanik

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: NIO vs BIO speed

2006-06-23 Thread Filip Hanik - Dev Lists 

https://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?view=log
https://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?view=log
https://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?view=log
https://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java?view=log
https://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?view=log

Dakota Jack wrote:

I am interested in this code.  Is there a way I can see the code?  Thanks.



On 6/22/06, *Filip Hanik - Dev Lists* <[EMAIL PROTECTED] 
> wrote:


Remy Maucherat wrote:

Filip Hanik - Dev Lists wrote:

Here is another test that I ran from a remote machine, setting
maxThreads="25" and ab concurrency to 50 and keepalive on.
In this case, NIO is a lot faster. Turn off keepalive on ab, and
we get similar results to previous run, where BIO is a tad faster.


Scaling the thread per connection model is done by increasing the
amount of threads. This particular test demonstrates the obvious.

yes, what is interesting though, is my NIO connector is not really
true NIO, as it ties up a thread while polling for data. The true
implementation would have not invoked that thread yet, but for
that I would have had to rewritten the connector from scratch as I
couldn't have taken advantage of code already written and tested.
The reason it was done like this, is cause that way I could use
almost all the code from the APR connector.
So you could call it a semi-"thread-per-connection" model, yet
handles better than the true thread per connection model.
APR does the same thing.




If I understand the results correctly, the results would be
acceptable on Unix.

yes, I think they are looking pretty good. And I am fairly
confident in this new code, as most of it, is old tested APR code.

Filip

-- 



Filip Hanik




--
"You can lead a horse to water but you cannot make it float on its back."
~Dakota Jack~


No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.1.394 / Virus Database: 268.9.2/372 - Release Date: 6/21/2006
  



--


Filip Hanik

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39883] New: - using antiResourceLocking in context.xml outside of webapp dir causes app delete on shutdown

2006-06-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39883

   Summary: using antiResourceLocking in context.xml outside of
webapp dir causes app delete on shutdown
   Product: Tomcat 5
   Version: 5.5.17
  Platform: All
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I have an application installed at c:\speechapps\Application_1

containing a META-INF with context.xml.  In the context.xml I have 
reloadable="false" antiJarLocking="true" and antiResourceLocking="true" 
alongiwth the standard docBase and path.  No other entries are present.  If I 
use the manager interface I can install the application and it works fine.  If 
I then shutdown tomcat gracefully, the application is completely deleted from 
the file system.  The context from the /conf/Catalina/localhost is not 
deleted.  On start of tomcat the application is not loaded (since it has been 
deleted from the file system).  If I use the antiResourceLocking=true in the 
webapps directory it does not delete the application content only when used 
outside of webapps.  

To work around this I removed the antiResourceLocking from the context.xml.  
This seems to resolve the issue for now.  This may be a good addition to the 
docs somewhere.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r416780 - in /tomcat/connectors/trunk/jni: java/org/apache/tomcat/jni/Socket.java native/src/network.c

2006-06-23 Thread mturk 
Author: mturk
Date: Fri Jun 23 10:58:41 2006
New Revision: 416780

URL: http://svn.apache.org/viewvc?rev=416780&view=rev
Log:
Add APR functions for set/get of user data
associated with the socket. They can be used to
attach the enclosing Java objects with the socket.

Modified:
tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java?rev=416780&r1=416779&r2=416780&view=diff
==
--- tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java 
(original)
+++ tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/Socket.java Fri Jun 
23 10:58:41 2006
@@ -525,4 +525,22 @@
  * @param buf The ByteBuffer
  */
 public static native void setrbb(long sock, ByteBuffer buf);
+
+/**
+ * Set the data associated with the current socket.
+ * @param sock The currently open socket.
+ * @param data The user data to associate with the socket.
+ * @param key The key to associate with the data.
+ * @param cleanup The cleanup to call when the socket is destroyed.
+ */
+  public static native int dataSet(long sock, String key, Object data);
+
+/**
+ * Return the data associated with the current socket
+ * @param data The user data associated with the socket.
+ * @param key The key to associate with the user data.
+ * @param sock The currently open socket.
+ * @return Data or null in case of error.
+ */
+ public static native Object dataGet(long sock, String key);
 }

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?rev=416780&r1=416779&r2=416780&view=diff
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Fri Jun 23 10:58:41 2006
@@ -953,7 +953,6 @@
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 apr_status_t ss;
 apr_size_t nbytes = (apr_size_t)len;
-apr_interval_time_t t;
 
 UNREFERENCED_STDARGS;
 TCN_ASSERT(sock != 0);
@@ -1276,6 +1275,40 @@
 UNREFERENCED(args);
 return (jint)APR_ENOTIMPL;
 #endif
+}
+
+
+TCN_IMPLEMENT_CALL(jint, Socket, dataSet)(TCN_STDARGS, jlong sock,
+  jstring key, jobject data)
+{
+tcn_socket_t *s = J2P(sock, tcn_socket_t *);
+apr_status_t rv = APR_SUCCESS;
+void *old = NULL;
+TCN_ALLOC_CSTRING(key);
+
+UNREFERENCED(o);
+TCN_ASSERT(sock != 0);
+
+rv = apr_socket_data_set(s->sock, data, J2S(key), NULL);
+TCN_FREE_CSTRING(key);
+return rv;
+}
+
+TCN_IMPLEMENT_CALL(jobject, Socket, dataGet)(TCN_STDARGS, jlong socket,
+ jstring key)
+{
+tcn_socket_t *s = J2P(socket, tcn_socket_t *);
+TCN_ALLOC_CSTRING(key);
+jobject rv = NULL;
+
+UNREFERENCED(o);
+TCN_ASSERT(sock != 0);
+
+if (apr_socket_data_get(&rv, J2S(key), s->sock) != APR_SUCCESS) {
+rv = NULL;
+}
+TCN_FREE_CSTRING(key);
+return rv;
 }
 
 TCN_IMPLEMENT_CALL(jint, Mulicast, join)(TCN_STDARGS,



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r416783 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-06-23 Thread mturk 
Author: mturk
Date: Fri Jun 23 11:06:15 2006
New Revision: 416783

URL: http://svn.apache.org/viewvc?rev=416783&view=rev
Log:
Remove unused variables.

Modified:
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?rev=416783&r1=416782&r2=416783&view=diff
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Fri Jun 23 11:06:15 2006
@@ -1277,13 +1277,11 @@
 #endif
 }
 
-
 TCN_IMPLEMENT_CALL(jint, Socket, dataSet)(TCN_STDARGS, jlong sock,
   jstring key, jobject data)
 {
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 apr_status_t rv = APR_SUCCESS;
-void *old = NULL;
 TCN_ALLOC_CSTRING(key);
 
 UNREFERENCED(o);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Iso Demirkaya/CH/BALOISE ist außer Haus. Ferien!

2006-06-23 Thread iso . demirkaya 
Ich werde ab  23.06.2006 nicht im Büro sein. Ich kehre zurück am
30.06.2006.

Ferien. Bin zurück am 3. Juli 2006. In dringenden Fällen wenden Sie sich
bitte an Rainer König 032 626 08 35 oder Roland Käser 032 626 08 24.

Disclaimer: The contents of this email and any attachment thereto are
intended exclusively for the attention of the addressee(s).
The email and any such attachment(s) may contain information that is
confidential and protected on the strength of professional,
official or business secrecy laws and regulations or contractual
obligations. Should you have received this email by mistake,
you may neither make use of nor divulge the contents of the email or of any
attachment thereto. In such a case,
please inform the email's sender and delete the message and all attachments
without delay from your systems.
You can find our e-mail disclaimer statement in other languages under
http://www.baloise.ch/disclaimer


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r416789 - in /tomcat/container/tc5.5.x/modules/groupcom: build/build.xml src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

2006-06-23 Thread fhanik 
Author: fhanik
Date: Fri Jun 23 11:27:08 2006
New Revision: 416789

URL: http://svn.apache.org/viewvc?rev=416789&view=rev
Log:
Adjusted build script, and correctd TcpFailureDetector

Modified:
tomcat/container/tc5.5.x/modules/groupcom/build/build.xml

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

Modified: tomcat/container/tc5.5.x/modules/groupcom/build/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/build/build.xml?rev=416789&r1=416788&r2=416789&view=diff
==
--- tomcat/container/tc5.5.x/modules/groupcom/build/build.xml (original)
+++ tomcat/container/tc5.5.x/modules/groupcom/build/build.xml Fri Jun 23 
11:27:08 2006
@@ -97,7 +97,7 @@
 
 
 
-
+
 
   
   

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java?rev=416789&r1=416788&r2=416789&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 Fri Jun 23 11:27:08 2006
@@ -143,6 +143,7 @@
 if (shutdown || !memberAlive(member)) {
 //not correct, we need to maintain the map
 membership.removeMember( (MemberImpl) member);
+removeSuspects.remove(member);
 notify = true;
 } else {
 //add the member as suspect



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r416806 - in /tomcat/container/tc5.5.x/modules/groupcom: ./ src/share/org/apache/catalina/tribes/group/interceptors/ src/share/org/apache/catalina/tribes/membership/

2006-06-23 Thread fhanik 
Author: fhanik
Date: Fri Jun 23 12:43:21 2006
New Revision: 416806

URL: http://svn.apache.org/viewvc?rev=416806&view=rev
Log:
Fixed some bugs

Modified:
tomcat/container/tc5.5.x/modules/groupcom/VERSION

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java

Modified: tomcat/container/tc5.5.x/modules/groupcom/VERSION
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/VERSION?rev=416806&r1=416805&r2=416806&view=diff
==
--- tomcat/container/tc5.5.x/modules/groupcom/VERSION (original)
+++ tomcat/container/tc5.5.x/modules/groupcom/VERSION Fri Jun 23 12:43:21 2006
@@ -1,3 +1,5 @@
+0.9.3.0
+  - fixed bugs
 0.9.2.9
   - jdk1.4 support for buffer pools
 0.9.2.8

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java?rev=416806&r1=416805&r2=416806&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
 Fri Jun 23 12:43:21 2006
@@ -151,7 +151,7 @@
 //stop the thread
 if ( run ) {
 synchronized (this) {
-if ( run && ((svc & Channel.SND_TX_SEQ)==svc)) {
+if ( run && ((svc & Channel.SND_TX_SEQ)==Channel.SND_TX_SEQ)) {
 stopQueue();
 }//end if
 }//sync

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java?rev=416806&r1=416805&r2=416806&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 Fri Jun 23 12:43:21 2006
@@ -150,7 +150,13 @@
 removeSuspects.put(member, new 
Long(System.currentTimeMillis()));
 }
 }
-if ( notify ) super.memberDisappeared(member);
+if ( notify ) {
+log.info("Verification complete. Member disappeared["+member+"]");
+super.memberDisappeared(member);
+} else {
+log.info("Verification complete. Member still alive["+member+"]");
+
+}
 }
 
 public boolean hasMembers() {

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java?rev=416806&r1=416805&r2=416806&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java
 Fri Jun 23 12:43:21 2006
@@ -202,7 +202,7 @@
 if ( sender != null ) throw new 
IllegalStateException("McastService.send already running.");
 if ( receiver == null ) socket.joinGroup(address);
 //make sure at least one packet gets out there
-send();
+send(false);
 doRunSender = true;
 serviceStartTime = System.currentTimeMillis();
 sender = new SenderThread(sendFrequency);
@@ -258,7 +258,7 @@
 byte[] payload = member.getPayload();
 member.setPayload(Member.SHUTDOWN_PAYLOAD);
 member.getData(true, true);
-send();
+send(false);
 //restore payload
 member.setPayload(payload);
 member.getData(true, true);
@@ -333,7 +333,7 @@
  * Send a ping
  * @throws Exception
  */ 
-public void send() throws IOException{
+public void send(boolean checkexpired) throws IOException{
 member.

svn commit: r416853 - /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java

2006-06-23 Thread fhanik 
Author: fhanik
Date: Fri Jun 23 19:00:01 2006
New Revision: 416853

URL: http://svn.apache.org/viewvc?rev=416853&view=rev
Log:
Be able to create the local member without actually starting the membership 
service

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java?rev=416853&r1=416852&r2=416853&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java
 Fri Jun 23 19:00:01 2006
@@ -134,7 +134,7 @@
  * Return the local member
  */
 public Member getLocalMember(boolean alive) {
-if ( alive && localMember != null ) 
localMember.setMemberAliveTime(System.currentTimeMillis()-impl.getServiceStartTime());
+if ( alive && localMember != null && impl != null) 
localMember.setMemberAliveTime(System.currentTimeMillis()-impl.getServiceStartTime());
 return localMember;
 }
 
@@ -148,8 +148,10 @@
 if (localMember != null) {
 localMember.setHostname(listenHost);
 localMember.setPort(listenPort);
-localMember.getData(true, true);
+} else {
+localMember = new MemberImpl(listenHost, listenPort, 0);
 }
+localMember.getData(true, true);
 }catch ( IOException x ) {
 throw new IllegalArgumentException(x);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]