date:20060605

Re: svn commit: r411541 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_ajp_common.h jk_util.c

2006-06-05 Thread David Rees


I noted a spelling mistake in the log line below, endpont should
probably be endpoint (missing i).

-Dave

On 6/4/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:

--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Sun Jun  4 
02:12:17 2006
@@ -1856,13 +1856,13 @@
 }
 if (JK_IS_DEBUG_LEVEL(l))
 jk_log(l, JK_LOG_DEBUG,
-"setting connection cache size to %u with min %u",
+"setting connection pool size to %u with min %u",
 p->ep_cache_sz, p->ep_mincache_sz);
 for (i = 0; i < p->ep_cache_sz; i++) {
 p->ep_cache[i] = (ajp_endpoint_t *)calloc(1, 
sizeof(ajp_endpoint_t));
 if (!p->ep_cache[i]) {
 jk_log(l, JK_LOG_ERROR,
-"creating endpont cache slot %d errno=%d",
+"creating endpont pool slot %d errno=%d",
 i, errno);
 JK_TRACE_EXIT(l);
 return JK_FALSE;


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r411543 - in /tomcat/connectors/trunk/jk/xdocs: changelog.xml config/workers.xml

2006-06-05 Thread David Rees


There is a spelling error below, incative should be inactive.

-Dave

On 6/4/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:

--- tomcat/connectors/trunk/jk/xdocs/config/workers.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/config/workers.xml Sun Jun  4 02:32:30 2006
@@ -172,9 +170,21 @@
 Do not use cachesize with values higher then 1 on Apache 2.x prefork or 
Apache 1.3.x!
 

-
-Cache timeout property should be used with cachesize to specify how to 
time JK should keep
-an open socket in cache before closing it. This property should be used to 
reduce the number of threads
+
+Minimum size of the connection pool that will be maintained.
+
+This property is used only when the connection_pool_size is specified.
+Its default value is connection_pool_size/2.
+
+Do not use connection_pool_size with values higher then 1 on Apache 2.x prefork or 
Apache 1.3.x!
+
+This feature has been added in jk 1.2.16.
+
+
+
+
+Cache timeout property should be used with connection_pool_size to 
specify how long JK should keep
+an incative socket in cache before closing it. This property should be used to 
reduce the number of threads
 on the Tomcat WebServer.
 
 Each child could open an ajp13 connection if it have to forward a request to 
Tomcat, creating


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r411713 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/config/workers.xml

2006-06-05 Thread mturk

Author: mturk
Date: Mon Jun  5 01:32:54 2006
New Revision: 411713

URL: http://svn.apache.org/viewvc?rev=411713&view=rev
Log:
Fix spelling. Thanks David :)

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
tomcat/connectors/trunk/jk/xdocs/config/workers.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=411713&r1=411712&r2=411713&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Mon Jun  5 
01:32:54 2006
@@ -1862,7 +1862,7 @@
 p->ep_cache[i] = (ajp_endpoint_t *)calloc(1, 
sizeof(ajp_endpoint_t));
 if (!p->ep_cache[i]) {
 jk_log(l, JK_LOG_ERROR,
-"creating endpont pool slot %d errno=%d",
+"allocating endpoint slot %d errno=%d",
 i, errno);
 JK_TRACE_EXIT(l);
 return JK_FALSE;

Modified: tomcat/connectors/trunk/jk/xdocs/config/workers.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/config/workers.xml?rev=411713&r1=411712&r2=411713&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/config/workers.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/config/workers.xml Mon Jun  5 01:32:54 2006
@@ -184,7 +184,7 @@
 
 
 Cache timeout property should be used with connection_pool_size to 
specify how long JK should keep
-an incative socket in cache before closing it. This property should be used to 
reduce the number of threads
+an inactive socket in cache before closing it. This property should be used to 
reduce the number of threads
 on the Tomcat WebServer.
 
 Each child could open an ajp13 connection if it have to forward a request to 
Tomcat, creating



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r411717 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c native/common/jk_ajp_common.h xdocs/changelog.xml xdocs/config/workers.xml

2006-06-05 Thread mturk

Author: mturk
Date: Mon Jun  5 01:50:10 2006
New Revision: 411717

URL: http://svn.apache.org/viewvc?rev=411717&view=rev
Log:
Added RECOVER_ABORT_IF_CLIENTERROR recovery_option
that closes the connection if client connection
is broken during the request.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h
tomcat/connectors/trunk/jk/xdocs/changelog.xml
tomcat/connectors/trunk/jk/xdocs/config/workers.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=411717&r1=411716&r2=411717&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Mon Jun  5 
01:50:10 2006
@@ -1753,6 +1753,10 @@
 }
 if (err == JK_CLIENT_ERROR) {
 *is_error = JK_HTTP_BAD_REQUEST;
+if (p->worker->recovery_opts & RECOVER_ABORT_IF_CLIENTERROR) {
+/* Mark the endpoint for shutdown */
+p->reuse = JK_FALSE;
+}
 jk_log(l, JK_LOG_INFO,
"Sending request to tomcat failed, "
"because of client error "

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h?rev=411717&r1=411716&r2=411717&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h Mon Jun  5 
01:50:10 2006
@@ -198,6 +198,7 @@
 
 #define RECOVER_ABORT_IF_TCGETREQUEST0x0001 /* DONT RECOVER IF TOMCAT FAIL 
AFTER RECEIVING REQUEST */
 #define RECOVER_ABORT_IF_TCSENDHEADER0x0002 /* DONT RECOVER IF TOMCAT FAIL 
AFTER SENDING HEADERS */
+#define RECOVER_ABORT_IF_CLIENTERROR 0x0006 /* CLOSE THE SOCKET IN CASE OF 
CLIENT ERROR */
 
 
 

Modified: tomcat/connectors/trunk/jk/xdocs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/changelog.xml?rev=411717&r1=411716&r2=411717&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/changelog.xml Mon Jun  5 01:50:10 2006
@@ -26,6 +26,10 @@
   
 
   
+  Added RECOVER_ABORT_IF_CLIENTERROR recovery_option that closes
+  the connection if client connection is broken during the request. (mturk)
+  
+  
   Renamed cache_timeout firective to connection_pool_timeout. (mturk)
   
   

Modified: tomcat/connectors/trunk/jk/xdocs/config/workers.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/config/workers.xml?rev=411717&r1=411716&r2=411717&view=diff
==
--- tomcat/connectors/trunk/jk/xdocs/config/workers.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/config/workers.xml Mon Jun  5 01:50:10 2006
@@ -385,6 +385,12 @@
 and works on all servlet engines supporting ajp13.
 Full recovery by default.
 
+If the value 4 is added to the recovery options, the connection
+between the webserver and tomcat will be closed if the client connection
+to the webserver is terminated during the request/response cycle. This allows
+to inform the servlet engine about broken client connections during lengthy 
operations.
+This features has been added in jk 1.2.16
+
 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r411719 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h

2006-06-05 Thread mturk

Author: mturk
Date: Mon Jun  5 01:52:12 2006
New Revision: 411719

URL: http://svn.apache.org/viewvc?rev=411719&view=rev
Log:
Fix typo. The flag should be 4 instead 6.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h?rev=411719&r1=411718&r2=411719&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h Mon Jun  5 
01:52:12 2006
@@ -198,7 +198,7 @@
 
 #define RECOVER_ABORT_IF_TCGETREQUEST0x0001 /* DONT RECOVER IF TOMCAT FAIL 
AFTER RECEIVING REQUEST */
 #define RECOVER_ABORT_IF_TCSENDHEADER0x0002 /* DONT RECOVER IF TOMCAT FAIL 
AFTER SENDING HEADERS */
-#define RECOVER_ABORT_IF_CLIENTERROR 0x0006 /* CLOSE THE SOCKET IN CASE OF 
CLIENT ERROR */
+#define RECOVER_ABORT_IF_CLIENTERROR 0x0004 /* CLOSE THE SOCKET IN CASE OF 
CLIENT ERROR */
 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: What happened to the mod_jk 1.2.16 release?

2006-06-05 Thread Mladen Turk


David Rees wrote:


OK, I see that mladen has recently checked in some jk changes. As soon
as he gives the word, I'll check out the latest from SVN and do some
testing.



Think I'm done with all the patches I had on my schedule.
Feel free to check the HEAD.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

2006-06-05 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project tomcat-tc6 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/gump_work/build_tomcat-tc6_tomcat-tc6.html
Work Name: build_tomcat-tc6_tomcat-tc6 (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-logging-api.jar=/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-05062006.jar
 
-Dtomcat-dbcp.jar=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-05062006.jar
 
-Djasper-jdt.jar=/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar
 
[Working Directory: /usr/local/gump/public/workspace/tomcat-tc6]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/tomcat-tc6/classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/packages/javamail-1.4/mail.jar:/usr/local/gump/packages/javamail-1.4/lib/mailapi.jar:/usr/local/gump/packages/jaf-1.1ea/activation.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-05062006.jar:/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar:/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-05062006.jar
-
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ClassNameMBean.java:36:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextEnvironmentMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextEnvironmentMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextResourceLinkMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextResourceLinkMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/DefaultContextMBean.java:40:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

2006-06-05 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project tomcat-tc6 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/gump_work/build_tomcat-tc6_tomcat-tc6.html
Work Name: build_tomcat-tc6_tomcat-tc6 (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-logging-api.jar=/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-05062006.jar
 
-Dtomcat-dbcp.jar=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-05062006.jar
 
-Djasper-jdt.jar=/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar
 
[Working Directory: /usr/local/gump/public/workspace/tomcat-tc6]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/tomcat-tc6/classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/packages/javamail-1.4/mail.jar:/usr/local/gump/packages/javamail-1.4/lib/mailapi.jar:/usr/local/gump/packages/jaf-1.1ea/activation.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-05062006.jar:/usr/local/gump/packages/eclipse-3.1M6/plugins/org.eclipse.jdt.core_3.1.0/jdtcore.jar:/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-05062006.jar
-
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ClassNameMBean.java:36:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextEnvironmentMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextEnvironmentMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextResourceLinkMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/ContextResourceLinkMBean.java:38:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 302726 $ $Date: 2004-02-27 15:59:07 +0100 
(ven., 27 f??vr. 2004) $
[javac] 
 ^
[javac] 
/x1/gump/public/workspace/tomcat-tc6/java/org/apache/catalina/mbeans/DefaultContextMBean.java:40:
 warning: unmappable character for encoding ASCII
[javac]  * @version $Revision: 303133

DO NOT REPLY [Bug 39721] New: - Request parameter is null

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39721

   Summary: Request parameter is null
   Product: Tomcat 5
   Version: Unknown
  Platform: Other
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


i have given request like this 
http://localhost:8082/sample/info.do?
senderMDN=100&buddyList=*.%,2&pm2=0&pm1=0&requestId=add&

System.out.println(request.getQueryString()); it is returning 
senderMDN=100&buddyList=*.%,2&pm2=0&pm1=0&requestId=add&

but System.out.println(request.getParameter("buddyList")); it is returning null

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Bug + Patch on StandardPipeline.removeValve(Valve valve) for T5.5.16+

2006-06-05 Thread David Gagnon


Hi all,

 I run into this problem with T5 when tring to add/remove/add a valve 
to the standard engine. 
-For what I understand an empty pipeline has:

basic = StandardEngineValve (For example);
first = null;

-If you add a valve you will get
basic = StandardEngineValve
first = myValve (with myValve.next = StandardEngineValve)

-If you remove the valve you will get
basic =StandardEngineValve
first = StandardEngineValve
Note that StandardEngineValve is in first too here.

-If I try to add a new valve given the actual code in  addValve the 
valve will not be added because (see the **) current = basic and 
current.getNext() = null;


addValve(Valve valve) {
  


   // Add this Valve to the set associated with this Pipeline
   if (first == null) {
   first = valve;
   valve.setNext(basic);
   } else {
   Valve current = first;
   while (current != null) {
**if (current.getNext() == basic) {
   current.setNext(valve);
   valve.setNext(basic);
   break;
   }
   current = current.getNext();
   }
   }

   }


PATCH:
For what I understand the right patch will be in the removeValve 
method.  We need to remove the basic valve when that the only one in the 
pipeline:


public void removeValve(Valve valve) {

   Valve current;
   if(first == valve) {
   first = first.getNext();
   current = null;
   } else {
   current = first;
   }
   while (current != null) {
   if (current.getNext() == valve) {
   current.setNext(valve.getNext());
   break;
   }
   current = current.getNext();
   }

// PATCH: Empty the pipeline if only the basic valve is there
   if (first == basic) first == null;

   if (valve instanceof Contained)
   ((Contained) valve).setContainer(null);

   // Stop this valve if necessary
   if (started) {
   if (valve instanceof Lifecycle) {
   try {
   ((Lifecycle) valve).stop();
   } catch (LifecycleException e) {
   log.error("StandardPipeline.removeValve: stop: ", e);
   }
   }
   // Unregister the removed valave
   unregisterValve(valve);
   }
  
   }


Hope that oki.  I look the 5.5.17 code and the problem is still there.  
Is that the right way to submit a Patch. If I need to open a bug 
directly, let me know




Best Regard
/David


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bug + Patch on StandardPipeline.removeValve(Valve valve) for T5.5.16+

2006-06-05 Thread Mark Thomas

David Gagnon wrote:
> Hope that oki.  I look the 5.5.17 code and the problem is still there. 
> Is that the right way to submit a Patch. If I need to open a bug
> directly, let me know

It is usually best to open a bug report and attach your patch. This
way, it is less likely to get overlooked if someone doesn't apply the
patch immediately.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39724] New: - Bug on StandardPipeline.removeValve(Valve valve) for T5.5.16+

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39724

   Summary: Bug on StandardPipeline.removeValve(Valve valve) for
T5.5.16+
   Product: Tomcat 5
   Version: 5.5.16
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I run into this problem with T5 when tring to add/remove/add a valve to the
standard engine. -For what I understand an empty pipeline has:
basic = StandardEngineValve (For example);
first = null;

-If you add a valve you will get
basic = StandardEngineValve
first = myValve (with myValve.next = StandardEngineValve)

-If you remove the valve you will get
basic =StandardEngineValve
first = StandardEngineValve
Note that StandardEngineValve is in first too here.

-If I try to add a new valve given the actual code in  addValve the valve will
not be added because (see the **) current = basic and current.getNext() = null;

addValve(Valve valve) {
 
   // Add this Valve to the set associated with this Pipeline
   if (first == null) {
   first = valve;
   valve.setNext(basic);
   } else {
   Valve current = first;
   while (current != null) {
**if (current.getNext() == basic) {
   current.setNext(valve);
   valve.setNext(basic);
   break;
   }
   current = current.getNext();
   }
   }

   }

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39724] - Bug on StandardPipeline.removeValve(Valve valve) for T5.5.16+

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39724





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 14:03 ---
Created an attachment (id=18402)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18402&action=view)
The patch on the removeValve Method


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39699





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 20:57 ---
(In reply to comment #18)
> test case, meaning maybe a zip containing your config files, any modifications
> that you have made two tomcat, ie, added in log4j etc.
> 
> ie, can you get us detailed instructions on how to exactly reproduce your
> problem. just saying that deploy an app and it breaks, it simply not 
> sufficient,
> as our apps are deploying.

I have made some progress with a "simple" test case. Here are the steps:

1) download vanilla tomcat .tar.gz (5.5.17)
2) tar xzvf /home/haroon/src/dist/apache-tomcat-5.5.17.tar.gz
3) cd apache-tomcat-5.5.17/conf/
4) edit server.xml to uncomment the  config (leave everything else as 
is)
5) edit tomcat-users.xml so that you have a username/password with role 
"manager"
6) cd ../bin
7) ./startup.sh
8) After tomcat starts up, deploy testcase by copying
servlets-examples-cluster-node1.war to ../webapps (I will attach .war file in
next comment)
9) context deploys fine
10) go to http://localhost:8080/manager/html/list in your browser
11) Watch your catalina.out as you click on Reload for
servlets-examples-cluster-node1 and get the error.

Questions?


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39699





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 20:58 ---
Created an attachment (id=18406)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18406&action=view)
testcase describing cluster related reload of distributable webapps which
contain log4j


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39699





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 21:03 ---
(In reply to comment #20)

> testcase describing cluster related reload of distributable webapps which
> contain log4j
> 

To give you some information about how I created this "sample testcase" app.

* I obtained the file from
http://opensource.atlassian.com/confluence/oss/pages/viewpageattachments.action?pageId=2578
which is a page for listing the attachments for the wiki article at:
http://opensource.atlassian.com/confluence/oss/display/GERONIMO/Geronimo+Clustering+Example

* After that I added a simple log4j.properties in WEB-INF/classes

---begin-
# This is the configuration for logging displayed in the Application Server
log4j.rootLogger=INFO, stdout

log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.PatternLayout

# Pattern to output the caller's file name and line number.
log4j.appender.stdout.layout.ConversionPattern=%d{ISO8601} %p [%t] %C{1}.%M(%L)
|%m%n
-cut-

* copied commons-logging.jar (I think 1.0.4) and log4j-1.2.13.jar in WEB-INF/lib

That is the exact jar that you see in the attachment in the previous comment.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39699





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 21:04 ---
(In reply to comment #21)
> 
> That is the exact jar that you see in the attachment in the previous comment.

oops... meant to say war file (instead of jar)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39728] New: - Tomcat throws Security Exception when using signed activation.jar

2006-06-05 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39728

   Summary: Tomcat throws Security Exception when using signed
activation.jar
   Product: Tomcat 5
   Version: 5.0.28
  Platform: Other
OS/Version: Linux
Status: NEW
  Keywords: ErrorMessage
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Greetings,

I am currently working on a Sun Identity Manager installation on Linux and found
that when I download and use the mail and activation JAR files from Sun
contained within jaf-1_1-fr.zip - Tomcat throws an erroneous exception which
states the signers of all the classes within the JAR do not match.

The JAR itself verifies without a problem: jarsigner -verify -verbose
./activation.jar

There is only this single activation.jar file on the system and the only way
thus far I've found to alleviate this exception is to use an unsigned
activation.jar which comes with NetBeans 5.0

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r411968 - /tomcat/container/tc5.5.x/modules/groupcom/VERSION

2006-06-05 Thread fhanik

Author: fhanik
Date: Mon Jun  5 18:55:22 2006
New Revision: 411968

URL: http://svn.apache.org/viewvc?rev=411968&view=rev
Log:
just a small update to release a new build on the website

Modified:
tomcat/container/tc5.5.x/modules/groupcom/VERSION

Modified: tomcat/container/tc5.5.x/modules/groupcom/VERSION
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/modules/groupcom/VERSION?rev=411968&r1=411967&r2=411968&view=diff
==
--- tomcat/container/tc5.5.x/modules/groupcom/VERSION (original)
+++ tomcat/container/tc5.5.x/modules/groupcom/VERSION Mon Jun  5 18:55:22 2006
@@ -1,4 +1,6 @@
-0.0.2.4
+0.9.2.5
+  - minor updates
+0.9.2.4
   - leader election, work in progress
 0.9.2.3
   - Keep alive pings for AbstractReplicatedMap



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: What happened to the mod_jk 1.2.16 release?

2006-06-05 Thread David Rees


On 6/5/06, Mladen Turk <[EMAIL PROTECTED]> wrote:

Think I'm done with all the patches I had on my schedule.
Feel free to check the HEAD.


I built the latest from SVN today and ran a few of my applications
through it and didn't notice any anomalies. Looks good so far, thanks!

-Dave

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r411541 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_ajp_common.h jk_util.c

Re: svn commit: r411543 - in /tomcat/connectors/trunk/jk/xdocs: changelog.xml config/workers.xml

svn commit: r411713 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/config/workers.xml

svn commit: r411717 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c native/common/jk_ajp_common.h xdocs/changelog.xml xdocs/config/workers.xml

svn commit: r411719 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.h

Re: What happened to the mod_jk 1.2.16 release?

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

DO NOT REPLY [Bug 39721] New: - Request parameter is null

Bug + Patch on StandardPipeline.removeValve(Valve valve) for T5.5.16+

Re: Bug + Patch on StandardPipeline.removeValve(Valve valve) for T5.5.16+

DO NOT REPLY [Bug 39724] New: - Bug on StandardPipeline.removeValve(Valve valve) for T5.5.16+

DO NOT REPLY [Bug 39724] - Bug on StandardPipeline.removeValve(Valve valve) for T5.5.16+

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

DO NOT REPLY [Bug 39699] - simple deploy failed in cluster (distributable flag)

DO NOT REPLY [Bug 39728] New: - Tomcat throws Security Exception when using signed activation.jar

svn commit: r411968 - /tomcat/container/tc5.5.x/modules/groupcom/VERSION

Re: What happened to the mod_jk 1.2.16 release?

20 matches

Site Navigation

Mail list logo

Footer information