svn commit: r398381 - /tomcat/watchdog/branches/tc4.1.x/src/tools/org/apache/watchdog/jspxml/jsp2XML.java

[markt]

Author: markt
Date: Sun Apr 30 10:01:47 2006
New Revision: 398381

URL: http://svn.apache.org/viewcvs?rev=398381&view=rev
Log:
JSP comments should be dropped when converting to xml. This was causing a 
number of test failures with 4.1.x

Modified:

tomcat/watchdog/branches/tc4.1.x/src/tools/org/apache/watchdog/jspxml/jsp2XML.java

Modified: 
tomcat/watchdog/branches/tc4.1.x/src/tools/org/apache/watchdog/jspxml/jsp2XML.java
URL: 
http://svn.apache.org/viewcvs/tomcat/watchdog/branches/tc4.1.x/src/tools/org/apache/watchdog/jspxml/jsp2XML.java?rev=398381&r1=398380&r2=398381&view=diff
==
--- 
tomcat/watchdog/branches/tc4.1.x/src/tools/org/apache/watchdog/jspxml/jsp2XML.java
 (original)
+++ 
tomcat/watchdog/branches/tc4.1.x/src/tools/org/apache/watchdog/jspxml/jsp2XML.java
 Sun Apr 30 10:01:47 2006
@@ -221,12 +221,10 @@
 
 if ( jsp_char == '-' ) //jsp Comment
 {
+// JSP comments are not included in the XML view JSP.5.3.3
 xml += "]]>" + new_line ; //end of CDATA section
 cdata_closed = true;
-xml += new_line + "" ;
 last_index = end_index + 4;
 continue;
 } //end JSP Comment



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39452] New: - IIS ISAPI MOD_JK omits headers when run as application extension

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39452

   Summary: IIS ISAPI MOD_JK omits headers when run as application
extension
   Product: Tomcat 5
   Version: 5.5.17
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:JK
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I wanted the default document in IIS to be index.jsp and handled by Tomcat. I 
couldn't write a URI rule to match this so I configured isapi_redirect.dll to 
run as an application extension for .jsp. I found this didn't work in all 
browsers. I use virtual hosts and depending on what browser I used, Tomcat 
wasn't matching the host in server.xml. The reason is jk_isapi_plugin.c was 
omitting the last two headers in all cases, assuming they were the special 
ones added by the filter. In my case those two weren't there and depending on 
what headers a certain browser sent, HTTP_HOST was one of the last two that 
got ommitted.

Since there was already code to ignore the special headers if they weren't 
skipped by subtracting 2 off the header count, I just had to comment out one 
line of code:
   cnt -= 2;   /* For our two special headers:
and insert one:
   cnt--;
just after the if clause that starts with:
   if (!strnicmp(tmp, URI_HEADER_NAME, strlen(URI_HEADER_NAME))

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Bug report for Tomcat 3 [2006/04/30]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 2350|Ver|Nor|2001-06-27|ServletConfig.getInitParameter() requires url-patt|
| 2478|Opn|Cri|2001-07-06|Passing Session variables between JSP's and Servle|
| 4551|Opn|Nor|2001-10-31|Ctx( /tt01 ): IOException in: R( /tt01 + /com/abc/|
| 4980|New|Min|2001-11-20|Startup message indicates incorrect log file  |
| 4994|New|Nor|2001-11-21|Tomcat needs a mechanism for clean and certain shu|
| 5064|New|Cri|2001-11-25|Socket write error when include files is more than|
| 5108|New|Maj|2001-11-26|Docs for Tomcat 3.2.x appear to be for Tomcat 3.3 |
| 5137|New|Nor|2001-11-27|Null pointer in class loader after attempting to r|
| 5160|Unc|Maj|2001-11-28|'IllegalStateException'   |
| 5331|New|Nor|2001-12-09|getPathInfo vs URL normalization  |
| 5510|New|Blk|2001-12-19|How to call ejb deployed in JBoss from Tomcat serv|
| 5756|New|Nor|2002-01-08|jspc.bat exits with wrong ERRORLEVEL  |
| 5797|New|Nor|2002-01-10|UnCatched ? StringIndexOutOfBoundsException: Strin|
| 6027|New|Maj|2002-01-25|Tomcat  Automatically shuts down as service   |
| 6168|New|Blk|2002-02-01|IllegalStateException |
| 6451|New|Cri|2002-02-14|Stackoverflow |
| 6478|New|Enh|2002-02-14|Default Tomcat Encoding   |
| 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c|
| 6648|New|Nor|2002-02-25|jakarta-servletapi build with java 1.4 javadoc err|
| 6989|New|Maj|2002-03-08|Unable to read tld file during parallel JSP compil|
| 7013|New|Cri|2002-03-10|Entering a servlet path with non-ISO8859-1 charact|
| 7227|New|Nor|2002-03-19| directive don't work |
| 7626|New|Nor|2002-03-29|classloader not working properly  |
| 7652|New|Cri|2002-04-01|Tomcat stalls periodically|
| 7785|New|Blk|2002-04-06|tomcat bug in context reloading   |
| 7863|New|Maj|2002-04-09|I have a problem when running Tomcat with IIS |
| 8187|New|Cri|2002-04-17|Errors when Tomcat used with MS Access database   |
| 8239|New|Cri|2002-04-18|Resource temporary unavailable|
| 8263|New|Cri|2002-04-18|url-pattern easy to circumvent|
| 9250|New|Maj|2002-05-20|outOfMemoryError  |
| 9367|New|Maj|2002-05-23|HttpSessionBindingEvent not thrown for HttpSession|
| 9390|New|Nor|2002-05-24|jasper compilation error in tomcat|
| 9480|New|Nor|2002-05-29|Data connection pooling   |
| 9607|New|Maj|2002-06-04|precompile JSP|
| 9737|Ver|Nor|2002-06-10|ArrayIndexOutOfBoundsException when sending just p|
|10047|New|Cri|2002-06-20|IllegalStateException |
|10202|New|Maj|2002-06-25|Tomcat is not responding in time  |
|10357|Unc|Blk|2002-06-30|java.lang.IllegalArgumentException: Short Read|
|10406|New|Cri|2002-07-02|IllegalStateException |
|11087|New|Blk|2002-07-23|IllegalStateException |
|11286|New|Maj|2002-07-30|Tomcat threads not respond if increase JVM size   |
|11466|New|Nor|2002-08-05|ContextManager: SocketException reading request   |
|12156|New|Cri|2002-08-29|Apache and Tomcat 3.3.1 Interworking problem  |
|12194|New|Maj|2002-08-30|Tomcat does not send WWW-Authenticate header  |
|12852|New|Nor|2002-09-20|May be error in _jspService() -> out.flushBuffers(|
|14386|New|Maj|2002-11-08|Date headers corrupted using setDateHeader|
|15632|New|Nor|2002-12-23|Problem with the Tomcat Sessions Parameter on URL |
|16363|New|Cri|2003-01-23|Stack Overflow accessing compiled JSP - Tomcat 3.2|
|17915|New|Maj|2003-03-12|Jasper ignores manifest classpath |
|19114|New|Nor|2003-04-17|RequestDispatcherImpl does not set root cause exce|
|19143|New|Nor|2003-04-18|if TOMCAT_INSTALL differs from TOMCAT_HOME -sequri|
|20238|New|Maj|2003

Bug report for Tomcat 4 [2006/04/30]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 3839|Opn|Enh|2001-09-26|Problem bookmarking login page|
| 4227|Opn|Enh|2001-10-17|Invalid CGI path  |
| 5329|New|Enh|2001-12-08|NT Service exits startup before Tomcat is finished|
| 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob|
| 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi|
| 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio|
| 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI|
| 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam|
| 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty|
| 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store   |
| 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output|
| 7676|New|Enh|2002-04-02|Allow name property to use match experssions in  without className in server.xml produces N|
|11069|Opn|Enh|2002-07-23|Tomcat not flag error if tld is outside of /WEB-IN|
|11129|New|Enh|2002-07-24|New valve for putting the sessionIDs in the reques|
|11248|New|Enh|2002-07-29|DefaultServlet doesn't send expires header|
|11754|Opn|Enh|2002-08-15|Synchronous shutdown script - shutdown.sh should w|
|12069|New|Enh|2002-08-27|Creation of more HttpSession objects for one previ|
|12658|New|Enh|2002-09-15|a proxy host and port at the  element level |
|12766|New|Enh|2002-09-18|Tomcat should use tld files in /WEB-INF/ over vers|
|13309|Opn|Enh|2002-10-04|Catalina calls System.exit()  |
|13634|New|Enh|2002-10-15|Allowing system properties to be substituted in co|
|13689|Opn|Enh|2002-10-16|Classloader paths for 'Common' classes and librari|
|13731|New|Enh|2002-10-17|Final request, response, session and other variabl|
|13941|New|Enh|2002-10-24|reload is VERY slow   |
|13965|New|Enh|2002-10-25|Catalina.sh correction request for Tru64 Unix |
|14097|New|Enh|2002-10-30|hardcoded registry value for vm lets tomcat servic|
|14416|New|Enh|2002-11-10|blank tag name in TLD cause NullPointerException  |
|14635|New|Enh|2002-11-18|Should be possible not to have -MM-DD in log f|
|14766|New|Enh|2002-11-22|Redirect Vavle|
|14993|New|Enh|2002-12-02|Possible obselete synchronized declaration|
|15115|New|Enh|2002-12-05|correct docs... XML parser *cannot* be overridden |
|15417|Opn|Enh|2002-12-16|Add port for forced compilation of JSP pages  |
|15688|New|Enh|2002-12-27|full-qualified names instead of imports   |
|15893|New|Enh|2003-01-08|Need a getPort() method on Connector or similar fu|
|15941|New|Enh|2003-01-10|Expose rootCause exceptions at deeper levels  |
|16294|New|Enh|2003-01-21|Configurable URL Decoding.|
|16357|New|Enh|2003-01-23|"connection timeout reached"  |
|16531|New|Enh|2003-01-29|Updating already deployed ".war" files in a single|
|16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to|
|16596|New|Enh|2003-01-30|option for disabling log rotation |
|17070|New|Enh|2003-02-14|The Catalina Ant tasks do not allow for 'reusable'|
|17146|New|Enh|2003-02-18|Simplify build.xml using 

Bug report for Tomcat 5 [2006/04/30]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|17310|Ver|Nor|2003-02-22|;jsessionid confuses StandardHostcan't find Co|
|19803|Ver|Maj|2003-05-09|manager reload fails and disables app - Incompatib|
|19958|Ver|Maj|2003-05-15|Problems reading ServletInputStream   |
|20268|Inf|Min|2003-05-27|Tomcat 5.0.2 takes 100% CPU   |
|21045|Ver|Nor|2003-06-24|Manager app does find resources   |
|21600|Ver|Nor|2003-07-15|'s lost after manager stop/start or rel|
|22679|Ver|Enh|2003-08-24|how to access ssl session ID out of tomcat to prev|
|22986|Ver|Nor|2003-09-08|Web apps with context XML file don't start if CATA|
|24413|Ver|Nor|2003-11-04|bundled JMX implementation not compliant to specif|
|24943|Ver|Nor|2003-11-24|Tomcat 5.0.14 / Windows 2000 Service does not star|
|25078|Ver|Nor|2003-11-29|Catalina Ant Serverinfo task always fails |
|27338|Ver|Maj|2004-03-01|Wrong mappings for JSP Documents (.jspx)  |
|28039|New|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|28634|Ass|Enh|2004-04-27|Extend StandardManager/StandardSession for DeltaMa|
|28709|Ver|Nor|2004-04-30|javax.servlet.http.HttpServletRequest.isRequestedS|
|28875|Ver|Nor|2004-05-10|Multi-byte characters in default error page aren't|
|29091|Opn|Nor|2004-05-19|Non-ascii characters are not handled correctly... |
|29160|Ver|Enh|2004-05-23|precompile problem: _jspx_meth_* (javax.servlet.js|
|29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi|
|29497|Unc|Nor|2004-06-10|Connection pool, redeployment |
|29521|Ver|Cri|2004-06-11|No destroy methods called on service shutdown |
|30155|Opn|Cri|2004-07-16|Problem with viewing mail session |
|30241|Ver|Enh|2004-07-21|Enhance build script to use branch argument when c|
|30489|Opn|Cri|2004-08-05|removeAttribute: Session already invalidated  |
|30833|Ver|Nor|2004-08-24|request.getServerPort() returns wrong port (WAS: r|
|31339|Inf|Maj|2004-09-21|admin app throwing struts exceptions  |
|32180|New|Nor|2004-11-11|EL functions are executed in privileged context   |
|32280|Ver|Cri|2004-11-17|Problem clustering tomcat when a failed server is |
|32569|Ass|Nor|2004-12-07|ServletContextListener will not die   |
|32593|Inf|Maj|2004-12-09|Server (Apache 2.0.48) reached MaxClients setting |
|32754|Inf|Nor|2004-12-17|Can't modify thread configuration attributes of AJ|
|32832|Ver|Maj|2004-12-23|request.getSession(false) fails to return null.   |
|33180|Ver|Nor|2005-01-20|JSTL automatic type conversion gives unexpected re|
|33262|Inf|Nor|2005-01-27|Service Manager autostart should check for adminis|
|33356|Inf|Maj|2005-02-02|Incorrect parsing of tag attributes   |
|33407|Inf|Nor|2005-02-05|\$ is quoted even with el-ignored=true|
|33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps|
|33650|Inf|Enh|2005-02-19|Jasper performance for multiple files processing  |
|33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na|
|33806|Opn|Min|2005-03-02|Session tracking using URL rewriting fails, if cli|
|33831|Ver|Nor|2005-03-03|RequestDispatcher.forward and resource missing|
|34006|Ver|Nor|2005-03-14|Undeploy of webapps with antiResourceLocking in ME|
|34016|Ver|Nor|2005-03-15|antiResourceLocking webapp fails to deploy on Tomc|
|34033|Ver|Nor|2005-03-16|Cannot delete users using Administration Tool weba|
|34076|Inf|Nor|2005-03-18|overriding content.xml docBase with manager webapp|
|34319|New|Nor|2005-04-06|StoreBase.processExpires() is very inefficient|
|34396|Inf|   |2005-04-11|security exception using datasource in|
|35635|New|Nor|2005-07-06|Tomcat service does not log startup error messages|
|35746|Inf|Nor|2005-07-14|session manager should be immune to system clock t|
|35765|New|Enh|2005-07-16|make the SSL cipher config in server.xml fail safe|
|35827|Inf|Blk|2005-07-22|Problem with POST forms with jk connector/IIS/Wind|
|35835|Inf

Bug report for Watchdog [2006/04/30]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|  278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug|
|  279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug|
|  469|Unc|Nor|2001-01-17|in example-taglib.tld "urn" should be "uri" BugRat|
|  470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B|
| 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths|
|10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher|
|11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward()|
|11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav|
|11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie|
|11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro|
|11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid.|
|14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec|
|15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv|
|24649|New|Nor|2003-11-12|getRemoteHost fails when agent has uppercase chara|
|29398|New|Nor|2004-06-04|Update site and note current status   |
+-+---+---+--+--+
| Total   15 bugs   |
+---+

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39441] - new Deployer is all over the show

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39441





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 00:33 ---
Remy,  please forward this the tomcat Product Manager for review.

No, I don't believe I have any special needs whatsoever.  Just the ability to
specify basic Context details, for what I have deployed.

The fact that there are issues with this,  sticks out like a sore thumb. (!)

Perhaps you could kindly either forward me the email of the Product Manager, who
can either enlighten me/ or address the issues I've raised.  This way we can
determine what to do without necessarily being tedious by re-opening the issue.

Thanks.
Thomas


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39441] - new Deployer is all over the show

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39441





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 00:41 ---
(In reply to comment #2)
> Perhaps you could kindly either forward me the email of the Product Manager, 
who
> can either enlighten me/ or address the issues I've raised.  This way we can
> determine what to do without necessarily being tedious by re-opening the 
issue.
> Thanks.
> Thomas

To the extent that there is a Product Manager on an Open Source project like 
Tomcat, the email address would be remm  apache.org (aka Remy :).



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39441] - new Deployer is all over the show

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39441





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 01:07 ---
saw your response on the 'tomcat-dev' list, William.

ok - for now I'm going to go away and read up heavy on the docs, just in case
this thing *might* make sense.

HOWEVER--
1)  off the cuff, the 'concept' here seems unsound
2)  NG posts and others with simple/ trivial needs, are finding problems here?
   ... and being given the shove-off like from Remy just above  :-)
3)  i'm going to call this early as SMELL.

i'll come back to you guys once I determine in-depth whether I'm right or wrong.

one thing for you guys to think about:  
Tomcat already has a 'working' directory.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]