DO NOT REPLY [Bug 37455] - https/sll hangs with tcnative-1.dll

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37455





--- Additional Comments From [EMAIL PROTECTED]  2006-03-24 08:19 ---
It took me two days to find out that my "full install" of tomcat 5.5.15 on
Windows 2003 actually had APR enabled, and that my SSL config did not work
because of this.

The log should most definitely contain an error if the wrong configuration
format is used, and it should contain the information during startup if APR is
enabled.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37455] - https/sll hangs with tcnative-1.dll

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37455


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39093] New: - Tomcat messes up when a class has the same name as a package

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39093

   Summary: Tomcat messes up when a class has the same name as a
package
   Product: Tomcat 5
   Version: 5.5.16
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: major
  Priority: P2
 Component: Servlet & JSP API
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I've found something that appears to be a bug in TC 5.5.16 . After a small 
check, it however, also occured in TC 5.5.15, so it might even be older.
Tomcat 4.0.6 (using JDK 1.4), however, did *not* have this problem.

I've got the following class/package structure:

1: nl.hhv.merlin.gui.editor.EditButtons
2: nl.hhv.merlin.gui.Editor
3: nl.hhv.merlin.gui.editor2.EditButtons

Note that packagename of the first class is equal to the fully qualified
name of the second class (except for caps/nocaps). This should be no problem
right?!? At least it never was until now.

Now I have a JSP that simply does:

<%
  nl.hhv.merlin.gui.editor.EditButtons buttons = null;
%>

Eclipse has no problems with this JSP, and happily accepts it, why shouldn't
it? Looks fine to me to :-) But Tomcat 5.5.16 gives me the following error:

  Generated servlet error:
  nl.hhv.merlin.gui.editor cannot be resolved to a type

When I change my JSP to:

<%
  nl.hhv.merlin.gui.editor2.EditButtons buttons = null;
%>

Tomcat compiles the JSP without any problems. Note that the 2nd EditButtons
class is an EXACT copy of the first.

I've tried to reproduce the same issue with different class and package-names, 
but then it seems to work!?!?

Anyway, I've attached a small ZIP which can be unpacked into the TC webapps 
dir, to try this out yourselves. It also contains the Java sources. Check out 
the remarks in index.jsp for more weirdness :-)

The provided class files have been compiled using Eclipse 3.1.2 (so not the JDK 
compiler). I'm running TC on Java 1.5.0_06.

Kind regards,
Paul Hamer

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39093] - Tomcat messes up when a class has the same name as a package

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39093





--- Additional Comments From [EMAIL PROTECTED]  2006-03-24 08:53 ---
Created an attachment (id=17966)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17966&action=view)
TC webapp to test this yourselves


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Requesting volunteers to regression test commons-logging release candidate

[robert burrell donkin]

On 3/24/06, Costin Manolache <[EMAIL PROTECTED]> wrote:
>
> An alternative is to use the 'no discovery, no plugins, no layers'
> implementation of commons-logging
> that we have in sandbox :-) - which just implements the commons-logging
> APIs
> hardcoding everything to java.util.logging. People who want log4j or
> another
> logger can replace
> the jar with the 'official' discovery-based implementation if they need
> it.
>
> There are a lot of benefits of having a logger with discovery and a
> mini-logger if no real logger is found, but
> for tomcat we know java.util will be found, and it avoids a lot of
> problems
> to just use the hardcoded one.


+1

sounds like a good plan

static binding has many advantages especially when dealing with high level
classloaders. it should also be much more preformant. i'll check out the
sandbox this weekend and double check the implementation for any known
issues with static binding JCL implementations.

if a user deploys a web application that uses and ships with JCL, then AFAIK
when deployed in a parent-last classloader the dynamic discovery mechanism
should work fine.

may need to check that the workaround put in place for the hot deployment
memory leak functions ok with the proposed configuration.

- robert

svn commit: r388500 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[remm]

Author: remm
Date: Fri Mar 24 04:37:27 2006
New Revision: 388500

URL: http://svn.apache.org/viewcvs?rev=388500&view=rev
Log:
- As suggested by Peter, replace the (synced) Stack with a specialized unsynced 
stack.

Modified:

tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=388500&r1=388499&r2=388500&view=diff
==
--- 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
(original)
+++ 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
Fri Mar 24 04:37:27 2006
@@ -19,7 +19,6 @@
 import java.net.InetAddress;
 import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.Stack;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -109,10 +108,9 @@
 
 
 /**
- * Available processors.
+ * Available workers.
  */
-// FIXME: Stack is synced, which makes it a non optimal choice
-protected Stack workers = new Stack();
+protected WorkerStack workers = null;
 
 
 /**
@@ -510,7 +508,7 @@
 
 if (initialized)
 return;
-
+
 // Create the root APR memory pool
 rootPool = Pool.create(0);
 // Create the pool for the server socket
@@ -625,6 +623,9 @@
 running = true;
 paused = false;
 
+// Create worker collection
+workers = new WorkerStack(maxThreads);
+
 // Start acceptor thread
 acceptorThread = new Thread(new Acceptor(), getName() + 
"-Acceptor");
 acceptorThread.setPriority(threadPriority);
@@ -808,7 +809,7 @@
 synchronized (workers) {
 if (workers.size() > 0) {
 curThreadsBusy++;
-return ((Worker) workers.pop());
+return (workers.pop());
 }
 if ((maxThreads > 0) && (curThreads < maxThreads)) {
 curThreadsBusy++;
@@ -1516,5 +1517,60 @@
 public boolean process(long socket);
 }
 
+
+// - WorkerStack Inner 
Class
+
+
+public class WorkerStack {
+
+protected Worker[] workers = null;
+protected int end = 0;
+
+public WorkerStack(int size) {
+workers = new Worker[size];
+}
+
+/** 
+ * Put the object into the queue.
+ * 
+ * @param   object  the object to be appended to the queue (first 
element). 
+ */
+public void push(Worker worker) {
+workers[end++] = worker;
+}
+
+/**
+ * Get the first object out of the queue. Return null if the queue
+ * is empty. 
+ */
+public Worker pop() {
+if (end > 0) {
+return workers[--end];
+}
+return null;
+}
+
+/**
+ * Get the first object out of the queue, Return null if the queue
+ * is empty.
+ */
+public Worker peek() {
+return workers[end];
+}
+
+/**
+ * Is the queue empty?
+ */
+public boolean isEmpty() {
+return (end == 0);
+}
+
+/**
+ * How many elements are there in this queue?
+ */
+public int size() {
+return (end);
+}
+}
 
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388515 - /tomcat/container/tc5.5.x/modules/groupcom/to-do.txt

[fhanik]

Author: fhanik
Date: Fri Mar 24 05:14:35 2006
New Revision: 388515

URL: http://svn.apache.org/viewcvs?rev=388515&view=rev
Log:
added job

Modified:
tomcat/container/tc5.5.x/modules/groupcom/to-do.txt

Modified: tomcat/container/tc5.5.x/modules/groupcom/to-do.txt
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/to-do.txt?rev=388515&r1=388514&r2=388515&view=diff
==
--- tomcat/container/tc5.5.x/modules/groupcom/to-do.txt (original)
+++ tomcat/container/tc5.5.x/modules/groupcom/to-do.txt Fri Mar 24 05:14:35 2006
@@ -34,6 +34,8 @@
 
 Code Tasks:
 ===
+33. PerfectFDInterceptor, when a member is reported missing, first check TCP 
path too.
+
 32. Replicated JNDI entries in Tomcat in the format
 cluster:/ for example
 cluster:myapps/db/shared/dbinfo



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r388500 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[Peter Rossbach]

Cool catch  => Use simple data structure, with fine performance  
impact. :-)

Peter

Am 24.03.2006 um 13:37 schrieb [EMAIL PROTECTED]:


Author: remm
Date: Fri Mar 24 04:37:27 2006
New Revision: 388500

URL: http://svn.apache.org/viewcvs?rev=388500&view=rev
Log:
- As suggested by Peter, replace the (synced) Stack with a  
specialized unsynced stack.


Modified:
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/ 
AprEndpoint.java


Modified: tomcat/connectors/trunk/util/java/org/apache/tomcat/util/ 
net/AprEndpoint.java
URL: http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/ 
java/org/apache/tomcat/util/net/AprEndpoint.java? 
rev=388500&r1=388499&r2=388500&view=diff
== 

--- tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/ 
AprEndpoint.java (original)
+++ tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/ 
AprEndpoint.java Fri Mar 24 04:37:27 2006

@@ -19,7 +19,6 @@
 import java.net.InetAddress;
 import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.Stack;

 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -109,10 +108,9 @@


 /**
- * Available processors.
+ * Available workers.
  */
-// FIXME: Stack is synced, which makes it a non optimal choice
-protected Stack workers = new Stack();
+protected WorkerStack workers = null;


 /**
@@ -510,7 +508,7 @@

 if (initialized)
 return;
-
+
 // Create the root APR memory pool
 rootPool = Pool.create(0);
 // Create the pool for the server socket
@@ -625,6 +623,9 @@
 running = true;
 paused = false;

+// Create worker collection
+workers = new WorkerStack(maxThreads);
+
 // Start acceptor thread
 acceptorThread = new Thread(new Acceptor(), getName()  
+ "-Acceptor");

 acceptorThread.setPriority(threadPriority);
@@ -808,7 +809,7 @@
 synchronized (workers) {
 if (workers.size() > 0) {
 curThreadsBusy++;
-return ((Worker) workers.pop());
+return (workers.pop());
 }
 if ((maxThreads > 0) && (curThreads < maxThreads)) {
 curThreadsBusy++;
@@ -1516,5 +1517,60 @@
 public boolean process(long socket);
 }

+
+// -  
WorkerStack Inner Class

+
+
+public class WorkerStack {
+
+protected Worker[] workers = null;
+protected int end = 0;
+
+public WorkerStack(int size) {
+workers = new Worker[size];
+}
+
+/**
+ * Put the object into the queue.
+ *
+ * @param   object  the object to be appended to the  
queue (first element).

+ */
+public void push(Worker worker) {
+workers[end++] = worker;
+}
+
+/**
+ * Get the first object out of the queue. Return null if  
the queue

+ * is empty.
+ */
+public Worker pop() {
+if (end > 0) {
+return workers[--end];
+}
+return null;
+}
+
+/**
+ * Get the first object out of the queue, Return null if  
the queue

+ * is empty.
+ */
+public Worker peek() {
+return workers[end];
+}
+
+/**
+ * Is the queue empty?
+ */
+public boolean isEmpty() {
+return (end == 0);
+}
+
+/**
+ * How many elements are there in this queue?
+ */
+public int size() {
+return (end);
+}
+}

 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r388500 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[Remy Maucherat]

Peter Rossbach wrote:

Cool catch  => Use simple data structure, with fine performance impact. :-)


Believe it or not, but it's just a little bit faster than the stack 
(which has the same behavior, except with syncs).


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388561 - /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/NioSender.java

[fhanik]

Author: fhanik
Date: Fri Mar 24 07:26:05 2006
New Revision: 388561

URL: http://svn.apache.org/viewcvs?rev=388561&view=rev
Log:
Using long lifed bytebuffers for sending

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/NioSender.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/NioSender.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/NioSender.java?rev=388561&r1=388560&r2=388561&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/NioSender.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/NioSender.java
 Fri Mar 24 07:26:05 2006
@@ -59,6 +59,7 @@
  * STATE VARIABLES *
  */
 protected ByteBuffer readbuf = null;
+protected ByteBuffer writebuf = null;
 protected byte[] current = null;
 protected int curPos=0;
 protected XByteBuffer ackbuf = new XByteBuffer(128,true);
@@ -169,7 +170,6 @@
 //weve written everything, or we are starting a new package
 //protect against buffer overwrite
 int length = current.length-curPos;
-ByteBuffer writebuf = ByteBuffer.wrap(current,curPos,length);
 int byteswritten = socketChannel.write(writebuf);
 curPos += byteswritten;
 remaining -= byteswritten;
@@ -201,6 +201,12 @@
 } else {
 readbuf.clear();
 }
+if ( writebuf == null ) {
+writebuf = getWriteBuffer();
+} else {
+writebuf.clear();
+}
+
 InetSocketAddress addr = new InetSocketAddress(getAddress(),getPort());
 if ( socketChannel != null ) throw new IOException("Socket channel has 
already been established. Connection might be in progress.");
 socketChannel = SocketChannel.open();
@@ -244,6 +250,7 @@
 readbuf = getReadBuffer();
 }
 if ( readbuf != null ) readbuf.clear();
+if ( writebuf != null ) writebuf.clear();
 current = null;
 curPos = 0;
 ackbuf.clear();
@@ -254,8 +261,16 @@
 setConnectTime(-1);
 }
 
-private ByteBuffer getReadBuffer() {
-return 
(getDirectBuffer()?ByteBuffer.allocateDirect(getRxBufSize()):ByteBuffer.allocate(getRxBufSize()));
+private ByteBuffer getReadBuffer() { 
+return getBuffer(getRxBufSize());
+}
+
+private ByteBuffer getWriteBuffer() {
+return getBuffer(getTxBufSize());
+}
+
+private ByteBuffer getBuffer(int size) {
+return 
(getDirectBuffer()?ByteBuffer.allocateDirect(size):ByteBuffer.allocate(size));
 }
 
 /**
@@ -266,11 +281,20 @@
 * @todo Implement this org.apache.catalina.tribes.tcp.IDataSender method
 */
public synchronized void setMessage(byte[] data) throws IOException {
+   setMessage(data,0,data.length);
+   }
+
+   public synchronized void setMessage(byte[] data,int offset, int length) 
throws IOException {
if ( data != null ) {
current = data;
remaining = current.length;
curPos = 0;
ackbuf.clear();
+   if ( writebuf != null ) writebuf.clear();
+   else writebuf = getBuffer(length);
+   if ( writebuf.capacity() > length ) writebuf = getBuffer(length);
+   writebuf.put(data,offset,length);
+   writebuf.rewind();
if (isConnected()) {
socketChannel.register(getSelector(), SelectionKey.OP_WRITE, 
this);
}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r388500 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[Filip Hanik - Dev Lists]

Remy Maucherat wrote:

Peter Rossbach wrote:
Cool catch  => Use simple data structure, with fine performance 
impact. :-)


Believe it or not, but it's just a little bit faster than the stack 
(which has the same behavior, except with syncs).
you can only tell true performance improvement on machines with more 
than one CPU, say 4/8/32 CPU machines, sync vs using thread safe non 
sync the difference can be huge.


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388569 - in /tomcat/container/tc5.5.x/modules/groupcom: src/share/org/apache/catalina/tribes/tcp/nio/ParallelNioSender.java test/org/apache/catalina/tribes/demos/LoadTest.java to-do.txt

[fhanik]

Author: fhanik
Date: Fri Mar 24 08:20:37 2006
New Revision: 388569

URL: http://svn.apache.org/viewcvs?rev=388569&view=rev
Log:
Added to do, played around with the default values

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/ParallelNioSender.java

tomcat/container/tc5.5.x/modules/groupcom/test/org/apache/catalina/tribes/demos/LoadTest.java
tomcat/container/tc5.5.x/modules/groupcom/to-do.txt

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/ParallelNioSender.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/ParallelNioSender.java?rev=388569&r1=388568&r2=388569&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/ParallelNioSender.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/nio/ParallelNioSender.java
 Fri Mar 24 08:20:37 2006
@@ -51,7 +51,7 @@
 
 protected static org.apache.commons.logging.Log log = 
org.apache.commons.logging.LogFactory.getLog(ParallelNioSender.class);
 
-protected long selectTimeout = 1000; 
+protected long selectTimeout = 1000; //default 1 second
 protected Selector selector;
 protected HashMap nioSenders = new HashMap();
 

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/test/org/apache/catalina/tribes/demos/LoadTest.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/test/org/apache/catalina/tribes/demos/LoadTest.java?rev=388569&r1=388568&r2=388569&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/test/org/apache/catalina/tribes/demos/LoadTest.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/test/org/apache/catalina/tribes/demos/LoadTest.java
 Fri Mar 24 08:20:37 2006
@@ -26,6 +26,7 @@
 import org.apache.catalina.tribes.MembershipListener;
 import org.apache.catalina.tribes.io.XByteBuffer;
 import org.apache.catalina.tribes.Channel;
+import java.io.Externalizable;
 
 
 /**
@@ -245,7 +246,7 @@
 
 
 //public static class LoadMessage extends ByteMessage implements 
Serializable  {
-public static class LoadMessage implements Serializable  {
+public static class LoadMessage extends ByteMessage  implements 
Serializable {
 
 public static byte[] outdata = new byte[size];
 public static Random r = new Random(System.currentTimeMillis());
@@ -261,7 +262,7 @@
 return messageSize;
 }
 
-protected byte[] message = null;
+protected byte[] message = getMessage();
 protected int nr = -1;
 static {
 r.nextBytes(outdata);

Modified: tomcat/container/tc5.5.x/modules/groupcom/to-do.txt
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/to-do.txt?rev=388569&r1=388568&r2=388569&view=diff
==
--- tomcat/container/tc5.5.x/modules/groupcom/to-do.txt (original)
+++ tomcat/container/tc5.5.x/modules/groupcom/to-do.txt Fri Mar 24 08:20:37 2006
@@ -34,6 +34,9 @@
 
 Code Tasks:
 ===
+34. Configurable payload for the membership heartbeat, so that the app can 
decide what to heartbeat.
+such as JMX management port, ala Andy Piper's suggestion.
+
 33. PerfectFDInterceptor, when a member is reported missing, first check TCP 
path too.
 
 32. Replicated JNDI entries in Tomcat in the format



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388570 - in /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes: mcast/McastService.java tcp/ReplicationTransmitter.java

[fhanik]

Author: fhanik
Date: Fri Mar 24 08:32:50 2006
New Revision: 388570

URL: http://svn.apache.org/viewcvs?rev=388570&view=rev
Log:
Added in default values so that you can create a channel in a super simple way

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/mcast/McastService.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/tcp/ReplicationTransmitter.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/mcast/McastService.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/mcast/McastService.java?rev=388570&r1=388569&r2=388570&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/mcast/McastService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/mcast/McastService.java
 Fri Mar 24 08:32:50 2006
@@ -17,19 +17,13 @@
 package org.apache.catalina.tribes.mcast;
 
 import java.util.Properties;
-
-import javax.management.MBeanServer;
 import javax.management.ObjectName;
 
-import org.apache.catalina.Cluster;
-import org.apache.catalina.Container;
 import org.apache.catalina.tribes.Member;
 import org.apache.catalina.tribes.MembershipListener;
 import org.apache.catalina.tribes.MembershipService;
-import org.apache.catalina.core.StandardHost;
 import org.apache.catalina.util.StringManager;
 import org.apache.commons.modeler.Registry;
-import org.apache.catalina.tribes.tcp.*;
 
 /**
  * A membership implementation using simple multicast.
@@ -87,7 +81,13 @@
  * Create a membership service.
  */
 public McastService() {
+//default values
 properties.setProperty("mcastClusterDomain", "catalina");
+properties.setProperty("mcastPort","45564");
+properties.setProperty("mcastAddress","228.0.0.4");
+properties.setProperty("memberDropTime","3000");
+properties.setProperty("mcastFrequency","500");
+
 }
 
 /**
@@ -121,7 +121,7 @@
  * 3. mcastClusterDomain - the mcast cluster domain
  * 4. bindAddress - the bind address if any - only one that can be null
  * 5. memberDropTime - the time a member is gone before it is considered 
gone.
- * 6. msgFrequency - the frequency of sending messages
+ * 6. mcastFrequency - the frequency of sending messages
  * 7. tcpListenPort - the port this member listens to
  * 8. tcpListenHost - the bind address of this member
  * @exception java.lang.IllegalArgumentException if a property is missing.
@@ -131,7 +131,7 @@
 hasProperty(properties,"mcastAddress");
 hasProperty(properties,"mcastClusterDomain");
 hasProperty(properties,"memberDropTime");
-hasProperty(properties,"msgFrequency");
+hasProperty(properties,"mcastFrequency");
 hasProperty(properties,"tcpListenPort");
 hasProperty(properties,"tcpListenHost");
 this.properties = properties;
@@ -201,11 +201,11 @@
 }
 
 public void setMcastFrequency(long time) {
-properties.setProperty("msgFrequency", String.valueOf(time));
+properties.setProperty("mcastFrequency", String.valueOf(time));
 }
 
 public long getMcastFrequency() {
-String p = properties.getProperty("msgFrequency");
+String p = properties.getProperty("mcastFrequency");
 return new Long(p).longValue();
 }
 
@@ -275,7 +275,7 @@
 }
 }
 
-impl = new 
McastServiceImpl((MemberImpl)localMember,Long.parseLong(properties.getProperty("msgFrequency")),
+impl = new 
McastServiceImpl((MemberImpl)localMember,Long.parseLong(properties.getProperty("mcastFrequency")),
 
Long.parseLong(properties.getProperty("memberDropTime")),
 
Integer.parseInt(properties.getProperty("mcastPort")),
 bind,
@@ -285,7 +285,7 @@
 this);
 
 impl.start(level);
-   long memberwait = 
(Long.parseLong(properties.getProperty("msgFrequency"))*4);
+   long memberwait = 
(Long.parseLong(properties.getProperty("mcastFrequency"))*4);
 if(log.isInfoEnabled())
 log.info("Sleeping for "+memberwait+" milliseconds to establish 
cluster membership");
 Thread.sleep(memberwait);
@@ -424,7 +424,7 @@
 p.setProperty("mcastClusterDomain","catalina");
 p.setProperty("bindAddress","localhost");
 p.setProperty("memberDropTime","3000");
-p.setProperty("msgFrequency","500");
+p.setProperty("mcastFrequency","500");
 p.setProperty("tcpListenPort",args[1]);
 p.setProperty("tcpListenHost",args[0]);
 service.setProperties(p);

Modified: 
tomcat/container/tc5.5.x/modu

svn commit: r388572 - /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

[fhanik]

Author: fhanik
Date: Fri Mar 24 08:34:25 2006
New Revision: 388572

URL: http://svn.apache.org/viewcvs?rev=388572&view=rev
Log:
more defaults, now you can create channel by saying new GroupChannel(), then 
start and you are done

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=388572&r1=388571&r2=388572&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Fri Mar 24 08:34:25 2006
@@ -24,6 +24,9 @@
 import org.apache.catalina.tribes.MembershipService;
 import org.apache.catalina.tribes.MessageListener;
 import org.apache.catalina.tribes.tcp.SenderState;
+import org.apache.catalina.tribes.tcp.ReplicationTransmitter;
+import org.apache.catalina.tribes.mcast.McastService;
+import org.apache.catalina.tribes.tcp.nio.NioReceiver;
 
 
 /**
@@ -34,9 +37,9 @@
  * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
  */
 public class ChannelCoordinator extends ChannelInterceptorBase implements 
MessageListener {
-private ChannelReceiver clusterReceiver;
-private ChannelSender clusterSender;
-private MembershipService membershipService;
+private ChannelReceiver clusterReceiver = new NioReceiver();
+private ChannelSender clusterSender = new ReplicationTransmitter();
+private MembershipService membershipService = new McastService();
 private boolean started = false;
 
 public ChannelCoordinator() {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388576 - /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

[fhanik]

Author: fhanik
Date: Fri Mar 24 08:47:32 2006
New Revision: 388576

URL: http://svn.apache.org/viewcvs?rev=388576&view=rev
Log:
Oops, now are are completely autoconfigured

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=388576&r1=388575&r2=388576&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Fri Mar 24 08:47:32 2006
@@ -115,6 +115,7 @@
 if (started) return;
 //must start the receiver first so that we can coordinate the port 
it
 //listens to with the local membership settings
+clusterReceiver.setMessageListener(this);
 clusterReceiver.start();
 clusterSender.start();
 //synchronize, big time FIXME



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39061] - Cannot undeploy application due to javax.crypto.Cipher

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39061


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |major




--- Additional Comments From [EMAIL PROTECTED]  2006-03-24 18:12 ---
I'm suggesting a severity of "major" since this blocks the re-deploy of an
application:  The whole server must be shut down for Tomcat to release the locks
on the offending files.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388594 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[remm]

Author: remm
Date: Fri Mar 24 10:15:16 2006
New Revision: 388594

URL: http://svn.apache.org/viewcvs?rev=388594&view=rev
Log:
- Add many threading options, the most useful being multiple pollers for Win 
(after testing, it's
  really not possible to have large pollers and reasonable performance).

Modified:

tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=388594&r1=388593&r2=388594&view=diff
==
--- 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
(original)
+++ 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
Fri Mar 24 10:15:16 2006
@@ -92,19 +92,19 @@
 /**
  * The acceptor thread.
  */
-protected Thread acceptorThread = null;
+//protected Thread[] acceptorThreads = null;
 
 
 /**
  * The socket poller thread.
  */
-protected Thread pollerThread = null;
+//protected Thread[] pollerThreads = null;
 
 
 /**
  * The sendfile thread.
  */
-protected Thread sendfileThread = null;
+//protected Thread[] sendfileThreads = null;
 
 
 /**
@@ -195,7 +195,7 @@
 /**
  * Size of the socket poller.
  */
-protected int pollerSize = 16 * 1024;
+protected int pollerSize = 8 * 1024;
 public void setPollerSize(int pollerSize) { this.pollerSize = pollerSize; }
 public int getPollerSize() { return pollerSize; }
 
@@ -269,7 +269,7 @@
 /**
  * Timeout on first request read before going to the poller, in ms.
  */
-protected int firstReadTimeout = 100;
+protected int firstReadTimeout = -1;
 public int getFirstReadTimeout() { return firstReadTimeout; }
 public void setFirstReadTimeout(int firstReadTimeout) { 
this.firstReadTimeout = firstReadTimeout; }
 
@@ -310,31 +310,49 @@
 
 
 /**
- * Number of keepalive sockets.
+ * Acceptor thread count.
  */
-protected int keepAliveCount = 0;
-public int getKeepAliveCount() { return keepAliveCount; }
+protected int acceptorThreadCount = 0;
+public void setAcceptorThreadCount(int acceptorThreadCount) { 
this.acceptorThreadCount = acceptorThreadCount; }
+public int getAcceptorThreadCount() { return acceptorThreadCount; }
 
 
 /**
- * Number of sendfile sockets.
+ * Sendfile thread count.
+ */
+protected int sendfileThreadCount = 0;
+public void setSendfileThreadCount(int sendfileThreadCount) { 
this.sendfileThreadCount = sendfileThreadCount; }
+public int getSendfileThreadCount() { return sendfileThreadCount; }
+
+
+/**
+ * Poller thread count.
  */
-protected int sendfileCount = 0;
-public int getSendfileCount() { return sendfileCount; }
+protected int pollerThreadCount = 0;
+public void setPollerThreadCount(int pollerThreadCount) { 
this.pollerThreadCount = pollerThreadCount; }
+public int getPollerThreadCount() { return pollerThreadCount; }
 
 
 /**
  * The socket poller.
  */
-protected Poller poller = null;
-public Poller getPoller() { return poller; }
+protected Poller[] pollers = null;
+protected int pollerRoundRobin = 0;
+public Poller getPoller() {
+pollerRoundRobin = (pollerRoundRobin + 1) % pollers.length;
+return pollers[pollerRoundRobin];
+}
 
 
 /**
  * The static file sender.
  */
-protected Sendfile sendfile = null;
-public Sendfile getSendfile() { return sendfile; }
+protected Sendfile[] sendfiles = null;
+protected int sendfileRoundRobin = 0;
+public Sendfile getSendfile() {
+sendfileRoundRobin = (sendfileRoundRobin + 1) % sendfiles.length;
+return sendfiles[sendfileRoundRobin];
+}
 
 
 /**
@@ -458,6 +476,38 @@
 
 
 /**
+ * Number of keepalive sockets.
+ */
+public int getKeepAliveCount() {
+if (pollers == null) {
+return 0;
+} else {
+int keepAliveCount = 0;
+for (int i = 0; i < pollers.length; i++) {
+keepAliveCount += pollers[i].getKeepAliveCount();
+}
+return keepAliveCount;
+}
+}
+
+
+/**
+ * Number of sendfile sockets.
+ */
+public int getSendfileCount() {
+if (sendfiles == null) {
+return 0;
+} else {
+int sendfileCount = 0;
+for (int i = 0; i < sendfiles.length; i++) {
+sendfileCount += sendfiles[i].getSendfileCount();
+}
+return sendfileCount;
+}
+}
+
+
+/**
  * Return the amount of threads that are managed by the pool.
  *
  * @return the amount of threads that are managed by the pool
@@ -554,6 +604,35 @@
 useSen

DO NOT REPLY [Bug 39091] - precompiled JSP pages always recompile

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39091


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2006-03-24 18:32 ---
The duplicate was correctly closed. Tomcat is behaving as per the servlet spec.
Please do as you were asked and follow this up on Tomcat user. Bugzilla is not a
support forum.

Further re-openings of this bug will be closed without further comment.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39093] - Tomcat messes up when a class has the same name as a package

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39093


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2006-03-24 22:58 ---
Thanks for the test case. It makes looking at bugs like this so much quicker.

My environment:
Windows Home SP2 + all patches
Java 1.5.0_04
Tomcat 5.5.HEAD and 5.5.15

I can't reproduce this. I confirmed the suspect code was present in the JSP by
reviewing the source code generated in the work directory. The JSP was compilied
with the Eclipse 3.1.2 compilier.

This looks like a problem with your environment.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388678 - /tomcat/container/tc5.5.x/modules/groupcom/to-do.txt

[fhanik]

Author: fhanik
Date: Fri Mar 24 15:54:45 2006
New Revision: 388678

URL: http://svn.apache.org/viewcvs?rev=388678&view=rev
Log:
Added to do items

Modified:
tomcat/container/tc5.5.x/modules/groupcom/to-do.txt

Modified: tomcat/container/tc5.5.x/modules/groupcom/to-do.txt
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/to-do.txt?rev=388678&r1=388677&r2=388678&view=diff
==
--- tomcat/container/tc5.5.x/modules/groupcom/to-do.txt (original)
+++ tomcat/container/tc5.5.x/modules/groupcom/to-do.txt Fri Mar 24 15:54:45 2006
@@ -34,6 +34,13 @@
 
 Code Tasks:
 ===
+36. UDP Sender and Receiver, initially without flow control and guaranteed 
delivery.
+This can be easily done as an interceptor, and operate in parallel with 
the TCP sender.
+It can implement an auto detect, so that if the message is going to a 
destination in the same network 
+patch, then send it over UDP.
+
+35. The ability to share one channel amongst multiple processes
+
 34. Configurable payload for the membership heartbeat, so that the app can 
decide what to heartbeat.
 such as JMX management port, ala Andy Piper's suggestion.
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r388679 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[remm]

Author: remm
Date: Fri Mar 24 15:59:49 2006
New Revision: 388679

URL: http://svn.apache.org/viewcvs?rev=388679&view=rev
Log:
- Remove commented out code.

Modified:

tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=388679&r1=388678&r2=388679&view=diff
==
--- 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
(original)
+++ 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
Fri Mar 24 15:59:49 2006
@@ -90,24 +90,6 @@
 
 
 /**
- * The acceptor thread.
- */
-//protected Thread[] acceptorThreads = null;
-
-
-/**
- * The socket poller thread.
- */
-//protected Thread[] pollerThreads = null;
-
-
-/**
- * The sendfile thread.
- */
-//protected Thread[] sendfileThreads = null;
-
-
-/**
  * Available workers.
  */
 protected WorkerStack workers = null;
@@ -606,7 +588,7 @@
 
 // Initialize thread count defaults for acceptor, poller and sendfile
 if (acceptorThreadCount == 0) {
-// FIXME: Default to one per CPU ?
+// FIXME: Doesn't seem to work that well with multiple accept 
threads
 acceptorThreadCount = 1;
 }
 if (pollerThreadCount == 0) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r388679 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

[Filip Hanik - Dev Lists]

just a small observation,

working with multiple polling threads is pretty hard, we do it in the 
clustering code (NIO), on the receiver side of things,
and it took a while to work out the kinks, and you need a shared place 
to lock, since a lot of the operations are not thread safe.

The code becomes somewhat complex.

I haven't made myself familiar enough of the APR code to comment there, 
but I can imagine the same scenario would be there. Usually a single 
thread, even on a multi CPU machine can perform all polling, as long as 
it doesn't do anything but read the buffer, then pass it on to a thread.
If the poller thread starts doing more, such as putting packages 
together, copy data, deserialization etc, then you'll find yourself in a 
bottleneck.


I like this guys approach, 
http://www.onjava.com/pub/a/onjava/2004/09/01/nio.html?page=1
he had the same experience, one poller thread becomes way more 
manageable code, and he created a neat design of putting back 
registration request to happen async or sync.


Filip



[EMAIL PROTECTED] wrote:

Author: remm
Date: Fri Mar 24 15:59:49 2006
New Revision: 388679

URL: http://svn.apache.org/viewcvs?rev=388679&view=rev
Log:
- Remove commented out code.

Modified:

tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=388679&r1=388678&r2=388679&view=diff
==
--- 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
(original)
+++ 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
Fri Mar 24 15:59:49 2006
@@ -90,24 +90,6 @@
 
 
 /**

- * The acceptor thread.
- */
-//protected Thread[] acceptorThreads = null;
-
-
-/**
- * The socket poller thread.
- */
-//protected Thread[] pollerThreads = null;
-
-
-/**
- * The sendfile thread.
- */
-//protected Thread[] sendfileThreads = null;
-
-
-/**
  * Available workers.
  */
 protected WorkerStack workers = null;
@@ -606,7 +588,7 @@
 
 // Initialize thread count defaults for acceptor, poller and sendfile

 if (acceptorThreadCount == 0) {
-// FIXME: Default to one per CPU ?
+// FIXME: Doesn't seem to work that well with multiple accept 
threads
 acceptorThreadCount = 1;
 }
 if (pollerThreadCount == 0) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]