svn commit: r369000 - in /tomcat/connectors/trunk/jni: java/org/apache/tomcat/jni/File.java native/src/file.c

2006-01-14 Thread mturk
Author: mturk
Date: Sat Jan 14 00:08:44 2006
New Revision: 369000

URL: http://svn.apache.org/viewcvs?rev=369000&view=rev
Log:
Revert note about unused pool. APR guys say it might
be used sometime in the future :)

Modified:
tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/File.java
tomcat/connectors/trunk/jni/native/src/file.c

Modified: tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/File.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/File.java?rev=369000&r1=368999&r2=369000&view=diff
==
--- tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/File.java (original)
+++ tomcat/connectors/trunk/jni/java/org/apache/tomcat/jni/File.java Sat Jan 14 
00:08:44 2006
@@ -255,7 +255,7 @@
 /**
  * Delete the specified file.
  * @param path The full path to the file (using / on all systems)
- * @param pool Unused.
+ * @param pool The pool to use.
  * If the file is open, it won't be removed until all
  * instances are closed.
  */
@@ -268,7 +268,7 @@
  * possible.
  * @param fromPath The full path to the original file (using / on all 
systems)
  * @param toPath The full path to the new file (using / on all systems)
- * @param pool Unused.
+ * @param pool The pool to use.
  */
 public static native int rename(String fromPath, String toPath, long pool);
 

Modified: tomcat/connectors/trunk/jni/native/src/file.c
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/jni/native/src/file.c?rev=369000&r1=368999&r2=369000&view=diff
==
--- tomcat/connectors/trunk/jni/native/src/file.c (original)
+++ tomcat/connectors/trunk/jni/native/src/file.c Sat Jan 14 00:08:44 2006
@@ -112,12 +112,12 @@
 
 TCN_IMPLEMENT_CALL(jint, File, remove)(TCN_STDARGS, jstring path, jlong pool)
 {
+apr_pool_t *p = J2P(pool, apr_pool_t *);
 TCN_ALLOC_CSTRING(path);
 apr_status_t rv;
 
 UNREFERENCED(o);
-UNREFERENCED(pool);
-rv = apr_file_remove(J2S(path), NULL);
+rv = apr_file_remove(J2S(path), p);
 TCN_FREE_CSTRING(path);
 return (jint)rv;
 }
@@ -125,13 +125,13 @@
 TCN_IMPLEMENT_CALL(jint, File, rename)(TCN_STDARGS, jstring from,
jstring to, jlong pool)
 {
+apr_pool_t *p = J2P(pool, apr_pool_t *);
 TCN_ALLOC_CSTRING(from);
 TCN_ALLOC_CSTRING(to);
 apr_status_t rv;
 
 UNREFERENCED(o);
-UNREFERENCED(pool);
-rv = apr_file_rename(J2S(from), J2S(to), NULL);
+rv = apr_file_rename(J2S(from), J2S(to), p);
 TCN_FREE_CSTRING(from);
 TCN_FREE_CSTRING(to);
 return (jint)rv;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[VOTE] Tomcat v5.5.15 Stability

2006-01-14 Thread Yoav Shapira
Hi,
Tomcat v5.5.15-beta was released last week, and hopefully people have
had time to test it a bit.  If you have, please vote on its stability
below.  If you haven't, you still can test it a bit and let us know
what you think ;)  As a reminder, only Tomcat committer votes are
binding, but everyone else is welcome to voice their opinion.

[ ] Stable - no major issues
[ ] Beta - at least one significant issue (what is it?)
[ ] Alpha - multiple significant issues, not recommended for use (why?)

--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Tomcat v5.5.15 Stability

2006-01-14 Thread Peter Rossbach

[x ] Stable - no major issues

+1 to release 5.5.15

Peter


Am 14.01.2006 um 16:37 schrieb Yoav Shapira:


Hi,
Tomcat v5.5.15-beta was released last week, and hopefully people have
had time to test it a bit.  If you have, please vote on its stability
below.  If you haven't, you still can test it a bit and let us know
what you think ;)  As a reminder, only Tomcat committer votes are
binding, but everyone else is welcome to voice their opinion.

[ ] Stable - no major issues
[ ] Beta - at least one significant issue (what is it?)
[ ] Alpha - multiple significant issues, not recommended for use  
(why?)


--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Tomcat v5.5.15 Stability

2006-01-14 Thread M A
I have issue with the APR not delivering a page that was approx 14KB in
size,
I did post it on here but no one responded.

Is it a show stopper well for me it is it means i cant use APR ..



On 1/14/06, Yoav Shapira <[EMAIL PROTECTED]> wrote:
>
> Hi,
> Tomcat v5.5.15-beta was released last week, and hopefully people have
> had time to test it a bit.  If you have, please vote on its stability
> below.  If you haven't, you still can test it a bit and let us know
> what you think ;)  As a reminder, only Tomcat committer votes are
> binding, but everyone else is welcome to voice their opinion.
>
> [ ] Stable - no major issues
> [ ] Beta - at least one significant issue (what is it?)
> [ ] Alpha - multiple significant issues, not recommended for use (why?)
>
> --
> Yoav Shapira
> System Design and Management Fellow
> MIT Sloan School of Management
> Cambridge, MA, USA
> [EMAIL PROTECTED] / www.yoavshapira.com
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


Re: [VOTE] Tomcat v5.5.15 Stability

2006-01-14 Thread Remy Maucherat

Yoav Shapira wrote:

Hi,
Tomcat v5.5.15-beta was released last week, and hopefully people have
had time to test it a bit.  If you have, please vote on its stability
below.  If you haven't, you still can test it a bit and let us know
what you think ;)  As a reminder, only Tomcat committer votes are
binding, but everyone else is welcome to voice their opinion.

[X] Stable - no major issues
[ ] Beta - at least one significant issue (what is it?)
[ ] Alpha - multiple significant issues, not recommended for use (why?)


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r369135 - /tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr152/build.xml

2006-01-14 Thread billbarker
Author: billbarker
Date: Sat Jan 14 16:39:19 2006
New Revision: 369135

URL: http://svn.apache.org/viewcvs?rev=369135&view=rev
Log:
bundle the ant tasks in a jar (mostly to keep Gump happy :)

Modified:
tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr152/build.xml

Modified: tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr152/build.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr152/build.xml?rev=369135&r1=369134&r2=369135&view=diff
==
--- tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr152/build.xml (original)
+++ tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr152/build.xml Sat Jan 14 
16:39:19 2006
@@ -16,6 +16,7 @@
   
   
   
+  
 
   
 
@@ -113,8 +114,9 @@
 debug="${compile.debug}" deprecation="${compile.deprecation}"
 optimize="${compile.optimize}" 
 classpath="${ant.home}/lib/ant.jar" />
+
 
+classpath="${jsp-anttask.jar}" />
   
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]