Re: svn commit: r360466 - /tomcat/connectors/trunk/jk/java/org/apache/coyote/ajp/AjpAprProcessor.java

2006-01-02 Thread Remy Maucherat

[EMAIL PROTECTED] wrote:

Author: billbarker
Date: Sat Dec 31 16:24:57 2005
New Revision: 360466

URL: http://svn.apache.org/viewcvs?rev=360466&view=rev
Log:
Fix handling of the special first Body-Chunk packet.

Somebody that knows the APR interface better than me could probably clean this 
up (e.g. swallow an unread first Body-Chunk in recycle instead of in process).  
However, it probably doesn't actually make much difference in terms of 
processing speed.

I haven't actually tested this, but now it's doing much the same thing as the 
JK/Java Connector, so it should be fine.



If it works, then it's really cool since it's so simple. The performance 
impact should be very small, I think.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38092] New: - Getting java.net.SocketTimeoutException

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38092

   Summary: Getting java.net.SocketTimeoutException
   Product: Tomcat 4
   Version: 4.1.24
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I am getting the following exception in my application
2005-12-10 21:02:05,455 [HttpProcessor[443][33]] INFO STDOUT - HttpProcessor
[443][33], handling exception: java.net.SocketTimeoutException: Read timed out
Could you kindly let me know what does this exception mean, and whether this is 
an error condition. Could you also suggest a possible solution for this problem.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38095] New: - do not produce java code using "unchecked or unsafe operations"

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38095

   Summary: do not produce java code using "unchecked or unsafe
operations"
   Product: Tomcat 5
   Version: 5.5.14
  Platform: Other
   URL: http://jakarta.apache.org/tomcat/tomcat-5.5-doc/jasper-
howto.html#Web%20Application%20Compilation
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


at least with javac of 1.5 / 5.0 the following error is displayed
<<[javac] Note: C:\Documents and Settings\you\My
Documents\myProj\build\jspC\org\apache\jsp\
build\jsp\samplePAge_005fen_jsp.java uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.>>


since it is not possible to get at the mentioned details with the current ant
version, see RFE Bug 38094

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38078] - java.lang.RuntimeException: Read of HTTP Request POST parameters failed: Read timed out

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38078





--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 14:51 ---
Bugzilla isn't a support forum. Please use the users@tomcat.apache.org list for
questions like this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37285] - POST of document through CGI

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37285


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 14:54 ---
*** Bug 38085 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38085] - CGIServlet - form data with enctype="multipart/form-data"

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38085


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 14:54 ---
Indeed it is.

*** This bug has been marked as a duplicate of 37285 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38092] - Getting java.net.SocketTimeoutException

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38092


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 16:09 ---
Bugzilla is not a support forum. Please use the users list. See
http://tomcat.apache.org/lists.html for subscription and usage instructions.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r365362 - /tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java

2006-01-02 Thread markt
Author: markt
Date: Mon Jan  2 07:40:09 2006
New Revision: 365362

URL: http://svn.apache.org/viewcvs?rev=365362&view=rev
Log:
Fix bug 15570. Magic role of * was interpreted as all authenticated
users rather than as all roles defined in web.xml

Modified:

tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java

Modified: 
tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=365362&r1=365361&r2=365362&view=diff
==
--- 
tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
 (original)
+++ 
tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/authenticator/AuthenticatorBase.java
 Mon Jan  2 07:40:09 2006
@@ -566,10 +566,14 @@
 }
 
 // Check each role included in this constraint
-if (constraint.getAllRoles())
-return (true);
+String roles[];
+if (constraint.getAllRoles()) {
+// * means all roles defined in web.xml
+roles = context.findSecurityRoles();
+} else {
+roles = constraint.findAuthRoles();
+}
 
-String roles[] = constraint.findAuthRoles();
 if (roles == null)
 roles = new String[0];
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r365363 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/realm/RealmBase.java webapps/docs/changelog.xml

2006-01-02 Thread markt
Author: markt
Date: Mon Jan  2 07:46:04 2006
New Revision: 365363

URL: http://svn.apache.org/viewcvs?rev=365363&view=rev
Log:
Fix bug 15570. Magic role of * was interpreted as all authenticated
users rather than as all roles defined in web.xml
Ported from TC4.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java?rev=365363&r1=365362&r2=365363&view=diff
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/RealmBase.java
 Mon Jan  2 07:46:04 2006
@@ -728,12 +728,17 @@
 boolean denyfromall = false;
 for(int i=0; i < constraints.length; i++) {
 SecurityConstraint constraint = constraints[i];
-String roles[] = constraint.findAuthRoles();
+
+String roles[];
+if (constraint.getAllRoles()) {
+// * means all roles defined in web.xml
+roles = request.getContext().findSecurityRoles();
+} else {
+roles = constraint.findAuthRoles();
+}
+
 if (roles == null)
 roles = new String[0];
-
-if (constraint.getAllRoles() && !denyfromall)
-status = true;
 
 if (log.isDebugEnabled())
 log.debug("  Checking roles " + principal);

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=365363&r1=365362&r2=365363&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Jan  2 07:46:04 2006
@@ -31,11 +31,18 @@
37934: Don't ask for authentication if deny-from-all is in 
effect. (billbarker)
   
   
+15570: auth-constraint of * was interpretted as all
+authenticated users rather than as all roles defined in web.xml. 
(markt)
+  
+  
Remove leftover static logger which was used to log application level 
messages in
ApplicationContextFacade (remm)
   
   
 38012: Where a CGI script sets a response code, use it. 
(markt)
+  
+  
+37854: Extension-List checking was too strict. (markt)
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 15570] - incorrect role-name mapping for "*" with respect to spec

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=15570


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 16:50 ---
Thsi has been fixed in SVN for tc4.1.x and tc5.5.x

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38099] New: - Some users get: "failed appending the header value"

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38099

   Summary: Some users get: "failed appending the header value"
   Product: Tomcat 5
   Version: 5.5.9
  Platform: PC
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:AJP
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


When calling the remote tomcat server trough the isapi_redirect.dll from the
client computer I get the error in the log file:

[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (828): Virtual
Host redirection of /frasapptest17.pharma.aventis.com/adwebapp/index.jsp
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (449):
Attempting to map URI '/frasapptest17.pharma.aventis.com/adwebapp/index.jsp'
from 2 maps
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (461):
Attempting to map context URI '/adwebapp/*'
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (461):
Attempting to map context URI '/Antibody/*'
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (835): Default
redirection of /adwebapp/index.jsp
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (449):
Attempting to map URI '/adwebapp/index.jsp' from 2 maps
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (461):
Attempting to map context URI '/adwebapp/*'
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (475): Found
a wildchar match w_frasorm32 -> /adwebapp/*
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (845): check if
[/adwebapp/index.jsp] is points to the web-inf directory
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (863):
[/adwebapp/index.jsp] is a servlet url - should redirect to w_frasorm32
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (762): Filter
started
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (828): Virtual
Host redirection of /frasapptest17.pharma.aventis.com/adwebapp/index.jsp
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (449):
Attempting to map URI '/frasapptest17.pharma.aventis.com/adwebapp/index.jsp'
from 2 maps
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (461):
Attempting to map context URI '/adwebapp/*'
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (461):
Attempting to map context URI '/Antibody/*'
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (835): Default
redirection of /adwebapp/index.jsp
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (449):
Attempting to map URI '/adwebapp/index.jsp' from 2 maps
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (461):
Attempting to map context URI '/adwebapp/*'
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_uri_worker_map.c (475): Found
a wildchar match w_frasorm32 -> /adwebapp/*
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (845): check if
[/adwebapp/index.jsp] is points to the web-inf directory
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (863):
[/adwebapp/index.jsp] is a servlet url - should redirect to w_frasorm32
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_worker.c (301): Maintaining
worker w_frasorm32
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_worker.c (111): found a worker
w_frasorm32
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (1018): got a
worker for name w_frasorm32
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_ajp_common.c (2131): acquired
connection cache slot=0
[Mon Jan 02 15:49:41 2006] [3332:2252] [error] jk_ajp_common.c (430): failed
appending the header value
[Mon Jan 02 15:49:41 2006] [3332:2252] [info]  jk_ajp_common.c (1662): Creating
AJP message failed, without recovery
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_isapi_plugin.c (1031):
service() returned OK
[Mon Jan 02 15:49:41 2006] [3332:2252] [debug] jk_ajp_common.c (2074): recycling
connection cache slot=0 for worker w_frasorm32

Access to isapi_redirect.dll is restricted to "authenticated users" in IIS 6.
For most users the request of the web page work. But some users get the error
shown in the above log file.

If the users that are unable to access the application use the server's IP
address instead of the host name then the connector works without problems.

Summary: For most users everything is OK.
Some users get an error when they access the URL through the host name but they
are able to access the URL using the server's IP number.

The frontend web server is IIS 6 on Win2003

-- 
Configure bugmail: http://issues.apache.o

DO NOT REPLY [Bug 38100] New: - HttpServletRequest.getRemoteHost() returning invalid results

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38100

   Summary: HttpServletRequest.getRemoteHost() returning invalid
results
   Product: Tomcat 5
   Version: 5.5.12
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P3
 Component: Connector:Coyote
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


This issue might be related to
http://issues.apache.org/bugzilla/show_bug.cgi?id=33971

What i am seeing is that at runtime, HttpServletRequest.getRemoteHost() is
returning invalid results. That is, it sometimes returns unqualified hostnames
(instead of an ip, which is expected if it can't get a fully-qualified
hostname). Other times it returns a hostname that has absolutely nothing to do
with the IP.

Some examples I see in my logs:

86.125.53.140 maps to msnbot.msn.com
88.7.11.140 maps to msnbot.msn.com
210.111.94.102 maps to crawl-66-249-66-138.googlebot.com
218.190.175.145 maps to msnbot.msn.com

   These are all logged by the servlet being hit, with it logging: "ip " +
request.getRemoteAddr() + " maps to " + request.getRemoteHost()

Now, if you try looking up the hostname associated with the above IPs after the
fact you will notice none of them map to the hostnames that Tomcat claims it
does. I suspect that sometimes when reverse lookup fails, Tomcat retains the
rDNS result from the previous lookup instead of returning the string format of
the IP. This might also be a new bug introduced between 5.5.9 and 5.5.12 because
I don't recall having this problem with 5.5.9.

( I'm leaving the country today for a few weeks so please excuse me if I don't
reply right away to any questions you might follow up with )

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38100] - HttpServletRequest.getRemoteHost() returning invalid results

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38100





--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 18:28 ---
BTW: I only use the HTTP connector, not jk or apr. This is a standalone Tomcat
server.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Cutting Tomcat 5.5.15 tomorrow (Tuesday)

2006-01-02 Thread Yoav Shapira
Happy new year everyone ;)

Unless I hear a -1 in response to this message, I will tag and cut
Tomcat 5.5.15 tomorrow (Tuesday, 3 Jan 2006) at 10am my time (EST),
which is 1500h GMT.

--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37285] - POST of document through CGI

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37285





--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 19:02 ---
Part of the problem is that CGIRunner.run has to deal with the feature of 
HttpServlet that does _not_ discriminate between POST and GET.

I recall reading in passing somewhere, that HttpServlet will parse the POST 
contents into an internal data structure for enumeration via getParameterNames 
and retrieval via getParameterValue, if and only if the CONTENT_TYPE 
is "application/x-www-form-urlencoded".  This act will likely drain the stdin 
and lose whatever original content was there.

Additionally, the parameters parsed from the GET QUERY_STRING are thrown into 
the getParameterNames mix.


In run(), when POST is observed, 
1. stdin is read into a buffer named content.  I speculated stdin is pre-
drained if content type is urlencoded.
2. the HttpServlet parameters are written to the stream (S) that will be the 
cgis stdin.
3. the 'content' buffer is appended to S {buffer is empty if urlencoded and the 
whole thing if multipart form}

One problem I see is that content length is not increased when content buffer 
is written.  Maybe it gets measured elsewhere?

My original foray into this bug is due to that fact I am deploying a cgi app 
(YaBB) that does not use standard parameter separators -- it's legacy nature 
has parameters being separated by & or ; .

The cgi app was not getting the parameters it needed because HttpServlet 
encoded or escaped the semis and subsequent equals to their equivalent %{nn} 
forms.  Since I can't recall the code numbers I'll use %.. For example: 
foo.pl?a=1&b=2;c=3;d=4
got HttpServlet parsed into parameters
a=1
b=2%..c%..3%..d%..4

Things would be much cleaner if (presumably) HttpServlet did not automatically 
drain stdin, and then CGIServelt could output verbatim the POST contents to the 
cgis stdin and not fool around with looping over parsed out parameters.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38100] - HttpServletRequest.getRemoteHost() returning invalid results

2006-01-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38100





--- Additional Comments From [EMAIL PROTECTED]  2006-01-02 19:05 ---
I went one step further and tried comparing the output of
HttpServletRequest.getRemoteHost() and InetAddress.getHostname():

String remoteHost = request.getRemoteHost();
String ip = request.getRemoteAddr();
text.append("ip " + ip + " maps to " + remoteHost);
String hostname = InetAddress.getByName(ip).getHostName();
if (!hostname.equals(remoteHost))
{
  text.append(" but the actual hostname is " + hostname);
  log.debug(text);
}


and got output like this:

ip 210.111.94.102 maps to vz4-vlan1.networx-bg.com but the actual hostname is
210.111.94.102

doing "nslookup" locally I clearly see that 210.111.94.102 has no reverse lookup
and that vz4-vlan1.networx-bg.com actually maps to 82.147.153.200 so now I'm
100% certain this is a Tomcat bug.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r365421 - /tomcat/build/tc5.5.x/build.xml

2006-01-02 Thread yoavs
Author: yoavs
Date: Mon Jan  2 12:21:01 2006
New Revision: 365421

URL: http://svn.apache.org/viewcvs?rev=365421&view=rev
Log:
Added md5 checksum generation for each distros, one less thing for the release 
manager to do manually.

Modified:
tomcat/build/tc5.5.x/build.xml

Modified: tomcat/build/tc5.5.x/build.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/build/tc5.5.x/build.xml?rev=365421&r1=365420&r2=365421&view=diff
==
--- tomcat/build/tc5.5.x/build.xml (original)
+++ tomcat/build/tc5.5.x/build.xml Mon Jan  2 12:21:01 2006
@@ -1448,7 +1448,6 @@
   
 
-
 
   
 
@@ -1459,16 +1458,19 @@
 tofile="${tomcat.dist}/bin/tomcat5.exe" />
 
+
 
 
-
+
+
 
   
   
 
-
+
+
+
+
   
 
 
@@ -1491,6 +1493,7 @@
 
   
 
+  
   
 
   
@@ -1513,8 +1516,11 @@
 
   
 
+
+
   
 
+  
   
 
   
 
+
+
   
 
+  
   
 
-  
-  
-  
-  
-  
+  
+  
+  
+  
+  
 
+
+
   
 
-  
-
-  
-  
-  
-  
-  
-
-  
-
-  
-
-  
-
-
-
-  
-  
-  
-  
-  
-
-  
+  
+  
+
+  
+  
+  
+  
+  
+
+ 
+
+  
 
-  
+  
+  
+
+  
+
+
+
+  
+  
+  
+  
+  
+
+   
+
+  
 
+  
+  
 
 
 
 
 
+
 
   
 
@@ -1597,12 +1602,12 @@
 
   
 
+  
   
-
+
 
 
+ tarfile="${tomcat.release}/v${version}/bin/${final.name}.tar.gz">
   
 
 
@@ -1651,14 +1656,17 @@
 
   
 
+
+
   
 
+  
   
 
 
 
+ 
tarfile="${tomcat.release}/v${version}/bin/${final.name}-embed.tar.gz">
   
 
 
@@ -1669,14 +1677,18 @@
 
   
 
+
+
   
 
+  
   
 
 
+
 
+ 
tarfile="${tomcat.release}/v${version}/bin/${final.name}-deployer.tar.gz">
   
 
 
@@ -1687,47 +1699,57 @@
 
   
 
+
+
+  
+
+  
+  
+
+
+
+  
+
+
+
+
+  
+  
+
+  
+
+
+
   
 
-  
-
-
-  
-
-
-
-
-  
-  
-
-  
-
-  
-
-  
-
-
-  
-
-
-
-
-  
-  
-
-
-  
-
-  
-
-
-  
+  
+  
+
+
+
+  
+
+
+
+
+  
+  
+
+
+  
+  
+
+  
+
+
+
+  
 
+  
   
+
 
 
 
@@ -1738,10 +1760,12 @@
 
   
 
-
+
+
+
+
 
+ 
tarfile="${tomcat.release}/v${version}/bin/${final.name}-fulldocs.tar.gz">
   
 
 
@@ -1752,21 +1776,26 @@
 
   
 
+
+
   
 
- 
-
+  
+  
 
   
 
+
+
   
 
+  
   
-
 
+
 
+ tarfile="${tomcat.release}/v${version}/src/${final-src.name}.tar.gz">
   
 
 
@@ -1786,6 +1815,8 @@
 
   
 
+
+
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]