DO NOT REPLY [Bug 37895] - isapi 1.2.15 connector when configured on IIS6.0(W2003) with "isapi_redirect.properties does not work

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37895


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 09:03 ---
If you put isapi_redirect.properties file in the same path as your
isapi_redirect.dll filter it will be used.
The name of the properties file MUST match the name of the .dll
without the extension of course.
Also make sure that LocalSystem account has a priviledge for accessing
all those folders.

Anyhow, it works just fine (WIN2K3/x64).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Checking bug case for last-modified problem in 5.5.4

[Phil Shaw]

On 12 Dec 2005, at 10:22, Phil Shaw wrote:

> I have found reference to this bug in the Jackrabbit list, but I 
> couldn't find it in bugzilla for Tomcat. I would like to check that 
> it is a recognised bug that has been identified and fixed before I 
> plan an upgrade.

Sorry, this was a complete red herring. I jumped too rapidly to an 
assumption about Jackrabbit and Tomcat. This was not an error with 
Tomcat, the Google FeedFetcher client is apparently issuing invalid 
if-modified-since headers.

> It's not clear to me what the problem is with the date, some examples:
> 
> java.lang.IllegalArgumentException: Sat, 10 Dec 2005 08:39:07
> java.lang.IllegalArgumentException: Sat, 10 Dec 2005 08:39:39
> java.lang.IllegalArgumentException: Sat, 10 Dec 2005 08:51:37

The HTTP specification says the problem is that this format should 
have a GMT on the end, i.e. 'Sat, 10 Dec 2005 08:39:07 GMT'.

It surprised me that an IllegalArgumentException is thrown in this 
case.

Best regards,

Phil



--
http://www.codestyle.org/Web font statistics and developer FAQs
http://www.metacentric.net/  Automated news feeds for your Web site


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37870] - NullSoft Installer reports incorrect disk space

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37870





--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 10:24 ---
Reported on NullSoft project as suggested.
http://sourceforge.net/tracker/index.php?
func=detail&aid=1380254&group_id=22049&atid=373085

Kev

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Proxied client IP logging

[Phil Shaw]

While I'm subscribed to this list I would like to submit this method 
for logging forwarded IP addresses when Tomcat is behind a proxy. 
Replace the simple request.getRemoteAddr(); call in the invoke method 
of AccessLogValve with getClientIp(ServletRequest).

Hope this may be useful. If you need a more formal assignment to 
Apache, please let me know. 

Best regards,

Phil


/**
 *  Get a forwarded client IP address if available.
 *  @param  The servlet request object.
 *  @return The HTTP X-Forwarded-For header value if 
present,
 *  or the default remote address if not.
 */
private final String getClientIp(final ServletRequest request) {

  try {

HttpServletRequest httpRequest = (HttpServletRequest) request;

String forwardedIp = httpRequest.getHeader("X-Forwarded-For");

if (forwardedIp != null) {

  return forwardedIp;
}
else {

  return request.getRemoteAddr();
}
  }
  catch (ClassCastException cce) {

return request.getRemoteAddr();
  }
}


--
http://www.codestyle.org/Web font statistics and developer FAQs
http://www.metacentric.net/  Automated news feeds for your Web site


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37356] - Tomcat does not invalidate sessions after session-timeout period has passed.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37356





--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 13:30 ---
(In reply to comment #1)
> Is something holding a reference to those sessions?
> And does this happen with 5.0.30 or 5.5.12?

Thanks for the interest.

This happens with 5.0.28 in production - I cannot reproduce it anywhere else 
(using 5.0.28) and I currently cannot migrate the production system to 5.0.30 
either. So, in short I cannot say if it happens on anything other than 5.0.28 -
 if someone could say that this behaviour was different in 5.0.30 then I would 
be able to move forwards but without something more definitive I can't.

I am not sure what you are getting at with the reference holding - if you mean 
is something keeping the session alive i.e. polling or such like then the 
answer is no. If you mean is a Java object keeping a reference to it - then 
aside from what Tomcat does internally (where I expect it must do...) then the 
answer is also no.

Hope this helps. Eddie


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 35746] - session manager should be immune to system clock time changes (solution provided)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35746





--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 16:25 ---
Hello,

I try to provide solutions/proof of concepts and I rely on knowledgable coders
who can sift the good ideas from the bad ideas and ensure a patch doesn't risk
dozens of rejections because of various pickyness. I consider myself a
consultant and I'm open to questions but I cannot always write code for all
opensource projects I contribute to.

If the official team of developers cannot appreciate anything else than working
code, then the useful knowledge of the community is censored and cannot benefit
this project.

Thank you for your comprehension.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Proxied client IP logging

[Sriram N]

--- Phil Shaw <[EMAIL PROTECTED]> wrote:


> 
> Hope this may be useful. If you need a more formal assignment to 
> Apache, please let me know. 
> 

You should post to the Tomcat Bugzilla. That's the best mechanism for
submitting patches.

> Best regards,
> 
> Phil
> 

-- Sriram



__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Proxied client IP logging

[Tim Funk]

I'm not really interested in this patch for a few reasons:
1) The functionality is available via a custom pattern
2) X-Forwarded-For (IIRC) can be multi-valued (comma seperated via multiple 
proxies)
3) X-Forwarded - This can break existing implementations for clients which 
are sending X-Forwarded-For (but we wish to ignore)


-Tim

Phil Shaw wrote:
While I'm subscribed to this list I would like to submit this method 
for logging forwarded IP addresses when Tomcat is behind a proxy. 
Replace the simple request.getRemoteAddr(); call in the invoke method 
of AccessLogValve with getClientIp(ServletRequest).


Hope this may be useful. If you need a more formal assignment to 
Apache, please let me know. 


Best regards,

Phil


/**
 *  Get a forwarded client IP address if available.
 *  @param  The servlet request object.
 *  @return The HTTP X-Forwarded-For header value if 
present,

 *  or the default remote address if not.
 */
private final String getClientIp(final ServletRequest request) {

  try {

HttpServletRequest httpRequest = (HttpServletRequest) request;

String forwardedIp = httpRequest.getHeader("X-Forwarded-For");

if (forwardedIp != null) {

  return forwardedIp;
}
else {

  return request.getRemoteAddr();
}
  }
  catch (ClassCastException cce) {

return request.getRemoteAddr();
  }
}


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Who is working on the ISAPI connector code?

[Preston L. Bannister]

It is not as yet clear if "IIS 5 compatibility isolation mode" is needed or
all that is needed.  The user experience seems to be all over the map.
We're working on it...

Folks run IIS for a variety of reasons, many of which make sense.  NTLM
authentication is one - the mod_auth_sspi module used in Apache is bound to
be least a step behind the builtin code used by IIS.  There are all sorts of
quirks with differing versions and setups (which have caused us grief) that
make delegating NTLM to IIS a win. In terms of performance and reliability,
there really are not significant differences between Apache (the HTTP
server) and IIS anymore.

Lots of folks are running old ASP and new .NET applications as well, and
using IIS is less trouble than using Apache.  All good reasons...

Upshot is, there is value in a way to cleanly plug in one or more
server-side Java applications (possibily running on different machines)
behind a single IIS server.  (ack - runon sentence).


On 12/13/05, Jess Holle <[EMAIL PROTECTED]> wrote:
>
> In IIS 6, you also have to run in IIS 5 compatibility isolation mode.
>
> I have no love for IIS myself but we also have customers that have some
> inexplicable emotional attachment to it.  Is it just NTLM?  In which
> case someone should shove mod_auth_sspi into Apache and be done.  If
> not, what's the fascination with IIS?  In our case our application is
> purely Java, so in direct conjunction with it ASP, .Net, etc, are of no
> benefit whatsoever.
>
> It would be helpful if either: (1) all remaining rational reasons for
> using IIS (e.g. NTLM) were answered by Apache or (2) the IIS/Tomcat
> connector was not the ugly step child that no one wanted.
>

DO NOT REPLY [Bug 37895] - isapi 1.2.15 connector when configured on IIS6.0(W2003) with "isapi_redirect.properties does not work

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37895





--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 18:26 ---
There is a little more to this than just "it works" or "it's broken".  There are
permission problems (that we are currently puzzling out) that can:

1) Cause a correctly(?) configured isapi_redirect not to load as an ISAPI 
filter.
2) Cause the filter to load, but the ISAPI extension part is not working.
3) Cause the extension to only partly(?) work (apparently).

Perhaps the core problem is that neither IIS6 or isapi_redirect.dll throw off
enough clues, so the cause of the failure is obscure.  We cannot change IIS6,
but perhaps we can be a bit more helpful in the isapi_redirect code.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Proxied client IP logging

[Phil Shaw]

On 14 Dec 2005, at 11:12, Tim Funk wrote:

> I'm not really interested in this patch for a few reasons:
> 1) The functionality is available via a custom pattern

Okay, I wasn't aware of that. This was a hack that fixed an immediate 
requirement for me. I don't use it any longer myself, so I'll drop it.

Cheers,

Phil

--
http://www.codestyle.org/Web font statistics and developer FAQs
http://www.metacentric.net/  Automated news feeds for your Web site


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[VOTE] Tomcat v5.5.14 Stability

[Yoav Shapira]

Hi,
Tomcat v5.5.14-beta has been out for about a week now. If you have
tested it, please vote on its stability below using our usual
guidelines.  (And if you haven't tested it yet, please give it a whack
;))

Tomcat 5.5.14 is:
[ ] Stable
[ ] Beta - At least one significant issue preventing stability (please
elaborate)
[ ] Alpha - Multiple significant issues (please elaborate)

As a reminder, only committer votes are binding.  Everyone's opinion
is welcome, of course.

--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Tomcat v5.5.14 Stability

[Markus Schönhaber]

Yoav Shapira wrote:
> Hi,
> Tomcat v5.5.14-beta has been out for about a week now. If you have
> tested it, please vote on its stability below using our usual
> guidelines.  (And if you haven't tested it yet, please give it a whack
> ;))

My opinion:

Tomcat 5.5.14 is:
[X] Stable

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Tomcat v5.5.14 Stability

[Remy Maucherat]

Yoav Shapira wrote:

Hi,
Tomcat v5.5.14-beta has been out for about a week now. If you have
tested it, please vote on its stability below using our usual
guidelines.  (And if you haven't tested it yet, please give it a whack
;))

Tomcat 5.5.14 is:
[ ] Stable
[ ] Beta - At least one significant issue preventing stability (please
elaborate)
[ ] Alpha - Multiple significant issues (please elaborate)

As a reminder, only committer votes are binding.  Everyone's opinion
is welcome, of course.


There's that clustering bug that Peter said was critical :( So how 
critical is it ?



Fix Bug 37808 -- 'java.lang.ArrayIndexOutOfBoundsException inside 
XByteBuffer.java.

Very production critical bug, arrgh!


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Tomcat v5.5.14 Stability

[Peter Rossbach]

5.5.14
[X] Beta - At least one significant issue preventing stability (please
elaborate)

I have found production critical bug inside cluster and fix the bug 37808
Currently I check other strange issues 37896 and implement the support 
for cross context session replication.


Peter

Yoav Shapira schrieb:


Hi,
Tomcat v5.5.14-beta has been out for about a week now. If you have
tested it, please vote on its stability below using our usual
guidelines.  (And if you haven't tested it yet, please give it a whack
;))

Tomcat 5.5.14 is:
[ ] Stable
[ ] Beta - At least one significant issue preventing stability (please
elaborate)
[ ] Alpha - Multiple significant issues (please elaborate)

As a reminder, only committer votes are binding.  Everyone's opinion
is welcome, of course.

--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




 





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Tomcat v5.5.14 Stability

[Peter Rossbach]

Hey!

I have changed the cluster message header format long time ago 5.5.10. 
In some situations TCP Stack split the message, then the
receiver byte array  interpretation start to early. Arrggh, after first 
exception the receiver socket is hanging and replication transfer 
stops.

Wait a little bit and tomcat crash with OutOfMemory or hanging.

Peter

Remy Maucherat schrieb:


Yoav Shapira wrote:


Hi,
Tomcat v5.5.14-beta has been out for about a week now. If you have
tested it, please vote on its stability below using our usual
guidelines.  (And if you haven't tested it yet, please give it a whack
;))

Tomcat 5.5.14 is:
[ ] Stable
[ ] Beta - At least one significant issue preventing stability (please
elaborate)
[ ] Alpha - Multiple significant issues (please elaborate)

As a reminder, only committer votes are binding.  Everyone's opinion
is welcome, of course.



There's that clustering bug that Peter said was critical :( So how 
critical is it ?



Fix Bug 37808 -- 'java.lang.ArrayIndexOutOfBoundsException inside 
XByteBuffer.java.

Very production critical bug, arrgh!


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]









-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Tomcat v5.5.14 Stability

[Yoav Shapira]

Howdy,
OK, thanks for following up.  Please let us know once the bug is fixed...

Yoav

On 12/14/05, Peter Rossbach <[EMAIL PROTECTED]> wrote:
> Hey!
>
> I have changed the cluster message header format long time ago 5.5.10.
> In some situations TCP Stack split the message, then the
> receiver byte array  interpretation start to early. Arrggh, after first
> exception the receiver socket is hanging and replication transfer
> stops.
> Wait a little bit and tomcat crash with OutOfMemory or hanging.
>
> Peter
>
> Remy Maucherat schrieb:
>
> > Yoav Shapira wrote:
> >
> >> Hi,
> >> Tomcat v5.5.14-beta has been out for about a week now. If you have
> >> tested it, please vote on its stability below using our usual
> >> guidelines.  (And if you haven't tested it yet, please give it a whack
> >> ;))
> >>
> >> Tomcat 5.5.14 is:
> >> [ ] Stable
> >> [ ] Beta - At least one significant issue preventing stability (please
> >> elaborate)
> >> [ ] Alpha - Multiple significant issues (please elaborate)
> >>
> >> As a reminder, only committer votes are binding.  Everyone's opinion
> >> is welcome, of course.
> >
> >
> > There's that clustering bug that Peter said was critical :( So how
> > critical is it ?
> >
> > 
> > Fix Bug 37808 -- 'java.lang.ArrayIndexOutOfBoundsException inside
> > XByteBuffer.java.
> > Very production critical bug, arrgh!
> > 
> >
> > Rémy
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
> >
>
>
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37895] - isapi 1.2.15 connector when configured on IIS6.0(W2003) with "isapi_redirect.properties does not work

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37895





--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 22:00 ---
IIS is totally unhelpful when it comes to finding problems.. i still cant figure
out the logic of throwing 404 error for prohibited extension.. :-S.. neways..
out here.. i know if it works for others it shud for me too and may i am missing
something really basic somewhere.. that is why I posted both the reg file and
properties... all values are exactly same.. i checked the name etc too.. but not
working.. i know the isapi is finding the properties file and reading it because
if i rename the file to something else, it loads the values from registry and
works fine.. but if i rename it back to isapi_redirect.properties, then the
filter stops working and IIS starts throwing 404 error. NO entry in the ISAPI
log either.   I guess i have to do a bit more hit and try .. but any help will
be appreciated.. thanks in advance..

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Proxied client IP logging

[Shankar Unni]

Tim Funk wrote:

2) X-Forwarded-For (IIRC) can be multi-valued (comma seperated via 
multiple proxies)


Plus, other load balancers seem to stick in other headers, too (e.g. 
"X-Real-IP").  (These two seem to be the most popular).


It'll be an interesting job to figure out the "real" IP address if your 
request goes through *two* proxy servers, and they each set a different 
header..



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r356889 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java

[pero]

Author: pero
Date: Wed Dec 14 13:58:18 2005
New Revision: 356889

URL: http://svn.apache.org/viewcvs?rev=356889&view=rev
Log:
compress flag is not need inside count packages!

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java?rev=356889&r1=356888&r2=356889&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java
 Wed Dec 14 13:58:18 2005
@@ -158,8 +158,7 @@
 //if the header (START_DATA) isn't the first thing or
 //the buffer isn't even 14 bytes
 if ( index != start || ((bufSize-start)<14) ) break;
-//then get the compress 4 bytes
-int compress = toInt(buf, pos);
+//next 4 bytes are compress flag not needed for count packages
 //then get the size 4 bytes
 int size = toInt(buf, pos+4);
 //now the total buffer has to be long enough to hold



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37793] - org.apache.jasper.runtime.BodyContentImpl doesn't reset the 'cb' character array, causes memory leak

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37793


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Status|RESOLVED|VERIFIED




--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 23:30 ---
I'm seeing the same problem and are in the process of hunting down several
memory "leaks". Patches against current Tomcat 5.5 SVN will follow.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37896] - FastAsyncSocketSender blocks all threads on socket error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37896





--- Additional Comments From [EMAIL PROTECTED]  2005-12-14 23:32 ---
I'll try to get a copy of the new code, I'm not so sure I can test it though as
the circumstances are quite particular in reproducing this problem and I can't
really take down our live site to test it. I'll at least read through it to see
if the blocking scenerio can take place.

As for the node, yes I think so if I understand your question properly, we only
have 1 node name, and 1 domain name, and 1 context which is distributable.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37896] - FastAsyncSocketSender blocks all threads on socket error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37896





--- Additional Comments From [EMAIL PROTECTED]  2005-12-15 00:25 ---
Okay I had a look at the new code and I'm pretty sure the problem will still
manifest itself. 

The problem isn't with the code perse but I think it's a problem with the design
of the replication. Since the replication is in-line with the HTTP request
(seems like new session requests are inline even in asynch mode), if something
bad happens to the replication socket which causes it to hang, it will block
that thread (presumably until SO_TIMEOUT which is usually 2 minutes).

If a subsequent request comes in for a new session, it will try to do the same
thing but it needs to aquire a lock on the DataSender object via sendMessage();
therefore, this thread will now block until the previous thread timesout. As a
result a lot of threads may backup while waiting for the original socket to 
timeout.

Note that this could happen even in pooled mode, if all 300 threads had their
own 300 replicator sockets, and each sat there waiting to timeout for 2 minutes,
then there wuld be no more threads available (assuming I'm maxed at 300 
threads).

The only things I can really think of to resolve this is to have the replication
on a separate thread to the http requests. 

Of course maybe I'm just mis-reading the code and everything I'm saying might be
wrong...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 35351] - Unable to reference nested/inner classes in tags

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35351





--- Additional Comments From [EMAIL PROTECTED]  2005-12-15 00:57 ---
(In reply to comment #8)
> (In reply to comment #7)
> > I have the fix from glassfish, so the lines can be off.
> 
> Just to be clear, is this patch is still covered by your CCLA?  In English, 
> is 
> this a grant from glassfish to that ASF?
> 

This is just a patch, and there is no license or copyright, so YES.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37896] - FastAsyncSocketSender blocks all threads on socket error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37896





--- Additional Comments From [EMAIL PROTECTED]  2005-12-15 01:23 ---
Fast async has been designed to be used asynchronously. With such a
configuration, no tcp communication for replication will be done during the
request-response lifecycle. Instead all replication messages will only put into
a local queue. Seperate threads will pick up these messages an send them. The
queue will be locked while taking out the messages, but the lock will b freed
before actually trying to send a message.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Tomcat v5.5.14 Stability

[Bill Barker]

"Yoav Shapira" <[EMAIL PROTECTED]> wrote in message 
news:[EMAIL PROTECTED]

>Tomcat 5.5.14 is:
>[ ] Stable
>[X] Beta - At least one significant issue preventing stability (please 
>elaborate)
>[ ] Alpha - Multiple significant issues (please elaborate)
>

BZ 37852 is about as significant as it gets :).




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r356975 - /tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Generator.java

[billbarker]

Author: billbarker
Date: Wed Dec 14 20:15:17 2005
New Revision: 356975

URL: http://svn.apache.org/viewcvs?rev=356975&view=rev
Log:
Fix problem using an inner class for a .

I have no reason to not believe that kinman's CCLA isn't still in effect, so I 
don't see an IP issue in accepting the patch.

Fix for Bug #35351
Submitted by: Kin-Man Chung (kinman at apache dot org)


Modified:

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Generator.java

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Generator.java?rev=356975&r1=356974&r2=356975&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Generator.java
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Generator.java
 Wed Dec 14 20:15:17 2005
@@ -1142,8 +1142,48 @@
 String type = n.getTextAttribute("type");
 Node.JspAttribute beanName = n.getBeanName();
 
-if (type == null) // if unspecified, use class as type of bean
-type = klass;
+// If "class" is specified, try an instantiation at compile time
+boolean generateNew = false;
+String canonicalName = null;// Canonical name for klass
+if (klass != null) {
+try {
+Class bean = ctxt.getClassLoader().loadClass(klass);
+if (klass.indexOf('$') >= 0)  {
+// Obtain the canonical type name
+canonicalName = JspUtil.getCanonicalName(bean);
+} else {
+canonicalName = klass;
+}
+int modifiers = bean.getModifiers();
+if (!Modifier.isPublic(modifiers) ||
+Modifier.isInterface(modifiers) ||
+Modifier.isAbstract(modifiers)) {
+throw new Exception("Invalid bean class modifier");
+}
+// Check that there is a 0 arg constructor
+bean.getConstructor(new Class[] {});
+// At compile time, we have determined that the bean class
+// exists, with a public zero constructor, new() can be
+// used for bean instantiation.
+generateNew = true;
+} catch (Exception e) {
+// Cannot instantiate the specified class, either a
+// compilation error or a runtime error will be raised,
+// depending on a compiler flag.
+
if(ctxt.getOptions().getErrorOnUseBeanInvalidClassAttribute()) {
+err.jspError(n, "jsp.error.invalid.bean", klass);
+}
+if (canonicalName == null) {
+// Doing our best here to get a canonical name
+// from the binary name, should work 99.99% of time.
+canonicalName = klass.replace('$','.');
+}
+}
+if (type == null) {
+// if type is unspecified, use "class" as type of bean
+type = canonicalName;
+}
+}
 
 String scopename = "PageContext.PAGE_SCOPE"; // Default to page
 String lock = "_jspx_page_context";
@@ -1204,43 +1244,23 @@
 /*
  * Instantiate the bean if it is not in the specified scope.
  */
-boolean generateNew = false;
-if (beanName == null) {
-try {
-Class bean = ctxt.getClassLoader().loadClass(klass);
-int modifiers = bean.getModifiers();
-if (!Modifier.isPublic(modifiers) ||
-Modifier.isInterface(modifiers) ||
-Modifier.isAbstract(modifiers)) {
-throw new Exception("Invalid bean class modifier");
-}
-// Check that there is a 0 arg constructor
-bean.getConstructor(new Class[] {});
-generateNew = true;
-} catch (Exception e) {
-// Cannot instantiate the specified class
-if 
(ctxt.getOptions().getErrorOnUseBeanInvalidClassAttribute()) {
-err.jspError(n, "jsp.error.invalid.bean", klass);
-}
-}
-}
 if (!generateNew) {
-String className;
+String binaryName;
 if (

DO NOT REPLY [Bug 35351] - Unable to reference nested/inner classes in tags

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35351


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-12-15 05:17 ---
Kin-Man's patch has been applied to SVN trunk, and will appear in 5.5.15.

(and, yes, the line numbers are off :).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r356976 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml

[billbarker]

Author: billbarker
Date: Wed Dec 14 20:25:15 2005
New Revision: 356976

URL: http://svn.apache.org/viewcvs?rev=356976&view=rev
Log:
Doc change

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=356976&r1=356975&r2=356976&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Wed Dec 14 20:25:15 2005
@@ -29,6 +29,13 @@
   
 
   
+  
+
+  
+35351: Fix problem using an inner class for a . (kinman).
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r356977 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml

[billbarker]

Author: billbarker
Date: Wed Dec 14 20:31:38 2005
New Revision: 356977

URL: http://svn.apache.org/viewcvs?rev=356977&view=rev
Log:
fix typo

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=356977&r1=356976&r2=356977&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Wed Dec 14 20:31:38 2005
@@ -32,7 +32,7 @@
   
 
   
-35351: Fix problem using an inner class for a . (kinman).
+35351: Fix problem using an inner class for a 
. (kinman).
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37458] - Datarace on org.apache.catalina.loader.WebappClassLoader

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37458





--- Additional Comments From [EMAIL PROTECTED]  2005-12-15 06:34 ---
(In reply to comment #1)
> Suggested fix?

This is one possible scence to cause an exeption: suppose two threads t1 and t2,
both are trying to load a same new class. t1 goes first and hit the line 1630,
definePackage(packageName, entry.manifest, entry.codeBase), and stops before the
method call. Then t2 goes ahead and it can hit the same method call too since
the entry.manifest is still not null at that time. And then t2 or t1 continues
and loads the class and sets entry.manifest at the end. After this, when the
other thread tries to finish the call to definePackage, an exception will be
thrown since entry.manifest and entry.codebase have become null now.

I haven't got any good solution so far. One could use a huge sync block to
protect the test on entry.manifest and the corresponding later change, but that
would make it inefficient. Another alternative is to catch the nullpointer
exception thrown by definePackage and ignore it if possible.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37896] - FastAsyncSocketSender blocks all threads on socket error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37896


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-12-15 08:57 ---
Hmm,

when you don't want update complete to 5.5.15 (svn head) you can
compile the cluster module and copy the resulting catalina-cluster.jar inside
5.5.12 release. 

The default cluster configuration normaly used fastasyncqueue, the problem is
that the subclass not implement the right method. Now is fixed and all is
working well.

Peter

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]