DO NOT REPLY [Bug 37629] - No worker files

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37629





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 09:45 ---
When I compare /conf directory between v5.1.12 and 5.1.11, the 
following files are missing in 5.1.12 version:
* jk2.manifest * shm.manifest
* jk2.properties   * tomcat-jk2.manifest
* jkconf.ant.xml   * uriworkermap.properties
* jkconfig.manifest* workers2.properties
* workers2.properties.minimal  * workers.properties
* workers.properties.minimal

I suppose that all files containing "2" are releted to mod_jk2 which is 
deprecated, but other files are related to mod_jk which is required to 
communicate between apache HTTPD and Tomcat (if my understanding is correct).
Are these files missing by purpose and in this case what is the new procedure 
to communicate between Apache and Tomcat (doc still mentions worker.properties 
file) or is it just a mistake?
Thanks for your help.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37326] - No error reported when has non-existent target

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37326





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 11:32 ---
(In reply to comment #2)
OK have done that.  Used fresh install of TC5.5.12 installed as windows 
service using the service.bat script (which is my standard dev setup).  TC is 
unmodified from standard install, except that I added my test.war (attached) 
to the webapps folder. No other changes to standard setup.  PS am using jdk 
1.5.0_02-b09

For some reason could not get DEBUG/ALL logging of the class to work with 
java.util.logging (which is what I normally use), so installed log4j instead 
exactly as described on the logging docs page (at 
http://tomcat.apache.org/tomcat-5.5-doc/logging.html), with the exception that 
I modified log4j.properties as shown below to give DEBUG level on the 
ApplicationDispatcher, hope this is correct, not sure as do not know log4j 
well:

log4j.rootLogger=info, R 
log4j.appender.R=org.apache.log4j.RollingFileAppender 
log4j.appender.R.File=${catalina.home}/logs/tomcat.log 
log4j.appender.R.MaxFileSize=10MB 
log4j.appender.R.MaxBackupIndex=10 
log4j.appender.R.layout=org.apache.log4j.PatternLayout 
log4j.appender.R.layout.ConversionPattern=%p %t %c - %m%n 
log4j.logger.org.apache.catalina.core.ApplicationDispatcher=DEBUG

Then ran the request to http://localhost:8080/test/ to test the attached war.  
Page worked fine as before, no reported errors in logfile or browser, despite 
one of the included files being missing from the webapp.  The entire contents 
of the resulting tomcat.log are attached.

Hope this helps, just let me know if you need anything else.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37326] - No error reported when has non-existent target

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37326





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 11:33 ---
Created an attachment (id=17073)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17073&action=view)
tomcat.log with DEBUG level for ApplicationDispatcher


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37326] - No error reported when has non-existent target

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37326


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #16849|text/xml|application/octet-stream
  mime type||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37326] - No error reported when has non-existent target

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37326


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #17073|tomcat.log with DEBUG level |tomcat.log using log4j with
description|for ApplicationDispatcher   |DEBUG level for
   ||ApplicationDispatcher




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC|[EMAIL PROTECTED] |
   Severity|major   |normal




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 11:45 ---
First, the current code is:

} else if (actionCode == ActionCode.ACTION_REQ_LOCAL_ADDR_ATTRIBUTE) {

// Get local host address
if (localAddr == null && (socket != 0)) {
try {
long sa = Address.get(Socket.APR_LOCAL, socket);
Sockaddr addr = new Sockaddr();
if (Address.fill(addr, sa)) {
localAddr = addr.hostname;
localPort = addr.port;
}
} catch (Exception e) {
log.warn(sm.getString("http11processor.socket.info"), e);
}
}

request.localAddr().setString(localAddr);

Then, I don't really care about this issue, so please stop spamming me about it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 10903] - Unbalanced tags do not generate compile time error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=10903





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 14:27 ---
I just downloaded Tomcat 5.5.12 and tried it. I still get 
$ 29 nov. 2005 14:26:53 org.apache.catalina.core.ApplicationDispatcher invoke
GRAVE: "Servlet.service()" pour la servlet fw3Servlet a lancé une exception
org.apache.jasper.JasperException: /WebV3Page_3-view.jsp(11,1) The end tag
"

svn commit: r349715 - /tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java

[remm]

Author: remm
Date: Tue Nov 29 05:29:07 2005
New Revision: 349715

URL: http://svn.apache.org/viewcvs?rev=349715&view=rev
Log:
- 37673: Fix getLocalName and getLocalPort.

Modified:

tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java

Modified: 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=349715&r1=349714&r2=349715&view=diff
==
--- 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
 (original)
+++ 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
 Tue Nov 29 05:29:07 2005
@@ -1045,11 +1045,7 @@
 if (localAddr == null && (socket != 0)) {
 try {
 long sa = Address.get(Socket.APR_LOCAL, socket);
-Sockaddr addr = new Sockaddr();
-if (Address.fill(addr, sa)) {
-localAddr = addr.hostname;
-localPort = addr.port;
-}
+localAddr = Address.getip(sa);
 } catch (Exception e) {
 log.warn(sm.getString("http11processor.socket.info"), e);
 }
@@ -1077,11 +1073,8 @@
 if (localPort == -1 && (socket != 0)) {
 try {
 long sa = Address.get(Socket.APR_LOCAL, socket);
-Sockaddr addr = new Sockaddr();
-if (Address.fill(addr, sa)) {
-localAddr = addr.hostname;
-localPort = addr.port;
-}
+Sockaddr addr = Address.getInfo(sa);
+localPort = addr.port;
 } catch (Exception e) {
 log.warn(sm.getString("http11processor.socket.info"), e);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 14:31 ---
The issue is now fixed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349717 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml

[remm]

Author: remm
Date: Tue Nov 29 05:55:55 2005
New Revision: 349717

URL: http://svn.apache.org/viewcvs?rev=349717&view=rev
Log:
- Changelog update.

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349717&r1=349716&r2=349717&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Tue Nov 29 05:55:55 2005
@@ -158,6 +158,10 @@
 37627: Fix buffering issue in the HTTP APR connector when a 
large buffer size was
 used for servlets (remm)
   
+  
+37673: Fix implementation of getLocalPort and getLocalAddr 
in the HTTP APR connector
+(remm)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37629] - No worker files

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37629


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 15:10 ---
My understanding is that it's not a mistake.  The JK2 files are gone on purpose
obviously (although you can still get them with JK2 and older downloads if you
want).  The JK files are still supported, but are now distributed with mod_jk
itself: for example, workers.properties is still needed, and comes with the
mod_jk download.

If you have further questions, please ask on the users@tomcat.apache.org mailing
list.  Bugzilla is not the best place for this type of discussion.  Thank you.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37326] - No error reported when has non-existent target

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37326


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 15:11 ---
Steve, thank you.  This helps.  I'll try to find more time to look at this
within the next few days.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37692] New: - RequestProcessors are no longer registered in JMX

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37692

   Summary: RequestProcessors are no longer registered in JMX
   Product: Tomcat 5
   Version: 5.5.12
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


With Tomcat 5.5.12, individual RequestProcessors do not show up when I attempt
to access them via JMX. Is this by design, or a new bug? If by design,
documentation will need to be updated since the query below is used as an
example in the javadocs and the remote administration documentation. The example
below uses the Manager app's jmxproxy.

Under Tomcat 5.5.12, when I access this URL:
/manager/jmxproxy/?qry=*%3Atype%3DRequestProcessor%2C*

I get the following result:
-
OK - Number of results: 0
-

Under Tomcat 5.5.11, accessing the same URL:

I get this result:
-
OK - Number of results: 2

Name: Catalina:type=RequestProcessor,worker=http-8680,name=HttpRequest0
modelerType: org.apache.coyote.RequestInfo
virtualHost: 
bytesSent: 0
method: GET
remoteAddr: 
requestBytesSent: 0
contentLength: -1
bytesReceived: 0
requestProcessingTime: 104
globalProcessor: [EMAIL PROTECTED]
protocol: HTTP/1.1
currentQueryString: qry=*%3Atype%3DRequestProcessor%2C*
requestBytesReceived: 0
serverPort: 8680
stage: 3
requestCount: 0
maxTime: 0
processingTime: 0
currentUri: /manager/jmxproxy/
errorCount: 0
--snip---

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37692] - RequestProcessors are no longer registered in JMX

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37692


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 16:34 ---
It's a feature.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37693] New: - APR Connector not up to Servlet 2.4 API spec for getLocalAddr() method

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37693

   Summary: APR Connector not up to Servlet 2.4 API spec for
getLocalAddr() method
   Product: Tomcat 5
   Version: 5.5.12
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:HTTP
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


The servlet API spec reads as follows:

getLocalAddr
public java.lang.String getLocalAddr()The default behavior of this method is to 
return getLocalAddr() on the wrapped request object. 

Specified by:
getLocalAddr in interface ServletRequest
Returns:
a String containing the IP address on which the request was received.
Since: 
2.4 

I tracked down the bug to the following code:

Http11AprProcessor.java 

The action() method which is called with 

ActionCode.ACTION_REQ_LOCAL_ADDR_ATTRIBUTE

assings a hostname instead of an ip address to the localAddr variable 

1050: localAddr = addr.hostname;

which then sets it in the request object

1058: request.localAddr().setString(localAddr);

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37693] - APR Connector not up to Servlet 2.4 API spec for getLocalAddr() method

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37693


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:01 ---


*** This bug has been marked as a duplicate of 37673 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:01 ---
*** Bug 37693 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37693] - APR Connector not up to Servlet 2.4 API spec for getLocalAddr() method

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37693





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:02 ---
Created an attachment (id=17076)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17076&action=view)
Simple JSP demonstrating the bug

This JSP demonstrates the bug clearly. It has both request.getLocalName() which
should return the local server's hostname. It also has request.getLocalAddr()
which returns the machines hostname, it should return the local server's IP
address. Open the .jsp in Tomcat 5.5.12 using the APR native connector.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37692] - RequestProcessors are no longer registered in JMX

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37692





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:02 ---
Then, as noted, the documentation will need to be updated to not suggest that
one can see RequestProcessors using the method shown. These are two places I've
seen the outdated docs:

http://tomcat.apache.org/tomcat-5.5-doc/manager-howto.html
http://tomcat.apache.org/tomcat-5.5-doc/catalina/docs/api/org/apache/catalina/ant/JMXQueryTask.html

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:06 ---
Remy you do not care if your code is up to servlet 2.4 specification? 

Trust me, I am not doing this to waste your or my time...

I am a professional Java developer using Tomcat in a production evironment. We 
want to use the APR connector, but this bug is forcing me to recommend we NOT 
use it. If you won't fix it I can look into fixing it myself.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37692] - RequestProcessors are no longer registered in JMX

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37692





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:12 ---
(In reply to comment #2)
> Then, as noted, the documentation will need to be updated to not suggest that
> one can see RequestProcessors using the method shown. These are two places 
> I've
> seen the outdated docs:

I was evidently sarcastic: this works perfectly fine, and the JMX objects are
properly registered.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37695] New: - Try to run Struts

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37695

   Summary: Try to run Struts
   Product: Tomcat 5
   Version: 5.5.12
  Platform: Other
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


javax.servlet.ServletException: Servlet.init() for servlet action threw 
exception
org.apache.catalina.valves.ErrorReportValve.invoke
(ErrorReportValve.java:105)
org.apache.catalina.connector.CoyoteAdapter.service
(CoyoteAdapter.java:148)
org.apache.coyote.http11.Http11Processor.process
(Http11Processor.java:868)
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.pro
cessConnection(Http11BaseProtocol.java:663)
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket
(PoolTcpEndpoint.java:527)
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt
(LeaderFollowerWorkerThread.java:80)
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(ThreadPool.java:684)
java.lang.Thread.run(Unknown Source)


root cause 

java.lang.NullPointerException
org.apache.struts.action.ActionServlet.parseModuleConfigFile
(ActionServlet.java:705)
org.apache.struts.action.ActionServlet.initModuleConfig
(ActionServlet.java:670)
org.apache.struts.action.ActionServlet.init(ActionServlet.java:342)
javax.servlet.GenericServlet.init(GenericServlet.java:211)
org.apache.catalina.valves.ErrorReportValve.invoke
(ErrorReportValve.java:105)
org.apache.catalina.connector.CoyoteAdapter.service
(CoyoteAdapter.java:148)
org.apache.coyote.http11.Http11Processor.process
(Http11Processor.java:868)
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.pro
cessConnection(Http11BaseProtocol.java:663)
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket
(PoolTcpEndpoint.java:527)
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt
(LeaderFollowerWorkerThread.java:80)
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(ThreadPool.java:684)
java.lang.Thread.run(Unknown Source)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 17:54 ---
Created an attachment (id=17077)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17077&action=view)
JSP example demonstrating the bug

Simple JSP demonstrating the bug

This JSP demonstrates the bug clearly. It has both request.getLocalName() which

should return the local server's hostname. It also has request.getLocalAddr()
which returns the machines hostname, it should return the local server's IP
address. Open the .jsp in Tomcat 5.5.12 using the APR native connector.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Bug Being marked RESOLVED and FIXED when it's not...

[Nate Rock]

What does one do when a bug is closed as "RESLOVED" and "FIXED" when
it's not actually fixed? The bug has a proposed code fix and an
attachment which has code demonstrating the bug. Since the author
"really doesn't care about this issue" how can I see about getting it
resolved?

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673

I belive it's been closed because I initially pasted in some code that I
was working on to try and resolve the issue instead of the original
source and didn't know how to change my original post... sorry Remy, my
bad =(

I am trying to give back to the apache community, but thus far it has
been frustrating. I realize I made some "n00bish" mistakes and am
willing to work with the apache dev team in whatever way they deem
appropriate.

Thanks for your attention!

  -rOcK

Nate Rock
Java Devloper
Infinite Campus

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37695] - Try to run Struts

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37695


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID
Summary|Try to run Struts   |Try to run Struts




--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 18:03 ---
Please use the struts user list for help. This is a configuration issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349764 - in /tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11: Http11AprProcessor.java Http11Processor.java

[remm]

Author: remm
Date: Tue Nov 29 09:03:43 2005
New Revision: 349764

URL: http://svn.apache.org/viewcvs?rev=349764&view=rev
Log:
- localName was never reset.

Modified:

tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java

tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11Processor.java

Modified: 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=349764&r1=349763&r2=349764&view=diff
==
--- 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
 (original)
+++ 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11AprProcessor.java
 Tue Nov 29 09:03:43 2005
@@ -746,6 +746,7 @@
 remoteAddr = null;
 remoteHost = null;
 localAddr = null;
+localName = null;
 remotePort = -1;
 localPort = -1;
 

Modified: 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11Processor.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11Processor.java?rev=349764&r1=349763&r2=349764&view=diff
==
--- 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11Processor.java
 (original)
+++ 
tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/Http11Processor.java
 Tue Nov 29 09:03:43 2005
@@ -772,6 +772,7 @@
 remoteAddr = null;
 remoteHost = null;
 localAddr = null;
+localName = null;
 remotePort = -1;
 localPort = -1;
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] - Http11AprProcessor.java - getLocalAddr() returns HostName

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 18:40 ---
Looks like it's been resolved and fixed! Remy is the MAN /bow

http://svn.apache.org/viewcvs.cgi/tomcat/connectors/trunk/http11/src/java/org/ap
ache/coyote/http11/Http11AprProcessor.java?rev=349715&view=markup

My bad Remy, didn't see your fixed post above... I was too busy creating the 
duplicate bug 37693... still learning about the whole apache dev process sorry 
for any inconvenience it might have caused you. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Bug Being marked RESOLVED and FIXED when it's not...

[Yoav Shapira]

Nate,

> What does one do when a bug is closed as "RESLOVED" and "FIXED" when
> it's not actually fixed?

Bugs are marked as FIXED when a fix has been committed to the source
code repository.  You can see the fix browsing http://svn.apache.org. 
If you're not sure how to navigate that structure, start at
http://svn.apache.org/viewcvs.cgi/tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/
and click on the relevant files.  You can see code diffs there as
well.

This is different from marking issues as FIXED when a release comes
out: both approaches have their pros and cons.  We use the former for
many reasons, and prefer to stay that away.

If a bug is marked as FIXED but you can't find a relevant commit, you
do what you did (albeit in a nicer tone if possible ;)) and ask on the
dev@tomcat.apache.org mailing list.

--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37698] New: - Try to run Struts Tomcat 5.5.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37698

   Summary: Try to run Struts  Tomcat 5.5.12
   Product: Tomcat 5
   Version: 5.5.12
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Error
Servlet action is not available

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37698] - Try to run Struts Tomcat 5.5.12

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37698


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Bug Being marked RESOLVED and FIXED when it's not...

[Nate Rock]

Special thanks to Remy for resolving the issue! I appolgize to him
specifically and to the dev list in general for the harshness of some of
my comments, I was frustrated after seeing my first atempt at debugging
actual Tomcat code being thwarted becaues of a simple error on my part.
I am "new" to the world of contributing to the Apache Tomcat Open Source
project and appreciate the patience and understanding shown by those
involved.

That being said, I have learned a LOT about the tomcat/apache project
and process in general and look forward to contributing in any way I can
in the future. 

Yoav, I actually stumbled upon the commited source fix while parusing a
link to one of the other emails that came through a bit ago, but your
explination was spot on, thank you. Here is the specific fix if anyone
is interested.

http://svn.apache.org/viewcvs.cgi/tomcat/connectors/trunk/http11/src/jav
a/org/apache/coyote/http11/Http11AprProcessor.java?rev=349764&view=marku
p

Again, thank you all for your help!!! Less than a full day's turn around
for a bug fix is commendable... Viva Open Source! I will have to say
that our company has been impressed with what the Tomcat developers have
been able to turn out and I have finally been given a glimps of the
action behind the scene;) Now back to the daily grind =*( 

Sincerely,

   -rOcK

Nate Rock
Java Devloper
Infinite Campus

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of
Yoav Shapira
Sent: Tuesday, November 29, 2005 11:45 AM
To: Tomcat Developers List
Subject: Re: Bug Being marked RESOLVED and FIXED when it's not...

Nate,

> What does one do when a bug is closed as "RESLOVED" and "FIXED" when 
> it's not actually fixed?

Bugs are marked as FIXED when a fix has been committed to the source
code repository.  You can see the fix browsing http://svn.apache.org. 
If you're not sure how to navigate that structure, start at
http://svn.apache.org/viewcvs.cgi/tomcat/connectors/trunk/http11/src/jav
a/org/apache/coyote/http11/
and click on the relevant files.  You can see code diffs there as well.

This is different from marking issues as FIXED when a release comes
out: both approaches have their pros and cons.  We use the former for
many reasons, and prefer to stay that away.

If a bug is marked as FIXED but you can't find a relevant commit, you do
what you did (albeit in a nicer tone if possible ;)) and ask on the
dev@tomcat.apache.org mailing list.

--
Yoav Shapira
System Design and Management Fellow
MIT Sloan School of Management
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED] For additional
commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 10903] - Unbalanced tags do not generate compile time error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=10903





--- Additional Comments From [EMAIL PROTECTED]  2005-11-29 20:56 ---
Just repeated my test with a clean download of 5.5.12 and it still works 
correctly.

Looking at your stack trace, you appear to have a modified Tomcat version. I
suggest you approach whoever provided you with this version of tomact. A Google
search around net.atos.mm.fwk.fw3 didn't turn up any obvious culprits but I
wasn't really looking that hard.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: getContext() - spec interpretation

[Mark Thomas]

Jan,

Jan Luehe wrote:

Hi Mark,



I agree the current javadocs of ServletContext.getContext() are
ambiguous, and I agree we need to present this case to the
Servlet EG. Maybe there is a small chance to have this resolved
in the Servlet 2.5 timeframe ...

I think it would be more useful to have the "uripath" argument be
interpreted as a full URI rather than a context root, and have
ServletContext.getContext() determine the longest match of the given
"uripath" with the context roots of any deployed contexts.


 I agree the current behaviour, which "hides" any foreign contexts

whose context roots match a subdir of the current context, is broken
(in part because of the spec ambiguity), because it returns different
results depending on the context from which the getContext() call is
made.

I don't see why we need to restrict "uripath" to be a context root in
order to fix the current behaviour, though. As I said, returning
the context whose context root has the longest match with the given
"uripath" may make more sense.

Would you agree?


Jan


I have just re-read the spec keeping score of number of times the 
wording suggests an exact match or a longest match. The result was a 
draw so I am happy to interpret it either way. Given that the longest 
match makes the most sense to me and won't break any existing 
functionality I will take this approach until the EG issues some 
clarification. Hopefully they will clarify it the "right" way.


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349829 - in /tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF: classes/org/apache/webapp/admin/filters/SetCharacterEncodingFilter.java web.xml

[markt]

Author: markt
Date: Tue Nov 29 15:13:49 2005
New Revision: 349829

URL: http://svn.apache.org/viewcvs?rev=349829&view=rev
Log:
Align package name with directory structure.

Modified:

tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/filters/SetCharacterEncodingFilter.java
tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/web.xml

Modified: 
tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/filters/SetCharacterEncodingFilter.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/filters/SetCharacterEncodingFilter.java?rev=349829&r1=349828&r2=349829&view=diff
==
--- 
tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/filters/SetCharacterEncodingFilter.java
 (original)
+++ 
tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/filters/SetCharacterEncodingFilter.java
 Tue Nov 29 15:13:49 2005
@@ -15,7 +15,7 @@
  */
 
 
-package filters;
+package org.apache.webapp.admin.filters;
 
 
 import java.io.IOException;

Modified: tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/web.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/web.xml?rev=349829&r1=349828&r2=349829&view=diff
==
--- tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/web.xml (original)
+++ tomcat/container/branches/tc4.1.x/webapps/admin/WEB-INF/web.xml Tue Nov 29 
15:13:49 2005
@@ -18,7 +18,7 @@