Re: getContext() - spec interpretation

2005-11-28 Thread Cédrik LIME 

At 18:20 27/11/2005 +, you wrote:

Bill Barker wrote:
I can't really dispute the interpretation of 
the spec, but the change is likely to break many more webapps then it fixes :(.


I thought this too. However, I think we should 
implement the spec as is. If we start relaxing 
it here, then where else do we relax it? If 
other Servlet containers start relaxing the 
specs in their own ways it rapidly defeats the 
object of having a spec in the first place.

[snip]
My preference is to post a 'heads-up' to the 
users list that this change is coming in the 
next release along with a link to the SSI 
changes so users can start to look at their apps ahead of the next release.


Don't forget that not all tc users are on the 
users mailing list. If this change can 
potentially break user applications, there should 
be IMHO a big sign saying so in the release note web page as well.


As for the question, I agree with Mark (+1 for implementing the spec tightly).

Cédrik 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37668] New: - antiResourceLocking stops JSP reloading

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37668

   Summary: antiResourceLocking stops JSP reloading
   Product: Tomcat 5
   Version: 5.5.9
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Webapps:Documentation
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I assume this is expected behaviour so I have logged it against documentation.
I set antiResourceLocking in the context.xml file for my application, I then
made some changes to a "running" JSP, expecting Tomcat to detect the changes and
re compile. Reading around I found that using antiResourceLocking causes tomcat
to copy the webapp to a temp folder. My guess is that the jsp file I am editing
in the webapps/app directory is no longer the one that tomcat is using, and
hence I see no changes. Probably should say this in the Context Reference
documentation.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349453 - /tomcat/container/branches/tc5.0.x/webapps/docs/status.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 10:31:17 2005
New Revision: 349453

URL: http://svn.apache.org/viewcvs?rev=349453&view=rev
Log:
Updated status: Bugzilla 37281: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=37281

Modified:
tomcat/container/branches/tc5.0.x/webapps/docs/status.xml

Modified: tomcat/container/branches/tc5.0.x/webapps/docs/status.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc5.0.x/webapps/docs/status.xml?rev=349453&r1=349452&r2=349453&view=diff
==
--- tomcat/container/branches/tc5.0.x/webapps/docs/status.xml (original)
+++ tomcat/container/branches/tc5.0.x/webapps/docs/status.xml Mon Nov 28 
10:31:17 2005
@@ -29,9 +29,10 @@
 
   
 
-  Tomcat 5.0.29 was released on October 6th, 2004.  Work on the 5.0 
branch is primarily
-  for maintenance and bug fixes.  It is still considered the best branch 
for production use, but
-  Tomcat 5.5 is rapidly nearing a stable release.
+  Tomcat 5.0 is in maintenance-only mode, with no regular release 
schedule.  
+  Tomcat 5.0.30 was the last Tomcat release: it was voted as Beta 
quality, so 
+  Tomcat 5.0.28 is the latest stable one for users of the 5.0 
branch.  All users
+  are encouraged to update to Tomcat 5.5.
 
 
   Tomcat 5.5 has several major goals.  They are discussed in the 
tomcat-dev



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37281] - Current Status Summary is misleading

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37281


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 19:40 ---
Fixed in SVN and in tomcat-5.0 docs site (which will be updated in ~1hr).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37669] New: - Invalid classname in catalina-ant antlib.xml

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37669

   Summary: Invalid classname in catalina-ant antlib.xml
   Product: Tomcat 5
   Version: 5.5.12
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


The antlib.xml contained in catalina-ant.jar has an error in a classname which
makes the JKStatusUpdateTask more difficult to use. JKStatusUpdateTask is
entered into that file as "JkStatusUpdateTask".

Here's a patch:


Index: 
C:/workspace/container/catalina/src/share/org/apache/catalina/ant/antlib.xml
===
---
C:/workspace/container/catalina/src/share/org/apache/catalina/ant/antlib.xml
(revision 349458)
+++
C:/workspace/container/catalina/src/share/org/apache/catalina/ant/antlib.xml
(working copy)
@@ -29,7 +29,7 @@
 classname="org.apache.catalina.ant.SessionsTask" />
   
+classname="org.apache.catalina.ant.JKStatusUpdateTask" />
   

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349460 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/ant/antlib.xml webapps/docs/changelog.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 11:15:08 2005
New Revision: 349460

URL: http://svn.apache.org/viewcvs?rev=349460&view=rev
Log:
Bugzilla 37669: http://issues.apache.org/bugzilla/show_bug.cgi?id=37669

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ant/antlib.xml
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ant/antlib.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ant/antlib.xml?rev=349460&r1=349459&r2=349460&view=diff
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ant/antlib.xml 
(original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ant/antlib.xml 
Mon Nov 28 11:15:08 2005
@@ -29,7 +29,7 @@
 classname="org.apache.catalina.ant.SessionsTask" />
   
+classname="org.apache.catalina.ant.JKStatusUpdateTask" />
   

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349460&r1=349459&r2=349460&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 11:15:08 2005
@@ -46,6 +46,9 @@

 37284: Guess JSE 5.0 location on Mac OS X, patch by Stepan 
Koltsov. (yoavs)
   
+  
+: Wrong class name in antlib.xml for JkStatusUpdateTask. 
(yoavs)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37669] - Invalid classname in catalina-ant antlib.xml

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37669


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 20:15 ---
Fixed, thanks for reporting it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349473 - in /tomcat/container/tc5.5.x/webapps/docs: changelog.xml config/engine.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 11:33:27 2005
New Revision: 349473

URL: http://svn.apache.org/viewcvs?rev=349473&view=rev
Log:
Bugzilla 37591: http://issues.apache.org/bugzilla/show_bug.cgi?id=37591

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
tomcat/container/tc5.5.x/webapps/docs/config/engine.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349473&r1=349472&r2=349473&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 11:33:27 2005
@@ -101,7 +101,11 @@
   Fix for a couple of (mostly silly) edge-cases in testing auth.
Thanks to Nam T. Nguyen for the report. (billbarker) 
   
-  37060: Actually copy the Request headers when replaying 
after Form auth. (billbarker)
+  
+37060: Actually copy the Request headers when replaying 
after Form auth. (billbarker)
+  
+  
+37591: Typo in Engine configuration reference. (yoavs)
   
 
   

Modified: tomcat/container/tc5.5.x/webapps/docs/config/engine.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/config/engine.xml?rev=349473&r1=349472&r2=349473&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/config/engine.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/config/engine.xml Mon Nov 28 11:33:27 
2005
@@ -69,7 +69,7 @@
 
   
 Identifier which must be used in load balancing scenarios to enable
-session affinity. The indetifier, which must be unique across all
+session affinity. The identifier, which must be unique across all
 Tomcat 5 servers which participate in the cluster, will be appended to
 the generated session identifier, therefore allowing the front end
 proxy to always forward a particular session to the same Tomcat 5



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37591] - wrong typing in the doc

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37591


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 20:34 ---
Fixed, thanks for reporting it (even if the bug has the wrong URL and the
suggested fix is the same as the bug ;))

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349477 - /tomcat/container/tc5.5.x/webapps/docs/changelog.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 11:44:31 2005
New Revision: 349477

URL: http://svn.apache.org/viewcvs?rev=349477&view=rev
Log:
Bugzilla 37612: http://issues.apache.org/bugzilla/show_bug.cgi?id=37612

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349477&r1=349476&r2=349477&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 11:44:31 2005
@@ -162,6 +162,10 @@
 37407: File descriptor leak in JspReader.  Thanks to Fred 
for the patch.  I also
 did some minor cleanup in the class. (yoavs)
   
+  
+37612: Add file location to JSP Validator error message.  
Thanks to Renaud Bruyeron
+for the patch. (yoavs)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349479 - in /tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper: compiler/Validator.java resources/LocalStrings.properties resources/LocalStrings_es.properties resources/LocalStrin

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 11:44:47 2005
New Revision: 349479

URL: http://svn.apache.org/viewcvs?rev=349479&view=rev
Log:
Bugzilla 37612: http://issues.apache.org/bugzilla/show_bug.cgi?id=37612

Modified:

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Validator.java

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings.properties

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_es.properties

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_fr.properties

tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_ja.properties

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Validator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Validator.java?rev=349479&r1=349478&r2=349479&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Validator.java
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/compiler/Validator.java
 Mon Nov 28 11:44:47 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 1999,2004 The Apache Software Foundation.
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -1531,7 +1531,7 @@
}
 errMsg.append("");
 
errMsg.append(Localizer.getMessage("jsp.error.tlv.invalid.page",
-  tli.getShortName()));
+  tli.getShortName(), 
compiler.getPageInfo().getJspFile()));
 errMsg.append("");
 for (int i=0; ihttp://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings.properties?rev=349479&r1=349478&r2=349479&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings.properties
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings.properties
 Mon Nov 28 11:44:47 2005
@@ -267,7 +267,7 @@
 jspc.error.emptyWebApp=-webapp requires a trailing file argument
 jsp.error.library.invalid=JSP page is invalid according to library {0}: {1}
 jsp.error.tlvclass.instantiation=Failed to load or instantiate 
TagLibraryValidator class: {0}
-jsp.error.tlv.invalid.page=Validation error messages from TagLibraryValidator 
for {0}
+jsp.error.tlv.invalid.page=Validation error messages from TagLibraryValidator 
for {0} in {1}
 jsp.error.tei.invalid.attributes=Validation error messages from TagExtraInfo 
for {0}
 jsp.parser.sax.propertynotsupported=SAX property not supported: {0}
 jsp.parser.sax.propertynotrecognized=SAX property not recognized: {0}

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_es.properties?rev=349479&r1=349478&r2=349479&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_es.properties
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_es.properties
 Mon Nov 28 11:44:47 2005
@@ -267,7 +267,7 @@
 jspc.error.emptyWebApp=-webapp necesita un argumento de archivo
 jsp.error.library.invalid=La página JSP es incorrecta de acuerdo a la 
biblioteca {0}: {1}
 jsp.error.tlvclass.instantiation=No pude cargar o instanciar clase 
TagLibraryValidator: {0}
-jsp.error.tlv.invalid.page=Mensajes de error de validación desde 
TagLibraryValidator para {0}
+jsp.error.tlv.invalid.page=Mensajes de error de validación desde 
TagLibraryValidator para {0} in {1}
 jsp.error.tei.invalid.attributes=Mensajes de error de validación desde 
TagExtraInfo para {0}
 jsp.parser.sax.propertynotsupported=Propiedad SAX no soportada: {0}
 jsp.parser.sax.propertynotrecognized=Propiedad SAX no reconocida: {0}

Modified: 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_fr.properties
URL: 
http://svn.apache.org/viewcvs/tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_fr.properties?rev=349479&r1=349478&r2=349479&view=diff
==
--- 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_fr.properties
 (original)
+++ 
tomcat/jasper/tc5.5.x/jasper2/src/share/org/apache/jasper/resources/LocalStrings_fr.properties
 Mon Nov 28 11:44:47 2005
@@ -218,7 +218,7 @@
 jspc.error

DO NOT REPLY [Bug 37612] - Jasper's Validator does not include full path of file being compiled in error message

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37612


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 20:45 ---
Fixed, thank you for reporting this.

Next time please be careful with the diff -u command order, your patch diff file
was flipped ;)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37629] - No worker files

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37629


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 20:48 ---
Are you talking about the mod_jk2 files?  Those are gone on purpose.  If you're
talking about other files, can you please ask on [EMAIL PROTECTED]

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37668] - antiResourceLocking stops JSP reloading

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37668


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 20:48 ---
You're right, will update documentation right now.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349485 - in /tomcat/container/tc5.5.x/webapps/docs: changelog.xml config/context.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 11:55:11 2005
New Revision: 349485

URL: http://svn.apache.org/viewcvs?rev=349485&view=rev
Log:
Bugzilla 37668: http://issues.apache.org/bugzilla/show_bug.cgi?id=37668

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
tomcat/container/tc5.5.x/webapps/docs/config/context.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349485&r1=349484&r2=349485&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 11:55:11 2005
@@ -107,6 +107,9 @@
   
 37591: Typo in Engine configuration reference. (yoavs)
   
+  
+37668: Added note about JSP recompilation to Context 
configuration documentation. (yoavs)
+  
 
   
   

Modified: tomcat/container/tc5.5.x/webapps/docs/config/context.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/config/context.xml?rev=349485&r1=349484&r2=349485&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/config/context.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/config/context.xml Mon Nov 28 
11:55:11 2005
@@ -231,6 +231,11 @@
 but allows full webapp hot deploy and undeploy on platforms 
 or configurations where file locking can occur.
 If not specified, the default value is false.
+   
+Please note that setting this to true has some side 
effects,
+including the disabling of JSP reloading in a running server: see
+http://issues.apache.org/bugzilla/show_bug.cgi?id=37668";>Bugzilla 
37668.
+
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37668] - antiResourceLocking stops JSP reloading

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37668


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 20:55 ---
Fixed, thank you for reporting this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37326] - No error reported when has non-existent target

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37326


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 21:27 ---
I'm looking at org.apache.catalina.core.ApplicationDispatcher (which I think is
the relevant class), and it seems to log and re-throw all the exceptions. 
Steve, can you please retry it on 5.5.12 with DEBUG-level logging enabled for
this class, and post your findings when you get a chance?  Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37213] - problem when running tomcat with -security option

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37213


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
  Component|Unknown |Native:Integration




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 21:29 ---
Does it happen with stand-alone Tomcat?  Or only with the Windows service?  Does
it happen out of the box?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349499 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java webapps/docs/changelog.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 12:49:42 2005
New Revision: 349499

URL: http://svn.apache.org/viewcvs?rev=349499&view=rev
Log:
Bugzilla 37132: http://issues.apache.org/bugzilla/show_bug.cgi?id=37132

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=349499&r1=349498&r2=349499&view=diff
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/authenticator/DigestAuthenticator.java
 Mon Nov 28 12:49:42 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 1999,2004 The Apache Software Foundation.
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -221,9 +221,8 @@
 return (null);
 authorization = authorization.substring(7).trim();
 
-
-StringTokenizer commaTokenizer =
-new StringTokenizer(authorization, ",");
+// Bugzilla 37132: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=37132
+String[] tokens = authorization.split(",(?=(?:[^\"]*\"[^\"]*\")+$)");
 
 String userName = null;
 String realmName = null;
@@ -235,8 +234,11 @@
 String response = null;
 String method = request.getMethod();
 
-while (commaTokenizer.hasMoreTokens()) {
-String currentToken = commaTokenizer.nextToken();
+for (int i = 0; i < tokens.length; i++) {
+String currentToken = tokens[i];
+if (currentToken.length() == 0)
+continue;
+
 int equalSign = currentToken.indexOf('=');
 if (equalSign < 0)
 return null;

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349499&r1=349498&r2=349499&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 12:49:42 2005
@@ -110,6 +110,10 @@
   
 37668: Added note about JSP recompilation to Context 
configuration documentation. (yoavs)
   
+  
+37132: Have DigestAuthenticator Handle user names with 
commas.  Thanks to 
+  Robert Wille for the patch. (yoavs)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37356] - Tomcat does not invalidate sessions after session-timeout period has passed.

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37356


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 21:52 ---
Is something holding a reference to those sessions?

And does this happen with 5.0.30 or 5.5.12?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37381] - pageContext.forward causes Illegal to clear() when buffer size == 0

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37381


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 21:55 ---
Does this happen in 5.5.12 as well?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 10903] - Unbalanced tags do not generate compile time error

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=10903


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 21:56 ---
This works as expected with the latest versions of 4.x and 5.5.x

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349504 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java webapps/docs/changelog.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 13:05:40 2005
New Revision: 349504

URL: http://svn.apache.org/viewcvs?rev=349504&view=rev
Log:
Bugzilla 37529: http://issues.apache.org/bugzilla/show_bug.cgi?id=37529

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java?rev=349504&r1=349503&r2=349504&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java
 Mon Nov 28 13:05:40 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 1999,2004 The Apache Software Foundation.
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -184,12 +184,18 @@
 }
 
 /**
- * Close Selector
+ * Close Selector.
+ *
  * @see org.apache.catalina.cluster.tcp.ClusterReceiverBase#stopListening()
  */
-protected void stopListening(){
+protected void stopListening() {
+// Bugzilla 37529: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=37529
+doListen = false;
 if ( selector != null ) {
 try {
+for(int i = 0; i < getTcpThreadCount(); i++) {
+selector.wakeup();
+}
 selector.close();
 } catch ( Exception x ) {
 log.error("Unable to close cluster receiver selector.",x);
@@ -197,7 +203,6 @@
 selector = null;
 }
 }
-doListen = false;
}
 
 // --

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349504&r1=349503&r2=349504&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 13:05:40 2005
@@ -211,8 +211,12 @@
   
 36866: Correct attribute name in conf/server.xml 
documentation for Cluster element. (yoavs)
   
-  37261: Allow xerces to know where the web.xml file is so 
that relative entities can be resolved.
-
+  
+37261: Allow xerces to know where the web.xml file is so 
that relative entities can be resolved.
+  
+  
+37529: Fixed race condition in 
ReplicationLister#stopListening.  Thanks to 
+Chris Walker for the patch. (yoavs)
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37529] - Tomcat take a long time to stop when configured for clustering

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37529


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 22:05 ---
Looks like a good catch, thanks for reporting it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Repo clean up

2005-11-28 Thread Mark Thomas 

Later than I originally intended. Sorry.

The candidates for clean up are:
connectors/naming
connectors/webapp
connectors/jk/native2
container/branches/tc4.1.x/jasper/

Clean up == deletion. The nature of svn is such that we can undelete 
things very easily if any of this turns out to be a big mistake.
Any objections or additional candidates before I go ahead and do this? 
 I'll do this at the end of this week unless someone objects.


Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r349505 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Connector.java webapps/docs/changelog.xml

2005-11-28 Thread yoavs 
Author: yoavs
Date: Mon Nov 28 13:14:21 2005
New Revision: 349505

URL: http://svn.apache.org/viewcvs?rev=349505&view=rev
Log:
Bugzilla 37212: http://issues.apache.org/bugzilla/show_bug.cgi?id=37212

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Connector.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Connector.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Connector.java?rev=349505&r1=349504&r2=349505&view=diff
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Connector.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Connector.java
 Mon Nov 28 13:14:21 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 1999,2004 The Apache Software Foundation.
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -1088,8 +1088,13 @@
 try {
 protocolHandler.start();
 } catch (Exception e) {
+String errPrefix = "";
+if(this.service != null) {
+errPrefix += "service.getName(): \"" + this.service.getName() 
+ "\"; ";
+}
+
 throw new LifecycleException
-(sm.getString
+(errPrefix + " " + sm.getString
  ("coyoteConnector.protocolHandlerStartFailed", e));
 }
 

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=349505&r1=349504&r2=349505&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Nov 28 13:14:21 2005
@@ -114,6 +114,10 @@
 37132: Have DigestAuthenticator Handle user names with 
commas.  Thanks to 
   Robert Wille for the patch. (yoavs)
   
+  
+37212: Better error reporting in Connector.java.  Thanks to 
Ralf Hauser for
+the patch. (yoavs)
+  
 
   
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37212] - provide better error message upon startup problems

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37212


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 22:14 ---
Done.  Thanks for contributing this patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37671] New: - File Download not working for anchor tags

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37671

   Summary: File Download not working for anchor tags
   Product: Tomcat 4
   Version: 4.1.31
  Platform: PC
OS/Version: Windows Server 2003
Status: NEW
  Severity: normal
  Priority: P2
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


Hello,

  I've encountered a bug with the 4.1.31 version of Tomcat.  Apparently, when 
I use an anchor tag for a file, and I click on the link, it does not show the 
file download message  "Do you want to open or save this file?" with the open 
and save options.  Instead, it displays the file in the browser.  I know you 
could normally save this information from the browser to a file, but I need it 
to show the download message because it's easier for users to save their 
file.  I'm using Internet Explorer version 6, SP2.  I've also tried setting 
the "Confirm open after download" check box for file types to no avail.  It 
use to work in Tomcat 4.1.18.

   Any help would be appreciated.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37672] New: - File Download not working for anchor tags

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37672

   Summary: File Download not working for anchor tags
   Product: Tomcat 4
   Version: 4.1.31
  Platform: PC
OS/Version: Windows Server 2003
Status: NEW
  Severity: normal
  Priority: P2
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


Hello,

  I've encountered a bug with the 4.1.31 version of Tomcat.  Apparently, when 
I use an anchor tag for a file, and I click on the link, it does not show the 
file download message  "Do you want to open or save this file?" with the open 
and save options.  Instead, it displays the file in the browser.  I know you 
could normally save this information from the browser to a file, but I need it 
to show the download message because it's easier for users to save their 
file.  I'm using Internet Explorer version 6, SP2.  I've also tried setting 
the "Confirm open after download" check box for file types to no avail.  It 
use to work in Tomcat 4.1.18.

   Any help would be appreciated.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37671] - File Download not working for anchor tags

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37671





--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 22:46 ---
*** Bug 37672 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37672] - File Download not working for anchor tags

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37672


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 22:46 ---


*** This bug has been marked as a duplicate of 37671 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37671] - File Download not working for anchor tags

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37671


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-11-28 22:47 ---
This is a configuration issue. Please use tomcat-user.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37673] New: - Http11AprProcessor.java - getLocalAddr() returns HostName

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37673

   Summary: Http11AprProcessor.java - getLocalAddr() returns
HostName
   Product: Tomcat 5
   Version: 5.5.12
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: major
  Priority: P2
 Component: Connector:HTTP
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


I have a jsp that uses the getLocalAddr() method for some ssl certificate 
generation utility and it's currently returning the hostname instaed of the IP.

After much digging through the Tomcat source I found the snippet below:

org\apache\coyote\http11\Http11AprProcessor.java

} else if (actionCode == ActionCode.ACTION_REQ_LOCAL_ADDR_ATTRIBUTE) {

// Get local host address
if (localAddr == null) {
try {
long sa = Address.get(Socket.APR_LOCAL, socket);
remoteAddr = Address.getip(sa);
if (Address.fill(addr, sa)) {
localAddr = addr.hostname;
localPort = addr.port;
}
} catch (Exception e) {
log.warn(sm.getString("http11processor.socket.info"), e);
}
}

request.localAddr().setString(localAddr);

}

Should the code above be changed to the snipit below so that the ip address is 
coming back instead of the hostname as expected?


} else if (actionCode == ActionCode.ACTION_REQ_LOCAL_ADDR_ATTRIBUTE) {

// Get local host address
if (localAddr == null) {
try {
long sa = Address.get(Socket.APR_LOCAL, socket);
localAddr = Address.getip(sa);
} catch (Exception e) {
log.warn(sm.getString("http11processor.socket.info"), e);
}
}

request.localAddr().setString(localAddr);

}

If not I would love to know why the hostName/port are being returned instead of 
the IP thanx!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37674] New: - Windows EXE fails to pass spaces in JVMTI -javaagent option

2005-11-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37674

   Summary: Windows EXE fails to pass spaces in JVMTI -javaagent
option
   Product: Tomcat 5
   Version: Unknown
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:Packaging
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


I am trying to configure the Tomcat 5.5.12 Windows EXE to pass a -javaagent 
argument properly. I have found that if the file path for the Javaagent jar has 
spaces then the system won't start correctly. However, if I copy the javaagent 
jar to a location with no spaces in the file path then everything works.

E.g., this Java Option configuration line works:
-javaagent:C:\aspectjweaver.jar

This fails:
-javaagent:C:\Program Files\Apache Software Foundation\Tomcat 5.5
\shared\lib\glassbox\aspectjweaver.jar

With the following output 
[2005-11-28 16:01:31] [409  javajni.c] [error] CreateJavaVM Failed
[2005-11-28 16:01:31] [930  prunsrv.c] [error] Failed initializing java 
C:\Program Files\Apache Software Foundation\Tomcat 5.5\bin\b
ootstrap.jar
[2005-11-28 16:01:31] [1179 prunsrv.c] [error] ServiceStart returned 2

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: getContext() - spec interpretation

2005-11-28 Thread Jan Luehe 
Hi Mark,


Mark Thomas wrote On 11/24/05 11:34,:
> All,
> 
> I have been looking at bug 13040 and reviewing the current 
> getContext() implementation. I saw Remy's comment from some time ago 
> when fixing some related bugs 
> (http://marc.theaimsgroup.com/?l=tomcat-dev&m=106008981803343&w=2) 
> that this would be better if the spec mandated that the parameter 
> passed to getContext() must be an exact match for a context path.
> 
> Having read the 2.4 spec several times I am pretty sure that is does 
> say this, albeit not as directly as it might. I assume (perhaps 
> wrongly) that any changes in this area will generate a lot of debate 
> so I wanted to do the debate and then change the code.
> 
> The key parts of the spec are:
> SRV.14.2.8 ServletContext
> 
> public ServletContext getContext(java.lang.String uripath)
> 
> uripath - a String specifying the context path of another web 
> application in the container.
> 
> 
> My interpretation is:
> SRV.14.2.8 says the parameter is a context path
> SRV.4.4 is very clear about what is context path is
> 
> Therefore, getContext() must look for an exact match of uripath 
> against the context paths for the currently deployed web-apps.
> 
> My proposal, therefore is to change the getContext() implementation to 
> look for an exact match. This is stricter than the current 
> implementation (and may cause problems for some users) but will fix a 
> number of odd behaviours including the one described in bug 13040.
> 
> In the unlikely event that no-one disagrees with my interpretation, 
> I'll commit a fix over the weekend to TC4 and TC5. (The 2.3 spec has 
> the exact same wording.)


I agree the current javadocs of ServletContext.getContext() are
ambiguous, and I agree we need to present this case to the
Servlet EG. Maybe there is a small chance to have this resolved
in the Servlet 2.5 timeframe ...

I think it would be more useful to have the "uripath" argument be
interpreted as a full URI rather than a context root, and have
ServletContext.getContext() determine the longest match of the given
"uripath" with the context roots of any deployed contexts.

Applied to the scenario described at:

  http://marc.theaimsgroup.com/?l=tomcat-dev&m=108109687130165&w=2

which assumes the following configured contexts:

  A: /
  B: /foo/
  C: /foo/bar/

the above interpretation would give the following consistent results:

  Context uripath result
  --
  A   "/" A
  A   "/foo/" B
  A   "/foo/bar/" C
  A   "/foo/bar/xxx/" C

  B   "/" A
  B   "/foo/" B
  B   "/foo/bar/" C
  B   "/foo/bar/xxx/" C

  C   "/" A
  C   "/foo/" B
  C   "/foo/bar/" C
  C   "/foo/bar/xxx/" C

I agree the current behaviour, which "hides" any foreign contexts
whose context roots match a subdir of the current context, is broken
(in part because of the spec ambiguity), because it returns different
results depending on the context from which the getContext() call is
made.

I don't see why we need to restrict "uripath" to be a context root in
order to fix the current behaviour, though. As I said, returning
the context whose context root has the longest match with the given
"uripath" may make more sense.

Would you agree?


Jan

> 
> Mark
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]